Why isn't FEATURE_SH_STANDALONE considered in BB_EXECVP()?

2014-04-02 Thread dietmar.schindler
On the one hand, in shell/ash.c we have: --- static void tryexec(IF_FEATURE_SH_STANDALONE(int applet_no,) char *cmd, char **argv, char **envp) { #if ENABLE_FEATURE_SH_STANDALONE if (applet_no >= 0) { if (APPLET_IS_NOEXEC(applet_no)) { clearenv();

AW: Why isn't FEATURE_SH_STANDALONE considered in BB_EXECVP()?

2014-04-02 Thread dietmar.schindler
> Von: Mason > Gesendet: Mittwoch, 2. April 2014 14:27 > > Dietmar Schindler wrote: [snip] > > Your message is a reply to an existing thread: > > References: > <1396123321-23646-1-git-send-email-drew_mose...@mentor.com> > > > This tricks threading email agents into considering your messa

AW: Possible Unicode Problems in Busybox - Collect and Discussion

2014-08-13 Thread dietmar.schindler
> Von: Harald Becker > Gesendet: Mittwoch, 13. August 2014 19:07 > ... > size_t utf8len( const char* s ) > { >size_t n = 0; >while (*s) > if ((*s++ ^ 0x40) < 0xC0) >n++; >return n; > } > ... > char *utf8skip( char const* s, size_t n ) > { >for ( ; n && *s; --n ) >

AW: [Bug: Busybox 1.22.1] false return 0 instead of 1 with '--help' switch.

2014-09-01 Thread dietmar.schindler
> Von: Laurent Bercot > Gesendet: Samstag, 30. August 2014 11:38 > > POSIX does not specify anything about --help. It's a GNU extension, > like every long option. > > For true or false, POSIX does not specify any option at all: > http://pubs.opengroup.org/onlinepubs/9699919799/utilities/false

AW: AW: [Bug: Busybox 1.22.1] false return 0 instead of 1 with '--help' switch.

2014-09-01 Thread dietmar.schindler
> Von: Laurent Bercot > Gesendet: Montag, 1. September 2014 10:49 > > On 01/09/2014 09:20, dietmar.schind...@manroland-web.com wrote: > > That does not follow. > > http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap01.html#tag_17_04 > > talks in the OPTIONS section about "arbitrary

AW: [PATCH 5/5] Bionic lacks transparent LFS migrations; provide a workaround

2015-04-26 Thread dietmar.schindler
> On Friday, 24 April 2015, at 4:12 am, Matt Whitlock wrote: > > +#if defined(__BIONIC__) && _FILE_OFFSET_BITS == 64 > > The preprocessor needs to test whether _FILE_OFFSET_BITS is defined before > using it in an > expression. That's not true. INTERNATIONAL STANDARD ©ISO/IEC ISO/IEC 9899:201x, Pr

AW: [PATCH 5/5] Bionic lacks transparent LFS migrations; provide a workaround

2015-04-27 Thread dietmar.schindler
> Von: Rich Felker [mailto:dal...@aerifal.cx] > Gesendet: Dienstag, 28. April 2015 01:02 > > On Mon, Apr 27, 2015 at 06:30:59AM +, dietmar.schind...@manroland-web.com > wrote: > > > On Friday, 24 April 2015, at 4:12 am, Matt Whitlock wrote: > > > > +#if defined(__BIONIC__) && _FILE_OFFSET_BITS

AW: [PATCH 5/5] Bionic lacks transparent LFS migrations; provide a workaround

2015-05-04 Thread dietmar.schindler
> Von: Denys Vlasenko [mailto:vda.li...@googlemail.com] > Gesendet: Sonntag, 3. Mai 2015 18:48 > > On Tue, Apr 28, 2015 at 8:36 AM, wrote: > > Whose policy is that which caters to a certain compiler option's inept > > warnings? "What are > the goals of Busybox?" (http://www.busybox.net/FAQ.html#

AW: [RFC/PATCH v2 3/5] libbb: add ends_with() function

2015-08-25 Thread dietmar.schindler
> Von: Tito > Gesendet: Montag, 24. August 2015 21:29 > > On 08/24/2015 12:51 AM, Jody Bruchon wrote: > > On 2015-08-21 17:26, Tito wrote: > >> what sense would it make to check if str\0 ends_with \0 if all strings > >> do end with \0 ? > > > > In this case, I view this as a problem of handling all

AW: [PATCH] modutils.c: update rmmod message for ENOENT error

2015-10-22 Thread dietmar.schindler
> Von: Maxin B. John > Gesendet: Donnerstag, 22. Oktober 2015 12:52 > > When we try to remove a non-existing module: > > $ rmmod nonexisting > rmmod: can't unload 'nonexisting': unknown symbol in module, or unknown > parameter > > man page of "delete_module" says: > ENOENT: No module by that name e

AW: why are init's arguments wiped ?

2016-01-29 Thread dietmar.schindler
> -Ursprüngliche Nachricht- > Von: Laurent Bercot > Gesendet: Freitag, 29. Januar 2016 10:13 > > On 29/01/2016 08:27, Nicolas CARRIER wrote: > > ... > > I'm really interested in knowing which is the real reason behind this > > feature and if there is any chance that a patch would be accepte

AW: why are init's arguments wiped ?

2016-01-31 Thread dietmar.schindler
> -Ursprüngliche Nachricht- > Von: Laurent Bercot > Gesendet: Freitag, 29. Januar 2016 21:10 > >That doesn't change the fact that it's the behaviour of every > init binary since 1970 and that you should come with a better reason if > you want to change it, especially since it's so easy

AW: ifup/down broken!!!

2016-09-27 Thread dietmar.schindler
> Von: David Henderson > Gesendet: Montag, 26. September 2016 17:04 > > ... The script is as follows: > > #!/bin/sh > # > # DEBUG > echo 'resolv.conf' > /tmp/debug.ifup > env >> /tmp/debug.ifup > > # everything below this point was added recently > CONFIG='' > > # this segment was what was causing

AW: Ash wildcard usability bug

2016-10-23 Thread dietmar.schindler
> Von: Denys Vlasenko > Gesendet: Montag, 24. Oktober 2016 01:31 > ... > > On Tue, Oct 18, 2016 at 4:31 PM, Lauri Kasanen wrote: > > The following fails in ash 1.24.1, probably also in git. Works in bash. > > but not in non-interactive bash called as sh! > > Interactive bash: works > Interactive b

AW: Ash wildcard usability bug

2016-10-25 Thread dietmar.schindler
> Von: Lauri Kasanen [mailto:cur...@operamail.com] > Gesendet: Dienstag, 25. Oktober 2016 10:49 > > On Mon, Oct 24, 2016, at 20:09, Denys Vlasenko wrote: > > Note that they allow to consistently never do globbing > > on the redirect word. > > > > To me it looks like the best course of action. > > S

AW: Ash wildcard usability bug

2016-10-25 Thread dietmar.schindler
> Von: Lauri Kasanen [mailto:cur...@operamail.com] > Gesendet: Dienstag, 25. Oktober 2016 19:25 > > > > On Mon, Oct 24, 2016, at 20:09, Denys Vlasenko wrote: > > > > Note that they allow to consistently never do globbing on the > > > > redirect word. > > > > > > > > To me it looks like the best cou

AW: sed bug ?

2016-11-17 Thread dietmar.schindler
> Von: Timo Teras > Gesendet: Donnerstag, 17. November 2016 10:56 > > The following discrepancy happens on 1.25.1 (and git master) with musl > c-library: > > ~ $ echo /usr/lib/ | sed 's,\(^/\|\)[^/][^/]*,..,g' > ../../ > > ~ $ echo /usr/lib/ | busybox sed 's,\(^/\|\)[^/][^/]*,..,g' > /../../ > > An

AW: sed bug ?

2016-11-17 Thread dietmar.schindler
> Von: Timo Teräs > Gesendet: Donnerstag, 17. November 2016 13:23 > > On Thu, 17 Nov 2016 12:08:27 + > wrote: > > > > Von: Timo Teras > > > Gesendet: Donnerstag, 17. November 2016 10:56 > > > > > > The following discrepancy happens on 1.25.1 (and git master) with > > > musl c-library: > > > >

RE: [PATCH v2] bloat-o-meter: line wrapped at 75 columns instead of 80

2024-03-12 Thread dietmar.schindler
> From: busybox On Behalf Of Jones Syue ??? > Sent: Wednesday, March 13, 2024 2:22 AM > > > This patch replaces the 78 "-" prints with 75 "-". And replace the 80 > > columns summary line with 77 columns. ("%s" is considered as two chars > > and should be filled with whitespace " ", so 77 = 75 + 2)

AW: [PATCH] Huge performance boost for recursion (cp, du, find, ls, rm, , mv)

2024-04-10 Thread dietmar.schindler
> Von: busybox Im Auftrag von Jody Bruchon > Gesendet: Mittwoch, 10. April 2024 21:36 > > Bloat-O-Meter: > > function old new delta > … > recursive_action1 420 419 0 > … How comes 419 - 420 = 0? -- Regards, Dietmar Schindler manroland Goss web syste

telnetd setting XTABS

2012-08-02 Thread dietmar.schindler
What is the rationale for BusyBox' telnetd setting XTABS? It has the ugly consequence that the original terminal setting when connecting via telnet is different in comparison to connecting e. g. via serial line or ssh. -- Regards, Dietmar Schindler manrola

[PATCH] hexdump: don't unconditionally limit the usable address range

2013-03-22 Thread dietmar.schindler
For example the command hexdump -s 0xc0216000 /dev/kmem | head -1 outputs hexdump: number 0xc0216000 is not in 0..2147483647 range without the patch, and c0216000 7d61 5b78 4e80 0020 7c08 02a6 9001 0004 with it (compiled with CFLAGS="-D_LARGEFILE_SOURCE -D_FILE_OFFSET_

AW: [PATCH] hexdump: don't unconditionally limit the usable address range

2013-04-02 Thread dietmar.schindler
> Von: Denys Vlasenko [mailto:vda.li...@googlemail.com] > Gesendet: Mittwoch, 27. März 2013 15:19 > > On Fri, Mar 22, 2013 at 2:00 PM, > wrote: > > For example the command > > > > hexdump -s 0xc0216000 /dev/kmem | head -1 > > > > outputs > > > > hexdump: number 0xc0216000 is not i

AW: [PATCH] hexdump: don't unconditionally limit the usable address range

2013-04-02 Thread dietmar.schindler
> -Ursprüngliche Nachricht- > Von: busybox-boun...@busybox.net [mailto:busybox-boun...@busybox.net] > Im Auftrag von dietmar.schind...@manroland-web.com > Gesendet: Dienstag, 2. April 2013 09:54 > > > Von: Denys Vlasenko [mailto:vda.li...@googlemail.com] > > Gesendet: Mittwoch, 27. März 201

AW: New shell command: prlimit

2013-05-22 Thread dietmar.schindler
> Im Auftrag von Joshua Judson Rosen > ... > prlimit takes a PID as a first argument, and then processes the rest of > its arguments identically to ulimit, e.g.: > > prlimit 3431 -c unlimited > > Maybe this is of general interest? Well, I am not general, but to me it sounds interesting. -- R

AW: [PATCH] Convert sscanf to preferred xstrtou conversion.

2013-06-03 Thread dietmar.schindler
> Gesendet: Sonntag, 2. Juni 2013 21:50 > An: busybox@busybox.net > Betreff: [PATCH] Convert sscanf to preferred xstrtou conversion. > > Signed-off-by: Paul B. Henson > --- > miscutils/ubi_tools.c | 20 ++-- > 1 files changed, 14 insertions(+), 6 deletions(-) > > diff --git a/mi

AW: [PATCH] Fix incorrect OS reporting in uname -o

2013-09-18 Thread dietmar.schindler
> Von: Patrick 'P. J.' McDermott > Gesendet: Mittwoch, 18. September 2013 05:48 > > On 2013-09-17 18:56, Rich Felker wrote: > > - strcpy(uname_info.os, "GNU/Linux"); > > + strcpy(uname_info.os, > > +#ifdef __GLIBC__ > > + "GNU/" > > +#endif > > + "Linux"); > > I'd agree that

AW: Information needed - ash

2013-10-25 Thread dietmar.schindler
> Von: Alexander Kriegisch > Gesendet: Freitag, 25. Oktober 2013 12:29 > > Why is everybody answering the same question I have answered before and for > which the author > of the original question has thanked me already? Has my posting somehow not > arrived at the > list? Your posting of 23.10.2

AW: Information needed - ash

2013-10-25 Thread dietmar.schindler
> Von: Alexander Kriegisch [mailto:alexan...@kriegisch.name] > Gesendet: Freitag, 25. Oktober 2013 14:32 > > Actually it was not empty. Whoever owns the list might want to check why my > message was > mutilated. What I had written was: > > >>> /etc/profile > >>> $HOME/.profile > >>> > >>> See http

AW: [PATCH] sed: Document POSIX -E sed flag that selects EREs (as a synonym for -r)

2013-10-30 Thread dietmar.schindler
> Von: Harald Becker > Gesendet: Mittwoch, 30. Oktober 2013 13:34 > > IMO when upstream now uses -E for ERE, shouldn't we just document > -E and drop description of -r (just letting it work hidden for > compatibility, with a source comment to use -E in newer scripts)? > > Why do we need to display

AW: [PATCH] add paste implementation

2017-03-13 Thread dietmar.schindler
> Von: walter harms > Gesendet: Samstag, 11. März 2017 11:05 > > Am 10.03.2017 19:07, schrieb Maxime Coste: > > ... > > +for (int i = 0; i < file_count; ++i) { > > IMHO it is better to put 'int i' in the definition section and remove the int > here. > It make things harder to read (for me), same f

AW: [BUG] 'case' does not match double-quoted backslash

2018-02-12 Thread dietmar.schindler
> Von: Kang-Che Sung > Gesendet: Dienstag, 13. Februar 2018 04:52 > > On Tue, Feb 13, 2018 at 10:34 AM, Martijn Dekker wrote: > > Op 13-02-18 om 03:09 schreef Kang-Che Sung: > >> Just wondering, why using "\z" and not "\\z" ? > >> The former doesn't seem to be a valid syntax. > > > > It is valid,

AW: BUG: grep -v -x -f does not work when pattern file is empty

2018-04-04 Thread dietmar.schindler
> Von: Quentin Rameau > Gesendet: Mittwoch, 4. April 2018 23:29 > … > Hello Luiz, > > > This simple test show the problem: > > > > $ touch a.txt > > $ busybox grep -v -x -f a.txt /etc/passwd | wc -l > > 0 > > > > While gnu grep works: > > > > $ grep -v -x -f a.txt /etc/passwd | wc -l > > 43 > > > >

AW: BUG: grep -v -x -f does not work when pattern file is empty

2018-04-05 Thread dietmar.schindler
> Von: Quentin Rameau > Gesendet: Donnerstag, 5. April 2018 10:24 > > Hello Dietmar, > > > > The standard specifies, for the -f flag: > > > > > > “Patterns in pattern_file shall be terminated by a . A null > > > pattern can be specified by an empty line in pattern_file.” > > > > The above does not

RE: [PATCH] fsck: Fix incorrect handling of child exit

2018-05-25 Thread dietmar.schindler
> -Original Message- > From: busybox [mailto:busybox-boun...@busybox.net] On Behalf Of Niklas > Hambüchen > Sent: Thursday, May 24, 2018 9:51 PM > > … > The way you do it now, using WEXITSTATUS in all cases where it's not > WIFSIGNALED, makes the > assumption that WIFSIGNALED is the preci

RE: [PATCH] Add bc (Last patch)

2018-10-31 Thread dietmar.schindler
> From: busybox On Behalf Of Gavin Howard > Sent: Tuesday, October 30, 2018 12:30 AM > > On Mon, Oct 29, 2018 at 4:46 PM Denys Vlasenko > wrote: > > > > On Mon, Oct 29, 2018 at 4:55 PM Gavin Howard > > wrote: > > >... > > +if (!(v->v = malloc(esize * BC_VEC_START_CAP))) return > > BC_STAT

RE: [PATCH] losetup: Create loop device if it does not exist

2019-09-24 Thread dietmar.schindler
> From: busybox On Behalf Of Joerg Vehlow > Sent: Monday, September 23, 2019 7:39 AM > > util-linux's losetup creates a loop device, if it is missing. > This is missing in busybox's implementation. > > Testcase: > losetup /dev/loop1000 > If /dev/loop1000 does not exist busybox give an error but >

RE: Sime makelike wrapper scripts support

2020-01-13 Thread dietmar.schindler
> From: busybox On Behalf Of Boris Kotov > Sent: Sunday, January 12, 2020 12:10 AM > To: busybox@busybox.net > > … > It would be really handy to have a simple Makefile-like wrapper scripts > syntax just to execute some common commands on it: > > > ``` > > hello: > > echo hello > > build: > >

RE: [PATCH] crontab: Fix -e with editors saving using renaming strategy

2020-07-15 Thread dietmar.schindler
> -Original Message- > From: busybox On Behalf Of Gray Wolf > Sent: Saturday, June 13, 2020 2:01 AM > > Some editors (like vim) use renaming strategy to save file. That means > they save a file to some random name and then rename it to final > location. ... Irrespective of the usefulness

RE: [PATCH] shrink last_char_is function even more

2020-09-02 Thread dietmar.schindler
> -Original Message- > From: busybox On Behalf Of Tito > Sent: Monday, July 20, 2020 1:58 PM > To: busybox@busybox.net > > … > I for myself decided for being defensive and this until today > payed off for my little personal codebase. How have you been able to determine that this "payed of

RE: [PATCH] vi: fix regex search compilation error

2021-07-14 Thread dietmar.schindler
> -Original Message- > From: busybox On Behalf Of Bernhard > Reutner-Fischer > Sent: Wednesday, July 14, 2021 12:51 AM > > On Tue, 13 Jul 2021 21:42:05 +0100 > Ron Yorston wrote: > > > Bernhard Reutner-Fischer wrote: > > >If i'm not mistaken, the s++ is fully redundant here although it s

RE: ash ${str/find/repl} performance

2021-07-21 Thread dietmar.schindler
> From: busybox On Behalf Of Alin Mr > Sent: Monday, July 19, 2021 9:21 PM > > It seems that bash-like pattern substitution is surprisingly slow. Tested > with busybox > 1_33_stable, 1_32_stable, master, Debian/buster busybox-static (all having > the applet-bias > features configured, i.e. FEATU

RE: [PATCH] adding the trap ERR feature

2021-08-18 Thread dietmar.schindler
Hello, Roberto, I appreciate your useful efforts of adding the trap ERR feature. However, please allow me to comment on the LINENO behavior. > From: busybox On Behalf Of Roberto A. Foglietta > Sent: Saturday, August 14, 2021 12:45 AM > > I prepared a test but feel free to improve it. He

RE: wget command does not work

2021-09-21 Thread dietmar.schindler
> From: busybox On Behalf Of Sergey Ponomarev > Sent: Tuesday, September 21, 2021 1:19 PM > > This is a developers list, not a support. Please use > http://StackOverflow.com or any other forums to ask questions: there > is a moderation and a community that is willing to help. StackOverflow.com is