Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Jonathan Morton
> On 7 Mar, 2018, at 11:34 pm, Toke Høiland-Jørgensen wrote: > > Ah, totally missed that those were wrong as well. The values for > dropped, overlimits and requeues are not printed by the cake-specific > code at all, so there is something else dubious going on. Could they be pointer values? -

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Toke Høiland-Jørgensen
Kevin Darbyshire-Bryant writes: >> On 7 Mar 2018, at 12:59, Toke Høiland-Jørgensen wrote: >> >> >>> qdisc cake 8004: root refcnt 4486780 bandwidth 19900Kbit diffserv3 >>> dual-srchost nat rtt 100.0ms ptm overhead 4502152 >>> Sent 42615751 bytes 4491092 pkt (dropped 4491108, overlimits 4491124

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Jonathan Morton
> On 7 Mar, 2018, at 8:27 pm, Kevin Darbyshire-Bryant > wrote: > >> Are you using the latest kernel code? Those values were added in an >> incompatible manner, so if you don't have userspace and kernel code in >> sync they'll be garbage, basically… > > I’m using latest commit on kernel space sc

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Kevin Darbyshire-Bryant
> On 7 Mar 2018, at 18:27, Kevin Darbyshire-Bryant > wrote: > > > >> On 7 Mar 2018, at 12:59, Toke Høiland-Jørgensen wrote: >> >> >>> qdisc cake 8004: root refcnt 4486780 bandwidth 19900Kbit diffserv3 >>> dual-srchost nat rtt 100.0ms ptm overhead 4502152 >>> Sent 42615751 bytes 4491092 p

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Kevin Darbyshire-Bryant
> On 7 Mar 2018, at 12:59, Toke Høiland-Jørgensen wrote: > > >> qdisc cake 8004: root refcnt 4486780 bandwidth 19900Kbit diffserv3 >> dual-srchost nat rtt 100.0ms ptm overhead 4502152 >> Sent 42615751 bytes 4491092 pkt (dropped 4491108, overlimits 4491124 >> requeues 4491152) >> backlog 0b 4

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Dave Taht
On Wed, Mar 7, 2018 at 7:52 AM, Toke Høiland-Jørgensen wrote: > Dave Taht writes: > >> So it sounds like all the individual pieces are sync'd again? >> >> 4.16-rc4 is out, so there are several weeks left to make the net-next >> window. I note that I don't feel strongly (never had) that I should b

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Toke Høiland-Jørgensen
Dave Taht writes: > So it sounds like all the individual pieces are sync'd again? > > 4.16-rc4 is out, so there are several weeks left to make the net-next > window. I note that I don't feel strongly (never had) that I should be > the one to make the net-next submission, just so long as it now ge

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Dave Taht
So it sounds like all the individual pieces are sync'd again? 4.16-rc4 is out, so there are several weeks left to make the net-next window. I note that I don't feel strongly (never had) that I should be the one to make the net-next submission, just so long as it now gets through checkpatch (?)...

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Toke Høiland-Jørgensen
Sebastian Moeller writes: >> diff --git a/tc/q_cake.c b/tc/q_cake.c >> index e21552e8..95301b41 100644 >> --- a/tc/q_cake.c >> +++ b/tc/q_cake.c >> @@ -243,12 +243,22 @@ static int cake_parse_opt(struct qdisc_util *qu, int >> argc, char **argv, >>/* Typical VDSL2 framing schemes,

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Sebastian Moeller
Hi Toke, > On Mar 7, 2018, at 13:59, Toke Høiland-Jørgensen wrote: > > Kevin Darbyshire-Bryant writes: > >> I don’t the column alignment can be correct because the print lines don’t >> include a leading space, so columns can run into each other. >> >> fprintf(f, "%12u", tst->unresponse_flo

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Toke Høiland-Jørgensen
Kevin Darbyshire-Bryant writes: > I don’t the column alignment can be correct because the print lines don’t > include a leading space, so columns can run into each other. > > fprintf(f, "%12u", tst->unresponse_flows); > v > fprintf(f, " %12u", tst->unresponse_flows); > > The header lines are pro

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Kevin Darbyshire-Bryant
I don’t the column alignment can be correct because the print lines don’t include a leading space, so columns can run into each other. fprintf(f, "%12u", tst->unresponse_flows); v fprintf(f, " %12u", tst->unresponse_flows); The header lines are probably wrong. Should be as per https://github.c

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Toke Høiland-Jørgensen
Kevin Darbyshire-Bryant writes: >> On 7 Mar 2018, at 10:31, Toke Høiland-Jørgensen wrote: >> >>> >> >> Please don't put something different into LEDE than what we're working >> on upstreaming. It is difficult enough to keep track of the different >> versions as they are. The tc-adv repo is al

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Toke Høiland-Jørgensen
Kevin Darbyshire-Bryant writes: > There were some useful stats column re-alignment changes as well, > wonder if you got those? Probably not, as that code is not longer directly diff'able, unfortunately... The json-related changes were fairly intrusive... Eyeballing the diff, however, I *think*

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Sebastian Moeller
Hi Kevin, > On Mar 7, 2018, at 12:07, Kevin Darbyshire-Bryant > wrote: > > > >> On 7 Mar 2018, at 10:31, Toke Høiland-Jørgensen wrote: >> >>> >> >> Please don't put something different into LEDE than what we're working >> on upstreaming. It is difficult enough to keep track of the diff

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Kevin Darbyshire-Bryant
There were some useful stats column re-alignment changes as well, wonder if you got those? > On 7 Mar 2018, at 10:36, Toke Høiland-Jørgensen wrote: > > Toke Høiland-Jørgensen writes: > >> Kevin Darbyshire-Bryant writes: >> >>> Hi All, >>> >>> >>> On 7 Mar 2018, at 08:50, Toke Høilan

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Kevin Darbyshire-Bryant
> On 7 Mar 2018, at 10:31, Toke Høiland-Jørgensen wrote: > >> > > Please don't put something different into LEDE than what we're working > on upstreaming. It is difficult enough to keep track of the different > versions as they are. The tc-adv repo is already rebased on the upstream > iproute

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Toke Høiland-Jørgensen
Toke Høiland-Jørgensen writes: > Kevin Darbyshire-Bryant writes: > >> Hi All, >> >> >> >>> On 7 Mar 2018, at 08:50, Toke Høiland-Jørgensen wrote: >>> >>> Jonathan Morton writes: >>> > On 6 Mar, 2018, at 11:06 pm, Toke Høiland-Jørgensen wrote: > > ...on the iproute2 side the onl

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Toke Høiland-Jørgensen
Kevin Darbyshire-Bryant writes: > Hi All, > > > >> On 7 Mar 2018, at 08:50, Toke Høiland-Jørgensen wrote: >> >> Jonathan Morton writes: >> On 6 Mar, 2018, at 11:06 pm, Toke Høiland-Jørgensen wrote: ...on the iproute2 side the only thing missing before we can attempt an u

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Kevin Darbyshire-Bryant
Hi All, > On 7 Mar 2018, at 08:50, Toke Høiland-Jørgensen wrote: > > Jonathan Morton writes: > >>> On 6 Mar, 2018, at 11:06 pm, Toke Høiland-Jørgensen wrote: >>> >>> ...on the iproute2 side the only >>> thing missing before we can attempt an upstream submission is an update >>> of the man

Re: [Cake] [PATCH] q_cake: Update xstats format to use per-tin structure

2018-03-07 Thread Toke Høiland-Jørgensen
Jonathan Morton writes: >> On 6 Mar, 2018, at 11:06 pm, Toke Høiland-Jørgensen wrote: >> >> ...on the iproute2 side the only >> thing missing before we can attempt an upstream submission is an update >> of the man page, as far as I can tell. Any volunteers to do that? :) > > I could look into t