Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

2012-06-08 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105030/#review14508 --- Ship it! That was a fast update. Nice work. Please fix the

Re: Review Request: Additional quick action buttons when mouse is over items, in Stage slides sorter.

2012-06-08 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103538/#review14509 --- One think I noted is that when you select a slide by pressing

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

2012-06-08 Thread Paul Mendez
On June 8, 2012, 7:13 a.m., Thorsten Zachmann wrote: stage/part/animations/strategy/KPrSmilValues.cpp, line 131 http://git.reviewboard.kde.org/r/105030/diff/4/?file=66752#file66752line131 The brackets are not needed please remove. Thanks, I fixed the brackets issue. - Paul

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

2012-06-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105030/#review14511 --- This review has been submitted with commit

Re: Review Request: Adds a page/slide navigator control for the statusbar, used in Stage Flow

2012-06-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105180/#review14514 --- This review has been submitted with commit

Re: Review Request: Adds a page/slide navigator control for the statusbar, used in Stage Flow

2012-06-08 Thread Friedrich W. H. Kossebau
On June 8, 2012, 5:23 a.m., Thorsten Zachmann wrote: Please commit after fixing the details I noticied. If I miss someting on the inline stuff lets discuss it before committing. One thing I noticed which is not due to your code but only visible when your code is there is that if

Re: Review Request: Implemented KexiDBDatePicker

2012-06-08 Thread Oleg Kukharchuk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105179/ --- (Updated June 8, 2012, 5:13 p.m.) Review request for Calligra, Jarosław

Re: Review Request: Additional quick action buttons when mouse is over items, in Stage slides sorter.

2012-06-08 Thread Paul Mendez
On June 8, 2012, 7:24 a.m., Thorsten Zachmann wrote: stage/part/KPrViewModeSlidesSorter.cpp, line 762 http://git.reviewboard.kde.org/r/103538/diff/3/?file=66768#file66768line762 Starting a presentation does not work for me. Not sure what is wrong but I only get an empty white

Re: Review Request: Additional quick action buttons when mouse is over items, in Stage slides sorter.

2012-06-08 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103538/ --- (Updated June 8, 2012, 6:32 p.m.) Review request for Calligra. Changes

Re: Review Request: Adds a page/slide navigator control for the statusbar, used in Stage Flow

2012-06-08 Thread Friedrich W. H. Kossebau
Am Freitag, 8. Juni 2012, 05:23:16 schrieb Thorsten Zachmann: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105180/#review14507 ---

Review Request: Port KexiActionSelectionDialog from Q3

2012-06-08 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105187/ --- Review request for Calligra, Jarosław Staniek and Oleg Kukharchuk.

Re: Review Request: Port KexiActionSelectionDialog from Q3

2012-06-08 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105187/#review14521 --- Good work! If there's some work to do, please commit to your

Re: Review Request: Implemented KexiDBDatePicker

2012-06-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105179/#review14522 --- This review has been submitted with commit

tool tooltips vs. tool titles (was: Re: Review Request: turn the tooltips of all tools consistently into Does something style)

2012-06-08 Thread Friedrich W. H. Kossebau
Am Freitag, 8. Juni 2012, 01:42:41 schrieb C. Boemann: I'm sorry, but I think I also said it should be done individually and with discussions. I was not sure if the not a single patch was meant with regard to the patch at which the discussion happened, so I just created list with all tooltips

Re: Review Request: Slightly improve the option widget of the document background tool

2012-06-08 Thread Friedrich W. H. Kossebau
On June 7, 2012, 2:59 p.m., C. Boemann wrote: libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp, line 31 http://git.reviewboard.kde.org/r/105153/diff/1/?file=66403#file66403line31 Tool tips shouldn't have title case Friedrich W. H. Kossebau wrote: All tools

Re: tool tooltips vs. tool titles (was: Re: Review Request: turn the tooltips of all tools consistently into Does something style)

2012-06-08 Thread C. Boemann
On Saturday 09 June 2012 02:14:40 Friedrich W. H. Kossebau wrote: Am Freitag, 8. Juni 2012, 01:42:41 schrieb C. Boemann: I'm sorry, but I think I also said it should be done individually and with discussions. I was not sure if the not a single patch was meant with regard to the patch at

Re: Review Request: Adds a page/slide navigator control for the statusbar, used in Stage Flow

2012-06-08 Thread Thorsten Zachmann
Hello Friedrich, One thing I noticed which is not due to your code but only visible when your code is there is that if you enter the first/last page in the widget the actions do not get enabled/disabled and therefore it shows the old state of the actions, e.g. when entering the last page