Re: [Care2002-developers] PHP_SELF is evil!

2010-09-16 Thread Ap.Muthu
Hi Robert, Please verify that any Care2x install in a subfolder of a domain like http://www.domain.com/care2x/ will not fail under the current $_SERVER['SCRIPT_NAME']. (hope there is no $_SERVER['SERVER_NAME'] variable since the older $PHP_SELF was essentially $_SERVER['PHP_SELF'] which is a fu

Re: [Care2002-developers] PHP_SELF is evil!

2010-09-16 Thread Robert Meggle
Hi Muthu, That would be great. Tomorrow I will be out - and back somewhere at afternoon. Then I would do the same. There are several things what waste the apache error logs what I want to fix before I go to the front end and what there could be for an issue. Just now I saw that there is a missi

Re: [Care2002-developers] Current Status and Bugs after SVN 6711

2010-09-16 Thread Robert Meggle
Hi Muthu, > Looked at the table and code bindings: > > Persons > All Personell (Employee) are Persons > All Patients are Persons > No Login User is direclty releated to any Person (All users were Employees > earlier, not anymore, the title tag is now a misnomer) I think that has something to do

Re: [Care2002-developers] PHP_SELF is evil!

2010-09-16 Thread Ap.Muthu
OK - we will leave it as is for now - $_SERVER['SERVER_NAME'] stays. Will install afresh and see what happens. Ap.Muthu > Hi Muthu, > > >> Rather than hardcoding the variable $_SERVER['SERVER_NAME'] everywhere, >> we >> can take advantage of the variable $PHP_SELF being globally declared in >>

[Care2002-developers] Current Status and Bugs after SVN 6711

2010-09-16 Thread Ap.Muthu
Hi Robert, Just committed SVN 6711 - a couple of bytes that were different - checked it in hex. Will do a fresh install with theSVN and see what gives. Looked at the table and code bindings: Persons All Personell (Employee) are Persons All Patients are Persons No Login User is direclty releated

Re: [Care2002-developers] PHP_SELF is evil!

2010-09-16 Thread Robert Meggle
Hi Muthu, > Rather than hardcoding the variable $_SERVER['SERVER_NAME'] everywhere, we > can take advantage of the variable $PHP_SELF being globally declared in > AdoDB - just one place! If you are very sure of the consequences of > $_SERVER['PHP_SELF'], then all we need to do is to re-assign

Re: [Care2002-developers] PHP_SELF is evil!

2010-09-16 Thread Robert Meggle
Hi Muthu, > The value of some unicode characters have got mangled during your change in > line 10 of file: > modules/news/includes/inc_newstitle_clean.php Luckily I found the original chars on other backup's, because that would be impossible to redefine. Committed, should be in the TRUNK reposit

Re: [Care2002-developers] PHP_SELF is evil!

2010-09-16 Thread Ap.Muthu
Hi Robert, Rather than hardcoding the variable $_SERVER['SERVER_NAME'] everywhere, we can take advantage of the variable $PHP_SELF being globally declared in AdoDB - just one place! If you are very sure of the consequences of $_SERVER['PHP_SELF'], then all we need to do is to re-assign the vari

Re: [Care2002-developers] PHP_SELF is evil!

2010-09-16 Thread Robert Meggle
Hi Muthu, Yes, I saw that as well. Either in adodb there are such variables as well in some other files what I let out for the moment. But for the check if the file is called direct (that would represent an intrusion) it should be corrected. I know that the $_SERVER['SCRIPT_NAME'] will not make p

Re: [Care2002-developers] SVN upto 6708 - submenu_row_spacer.tpl exclusion

2010-09-16 Thread Robert Meggle
Hi Muthu, Yes, that I did. The reason was that submenu_row_spacer.tpl had an ../../ reference to pixel.gif what fits to modules, but not to login.php stored in main. All in all there was no bug, it was just producing apache error logs. Now that is what I try to catch here as well. That pixel.g

Re: [Care2002-developers] PHP_SELF is evil!

2010-09-16 Thread Ap.Muthu
Hi Robert, Please check the need to replace $PHP_SELF and revert it if needed. The said variable is a clean value of $_SERVER['PHP_SELF'] and in some instances made as $thisfle. It is globally declared in AdoDB: classes/adodb/adodb-pager.inc.php (lines 60/63) classes/adodb/adodb-perf.inc.php (lin

[Care2002-developers] SVN upto 6708 - submenu_row_spacer.tpl exclusion

2010-09-16 Thread Ap.Muthu
Hi Robert, You have corrected the path to pixel.gif in /gui/smarty_template/templates/default/main/common/submenu_row_spacer.tpl Any reason the above file chosen to be removed from inclusion in: /gui/smarty_template/templates/default/main/login_config.tpl So long the menu looked good without the

Re: [Care2002-developers] what is your idea about ...

2010-09-16 Thread Robert Meggle
Hi Tim, Exactly. But these are two topics when we look more in detail. Topic 1: What fields must be there, and Topic 2: What fields must be mandatory. Topic 2 is more easy. When we focus now a main branch what is public, then it should be have some standard settings. I am not that sure that in

Re: [Care2002-developers] what is your idea about ...

2010-09-16 Thread Robert Meggle
Hi Tim, Exactly. But these are two topics when we look more in detail. Topic 1: What fields must be there, and Topic 2: What fields must be mandatory. Topic 2 is more easy. When we focus now a main branch what is public, then it should be have some standard settings. I am not that sure that in

Re: [Care2002-developers] what is your idea about ...

2010-09-16 Thread Tim Schofield
Robert, I strongly believe that the registration screen should be as configurable as possible. As we both know, hospitals in different parts of the world have very different requirements for what data they need to acquire at registration. Thanks Tim On 16 September 2010 15:02, Robert Meggle wr

[Care2002-developers] what is your idea about ...

2010-09-16 Thread Robert Meggle
revision 6707, class_gui_person_show.php, line 370: [...] if (!$GLOBAL_CONFIG['person_insurance_1_nr_hide']&&$insurance_show&& $insurance_nr){ [...] And brings me to the question what fields must be mandatory at registration and admission. Please feel free to answer ;-) Thanks Robert -- --

Re: [Care2002-developers] Latest SVN 6700 trunk Download

2010-09-16 Thread Ap.Muthu
Hi GJ, "Hardly Working" in English means "Not Working at all" "Working Hard" is the right phrase here! Regards, Ap.Muthu > > hi Tim, > > Muthu and Robert are hardly working on releasing an 2.6.1 demo very > shortly > > gj. > On 2010-09-16 10:58.PD, Tim Schofield wrote: >> But maybe it wo

Re: [Care2002-developers] Latest SVN 6700 trunk Download

2010-09-16 Thread Tim Schofield
Hi Gjergj, Are we talking about an online demo, or one we can download and play with? Thanks Tim On 16 September 2010 10:00, Gjergj Sheldija wrote: > > hi Tim, > > Muthu and Robert are hardly working on releasing an 2.6.1 demo very shortly > > gj. > On 2010-09-16 10:58.PD, Tim Schofield wrote:

Re: [Care2002-developers] Latest SVN 6700 trunk Download

2010-09-16 Thread Robert Meggle
Hi Tim, We are working on 2.6.1. stable. Then we can also think to focus the so called "gettext" branch as 2.7 alpha. ;-) http://sourceforge.net/apps/trac/care2002/roadmap Robert Am Donnerstag, den 16.09.2010, 11:00 +0200 schrieb Gjergj Sheldija: > hi Tim, > > Muthu and Robert are hardly work

Re: [Care2002-developers] Latest SVN 6700 trunk Download

2010-09-16 Thread Robert Meggle
Hi Gjergj, Am Donnerstag, den 16.09.2010, 10:14 +0200 schrieb Gjergj Sheldija: > for the migration to php 5x , you might need this : > https://sourceforge.net/apps/trac/care2002/wiki/MigrateToPHP5x Yes, this is already done. But it would not check for non declared variables. Most I fixed now I t

Re: [Care2002-developers] Latest SVN 6700 trunk Download

2010-09-16 Thread Gjergj Sheldija
hi Tim, Muthu and Robert are hardly working on releasing an 2.6.1 demo very shortly gj. On 2010-09-16 10:58.PD, Tim Schofield wrote: > But maybe it would be good to release a 2.6 alpha, or beta release. > That tends to encourage testing in my experience. > > Tim > > > On 16 September 2010 09:07,

Re: [Care2002-developers] Latest SVN 6700 trunk Download

2010-09-16 Thread Tim Schofield
But maybe it would be good to release a 2.6 alpha, or beta release. That tends to encourage testing in my experience. Tim On 16 September 2010 09:07, Robert Meggle wrote: > Hi Muthu, > > You are never sleeping like me it seems :-D > > I have tested around yesterday a bit the ACL. Here I would s

Re: [Care2002-developers] Latest SVN 6700 trunk Download

2010-09-16 Thread Gjergj Sheldija
for the migration to php 5x , you might need this : https://sourceforge.net/apps/trac/care2002/wiki/MigrateToPHP5x gj, -- Start uncovering the many advantages of virtual appliances and start using them to simplify appl

Re: [Care2002-developers] Latest SVN 6700 trunk Download

2010-09-16 Thread Robert Meggle
Hi Muthu, You are never sleeping like me it seems :-D I have tested around yesterday a bit the ACL. Here I would suggest to simplify the process, because for now it is not understandable just for user what must be done. All other sections seems to work. For an release I would also first work i

[Care2002-developers] Latest SVN 6700 trunk Download

2010-09-16 Thread Ap.Muthu
Hi, http://care2002.svn.sourceforge.net/viewvc/care2002/care2x/trunk/?view=tar That will get the latest (currently SVN 6700) on v2.6+ trunk. It will be okay to place this under downloads (currently absent) section of www.care2x.org . Regards, Ap.Muthu > hi, > > you should use the trunk > > gj

Re: [Care2002-developers] SVN 6699 file bugs

2010-09-16 Thread Gjergj Sheldija
hi, you should use the trunk gj. On 2010-09-15 10:54.MD, Tim Schofield wrote: > Hi, > > Should we be using the gettext branch or the trunk? > > Thanks > Tim > > > On 15 September 2010 21:44, Ap.Muthu wrote: >> Hi Robert, >> >> Please pull a fresh one from SVN. That way if there are any delete