Code Review Gig

2012-05-03 Thread Brian Thornton
Hi guys, I have some code going to print (public scrutiny) and wanted to see if anyone was available for hourly code review. This isn't a formal job but something you would be paid for. Should have experience in CFCs, constructors, cfscript, MVC, REST, mime types, ORM and CSRF Thanks

Re: Coldfusion Code Review Tool

2011-01-13 Thread dev losh
Hey ! Thanks all for the Responses. I will try all these and will update in this thread. Thanks Devlosh ~| Order the Adobe Coldfusion Anthology now!

Coldfusion Code Review Tool

2011-01-11 Thread dev losh
Can anyone recommend any good tool that can be used for Coldfusion Code Reviews? I tried Sonar but could'nt find coldfusion plugin for the same. Thanks, Devlosh ~| Order the Adobe Coldfusion Anthology now!

Re: Coldfusion Code Review Tool

2011-01-11 Thread Russ Michaels
Hi, Have a look at his http://www.google.com/enterprise/marketplace/viewListing?productListingId=5143210+12982233047309328439 If you do not have a google apps account then you can signup for a free one at www.cfmldeveloper.com -- Russ Michaels www.bluethunderinternet.com : Business hosting

Re: Coldfusion Code Review Tool

2011-01-11 Thread Steven Durette
I believe codecop is still available on riaforge.org. Sent from my iPhone On Jan 11, 2011, at 5:48 AM, dev losh devl...@gmail.com wrote: Can anyone recommend any good tool that can be used for Coldfusion Code Reviews? I tried Sonar but could'nt find coldfusion plugin for the same.

Re: Coldfusion Code Review Tool

2011-01-11 Thread Will Tomlinson
Can anyone recommend any good tool that can be used for Coldfusion Code Reviews? I tried Sonar but could'nt find coldfusion plugin for the same. I built one a couple of years back. You'd need to have some knowledge of Regexs to use it. It uses a MySQL DB.

Re: Code Review?

2010-02-11 Thread Glyn Jackson
yep the error was because of a users firewall not sending the http_referer so the value was - which mid function does not like. ~| Want to reach the ColdFusion community with something they want? Let them know on the House of

Code Review?

2010-02-10 Thread Glyn Jackson
I have been asked to looked as some code within this page is below. I have no idea what its doing however I was told its needed but keeps giving me errors. is your opinion why does this exists? cfparam name=referer_itemID default=0 cfparam name=referer_popupID default=0 cfif

Re: Code Review?

2010-02-10 Thread William Seiter
without seeing the context of the code, it appears to be holding values that may be used for 'tracking' the user on the site. What is the error that you are receiving from it? -- William E. Seiter On Feb 10, 2010, Glyn Jackson glyn.jack...@newebia.co.uk wrote: I have been asked to

re: Code Review?

2010-02-10 Thread Jason Fisher
All this code is doing is setting 2 variables, based on values that existed in the user's previous request, as tracked in cgi.http_referer. referer_itemID: holds the value of a url param called item_id: or '0' if the param is invalid or missing or '-1' if there is already a variable called

re: Code Review?

2010-02-10 Thread Al Musella, DPM
Does it always cause an error or just sometimes? If it is sometimes, it might be the browser not sending the http_referer.. try using cfparam on it. At 12:23 PM 2/10/2010, you wrote: All this code is doing is setting 2 variables, based on values that existed in the user's previous request,

RE: Code Review?

2010-02-10 Thread brad
CGI scoped variables always exist. #cgi.I_like_cheese_burgers# should return an empty string-- unless of course, there is a web server out there that implements that variable. :) ~Brad Original Message Subject: re: Code Review? From: Al Musella, DPM muse

Re: Code Review?

2010-02-10 Thread Charlie Stell
, there is a web server out there that implements that variable. :) ~Brad Original Message Subject: re: Code Review? From: Al Musella, DPM muse...@virtualtrials.com Date: Wed, February 10, 2010 12:17 pm To: cf-talk cf-talk@houseoffusion.com Does it always cause an error

Re: CFCs, Scopes Thread Safety code review

2009-01-01 Thread Glyn Jackson
yes thats where query in the add to cart comes into play, from now on when they add an item I check to see if it is active AND active = 'on' lol anyhow again thank for the help :) ~| Adobe® ColdFusion® 8 software 8 is the most

Re: CFCs, Scopes Thread Safety code review

2009-01-01 Thread s. isaac dealey
yes thats where query in the add to cart comes into play, from now on when they add an item I check to see if it is active AND active = 'on' lol anyhow again thank for the help :) I figured that was the case, but that still doesn't eliminate the race condition. The cart lives for the

Re: CFCs, Scopes Thread Safety code review

2009-01-01 Thread Glyn Jackson
I figured that was the case, but that still doesn't eliminate the race condition. The cart lives for the duration of their session, which is like 20 minutes or so. So the item that was active when they added it to their cart could become inactive at any time after it's added and before they check

Re: CFCs, Scopes Thread Safety code review

2008-12-31 Thread Glyn Jackson
Hi again Isaac, you just hit the nail on the head, the query given is just 1 of hundreds in that CFC but the problem of the user deleting a category happen sometime back. Halloween products after the season had ended and a customer placed an order they should not. I put it down to a catching

Re: CFCs, Scopes Thread Safety code review

2008-12-31 Thread s. isaac dealey
Hi again Isaac, you just hit the nail on the head, the query given is just 1 of hundreds in that CFC but the problem of the user deleting a category happen sometime back. Halloween products after the season had ended and a customer placed an order they should not. I put it down to a catching

CFCs, Scopes Thread Safety code review

2008-12-30 Thread Glyn Jackson
I am currently on a performance crusade and have been rewriting lots of my current projects. One of the biggest changes as a result has been the way I architect my applications. I have started to use the application scope to cache commonly used components. For example...

Re: CFCs, Scopes Thread Safety code review

2008-12-30 Thread Matt Quackenbush
On Tue, Dec 30, 2008 at 5:36 AM, Glyn Jackson wrote: application.appObjs = structNew(); application.appObjs.securitySQLcfc = createObject(component,components.security); application.appObjs.commomSQLcfc = createObject(component,components.common-sql); Just to make sure it's clear, that

Re: CFCs, Scopes Thread Safety code review

2008-12-30 Thread Glyn Jackson
Sorry it was not clear about how I was catching. The CFCs are indeed created inside the onApplicationStart function (application.cfc) Also re traffic: it's not a large amount I would agree, but for a small ecommerce store it does handle £50,000 of orders per month so for them that traffic is

Re: CFCs, Scopes Thread Safety code review

2008-12-30 Thread Matt Quackenbush
On Tue, Dec 30, 2008 at 11:46 AM, Glyn Jackson wrote: Also re traffic: it's not a large amount I would agree, but for a small ecommerce store it does handle £50,000 of orders per month so for them that traffic is very valuable and the cart and order system all written in CF must be working

Re: CFCs, Scopes Thread Safety code review

2008-12-30 Thread Jason Fisher
Glyn, Hal Helms (http://www.halhelms.com/) offers some solid info on OO with CF and you can also explore Ben Nadel's journey down the OO road (http://www.bennadel.com/blog/). In addition, check out ColdBox or Model-Glue for OO frameworks that are pure CF.

Re: CFCs, Scopes Thread Safety code review

2008-12-30 Thread Glyn Jackson
@ Jason: thanks for the links I will check them out. I have been learning ColdBox over the last few months. It was cool until I found out half way into my project I could not call the layout without the handler. I don't that defeats the point of MVC but I needed it to brake the rules just once

Re: CFCs, Scopes Thread Safety code review

2008-12-30 Thread s. isaac dealey
Someone else probably already mentioned this. The productmenu function is not thread safe, although it's not a huge issue. Each time the function executes it places the query result in the variables scope of the cfc, which isn't where you want it generally speaking... However, the danger with this

RE: MSSQL 2000 Code review and best practices

2007-07-12 Thread Dharmendar Kumar
://www.daksatech.com Subject: MSSQL 2000 Code review and best practices From: DURETTE, STEVEN J (ATTASIAIT) Date: Tue, 10 Jul 2007 07:54:20 -0400 Thread: http://www.houseoffusion.com/groups/cf-talk/thread.cfm/threadid:52463#283381 Hey all, For quite a while now, the group I work in has been doing code

Re: MSSQL 2000 Code review and best practices

2007-07-12 Thread dk
://www.daksatech.com Hey all, For quite a while now, the group I work in has been doing code reviews of our ColdFusion code through the use of a code review tool to pick up the major stuff, then peer review to get the logic/other problems. Now we have to start doing it for SQL code. Does anyone

Re: MSSQL 2000 Code review and best practices

2007-07-12 Thread dk
://www.daksatech.com Hey all, For quite a while now, the group I work in has been doing code reviews of our ColdFusion code through the use of a code review tool to pick up the major stuff, then peer review to get the logic/other problems. Now we have to start doing it for SQL code. Does anyone

OT: MSSQL 2000 Code review and best practices

2007-07-10 Thread DURETTE, STEVEN J (ATTASIAIT)
Hey all, For quite a while now, the group I work in has been doing code reviews of our ColdFusion code through the use of a code review tool to pick up the major stuff, then peer review to get the logic/other problems. Now we have to start doing it for SQL code. Does anyone know of any code

Code Review

2006-03-16 Thread Mehdi, Agha
Hi Guys, We need to have ColdFusion code for one of our applications reviewed/analyzed. Can you please recommend professionals who do that? Thanks Agha Mehdi IDT - eBusiness Program Manager Work: 408.284.8239 Cell : 209.275.0482 Fax : 408.284.2766

RE: Code Review

2006-03-16 Thread Kevin Aebig
Probably 3/4 of the people on this list are more than qualified, depending on what specifically you're looking for. !k -Original Message- From: Mehdi, Agha [mailto:[EMAIL PROTECTED] Sent: March 16, 2006 1:53 PM To: CF-Talk Subject: Code Review Hi Guys, We need to have ColdFusion code

Re: Code Review

2006-03-16 Thread Michael Traher
We use brainbench http://www.brainbench.com/xml/bb/business/hiring/hireemployees.xml for all our candidates as a first test, followed by a practical test at the interview (we get them to write some code). The brainbench test gives an accurate assessment of CF knowledge and is time limited. On

RE: Code Review

2006-03-16 Thread Mehdi, Agha
through the application and point out deficiencies (if any). Thanks Agha Mehdi IDT - eBusiness Program Manager -Original Message- From: Michael Traher [mailto:[EMAIL PROTECTED] Sent: Thursday, March 16, 2006 1:18 PM To: CF-Talk Subject: Re: Code Review We use brainbench http

Re: Code Review

2006-03-16 Thread Jerry Johnson
Does Allaire/Macromedia/Adobe still have a unit that does this? Didn't Allaire have a testing facility and engineers available? On 3/16/06, Mehdi, Agha [EMAIL PROTECTED] wrote: Michael, I don't want experienced analysts go through the brainbench test. One of our vendors developed our

Re: Code Review

2006-03-16 Thread Michael Traher
] Sent: Thursday, March 16, 2006 1:18 PM To: CF-Talk Subject: Re: Code Review We use brainbench http://www.brainbench.com/xml/bb/business/hiring/hireemployees.xml for all our candidates as a first test, followed by a practical test at the interview (we get them to write some code

RE: Code Review

2006-03-16 Thread Munson, Jacob
You might check out About Web, or contact Simon Horwith directly. I've heard him mention that their company does code reviews. -Original Message- From: Mehdi, Agha [mailto:[EMAIL PROTECTED] Sent: March 16, 2006 1:53 PM Hi Guys, We need to have ColdFusion code for one of our

RE: Code Review

2006-03-16 Thread Munson, Jacob
Here's Simon's blog: http://www.horwith.com/ -Original Message- From: Munson, Jacob Sent: Thursday, March 16, 2006 4:31 PM You might check out About Web, or contact Simon Horwith directly. I've heard him mention that their company does code reviews. -Original

Re: Code Review

2006-03-16 Thread Adam Churvis
[EMAIL PROTECTED] To: CF-Talk cf-talk@houseoffusion.com Sent: Thursday, March 16, 2006 2:53 PM Subject: Code Review Hi Guys, We need to have ColdFusion code for one of our applications reviewed/analyzed. Can you please recommend professionals who do that? Thanks Agha Mehdi IDT - eBusiness

I need a code review

2002-09-12 Thread Chris Edwards
Hi I'm rather new to CF and have written a basic site architecture. I would like if someone would review it, preferably someone with alot of experience. I need to know if I'm on the right track and if there are any fatal flaws to my design. If you wish be of assitance, then email me

Looping Over Structures - Help and Peer Code Review Request

2002-08-19 Thread Chris Montgomery
Howdy Cf-Talk, I am building a job search agent that will send scheduled emails to job seekers based on their matching criteria they input when setting up their search agent. When a job seeker creates the agent, they must select at least one category of interest. When the scheduled agent runs,

Re: Looping Over Structures - Help and Peer Code Review Request

2002-08-19 Thread Chris Montgomery
In case anyone is interested in taking a look, I've posted the dump of the structures here: http://www.airtightweb.com/test/searchagentdump.htm As you can see from that, Jobcatlist holds the categories a job seeker is interested in and Joblist holds any active jobs in those categories, for each

Code review, PLEASE

2001-03-19 Thread Mike
I have to be missing something: and I cant put my mouse on it !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" html head CFPARAM Name="ID" Default=1 titleInterview 2/title /head CFQUERY NAME="selectcandidate"

RE: Code review, PLEASE

2001-03-19 Thread Paul Ihrig
essage- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 2:27 PM To: CF-Talk Subject: Code review, PLEASE I have to be missing something: and I cant put my mouse on it !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" !--- include toolbar.cfm--- cf

RE: Code review, PLEASE

2001-03-19 Thread Phoeun Pha
It would be best if u can tell us what the problem is and what ua re tyring to get the page to do. then i can understand the code better -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 1:27 PM To: CF-Talk Subject: Code review, PLEASE I have

Re: Code review, PLEASE

2001-03-19 Thread Mike
ing that you think should so we don't have to guess. :) -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 11:27 AM To: CF-Talk Subject: Code review, PLEASE I have to be missing something: and I cant put my mouse on it !DOCTYPE HTML PUBLIC &qu

RE: Code review, PLEASE

2001-03-19 Thread Savan Thongvanh
glad you said that, i was feeling kind of dense "Dylan Bromby" [EMAIL PROTECTED] on 03/19/2001 01:39:53 PM Please respond to [EMAIL PROTECTED] To: CF-Talk [EMAIL PROTECTED] cc:(bcc: Savan Thongvanh/DSM/Seabury) Subject: RE: Code review, PLEASE why don't you p

Re: Code review, PLEASE

2001-03-19 Thread Mike
Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 2:27 PM To: CF-Talk Subject: Code review, PLEASE I have to be missing something: and I cant put my mouse on it !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" !--- include to

Re: Code review, PLEASE

2001-03-19 Thread Greg Wolfinger
whats the error that you are getting with this code? - Original Message - From: "Mike" [EMAIL PROTECTED] To: "CF-Talk" [EMAIL PROTECTED] Sent: Monday, March 19, 2001 2:26 PM Subject: Code review, PLEASE I have to be missing something: and I cant put my mouse on

RE: Code review, PLEASE

2001-03-19 Thread Hayes, David
selectCandidate is your query name; a query can't be converted to a string. You may want one of your query column names instead. -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 2:01 PM To: CF-Talk Subject: Re: Code review, PLEASE This is what I

RE: Code review, PLEASE

2001-03-19 Thread Robert Long
I don't see any query that is updating anything in the code you sent. -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 1:51 PM To: CF-Talk Subject: Re: Code review, PLEASE Sorry bout that: This is the error Error Occurred While Processing Request

RE: Code review, PLEASE

2001-03-19 Thread Howarth, Craig (IBK-NY)
iginal Message- From: Mike [SMTP:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 3:01 PM To: CF-Talk Subject: Re: Code review, PLEASE This is what I get now with the ## Error Occurred While Processing Request Error Diagnostic Information Expression result cannot

RE: Code review, PLEASE

2001-03-19 Thread Robert Long
ue="#id" ... rest of code... /cfoutput -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 2:01 PM To: CF-Talk Subject: Re: Code review, PLEASE This is what I get now with the ## Error Occurred While Processing Request Error Diagnostic In

Code review PLEASE

2001-03-15 Thread Mike
This is really making me go bald, I have a page that has next and previous, and when viewed locally I can see everything, when I ftp to my host (and yes the odbc is working and correct) I can only see the first record, and nothing after that. I have tried putting the database(access) in the

RE: Code review PLEASE

2001-03-15 Thread Sicular, Alexander
, March 15, 2001 2:00 PM To: CF-Talk Subject: Code review PLEASE This is really making me go bald, I have a page that has next and previous, and when viewed locally I can see everything, when I ftp to my host (and yes the odbc is working and correct) I can only see the first record

Re: Code review PLEASE

2001-03-15 Thread Mike
;news:010001c0ad87$6836dcb0$[EMAIL PROTECTED]... You have a maxrows = 1 on the query. $.02 - Original Message - From: "Mike" [EMAIL PROTECTED] To: "CF-Talk" [EMAIL PROTECTED] Sent: Thursday, March 15, 2001 12:59 PM Subject: Code review PLEASE This is really making me

Re: Code review PLEASE

2001-03-15 Thread Deanna L. Schneider
Are you trying to have the user page through one record at a time? Cause that's what you're going to get with this. You'll only ever get one user whose id equals the passed id ---snip--- WHERE ID=#ID# What I think you want is something like the following (quickly cut from existing code, so

RE: Code review PLEASE

2001-03-15 Thread Stephenie Hamilton
, March 15, 2001 2:47 PM To: CF-Talk Subject: Re: Code review PLEASE Your the second one to say that, but locally everything works fine, if I turn the max rows off then I will see all the records and I only want to see one record at time Michael "Cami Lawson" [EMAIL PROTEC

Re: Code review PLEASE

2001-03-15 Thread David E. Crawford
From: "Mike" [EMAIL PROTECTED] To: "CF-Talk" [EMAIL PROTECTED] Sent: Thursday, March 15, 2001 14:46 Subject: Re: Code review PLEASE Your the second one to say that, but locally everything works fine, if I turn the max rows off then I will see all the records and I only want to see

Re: Code review PLEASE

2001-03-15 Thread Mike
ent: Thursday, March 15, 2001 12:59 PM Subject: Code review PLEASE This is really making me go bald, I have a page that has next and previous, and when viewed locally I can see everything, when I ftp to my host (and yes the odbc is working and correct) I can only see the first record, and

RE: Code review PLEASE

2001-03-15 Thread Douglas Malcolm
t a string, and is in fact a number after you increment it. Douglas Malcolm -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Thursday, March 15, 2001 11:47 AM To: CF-Talk Subject: Re: Code review PLEASE Your the second one to say that, but locally everything works fine,

Re: Code review PLEASE

2001-03-15 Thread Judith Campbell
At 02:46 PM 3/15/01 -0500, you wrote: Your the second one to say that, but locally everything works fine, if I turn the max rows off then I will see all the records and I only want to see one record at time Michael The problem isn't with maxrows, it's with ID. the cfparam statement isn't

RE: Code review PLEASE

2001-03-15 Thread Adkins, Randy
Put CFOUTPTUT around the CFSET for your NEXT/PREV variables Your MAXROWS=1 is fine -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Thursday, March 15, 2001 2:47 PM To: CF-Talk Subject: Re: Code review PLEASE Your the second one to say that, but locally everything works

Re: Code review PLEASE

2001-03-15 Thread Jason Lotz
Take maxrows out of the cfquery and add it to the cfoutput along with a startrow attribute. Jason - Original Message - From: "Mike" [EMAIL PROTECTED] To: "CF-Talk" [EMAIL PROTECTED] Sent: Thursday, March 15, 2001 12:46 PM Subject: Re: Code review PLEASE Your t

Re: Code review PLEASE

2001-03-15 Thread Mike
logies, Inc. want CF_Freedom? try CFXHosting.com -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Thursday, March 15, 2001 2:47 PM To: CF-Talk Subject: Re: Code review PLEASE Your the second one to say that, but locally everything works fine, if I turn the m

Re: Code review PLEASE

2001-03-15 Thread Jon Hall
ata here td align="left"a href="default2.cfm?ID=#PrevID#"Previous/a/td td align="right"a href="default2.cfm?ID=#NextID#"Next/a/td /cfoutput This will work even without caching, but might as well make it quicker. jon - Original Message - From: "Mik

Re: Code review PLEASE

2001-03-15 Thread Mike
, March 15, 2001 2:47 PM To: CF-Talk Subject: Re: Code review PLEASE Your the second one to say that, but locally everything works fine, if I turn the max rows off then I will see all the records and I only want to see one record at time Michael "Cami Lawson" [EMAIL

Re: Code review PLEASE

2001-03-15 Thread Mike
="default2.cfm?ID=#PrevID#"Previous/a/td td align="right"a href="default2.cfm?ID=#NextID#"Next/a/td /cfoutput This will work even without caching, but might as well make it quicker. jon - Original Message - From: "Mike" [EMAIL PROTECTED] To: &q