Code Review Gig
Hi guys, I have some code going to print (public scrutiny) and wanted to see if anyone was available for hourly code review. This isn't a formal job but something you would be paid for. Should have experience in CFCs, constructors, cfscript, MVC, REST, mime types, ORM and CSRF Thanks ~| Order the Adobe Coldfusion Anthology now! http://www.amazon.com/Adobe-Coldfusion-Anthology/dp/1430272155/?tag=houseoffusion Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:350983 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/groups/cf-talk/unsubscribe.cfm
Re: Coldfusion Code Review Tool
Hey ! Thanks all for the Responses. I will try all these and will update in this thread. Thanks Devlosh ~| Order the Adobe Coldfusion Anthology now! http://www.amazon.com/Adobe-Coldfusion-Anthology/dp/1430272155/?tag=houseoffusion Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:340730 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/groups/cf-talk/unsubscribe.cfm
Coldfusion Code Review Tool
Can anyone recommend any good tool that can be used for Coldfusion Code Reviews? I tried Sonar but could'nt find coldfusion plugin for the same. Thanks, Devlosh ~| Order the Adobe Coldfusion Anthology now! http://www.amazon.com/Adobe-Coldfusion-Anthology/dp/1430272155/?tag=houseoffusion Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:340622 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/groups/cf-talk/unsubscribe.cfm
Re: Coldfusion Code Review Tool
Hi, Have a look at his http://www.google.com/enterprise/marketplace/viewListing?productListingId=5143210+12982233047309328439 If you do not have a google apps account then you can signup for a free one at www.cfmldeveloper.com -- Russ Michaels www.bluethunderinternet.com : Business hosting services solutions www.cfmldeveloper.com: ColdFusion developer community www.michaels.me.uk : my blog www.cfsearch.com : ColdFusion search engine ** *skype me* : russmichaels ~| Order the Adobe Coldfusion Anthology now! http://www.amazon.com/Adobe-Coldfusion-Anthology/dp/1430272155/?tag=houseoffusion Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:340623 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/groups/cf-talk/unsubscribe.cfm
Re: Coldfusion Code Review Tool
I believe codecop is still available on riaforge.org. Sent from my iPhone On Jan 11, 2011, at 5:48 AM, dev losh devl...@gmail.com wrote: Can anyone recommend any good tool that can be used for Coldfusion Code Reviews? I tried Sonar but could'nt find coldfusion plugin for the same. Thanks, Devlosh ~| Order the Adobe Coldfusion Anthology now! http://www.amazon.com/Adobe-Coldfusion-Anthology/dp/1430272155/?tag=houseoffusion Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:340624 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/groups/cf-talk/unsubscribe.cfm
Re: Coldfusion Code Review Tool
Can anyone recommend any good tool that can be used for Coldfusion Code Reviews? I tried Sonar but could'nt find coldfusion plugin for the same. I built one a couple of years back. You'd need to have some knowledge of Regexs to use it. It uses a MySQL DB. http://willtomlinson.wordpress.com/2008/07/03/announcing-code-scanner-10/ Will ~| Order the Adobe Coldfusion Anthology now! http://www.amazon.com/Adobe-Coldfusion-Anthology/dp/1430272155/?tag=houseoffusion Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:340630 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/groups/cf-talk/unsubscribe.cfm
Re: Code Review?
yep the error was because of a users firewall not sending the http_referer so the value was - which mid function does not like. ~| Want to reach the ColdFusion community with something they want? Let them know on the House of Fusion mailing lists Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:330583 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4
Code Review?
I have been asked to looked as some code within this page is below. I have no idea what its doing however I was told its needed but keeps giving me errors. is your opinion why does this exists? cfparam name=referer_itemID default=0 cfparam name=referer_popupID default=0 cfif len(cgi.HTTP_REFERER) !--- Item ID --- cfset begin_itemID = find(item_id:,cgi.HTTP_REFERER) + 8 / cfif begin_itemID cfset end_itemID = find(/,cgi.HTTP_REFERER,begin_itemID) / cfset referer_itemID = mid(cgi.HTTP_REFERER,begin_itemID,end_itemID-begin_itemID) / /cfif !--- MP ID --- cfset begin_mpID = find(mp_id:,cgi.HTTP_REFERER) + 6 / cfif begin_mpID cfset end_mpID = find(/,cgi.HTTP_REFERER,begin_mpID) / cfset referer_popupID = mid(cgi.HTTP_REFERER,begin_mpID,end_mpID-begin_mpID) / /cfif cfif not isNumeric(referer_itemID) cfset referer_itemID = 0 / /cfif cfif not isNumeric(referer_popupID) cfset referer_popupID = 0 / /cfif cfparam name=livewireLaunch default=0 cfif livewireLaunch cfset referer_itemID = -1 / /cfif /cfif ~| Want to reach the ColdFusion community with something they want? Let them know on the House of Fusion mailing lists Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:330531 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4
Re: Code Review?
without seeing the context of the code, it appears to be holding values that may be used for 'tracking' the user on the site. What is the error that you are receiving from it? -- William E. Seiter On Feb 10, 2010, Glyn Jackson glyn.jack...@newebia.co.uk wrote: I have been asked to looked as some code within this page is below. I have no idea what its doing however I was told its needed but keeps giving me errors. is your opinion why does this exists? cfparam name=referer_itemID default=0 cfparam name=referer_popupID default=0 cfif len(cgi.HTTP_REFERER) !--- Item ID --- cfset begin_itemID = find(item_id:,cgi.HTTP_REFERER) + 8 / cfif begin_itemID cfset end_itemID = find(/,cgi.HTTP_REFERER,begin_itemID) / cfset referer_itemID = mid(cgi.HTTP_REFERER,begin_itemID,end_itemID-begin_itemID) / /cfif !--- MP ID --- cfset begin_mpID = find(mp_id:,cgi.HTTP_REFERER) + 6 / cfif begin_mpID cfset end_mpID = find(/,cgi.HTTP_REFERER,begin_mpID) / cfset referer_popupID = mid(cgi.HTTP_REFERER,begin_mpID,end_mpID-begin_mpID) / /cfif cfif not isNumeric(referer_itemID) cfset referer_itemID = 0 / /cfif cfif not isNumeric(referer_popupID) cfset referer_popupID = 0 / /cfif cfparam name=livewireLaunch default=0 cfif livewireLaunch cfset referer_itemID = -1 / /cfif /cfif ~| Want to reach the ColdFusion community with something they want? Let them know on the House of Fusion mailing lists Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:330535 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=11502.10531.4
re: Code Review?
All this code is doing is setting 2 variables, based on values that existed in the user's previous request, as tracked in cgi.http_referer. referer_itemID: holds the value of a url param called item_id: or '0' if the param is invalid or missing or '-1' if there is already a variable called livewireLaunch set to non-zero referer_popupID: hold the value of a url param called mp_id: or '0' if the param is invalid or missing ~| Want to reach the ColdFusion community with something they want? Let them know on the House of Fusion mailing lists Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:330536 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4
re: Code Review?
Does it always cause an error or just sometimes? If it is sometimes, it might be the browser not sending the http_referer.. try using cfparam on it. At 12:23 PM 2/10/2010, you wrote: All this code is doing is setting 2 variables, based on values that existed in the user's previous request, as tracked in cgi.http_referer. referer_itemID: holds the value of a url param called item_id: or '0' if the param is invalid or missing or '-1' if there is already a variable called livewireLaunch set to non-zero referer_popupID: hold the value of a url param called mp_id: or '0' if the param is invalid or missing ~| Want to reach the ColdFusion community with something they want? Let them know on the House of Fusion mailing lists Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:330543 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4
RE: Code Review?
CGI scoped variables always exist. #cgi.I_like_cheese_burgers# should return an empty string-- unless of course, there is a web server out there that implements that variable. :) ~Brad Original Message Subject: re: Code Review? From: Al Musella, DPM muse...@virtualtrials.com Date: Wed, February 10, 2010 12:17 pm To: cf-talk cf-talk@houseoffusion.com Does it always cause an error or just sometimes? If it is sometimes, it might be the browser not sending the http_referer.. try using cfparam on it. ~| Want to reach the ColdFusion community with something they want? Let them know on the House of Fusion mailing lists Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:330545 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4
Re: Code Review?
Id put my money on it somtimes not finding / - so your end is 0, your start is 0, and your getting a negative with mid On Wed, Feb 10, 2010 at 1:23 PM, b...@bradwood.com wrote: CGI scoped variables always exist. #cgi.I_like_cheese_burgers# should return an empty string-- unless of course, there is a web server out there that implements that variable. :) ~Brad Original Message Subject: re: Code Review? From: Al Musella, DPM muse...@virtualtrials.com Date: Wed, February 10, 2010 12:17 pm To: cf-talk cf-talk@houseoffusion.com Does it always cause an error or just sometimes? If it is sometimes, it might be the browser not sending the http_referer.. try using cfparam on it. ~| Want to reach the ColdFusion community with something they want? Let them know on the House of Fusion mailing lists Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:330560 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4
Re: CFCs, Scopes Thread Safety code review
yes thats where query in the add to cart comes into play, from now on when they add an item I check to see if it is active AND active = 'on' lol anyhow again thank for the help :) ~| Adobe® ColdFusion® 8 software 8 is the most important and dramatic release to date Get the Free Trial http://ad.doubleclick.net/clk;207172674;29440083;f Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:317310 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=11502.10531.4
Re: CFCs, Scopes Thread Safety code review
yes thats where query in the add to cart comes into play, from now on when they add an item I check to see if it is active AND active = 'on' lol anyhow again thank for the help :) I figured that was the case, but that still doesn't eliminate the race condition. The cart lives for the duration of their session, which is like 20 minutes or so. So the item that was active when they added it to their cart could become inactive at any time after it's added and before they check out. -- s. isaac dealey ^ new epoch isn't it time for a change? ph: 781.769.0723 http://onTap.riaforge.org/blog ~| Adobe® ColdFusion® 8 software 8 is the most important and dramatic release to date Get the Free Trial http://ad.doubleclick.net/clk;207172674;29440083;f Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:317320 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4
Re: CFCs, Scopes Thread Safety code review
I figured that was the case, but that still doesn't eliminate the race condition. The cart lives for the duration of their session, which is like 20 minutes or so. So the item that was active when they added it to their cart could become inactive at any time after it's added and before they check out. very true. ~| Adobe® ColdFusion® 8 software 8 is the most important and dramatic release to date Get the Free Trial http://ad.doubleclick.net/clk;207172674;29440083;f Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:317321 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4
Re: CFCs, Scopes Thread Safety code review
Hi again Isaac, you just hit the nail on the head, the query given is just 1 of hundreds in that CFC but the problem of the user deleting a category happen sometime back. Halloween products after the season had ended and a customer placed an order they should not. I put it down to a catching issue at the time. ~| Adobe® ColdFusion® 8 software 8 is the most important and dramatic release to date Get the Free Trial http://ad.doubleclick.net/clk;207172674;29440083;f Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:317287 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4
Re: CFCs, Scopes Thread Safety code review
Hi again Isaac, you just hit the nail on the head, the query given is just 1 of hundreds in that CFC but the problem of the user deleting a category happen sometime back. Halloween products after the season had ended and a customer placed an order they should not. I put it down to a catching issue at the time. Ahh... seasonal items... yeah, that would make it more likely... but although I would still recommend adding the var in that function, it won't eliminate the race condition in that case. You'll still need to check the item(s) individually when they're added to the cart and probably again when the user reaches the checkout if you want to handle all the possible race-condition scenarios with that. If the guy puts something in his cart and is shopping around for a few minutes while the item is removed from the inventory, then he'll still get to the checkout with the item unless you do some kind of check and tell him woops, this was removed from the inventory. Although personally my preference would be not to remove anything from the cart, like, unless they actually ran out of stock and needed to give him a store credit or a refund, once it's in the cart, I would consider it set until he checks out -- no price changes, etc. Because he agreed to the price when he added it to the cart. If he agreed to 8 and then he reaches the check out and it's 10 or 12 or whatever, he's liable to be unhappy about that and consider it poor service. -- s. isaac dealey ^ new epoch isn't it time for a change? ph: 781.769.0723 http://onTap.riaforge.org/blog ~| Adobe® ColdFusion® 8 software 8 is the most important and dramatic release to date Get the Free Trial http://ad.doubleclick.net/clk;207172674;29440083;f Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:317296 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4
CFCs, Scopes Thread Safety code review
I am currently on a performance crusade and have been rewriting lots of my
current projects. One of the biggest changes as a result has been the way I
architect my applications. I have started to use the application scope to cache
commonly used components. For example...
===
application.appObjs = structNew();
application.appObjs.securitySQLcfc =
createObject(component,components.security);
application.appObjs.commomSQLcfc =
createObject(component,components.common-sql);
===
I recently posted a comment on a blog regarding this when the CF Guru himself
Mr Sean Corfield recommend if I was going to do this, it was possible I could
run into some thread safety issues. Now I have to be honest, I read about this
a year or so back but never really paid attention. However it does have me
worried a little now. From my understanding... because I create my CFCs in the
application scope the CFCâs are treated just like other applications vars ie.
everyone shares it and the issue comes because this could include scopes and
variables in CFCs not VAR-declare. The word singleton was mention, from my JAVA
days I remember this as being an object created once but it can't be
instantiated elsewhere in the application, well if thatâs correct then that
was my desire right?
Ok, on the question, honestlol
A clients website gets around 5k of traffic a day and I have already cache some
commonly used components however this was before Mr Sean Corfield reminder on
CFCs, Scopes Thread Safety! I have not had any reported issues with the site.
I am being naive or lucky?
For example, most of the components are just simple SQL statement which I only
want as a singleton, why create the object every time? I also donât think
CFCs, Scopes Thread Safety would be an issue here, is this correct or not?
example code...
===
cffunction name=getProductMenu returntype=query hint=returns product
menu
cfquery name=productquery datasource=#application.appConfig.dbSource#
username=#application.appConfig.dbUsername#
password=#application.appConfig.dbPassword#
SELECT s.storeId, s.name as storeName, s.metaDescription as storeMeta,
s.pos, d.depId, d.name as depName, d.metaDescription as depMeta, d.pos, c.name
as catName, c.metaDescription as catMeta, c.catId, (SELECT COUNT(*) as proCount
FROM products p WHERE p.catId = c.catId AND p.active != 'off') as empt
FROM stores s
LEFT JOIN departments d on s.storeId = d.storeId
LEFT JOIN categories c on d.depId = c.depId
AND (SELECT COUNT(*) as proCount FROM products p WHERE p.catId = c.catId
AND p.active != 'off') 0
/cfquery
cfreturn productquery
/cffunction
===
The only one code that does concern me is my cart cfc, originally if it was in
a include and I have only just added it to a components, yes its a little messy
at the moment but it works. I have had not issues but if someone could look at
it :)
sorry it long
===
cffunction name=addtoCart access=public hint=adds a new item to the cart
!--- if cart session does not exist, create it ---
cfif not structkeyexists(session,cartItem)
cflock timeout=60 type=exclusive
cfset session['cartItem'] = structnew()
/cflock
/cfif
!---gets option id's from product form---
cfif structkeyexists(FORM, optVal) AND FORM['optVal'] GT 0 AND
FORM['optVal'] NEQ
cfset productOptionId0 = Arraynew(1)
cfset val = #form.optVal# - 1
cfloop from=0 to=#val# index=this
cfset Vsel = form.sel0
cfif isDefined('form.sel0')
cfset formval = Evaluate(form.sel this)
cfset optvals = ListFirst(formval,*)
/cfif
cfset ArrayAppend( productOptionId0, #optvals# ) /
/cfloop
cfset optionList = ArrayToList(productOptionId0)
cfoutput #optionList#
cfparam name=form.productOptionId default=#optionList#,
/cfoutput
/cfif
!--- if cart item does not exist, create it ---
cfif structkeyexists(form,productid) and form['productid'] neq and
structkeyexists(form,qty) and form['qty'] gt 0
!--- create default node for product id ---
cfset itemNode = pCode_#form['productid']#_1
!--- if no node exists for the given product, create it. ---
cfif not structkeyexists(session['cartItem'],itemNode)
!--- define new node as a struct ---
cfset session['cartItem'][itemNode] = structnew()
cfset session['cartItem'][itemNode]['aQty'] = form['qty']
!--- grab the product info based on id ---
cfquery name=getProd datasource=#application.appConfig.dbSource#
username=#application.appConfig.dbUsername#
Re: CFCs, Scopes Thread Safety code review
On Tue, Dec 30, 2008 at 5:36 AM, Glyn Jackson wrote: application.appObjs = structNew(); application.appObjs.securitySQLcfc = createObject(component,components.security); application.appObjs.commomSQLcfc = createObject(component,components.common-sql); Just to make sure it's clear, that code above, by itself, does not cache anything. If you are using Application.cfc, then it would need to be placed inside of onApplicationStart() in order to be cached. If you are using Application.cfm, then you would need to place it inside of a check to make sure the variables do not exist. For example: cfif NOT structKeyExists(application, appObjs) !--- create the objects here --- /cfif A clients website gets around 5k of traffic a day and I have already cache some commonly used components however this was before Mr Sean Corfield reminder on CFCs, Scopes Thread Safety! I have not had any reported issues with the site. I am being naive or lucky? 5k a day is very little traffic, in terms of large scale applications. Having no issues/bugs with that amount of traffic is not, in my opinion, a good judge of the application's safety. For example, most of the components are just simple SQL statement which I only want as a singleton, why create the object every time? I also don't think CFCs, Scopes Thread Safety would be an issue here, is this correct or not? example code... If the object is shared amongst the entire application, and only needed once, then yes, create it once and cache it. But it still has to be thread safe. ;-) cffunction name=getProductMenu returntype=query hint=returns product menu cfquery name=productquery datasource=#application.appConfig.dbSource# username=#application.appConfig.dbUsername# password=#application.appConfig.dbPassword# SELECT s.storeId, s.name as storeName, s.metaDescription as storeMeta, s.pos, d.depId, d.name as depName, d.metaDescription as depMeta, d.pos, c.name as catName, c.metaDescription as catMeta, c.catId, (SELECT COUNT(*) as proCount FROM products p WHERE p.catId = c.catId AND p.active != 'off') as empt FROM stores s LEFT JOIN departments d on s.storeId = d.storeId LEFT JOIN categories c on d.depId = c.depId AND (SELECT COUNT(*) as proCount FROM products p WHERE p.catId = c.catId AND p.active != 'off') 0 /cfquery cfreturn productquery /cffunction ^ That is *not* thread safe. While you'd probably get away with it since it is not using any client-supplied variables, it still is not thread safe. You need to var *all* variables that are not part of the object's properties. cffunction name=getProductMenu cfset var productquery = / cfquery name=productquery !-- the query --- /cfquery cfreturn productquery / /cffunction ^ Now we're thread safe. Another point, not necessarily related to thread safety, but more of a best practices thing. You don't really want your objects directly referencing things that are outside of them, such as your datasource information. This information should really be passed into the object when it is created. For example... application.appObjs.securitySQLcfc = createObject(component,components.security).init(dbSource: application.appConfig.dbSource, dbUsername: application.appConfig.dbUsername, dbPassword: application.appConfig.dbPassword); Note that we've added an init() method to the object creation, and are passing in three arguments for our datasource information. Now, inside of the CFC we'll add an init() method. cffunction name=init hint=I initialize the object returntype=any output=false access=public cfargument name=dbSource type=string required=true / cfargument name=dbUsername type=string required=true / cfargument name=dbPassword type=string required=true / cfscript variables.dbSource = arguments.dbSource; variables.dbUsername = arguments.dbUsername; variables.dbPassword = arguments.dbPassword; return this; /cfscript /cffunction One note to make about the returntype of the init() method. In the example I used 'any', but in reality I would use the class type of the object. So, let's say that your CFC is named 'foo.cfc', I would use returntype=foo. Now that we have passed in our datasource information, we can alter our queries to use it rather than going outside of the object to get data. This is key to encapsulation. So our productquery would now look like so: cfquery name=productquery datasource=#variables.dbSource# username=#variables.dbUsername# password=#variables.dbPassword# !--- query here --- /cfquery You can leave off the variables. if you'd like, but it would be better to leave it there so that you know where those are coming from when looking back at the code later. Now then, I would also recommend studying about using getters and setters, sometimes referred to as accessors and mutators. But for the sake of simplicity and not overwhelming you all at once, I
Re: CFCs, Scopes Thread Safety code review
Sorry it was not clear about how I was catching. The CFCs are indeed created inside the onApplicationStart function (application.cfc) Also re traffic: it's not a large amount I would agree, but for a small ecommerce store it does handle £50,000 of orders per month so for them that traffic is very valuable and the cart and order system all written in CF must be working correctly. ..NET and jsp is normally my bag but over the last few years CF has been the love of my life (donât tell the wife) Thank for the examples Matt, I really do appreciate all the help I am giving. I am glad I was pointed in this direction and posted here. I just needed some examples to understand what Sean Corfield was saying and I got it. The encapsulation advice was excellent, I was not aware you could e.g foo as the return type. I understand the principles of encapsulation, inheritance, polymorphism etc from my JAVA 2.0 classes back many years back but was not aware that most of these concepts (term used loosely) could be applied in CF i.e object-oriented design patterns (please not on hit me, because I said the word OO and CF) I would really like any links to books and articles so I can learn more on CFCs and OO design patterns in CF and how to apply them using CFCs (ps all I know currently has been self-taught from blogs and Ben Fortaâs books) Anyway back to the point: if i var-declare all variables regardless, i should be ok, right? again thanks Matt have been a big help ~| Adobe® ColdFusion® 8 software 8 is the most important and dramatic release to date Get the Free Trial http://ad.doubleclick.net/clk;207172674;29440083;f Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:317272 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=11502.10531.4
Re: CFCs, Scopes Thread Safety code review
On Tue, Dec 30, 2008 at 11:46 AM, Glyn Jackson wrote: Also re traffic: it's not a large amount I would agree, but for a small ecommerce store it does handle £50,000 of orders per month so for them that traffic is very valuable and the cart and order system all written in CF must be working correctly. I was not knocking 5k of traffic. Most websites don't see that in an entire lifetime. I was just pointing out that it should not be used as a measurement of an application's security. :-) I would really like any links to books and articles so I can learn more on CFCs and OO design patterns in CF and how to apply them using CFCs (ps all I know currently has been self-taught from blogs and Ben Forta's books) I don't know of any OO+CF books out there off the top of my head. Most are written to cater to other languages such as Java. Those same principles can (and should) be applied to CF though. Anyway back to the point: if i var-declare all variables regardless, i should be ok, right? Any variable that is not shared between methods should be var'd, yes. ~| Adobe® ColdFusion® 8 software 8 is the most important and dramatic release to date Get the Free Trial http://ad.doubleclick.net/clk;207172674;29440083;f Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:317273 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=11502.10531.4
Re: CFCs, Scopes Thread Safety code review
Glyn, Hal Helms (http://www.halhelms.com/) offers some solid info on OO with CF and you can also explore Ben Nadel's journey down the OO road (http://www.bennadel.com/blog/). In addition, check out ColdBox or Model-Glue for OO frameworks that are pure CF. ~| Adobe® ColdFusion® 8 software 8 is the most important and dramatic release to date Get the Free Trial http://ad.doubleclick.net/clk;207172674;29440083;f Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:317274 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4
Re: CFCs, Scopes Thread Safety code review
@ Jason: thanks for the links I will check them out. I have been learning ColdBox over the last few months. It was cool until I found out half way into my project I could not call the layout without the handler. I don't that defeats the point of MVC but I needed it to brake the rules just once and it was not versatile to do so. The reason for this was a SOAP request where the page including the view needed to be retuned over HTTP by a .NET application (and a gateway in CF). I am sure thats another post altogether lol. @ Matt: I know what you meant in ref to the traffic and application lol. I am very impressed with CF, it has taken a lot of work to make the application accessible and to integrate with there current systems but CF and XML work together very well. PS have i given up on the backend for accessibility CF + EXT 2.0 = not accessibility! again thanks for all your help I am sure I will be posting more here now :) ~| Adobe® ColdFusion® 8 software 8 is the most important and dramatic release to date Get the Free Trial http://ad.doubleclick.net/clk;207172674;29440083;f Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:317275 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4
Re: CFCs, Scopes Thread Safety code review
Someone else probably already mentioned this. The productmenu function is not thread safe, although it's not a huge issue. Each time the function executes it places the query result in the variables scope of the cfc, which isn't where you want it generally speaking... However, the danger with this particular race condition for the moment is small. It might result in someone getting a menu that contains a category that doesn't have any products in it, or not containing one that does. But also in this case, even if you elminate the race condition within the function, the end result of the user seeing a slightly incorrect menu would still exist because the race condition is also created again by the nature of the web. A guy hits the page, gets the menu and then off somewhere else the client deletes that category. But the user still has the page open in their browser and when they click the link, bang! They come to a page that may or may not work because the category doesn't exist or maybe doesn't have any products in it. But this is the kind of race condition that a lot of applications have and rarely becomes an issue because well, for starters the people using the site have to do several things at the same time and while selecting a category is common, deleting one is not. So right off the bat, you're not likely to see the result of the race condition very often, because someone has to delete a category or deactivate its last product first and that rarely happens. And then even on the rare occasion on which all these events line up just right, I'm not sure how many people will actually report the error or the page that's not working to the store. Often it's not so important to them and just going somewhere else is easier. So yeah, in that case, the fact that you're not having problems is kind of coincidental. If we're talking about best practice on the other hand, you always want to use a cfset var queryname = 0 / before every query in your CFCs. -- s. isaac dealey ^ new epoch isn't it time for a change? ph: 781.769.0723 http://onTap.riaforge.org/blog ~| Adobe® ColdFusion® 8 software 8 is the most important and dramatic release to date Get the Free Trial http://ad.doubleclick.net/clk;207172674;29440083;f Archive: http://www.houseoffusion.com/groups/cf-talk/message.cfm/messageid:317278 Subscription: http://www.houseoffusion.com/groups/cf-talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4
RE: MSSQL 2000 Code review and best practices
You can try Microsoft Best Practices Analyzer Tool for Microsoft SQL Server 2000 http://www.microsoft.com/downloads/details.aspx?FamilyID=b352eb1f-d3ca-44ee- 893e-9e07339c1f22displaylang=en hth, Dharmendar Kumar Email/ Fax Communications: http://www.realmagnet.com Web Development: http://www.daksatech.com Subject: MSSQL 2000 Code review and best practices From: DURETTE, STEVEN J (ATTASIAIT) Date: Tue, 10 Jul 2007 07:54:20 -0400 Thread: http://www.houseoffusion.com/groups/cf-talk/thread.cfm/threadid:52463#283381 Hey all, For quite a while now, the group I work in has been doing code reviews of our ColdFusion code through the use of a code review tool to pick up the major stuff, then peer review to get the logic/other problems. Now we have to start doing it for SQL code. Does anyone know of any code review tool for SQL Server stored procedures? How about any best practices for sql code? Thanks, Steve ~| ColdFusion MX7 by Adobe® Dyncamically transform webcontent into Adobe PDF with new ColdFusion MX7. Free Trial. http://www.adobe.com/products/coldfusion?sdid=RVJV Archive: http://www.houseoffusion.com/groups/CF-Talk/message.cfm/messageid:283580 Subscription: http://www.houseoffusion.com/groups/CF-Talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=11502.10531.4
Re: MSSQL 2000 Code review and best practices
You can try Microsoft Best Practices Analyzer Tool for Microsoft SQL Server 2000 http://www.microsoft.com/downloads/details.aspx?FamilyID=b352eb1f-d3ca-44ee-893e-9e07339c1f22displaylang=en hth, Dharmendar Kumar Email/ Fax Communications: http://www.realmagnet.com Web Development: http://www.daksatech.com Hey all, For quite a while now, the group I work in has been doing code reviews of our ColdFusion code through the use of a code review tool to pick up the major stuff, then peer review to get the logic/other problems. Now we have to start doing it for SQL code. Does anyone know of any code review tool for SQL Server stored procedures? How about any best practices for sql code? Thanks, Steve ~| ColdFusion MX7 and Flex 2 Build sales marketing dashboard RIAâs for your business. Upgrade now http://www.adobe.com/products/coldfusion/flex2?sdid=RVJT Archive: http://www.houseoffusion.com/groups/CF-Talk/message.cfm/messageid:283585 Subscription: http://www.houseoffusion.com/groups/CF-Talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4
Re: MSSQL 2000 Code review and best practices
You can try Microsoft Best Practices Analyzer Tool for Microsoft SQL Server 2000 http://www.microsoft.com/downloads/details.aspx?FamilyID=b352eb1f-d3ca-44ee-893e-9e07339c1f22displaylang=en hth, Dharmendar Kumar Email/ Fax Communications: http://www.realmagnet.com Web Development: http://www.daksatech.com Hey all, For quite a while now, the group I work in has been doing code reviews of our ColdFusion code through the use of a code review tool to pick up the major stuff, then peer review to get the logic/other problems. Now we have to start doing it for SQL code. Does anyone know of any code review tool for SQL Server stored procedures? How about any best practices for sql code? Thanks, Steve ~| Deploy Web Applications Quickly across the enterprise with ColdFusion MX7 Flex 2 Free Trial http://www.adobe.com/products/coldfusion/flex2/?sdid=RVJU Archive: http://www.houseoffusion.com/groups/CF-Talk/message.cfm/messageid:283592 Subscription: http://www.houseoffusion.com/groups/CF-Talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=11502.10531.4
OT: MSSQL 2000 Code review and best practices
Hey all, For quite a while now, the group I work in has been doing code reviews of our ColdFusion code through the use of a code review tool to pick up the major stuff, then peer review to get the logic/other problems. Now we have to start doing it for SQL code. Does anyone know of any code review tool for SQL Server stored procedures? How about any best practices for sql code? Thanks, Steve ~| Create Web Applications With ColdFusion MX7 Flex 2. Build powerful, scalable RIAs. Free Trial http://www.adobe.com/products/coldfusion/flex2/?sdid=RVJS Archive: http://www.houseoffusion.com/groups/CF-Talk/message.cfm/messageid:283381 Subscription: http://www.houseoffusion.com/groups/CF-Talk/subscribe.cfm Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=11502.10531.4
Code Review
Hi Guys, We need to have ColdFusion code for one of our applications reviewed/analyzed. Can you please recommend professionals who do that? Thanks Agha Mehdi IDT - eBusiness Program Manager Work: 408.284.8239 Cell : 209.275.0482 Fax : 408.284.2766 ~| Message: http://www.houseoffusion.com/lists.cfm/link=i:4:235566 Archives: http://www.houseoffusion.com/cf_lists/threads.cfm/4 Subscription: http://www.houseoffusion.com/lists.cfm/link=s:4 Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4 Donations Support: http://www.houseoffusion.com/tiny.cfm/54
RE: Code Review
Probably 3/4 of the people on this list are more than qualified, depending on what specifically you're looking for. !k -Original Message- From: Mehdi, Agha [mailto:[EMAIL PROTECTED] Sent: March 16, 2006 1:53 PM To: CF-Talk Subject: Code Review Hi Guys, We need to have ColdFusion code for one of our applications reviewed/analyzed. Can you please recommend professionals who do that? Thanks Agha Mehdi IDT - eBusiness Program Manager Work: 408.284.8239 Cell : 209.275.0482 Fax : 408.284.2766 ~| Message: http://www.houseoffusion.com/lists.cfm/link=i:4:235572 Archives: http://www.houseoffusion.com/cf_lists/threads.cfm/4 Subscription: http://www.houseoffusion.com/lists.cfm/link=s:4 Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4 Donations Support: http://www.houseoffusion.com/tiny.cfm/54
Re: Code Review
We use brainbench http://www.brainbench.com/xml/bb/business/hiring/hireemployees.xml for all our candidates as a first test, followed by a practical test at the interview (we get them to write some code). The brainbench test gives an accurate assessment of CF knowledge and is time limited. On 3/16/06, Mehdi, Agha [EMAIL PROTECTED] wrote: Hi Guys, We need to have ColdFusion code for one of our applications reviewed/analyzed. Can you please recommend professionals who do that? Thanks Agha Mehdi -- Mike T Blog http://www.socialpoints.com/ ~| Message: http://www.houseoffusion.com/lists.cfm/link=i:4:235580 Archives: http://www.houseoffusion.com/cf_lists/threads.cfm/4 Subscription: http://www.houseoffusion.com/lists.cfm/link=s:4 Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=11502.10531.4 Donations Support: http://www.houseoffusion.com/tiny.cfm/54
RE: Code Review
Michael, I don't want experienced analysts go through the brainbench test. One of our vendors developed our application and it's all CF and AJAX built around their JADX framework. We have been noticing some performance issues, which are irregular. We want someone experienced in this area to go through the application and point out deficiencies (if any). Thanks Agha Mehdi IDT - eBusiness Program Manager -Original Message- From: Michael Traher [mailto:[EMAIL PROTECTED] Sent: Thursday, March 16, 2006 1:18 PM To: CF-Talk Subject: Re: Code Review We use brainbench http://www.brainbench.com/xml/bb/business/hiring/hireemployees.xml for all our candidates as a first test, followed by a practical test at the interview (we get them to write some code). The brainbench test gives an accurate assessment of CF knowledge and is time limited. On 3/16/06, Mehdi, Agha [EMAIL PROTECTED] wrote: Hi Guys, We need to have ColdFusion code for one of our applications reviewed/analyzed. Can you please recommend professionals who do that? Thanks Agha Mehdi -- Mike T Blog http://www.socialpoints.com/ ~| Message: http://www.houseoffusion.com/lists.cfm/link=i:4:235588 Archives: http://www.houseoffusion.com/cf_lists/threads.cfm/4 Subscription: http://www.houseoffusion.com/lists.cfm/link=s:4 Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4 Donations Support: http://www.houseoffusion.com/tiny.cfm/54
Re: Code Review
Does Allaire/Macromedia/Adobe still have a unit that does this? Didn't Allaire have a testing facility and engineers available? On 3/16/06, Mehdi, Agha [EMAIL PROTECTED] wrote: Michael, I don't want experienced analysts go through the brainbench test. One of our vendors developed our application and it's all CF and AJAX built around their JADX framework. We have been noticing some performance issues, which are irregular. We want someone experienced in this area to go through the application and point out deficiencies (if any). ~| Message: http://www.houseoffusion.com/lists.cfm/link=i:4:235589 Archives: http://www.houseoffusion.com/cf_lists/threads.cfm/4 Subscription: http://www.houseoffusion.com/lists.cfm/link=s:4 Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=11502.10531.4 Donations Support: http://www.houseoffusion.com/tiny.cfm/54
Re: Code Review
sorry - I read 'applicants' instead of applications On 3/16/06, Mehdi, Agha [EMAIL PROTECTED] wrote: Michael, I don't want experienced analysts go through the brainbench test. One of our vendors developed our application and it's all CF and AJAX built around their JADX framework. We have been noticing some performance issues, which are irregular. We want someone experienced in this area to go through the application and point out deficiencies (if any). Thanks Agha Mehdi IDT - eBusiness Program Manager -Original Message- From: Michael Traher [mailto:[EMAIL PROTECTED] Sent: Thursday, March 16, 2006 1:18 PM To: CF-Talk Subject: Re: Code Review We use brainbench http://www.brainbench.com/xml/bb/business/hiring/hireemployees.xml for all our candidates as a first test, followed by a practical test at the interview (we get them to write some code). The brainbench test gives an accurate assessment of CF knowledge and is time limited. On 3/16/06, Mehdi, Agha [EMAIL PROTECTED] wrote: Hi Guys, We need to have ColdFusion code for one of our applications reviewed/analyzed. Can you please recommend professionals who do that? Thanks Agha Mehdi -- Mike T Blog http://www.socialpoints.com/ ~| Message: http://www.houseoffusion.com/lists.cfm/link=i:4:235592 Archives: http://www.houseoffusion.com/cf_lists/threads.cfm/4 Subscription: http://www.houseoffusion.com/lists.cfm/link=s:4 Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=11502.10531.4 Donations Support: http://www.houseoffusion.com/tiny.cfm/54
RE: Code Review
You might check out About Web, or contact Simon Horwith directly. I've heard him mention that their company does code reviews. -Original Message- From: Mehdi, Agha [mailto:[EMAIL PROTECTED] Sent: March 16, 2006 1:53 PM Hi Guys, We need to have ColdFusion code for one of our applications reviewed/analyzed. Can you please recommend professionals who do that? This transmission may contain information that is privileged, confidential and/or exempt from disclosure under applicable law. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein (including any reliance thereon) is STRICTLY PROHIBITED. If you received this transmission in error, please immediately contact the sender and destroy the material in its entirety, whether in electronic or hard copy format. Thank you. A1. ~| Message: http://www.houseoffusion.com/lists.cfm/link=i:4:235594 Archives: http://www.houseoffusion.com/cf_lists/threads.cfm/4 Subscription: http://www.houseoffusion.com/lists.cfm/link=s:4 Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=11502.10531.4 Donations Support: http://www.houseoffusion.com/tiny.cfm/54
RE: Code Review
Here's Simon's blog: http://www.horwith.com/ -Original Message- From: Munson, Jacob Sent: Thursday, March 16, 2006 4:31 PM You might check out About Web, or contact Simon Horwith directly. I've heard him mention that their company does code reviews. -Original Message- From: Mehdi, Agha [mailto:[EMAIL PROTECTED] Sent: March 16, 2006 1:53 PM Hi Guys, We need to have ColdFusion code for one of our applications reviewed/analyzed. Can you please recommend professionals who do that? [INFO] -- Access Manager: This transmission may contain information that is privileged, confidential and/or exempt from disclosure under applicable law. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information contained herein (including any reliance thereon) is STRICTLY PROHIBITED. If you received this transmission in error, please immediately contact the sender and destroy the material in its entirety, whether in electronic or hard copy format. Thank you. A2 ~| Message: http://www.houseoffusion.com/lists.cfm/link=i:4:235595 Archives: http://www.houseoffusion.com/cf_lists/threads.cfm/4 Subscription: http://www.houseoffusion.com/lists.cfm/link=s:4 Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4 Donations Support: http://www.houseoffusion.com/tiny.cfm/54
Re: Code Review
Agha, We not only perform application analysis, we also have a full load testing lab complete with hardware load balanced cluster and multiple database servers. Just let us know if you're interested. Respectfully, Adam Phillip Churvis Certified Advanced ColdFusion MX 7 Developer http://www.ProductivityEnhancement.com Download Plum and other cool development tools, and get advanced intensive Master-level training: * C# ASP.NET for ColdFusion Developers * ColdFusion MX Master Class * Advanced Development with CFMX and SQL Server 2000 - Original Message - From: Mehdi, Agha [EMAIL PROTECTED] To: CF-Talk cf-talk@houseoffusion.com Sent: Thursday, March 16, 2006 2:53 PM Subject: Code Review Hi Guys, We need to have ColdFusion code for one of our applications reviewed/analyzed. Can you please recommend professionals who do that? Thanks Agha Mehdi IDT - eBusiness Program Manager Work: 408.284.8239 Cell : 209.275.0482 Fax : 408.284.2766 ~| Message: http://www.houseoffusion.com/lists.cfm/link=i:4:235603 Archives: http://www.houseoffusion.com/cf_lists/threads.cfm/4 Subscription: http://www.houseoffusion.com/lists.cfm/link=s:4 Unsubscribe: http://www.houseoffusion.com/cf_lists/unsubscribe.cfm?user=89.70.4 Donations Support: http://www.houseoffusion.com/tiny.cfm/54
I need a code review
Hi I'm rather new to CF and have written a basic site architecture. I would like if someone would review it, preferably someone with alot of experience. I need to know if I'm on the right track and if there are any fatal flaws to my design. If you wish be of assitance, then email me personally. Thank You. -- Chris Edwards Web Application Developer Outer Banks Internet, Inc. 252-441-6698 [EMAIL PROTECTED] http://www.OuterBanksInternet.com __ Signup for the Fusion Authority news alert and keep up with the latest news in ColdFusion and related topics. http://www.fusionauthority.com/signup.cfm FAQ: http://www.thenetprofits.co.uk/coldfusion/faq Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
Looping Over Structures - Help and Peer Code Review Request
Howdy Cf-Talk, I am building a job search agent that will send scheduled emails to job seekers based on their matching criteria they input when setting up their search agent. When a job seeker creates the agent, they must select at least one category of interest. When the scheduled agent runs, it will pull active jobs in the job seeker's category or categories that they identified in their search agent criteria. In setting up the agent, I've dumped everything into structures of structures (before that I used arrays of structures and that worked ok, but I was having trouble with looping and outputting the results). All data is dumped into the structures just fine (verified with cfdump). The outputted portion will be used to build a message body (using cfsavecontent that will be inserted into an email and sent to each job seeker that has matching jobs. There are a couple of areas I'm having problems with: 1. If there are no jobs that match a job seeker's categories of interest, then there will not be any jobs listed in the jobs structure and so that job seeker should be skipped over and nothing output for them when building the emails in the external loop over the AgentStruct structure. Is there a way to reach down and figure this out in advance when first starting the external loop over the AgentStruct structure? 2. I'm still having trouble getting data to output correctly for each job seeker with looping over the structures. I am posting the code below, hoping for some help to figure this out. I have embedded comments in the code where problems are happening. Basically, the issues I am having start with line 94, where the external loop begins for outputting data. On line 103, the loop to output each category that has jobs listed under it starts, but I am getting only one category for each job seeker even if they have other categories with jobs in them. After banging on this for four days, I'm about to go postal. Can anyone help me see the light? Muchas Gracias! [code begins] 1: !--- 6: *** Purpose: this template pulls job search preferences and emails a report of job matches to job seekers 7: --- 8: 9: !--- get all active jobs in cached query --- 10: cfquery name=GetJobs datasource=#dsn# CACHEDWITHIN=#CreateTimeSpan(0,0,10,0)# 11: SELECT Jobs.JobID, Jobs.PositionTitle, Jobs.City, Jobs.DateCloses, Jobs.DatePosted, Jobs.Company, Jobs.CatID 12: FROM Jobs 13: WHERE 0 = 0 AND Jobs.DatePosted (#Now()#-60) AND Jobs.DateCloses #Now()# AND Jobs.Active = 1 14: /cfquery 15: 16: !--- get job seeker's Search Agent prefs for active search agents --- 17: cfquery name=GetSeekerInfo datasource=#dsn# dbtype=ODBC 18: !---SELECT SeekerSearchAgent.* 19: FROM SeekerSearchAgent 20: WHERE AgentActive = 1 --- 21: SELECT Seekers.SeekID AS Seekers_SeekID, Seekers.FName, Seekers.MI, Seekers.LName, Seekers.Email, SeekerSearchAgent.SeekID AS SeekerSearchAgent_SeekID, SeekerSearchAgent.ID, SeekerSearchAgent.SendDaily, SeekerSearchAgent.SendWeekly, SeekerSearchAgent.NotifyAllJobs, SeekerSearchAgent.AgentActive, SeekerSearchAgent.LastNotified, SeekerSearchAgent.AgentActive 22: FROM Seekers RIGHT JOIN SeekerSearchAgent ON Seekers.SeekID = SeekerSearchAgent.SeekID 23: WHERE (((SeekerSearchAgent.AgentActive)=True)); 24: /cfquery 25: 26: cfif Not GetSeekerInfo.RecordCount GT 0 27: cfabort 28: /cfif 29: 30: !--- create array to hold structures containing job seeker search agent info --- 31: cfset AgentStruct = StructNew() 32: 33: !--- put seeker search agent info in an array of structures --- 34: cfloop query=GetSeekerInfo 35: cfset AgentStruct[#currentrow#] = StructNew() 36: cfset AgentStruct[#currentrow#].SeekID = #Seekers_SeekID# 37: cfset AgentStruct[#currentrow#].SendDaily = #SendDaily# 38: cfset AgentStruct[#currentrow#].SendWeekly = #SendWeekly# 39: cfset AgentStruct[#currentrow#].NotifyAllJobs = #NotifyAllJobs# 40: cfset AgentStruct[#currentrow#].LastNotified = #LastNotified# 41: cfset AgentStruct[#currentrow#].Email = #Email# 42: cfset AgentStruct[#currentrow#].FName = #FName# 43: cfset AgentStruct[#currentrow#].MI = #MI# 44: cfset AgentStruct[#currentrow#].LName = #LName# 45: /cfloop 46: 47: !--- loop over seeker id's in AgentArray --- 48: cfloop item=i collection=#AgentStruct# 49: 50: !--- get categories job seeker is interested in --- 51: cfquery name=GetCategoriesInterestedIn datasource=#dsn# dbtype=ODBC 52: SELECT JobCategory.* 53: FROM SeekerCatInterests, JobCategory 54: WHERE SeekerCatInterests.SeekID = #AgentStruct[#i#].SeekID# AND SeekerCatInterests.CatID = JobCategory.CatID 55: /cfquery 56: !--- create a structure to hold the categories a job seeker is interested in --- 57: cfset JobCatsStruct = StructNew() 58: 59: !--- add job categories seeker is interested in to
Re: Looping Over Structures - Help and Peer Code Review Request
In case anyone is interested in taking a look, I've posted the dump of the structures here: http://www.airtightweb.com/test/searchagentdump.htm As you can see from that, Jobcatlist holds the categories a job seeker is interested in and Joblist holds any active jobs in those categories, for each job seeker. I want to dump a list of those categories that have jobs, with a list of those jobs, in an email to each job seeker. Thanks! Monday, August 19, 2002, 4:38:18 PM, Chris Montgomery wrote: CM In setting up the agent, I've dumped everything into structures of CM structures... -- Chris Montgomery[EMAIL PROTECTED] Airtight Web Services http://www.airtightweb.com Web Development, Web Project Management, Software Sales 210-490-3249/888-745-7603 __ Get the mailserver that powers this list at http://www.coolfusion.com FAQ: http://www.thenetprofits.co.uk/coldfusion/faq Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
Code review, PLEASE
I have to be missing something: and I cant put my mouse on it !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" html head CFPARAM Name="ID" Default=1 titleInterview 2/title /head CFQUERY NAME="selectcandidate" DATASOURCE="interview" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile, InitialIntdate, InitialInt, TechIntvdate, TechIntv, PeerInterviewdate, PeerInterview, MarkInterdate, MarkInter, ExtOfferdate, CheckRef, StartDate, Comments FROM interview WHERE ID=#ID# /CFQUERY cfform action="interview2action.cfm" method="POST" CFSET NextID=#id#+1 CFSET PrevID=#id#-1 body bgcolor="6699ff" cfoutput query="selectcandidate" input type="hidden" name="id" value="selectcandidate" table width="95%" border="1" align="center" bgcolor="6699ff" tr tdID/td tdCandidate Name/td /tr tr tdnbsp;#ID#/td tdnbsp;#EmpCandidate#/td /tr tr tdInitial Interview Date/td tdInitial Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="InitialIntdate" value="#InitialIntdate#"/td tdnbsp;textarea cols="65" rows="5" name="InitialInt"#InitialInt#/textarea/td /tr tr tdTechnical Interview Date/td tdTechnical Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="TechIntvDate" value="#Techintvdate#"/td tdnbsp;textarea cols="65" rows="5" name="TechIntv"#TechIntv#/textarea/td /tr tr tdPeer Interview Date/td tdPeer Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="PeerInterviewdate" value="#PeerInterviewdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="PeerInterview"#PeerInterview#/textarea/td /tr tr tdMarketing Interview Date/td tdMarketing Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="MarkInterdate" value="#MarkInterdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="MarkInter"#MarkInter#/textarea/td /tr tr td valign="top"Offer Extended Date/td tdReference Check/td /tr tr td valign="top"nbsp;cfinput type="Text" name="ExtOfferdate" value="#ExtOfferdate#"/td tdnbsp;textarea cols="65" rows="5" name="CheckRef"#CheckRef#/textarea/td /tr tr tdStart Date/td tdAdditional Comments/td /tr tr td valign="top"nbsp;cfinput type="Text" name="StartDate" value="#StartDate#" required="No"/td tdtextarea cols="65" rows="5" name="Comments"#Comments#/textarea/td /tr /table table width="85%" border="0" TR TD align="left"a href="interview2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="interview2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput input type="submit" name="Action" value="Update Criteria" /cfform /body /html TIA Michael ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
RE: Code review, PLEASE
input type="hidden" name="id" value="selectcandidate" doesn't the value need # symbols? -paul Web Developer, NBBJ Work: [EMAIL PROTECTED] 614 241-3534 fax:614 485-5534 Home: [EMAIL PROTECTED] 614 449-1681 icq: 47658358 -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 2:27 PM To: CF-Talk Subject: Code review, PLEASE I have to be missing something: and I cant put my mouse on it !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" html head CFPARAM Name="ID" Default=1 titleInterview 2/title /head CFQUERY NAME="selectcandidate" DATASOURCE="interview" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile, InitialIntdate, InitialInt, TechIntvdate, TechIntv, PeerInterviewdate, PeerInterview, MarkInterdate, MarkInter, ExtOfferdate, CheckRef, StartDate, Comments FROM interview WHERE ID=#ID# /CFQUERY cfform action="interview2action.cfm" method="POST" CFSET NextID=#id#+1 CFSET PrevID=#id#-1 body bgcolor="6699ff" cfoutput query="selectcandidate" input type="hidden" name="id" value="selectcandidate" table width="95%" border="1" align="center" bgcolor="6699ff" tr tdID/td tdCandidate Name/td /tr tr tdnbsp;#ID#/td tdnbsp;#EmpCandidate#/td /tr tr tdInitial Interview Date/td tdInitial Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="InitialIntdate" value="#InitialIntdate#"/td tdnbsp;textarea cols="65" rows="5" name="InitialInt"#InitialInt#/textarea/td /tr tr tdTechnical Interview Date/td tdTechnical Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="TechIntvDate" value="#Techintvdate#"/td tdnbsp;textarea cols="65" rows="5" name="TechIntv"#TechIntv#/textarea/td /tr tr tdPeer Interview Date/td tdPeer Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="PeerInterviewdate" value="#PeerInterviewdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="PeerInterview"#PeerInterview#/textarea/td /tr tr tdMarketing Interview Date/td tdMarketing Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="MarkInterdate" value="#MarkInterdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="MarkInter"#MarkInter#/textarea/td /tr tr td valign="top"Offer Extended Date/td tdReference Check/td /tr tr td valign="top"nbsp;cfinput type="Text" name="ExtOfferdate" value="#ExtOfferdate#"/td tdnbsp;textarea cols="65" rows="5" name="CheckRef"#CheckRef#/textarea/td /tr tr tdStart Date/td tdAdditional Comments/td /tr tr td valign="top"nbsp;cfinput type="Text" name="StartDate" value="#StartDate#" required="No"/td tdtextarea cols="65" rows="5" name="Comments"#Comments#/textarea/td /tr /table table width="85%" border="0" TR TD align="left"a href="interview2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="interview2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput input type="submit" name="Action" value="Update Criteria" /cfform /body /html TIA Michael ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
RE: Code review, PLEASE
It would be best if u can tell us what the problem is and what ua re tyring to get the page to do. then i can understand the code better -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 1:27 PM To: CF-Talk Subject: Code review, PLEASE I have to be missing something: and I cant put my mouse on it !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" html head CFPARAM Name="ID" Default=1 titleInterview 2/title /head CFQUERY NAME="selectcandidate" DATASOURCE="interview" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile, InitialIntdate, InitialInt, TechIntvdate, TechIntv, PeerInterviewdate, PeerInterview, MarkInterdate, MarkInter, ExtOfferdate, CheckRef, StartDate, Comments FROM interview WHERE ID=#ID# /CFQUERY cfform action="interview2action.cfm" method="POST" CFSET NextID=#id#+1 CFSET PrevID=#id#-1 body bgcolor="6699ff" cfoutput query="selectcandidate" input type="hidden" name="id" value="selectcandidate" table width="95%" border="1" align="center" bgcolor="6699ff" tr tdID/td tdCandidate Name/td /tr tr tdnbsp;#ID#/td tdnbsp;#EmpCandidate#/td /tr tr tdInitial Interview Date/td tdInitial Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="InitialIntdate" value="#InitialIntdate#"/td tdnbsp;textarea cols="65" rows="5" name="InitialInt"#InitialInt#/textarea/td /tr tr tdTechnical Interview Date/td tdTechnical Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="TechIntvDate" value="#Techintvdate#"/td tdnbsp;textarea cols="65" rows="5" name="TechIntv"#TechIntv#/textarea/td /tr tr tdPeer Interview Date/td tdPeer Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="PeerInterviewdate" value="#PeerInterviewdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="PeerInterview"#PeerInterview#/textarea/td /tr tr tdMarketing Interview Date/td tdMarketing Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="MarkInterdate" value="#MarkInterdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="MarkInter"#MarkInter#/textarea/td /tr tr td valign="top"Offer Extended Date/td tdReference Check/td /tr tr td valign="top"nbsp;cfinput type="Text" name="ExtOfferdate" value="#ExtOfferdate#"/td tdnbsp;textarea cols="65" rows="5" name="CheckRef"#CheckRef#/textarea/td /tr tr tdStart Date/td tdAdditional Comments/td /tr tr td valign="top"nbsp;cfinput type="Text" name="StartDate" value="#StartDate#" required="No"/td tdtextarea cols="65" rows="5" name="Comments"#Comments#/textarea/td /tr /table table width="85%" border="0" TR TD align="left"a href="interview2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="interview2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput input type="submit" name="Action" value="Update Criteria" /cfform /body /html TIA Michael ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
Re: Code review, PLEASE
Sorry bout that: This is the error Error Occurred While Processing Request Error Diagnostic Information ODBC Error Code = 37000 (Syntax error or access violation) [Microsoft][ODBC Microsoft Access Driver] Syntax error in UPDATE statement. The error occurred while processing an element with a general identifier of (CFQUERY), occupying document position (8:1) to (8:46). Date/Time: 03/19/01 14:49:50 Browser: Mozilla/4.0 (compatible; MSIE 5.01; Windows NT 5.0) Remote Address: 127.0.0.1 HTTP Referer: http://127.0.0.1/nto/Interview2.cfm "Dylan Bromby" [EMAIL PROTECTED] wrote in message 000401c0b0ac$60463050$6401a8c0@bromby">news:000401c0b0ac$60463050$6401a8c0@bromby... why don't you post either the error or what isn't happening that you think should so we don't have to guess. :) -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 11:27 AM To: CF-Talk Subject: Code review, PLEASE I have to be missing something: and I cant put my mouse on it !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" html head CFPARAM Name="ID" Default=1 titleInterview 2/title /head CFQUERY NAME="selectcandidate" DATASOURCE="interview" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile, InitialIntdate, InitialInt, TechIntvdate, TechIntv, PeerInterviewdate, PeerInterview, MarkInterdate, MarkInter, ExtOfferdate, CheckRef, StartDate, Comments FROM interview WHERE ID=#ID# /CFQUERY cfform action="interview2action.cfm" method="POST" CFSET NextID=#id#+1 CFSET PrevID=#id#-1 body bgcolor="6699ff" cfoutput query="selectcandidate" input type="hidden" name="id" value="selectcandidate" table width="95%" border="1" align="center" bgcolor="6699ff" tr tdID/td tdCandidate Name/td /tr tr tdnbsp;#ID#/td tdnbsp;#EmpCandidate#/td /tr tr tdInitial Interview Date/td tdInitial Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="InitialIntdate" value="#InitialIntdate#"/td tdnbsp;textarea cols="65" rows="5" name="InitialInt"#InitialInt#/textarea/td /tr tr tdTechnical Interview Date/td tdTechnical Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="TechIntvDate" value="#Techintvdate#"/td tdnbsp;textarea cols="65" rows="5" name="TechIntv"#TechIntv#/textarea/td /tr tr tdPeer Interview Date/td tdPeer Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="PeerInterviewdate" value="#PeerInterviewdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="PeerInterview"#PeerInterview#/textarea/td /tr tr tdMarketing Interview Date/td tdMarketing Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="MarkInterdate" value="#MarkInterdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="MarkInter"#MarkInter#/textarea/td /tr tr td valign="top"Offer Extended Date/td tdReference Check/td /tr tr td valign="top"nbsp;cfinput type="Text" name="ExtOfferdate" value="#ExtOfferdate#"/td tdnbsp;textarea cols="65" rows="5" name="CheckRef"#CheckRef#/textarea/td /tr tr tdStart Date/td tdAdditional Comments/td /tr tr td valign="top"nbsp;cfinput type="Text" name="StartDate" value="#StartDate#" required="No"/td tdtextarea cols="65" rows="5" name="Comments"#Comments#/textarea/td /tr /table table width="85%" border="0" TR TD align="left"a href="interview2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="interview2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput input type="submit" name="Action" value="Update Criteria" /cfform /body /html TIA Michael ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
RE: Code review, PLEASE
glad you said that, i was feeling kind of dense "Dylan Bromby" [EMAIL PROTECTED] on 03/19/2001 01:39:53 PM Please respond to [EMAIL PROTECTED] To: CF-Talk [EMAIL PROTECTED] cc:(bcc: Savan Thongvanh/DSM/Seabury) Subject: RE: Code review, PLEASE why don't you post either the error or what isn't happening that you think should so we don't have to guess. :) -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 11:27 AM To: CF-Talk Subject: Code review, PLEASE I have to be missing something: and I cant put my mouse on it !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" html head CFPARAM Name="ID" Default=1 titleInterview 2/title /head CFQUERY NAME="selectcandidate" DATASOURCE="interview" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile, InitialIntdate, InitialInt, TechIntvdate, TechIntv, PeerInterviewdate, PeerInterview, MarkInterdate, MarkInter, ExtOfferdate, CheckRef, StartDate, Comments FROM interview WHERE ID=#ID# /CFQUERY cfform action="interview2action.cfm" method="POST" CFSET NextID=#id#+1 CFSET PrevID=#id#-1 body bgcolor="6699ff" cfoutput query="selectcandidate" input type="hidden" name="id" value="selectcandidate" table width="95%" border="1" align="center" bgcolor="6699ff" tr tdID/td tdCandidate Name/td /tr tr tdnbsp;#ID#/td tdnbsp;#EmpCandidate#/td /tr tr tdInitial Interview Date/td tdInitial Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="InitialIntdate" value="#InitialIntdate#"/td tdnbsp;textarea cols="65" rows="5" name="InitialInt"#InitialInt#/textarea/td /tr tr tdTechnical Interview Date/td tdTechnical Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="TechIntvDate" value="#Techintvdate#"/td tdnbsp;textarea cols="65" rows="5" name="TechIntv"#TechIntv#/textarea/td /tr tr tdPeer Interview Date/td tdPeer Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="PeerInterviewdate" value="#PeerInterviewdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="PeerInterview"#PeerInterview#/textarea/td /tr tr tdMarketing Interview Date/td tdMarketing Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="MarkInterdate" value="#MarkInterdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="MarkInter"#MarkInter#/textarea/td /tr tr td valign="top"Offer Extended Date/td tdReference Check/td /tr tr td valign="top"nbsp;cfinput type="Text" name="ExtOfferdate" value="#ExtOfferdate#"/td tdnbsp;textarea cols="65" rows="5" name="CheckRef"#CheckRef#/textarea/td /tr tr tdStart Date/td tdAdditional Comments/td /tr tr td valign="top"nbsp;cfinput type="Text" name="StartDate" value="#StartDate#" required="No"/td tdtextarea cols="65" rows="5" name="Comments"#Comments#/textarea/td /tr /table table width="85%" border="0" TR TD align="left"a href="interview2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="interview2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput input type="submit" name="Action" value="Update Criteria" /cfform /body /html TIA Michael ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
Re: Code review, PLEASE
This is what I get now with the ## Error Occurred While Processing Request Error Diagnostic Information Expression result cannot be converted to a string Expressions used inside tags like CFOUTPUT, CFQUERY, CFMAIL, etc. must evaluate to a value that can be converted to a string for output or dynamic text accumulation purposes. Complex objects, such as queries, arrays, and COM/DCOM objects, cannot be represented as strings. The error occurred while processing an element with a general identifier of (#selectcandidate#), occupying document position (22:39) to (22:55). Date/Time: 03/19/01 15:00:27 Browser: Mozilla/4.0 (compatible; MSIE 5.01; Windows NT 5.0) Remote Address: 127.0.0.1 "Paul Ihrig" [EMAIL PROTECTED] wrote in message 1097F6DBC531D2118F180008C7B1682D03A1537D@NBBJCMHEX1">news:1097F6DBC531D2118F180008C7B1682D03A1537D@NBBJCMHEX1... input type="hidden" name="id" value="selectcandidate" doesn't the value need # symbols? -paul Web Developer, NBBJ Work: [EMAIL PROTECTED] 614 241-3534 fax: 614 485-5534 Home: [EMAIL PROTECTED] 614 449-1681 icq: 47658358 -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 2:27 PM To: CF-Talk Subject: Code review, PLEASE I have to be missing something: and I cant put my mouse on it !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" html head CFPARAM Name="ID" Default=1 titleInterview 2/title /head CFQUERY NAME="selectcandidate" DATASOURCE="interview" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile, InitialIntdate, InitialInt, TechIntvdate, TechIntv, PeerInterviewdate, PeerInterview, MarkInterdate, MarkInter, ExtOfferdate, CheckRef, StartDate, Comments FROM interview WHERE ID=#ID# /CFQUERY cfform action="interview2action.cfm" method="POST" CFSET NextID=#id#+1 CFSET PrevID=#id#-1 body bgcolor="6699ff" cfoutput query="selectcandidate" input type="hidden" name="id" value="selectcandidate" table width="95%" border="1" align="center" bgcolor="6699ff" tr tdID/td tdCandidate Name/td /tr tr tdnbsp;#ID#/td tdnbsp;#EmpCandidate#/td /tr tr tdInitial Interview Date/td tdInitial Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="InitialIntdate" value="#InitialIntdate#"/td tdnbsp;textarea cols="65" rows="5" name="InitialInt"#InitialInt#/textarea/td /tr tr tdTechnical Interview Date/td tdTechnical Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="TechIntvDate" value="#Techintvdate#"/td tdnbsp;textarea cols="65" rows="5" name="TechIntv"#TechIntv#/textarea/td /tr tr tdPeer Interview Date/td tdPeer Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="PeerInterviewdate" value="#PeerInterviewdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="PeerInterview"#PeerInterview#/textarea/td /tr tr tdMarketing Interview Date/td tdMarketing Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="MarkInterdate" value="#MarkInterdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="MarkInter"#MarkInter#/textarea/td /tr tr td valign="top"Offer Extended Date/td tdReference Check/td /tr tr td valign="top"nbsp;cfinput type="Text" name="ExtOfferdate" value="#ExtOfferdate#"/td tdnbsp;textarea cols="65" rows="5" name="CheckRef"#CheckRef#/textarea/td /tr tr tdStart Date/td tdAdditional Comments/td /tr tr td valign="top"nbsp;cfinput type="Text" name="StartDate" value="#StartDate#" required="No"/td tdtextarea cols="65" rows="5" name="Comments"#Comments#/textarea/td /tr /table table width="85%" border="0" TR TD align="left"a href="interview2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="interview2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput input type="submit" name="Action" value="Update Criteria" /cfform /body /html TIA Michael ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
Re: Code review, PLEASE
whats the error that you are getting with this code? - Original Message - From: "Mike" [EMAIL PROTECTED] To: "CF-Talk" [EMAIL PROTECTED] Sent: Monday, March 19, 2001 2:26 PM Subject: Code review, PLEASE I have to be missing something: and I cant put my mouse on it !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" html head CFPARAM Name="ID" Default=1 titleInterview 2/title /head CFQUERY NAME="selectcandidate" DATASOURCE="interview" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile, InitialIntdate, InitialInt, TechIntvdate, TechIntv, PeerInterviewdate, PeerInterview, MarkInterdate, MarkInter, ExtOfferdate, CheckRef, StartDate, Comments FROM interview WHERE ID=#ID# /CFQUERY cfform action="interview2action.cfm" method="POST" CFSET NextID=#id#+1 CFSET PrevID=#id#-1 body bgcolor="6699ff" cfoutput query="selectcandidate" input type="hidden" name="id" value="selectcandidate" table width="95%" border="1" align="center" bgcolor="6699ff" tr tdID/td tdCandidate Name/td /tr tr tdnbsp;#ID#/td tdnbsp;#EmpCandidate#/td /tr tr tdInitial Interview Date/td tdInitial Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="InitialIntdate" value="#InitialIntdate#"/td tdnbsp;textarea cols="65" rows="5" name="InitialInt"#InitialInt#/textarea/td /tr tr tdTechnical Interview Date/td tdTechnical Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="TechIntvDate" value="#Techintvdate#"/td tdnbsp;textarea cols="65" rows="5" name="TechIntv"#TechIntv#/textarea/td /tr tr tdPeer Interview Date/td tdPeer Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="PeerInterviewdate" value="#PeerInterviewdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="PeerInterview"#PeerInterview#/textarea/td /tr tr tdMarketing Interview Date/td tdMarketing Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="MarkInterdate" value="#MarkInterdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="MarkInter"#MarkInter#/textarea/td /tr tr td valign="top"Offer Extended Date/td tdReference Check/td /tr tr td valign="top"nbsp;cfinput type="Text" name="ExtOfferdate" value="#ExtOfferdate#"/td tdnbsp;textarea cols="65" rows="5" name="CheckRef"#CheckRef#/textarea/td /tr tr tdStart Date/td tdAdditional Comments/td /tr tr td valign="top"nbsp;cfinput type="Text" name="StartDate" value="#StartDate#" required="No"/td tdtextarea cols="65" rows="5" name="Comments"#Comments#/textarea/td /tr /table table width="85%" border="0" TR TD align="left"a href="interview2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="interview2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput input type="submit" name="Action" value="Update Criteria" /cfform /body /html TIA Michael ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
RE: Code review, PLEASE
selectCandidate is your query name; a query can't be converted to a string. You may want one of your query column names instead. -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 2:01 PM To: CF-Talk Subject: Re: Code review, PLEASE This is what I get now with the ## Error Occurred While Processing Request Error Diagnostic Information Expression result cannot be converted to a string Expressions used inside tags like CFOUTPUT, CFQUERY, CFMAIL, etc. must evaluate to a value that can be converted to a string for output or dynamic text accumulation purposes. Complex objects, such as queries, arrays, and COM/DCOM objects, cannot be represented as strings. The error occurred while processing an element with a general identifier of (#selectcandidate#), occupying document position (22:39) to (22:55). Date/Time: 03/19/01 15:00:27 Browser: Mozilla/4.0 (compatible; MSIE 5.01; Windows NT 5.0) Remote Address: 127.0.0.1 "Paul Ihrig" [EMAIL PROTECTED] wrote in message 1097F6DBC531D2118F180008C7B1682D03A1537D@NBBJCMHEX1">news:1097F6DBC531D2118F180008C7B1682D03A1537D@NBBJCMHEX1... input type="hidden" name="id" value="selectcandidate" doesn't the value need # symbols? -paul Web Developer, NBBJ Work: [EMAIL PROTECTED] 614 241-3534 fax: 614 485-5534 Home: [EMAIL PROTECTED] 614 449-1681 icq: 47658358 -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 2:27 PM To: CF-Talk Subject: Code review, PLEASE I have to be missing something: and I cant put my mouse on it !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" html head CFPARAM Name="ID" Default=1 titleInterview 2/title /head CFQUERY NAME="selectcandidate" DATASOURCE="interview" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile, InitialIntdate, InitialInt, TechIntvdate, TechIntv, PeerInterviewdate, PeerInterview, MarkInterdate, MarkInter, ExtOfferdate, CheckRef, StartDate, Comments FROM interview WHERE ID=#ID# /CFQUERY cfform action="interview2action.cfm" method="POST" CFSET NextID=#id#+1 CFSET PrevID=#id#-1 body bgcolor="6699ff" cfoutput query="selectcandidate" input type="hidden" name="id" value="selectcandidate" table width="95%" border="1" align="center" bgcolor="6699ff" tr tdID/td tdCandidate Name/td /tr tr tdnbsp;#ID#/td tdnbsp;#EmpCandidate#/td /tr tr tdInitial Interview Date/td tdInitial Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="InitialIntdate" value="#InitialIntdate#"/td tdnbsp;textarea cols="65" rows="5" name="InitialInt"#InitialInt#/textarea/td /tr tr tdTechnical Interview Date/td tdTechnical Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="TechIntvDate" value="#Techintvdate#"/td tdnbsp;textarea cols="65" rows="5" name="TechIntv"#TechIntv#/textarea/td /tr tr tdPeer Interview Date/td tdPeer Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="PeerInterviewdate" value="#PeerInterviewdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="PeerInterview"#PeerInterview#/textarea/td /tr tr tdMarketing Interview Date/td tdMarketing Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="MarkInterdate" value="#MarkInterdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="MarkInter"#MarkInter#/textarea/td /tr tr td valign="top"Offer Extended Date/td tdReference Check/td /tr tr td valign="top"nbsp;cfinput type="Text" name="ExtOfferdate" value="#ExtOfferdate#"/td tdnbsp;textarea cols="65" rows="5" name="CheckRef"#CheckRef#/textarea/td /tr tr tdStart Date/td tdAdditional Comments/td /tr tr td valign="top"nbsp;cfinput type="Text" name="StartDate" value="#StartDate#" required="No"/td tdtextarea cols="65" rows="5" name="Comments"#Comments#/textarea/td /tr /table table width="85%" border="0" TR TD align="left"a href="interview2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="interview2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput input type="submit" name="Action" value="Update Criteria" /cfform /body /html TIA Michael ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
RE: Code review, PLEASE
I don't see any query that is updating anything in the code you sent. -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 1:51 PM To: CF-Talk Subject: Re: Code review, PLEASE Sorry bout that: This is the error Error Occurred While Processing Request Error Diagnostic Information ODBC Error Code = 37000 (Syntax error or access violation) [Microsoft][ODBC Microsoft Access Driver] Syntax error in UPDATE statement. The error occurred while processing an element with a general identifier of (CFQUERY), occupying document position (8:1) to (8:46). Date/Time: 03/19/01 14:49:50 Browser: Mozilla/4.0 (compatible; MSIE 5.01; Windows NT 5.0) Remote Address: 127.0.0.1 HTTP Referer: http://127.0.0.1/nto/Interview2.cfm "Dylan Bromby" [EMAIL PROTECTED] wrote in message 000401c0b0ac$60463050$6401a8c0@bromby">news:000401c0b0ac$60463050$6401a8c0@bromby... why don't you post either the error or what isn't happening that you think should so we don't have to guess. :) -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 11:27 AM To: CF-Talk Subject: Code review, PLEASE I have to be missing something: and I cant put my mouse on it !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" html head CFPARAM Name="ID" Default=1 titleInterview 2/title /head CFQUERY NAME="selectcandidate" DATASOURCE="interview" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile, InitialIntdate, InitialInt, TechIntvdate, TechIntv, PeerInterviewdate, PeerInterview, MarkInterdate, MarkInter, ExtOfferdate, CheckRef, StartDate, Comments FROM interview WHERE ID=#ID# /CFQUERY cfform action="interview2action.cfm" method="POST" CFSET NextID=#id#+1 CFSET PrevID=#id#-1 body bgcolor="6699ff" cfoutput query="selectcandidate" input type="hidden" name="id" value="selectcandidate" table width="95%" border="1" align="center" bgcolor="6699ff" tr tdID/td tdCandidate Name/td /tr tr tdnbsp;#ID#/td tdnbsp;#EmpCandidate#/td /tr tr tdInitial Interview Date/td tdInitial Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="InitialIntdate" value="#InitialIntdate#"/td tdnbsp;textarea cols="65" rows="5" name="InitialInt"#InitialInt#/textarea/td /tr tr tdTechnical Interview Date/td tdTechnical Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="TechIntvDate" value="#Techintvdate#"/td tdnbsp;textarea cols="65" rows="5" name="TechIntv"#TechIntv#/textarea/td /tr tr tdPeer Interview Date/td tdPeer Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="PeerInterviewdate" value="#PeerInterviewdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="PeerInterview"#PeerInterview#/textarea/td /tr tr tdMarketing Interview Date/td tdMarketing Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="MarkInterdate" value="#MarkInterdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="MarkInter"#MarkInter#/textarea/td /tr tr td valign="top"Offer Extended Date/td tdReference Check/td /tr tr td valign="top"nbsp;cfinput type="Text" name="ExtOfferdate" value="#ExtOfferdate#"/td tdnbsp;textarea cols="65" rows="5" name="CheckRef"#CheckRef#/textarea/td /tr tr tdStart Date/td tdAdditional Comments/td /tr tr td valign="top"nbsp;cfinput type="Text" name="StartDate" value="#StartDate#" required="No"/td tdtextarea cols="65" rows="5" name="Comments"#Comments#/textarea/td /tr /table table width="85%" border="0" TR TD align="left"a href="interview2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="interview2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput input type="submit" name="Action" value="Update Criteria" /cfform /body /html TIA Michael ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
RE: Code review, PLEASE
selectcandidate is the name of your query, to resolve the expression you need to indicate a column name. do you really want: input type="hidden" name="id" value="#selectcandidate.id# which will store the ID column of the query as a hidden form field. Craig -Original Message- From: Mike [SMTP:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 3:01 PM To: CF-Talk Subject: Re: Code review, PLEASE This is what I get now with the ## Error Occurred While Processing Request Error Diagnostic Information Expression result cannot be converted to a string Expressions used inside tags like CFOUTPUT, CFQUERY, CFMAIL, etc. must evaluate to a value that can be converted to a string for output or dynamic text accumulation purposes. Complex objects, such as queries, arrays, and COM/DCOM objects, cannot be represented as strings. The error occurred while processing an element with a general identifier of (#selectcandidate#), occupying document position (22:39) to (22:55). Date/Time: 03/19/01 15:00:27 Browser: Mozilla/4.0 (compatible; MSIE 5.01; Windows NT 5.0) Remote Address: 127.0.0.1 "Paul Ihrig" [EMAIL PROTECTED] wrote in message 1097F6DBC531D2118F180008C7B1682D03A1537D@NBBJCMHEX1">news:1097F6DBC531D2118F180008C7B1682D03A1537D@NBBJCMHEX1... input type="hidden" name="id" value="selectcandidate" doesn't the value need # symbols? -paul Web Developer, NBBJ Work: [EMAIL PROTECTED] 614 241-3534 fax: 614 485-5534 Home: [EMAIL PROTECTED] 614 449-1681 icq: 47658358 -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 2:27 PM To: CF-Talk Subject: Code review, PLEASE I have to be missing something: and I cant put my mouse on it !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" html head CFPARAM Name="ID" Default=1 titleInterview 2/title /head CFQUERY NAME="selectcandidate" DATASOURCE="interview" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile, InitialIntdate, InitialInt, TechIntvdate, TechIntv, PeerInterviewdate, PeerInterview, MarkInterdate, MarkInter, ExtOfferdate, CheckRef, StartDate, Comments FROM interview WHERE ID=#ID# /CFQUERY cfform action="interview2action.cfm" method="POST" CFSET NextID=#id#+1 CFSET PrevID=#id#-1 body bgcolor="6699ff" cfoutput query="selectcandidate" input type="hidden" name="id" value="selectcandidate" table width="95%" border="1" align="center" bgcolor="6699ff" tr tdID/td tdCandidate Name/td /tr tr tdnbsp;#ID#/td tdnbsp;#EmpCandidate#/td /tr tr tdInitial Interview Date/td tdInitial Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="InitialIntdate" value="#InitialIntdate#"/td tdnbsp;textarea cols="65" rows="5" name="InitialInt"#InitialInt#/textarea/td /tr tr tdTechnical Interview Date/td tdTechnical Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="TechIntvDate" value="#Techintvdate#"/td tdnbsp;textarea cols="65" rows="5" name="TechIntv"#TechIntv#/textarea/td /tr tr tdPeer Interview Date/td tdPeer Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="PeerInterviewdate" value="#PeerInterviewdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="PeerInterview"#PeerInterview#/textarea/td /tr tr tdMarketing Interview Date/td tdMarketing Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="MarkInterdate" value="#MarkInterdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="MarkInter"#MarkInter#/textarea/td /tr tr td valign="top"Offer Extended Date/td tdReference Check/td /tr tr td valign="top"nbsp;cfinput type="Text" name="ExtOfferdate" value="#ExtOfferdate#"/td tdnbsp;textarea cols="65" rows="5" name="CheckRef"#CheckRef#/textarea/td /tr tr tdStart Date/td tdAdditional Comments/td /tr tr td valign="top"nbsp;cfinput type="Text" name="St
RE: Code review, PLEASE
without seeing the update query, I would assume that the hidden value for ID needs to be the ID that is being selected from the 'selectcandidate' query. Perhaps the form input should be cfoutput query="selectcandidate" input type="hidden" name="id" value="#id" ... rest of code... /cfoutput -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 2:01 PM To: CF-Talk Subject: Re: Code review, PLEASE This is what I get now with the ## Error Occurred While Processing Request Error Diagnostic Information Expression result cannot be converted to a string Expressions used inside tags like CFOUTPUT, CFQUERY, CFMAIL, etc. must evaluate to a value that can be converted to a string for output or dynamic text accumulation purposes. Complex objects, such as queries, arrays, and COM/DCOM objects, cannot be represented as strings. The error occurred while processing an element with a general identifier of (#selectcandidate#), occupying document position (22:39) to (22:55). Date/Time: 03/19/01 15:00:27 Browser: Mozilla/4.0 (compatible; MSIE 5.01; Windows NT 5.0) Remote Address: 127.0.0.1 "Paul Ihrig" [EMAIL PROTECTED] wrote in message 1097F6DBC531D2118F180008C7B1682D03A1537D@NBBJCMHEX1">news:1097F6DBC531D2118F180008C7B1682D03A1537D@NBBJCMHEX1... input type="hidden" name="id" value="selectcandidate" doesn't the value need # symbols? -paul Web Developer, NBBJ Work: [EMAIL PROTECTED] 614 241-3534 fax: 614 485-5534 Home: [EMAIL PROTECTED] 614 449-1681 icq: 47658358 -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Monday, March 19, 2001 2:27 PM To: CF-Talk Subject: Code review, PLEASE I have to be missing something: and I cant put my mouse on it !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" html head CFPARAM Name="ID" Default=1 titleInterview 2/title /head CFQUERY NAME="selectcandidate" DATASOURCE="interview" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile, InitialIntdate, InitialInt, TechIntvdate, TechIntv, PeerInterviewdate, PeerInterview, MarkInterdate, MarkInter, ExtOfferdate, CheckRef, StartDate, Comments FROM interview WHERE ID=#ID# /CFQUERY cfform action="interview2action.cfm" method="POST" CFSET NextID=#id#+1 CFSET PrevID=#id#-1 body bgcolor="6699ff" cfoutput query="selectcandidate" input type="hidden" name="id" value="selectcandidate" table width="95%" border="1" align="center" bgcolor="6699ff" tr tdID/td tdCandidate Name/td /tr tr tdnbsp;#ID#/td tdnbsp;#EmpCandidate#/td /tr tr tdInitial Interview Date/td tdInitial Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="InitialIntdate" value="#InitialIntdate#"/td tdnbsp;textarea cols="65" rows="5" name="InitialInt"#InitialInt#/textarea/td /tr tr tdTechnical Interview Date/td tdTechnical Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="TechIntvDate" value="#Techintvdate#"/td tdnbsp;textarea cols="65" rows="5" name="TechIntv"#TechIntv#/textarea/td /tr tr tdPeer Interview Date/td tdPeer Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="PeerInterviewdate" value="#PeerInterviewdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="PeerInterview"#PeerInterview#/textarea/td /tr tr tdMarketing Interview Date/td tdMarketing Interview Notes/td /tr tr td valign="top"nbsp;cfinput type="Text" name="MarkInterdate" value="#MarkInterdate#" required="No"/td tdnbsp;textarea cols="65" rows="5" name="MarkInter"#MarkInter#/textarea/td /tr tr td valign="top"Offer Extended Date/td tdReference Check/td /tr tr td valign="top"nbsp;cfinput type="Text" name="ExtOfferdate" value="#ExtOfferdate#"/td tdnbsp;textarea cols="65" rows="5" name="CheckRef"#CheckRef#/textarea/td /tr tr tdStart Date/td tdAdditional Comments/td /tr tr td valign="top"nbsp;cfinput type="Text" name="StartDate" value="#StartDate#" required="No"/td tdtextarea cols="65" rows="5" name="Comments"#Comments#/textarea/td /tr /table table width="85%" border="0" TR TD align="left"a href="interview2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="interview2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput input type="submit" name="Action" value="Update Criteria" /cfform /body /html TIA Michael ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
Code review PLEASE
This is really making me go bald, I have a page that has next and previous, and when viewed locally I can see everything, when I ftp to my host (and yes the odbc is working and correct) I can only see the first record, and nothing after that. I have tried putting the database(access) in the database folder, and straight in the directory with all the pages and I still get the same result, I have replaced the database, and contacted my host, and they say that the code is fine from what little the guy knew about CF. Below is the code if someone could share there knowledge I would as always appreciate it. And thank you !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN" HTML HEAD CFPARAM Name="ID" Default=1 cfquery name="selectcandidate" datasource="interview" maxrows=1 dbtype="ODBC" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile FROMinterview WHERE ID=#ID# /cfquery CFSET NextID=#id#+1 CFSET PrevID=#id#-1 TITLEInterview Candidates/TITLE /HEAD BODY bgcolor="6699ff" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" cfoutput query="Selectcandidate" table cellpadding="10" tr tdID/tdbr td#id#/tdbr /tr tr tdCandidate Name/tdbr td#EmpCandidate#/tdbr /tr tr tdSkill Background/td td#SKillBackground#/td /tr tr tdStatus/td td#Status#/td /tr tr tdRecruiter/td td#Recruiter#/td /tr tr td valign="top"Profile/td tdtextarea cols="50" rows="5" name="Profile"#profile#/textarea/td /tr /table BRBR table width="85%" border="0" TR TD align="left"a href="default2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="default2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
RE: Code review PLEASE
change mawrows = 1 to something else, like user definable. Alexander Sicular Technical Director, Information Technology The Neurological Institute of New York Columbia University 212.305.1318 [EMAIL PROTECTED] -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Thursday, March 15, 2001 2:00 PM To: CF-Talk Subject: Code review PLEASE This is really making me go bald, I have a page that has next and previous, and when viewed locally I can see everything, when I ftp to my host (and yes the odbc is working and correct) I can only see the first record, and nothing after that. I have tried putting the database(access) in the database folder, and straight in the directory with all the pages and I still get the same result, I have replaced the database, and contacted my host, and they say that the code is fine from what little the guy knew about CF. Below is the code if someone could share there knowledge I would as always appreciate it. And thank you !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN" HTML HEAD CFPARAM Name="ID" Default=1 cfquery name="selectcandidate" datasource="interview" maxrows=1 dbtype="ODBC" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile FROMinterview WHERE ID=#ID# /cfquery CFSET NextID=#id#+1 CFSET PrevID=#id#-1 TITLEInterview Candidates/TITLE /HEAD BODY bgcolor="6699ff" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" cfoutput query="Selectcandidate" table cellpadding="10" tr tdID/tdbr td#id#/tdbr /tr tr tdCandidate Name/tdbr td#EmpCandidate#/tdbr /tr tr tdSkill Background/td td#SKillBackground#/td /tr tr tdStatus/td td#Status#/td /tr tr tdRecruiter/td td#Recruiter#/td /tr tr td valign="top"Profile/td tdtextarea cols="50" rows="5" name="Profile"#profile#/textarea/td /tr /table BRBR table width="85%" border="0" TR TD align="left"a href="default2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="default2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
Re: Code review PLEASE
Your the second one to say that, but locally everything works fine, if I turn the max rows off then I will see all the records and I only want to see one record at time Michael "Cami Lawson" [EMAIL PROTECTED] wrote in message 010001c0ad87$6836dcb0$[EMAIL PROTECTED]">news:010001c0ad87$6836dcb0$[EMAIL PROTECTED]... You have a maxrows = 1 on the query. $.02 - Original Message - From: "Mike" [EMAIL PROTECTED] To: "CF-Talk" [EMAIL PROTECTED] Sent: Thursday, March 15, 2001 12:59 PM Subject: Code review PLEASE This is really making me go bald, I have a page that has next and previous, and when viewed locally I can see everything, when I ftp to my host (and yes the odbc is working and correct) I can only see the first record, and nothing after that. I have tried putting the database(access) in the database folder, and straight in the directory with all the pages and I still get the same result, I have replaced the database, and contacted my host, and they say that the code is fine from what little the guy knew about CF. Below is the code if someone could share there knowledge I would as always appreciate it. And thank you !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN" HTML HEAD CFPARAM Name="ID" Default=1 cfquery name="selectcandidate" datasource="interview" maxrows=1 dbtype="ODBC" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile FROMinterview WHERE ID=#ID# /cfquery CFSET NextID=#id#+1 CFSET PrevID=#id#-1 TITLEInterview Candidates/TITLE /HEAD BODY bgcolor="6699ff" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" cfoutput query="Selectcandidate" table cellpadding="10" tr tdID/tdbr td#id#/tdbr /tr tr tdCandidate Name/tdbr td#EmpCandidate#/tdbr /tr tr tdSkill Background/td td#SKillBackground#/td /tr tr tdStatus/td td#Status#/td /tr tr tdRecruiter/td td#Recruiter#/td /tr tr td valign="top"Profile/td tdtextarea cols="50" rows="5" name="Profile"#profile#/textarea/td /tr /table BRBR table width="85%" border="0" TR TD align="left"a href="default2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="default2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
Re: Code review PLEASE
Are you trying to have the user page through one record at a time? Cause that's what you're going to get with this. You'll only ever get one user whose id equals the passed id ---snip--- WHERE ID=#ID# What I think you want is something like the following (quickly cut from existing code, so probably needs cleanup). cfset maxrows = "5" cfparam name="start" default = "1" cfquery name="selectcandidate" datasource="interview" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile FROMinterview /cfquery cfoutput query="selectcandidate" startrow="#start#" maxrows="#maxrows#" Table o' info here !-- --- Add previous and next buttons if needed. cfset prevstart = start - maxrows cfset nextstart = start + maxrows table width="100%" cellpadding="5" tr td cfif prevstart GTE 1 cfoutput form action="default2.cfm" method="post" input type="hidden" name="start" value="#prevstart#" input type="submit" value="Previous #maxrows#" /form /cfoutputcfelsenbsp;/cfif/td td cfif nextstart LT selectcandidates.recordcount cfoutputform action="default2.cfm" method="post" input type="hidden" name="start" value="#nextstart#" input type="submit" value="Next #maxrows#" /form/cfoutput cfelse nbsp; /cfif /td /tr /table Deanna Schneider Interactive Media Developer UWEX Cooperative Extension Electronic Publishing Group 103 Extension Bldg 432 N. Lake Street Madison, WI 53706 (608) 265-7923 ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
RE: Code review PLEASE
this may seem pretty obvious, but is your host using the same version of CF as you are locally? -- Stephenie Hamilton Senior ColdFusion Administrator Express Technologies, Inc. want CF_Freedom? try CFXHosting.com -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Thursday, March 15, 2001 2:47 PM To: CF-Talk Subject: Re: Code review PLEASE Your the second one to say that, but locally everything works fine, if I turn the max rows off then I will see all the records and I only want to see one record at time Michael "Cami Lawson" [EMAIL PROTECTED] wrote in message 010001c0ad87$6836dcb0$[EMAIL PROTECTED]">news:010001c0ad87$6836dcb0$[EMAIL PROTECTED]... You have a maxrows = 1 on the query. $.02 - Original Message - From: "Mike" [EMAIL PROTECTED] To: "CF-Talk" [EMAIL PROTECTED] Sent: Thursday, March 15, 2001 12:59 PM Subject: Code review PLEASE This is really making me go bald, I have a page that has next and previous, and when viewed locally I can see everything, when I ftp to my host (and yes the odbc is working and correct) I can only see the first record, and nothing after that. I have tried putting the database(access) in the database folder, and straight in the directory with all the pages and I still get the same result, I have replaced the database, and contacted my host, and they say that the code is fine from what little the guy knew about CF. Below is the code if someone could share there knowledge I would as always appreciate it. And thank you !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN" HTML HEAD CFPARAM Name="ID" Default=1 cfquery name="selectcandidate" datasource="interview" maxrows=1 dbtype="ODBC" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile FROMinterview WHERE ID=#ID# /cfquery CFSET NextID=#id#+1 CFSET PrevID=#id#-1 TITLEInterview Candidates/TITLE /HEAD BODY bgcolor="6699ff" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" cfoutput query="Selectcandidate" table cellpadding="10" tr tdID/tdbr td#id#/tdbr /tr tr tdCandidate Name/tdbr td#EmpCandidate#/tdbr /tr tr tdSkill Background/td td#SKillBackground#/td /tr tr tdStatus/td td#Status#/td /tr tr tdRecruiter/td td#Recruiter#/td /tr tr td valign="top"Profile/td tdtextarea cols="50" rows="5" name="Profile"#profile#/textarea/td /tr /table BRBR table width="85%" border="0" TR TD align="left"a href="default2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="default2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
Re: Code review PLEASE
Well, how many records are you going to have in the table for a particular ID? If ID is the unique, primary key, the first time you run it, it selects the record for ID=1, and gives you "prior" and "next" links for ID=0 and ID=2. The maxrows issue is a smokescreen to your real problem. Check to see what the value of ID is each time to make sure things are happening the way you want them to. If there are gaps in in your ID values, you will also have issues, as well as the fact that it is doubtful that you would have an ID of 0. DC - Original Message - From: "Mike" [EMAIL PROTECTED] To: "CF-Talk" [EMAIL PROTECTED] Sent: Thursday, March 15, 2001 14:46 Subject: Re: Code review PLEASE Your the second one to say that, but locally everything works fine, if I turn the max rows off then I will see all the records and I only want to see one record at time Michael "Cami Lawson" [EMAIL PROTECTED] wrote in message 010001c0ad87$6836dcb0$[EMAIL PROTECTED]">news:010001c0ad87$6836dcb0$[EMAIL PROTECTED]... You have a maxrows = 1 on the query. $.02 - Original Message - From: "Mike" [EMAIL PROTECTED] To: "CF-Talk" [EMAIL PROTECTED] Sent: Thursday, March 15, 2001 12:59 PM Subject: Code review PLEASE This is really making me go bald, I have a page that has next and previous, and when viewed locally I can see everything, when I ftp to my host (and yes the odbc is working and correct) I can only see the first record, and nothing after that. I have tried putting the database(access) in the database folder, and straight in the directory with all the pages and I still get the same result, I have replaced the database, and contacted my host, and they say that the code is fine from what little the guy knew about CF. Below is the code if someone could share there knowledge I would as always appreciate it. And thank you !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN" HTML HEAD CFPARAM Name="ID" Default=1 cfquery name="selectcandidate" datasource="interview" maxrows=1 dbtype="ODBC" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile FROMinterview WHERE ID=#ID# /cfquery CFSET NextID=#id#+1 CFSET PrevID=#id#-1 TITLEInterview Candidates/TITLE /HEAD BODY bgcolor="6699ff" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" cfoutput query="Selectcandidate" table cellpadding="10" tr tdID/tdbr td#id#/tdbr /tr tr tdCandidate Name/tdbr td#EmpCandidate#/tdbr /tr tr tdSkill Background/td td#SKillBackground#/td /tr tr tdStatus/td td#Status#/td /tr tr tdRecruiter/td td#Recruiter#/td /tr tr td valign="top"Profile/td tdtextarea cols="50" rows="5" name="Profile"#profile#/textarea/td /tr /table BRBR table width="85%" border="0" TR TD align="left"a href="default2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="default2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
Re: Code review PLEASE
OK my miss understanding, another developer showed me the prev and next code and when they did, they told me that I didnt need the max rows anymore. Although I question why it worked fine on the local machine and not when posted? THANK YOU MICHAEL egg on my face "Cami Lawson" [EMAIL PROTECTED] wrote in message 010001c0ad87$6836dcb0$[EMAIL PROTECTED]">news:010001c0ad87$6836dcb0$[EMAIL PROTECTED]... You have a maxrows = 1 on the query. $.02 - Original Message - From: "Mike" [EMAIL PROTECTED] To: "CF-Talk" [EMAIL PROTECTED] Sent: Thursday, March 15, 2001 12:59 PM Subject: Code review PLEASE This is really making me go bald, I have a page that has next and previous, and when viewed locally I can see everything, when I ftp to my host (and yes the odbc is working and correct) I can only see the first record, and nothing after that. I have tried putting the database(access) in the database folder, and straight in the directory with all the pages and I still get the same result, I have replaced the database, and contacted my host, and they say that the code is fine from what little the guy knew about CF. Below is the code if someone could share there knowledge I would as always appreciate it. And thank you !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN" HTML HEAD CFPARAM Name="ID" Default=1 cfquery name="selectcandidate" datasource="interview" maxrows=1 dbtype="ODBC" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile FROMinterview WHERE ID=#ID# /cfquery CFSET NextID=#id#+1 CFSET PrevID=#id#-1 TITLEInterview Candidates/TITLE /HEAD BODY bgcolor="6699ff" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" cfoutput query="Selectcandidate" table cellpadding="10" tr tdID/tdbr td#id#/tdbr /tr tr tdCandidate Name/tdbr td#EmpCandidate#/tdbr /tr tr tdSkill Background/td td#SKillBackground#/td /tr tr tdStatus/td td#Status#/td /tr tr tdRecruiter/td td#Recruiter#/td /tr tr td valign="top"Profile/td tdtextarea cols="50" rows="5" name="Profile"#profile#/textarea/td /tr /table BRBR table width="85%" border="0" TR TD align="left"a href="default2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="default2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
RE: Code review PLEASE
Michael, What error are you getting when not-local? Your code looks fine to me, I'm wondering if this bit is 100% correct though: CFSET NextID=#id#+1 Since it works fine the first time, the problem has got to be "after" the first pass through, right? Try making sure that ID is a not a string, and is in fact a number after you increment it. Douglas Malcolm -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Thursday, March 15, 2001 11:47 AM To: CF-Talk Subject: Re: Code review PLEASE Your the second one to say that, but locally everything works fine, if I turn the max rows off then I will see all the records and I only want to see one record at time Michael "Cami Lawson" [EMAIL PROTECTED] wrote in message 010001c0ad87$6836dcb0$[EMAIL PROTECTED]">news:010001c0ad87$6836dcb0$[EMAIL PROTECTED]... You have a maxrows = 1 on the query. $.02 - Original Message - From: "Mike" [EMAIL PROTECTED] To: "CF-Talk" [EMAIL PROTECTED] Sent: Thursday, March 15, 2001 12:59 PM Subject: Code review PLEASE This is really making me go bald, I have a page that has next and previous, and when viewed locally I can see everything, when I ftp to my host (and yes the odbc is working and correct) I can only see the first record, and nothing after that. I have tried putting the database(access) in the database folder, and straight in the directory with all the pages and I still get the same result, I have replaced the database, and contacted my host, and they say that the code is fine from what little the guy knew about CF. Below is the code if someone could share there knowledge I would as always appreciate it. And thank you !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN" HTML HEAD CFPARAM Name="ID" Default=1 cfquery name="selectcandidate" datasource="interview" maxrows=1 dbtype="ODBC" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile FROMinterview WHERE ID=#ID# /cfquery CFSET NextID=#id#+1 CFSET PrevID=#id#-1 TITLEInterview Candidates/TITLE /HEAD BODY bgcolor="6699ff" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" cfoutput query="Selectcandidate" table cellpadding="10" tr tdID/tdbr td#id#/tdbr /tr tr tdCandidate Name/tdbr td#EmpCandidate#/tdbr /tr tr tdSkill Background/td td#SKillBackground#/td /tr tr tdStatus/td td#Status#/td /tr tr tdRecruiter/td td#Recruiter#/td /tr tr td valign="top"Profile/td tdtextarea cols="50" rows="5" name="Profile"#profile#/textarea/td /tr /table BRBR table width="85%" border="0" TR TD align="left"a href="default2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="default2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
Re: Code review PLEASE
At 02:46 PM 3/15/01 -0500, you wrote: Your the second one to say that, but locally everything works fine, if I turn the max rows off then I will see all the records and I only want to see one record at time Michael The problem isn't with maxrows, it's with ID. the cfparam statement isn't finding it so it sets it to the default of one. ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
RE: Code review PLEASE
Put CFOUTPTUT around the CFSET for your NEXT/PREV variables Your MAXROWS=1 is fine -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Thursday, March 15, 2001 2:47 PM To: CF-Talk Subject: Re: Code review PLEASE Your the second one to say that, but locally everything works fine, if I turn the max rows off then I will see all the records and I only want to see one record at time Michael "Cami Lawson" [EMAIL PROTECTED] wrote in message 010001c0ad87$6836dcb0$[EMAIL PROTECTED]">news:010001c0ad87$6836dcb0$[EMAIL PROTECTED]... You have a maxrows = 1 on the query. $.02 - Original Message - From: "Mike" [EMAIL PROTECTED] To: "CF-Talk" [EMAIL PROTECTED] Sent: Thursday, March 15, 2001 12:59 PM Subject: Code review PLEASE This is really making me go bald, I have a page that has next and previous, and when viewed locally I can see everything, when I ftp to my host (and yes the odbc is working and correct) I can only see the first record, and nothing after that. I have tried putting the database(access) in the database folder, and straight in the directory with all the pages and I still get the same result, I have replaced the database, and contacted my host, and they say that the code is fine from what little the guy knew about CF. Below is the code if someone could share there knowledge I would as always appreciate it. And thank you !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN" HTML HEAD CFPARAM Name="ID" Default=1 cfquery name="selectcandidate" datasource="interview" maxrows=1 dbtype="ODBC" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile FROMinterview WHERE ID=#ID# /cfquery CFSET NextID=#id#+1 CFSET PrevID=#id#-1 TITLEInterview Candidates/TITLE /HEAD BODY bgcolor="6699ff" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" cfoutput query="Selectcandidate" table cellpadding="10" tr tdID/tdbr td#id#/tdbr /tr tr tdCandidate Name/tdbr td#EmpCandidate#/tdbr /tr tr tdSkill Background/td td#SKillBackground#/td /tr tr tdStatus/td td#Status#/td /tr tr tdRecruiter/td td#Recruiter#/td /tr tr td valign="top"Profile/td tdtextarea cols="50" rows="5" name="Profile"#profile#/textarea/td /tr /table BRBR table width="85%" border="0" TR TD align="left"a href="default2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="default2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
Re: Code review PLEASE
Take maxrows out of the cfquery and add it to the cfoutput along with a startrow attribute. Jason - Original Message - From: "Mike" [EMAIL PROTECTED] To: "CF-Talk" [EMAIL PROTECTED] Sent: Thursday, March 15, 2001 12:46 PM Subject: Re: Code review PLEASE Your the second one to say that, but locally everything works fine, if I turn the max rows off then I will see all the records and I only want to see one record at time Michael "Cami Lawson" [EMAIL PROTECTED] wrote in message 010001c0ad87$6836dcb0$[EMAIL PROTECTED]">news:010001c0ad87$6836dcb0$[EMAIL PROTECTED]... You have a maxrows = 1 on the query. $.02 - Original Message - From: "Mike" [EMAIL PROTECTED] To: "CF-Talk" [EMAIL PROTECTED] Sent: Thursday, March 15, 2001 12:59 PM Subject: Code review PLEASE This is really making me go bald, I have a page that has next and previous, and when viewed locally I can see everything, when I ftp to my host (and yes the odbc is working and correct) I can only see the first record, and nothing after that. I have tried putting the database(access) in the database folder, and straight in the directory with all the pages and I still get the same result, I have replaced the database, and contacted my host, and they say that the code is fine from what little the guy knew about CF. Below is the code if someone could share there knowledge I would as always appreciate it. And thank you !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN" HTML HEAD CFPARAM Name="ID" Default=1 cfquery name="selectcandidate" datasource="interview" maxrows=1 dbtype="ODBC" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile FROMinterview WHERE ID=#ID# /cfquery CFSET NextID=#id#+1 CFSET PrevID=#id#-1 TITLEInterview Candidates/TITLE /HEAD BODY bgcolor="6699ff" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" cfoutput query="Selectcandidate" table cellpadding="10" tr tdID/tdbr td#id#/tdbr /tr tr tdCandidate Name/tdbr td#EmpCandidate#/tdbr /tr tr tdSkill Background/td td#SKillBackground#/td /tr tr tdStatus/td td#Status#/td /tr tr tdRecruiter/td td#Recruiter#/td /tr tr td valign="top"Profile/td tdtextarea cols="50" rows="5" name="Profile"#profile#/textarea/td /tr /table BRBR table width="85%" border="0" TR TD align="left"a href="default2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="default2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
Re: Code review PLEASE
Yes "Stephenie Hamilton" [EMAIL PROTECTED] wrote in message [EMAIL PROTECTED]">news:[EMAIL PROTECTED]... this may seem pretty obvious, but is your host using the same version of CF as you are locally? -- Stephenie Hamilton Senior ColdFusion Administrator Express Technologies, Inc. want CF_Freedom? try CFXHosting.com -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Thursday, March 15, 2001 2:47 PM To: CF-Talk Subject: Re: Code review PLEASE Your the second one to say that, but locally everything works fine, if I turn the max rows off then I will see all the records and I only want to see one record at time Michael "Cami Lawson" [EMAIL PROTECTED] wrote in message 010001c0ad87$6836dcb0$[EMAIL PROTECTED]">news:010001c0ad87$6836dcb0$[EMAIL PROTECTED]... You have a maxrows = 1 on the query. $.02 - Original Message - From: "Mike" [EMAIL PROTECTED] To: "CF-Talk" [EMAIL PROTECTED] Sent: Thursday, March 15, 2001 12:59 PM Subject: Code review PLEASE This is really making me go bald, I have a page that has next and previous, and when viewed locally I can see everything, when I ftp to my host (and yes the odbc is working and correct) I can only see the first record, and nothing after that. I have tried putting the database(access) in the database folder, and straight in the directory with all the pages and I still get the same result, I have replaced the database, and contacted my host, and they say that the code is fine from what little the guy knew about CF. Below is the code if someone could share there knowledge I would as always appreciate it. And thank you !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN" HTML HEAD CFPARAM Name="ID" Default=1 cfquery name="selectcandidate" datasource="interview" maxrows=1 dbtype="ODBC" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile FROMinterview WHERE ID=#ID# /cfquery CFSET NextID=#id#+1 CFSET PrevID=#id#-1 TITLEInterview Candidates/TITLE /HEAD BODY bgcolor="6699ff" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" cfoutput query="Selectcandidate" table cellpadding="10" tr tdID/tdbr td#id#/tdbr /tr tr tdCandidate Name/tdbr td#EmpCandidate#/tdbr /tr tr tdSkill Background/td td#SKillBackground#/td /tr tr tdStatus/td td#Status#/td /tr tr tdRecruiter/td td#Recruiter#/td /tr tr td valign="top"Profile/td tdtextarea cols="50" rows="5" name="Profile"#profile#/textarea/td /tr /table BRBR table width="85%" border="0" TR TD align="left"a href="default2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="default2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
Re: Code review PLEASE
Mike do a little debugging on the host. What is the value of #nextid# and #previd# on the page? When you click next on the host, does it show the first record everytime? Does the url always say default2.cfm?ID=2 ? If so, it's obvious that the sql statement is not picking up the url variable and probably is only picking up the cfparam variable. Try scoping your variables just to make sure. If this isn't the problem it is always a good idea to scope variables, it makes the code a little easier to read later on, and it executes faster. cfparam name="url.id" default="1" cfquery name="selectcandidate" datasource="interview" maxrows=1 dbtype="ODBC" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile FROMinterview WHERE ID=#url.id# /cfquery cfset nextid = url.id + 1 cfset previd = url.id - 1 Notice no pound signs within the cfsets, it is again easier to read and executes slightly faster. One problem I see is that you are relying the ID to be sequential in the database. If you delete a record, eventually you will run into a query that has no record and shows a blank page. I think a better way to do all this if the user does not have the ability to edit records, would be to cache the query and use startrow and maxrow in your cfoutput. Like so... cfparam name="url.id" default="1" cfquery name="selectcandidate" datasource="interview" dbtype="ODBC" cachedwithin="#CreateTimeSpan(0,0,0,10)#" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile /cfquery cfset nextid = url.id + 1 cfset previd = url.id - 1 cfoutput query="selectCandidate" startrow="#url.id" maxrows="1" Data here td align="left"a href="default2.cfm?ID=#PrevID#"Previous/a/td td align="right"a href="default2.cfm?ID=#NextID#"Next/a/td /cfoutput This will work even without caching, but might as well make it quicker. jon - Original Message - From: "Mike" [EMAIL PROTECTED] To: "CF-Talk" [EMAIL PROTECTED] Sent: Thursday, March 15, 2001 1:59 PM Subject: Code review PLEASE This is really making me go bald, I have a page that has next and previous, and when viewed locally I can see everything, when I ftp to my host (and yes the odbc is working and correct) I can only see the first record, and nothing after that. I have tried putting the database(access) in the database folder, and straight in the directory with all the pages and I still get the same result, I have replaced the database, and contacted my host, and they say that the code is fine from what little the guy knew about CF. Below is the code if someone could share there knowledge I would as always appreciate it. And thank you !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN" HTML HEAD CFPARAM Name="ID" Default=1 cfquery name="selectcandidate" datasource="interview" maxrows=1 dbtype="ODBC" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile FROMinterview WHERE ID=#ID# /cfquery CFSET NextID=#id#+1 CFSET PrevID=#id#-1 TITLEInterview Candidates/TITLE /HEAD BODY bgcolor="6699ff" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" cfoutput query="Selectcandidate" table cellpadding="10" tr tdID/tdbr td#id#/tdbr /tr tr tdCandidate Name/tdbr td#EmpCandidate#/tdbr /tr tr tdSkill Background/td td#SKillBackground#/td /tr tr tdStatus/td td#Status#/td /tr tr tdRecruiter/td td#Recruiter#/td /tr tr td valign="top"Profile/td tdtextarea cols="50" rows="5" name="Profile"#profile#/textarea/td /tr /table BRBR table width="85%" border="0" TR TD align="left"a href="default2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="default2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
Re: Code review PLEASE
I took out the max rows, and reposted it and everything works fine, well kinda fine, the only dilema now is that once you go past the last record it show's a blank page, and vice versa for the first page if you scroll back, so now I am trying to figure that one out, thank you to all that answered. Michael "Adkins, Randy" [EMAIL PROTECTED] wrote in message [EMAIL PROTECTED]">news:[EMAIL PROTECTED]... Put CFOUTPTUT around the CFSET for your NEXT/PREV variables Your MAXROWS=1 is fine -Original Message- From: Mike [mailto:[EMAIL PROTECTED]] Sent: Thursday, March 15, 2001 2:47 PM To: CF-Talk Subject: Re: Code review PLEASE Your the second one to say that, but locally everything works fine, if I turn the max rows off then I will see all the records and I only want to see one record at time Michael "Cami Lawson" [EMAIL PROTECTED] wrote in message 010001c0ad87$6836dcb0$[EMAIL PROTECTED]">news:010001c0ad87$6836dcb0$[EMAIL PROTECTED]... You have a maxrows = 1 on the query. $.02 - Original Message - From: "Mike" [EMAIL PROTECTED] To: "CF-Talk" [EMAIL PROTECTED] Sent: Thursday, March 15, 2001 12:59 PM Subject: Code review PLEASE This is really making me go bald, I have a page that has next and previous, and when viewed locally I can see everything, when I ftp to my host (and yes the odbc is working and correct) I can only see the first record, and nothing after that. I have tried putting the database(access) in the database folder, and straight in the directory with all the pages and I still get the same result, I have replaced the database, and contacted my host, and they say that the code is fine from what little the guy knew about CF. Below is the code if someone could share there knowledge I would as always appreciate it. And thank you !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN" HTML HEAD CFPARAM Name="ID" Default=1 cfquery name="selectcandidate" datasource="interview" maxrows=1 dbtype="ODBC" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile FROMinterview WHERE ID=#ID# /cfquery CFSET NextID=#id#+1 CFSET PrevID=#id#-1 TITLEInterview Candidates/TITLE /HEAD BODY bgcolor="6699ff" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" cfoutput query="Selectcandidate" table cellpadding="10" tr tdID/tdbr td#id#/tdbr /tr tr tdCandidate Name/tdbr td#EmpCandidate#/tdbr /tr tr tdSkill Background/td td#SKillBackground#/td /tr tr tdStatus/td td#Status#/td /tr tr tdRecruiter/td td#Recruiter#/td /tr tr td valign="top"Profile/td tdtextarea cols="50" rows="5" name="Profile"#profile#/textarea/td /tr /table BRBR table width="85%" border="0" TR TD align="left"a href="default2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="default2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
Re: Code review PLEASE
THank You Jon, I am trying some of what other's here on the list suggested also. Michael "Jon Hall" [EMAIL PROTECTED] wrote in message 028701c0ad91$fd121de0$a41f88d8@ns2">news:028701c0ad91$fd121de0$a41f88d8@ns2... Mike do a little debugging on the host. What is the value of #nextid# and #previd# on the page? When you click next on the host, does it show the first record everytime? Does the url always say default2.cfm?ID=2 ? If so, it's obvious that the sql statement is not picking up the url variable and probably is only picking up the cfparam variable. Try scoping your variables just to make sure. If this isn't the problem it is always a good idea to scope variables, it makes the code a little easier to read later on, and it executes faster. cfparam name="url.id" default="1" cfquery name="selectcandidate" datasource="interview" maxrows=1 dbtype="ODBC" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile FROMinterview WHERE ID=#url.id# /cfquery cfset nextid = url.id + 1 cfset previd = url.id - 1 Notice no pound signs within the cfsets, it is again easier to read and executes slightly faster. One problem I see is that you are relying the ID to be sequential in the database. If you delete a record, eventually you will run into a query that has no record and shows a blank page. I think a better way to do all this if the user does not have the ability to edit records, would be to cache the query and use startrow and maxrow in your cfoutput. Like so... cfparam name="url.id" default="1" cfquery name="selectcandidate" datasource="interview" dbtype="ODBC" cachedwithin="#CreateTimeSpan(0,0,0,10)#" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile /cfquery cfset nextid = url.id + 1 cfset previd = url.id - 1 cfoutput query="selectCandidate" startrow="#url.id" maxrows="1" Data here td align="left"a href="default2.cfm?ID=#PrevID#"Previous/a/td td align="right"a href="default2.cfm?ID=#NextID#"Next/a/td /cfoutput This will work even without caching, but might as well make it quicker. jon - Original Message - From: "Mike" [EMAIL PROTECTED] To: "CF-Talk" [EMAIL PROTECTED] Sent: Thursday, March 15, 2001 1:59 PM Subject: Code review PLEASE This is really making me go bald, I have a page that has next and previous, and when viewed locally I can see everything, when I ftp to my host (and yes the odbc is working and correct) I can only see the first record, and nothing after that. I have tried putting the database(access) in the database folder, and straight in the directory with all the pages and I still get the same result, I have replaced the database, and contacted my host, and they say that the code is fine from what little the guy knew about CF. Below is the code if someone could share there knowledge I would as always appreciate it. And thank you !DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN" HTML HEAD CFPARAM Name="ID" Default=1 cfquery name="selectcandidate" datasource="interview" maxrows=1 dbtype="ODBC" SELECT ID, EmpCandidate, SKillBackground, Status, Recruiter, Profile FROMinterview WHERE ID=#ID# /cfquery CFSET NextID=#id#+1 CFSET PrevID=#id#-1 TITLEInterview Candidates/TITLE /HEAD BODY bgcolor="6699ff" !--- include toolbar.cfm--- cfinclude template="Toolbar.cfm" cfoutput query="Selectcandidate" table cellpadding="10" tr tdID/tdbr td#id#/tdbr /tr tr tdCandidate Name/tdbr td#EmpCandidate#/tdbr /tr tr tdSkill Background/td td#SKillBackground#/td /tr tr tdStatus/td td#Status#/td /tr tr tdRecruiter/td td#Recruiter#/td /tr tr td valign="top"Profile/td tdtextarea cols="50" rows="5" name="Profile"#profile#/textarea/td /tr /table BRBR table width="85%" border="0" TR TD align="left"a href="default2.cfm?ID=#PrevID#"Previous/a/TD td align="right"a href="default2.cfm?ID=#NextID#"Next/a/td /td/TR/table /cfoutput ~~ Structure your ColdFusion code with Fusebox. Get the official book at http://www.fusionauthority.com/bkinfo.cfm Archives: http://www.mail-archive.com/cf-talk@houseoffusion.com/ Unsubscribe: http://www.houseoffusion.com/index.cfm?sidebar=lists
