Re: [PATCH] [Patch] Assertion failure when a multidimensional array allocated with new operator is explicitly list initialized.

2013-11-25 Thread jyoti allur
Well, this seems to be fixed in clang version 3.4 (tags/RELEASE_34/rc1) as well as clang version 3.5 (195639) Thanks. http://llvm-reviews.chandlerc.com/D1986 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/li

Re: [PATCHv2] implement -Wold-style-cast

2013-11-25 Thread Dmitri Gribenko
On Mon, Nov 25, 2013 at 11:11 PM, Alp Toker wrote: > In light of this, and considering also that we don't usually make an effort > to produce FixIts for warning-level diagnostics in Sema, the original patch > to the parser by Ondřej looks fine to me. Dmitri, is that OK with you? Yes, this is fine

Re: [PATCHv2] implement -Wold-style-cast

2013-11-25 Thread Alp Toker
On 26/11/2013 06:29, Sean Silva wrote: On Tue, Nov 26, 2013 at 12:37 AM, Alp Toker > wrote: On 22/11/2013 15:54, Ondřej Hošek wrote: I've been trying to implement the relevant fix-it, but apart from not being able to find the end of the

Re: [PATCH] CMake: Enable building clang-format's Visual Studio plugin

2013-11-25 Thread Manuel Klimek
On Mon, Nov 25, 2013 at 10:49 PM, Hans Wennborg wrote: > On Mon, Nov 25, 2013 at 12:50 AM, Manuel Klimek wrote: > > On Sat, Nov 23, 2013 at 1:27 AM, Hans Wennborg > wrote: > >> > >> On Thu, Nov 21, 2013 at 10:53 PM, Manuel Klimek > wrote: > >> > I personally actually think we should somehow ba

Re: [PATCHv2] implement -Wold-style-cast

2013-11-25 Thread Sean Silva
On Tue, Nov 26, 2013 at 12:37 AM, Alp Toker wrote: > > On 22/11/2013 15:54, Ondřej Hošek wrote: > >> I've been trying to implement the relevant fix-it, but apart from not >> being able to find the end of the expression being cast (to insert the >> closing paren), the pathological case >> >> On Fr

Re: [PATCHv2] implement -Wold-style-cast

2013-11-25 Thread Alp Toker
On 22/11/2013 15:54, Ondřej Hošek wrote: I've been trying to implement the relevant fix-it, but apart from not being able to find the end of the expression being cast (to insert the closing paren), the pathological case On Fri, Nov 22, 2013 at 2:13 AM, Dmitri Gribenko wrote: (for example, sta

Re: [PATCH][AArch64] request to push AArch64 patches to release 3.4 branch

2013-11-25 Thread Jiangning Liu
Bill, Can you merge r195716 to branch 3.4 as well? Thanks, -Jiangning 2013/11/26 Bill Wendling > Sure. Done. > > -bw > > > > On Mon, Nov 25, 2013 at 9:59 AM, Ana Pazos wrote: > >> Thank you Bill, >> >> We have a fix from Hao that should also go into branch 3.4 (it's a fix of >> encoding error

r195714 - Remove some unused locals

2013-11-25 Thread Alp Toker
Author: alp Date: Mon Nov 25 20:52:41 2013 New Revision: 195714 URL: http://llvm.org/viewvc/llvm-project?rev=195714&view=rev Log: Remove some unused locals Modified: cfe/trunk/lib/AST/ASTDiagnostic.cpp cfe/trunk/lib/CodeGen/CGClass.cpp Modified: cfe/trunk/lib/AST/ASTDiagnostic.cpp URL:

r195710 - Unbreak -fms-extensions with GNU libc headers

2013-11-25 Thread Alp Toker
Author: alp Date: Mon Nov 25 19:30:10 2013 New Revision: 195710 URL: http://llvm.org/viewvc/llvm-project?rev=195710&view=rev Log: Unbreak -fms-extensions with GNU libc headers GNU libc uses '__uptr' as a member name in C mode, conflicting with the eponymous MSVC pointer modifier keyword. Detect

r195703 - Fix buildbot.

2013-11-25 Thread Richard Smith
Author: rsmith Date: Mon Nov 25 18:40:46 2013 New Revision: 195703 URL: http://llvm.org/viewvc/llvm-project?rev=195703&view=rev Log: Fix buildbot. Modified: cfe/trunk/test/CXX/drs/dr2xx.cpp Modified: cfe/trunk/test/CXX/drs/dr2xx.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CX

Re: r195626 - Tests for core issues 270-300.

2013-11-25 Thread Richard Smith
This was fixed in r195673. It failed on targets where size_t was 'unsigned'. Sorry for breaking you! On Mon, Nov 25, 2013 at 1:45 AM, Renato Golin wrote: > Hi Richard, > > Not sure what the error is, or why it's only failing on our bots... > > > http://lab.llvm.org:8011/builders/clang-native-arm

Re: [PATCH] Let __attribute__((format(…))) accept OFStrings

2013-11-25 Thread Alp Toker
On 25/11/2013 00:01, Jonathan Schleifer wrote: Hi! Actually, the patch already became obsolete after some discussion about the patch in my other mail. The patch obsoleting it is http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131118/094025.html. I couldn't find many projects ou

Re: [libcxx] r195693 - Don't use T as template argument, it is part of the application

2013-11-25 Thread Joerg Sonnenberger
On Mon, Nov 25, 2013 at 10:44:21PM -, Joerg Sonnenberger wrote: > Author: joerg > Date: Mon Nov 25 16:44:20 2013 > New Revision: 195693 > > URL: http://llvm.org/viewvc/llvm-project?rev=195693&view=rev > Log: > Don't use T as template argument, it is part of the application > namespace. This s

Re: [PATCH] Support for address space casting in order to map these on the new 'addrspacecast' IR instruction

2013-11-25 Thread Michele Scandale
Hi pekka, I think the assertion you reported is related to the introduction of the 'addrspacecast' instruction: now the bitcast is illegal when you want to convert a pointer between different address space, you have to use addrspacecast instead. This patch do not prevent *explicit casts

[libcxx] r195693 - Don't use T as template argument, it is part of the application

2013-11-25 Thread Joerg Sonnenberger
Author: joerg Date: Mon Nov 25 16:44:20 2013 New Revision: 195693 URL: http://llvm.org/viewvc/llvm-project?rev=195693&view=rev Log: Don't use T as template argument, it is part of the application namespace. Modified: libcxx/trunk/include/ext/__hash libcxx/trunk/include/type_traits Modifi

Re: [PATCH] Documentation parsing: allow some commands to have multiple paragraphs attached

2013-11-25 Thread Dmitri Gribenko
On Sat, Nov 23, 2013 at 4:35 AM, Dimitri van Heesch wrote: > I think I've explained that it does differ. It would make it harder for users > to write documentation that works well with clang and doxygen. So I hope it > is possible to make the implementation more in line with the way > doxygen proc

Re: [PATCH][AArch64] Add support for vget/vset_lane_f16 ACLE functions

2013-11-25 Thread Chad Rosier
> Hi Chad, > >> According to the latest documentation I have the ACLE prototypes for >> vget/vset_lane_f16 are: >> >> float16_t vget_lane_f16(float16x4_t v, const int lane) > > My interpretation has always been that the prototypes and calling > conventions of the intrinsics themselves are merely n

Re: [PATCH] CMake: Enable building clang-format's Visual Studio plugin

2013-11-25 Thread Hans Wennborg
On Mon, Nov 25, 2013 at 12:50 AM, Manuel Klimek wrote: > On Sat, Nov 23, 2013 at 1:27 AM, Hans Wennborg wrote: >> >> On Thu, Nov 21, 2013 at 10:53 PM, Manuel Klimek wrote: >> > I personally actually think we should somehow bake clang-format into the >> > extension (if possible) and distribute it

r195690 - Clang format VS plugin: update build prerequisites in the README

2013-11-25 Thread Hans Wennborg
Author: hans Date: Mon Nov 25 15:42:06 2013 New Revision: 195690 URL: http://llvm.org/viewvc/llvm-project?rev=195690&view=rev Log: Clang format VS plugin: update build prerequisites in the README Modified: cfe/trunk/tools/clang-format-vs/README.txt Modified: cfe/trunk/tools/clang-format-vs/R

r195687 - PR18044: Reject declarations of enumtype::X early to avoid an assertion in

2013-11-25 Thread Richard Smith
Author: rsmith Date: Mon Nov 25 15:30:29 2013 New Revision: 195687 URL: http://llvm.org/viewvc/llvm-project?rev=195687&view=rev Log: PR18044: Reject declarations of enumtype::X early to avoid an assertion in downstream code. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp cfe/trunk/test/SemaCXX

Re: XCore target exception handling

2013-11-25 Thread Eric Christopher
Don't suppose I can get you to upload these to phabricator? http://llvm-reviews.chandlerc.com/ Thanks! -eric On Tue, Nov 12, 2013 at 2:51 AM, Robert Lytton wrote: > Hi, > > I've separated the handling of "-fverbose-asm" into its own patch. > Are they good to go from a clang perspective? > > Pa

Re: [PATCH] Sema: Instantiate local class and their members appropriately

2013-11-25 Thread Richard Smith
LGTM with some tiny tweaks. Thank you! Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:674-677 @@ -665,5 +673,6 @@ // not the definitions of scoped member enumerations. // FIXME: There appears to be no wording for what happens for an enum defined // within a bloc

Re: [PATCH][AArch64] Add support for vget/vset_lane_f16 ACLE functions

2013-11-25 Thread Tim Northover
Hi Chad, > According to the latest documentation I have the ACLE prototypes for > vget/vset_lane_f16 are: > > float16_t vget_lane_f16(float16x4_t v, const int lane) My interpretation has always been that the prototypes and calling conventions of the intrinsics themselves are merely notional. If t

Re: [PATCH][AArch64] Add support for vget/vset_lane_f16 ACLE functions

2013-11-25 Thread Chad Rosier
Hi Tim, > Hi Chad, > >> I'm checking the target triple to allow for half-float arguments/return >> types in Sema. However, I'm currently looking into defining the AArch64 >> PCS as an alternative solution. I was hoping we could get these patches >> into the 3.4 release, so I'm sending patches wit

Re: [PATCH][AArch64] Add support for vget/vset_lane_f16 ACLE functions

2013-11-25 Thread Tim Northover
Hi Chad, > I'm checking the target triple to allow for half-float arguments/return > types in Sema. However, I'm currently looking into defining the AArch64 > PCS as an alternative solution. I was hoping we could get these patches > into the 3.4 release, so I'm sending patches with the less inva

Re: libcxx: support typeids across DLL boundary

2013-11-25 Thread Reid Kleckner
On Sat, Nov 23, 2013 at 2:49 AM, Yaron Keren wrote: > In MSVC raw_name does return a unique name: > > tu1().raw_name: .?AUFoo@?A0x08cd7644@@ > tu2().raw_name: .?AUFoo@?A0x8e5904ea@@ > > In gcc these are the same. > > libsupc++ code compares pointer to type, pointers to the name or the name > itse

Re: [PATCH] Consistency for type_tag_for_datatype subject

2013-11-25 Thread Aaron Ballman
Thanks! Committed with your recommendations in r195675. ~Aaron On Sun, Nov 24, 2013 at 6:23 PM, Dmitri Gribenko wrote: > On Sun, Nov 24, 2013 at 2:18 PM, Aaron Ballman wrote: >> Attr.td claims that type_tag_for_datatype only applies to VarDecl >> subjects, but SemaDeclAttr.cpp was not checking

r195676 - Make the integrated assembler the default for cygwin/mingw too.

2013-11-25 Thread Rafael Espindola
Author: rafael Date: Mon Nov 25 12:50:53 2013 New Revision: 195676 URL: http://llvm.org/viewvc/llvm-project?rev=195676&view=rev Log: Make the integrated assembler the default for cygwin/mingw too. The integrated assembler was already the default for win32. It is now able to handle a clang bootstr

r195675 - Making type_tag_for_datatype consistent with its declared subject from Attr.td. Also updated the related testcase.

2013-11-25 Thread Aaron Ballman
Author: aaronballman Date: Mon Nov 25 12:50:49 2013 New Revision: 195675 URL: http://llvm.org/viewvc/llvm-project?rev=195675&view=rev Log: Making type_tag_for_datatype consistent with its declared subject from Attr.td. Also updated the related testcase. Reviewed by Dmitri Gribenko. Modified:

r195673 - Fix test failure on targets where size_t is unsigned int.

2013-11-25 Thread Richard Smith
Author: rsmith Date: Mon Nov 25 12:23:23 2013 New Revision: 195673 URL: http://llvm.org/viewvc/llvm-project?rev=195673&view=rev Log: Fix test failure on targets where size_t is unsigned int. Modified: cfe/trunk/test/CXX/drs/dr2xx.cpp Modified: cfe/trunk/test/CXX/drs/dr2xx.cpp URL: http://ll

Re: [PATCH][AArch64] request to push AArch64 patches to release 3.4 branch

2013-11-25 Thread Bill Wendling
Sure. Done. -bw On Mon, Nov 25, 2013 at 9:59 AM, Ana Pazos wrote: > Thank you Bill, > > We have a fix from Hao that should also go into branch 3.4 (it's a fix of > encoding error for ld/st instruction): r195591 > > Can you merge it too, please. > > Thanks, > Ana. > > -Original Message

[PATCH][AArch64] Add support for vget/vset_lane_f16 ACLE functions

2013-11-25 Thread Chad Rosier
All, The attached patches add support for the vget_lane_f16, vgetq_lane_f16, vset_lane_f16, and vsetq_lane_f16 ACLEs. I'm checking the target triple to allow for half-float arguments/return types in Sema. However, I'm currently looking into defining the AArch64 PCS as an alternative solution. I

RE: [PATCH][AArch64] request to push AArch64 patches to release 3.4 branch

2013-11-25 Thread Ana Pazos
Thank you Bill, We have a fix from Hao that should also go into branch 3.4 (it's a fix of encoding error for ld/st instruction): r195591 Can you merge it too, please. Thanks, Ana. -Original Message- From: Bill Wendling [mailto:isanb...@gmail.com] Sent: Sunday, November 24, 2013 9:44 PM

r195669 - [-cxx-abi microsoft] Create backrefs for

2013-11-25 Thread David Majnemer
Author: majnemer Date: Mon Nov 25 11:50:19 2013 New Revision: 195669 URL: http://llvm.org/viewvc/llvm-project?rev=195669&view=rev Log: [-cxx-abi microsoft] Create backrefs for It wasn't possible for an anonymous type to show up inside of function arguments. However, decltype (which MSVC added s

Re: [PATCH] Fixing Alias-Avoidance Padding for MS-ABI Layout

2013-11-25 Thread Warren Hunt
Oops on the test cases. They exist, I'll add them when I get back to my machine in Mountain View. http://llvm-reviews.chandlerc.com/D2258 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] Sema: Instantiate local class and their members appropriately

2013-11-25 Thread David Majnemer
A gentle ping. :) http://llvm-reviews.chandlerc.com/D2236 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] Introduce Registry::getCompletions.

2013-11-25 Thread Samuel Benzaquen
LG for me. @klimek, do you have comments? http://llvm-reviews.chandlerc.com/D2210 BRANCH clangquery9 ARCANIST PROJECT clang ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] Another pass at adding missing matchers into the registry.

2013-11-25 Thread Samuel Benzaquen
Closed by commit rL195647 (authored by @sbenza). CHANGED PRIOR TO COMMIT http://llvm-reviews.chandlerc.com/D2253?vs=5734&id=5765#toc http://llvm-reviews.chandlerc.com/D2253 COMMIT http://llvm-reviews.chandlerc.com/rL195647 ___ cfe-commits mailin

r195647 - Another pass at adding missing matchers into the registry.

2013-11-25 Thread Samuel Benzaquen
Author: sbenza Date: Mon Nov 25 09:03:44 2013 New Revision: 195647 URL: http://llvm.org/viewvc/llvm-project?rev=195647&view=rev Log: Another pass at adding missing matchers into the registry. Summary: Another pass at adding missing matchers into the registry. Reviewers: klimek CC: cfe-commits,

Re: [PATCH] Introduce Parser::completeExpression.

2013-11-25 Thread Samuel Benzaquen
Comment at: lib/ASTMatchers/Dynamic/Parser.cpp:294 @@ -262,2 +293,3 @@ << CommaToken.Text; +ContextStack.pop_back(); return false; Can you add a scoped object that will pop_back automatically? Comment at: lib/ASTMat

RE: [PATCH] Enable FeatureMP for Cortex-A5 by default

2013-11-25 Thread Amara Emerson
Committed in r195640 & r195641. Cheers, Amara ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

r195641 - [ARM] Enable FeatureMP for Cortex-A5 by default.

2013-11-25 Thread Amara Emerson
Author: aemerson Date: Mon Nov 25 07:18:59 2013 New Revision: 195641 URL: http://llvm.org/viewvc/llvm-project?rev=195641&view=rev Log: [ARM] Enable FeatureMP for Cortex-A5 by default. Patch by Oliver Stannard. Modified: cfe/trunk/test/Preprocessor/arm-target-features.c Modified: cfe/trunk/t

Re: Unavailable method checker

2013-11-25 Thread Richard
hi all, any update on this? ta, richard. On 08 Nov 2013, at 22:23, Jordan Rose wrote: > > On Nov 6, 2013, at 7:18 , Tarka T wrote: > >> On Tue, Nov 5, 2013 at 6:46 PM, Jordan Rose wrote: >> >> On Oct 31, 2013, at 5:43 , Richard wrote: >> >>> On 29 Oct 2013, at 17:11, Jordan Rose wrote:

Re: [PATCH] Enable FeatureMP for Cortex-A5 by default

2013-11-25 Thread Renato Golin
LGTM too. On 25 November 2013 11:55, James Molloy wrote: > Hi Oliver, > > Looks like you forgot to CC both lists in your reply - re-cc'ing them. > > LGTM! > > Cheers, > > James > > > On 22 November 2013 15:06, Oliver Stannard wrote: > >> Hi James, >> >> >> >> I have attached an updated clang pa

r195638 - clang-format: Fix formatting of empty files (fixes c-index-tests).

2013-11-25 Thread Daniel Jasper
Author: djasper Date: Mon Nov 25 05:53:05 2013 New Revision: 195638 URL: http://llvm.org/viewvc/llvm-project?rev=195638&view=rev Log: clang-format: Fix formatting of empty files (fixes c-index-tests). Modified: cfe/trunk/lib/Format/Format.cpp Modified: cfe/trunk/lib/Format/Format.cpp URL: h

Re: [PATCH] Enable FeatureMP for Cortex-A5 by default

2013-11-25 Thread James Molloy
Hi Oliver, Looks like you forgot to CC both lists in your reply - re-cc'ing them. LGTM! Cheers, James On 22 November 2013 15:06, Oliver Stannard wrote: > Hi James, > > > > I have attached an updated clang patch which removes the whitespace diff. > > > > The +d16 is because the default for C

r195634 - clang-format: Refactor calculation of lines intersecting with -lines.

2013-11-25 Thread Daniel Jasper
Author: djasper Date: Mon Nov 25 05:08:59 2013 New Revision: 195634 URL: http://llvm.org/viewvc/llvm-project?rev=195634&view=rev Log: clang-format: Refactor calculation of lines intersecting with -lines. No functional changes intended. However, it seems to have found a buggy behavior in one of th

Re: [PATCH] Implement aarch64 neon instruction class SIMD lsone and lsone-post - LLVM

2013-11-25 Thread Tim Northover
> This sounds good, and we are suggesting using EXTRACT_SUBREG and friends, so > we are on the same page, right? I'm not suggesting creating the EXTRACT_SUBREGs as a special-case in AArch64 code, but leaving it to generic handling of shuffles. The less special-cases we have to deal with, the bette

Re: [PATCH] Support for address space casting in order to map these on the new 'addrspacecast' IR instruction

2013-11-25 Thread Pekka Jääskeläinen
LGTM. Trying to implicitly cast pointers between ASs now crash LLVM in LLVM 3.4 (assert in Instructions.cpp). Is it related to this? Perhaps the patch should be added to LLVM 3.4 and there could be a switch to disable the check for OpenCL (revert to the CUDA behavior)? The exact problem we

Re: [PATCH] Allow string literals as module identifiers

2013-11-25 Thread Daniel Jasper
Any news on this? Did we come to some kind of conclusion during the Dev Meeting? http://llvm-reviews.chandlerc.com/D2024 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: r195626 - Tests for core issues 270-300.

2013-11-25 Thread Renato Golin
Hi Richard, Not sure what the error is, or why it's only failing on our bots... http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a9/builds/13642/steps/check-all/logs/Clang%3A%3Adr2xx.cpp cheers, --renato On 25 November 2013 08:07, Richard Smith wrote: > Author: rsmith > Date: Mon No

Re: [PATCH] Another pass at adding missing matchers into the registry.

2013-11-25 Thread Manuel Klimek
lg http://llvm-reviews.chandlerc.com/D2253 BRANCH another_pass ARCANIST PROJECT clang ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] CMake: Enable building clang-format's Visual Studio plugin

2013-11-25 Thread Manuel Klimek
On Sat, Nov 23, 2013 at 1:27 AM, Hans Wennborg wrote: > On Thu, Nov 21, 2013 at 10:53 PM, Manuel Klimek wrote: > > I personally actually think we should somehow bake clang-format into the > > extension (if possible) and distribute it via the visual studio gallery. > > Sounds great. Do you want t

Re: [PATCH] Add completion to the query parser, and hook it up to clang-query.

2013-11-25 Thread Peter Collingbourne
- Add a test Hi klimek, sbenza, http://llvm-reviews.chandlerc.com/D2263 CHANGE SINCE LAST DIFF http://llvm-reviews.chandlerc.com/D2263?vs=5754&id=5755#toc Files: clang-query/QueryParser.cpp clang-query/QueryParser.h clang-query/tool/ClangQuery.cpp unittests/clang-query/QueryParser

r195626 - Tests for core issues 270-300.

2013-11-25 Thread Richard Smith
Author: rsmith Date: Mon Nov 25 02:07:41 2013 New Revision: 195626 URL: http://llvm.org/viewvc/llvm-project?rev=195626&view=rev Log: Tests for core issues 270-300. Added: cfe/trunk/test/CXX/drs/dr3xx.cpp Modified: cfe/trunk/test/CXX/drs/dr2xx.cpp cfe/trunk/www/cxx_dr_status.html Modi