Re: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0

2014-05-19 Thread Pedro Ferreira
...@cs.uiuc.edu] On Behalf Of David Tweed Sent: 13 May 2014 11:50 To: 'Pedro Ferreira'; cfe-commits@cs.uiuc.edu Subject: RE: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0 The patch LGTM. -Original Message- From: cfe-commits-boun...@cs.uiuc.edu [mailto:cfe-commits-boun

Re: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0

2014-05-19 Thread Neil Henning
. -Original Message- From: cfe-commits-boun...@cs.uiuc.edu [mailto:cfe-commits-boun...@cs.uiuc.edu] On Behalf Of David Tweed Sent: 13 May 2014 11:50 To: 'Pedro Ferreira'; cfe-commits@cs.uiuc.edu Subject: RE: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0 The patch LGTM

RE: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0

2014-05-19 Thread Joey Gouly
-attrs.cl. -Original Message- From: cfe-commits-boun...@cs.uiuc.edu [mailto:cfe-commits-boun...@cs.uiuc.edu] On Behalf Of David Tweed Sent: 13 May 2014 11:50 To: 'Pedro Ferreira'; cfe-commits@cs.uiuc.edu Subject: RE: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0 The patch

Re: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0

2014-05-19 Thread Pedro Ferreira
@cs.uiuc.edu *Subject:* Re: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0 Any reason why the additional test in invalid-kernel-attrs.cl only tests whether the Z dimension is 0? Would be useful to ensure no regressions occur that we test each dimension (Perhaps you could just submit

RE: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0

2014-05-19 Thread Joey Gouly
Committed as r209127! Joey From: Pedro Ferreira [mailto:pedro.ferre...@imgtec.com] Sent: 19 May 2014 12:04 To: Joey Gouly; 'Neil Henning'; cfe-commits@cs.uiuc.edu Subject: Re: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0 No, I don't. Pedro On 19/05/14 12:03, Joey

RE: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0

2014-05-13 Thread David Tweed
The patch LGTM. -Original Message- From: cfe-commits-boun...@cs.uiuc.edu [mailto:cfe-commits-boun...@cs.uiuc.edu] On Behalf Of Pedro Ferreira Sent: 13 May 2014 10:03 To: cfe-commits@cs.uiuc.edu Subject: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0 OpenCL allows us to

RE: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0

2014-05-13 Thread Joey Gouly
: Reject OpenCL workgroup size requirement of 0 The patch LGTM. -Original Message- From: cfe-commits-boun...@cs.uiuc.edu [mailto:cfe-commits-boun...@cs.uiuc.edu] On Behalf Of Pedro Ferreira Sent: 13 May 2014 10:03 To: cfe-commits@cs.uiuc.edu Subject: [PATCH] Clang: Reject OpenCL workgroup size

Re: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0

2014-05-13 Thread Aaron Ballman
Subject: RE: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0 The patch LGTM. -Original Message- From: cfe-commits-boun...@cs.uiuc.edu [mailto:cfe-commits-boun...@cs.uiuc.edu] On Behalf Of Pedro Ferreira Sent: 13 May 2014 10:03 To: cfe-commits@cs.uiuc.edu Subject

Re: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0

2014-05-13 Thread Pedro Ferreira
Ferreira'; cfe-commits@cs.uiuc.edu Subject: RE: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0 The patch LGTM. -Original Message- From: cfe-commits-boun...@cs.uiuc.edu [mailto:cfe-commits-boun...@cs.uiuc.edu] On Behalf Of Pedro Ferreira Sent: 13 May 2014 10:03 To: cfe-commits