[cfe-commits] r166171 - /cfe/trunk/lib/AST/DumpXML.cpp

2012-10-18 Thread Nick Lewycky
Author: nicholas Date: Thu Oct 18 02:55:46 2012 New Revision: 166171 URL: http://llvm.org/viewvc/llvm-project?rev=166171view=rev Log: Put used=1 on all used declarations in the XML dumper. This allows us to start seeing the bit so that we can find bugs and write tests for it. Modified:

[cfe-commits] [Patch] compiler-rt: SPARC64-optimized multiply/divide

2012-10-18 Thread Ed Schouten
Hi all, Attached is the latest version of a patch we use at FreeBSD to add optimized multiply/divide functions on SPARC64. Description from the original bug report[1]: According to a developer at the FreeBSD project, FreeBSD's total compilation time increases by 2.6% when the host system is

Re: [cfe-commits] r166171 - /cfe/trunk/lib/AST/DumpXML.cpp

2012-10-18 Thread Chandler Carruth
On Thu, Oct 18, 2012 at 12:55 AM, Nick Lewycky nicho...@mxc.ca wrote: Author: nicholas Date: Thu Oct 18 02:55:46 2012 New Revision: 166171 URL: http://llvm.org/viewvc/llvm-project?rev=166171view=rev Log: Put used=1 on all used declarations in the XML dumper. This allows us to start seeing

[cfe-commits] r166174 - /cfe/trunk/lib/AST/TypeLoc.cpp

2012-10-18 Thread Abramo Bagnara
Author: abramo Date: Thu Oct 18 03:29:37 2012 New Revision: 166174 URL: http://llvm.org/viewvc/llvm-project?rev=166174view=rev Log: Fixed some corner cases due to implicit int TypeLoc and simplified the logic. Modified: cfe/trunk/lib/AST/TypeLoc.cpp Modified: cfe/trunk/lib/AST/TypeLoc.cpp

Re: [cfe-commits] r166174 - /cfe/trunk/lib/AST/TypeLoc.cpp

2012-10-18 Thread Chandler Carruth
On Thu, Oct 18, 2012 at 1:29 AM, Abramo Bagnara abramo.bagn...@bugseng.comwrote: Author: abramo Date: Thu Oct 18 03:29:37 2012 New Revision: 166174 URL: http://llvm.org/viewvc/llvm-project?rev=166174view=rev Log: Fixed some corner cases due to implicit int TypeLoc and simplified the

Re: [cfe-commits] Bug 11709 Fix: va_list on ARM is not following AAPCS 7.1.4

2012-10-18 Thread Logan Chien
Hi, Here's another attempt to solve __builtin_va_arg issue. In this patch, there is a special check for C++ and va_list as record type: } else if (VaListType-isRecordType() getLangOpts().CPlusPlus) { // If va_list is a record type and we are compiling under C++ mode, // then we

Re: [cfe-commits] r166174 - /cfe/trunk/lib/AST/TypeLoc.cpp

2012-10-18 Thread Abramo Bagnara
Il 18/10/2012 10:37, Chandler Carruth ha scritto: On Thu, Oct 18, 2012 at 1:29 AM, Abramo Bagnara abramo.bagn...@bugseng.com mailto:abramo.bagn...@bugseng.com wrote: Author: abramo Date: Thu Oct 18 03:29:37 2012 New Revision: 166174 URL:

Re: [cfe-commits] r166171 - /cfe/trunk/lib/AST/DumpXML.cpp

2012-10-18 Thread Nick Lewycky
Chandler Carruth wrote: On Thu, Oct 18, 2012 at 12:55 AM, Nick Lewycky nicho...@mxc.ca mailto:nicho...@mxc.ca wrote: Author: nicholas Date: Thu Oct 18 02:55:46 2012 New Revision: 166171 URL: http://llvm.org/viewvc/llvm-project?rev=166171view=rev

Re: [cfe-commits] r165256 - /cfe/trunk/lib/Sema/SemaDecl.cpp

2012-10-18 Thread Philip Craig
On Sat, Oct 6, 2012 at 3:55 PM, Enea Zaffanella zaffane...@cs.unipr.it wrote: On 10/06/2012 01:44 AM, Philip Craig wrote: On Fri, Oct 5, 2012 at 2:40 PM, Abramo Bagnara abramo.bagn...@bugseng.com wrote: Il 05/10/2012 00:15, Chandler Carruth ha scritto: On Thu, Oct 4, 2012 at 3:12 PM,

Re: [cfe-commits] [Patch] Add -Wmissing-variable-declarations

2012-10-18 Thread Ed Schouten
Hi Eli, 2012/8/1 Eli Friedman eli.fried...@gmail.com: On Tue, Jul 24, 2012 at 7:06 AM, Ed Schouten e...@80386.nl wrote: I've updated the patch. As usual, it can be downloaded from: http://80386.nl/pub/wmissing-variable-declarations.txt @@ -6839,8 +6839,10 @@ } // Record the

Re: [cfe-commits] Bug 11709 Fix: va_list on ARM is not following AAPCS 7.1.4

2012-10-18 Thread Eli Friedman
On Thu, Oct 18, 2012 at 1:40 AM, Logan Chien tzuhsiang.ch...@gmail.com wrote: Hi, Here's another attempt to solve __builtin_va_arg issue. In this patch, there is a special check for C++ and va_list as record type: } else if (VaListType-isRecordType() getLangOpts().CPlusPlus) { //

Re: [cfe-commits] [LLVMdev] [cfe-dev] OpenMP support in CLANG: A proposal

2012-10-18 Thread Mahesha HS
Hi Eli, Thanks for all your comments. I have taken care of all your review comments. Yes, after I gone through your review comments, I also came to the conclusion that the addition of a new class for OpenMP pragma handling (class PragmaOmpHandler) is not necessarily required. However, initially,

Re: [cfe-commits] r165771 - in /cfe/trunk: include/clang/AST/ASTContext.h include/clang/AST/Comment.h lib/AST/ASTContext.cpp lib/AST/Comment.cpp lib/AST/CommentSema.cpp test/Index/overriding-method-co

2012-10-18 Thread Dmitri Gribenko
On Fri, Oct 12, 2012 at 2:52 AM, Fariborz Jahanian fjahan...@apple.com wrote: +comments::FullComment *ASTContext::cloneFullComment(comments::FullComment *FC, +const Decl *D) const { + comments::DeclInfo *ThisDeclInfo = new (*this)

[cfe-commits] [PATCH] Fix pretty-printing of decl group stmts

2012-10-18 Thread Richard Membarth
Attached is a patch that fixes pretty-printing of decl stmt groups. The example below shows that the current type pretty-printer does not print the variable name if Policy.SuppressSpecifiers is set. ~ cat test.cc int main(int argc, const char **argv) { int x=0, y=5; for (int i=x, j=y;

[cfe-commits] [PATCH] When using make VERBOSE=1, make sure compiler-rt is also build verbosely.

2012-10-18 Thread Jean-Daniel Dupas
When building clang+compiler-rt verbosely, the build commands of compiler-rt are not output in the terminal as expected. This patch fixes the issue by forwarding the VERBOSE flag to the compiler-rt make. http://llvm-reviews.chandlerc.com/D67 Files: runtime/compiler-rt/Makefile Index:

Re: [cfe-commits] [PATCH] clang/test/Index: 3 of tests require libxml2, following up to r166130.

2012-10-18 Thread Dmitri Gribenko
Hi Takumi, About the patch, adding the feature is not required here. The correct fix is to remove the CommentXMLValid from CHECK lines. (The test checks that there are no CommentXMLInvalid lines, so it is OK). Please tell me if you want me to make this change. On Thu, Oct 18, 2012 at 5:30 AM,

Re: [cfe-commits] [patch] Forward VERBOSE flag to compiler-rt Makefile.

2012-10-18 Thread Jean-Daniel Dupas
Le 16 oct. 2012 à 10:14, Jean-Daniel Dupas devli...@shadowlab.org a écrit : Hello, Using the autoconf build system, it is possible to build clang in verbose mode to get the full transcript of the build (using make VERBOSE=1). This is useful to track issues with the build system.

Re: [cfe-commits] [PATCH] clang/test/Index: 3 of tests require libxml2, following up to r166130.

2012-10-18 Thread NAKAMURA Takumi
Dmitri, I'm ok for you to update! 2012/10/18 Dmitri Gribenko griboz...@gmail.com: Hi Takumi, About the patch, adding the feature is not required here. The correct fix is to remove the CommentXMLValid from CHECK lines. (The test checks that there are no CommentXMLInvalid lines, so it is

Re: [cfe-commits] [LLVMdev] [cfe-dev] OpenMP support in CLANG: A proposal

2012-10-18 Thread Mahesha HS
Sorry, in my previous mail, I had missed to attach changes to clang/include/clang/Basic/TokenKinds.def in the patch 2. Please refer to the patch (2) attached in *this* mail, instead of the one sent in the previous mail. Patch 1 is fine. -- mahesha On Thu, Oct 18, 2012 at 5:02 PM, Mahesha HS

[cfe-commits] r166179 - in /cfe/trunk/test/Index: annotate-comments-availability-attrs.cpp overriding-ftemplate-comments.cpp overriding-method-comments.mm

2012-10-18 Thread Dmitri Gribenko
Author: gribozavr Date: Thu Oct 18 09:33:01 2012 New Revision: 166179 URL: http://llvm.org/viewvc/llvm-project?rev=166179view=rev Log: Un-XFAIL some tests for comment to XML conversion. This reverts r166151 and fixes the tests for builds without libxml2. Modified:

Re: [cfe-commits] [PATCH] clang/test/Index: 3 of tests require libxml2, following up to r166130.

2012-10-18 Thread Dmitri Gribenko
On Thu, Oct 18, 2012 at 3:55 PM, NAKAMURA Takumi geek4ci...@gmail.com wrote: Dmitri, I'm ok for you to update! Committed r166179, hopefully it fixes mingw and win32 buildbots! Dmitri -- main(i,j){for(i=2;;i++){for(j=2;ji;j++){if(!(i%j)){j=0;break;}}if (j){printf(%d\n,i);}}} /*Dmitri Gribenko

Re: [cfe-commits] [PATCH] 3 small static analyzer patches

2012-10-18 Thread Sean McBride
On Fri, 21 Sep 2012 09:51:32 -0700, Jordan Rose said: The reallocf change looks good. The place to add a test is unix-fns.c, which you probably already found. I'll let you come up with a test case just to practice. ;-) Welcome to the static analyzer! Hi, Here's a new patch with test. I

Re: [cfe-commits] [llvm-commits] (autoconf) Build ASan runtime for ARM/Android

2012-10-18 Thread Evgeniy Stepanov
ping On Wed, Oct 17, 2012 at 6:34 PM, Evgeniy Stepanov eugeni.stepa...@gmail.com wrote: OK, let's get rid of the configure option for the sake of progress. Please take another look. This way android runtime can be built with an extra make invocation in the same build tree. make -C

[cfe-commits] Fwd: Bug 11709 Fix: va_list on ARM is not following AAPCS 7.1.4

2012-10-18 Thread Logan Chien
-- Forwarded message -- From: Logan Chien tzuhsiang.ch...@gmail.com Date: Thu, Oct 18, 2012 at 11:20 PM Subject: Re: [cfe-commits] Bug 11709 Fix: va_list on ARM is not following AAPCS 7.1.4 To: Eli Friedman eli.fried...@gmail.com Thanks for your review. I have added new test to

[cfe-commits] r166181 - /cfe/trunk/NOTES.txt

2012-10-18 Thread Andy Gibbs
Author: andyg Date: Thu Oct 18 10:24:46 2012 New Revision: 166181 URL: http://llvm.org/viewvc/llvm-project?rev=166181view=rev Log: Fix typo (test commit) Modified: cfe/trunk/NOTES.txt Modified: cfe/trunk/NOTES.txt URL:

[cfe-commits] r166184 - in /cfe/trunk: include/clang/Sema/Sema.h lib/Sema/SemaStmtAsm.cpp test/CodeGen/ms-inline-asm.c

2012-10-18 Thread Chad Rosier
Author: mcrosier Date: Thu Oct 18 10:49:40 2012 New Revision: 166184 URL: http://llvm.org/viewvc/llvm-project?rev=166184view=rev Log: [ms-inline asm] Move most of the AsmParsing logic in clang back into the MC layer. Use the new ParseMSInlineAsm() API and add an implementation of the

Re: [cfe-commits] [PATCH] clang/test/Index: 3 of tests require libxml2, following up to r166130.

2012-10-18 Thread jahanian
On Oct 18, 2012, at 5:45 AM, Dmitri Gribenko griboz...@gmail.com wrote: Hi Takumi, About the patch, adding the feature is not required here. The correct fix is to remove the CommentXMLValid from CHECK lines. (The test checks that there are no CommentXMLInvalid lines, so it is OK). Yes,

Re: [cfe-commits] r166130 - in /cfe/trunk: bindings/xml/comment-xml-schema.rng include/clang/AST/Comment.h include/clang/AST/PrettyPrinter.h lib/AST/Comment.cpp lib/AST/DeclPrinter.cpp test/Index/anno

2012-10-18 Thread jahanian
On Oct 17, 2012, at 6:45 PM, NAKAMURA Takumi geek4ci...@gmail.com wrote: 2012/10/18 Fariborz Jahanian fjahan...@apple.com: Don't escape local std::string with StringRef. Fixed in r166163. Thanks. It went through couple of revisions and forgot to do this last one. - fariborz

Re: [cfe-commits] r165771 - in /cfe/trunk: include/clang/AST/ASTContext.h include/clang/AST/Comment.h lib/AST/ASTContext.cpp lib/AST/Comment.cpp lib/AST/CommentSema.cpp test/Index/overriding-method-co

2012-10-18 Thread Douglas Gregor
Hi Dmitri, On Oct 18, 2012, at 5:03 AM, Dmitri Gribenko griboz...@gmail.com wrote: On Fri, Oct 12, 2012 at 2:52 AM, Fariborz Jahanian fjahan...@apple.com wrote: +comments::FullComment *ASTContext::cloneFullComment(comments::FullComment *FC, +

Re: [cfe-commits] clang patch for bug 14021

2012-10-18 Thread Robert Muth
On Tue, Oct 16, 2012 at 1:47 PM, David Blaikie dblai...@gmail.com wrote: On Tue, Oct 16, 2012 at 10:09 AM, Robert Muth robe...@google.com wrote: On Tue, Oct 16, 2012 at 11:47 AM, David Blaikie dblai...@gmail.com wrote: On Tue, Oct 16, 2012 at 8:12 AM, Robert Muth robe...@google.com wrote: On

Re: [cfe-commits] r166130 - in /cfe/trunk: bindings/xml/comment-xml-schema.rng include/clang/AST/Comment.h include/clang/AST/PrettyPrinter.h lib/AST/Comment.cpp lib/AST/DeclPrinter.cpp test/Index/anno

2012-10-18 Thread Douglas Gregor
On Oct 18, 2012, at 4:42 AM, Dmitri Gribenko griboz...@gmail.com wrote: On Thu, Oct 18, 2012 at 12:58 AM, Fariborz Jahanian fjahan...@apple.com wrote: Author: fjahanian Date: Wed Oct 17 16:58:03 2012 New Revision: 166130 URL: http://llvm.org/viewvc/llvm-project?rev=166130view=rev Log:

Re: [cfe-commits] r166130 - in /cfe/trunk: bindings/xml/comment-xml-schema.rng include/clang/AST/Comment.h include/clang/AST/PrettyPrinter.h lib/AST/Comment.cpp lib/AST/DeclPrinter.cpp test/Index/anno

2012-10-18 Thread jahanian
On Oct 18, 2012, at 9:22 AM, Douglas Gregor dgre...@apple.com wrote: On Oct 18, 2012, at 4:42 AM, Dmitri Gribenko griboz...@gmail.com wrote: On Thu, Oct 18, 2012 at 12:58 AM, Fariborz Jahanian fjahan...@apple.com wrote: Author: fjahanian Date: Wed Oct 17 16:58:03 2012 New Revision:

Re: [cfe-commits] r166130 - in /cfe/trunk: bindings/xml/comment-xml-schema.rng include/clang/AST/Comment.h include/clang/AST/PrettyPrinter.h lib/AST/Comment.cpp lib/AST/DeclPrinter.cpp test/Index/anno

2012-10-18 Thread Dmitri Gribenko
On Thu, Oct 18, 2012 at 7:22 PM, Douglas Gregor dgre...@apple.com wrote: On Oct 18, 2012, at 4:42 AM, Dmitri Gribenko griboz...@gmail.com wrote: On Thu, Oct 18, 2012 at 12:58 AM, Fariborz Jahanian fjahan...@apple.com wrote: Modified: cfe/trunk/include/clang/AST/Comment.h URL:

Re: [cfe-commits] [PATCH] Optimize SourceManager::getColumnNumber to fix PR14106

2012-10-18 Thread Douglas Gregor
On Oct 17, 2012, at 6:04 PM, Craig Topper craig.top...@gmail.com wrote: This patch uses the line number cache to find the start of the line instead of searching backwards for it. This helps performance in cases where the line is long and have just called getLineNumber for the same position.

Re: [cfe-commits] r165771 - in /cfe/trunk: include/clang/AST/ASTContext.h include/clang/AST/Comment.h lib/AST/ASTContext.cpp lib/AST/Comment.cpp lib/AST/CommentSema.cpp test/Index/overriding-method-co

2012-10-18 Thread Dmitri Gribenko
On Thu, Oct 18, 2012 at 7:18 PM, Douglas Gregor dgre...@apple.com wrote: On Oct 18, 2012, at 5:03 AM, Dmitri Gribenko griboz...@gmail.com wrote: I think that cloneFullComment() is evil -- it breaks some assumptions about DeclInfo and does not properly introduce a concept of a comment being

[cfe-commits] r166188 - /cfe/trunk/lib/Sema/SemaInit.cpp

2012-10-18 Thread David Blaikie
Author: dblaikie Date: Thu Oct 18 11:57:32 2012 New Revision: 166188 URL: http://llvm.org/viewvc/llvm-project?rev=166188view=rev Log: PR14021: Copy lookup results to ensure safe iteration. Within the body of the loop the underlying map may be modified via Sema::AddOverloadCandidate -

Re: [cfe-commits] clang patch for bug 14021

2012-10-18 Thread David Blaikie
On Thu, Oct 18, 2012 at 9:22 AM, Robert Muth robe...@google.com wrote: On Tue, Oct 16, 2012 at 1:47 PM, David Blaikie dblai...@gmail.com wrote: On Tue, Oct 16, 2012 at 10:09 AM, Robert Muth robe...@google.com wrote: On Tue, Oct 16, 2012 at 11:47 AM, David Blaikie dblai...@gmail.com wrote: On

Re: [cfe-commits] [PATCH] Optimize SourceManager::getColumnNumber to fix PR14106

2012-10-18 Thread Craig Topper
Sure, I can make that change. After that is it ok to commit? On Thu, Oct 18, 2012 at 9:43 AM, Douglas Gregor dgre...@apple.com wrote: On Oct 17, 2012, at 6:04 PM, Craig Topper craig.top...@gmail.com wrote: This patch uses the line number cache to find the start of the line instead of

Re: [cfe-commits] [PATCH] External Sema Source

2012-10-18 Thread Douglas Gregor
On Oct 11, 2012, at 8:02 AM, Vassil Vassilev vasil.georgiev.vasi...@cern.ch wrote: Hi, We need to attach multiple ExternalSources to Sema, to provide modules /and/ last resort lookup. Right now that's a pain. The attached patch makes this much easier, at (almost?) no runtime cost for the

Re: [cfe-commits] [PATCH] Optimize SourceManager::getColumnNumber to fix PR14106

2012-10-18 Thread Douglas Gregor
Yes. On Oct 18, 2012, at 10:02 AM, Craig Topper craig.top...@gmail.com wrote: Sure, I can make that change. After that is it ok to commit? On Thu, Oct 18, 2012 at 9:43 AM, Douglas Gregor dgre...@apple.com wrote: On Oct 17, 2012, at 6:04 PM, Craig Topper craig.top...@gmail.com wrote:

Re: [cfe-commits] r165771 - in /cfe/trunk: include/clang/AST/ASTContext.h include/clang/AST/Comment.h lib/AST/ASTContext.cpp lib/AST/Comment.cpp lib/AST/CommentSema.cpp test/Index/overriding-method-co

2012-10-18 Thread Douglas Gregor
On Oct 18, 2012, at 9:56 AM, Dmitri Gribenko griboz...@gmail.com wrote: On Thu, Oct 18, 2012 at 7:18 PM, Douglas Gregor dgre...@apple.com wrote: On Oct 18, 2012, at 5:03 AM, Dmitri Gribenko griboz...@gmail.com wrote: I think that cloneFullComment() is evil -- it breaks some assumptions about

Re: [cfe-commits] r166130 - in /cfe/trunk: bindings/xml/comment-xml-schema.rng include/clang/AST/Comment.h include/clang/AST/PrettyPrinter.h lib/AST/Comment.cpp lib/AST/DeclPrinter.cpp test/Index/anno

2012-10-18 Thread Douglas Gregor
On Oct 17, 2012, at 2:58 PM, Fariborz Jahanian fjahan...@apple.com wrote: Author: fjahanian Date: Wed Oct 17 16:58:03 2012 New Revision: 166130 URL: http://llvm.org/viewvc/llvm-project?rev=166130view=rev Log: [Doc parsing]: This patch adds Declaration tag to XML comment for

Re: [cfe-commits] r166188 - /cfe/trunk/lib/Sema/SemaInit.cpp

2012-10-18 Thread Rafael Espíndola
I still think this should include a testcase. On 18 October 2012 12:57, David Blaikie dblai...@gmail.com wrote: Author: dblaikie Date: Thu Oct 18 11:57:32 2012 New Revision: 166188 URL: http://llvm.org/viewvc/llvm-project?rev=166188view=rev Log: PR14021: Copy lookup results to ensure safe

Re: [cfe-commits] r166130 - in /cfe/trunk: bindings/xml/comment-xml-schema.rng include/clang/AST/Comment.h include/clang/AST/PrettyPrinter.h lib/AST/Comment.cpp lib/AST/DeclPrinter.cpp test/Index/anno

2012-10-18 Thread jahanian
On Oct 18, 2012, at 10:21 AM, Douglas Gregor dgre...@apple.com wrote: On Oct 17, 2012, at 2:58 PM, Fariborz Jahanian fjahan...@apple.com wrote: Author: fjahanian Date: Wed Oct 17 16:58:03 2012 New Revision: 166130 URL: http://llvm.org/viewvc/llvm-project?rev=166130view=rev Log: [Doc

[cfe-commits] r166192 - /cfe/trunk/include/clang/AST/Comment.h

2012-10-18 Thread Fariborz Jahanian
Author: fjahanian Date: Thu Oct 18 12:32:05 2012 New Revision: 166192 URL: http://llvm.org/viewvc/llvm-project?rev=166192view=rev Log: Improve comment in couple of fields of DeclInfo. Modified: cfe/trunk/include/clang/AST/Comment.h Modified: cfe/trunk/include/clang/AST/Comment.h URL:

[cfe-commits] r166193 - /cfe/trunk/test/CodeGen/ms-inline-asm.c

2012-10-18 Thread Chad Rosier
Author: mcrosier Date: Thu Oct 18 12:51:43 2012 New Revision: 166193 URL: http://llvm.org/viewvc/llvm-project?rev=166193view=rev Log: [ms-inline asm] Remove accidental commit. Modified: cfe/trunk/test/CodeGen/ms-inline-asm.c Modified: cfe/trunk/test/CodeGen/ms-inline-asm.c URL:

[cfe-commits] r166194 - in /cfe/trunk: include/clang/AST/ExprCXX.h include/clang/Sema/Sema.h lib/AST/ExprCXX.cpp lib/Sema/SemaLookup.cpp lib/Sema/SemaOverload.cpp lib/Serialization/ASTReaderStmt.cpp l

2012-10-18 Thread Richard Smith
Author: rsmith Date: Thu Oct 18 12:56:02 2012 New Revision: 166194 URL: http://llvm.org/viewvc/llvm-project?rev=166194view=rev Log: DR1442: In a range-based for statement, namespace 'std' is not an associated namespace. Modified: cfe/trunk/include/clang/AST/ExprCXX.h

[cfe-commits] r166195 - in /cfe/trunk: include/clang/Serialization/ASTBitCodes.h lib/Serialization/ASTReader.cpp lib/Serialization/ASTWriter.cpp

2012-10-18 Thread Douglas Gregor
Author: dgregor Date: Thu Oct 18 12:58:09 2012 New Revision: 166195 URL: http://llvm.org/viewvc/llvm-project?rev=166195view=rev Log: Split the target options out into their own record within the AST file's control block. Modified: cfe/trunk/include/clang/Serialization/ASTBitCodes.h

Re: [cfe-commits] r166130 - in /cfe/trunk: bindings/xml/comment-xml-schema.rng include/clang/AST/Comment.h include/clang/AST/PrettyPrinter.h lib/AST/Comment.cpp lib/AST/DeclPrinter.cpp test/Index/anno

2012-10-18 Thread Dmitri Gribenko
On Thu, Oct 18, 2012 at 8:25 PM, jahanian fjahan...@apple.com wrote: On Oct 18, 2012, at 10:21 AM, Douglas Gregor dgre...@apple.com wrote: The declaration printer is going to need a lot of work. We'll need to have tests for essentially every kind of AST node. Yes, this is wip. Test

Re: [cfe-commits] r166130 - in /cfe/trunk: bindings/xml/comment-xml-schema.rng include/clang/AST/Comment.h include/clang/AST/PrettyPrinter.h lib/AST/Comment.cpp lib/AST/DeclPrinter.cpp test/Index/anno

2012-10-18 Thread jahanian
On Oct 18, 2012, at 11:01 AM, Dmitri Gribenko griboz...@gmail.com wrote: On Thu, Oct 18, 2012 at 8:25 PM, jahanian fjahan...@apple.com wrote: On Oct 18, 2012, at 10:21 AM, Douglas Gregor dgre...@apple.com wrote: The declaration printer is going to need a lot of work. We'll need to have

[cfe-commits] r166202 - /cfe/trunk/include/clang/AST/Comment.h

2012-10-18 Thread Dmitri Gribenko
Author: gribozavr Date: Thu Oct 18 13:18:26 2012 New Revision: 166202 URL: http://llvm.org/viewvc/llvm-project?rev=166202view=rev Log: Expand the comment for DeclInfo::CurrentDecl. Modified: cfe/trunk/include/clang/AST/Comment.h Modified: cfe/trunk/include/clang/AST/Comment.h URL:

[cfe-commits] r166203 - /cfe/trunk/include/clang/AST/Comment.h

2012-10-18 Thread Dmitri Gribenko
Author: gribozavr Date: Thu Oct 18 13:21:40 2012 New Revision: 166203 URL: http://llvm.org/viewvc/llvm-project?rev=166203view=rev Log: Fix more documentation comments in Comment.h Modified: cfe/trunk/include/clang/AST/Comment.h Modified: cfe/trunk/include/clang/AST/Comment.h URL:

[cfe-commits] r166204 - in /cfe/trunk: include/clang/Serialization/ASTBitCodes.h lib/Serialization/ASTReader.cpp lib/Serialization/ASTWriter.cpp

2012-10-18 Thread Douglas Gregor
Author: dgregor Date: Thu Oct 18 13:27:37 2012 New Revision: 166204 URL: http://llvm.org/viewvc/llvm-project?rev=166204view=rev Log: Collapse the version control revision/tag AST file record into the metadata record, which already had other version information. Clean up the block info block along

[cfe-commits] r166206 - in /cfe/trunk: include/clang/Serialization/ASTBitCodes.h lib/Serialization/ASTReader.cpp lib/Serialization/ASTWriter.cpp

2012-10-18 Thread Douglas Gregor
Author: dgregor Date: Thu Oct 18 13:36:53 2012 New Revision: 166206 URL: http://llvm.org/viewvc/llvm-project?rev=166206view=rev Log: Collapse the original file name and original file ID records into a single record. Modified: cfe/trunk/include/clang/Serialization/ASTBitCodes.h

Re: [cfe-commits] r166190 - /cfe/trunk/test/Index/annotate-comments.cpp

2012-10-18 Thread Dmitri Gribenko
On Thu, Oct 18, 2012 at 8:19 PM, Fariborz Jahanian fjahan...@apple.com wrote: Author: fjahanian Date: Thu Oct 18 12:19:41 2012 New Revision: 166190 URL: http://llvm.org/viewvc/llvm-project?rev=166190view=rev Log: Fix this test to match recent addition of declaration tag. Thank you! Dmitri

[cfe-commits] [PATCH] c++11 type attribute fix

2012-10-18 Thread Michael Han
Hi, This patch enables Clang to apply C++11 attributes present after declaration specifiers to types instead of declarators, and warn on attributes that appear at wrong place (like carries_dependency which can't be applied to types). Please review, thanks! Michael typeattr.patch

[cfe-commits] r166208 - in /cfe/trunk: include/clang/Sema/MultiplexExternalSemaSource.h include/clang/Sema/Sema.h lib/Sema/CMakeLists.txt lib/Sema/MultiplexExternalSemaSource.cpp lib/Sema/Sema.cpp lib

2012-10-18 Thread Axel Naumann
Author: axel Date: Thu Oct 18 14:05:02 2012 New Revision: 166208 URL: http://llvm.org/viewvc/llvm-project?rev=166208view=rev Log: From Vassil Vassilev: enable Sema to deal with multiple ExternalSemaSources. Added: cfe/trunk/include/clang/Sema/MultiplexExternalSemaSource.h (with props)

[cfe-commits] r166211 - in /cfe/trunk: lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp test/Analysis/objc_invalidation.m

2012-10-18 Thread Anna Zaks
Author: zaks Date: Thu Oct 18 14:17:57 2012 New Revision: 166211 URL: http://llvm.org/viewvc/llvm-project?rev=166211view=rev Log: [analyzer] Ivar invalidation: identify properties declared in protocols. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp

[cfe-commits] r166210 - in /cfe/trunk: include/clang/AST/DeclObjC.h lib/AST/DeclObjC.cpp lib/Sema/SemaObjCProperty.cpp

2012-10-18 Thread Anna Zaks
Author: zaks Date: Thu Oct 18 14:17:53 2012 New Revision: 166210 URL: http://llvm.org/viewvc/llvm-project?rev=166210view=rev Log: Factor CollectClassPropertyImplementations out of Sema into AST This would make it possible for the analyzer to use the function. Modified:

[cfe-commits] r166213 - /cfe/trunk/lib/Sema/SemaStmtAsm.cpp

2012-10-18 Thread Chad Rosier
Author: mcrosier Date: Thu Oct 18 14:39:37 2012 New Revision: 166213 URL: http://llvm.org/viewvc/llvm-project?rev=166213view=rev Log: [ms-inline asm] Have the LookupInlineAsmIdentifier() callback function return a *NamedDecl. In turn, build the expressions after we're finished parsing the asm.

Re: [cfe-commits] clang patch for bug 14021

2012-10-18 Thread Jan Voung
Attached is a creduce'd test case which compiles without any clang errors, but would have broken the assertion that lock_hack == 0 that was in Robert's patch. Well, I changed it to a print and grepped for the print so that it wouldn't crash clang before clang had a chance to print other errors.

[cfe-commits] r166219 - in /cfe/trunk: include/clang/Sema/Sema.h lib/Sema/SemaDeclCXX.cpp lib/Sema/SemaObjCProperty.cpp test/SemaObjCXX/property-synthesis-error.mm

2012-10-18 Thread Eli Friedman
Author: efriedma Date: Thu Oct 18 15:14:08 2012 New Revision: 166219 URL: http://llvm.org/viewvc/llvm-project?rev=166219view=rev Log: Fix Objective-C implicit property synthesis for C++ classes so we use valid source locations in places where it is necessary for diagnostics. By itself, this

[cfe-commits] r166218 - /cfe/trunk/lib/Frontend/TextDiagnostic.cpp

2012-10-18 Thread Benjamin Kramer
Author: d0k Date: Thu Oct 18 15:09:54 2012 New Revision: 166218 URL: http://llvm.org/viewvc/llvm-project?rev=166218view=rev Log: Emit diagnostics in chunks even when we're trying to print colored template diffs. char-by-char is really slow on an unbuffered stream. Modified:

Re: [cfe-commits] clang patch for bug 14021

2012-10-18 Thread David Blaikie
On Thu, Oct 18, 2012 at 1:15 PM, Jan Voung jvo...@chromium.org wrote: Attached is a creduce'd test case which compiles without any clang errors, but would have broken the assertion that lock_hack == 0 that was in Robert's patch. Better - and certainly not something that's totally unreasonable

[cfe-commits] r166221 - in /cfe/trunk: include/clang/Sema/Sema.h lib/Sema/SemaStmtAsm.cpp

2012-10-18 Thread Chad Rosier
Author: mcrosier Date: Thu Oct 18 15:27:06 2012 New Revision: 166221 URL: http://llvm.org/viewvc/llvm-project?rev=166221view=rev Log: [ms-inline asm] Add a size argument to the LookupInlineAsmIdentifier() callback, which will be used by the asm matcher in the near future. Modified:

[cfe-commits] r166223 - in /cfe/trunk: include/clang/Driver/Arg.h include/clang/Driver/ArgList.h include/clang/Driver/OptTable.h include/clang/Driver/Option.h lib/Driver/Arg.cpp lib/Driver/ArgList.cpp

2012-10-18 Thread Michael J. Spencer
Author: mspencer Date: Thu Oct 18 15:33:42 2012 New Revision: 166223 URL: http://llvm.org/viewvc/llvm-project?rev=166223view=rev Log: [Options] make Option a value type. Modified: cfe/trunk/include/clang/Driver/Arg.h cfe/trunk/include/clang/Driver/ArgList.h

Re: [cfe-commits] r166188 - /cfe/trunk/lib/Sema/SemaInit.cpp

2012-10-18 Thread Douglas Gregor
On Oct 18, 2012, at 9:57 AM, David Blaikie dblai...@gmail.com wrote: Author: dblaikie Date: Thu Oct 18 11:57:32 2012 New Revision: 166188 URL: http://llvm.org/viewvc/llvm-project?rev=166188view=rev Log: PR14021: Copy lookup results to ensure safe iteration. Within the body of the loop

Re: [cfe-commits] [Patch] Improve handling of __has_include

2012-10-18 Thread Douglas Gregor
LGTM! On Oct 10, 2012, at 6:16 PM, Richard Trieu rtr...@google.com wrote: Prevent crashes on malformed uses of __has_include. This fixes the cases outlined PR13334. Some diagnostic locations were changed and a bit of error recovery was added.

Re: [cfe-commits] r166188 - /cfe/trunk/lib/Sema/SemaInit.cpp

2012-10-18 Thread Richard Smith
On Thu, Oct 18, 2012 at 1:45 PM, Douglas Gregor dgre...@apple.com wrote: On Oct 18, 2012, at 9:57 AM, David Blaikie dblai...@gmail.com wrote: Author: dblaikie Date: Thu Oct 18 11:57:32 2012 New Revision: 166188 URL: http://llvm.org/viewvc/llvm-project?rev=166188view=rev Log:

Re: [cfe-commits] r166188 - /cfe/trunk/lib/Sema/SemaInit.cpp

2012-10-18 Thread David Blaikie
On Thu, Oct 18, 2012 at 1:45 PM, Douglas Gregor dgre...@apple.com wrote: On Oct 18, 2012, at 9:57 AM, David Blaikie dblai...@gmail.com wrote: Author: dblaikie Date: Thu Oct 18 11:57:32 2012 New Revision: 166188 URL: http://llvm.org/viewvc/llvm-project?rev=166188view=rev Log: PR14021:

Re: [cfe-commits] r166188 - /cfe/trunk/lib/Sema/SemaInit.cpp

2012-10-18 Thread Douglas Gregor
On Oct 18, 2012, at 1:48 PM, David Blaikie dblai...@gmail.com wrote: On Thu, Oct 18, 2012 at 1:45 PM, Douglas Gregor dgre...@apple.com wrote: On Oct 18, 2012, at 9:57 AM, David Blaikie dblai...@gmail.com wrote: Author: dblaikie Date: Thu Oct 18 11:57:32 2012 New Revision: 166188 URL:

Re: [cfe-commits] r166188 - /cfe/trunk/lib/Sema/SemaInit.cpp

2012-10-18 Thread Douglas Gregor
On Oct 18, 2012, at 1:48 PM, Richard Smith rich...@metafoo.co.uk wrote: On Thu, Oct 18, 2012 at 1:45 PM, Douglas Gregor dgre...@apple.com wrote: On Oct 18, 2012, at 9:57 AM, David Blaikie dblai...@gmail.com wrote: Author: dblaikie Date: Thu Oct 18 11:57:32 2012 New Revision: 166188

[cfe-commits] r166226 - in /cfe/trunk: lib/AST/StmtPrinter.cpp test/SemaCXX/ast-print.cpp

2012-10-18 Thread Eli Friedman
Author: efriedma Date: Thu Oct 18 15:54:37 2012 New Revision: 166226 URL: http://llvm.org/viewvc/llvm-project?rev=166226view=rev Log: Fix AST pretty-printing for C++ new expressions with placement arguments with default values. Based on patch by Grzegorz Jablonski. Modified:

Re: [cfe-commits] r166188 - /cfe/trunk/lib/Sema/SemaInit.cpp

2012-10-18 Thread David Blaikie
On Thu, Oct 18, 2012 at 1:50 PM, Douglas Gregor dgre...@apple.com wrote: On Oct 18, 2012, at 1:48 PM, David Blaikie dblai...@gmail.com wrote: On Thu, Oct 18, 2012 at 1:45 PM, Douglas Gregor dgre...@apple.com wrote: On Oct 18, 2012, at 9:57 AM, David Blaikie dblai...@gmail.com wrote:

[cfe-commits] r166227 - in /cfe/trunk: lib/AST/TypePrinter.cpp test/SemaCXX/ast-print.cpp

2012-10-18 Thread Eli Friedman
Author: efriedma Date: Thu Oct 18 15:58:58 2012 New Revision: 166227 URL: http://llvm.org/viewvc/llvm-project?rev=166227view=rev Log: Remove check which incorrectly suppressed printing an identifier in type printing. Patch by Benoit Perrot. Modified: cfe/trunk/lib/AST/TypePrinter.cpp

Re: [cfe-commits] [PATCH] Pretty print identifiers even while suppressing specifiers

2012-10-18 Thread Eli Friedman
On Wed, Oct 17, 2012 at 5:41 AM, Benoit Perrot ben...@lrde.epita.fr wrote: Hi, Please include a testcase with a patch where appropriate. (In this case, see test/SemaCXX/ast-print.cpp .) Of course. Here is the patch completed with a test. r166227. -Eli

Re: [cfe-commits] clang patch for bug 14021

2012-10-18 Thread Jan Voung
On Thu, Oct 18, 2012 at 1:20 PM, David Blaikie dblai...@gmail.com wrote: On Thu, Oct 18, 2012 at 1:15 PM, Jan Voung jvo...@chromium.org wrote: Attached is a creduce'd test case which compiles without any clang errors, but would have broken the assertion that lock_hack == 0 that was in

Re: [cfe-commits] [PATCH] Fix pretty-printing of decl group stmts

2012-10-18 Thread Eli Friedman
On Thu, Oct 18, 2012 at 5:06 AM, Richard Membarth richard.memba...@informatik.uni-erlangen.de wrote: Attached is a patch that fixes pretty-printing of decl stmt groups. The example below shows that the current type pretty-printer does not print the variable name if Policy.SuppressSpecifiers is

[cfe-commits] r166228 - in /cfe/trunk: include/clang/Serialization/ASTReader.h include/clang/Serialization/Module.h lib/Serialization/ASTReader.cpp

2012-10-18 Thread Douglas Gregor
Author: dgregor Date: Thu Oct 18 16:18:25 2012 New Revision: 166228 URL: http://llvm.org/viewvc/llvm-project?rev=166228view=rev Log: Move information about the original file from the ASTReader into the module files. Modified: cfe/trunk/include/clang/Serialization/ASTReader.h

Re: [cfe-commits] [PATCH] External Sema Source

2012-10-18 Thread Vassil Vassilev
On 10/18/12 7:04 PM, Douglas Gregor wrote: On Oct 11, 2012, at 8:02 AM, Vassil Vassilev vasil.georgiev.vasi...@cern.ch wrote: Hi, We need to attach multiple ExternalSources to Sema, to provide modules /and/ last resort lookup. Right now that's a pain. The attached patch makes this much

Re: [cfe-commits] clang patch for bug 14021

2012-10-18 Thread David Blaikie
On Thu, Oct 18, 2012 at 2:07 PM, Jan Voung jvo...@chromium.org wrote: On Thu, Oct 18, 2012 at 1:20 PM, David Blaikie dblai...@gmail.com wrote: On Thu, Oct 18, 2012 at 1:15 PM, Jan Voung jvo...@chromium.org wrote: Attached is a creduce'd test case which compiles without any clang errors,

[cfe-commits] r166229 - in /cfe/trunk: include/clang/Serialization/ASTReader.h include/clang/Serialization/Module.h lib/Serialization/ASTReader.cpp

2012-10-18 Thread Douglas Gregor
Author: dgregor Date: Thu Oct 18 16:31:35 2012 New Revision: 166229 URL: http://llvm.org/viewvc/llvm-project?rev=166229view=rev Log: Move the RelocatablePCH bit from the ASTReader to the module file. Modified: cfe/trunk/include/clang/Serialization/ASTReader.h

[cfe-commits] r166230 - in /cfe/trunk: include/clang/Driver/Option.h lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp

2012-10-18 Thread Michael J. Spencer
Author: mspencer Date: Thu Oct 18 16:36:01 2012 New Revision: 166230 URL: http://llvm.org/viewvc/llvm-project?rev=166230view=rev Log: [Options] Make Option non clang specific. Modified: cfe/trunk/include/clang/Driver/Option.h cfe/trunk/lib/Driver/Driver.cpp

[cfe-commits] r166231 - in /cfe/trunk: include/clang/AST/Comment.h lib/AST/Comment.cpp lib/AST/CommentDumper.cpp lib/AST/CommentSema.cpp tools/libclang/CXComment.cpp unittests/AST/CommentParser.cpp

2012-10-18 Thread Fariborz Jahanian
Author: fjahanian Date: Thu Oct 18 16:42:42 2012 New Revision: 166231 URL: http://llvm.org/viewvc/llvm-project?rev=166231view=rev Log: [doc parsing] use getParamName to access parameter for current(rewritten) comment and getParamNameAsWritten to access param name coming with \param marker.

Re: [cfe-commits] r165771 - in /cfe/trunk: include/clang/AST/ASTContext.h include/clang/AST/Comment.h lib/AST/ASTContext.cpp lib/AST/Comment.cpp lib/AST/CommentSema.cpp test/Index/overriding-method-co

2012-10-18 Thread jahanian
On Oct 18, 2012, at 9:18 AM, Douglas Gregor dgre...@apple.com wrote: Hi Dmitri, On Oct 18, 2012, at 5:03 AM, Dmitri Gribenko griboz...@gmail.com wrote: (2) ParamCommandComment::getParamName and others used to return the parameter name *as written* in \param command, without any regard

[cfe-commits] r166233 - in /cfe/trunk: include/clang/Serialization/ASTReader.h lib/Serialization/ASTReader.cpp

2012-10-18 Thread Douglas Gregor
Author: dgregor Date: Thu Oct 18 16:47:16 2012 New Revision: 166233 URL: http://llvm.org/viewvc/llvm-project?rev=166233view=rev Log: Move OriginalDir from ASTReader to ModuleFile. Modified: cfe/trunk/include/clang/Serialization/ASTReader.h cfe/trunk/lib/Serialization/ASTReader.cpp

[cfe-commits] r166235 - /cfe/trunk/include/clang/Driver/Option.h

2012-10-18 Thread Eric Christopher
Author: echristo Date: Thu Oct 18 16:52:10 2012 New Revision: 166235 URL: http://llvm.org/viewvc/llvm-project?rev=166235view=rev Log: Remove trailing comma. Modified: cfe/trunk/include/clang/Driver/Option.h Modified: cfe/trunk/include/clang/Driver/Option.h URL:

[cfe-commits] r166236 - in /cfe/trunk: include/clang/Driver/CC1Options.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGDebugInfo.cpp lib/Driver/Tools.cpp lib/F

2012-10-18 Thread Eric Christopher
Author: echristo Date: Thu Oct 18 16:52:18 2012 New Revision: 166236 URL: http://llvm.org/viewvc/llvm-project?rev=166236view=rev Log: Add a new option for and disable column number information as there are no known current users of column info. Robustify and fix up a few tests in the process.

[cfe-commits] r166237 - in /cfe/trunk: lib/AST/StmtPrinter.cpp test/SemaCXX/ast-print.cpp

2012-10-18 Thread Eli Friedman
Author: efriedma Date: Thu Oct 18 16:53:46 2012 New Revision: 166237 URL: http://llvm.org/viewvc/llvm-project?rev=166237view=rev Log: Use the type as written when pretty-printing C-style casts. Patch by Grzegorz Jablonski. Modified: cfe/trunk/lib/AST/StmtPrinter.cpp

Re: [cfe-commits] r166236 - in /cfe/trunk: include/clang/Driver/CC1Options.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGDebugInfo.cpp lib/Driver/Tools.cpp l

2012-10-18 Thread Douglas Gregor
On Oct 18, 2012, at 2:52 PM, Eric Christopher echri...@gmail.com wrote: Author: echristo Date: Thu Oct 18 16:52:18 2012 New Revision: 166236 URL: http://llvm.org/viewvc/llvm-project?rev=166236view=rev Log: Add a new option for and disable column number information as there are no known

Re: [cfe-commits] r166236 - in /cfe/trunk: include/clang/Driver/CC1Options.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGDebugInfo.cpp lib/Driver/Tools.cpp l

2012-10-18 Thread Chris Lattner
On Oct 18, 2012, at 2:58 PM, Douglas Gregor dgre...@apple.com wrote: On Oct 18, 2012, at 2:52 PM, Eric Christopher echri...@gmail.com wrote: Author: echristo Date: Thu Oct 18 16:52:18 2012 New Revision: 166236 URL: http://llvm.org/viewvc/llvm-project?rev=166236view=rev Log: Add a

Re: [cfe-commits] r166188 - /cfe/trunk/lib/Sema/SemaInit.cpp

2012-10-18 Thread Robert Muth
On Thu, Oct 18, 2012 at 4:48 PM, David Blaikie dblai...@gmail.com wrote: On Thu, Oct 18, 2012 at 1:45 PM, Douglas Gregor dgre...@apple.com wrote: On Oct 18, 2012, at 9:57 AM, David Blaikie dblai...@gmail.com wrote: Author: dblaikie Date: Thu Oct 18 11:57:32 2012 New Revision: 166188 URL:

Re: [cfe-commits] r166236 - in /cfe/trunk: include/clang/Driver/CC1Options.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGDebugInfo.cpp lib/Driver/Tools.cpp l

2012-10-18 Thread Eric Christopher
I'd rather we try to optimize column-number computation first. If we can make it fast enough, we don't need to add this tweaking flag. I think the two are orthogonal here. Basically there's no reason to bother emitting them unless someone is using them. We do a reasonable job of emitting a

Re: [cfe-commits] [PATCH] [llvm+clang] memset for non-8-bit bytes

2012-10-18 Thread Chris Lattner
On Oct 18, 2012, at 6:11 AM, Patrik Hägglund H patrik.h.haggl...@ericsson.com wrote: We have a back-end with 16-bit bytes, and have changed the memset intrinsics to be able to work on arbitrary word sizes, just as memcpy. Hi Patrik, This is interesting. Please start a thread on llvmdev

Re: [cfe-commits] r166236 - in /cfe/trunk: include/clang/Driver/CC1Options.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGDebugInfo.cpp lib/Driver/Tools.cpp l

2012-10-18 Thread Douglas Gregor
On Oct 18, 2012, at 3:00 PM, Chris Lattner clatt...@apple.com wrote: On Oct 18, 2012, at 2:58 PM, Douglas Gregor dgre...@apple.com wrote: On Oct 18, 2012, at 2:52 PM, Eric Christopher echri...@gmail.com wrote: Author: echristo Date: Thu Oct 18 16:52:18 2012 New Revision: 166236

Re: [cfe-commits] [Patch] compiler-rt: SPARC64-optimized multiply/divide

2012-10-18 Thread Chris Lattner
On Oct 18, 2012, at 1:00 AM, Ed Schouten e...@80386.nl wrote: Hi all, Attached is the latest version of a patch we use at FreeBSD to add optimized multiply/divide functions on SPARC64. Description from the original bug report[1]: Very cool. Please send this to llvm-commits though.

Re: [cfe-commits] r166236 - in /cfe/trunk: include/clang/Driver/CC1Options.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CGDebugInfo.cpp lib/Driver/Tools.cpp l

2012-10-18 Thread Eric Christopher
Hrm, I skimmed over the no known current users. I hate such configuration flags, but this one makes sense. Agreed. I just thought it was a waste to remove the code completely since someone may want the information. -eric ___ cfe-commits mailing

[cfe-commits] r166240 - /cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

2012-10-18 Thread Eric Christopher
Author: echristo Date: Thu Oct 18 17:08:02 2012 New Revision: 166240 URL: http://llvm.org/viewvc/llvm-project?rev=166240view=rev Log: Fix up comment and invert order. Most simple check first. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp

Re: [cfe-commits] [LLVMdev] [cfe-dev] OpenMP support in CLANG: A proposal

2012-10-18 Thread Eli Friedman
On Thu, Oct 18, 2012 at 4:32 AM, Mahesha HS mahesha.l...@gmail.com wrote: Hi Eli, Thanks for all your comments. I have taken care of all your review comments. Yes, after I gone through your review comments, I also came to the conclusion that the addition of a new class for OpenMP pragma

Re: [cfe-commits] [LLVMdev] [cfe-dev] OpenMP support in CLANG: A proposal

2012-10-18 Thread Eli Friedman
On Thu, Oct 18, 2012 at 6:34 AM, Mahesha HS mahesha.l...@gmail.com wrote: Sorry, in my previous mail, I had missed to attach changes to clang/include/clang/Basic/TokenKinds.def in the patch 2. Please refer to the patch (2) attached in *this* mail, instead of the one sent in the previous mail.

  1   2   >