Re: [PATCH] D10700: Driver: Add AMDGPU toolchain

2015-07-16 Thread Chad Rosier
mcrosier accepted this revision. mcrosier added a comment. This revision is now accepted and ready to land. Seems reasonable to me. http://reviews.llvm.org/D10700 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

Re: [PATCH] Avoid false positive/negative test results from line directive interference

2015-06-26 Thread Chad Rosier
Committed r240801 http://reviews.llvm.org/D10443 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

r240801 - Avoid false positive/negative test results from line directive interference.NFC.

2015-06-26 Thread Chad Rosier
Author: mcrosier Date: Fri Jun 26 12:49:10 2015 New Revision: 240801 URL: http://llvm.org/viewvc/llvm-project?rev=240801view=rev Log: Avoid false positive/negative test results from line directive interference.NFC. http://reviews.llvm.org/D10443 Patch by Geoff Berry. Modified:

Re: [PATCH] Disable preprocessor line directives to avoid false positive/negative test results

2015-06-15 Thread Chad Rosier
LGTM. Might be worthwhile to FileCheckize the test, which would allow you to reduce the number of RUN lines. http://reviews.llvm.org/D10443 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list

Re: [PATCH] Test case for adding support for parsing the XOR operator in Microsoft inline assembly

2015-06-11 Thread Chad Rosier
LGTM. REPOSITORY rL LLVM http://reviews.llvm.org/D10384 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] Fix for PR14269: Clang crashes when a bit field is used as inline assembler input / output with memory constraint

2015-06-04 Thread Chad Rosier
I think it's acceptable to reference a PR# in the test case, but in general we don't include these in the source code unless there's an associated FIXME. Please remove the PR#s from SemaStmtAsm.cpp. Otherwise, seems reasonable to me. http://reviews.llvm.org/D10086 EMAIL PREFERENCES

Re: [PATCH] Fix crash in handling back-end warnings

2015-05-11 Thread Chad Rosier
Committed by Diego in r236898. http://reviews.llvm.org/D9449 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] Driver tests: don't assume the clang binary is called 'clang'

2015-04-22 Thread Chad Rosier
REPOSITORY rL LLVM http://reviews.llvm.org/D9133 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] Driver tests: don't assume the clang binary is called 'clang'

2015-04-22 Thread Chad Rosier
Sounds reasonable. REPOSITORY rL LLVM http://reviews.llvm.org/D9133 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

Re: [PATCH] Pass inlinehint attribute to optimizer for all user marked inline functions

2015-04-01 Thread Chad Rosier
Many thanks, Reed! http://reviews.llvm.org/D8656 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] Pass inlinehint attribute to optimizer for all user marked inline functions

2015-03-27 Thread Chad Rosier
I've added Doug and John in hopes that someone with more experience with this code can give a proper review. Jakob was the original author.. AFAICT, the isInlined() API will return true for more than just those decls that include the 'inline' keyword. I'm not sure that's the behavior we want.

Re: [PATCH] Improve robustness of dependency-generation-crash.c test.

2015-03-02 Thread Chad Rosier
Seems reasonable. REPOSITORY rL LLVM http://reviews.llvm.org/D7620 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

r223471 - Fix Typos in include/clang-c/Index.h

2014-12-05 Thread Chad Rosier
Author: mcrosier Date: Fri Dec 5 09:50:44 2014 New Revision: 223471 URL: http://llvm.org/viewvc/llvm-project?rev=223471view=rev Log: Fix Typos in include/clang-c/Index.h Phabricator revision: http://reviews.llvm.org/D6507 Modified: cfe/trunk/include/clang-c/Index.h Modified:

Re: [PATCH] Fix Typos in include/clang-c/Index.h

2014-12-05 Thread Chad Rosier
Committed r223471. http://reviews.llvm.org/D6507 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] Fix Typos in llvm/IR/Module.h

2014-12-05 Thread Chad Rosier
Committed r223472. http://reviews.llvm.org/D6535 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] Update TargetTriple Format Info

2014-12-05 Thread Chad Rosier
Committed r223473. http://reviews.llvm.org/D6543 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] Backporting some changes from master to release_35 branch .

2014-12-05 Thread Chad Rosier
Daniel is correct. Committing to the release branch has additional restrictions. Thanks, Daniel. http://reviews.llvm.org/D6502 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] These builtin functions set errno. Mark them accordingly.

2014-12-01 Thread Chad Rosier
Rebase, per Hal's request. http://reviews.llvm.org/D3806 Files: include/clang/Basic/Builtins.def Index: include/clang/Basic/Builtins.def === --- include/clang/Basic/Builtins.def +++ include/clang/Basic/Builtins.def @@ -84,7 +84,7

r222397 - Revert [Reassociate] Update test cases due to r222142.

2014-11-19 Thread Chad Rosier
Author: mcrosier Date: Wed Nov 19 17:20:35 2014 New Revision: 222397 URL: http://llvm.org/viewvc/llvm-project?rev=222397view=rev Log: Revert [Reassociate] Update test cases due to r222142. This reverts commit r222144. Commit r222142 is being reverted due to a spec2006/gcc execution-time

r222144 - [Reassociate] Update test cases due to r222142.

2014-11-17 Thread Chad Rosier
Author: mcrosier Date: Mon Nov 17 10:34:47 2014 New Revision: 222144 URL: http://llvm.org/viewvc/llvm-project?rev=222144view=rev Log: [Reassociate] Update test cases due to r222142. Modified: cfe/trunk/test/CodeGen/aarch64-neon-intrinsics.c cfe/trunk/test/CodeGen/bmi-builtins.c

Re: r219619 - Relinquish ownership of MS-style inline assembly.

2014-10-13 Thread Chad Rosier
:21 2014 @@ -39,7 +39,7 @@ D: Clang LLVM IR generation N: Chad Rosier E: mcros...@codeaurora.org -D: MS-inline asm, and the compiler driver +D: Compiler driver N: Richard Smith E: rich...@metafoo.co.uk ___ cfe-commits mailing list cfe

r219619 - Relinquish ownership of MS-style inline assembly.

2014-10-13 Thread Chad Rosier
: Chad Rosier E: mcros...@codeaurora.org -D: MS-inline asm, and the compiler driver +D: Compiler driver N: Richard Smith E: rich...@metafoo.co.uk ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: r217546 - Only override the target architecture on -m32 and friends if it is

2014-09-12 Thread Chad Rosier
On Thu, Sep 11, 2014 at 10:08:18AM -0700, Hans Wennborg wrote: On Wed, Sep 10, 2014 at 2:46 PM, Joerg Sonnenberger jo...@britannica.bec.de wrote: On Wed, Sep 10, 2014 at 09:25:37PM -, Joerg Sonnenberger wrote: Author: joerg Date: Wed Sep 10 16:25:37 2014 New Revision: 217546

Re: r215051 - Driver: Add -fno-profile-arcs to go with -fprofile-arcs

2014-08-07 Thread Chad Rosier
Chad Rosier mcros...@codeaurora.org writes: A test case might not be a bad idea.. Can't get away with anything around here ;) Added a test for the new flag and a bonus test for the previously untested -fprofile-arcs in r215053. Thanks for adding the test as well as being a good sport

Re: r215051 - Driver: Add -fno-profile-arcs to go with -fprofile-arcs

2014-08-06 Thread Chad Rosier
A test case might not be a bad idea.. Author: bogner Date: Wed Aug 6 22:14:34 2014 New Revision: 215051 URL: http://llvm.org/viewvc/llvm-project?rev=215051view=rev Log: Driver: Add -fno-profile-arcs to go with -fprofile-arcs This is a trivial gcc-compatible change. Modified:

Re: [PATCH] These builtin functions set errno. Mark them accordingly.

2014-05-19 Thread Chad Rosier
Hal and I discussed this on IRC and here's the synopsis (mostly in Hal's words): Many of these builtins turn into libc calls, and those do set errno. Marking them as readnone is a problem, because we can reorder/eliminate writes to errno. For example, if we assume readnone for something like

[PATCH] These builtin functions set errno. Mark them accordingly.

2014-05-16 Thread Chad Rosier
CC'ing cfe-commits. Hi bob.wilson, chandlerc, grosbach, apazos, rjmccall, A number of library calls that set errno were not behaving correctly with -fmath-errno. Specifically, they were being lowered to native instruction and not setting errno. The changes are based on grepping through the

r207858 - [driver] Enable the slp vectorizer at -Oz.

2014-05-02 Thread Chad Rosier
Author: mcrosier Date: Fri May 2 13:41:57 2014 New Revision: 207858 URL: http://llvm.org/viewvc/llvm-project?rev=207858view=rev Log: [driver] Enable the slp vectorizer at -Oz. PR19568 Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/clang_f_opts.c Modified:

r207433 - [driver] Disable the slp vectorizer at -O0, -O1, and -Oz. This mirrors the

2014-04-28 Thread Chad Rosier
Author: mcrosier Date: Mon Apr 28 14:30:57 2014 New Revision: 207433 URL: http://llvm.org/viewvc/llvm-project?rev=207433view=rev Log: [driver] Disable the slp vectorizer at -O0, -O1, and -Oz. This mirrors the behavior of the loop vectorizer, which is enabled at -O2, -O3, -O4, -Ofast and -Os.

Re: r207433 - [driver] Disable the slp vectorizer at -O0, -O1, and -Oz. This mirrors the

2014-04-28 Thread Chad Rosier
was mostly arbitrary and I have no strong feelings either way. What are your thoughts? Chad On Mon, Apr 28, 2014 at 12:30 PM, Chad Rosier mcros...@codeaurora.orgwrote: -O1, and -Oz Wait, why? Based on what discussion? This is a pretty significant change, I'd like to understand why it was made

Re: r207433 - [driver] Disable the slp vectorizer at -O0, -O1, and -Oz. This mirrors the

2014-04-28 Thread Chad Rosier
me know if you feel otherwise. The decision to match the behavior of the loop vectorizer at -O1 and -Oz was mostly arbitrary and I have no strong feelings either way. What are your thoughts? Chad On Mon, Apr 28, 2014 at 12:30 PM, Chad Rosier mcros...@codeaurora.orgwrote: -O1, and -Oz

Re: [PATCH] PR19515, driver crash while handling a clang crash

2014-04-28 Thread Chad Rosier
LGTM. After a compiler crash (which prints the traceback and so forth), Driver::generateCompilationDiagnostics calls BuildInputs to get a list of inputs to pass to the preprocessor. BuildInputs runs through the command-line arguments. If the original command line included -lstdc++ this was

r197403 - [AArch64] Fix v1fx patterns for Floating-point Multiply Extend and Floating-point Compare to Zero.

2013-12-16 Thread Chad Rosier
Author: mcrosier Date: Mon Dec 16 12:29:54 2013 New Revision: 197403 URL: http://llvm.org/viewvc/llvm-project?rev=197403view=rev Log: [AArch64] Fix v1fx patterns for Floating-point Multiply Extend and Floating-point Compare to Zero. Modified: cfe/trunk/test/CodeGen/aarch64-neon-intrinsics.c

r197070 - [AArch64] Refactor the NEON scalar floating-point reciprocal step and

2013-12-11 Thread Chad Rosier
Author: mcrosier Date: Wed Dec 11 15:03:54 2013 New Revision: 197070 URL: http://llvm.org/viewvc/llvm-project?rev=197070view=rev Log: [AArch64] Refactor the NEON scalar floating-point reciprocal step and floating-point reciprocal square root step LLVM AArch64 intrinsics to use f32/f64 types,

r197071 - [AArch64] Add NEON scalar floating-point compare LLVM AArch64 intrinsics that

2013-12-11 Thread Chad Rosier
Author: mcrosier Date: Wed Dec 11 15:03:56 2013 New Revision: 197071 URL: http://llvm.org/viewvc/llvm-project?rev=197071view=rev Log: [AArch64] Add NEON scalar floating-point compare LLVM AArch64 intrinsics that use f32/f64 types, rather than their vector equivalents. Modified:

r197069 - [AArch64] Refactor the NEON scalar floating-point reciprocal estimate, floating-

2013-12-11 Thread Chad Rosier
Author: mcrosier Date: Wed Dec 11 15:03:52 2013 New Revision: 197069 URL: http://llvm.org/viewvc/llvm-project?rev=197069view=rev Log: [AArch64] Refactor the NEON scalar floating-point reciprocal estimate, floating- point reciprocal exponent, and floating-point reciprocal square root estimate LLVM

r197091 - [AArch64] Refactor NEON floating-point Max/Min/Maxnm/Minnm across vector AArch64

2013-12-11 Thread Chad Rosier
Author: mcrosier Date: Wed Dec 11 17:21:39 2013 New Revision: 197091 URL: http://llvm.org/viewvc/llvm-project?rev=197091view=rev Log: [AArch64] Refactor NEON floating-point Max/Min/Maxnm/Minnm across vector AArch64 intrinsics to use f32 types, rather than their vector equivalents. Modified:

r196927 - [AArch64] Refactor the Neon vector/scalar floating-point convert implementation.

2013-12-10 Thread Chad Rosier
Author: mcrosier Date: Tue Dec 10 09:35:40 2013 New Revision: 196927 URL: http://llvm.org/viewvc/llvm-project?rev=196927view=rev Log: [AArch64] Refactor the Neon vector/scalar floating-point convert implementation. Specifically, reuse the ARM intrinsics when possible. Modified:

r196931 - [AArch64] Refactor the Neon vector/scalar floating-point convert intrinsics so

2013-12-10 Thread Chad Rosier
Author: mcrosier Date: Tue Dec 10 10:11:55 2013 New Revision: 196931 URL: http://llvm.org/viewvc/llvm-project?rev=196931view=rev Log: [AArch64] Refactor the Neon vector/scalar floating-point convert intrinsics so that they use float/double rather than the vector equivalents when appropriate.

r196936 - [AArch64] Refactor the redundant code in the EmitAArch64ScalarBuiltinExpr()

2013-12-10 Thread Chad Rosier
Author: mcrosier Date: Tue Dec 10 11:44:36 2013 New Revision: 196936 URL: http://llvm.org/viewvc/llvm-project?rev=196936view=rev Log: [AArch64] Refactor the redundant code in the EmitAArch64ScalarBuiltinExpr() function. No functional change intended. Modified:

r196966 - [AArch64] Overload NEON signed/unsigned integer convert to floating-point

2013-12-10 Thread Chad Rosier
Author: mcrosier Date: Tue Dec 10 15:34:17 2013 New Revision: 196966 URL: http://llvm.org/viewvc/llvm-project?rev=196966view=rev Log: [AArch64] Overload NEON signed/unsigned integer convert to floating-point LLVM AArch64 intrinsics. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp Modified:

r196968 - [AArch64] Refactor the NEON signed/unsigned floating-point convert to fixed-point

2013-12-10 Thread Chad Rosier
Author: mcrosier Date: Tue Dec 10 15:34:21 2013 New Revision: 196968 URL: http://llvm.org/viewvc/llvm-project?rev=196968view=rev Log: [AArch64] Refactor the NEON signed/unsigned floating-point convert to fixed-point LLVM AArch64 intrinsics to use f32/f64, rather than their vector equivalents.

r196967 - [AArch64] Overload NEON signed/unsigned floating-point convert to fixed-point

2013-12-10 Thread Chad Rosier
Author: mcrosier Date: Tue Dec 10 15:34:20 2013 New Revision: 196967 URL: http://llvm.org/viewvc/llvm-project?rev=196967view=rev Log: [AArch64] Overload NEON signed/unsigned floating-point convert to fixed-point and fixed-point convert to floating-point LLVM AArch64 intrinsics. Modified:

r196969 - [AArch64] Refactor the NEON floating-point absolute difference LLVM AArch64

2013-12-10 Thread Chad Rosier
Author: mcrosier Date: Tue Dec 10 15:34:23 2013 New Revision: 196969 URL: http://llvm.org/viewvc/llvm-project?rev=196969view=rev Log: [AArch64] Refactor the NEON floating-point absolute difference LLVM AArch64 intrinsic to use f32/f64 types, rather than their vector equivalents. Modified:

r196834 - [AArch64] Remove q and non-q intrinsic definitions from the NEON scalar reduce

2013-12-09 Thread Chad Rosier
Author: mcrosier Date: Mon Dec 9 16:47:55 2013 New Revision: 196834 URL: http://llvm.org/viewvc/llvm-project?rev=196834view=rev Log: [AArch64] Remove q and non-q intrinsic definitions from the NEON scalar reduce pairwise implementation, using an overloaded definition instead. Modified:

r196835 - [AArch64] Refactor the NEON scalar reduce pairwise front-end codegen to remove

2013-12-09 Thread Chad Rosier
Author: mcrosier Date: Mon Dec 9 16:47:57 2013 New Revision: 196835 URL: http://llvm.org/viewvc/llvm-project?rev=196835view=rev Log: [AArch64] Refactor the NEON scalar reduce pairwise front-end codegen to remove unnecessary patterns in tablegen. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp

r196836 - [AArch64] Refactor the NEON scalar reduce pairwise intrinsics so that they use

2013-12-09 Thread Chad Rosier
Author: mcrosier Date: Mon Dec 9 16:47:59 2013 New Revision: 196836 URL: http://llvm.org/viewvc/llvm-project?rev=196836view=rev Log: [AArch64] Refactor the NEON scalar reduce pairwise intrinsics so that they use float/double rather than the vector equivalents when appropriate. Modified:

Re: r196152 - [AArch64] Add missing NEON scalar floating-point to integer convert ACLEs.

2013-12-03 Thread Chad Rosier
/3 Chad Rosier mcros...@codeaurora.org: Author: mcrosier Date: Mon Dec 2 15:07:24 2013 New Revision: 196152 URL: http://llvm.org/viewvc/llvm-project?rev=196152view=rev Log: [AArch64] Add missing NEON scalar floating-point to integer convert ACLEs. Modified: cfe/trunk/include/clang

r196152 - [AArch64] Add missing NEON scalar floating-point to integer convert ACLEs.

2013-12-02 Thread Chad Rosier
Author: mcrosier Date: Mon Dec 2 15:07:24 2013 New Revision: 196152 URL: http://llvm.org/viewvc/llvm-project?rev=196152view=rev Log: [AArch64] Add missing NEON scalar floating-point to integer convert ACLEs. Modified: cfe/trunk/include/clang/Basic/arm_neon.td

r196153 - [AArch64] Implemented vcopy_lane patterns using scalar DUP instruction.

2013-12-02 Thread Chad Rosier
Author: mcrosier Date: Mon Dec 2 15:07:27 2013 New Revision: 196153 URL: http://llvm.org/viewvc/llvm-project?rev=196153view=rev Log: [AArch64] Implemented vcopy_lane patterns using scalar DUP instruction. Patch by Ana Pazos! Modified: cfe/trunk/include/clang/Basic/arm_neon.td

[PATCH][AArch64] Request to push AArch64 patches to the release 3.4 branch

2013-11-27 Thread Chad Rosier
Hi Bill, Sorry to be a nuance.. (at least more so than usual ;) When you have a moment can you please cherry-pick these changes into the 3.4 branch? clang/llvm r195788/r195789 - Add support for NEON scalar floating-point to integer convert instructions. r195803/r195804 - Add support for NEON

r195789 - [AArch64] Add support for NEON scalar floating-point to integer convert

2013-11-26 Thread Chad Rosier
Author: mcrosier Date: Tue Nov 26 16:17:51 2013 New Revision: 195789 URL: http://llvm.org/viewvc/llvm-project?rev=195789view=rev Log: [AArch64] Add support for NEON scalar floating-point to integer convert instructions. Added: cfe/trunk/test/CodeGen/aarch64-neon-fcvt-intrinsics.c Modified:

r195804 - [AArch64] Add support for NEON scalar floating-point absolute difference.

2013-11-26 Thread Chad Rosier
Author: mcrosier Date: Tue Nov 26 19:46:19 2013 New Revision: 195804 URL: http://llvm.org/viewvc/llvm-project?rev=195804view=rev Log: [AArch64] Add support for NEON scalar floating-point absolute difference. Modified: cfe/trunk/include/clang/Basic/arm_neon.td

[PATCH][AArch64] Add support for vget/vset_lane_f16 ACLE functions

2013-11-25 Thread Chad Rosier
All, The attached patches add support for the vget_lane_f16, vgetq_lane_f16, vset_lane_f16, and vsetq_lane_f16 ACLEs. I'm checking the target triple to allow for half-float arguments/return types in Sema. However, I'm currently looking into defining the AArch64 PCS as an alternative solution. I

Re: [PATCH][AArch64] Add support for vget/vset_lane_f16 ACLE functions

2013-11-25 Thread Chad Rosier
Hi Tim, Hi Chad, I'm checking the target triple to allow for half-float arguments/return types in Sema. However, I'm currently looking into defining the AArch64 PCS as an alternative solution. I was hoping we could get these patches into the 3.4 release, so I'm sending patches with the

Re: [PATCH][AArch64] Add support for vget/vset_lane_f16 ACLE functions

2013-11-25 Thread Chad Rosier
Hi Chad, According to the latest documentation I have the ACLE prototypes for vget/vset_lane_f16 are: float16_t vget_lane_f16(float16x4_t v, const int lane) My interpretation has always been that the prototypes and calling conventions of the intrinsics themselves are merely notional. If

Re: r195047 - Make test/Driver/clang_f_opts.c not write to the test dir

2013-11-19 Thread Chad Rosier
Hi Hans, IIRC, the general convention is to use %t for temporary files. lit will clean up after itself. However, since your not running FileCheck on the output maybe it doesn't matter. Chad Author: hans Date: Mon Nov 18 15:58:33 2013 New Revision: 195047 URL:

RE: [PATCH][AArch64]Implement vreinterpret ACLE functions in Clang

2013-11-18 Thread Chad Rosier
Great. Thanks, Hao. Hi Chad, Thanks for the review. I've changed to use CHECK-LABEL and committed in http://llvm.org/viewvc/llvm-project?view=revisionrevision=194954 Thanks, -Hao -Original Message- From: Chad Rosier [mailto:mcros...@codeaurora.org] Sent: Friday, November 15

Re: [PATCH] Add predicate for AArch64 crypto instructions

2013-11-18 Thread Chad Rosier
LGTM. Hi, Attached is the patch of adding predicate for AArch64 crypto instructions. -- Thanks, -Jiangning ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits -- Qualcomm Innovation

Re: r194743 - Pass -Wa, -I and -Xassembler -I args to integrated assembler

2013-11-15 Thread Chad Rosier
Author: dpeixott Date: Thu Nov 14 16:52:58 2013 New Revision: 194743 URL: http://llvm.org/viewvc/llvm-project?rev=194743view=rev Log: Pass -Wa,-I and -Xassembler -I args to integrated assembler This patch adds -I to the arguments that are passed to the integrated assembler from -Wa, and

Re: [LLVMdev] [PATCH] Prevent clang from throwing the diagnostics twice.

2013-11-15 Thread Chad Rosier
Hi Umesh, Should the call to StringRef::getAsInteger() be predicated on the A-getIssuedDiagnostics() call? I assume the common case would be that we don't emit a diagnostic and thus the below would be a faster implementation: if (StringRef(A-getValue()).getAsInteger(10, Res)) { if (Diags) {

Re: [PATCH] Prevent clang from throwing the diagnostics twice.

2013-11-15 Thread Chad Rosier
Test cases? Yes, please. Also, this seems a bit heavy-handed for a solution. Why is getLastArgIntValue being called twice in the first place? I tend to agree with Aaron here. However, I can't think of a better solution. Perhaps the issue is that getOptimizationLevel() is being called

r194829 - Update contact information.

2013-11-15 Thread Chad Rosier
: Chad Rosier -E: chad.ros...@gmail.com +E: mcros...@codeaurora.org D: MS-inline asm, and the compiler driver N: Richard Smith ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [LLVMdev] [PATCH] Prevent clang from throwing the diagnostics twice.

2013-11-15 Thread Chad Rosier
As Chad pointed, it's likely that this requires a non-trivial refactoring. I don't have particularly bright ideas on solving it, but I'm uncomfortable adding the flag at the arg level because it kind of encourages lazy design when handling args. Perhaps looking into ways the code could be

r194854 - These ACLE tests no longer need to cast the return value.

2013-11-15 Thread Chad Rosier
Author: mcrosier Date: Fri Nov 15 15:28:24 2013 New Revision: 194854 URL: http://llvm.org/viewvc/llvm-project?rev=194854view=rev Log: These ACLE tests no longer need to cast the return value. Modified: cfe/trunk/test/CodeGen/aarch64-neon-intrinsics.c Modified:

Re: [PATCH][AArch64]Implement vreinterpret ACLE functions in Clang

2013-11-14 Thread Chad Rosier
Hao, My only suggestion would be to use the CHECK-LABEL directive for each of the function names. Otherwise, LGTM. Chad Hi, The attached patch implements the vreinterpret functions in Clang. As such functions are implemented by typecast, there is no instruction generated in the

r194732 - [AArch64] Add support for legacy AArch32 NEON scalar shift right by immediate

2013-11-14 Thread Chad Rosier
Author: mcrosier Date: Thu Nov 14 16:02:24 2013 New Revision: 194732 URL: http://llvm.org/viewvc/llvm-project?rev=194732view=rev Log: [AArch64] Add support for legacy AArch32 NEON scalar shift right by immediate and accumulate instructions. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp

r194599 - [AArch64] Tests for legacy AArch32 NEON scalar shift by immediate instructions.

2013-11-13 Thread Chad Rosier
Author: mcrosier Date: Wed Nov 13 14:05:44 2013 New Revision: 194599 URL: http://llvm.org/viewvc/llvm-project?rev=194599view=rev Log: [AArch64] Tests for legacy AArch32 NEON scalar shift by immediate instructions. A number of non-overloaded intrinsics have been replaced by thier overloaded

r194395 - [AArch64] Add support for NEON scalar floating-point convert to fixed-point instructions.

2013-11-11 Thread Chad Rosier
Author: mcrosier Date: Mon Nov 11 12:04:22 2013 New Revision: 194395 URL: http://llvm.org/viewvc/llvm-project?rev=194395view=rev Log: [AArch64] Add support for NEON scalar floating-point convert to fixed-point instructions. Modified: cfe/trunk/include/clang/Basic/arm_neon.td

r194407 - [AArch64] The shift right/left and insert immediate builtins expect 3

2013-11-11 Thread Chad Rosier
Author: mcrosier Date: Mon Nov 11 13:11:19 2013 New Revision: 194407 URL: http://llvm.org/viewvc/llvm-project?rev=194407view=rev Log: [AArch64] The shift right/left and insert immediate builtins expect 3 source operands, a vector, an element to insert, and a shift amount. Modified:

r193791 - [AArch64] Add support for NEON scalar shift immediate instructions.

2013-10-31 Thread Chad Rosier
Author: mcrosier Date: Thu Oct 31 14:29:05 2013 New Revision: 193791 URL: http://llvm.org/viewvc/llvm-project?rev=193791view=rev Log: [AArch64] Add support for NEON scalar shift immediate instructions. Modified: cfe/trunk/include/clang/Basic/arm_neon.td

r193817 - [AArch64] Add support for NEON scalar fixed-point convert to floating-point instructions.

2013-10-31 Thread Chad Rosier
Author: mcrosier Date: Thu Oct 31 17:37:08 2013 New Revision: 193817 URL: http://llvm.org/viewvc/llvm-project?rev=193817view=rev Log: [AArch64] Add support for NEON scalar fixed-point convert to floating-point instructions. Modified: cfe/trunk/include/clang/Basic/arm_neon.td

r193692 - [AArch64] Add support for NEON scalar floating-point compare instructions.

2013-10-30 Thread Chad Rosier
Author: mcrosier Date: Wed Oct 30 10:20:07 2013 New Revision: 193692 URL: http://llvm.org/viewvc/llvm-project?rev=193692view=rev Log: [AArch64] Add support for NEON scalar floating-point compare instructions. Modified: cfe/trunk/include/clang/Basic/arm_neon.td

r193118 - [AArch64] Add the constraint to NEON scalar mla/mls instructions.

2013-10-21 Thread Chad Rosier
Author: mcrosier Date: Mon Oct 21 15:12:01 2013 New Revision: 193118 URL: http://llvm.org/viewvc/llvm-project?rev=193118view=rev Log: [AArch64] Add the constraint to NEON scalar mla/mls instructions. Modified: cfe/trunk/include/clang/Basic/arm_neon.td

r192971 - [AArch64] Add support for NEON scalar extract narrow instructions.

2013-10-18 Thread Chad Rosier
Author: mcrosier Date: Fri Oct 18 09:03:36 2013 New Revision: 192971 URL: http://llvm.org/viewvc/llvm-project?rev=192971view=rev Log: [AArch64] Add support for NEON scalar extract narrow instructions. Modified: cfe/trunk/include/clang/Basic/arm_neon.td cfe/trunk/lib/CodeGen/CGBuiltin.cpp

r192909 - [AArch64] Add support for NEON scalar three register different instruction

2013-10-17 Thread Chad Rosier
Author: mcrosier Date: Thu Oct 17 13:12:50 2013 New Revision: 192909 URL: http://llvm.org/viewvc/llvm-project?rev=192909view=rev Log: [AArch64] Add support for NEON scalar three register different instruction class. The instruction class includes the signed saturating doubling multiply-add long,

r192801 - [AArch64] Add support for NEON scalar signed saturating accumulated of unsigned

2013-10-16 Thread Chad Rosier
Author: mcrosier Date: Wed Oct 16 11:09:16 2013 New Revision: 192801 URL: http://llvm.org/viewvc/llvm-project?rev=192801view=rev Log: [AArch64] Add support for NEON scalar signed saturating accumulated of unsigned value and unsigned saturating accumulate of signed value instructions. Modified:

r192804 - Update comment.

2013-10-16 Thread Chad Rosier
Author: mcrosier Date: Wed Oct 16 11:21:43 2013 New Revision: 192804 URL: http://llvm.org/viewvc/llvm-project?rev=192804view=rev Log: Update comment. Modified: cfe/trunk/include/clang/Basic/arm_neon.td Modified: cfe/trunk/include/clang/Basic/arm_neon.td URL:

r192807 - Update comment.

2013-10-16 Thread Chad Rosier
Author: mcrosier Date: Wed Oct 16 11:30:39 2013 New Revision: 192807 URL: http://llvm.org/viewvc/llvm-project?rev=192807view=rev Log: Update comment. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp URL:

r192844 - [AArch64] Add support for NEON scalar absolute value instruction.

2013-10-16 Thread Chad Rosier
Author: mcrosier Date: Wed Oct 16 16:04:49 2013 New Revision: 192844 URL: http://llvm.org/viewvc/llvm-project?rev=192844view=rev Log: [AArch64] Add support for NEON scalar absolute value instruction. Modified: cfe/trunk/include/clang/Basic/arm_neon.td cfe/trunk/lib/CodeGen/CGBuiltin.cpp

r192845 - [AArch64] Add support for NEON scalar negate instruction.

2013-10-16 Thread Chad Rosier
Author: mcrosier Date: Wed Oct 16 16:04:53 2013 New Revision: 192845 URL: http://llvm.org/viewvc/llvm-project?rev=192845view=rev Log: [AArch64] Add support for NEON scalar negate instruction. Modified: cfe/trunk/include/clang/Basic/arm_neon.td cfe/trunk/lib/CodeGen/CGBuiltin.cpp

r192734 - [AArch64] Add support for NEON scalar signed saturating absolute value and

2013-10-15 Thread Chad Rosier
Author: mcrosier Date: Tue Oct 15 16:19:02 2013 New Revision: 192734 URL: http://llvm.org/viewvc/llvm-project?rev=192734view=rev Log: [AArch64] Add support for NEON scalar signed saturating absolute value and scalar signed saturating negate instructions. Modified:

r192597 - [AArch64] Add support for NEON scalar integer compare instructions.

2013-10-14 Thread Chad Rosier
Author: mcrosier Date: Mon Oct 14 09:37:40 2013 New Revision: 192597 URL: http://llvm.org/viewvc/llvm-project?rev=192597view=rev Log: [AArch64] Add support for NEON scalar integer compare instructions. Modified: cfe/trunk/include/clang/Basic/arm_neon.td

r192232 - [AArch64] Add support for NEON scalar signed/unsigned integer to floating-point

2013-10-08 Thread Chad Rosier
Author: mcrosier Date: Tue Oct 8 15:43:46 2013 New Revision: 192232 URL: http://llvm.org/viewvc/llvm-project?rev=192232view=rev Log: [AArch64] Add support for NEON scalar signed/unsigned integer to floating-point convert instructions. Modified: cfe/trunk/include/clang/Basic/arm_neon.td

r192243 - [AArch64] Add support for NEON scalar floating-point reciprocal estimate,

2013-10-08 Thread Chad Rosier
Author: mcrosier Date: Tue Oct 8 17:09:29 2013 New Revision: 192243 URL: http://llvm.org/viewvc/llvm-project?rev=192243view=rev Log: [AArch64] Add support for NEON scalar floating-point reciprocal estimate, reciprocal exponent, and reciprocal square root estimate instructions. Modified:

r192112 - [AArch64] Add support for NEON scalar arithmetic instructions:

2013-10-07 Thread Chad Rosier
Author: mcrosier Date: Mon Oct 7 12:07:17 2013 New Revision: 192112 URL: http://llvm.org/viewvc/llvm-project?rev=192112view=rev Log: [AArch64] Add support for NEON scalar arithmetic instructions: SQDMULH, SQRDMULH, FMULX, FRECPS, and FRSQRTS. Modified:

Re: r175779 - [driver] Handle the processing of the QA_OVERRIDE_GCC3_OPTIONS and CCC_ADD_ARGS

2013-07-23 Thread Chad Rosier
Adding cfe-commits.. On Tue, Jul 23, 2013 at 12:15 PM, Chad Rosier chad.ros...@gmail.com wrote: Rafael, IIRC, the QA_OVERRIDE_GCC3_OPTIONS and CCC_ADD_ARGS are used in various Apple environments and there is no real consensus. Since there's no real overhead here I propose we just leave

Re: r175779 - [driver] Handle the processing of the QA_OVERRIDE_GCC3_OPTIONS and CCC_ADD_ARGS

2013-07-23 Thread Chad Rosier
LGTM. On Tue, Jul 23, 2013 at 2:13 PM, Rafael Espíndola rafael.espind...@gmail.com wrote: On 23 July 2013 12:57, Daniel Dunbar dan...@zuster.org wrote: I think we can get rid of CCC_ADD_ARGS, it is less useful than the other and just predated it. Patch attached :-) - Daniel

Re: r185483 - Debug Info: set default to gdwarf-2 for Darwin.

2013-07-03 Thread Chad Rosier
Manman, Inline comments below. On Jul 2, 2013, at 4:15 PM, Manman Ren m...@apple.com wrote: Author: mren Date: Tue Jul 2 18:15:25 2013 New Revision: 185483 URL: http://llvm.org/viewvc/llvm-project?rev=185483view=rev Log: Debug Info: set default to gdwarf-2 for Darwin. Darwin systems

r185557 - Chris has agree to take part ownership of the driver.

2013-07-03 Thread Chad Rosier
codegen, N: Ted Kremenek D: Clang Static Analyzer +N: Chris Matthews +E: cmatthe...@apple.com +D: The compiler driver + N: John McCall E: rjmcc...@apple.com D: Clang LLVM IR generation N: Chad Rosier -E: mcros...@apple.com +E: chad.ros...@gmail.com D: MS-inline asm, and the compiler

r185574 - Revert r185557 as it was a bit (a lot) premature.

2013-07-03 Thread Chad Rosier
Author: mcrosier Date: Wed Jul 3 15:37:50 2013 New Revision: 185574 URL: http://llvm.org/viewvc/llvm-project?rev=185574view=rev Log: Revert r185557 as it was a bit (a lot) premature. Modified: cfe/trunk/CODE_OWNERS.TXT Modified: cfe/trunk/CODE_OWNERS.TXT URL:

Re: r185557 - Chris has agree to take part ownership of the driver.

2013-07-03 Thread Chad Rosier
On Jul 3, 2013, at 1:19 PM, Eli Friedman eli.fried...@gmail.com wrote: On Wed, Jul 3, 2013 at 10:25 AM, Chad Rosier chad.ros...@gmail.com wrote: Author: mcrosier Date: Wed Jul 3 12:25:50 2013 New Revision: 185557 URL: http://llvm.org/viewvc/llvm-project?rev=185557view=rev Log: Chris

Re: [PATCH, RFC] Fix PR16454

2013-06-28 Thread Chad Rosier
Hi Bill, I'm not sure if this will be helpful, but what happens if you check to make sure you're only performing a single JobAction? If the -save-temps option is being specified, then I assume there will be multiple jobs. I did something kinda like this in:

Re: [cfe-commits] r139677 - /cfe/trunk/lib/Driver/Driver.cpp

2013-06-14 Thread Chad Rosier
On Jun 12, 2013, at 7:23 AM, Rafael Espíndola rafael.espind...@gmail.com wrote: [driver] Add support for the COMPILER_PATH environment variable, which adds the specified path(s) to the list of prefix directories. rdar://10097714 Sorry for the really late review, but why this

Re: [cfe-commits] r139677 - /cfe/trunk/lib/Driver/Driver.cpp

2013-06-14 Thread Chad Rosier
On Jun 14, 2013, at 10:01 AM, Rafael Espíndola rafael.espind...@gmail.com wrote: Sorry for the really late review, but why this environment variable instead of implementing the -B command line option? When Apple made the transition from llvm-gcc to clang I added this to be backward

r182659 - [ms-inline asm] Don't diagnose an empty lookup for inline assmebly. This happen

2013-05-24 Thread Chad Rosier
Author: mcrosier Date: Fri May 24 13:32:55 2013 New Revision: 182659 URL: http://llvm.org/viewvc/llvm-project?rev=182659view=rev Log: [ms-inline asm] Don't diagnose an empty lookup for inline assmebly. This happen for labels in inline assembly that aren't in the lookup tables. E.g., __asm {

Re: r180976 - Move parsing of identifiers in MS-style inline assembly into

2013-05-24 Thread Chad Rosier
Reid, I believe r182659 addresses the issue. John probably has a better long-term solution, but this should get you guys back to a working state. Chad On May 21, 2013, at 11:33 AM, Reid Kleckner r...@google.com wrote: Chad, is anyone actively working on this, or is this available to work

Re: r180976 - Move parsing of identifiers in MS-style inline assembly into

2013-05-21 Thread Chad Rosier
On May 21, 2013, at 11:33 AM, Reid Kleckner r...@google.com wrote: Chad, is anyone actively working on this, or is this available to work on? This breaks a bunch of stuff for us. Thanks for bringing this to my attention, Reid. I was on vacation last week, so this is the first I'm hearing

Re: r180874 - [inline asm] Add a test case for r180873. Test case needs to be on the clang

2013-05-07 Thread Chad Rosier
handler. Chad -eric On Wed, May 1, 2013 at 12:50 PM, Chad Rosier mcros...@apple.com wrote: Author: mcrosier Date: Wed May 1 14:50:45 2013 New Revision: 180874 URL: http://llvm.org/viewvc/llvm-project?rev=180874view=rev Log: [inline asm] Add a test case for r180873. Test case needs

Re: r180874 - [inline asm] Add a test case for r180873. Test case needs to be on the clang

2013-05-07 Thread Chad Rosier
handler will be in place, so we can report multiple errors and then exit, which is in fact the very fix in r180874. Hope that makes sense. Chad -eric On Tue, May 7, 2013 at 3:11 PM, Chad Rosier mcros...@apple.com wrote: On May 7, 2013, at 3:08 PM, Eric Christopher echri...@gmail.com wrote

  1   2   3   4   5   6   7   8   9   >