[PATCH] D25613: [clang-move] Don't overuse Replacements::add.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Awesome! Lg with one nit. Comment at: clang-move/ClangMove.cpp:197 clang::tooling::Replacement getReplacementInChangedCode(const clang::tooling::Replacements ,

[PATCH] D25613: [clang-move] Don't overuse Replacements::add.

hokein updated this revision to Diff 74677. hokein added a comment. Delete one more function. https://reviews.llvm.org/D25613 Files: clang-move/ClangMove.cpp Index: clang-move/ClangMove.cpp === --- clang-move/ClangMove.cpp +++

[PATCH] D25613: [clang-move] Don't overuse Replacements::add.

hokein updated this revision to Diff 74675. hokein added a comment. woohoo, delete more code! https://reviews.llvm.org/D25613 Files: clang-move/ClangMove.cpp Index: clang-move/ClangMove.cpp === --- clang-move/ClangMove.cpp +++

[PATCH] D25613: [clang-move] Don't overuse Replacements::add.

ioeric added inline comments. Comment at: clang-move/ClangMove.cpp:472 std::string FilePath = RemoveReplacement.getFilePath().str(); addOrMergeReplacement(RemoveReplacement, [FilePath]); For deletions, you can simply use `add`, which now simply

[PATCH] D25612: [clang-tidy] Add additional diagnostic to misc-use-after-move

This revision was automatically updated to reflect the committed changes. Closed by commit rL284235: [clang-tidy] Add additional diagnostic to misc-use-after-move (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D25612?vs=74671=74673#toc Repository: rL LLVM

[clang-tools-extra] r284235 - [clang-tidy] Add additional diagnostic to misc-use-after-move

Author: mboehme Date: Fri Oct 14 08:23:39 2016 New Revision: 284235 URL: http://llvm.org/viewvc/llvm-project?rev=284235=rev Log: [clang-tidy] Add additional diagnostic to misc-use-after-move Summary: This adds a diagnostic to the misc-use-after-move check that is output when the use happens on a

[PATCH] D25613: [clang-move] Don't overuse Replacements::add.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D25613 Files: clang-move/ClangMove.cpp Index: clang-move/ClangMove.cpp === ---

[PATCH] D25610: [clang-move] Add header guard for the new header.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284233: [clang-move] Add header guard for the new header. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D25610?vs=74663=74669#toc Repository: rL LLVM

[PATCH] D25612: [clang-tidy] Add additional diagnostic to misc-use-after-move

mboehme updated this revision to Diff 74671. mboehme added a comment. - Responses to reviewer comments https://reviews.llvm.org/D25612 Files: clang-tidy/misc/UseAfterMoveCheck.cpp test/clang-tidy/misc-use-after-move.cpp Index: test/clang-tidy/misc-use-after-move.cpp

[clang-tools-extra] r284233 - [clang-move] Add header guard for the new header.

Author: hokein Date: Fri Oct 14 08:01:36 2016 New Revision: 284233 URL: http://llvm.org/viewvc/llvm-project?rev=284233=rev Log: [clang-move] Add header guard for the new header. Summary: The header guard generated by clang-move isn't always a perfect style, just avoid getting the header included

[PATCH] D25600: [ASTMatcher] Add isStaticDataMember matcher for varDecl.

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3005 +/// \endcode +AST_MATCHER(VarDecl, isStaticDataMember) { + return Node.isStaticDataMember(); How does this differ from

[PATCH] D25468: [libcxx] Do not declare the thread api when __external_threading is present

This revision was automatically updated to reflect the committed changes. Closed by commit rL284232: [libcxx] Do not declare the thread api when __external_threading is present (authored by asiri). Changed prior to commit: https://reviews.llvm.org/D25468?vs=74234=74668#toc Repository: rL

[libcxx] r284232 - [libcxx] Do not declare the thread api when __external_threading is present

Author: asiri Date: Fri Oct 14 08:00:07 2016 New Revision: 284232 URL: http://llvm.org/viewvc/llvm-project?rev=284232=rev Log: [libcxx] Do not declare the thread api when __external_threading is present This fixes a small omission where even when __external_threading is provided, we attempt to

[PATCH] D25610: [clang-move] Add header guard for the new header.

hokein added inline comments. Comment at: clang-move/ClangMove.cpp:264 +HeaderGuard += "#define " + GuardName + "\n"; +clang::tooling::Replacement HeaderGuardInclude(FileName, 0, 0, + HeaderGuard); ioeric

[libcxx] r284230 - Disable Modules when building the libc++ sources.

Author: ericwf Date: Fri Oct 14 07:56:52 2016 New Revision: 284230 URL: http://llvm.org/viewvc/llvm-project?rev=284230=rev Log: Disable Modules when building the libc++ sources. Libc++ will not build with modules enabled. In order to support an in-tree libc++ when LLVM_ENABLE_MODULES is ON we

[PATCH] D25431: [libcxx] Convert Solaris support library to C++ to fix -std=c++11 build

mgorny retitled this revision from "[libcxx] [CMake] Build Solaris compat as separate C lib, to avoid -std= issues" to "[libcxx] Convert Solaris support library to C++ to fix -std=c++11 build ". mgorny updated the summary for this revision. mgorny updated this revision to Diff 74666. mgorny

[PATCH] D25612: [clang-tidy] Add additional diagnostic to misc-use-after-move

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The code looks good. Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:579 DiagnosticIDs::Note); + } else if(UseLoc < MoveLoc || Use.DeclRef == MoveArg) {

r284229 - Fix for PR30632: Name mangling issue.

Author: abataev Date: Fri Oct 14 07:43:59 2016 New Revision: 284229 URL: http://llvm.org/viewvc/llvm-project?rev=284229=rev Log: Fix for PR30632: Name mangling issue. There was a bug in the implementation of captured statements. If it has a lambda expression in it and the same lambda expression

[PATCH] D25612: [clang-tidy] Add additional diagnostic to misc-use-after-move

mboehme created this revision. mboehme added a reviewer: hokein. mboehme added a subscriber: cfe-commits. This adds a diagnostic to the misc-use-after-move check that is output when the use happens on a later loop iteration than the move, for example: A a; for (int i = 0; i < 10; ++i) {

[PATCH] D25610: [clang-move] Add header guard for the new header.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lg Comment at: clang-move/ClangMove.cpp:264 +HeaderGuard += "#define " + GuardName + "\n"; +clang::tooling::Replacement HeaderGuardInclude(FileName, 0, 0, +

[PATCH] D25431: [libcxx] [CMake] Build Solaris compat as separate C lib, to avoid -std= issues

mgorny added a comment. In https://reviews.llvm.org/D25431#570227, @EricWF wrote: > Why not just compile the sources files as C++ by changing their extensions? > This change seems all kinds of wrong because we're throwing away *all* of our > flags, including things like `-m32` or `-target `.

[PATCH] D25568: [libcxx] [cmake] Use -print-libgcc-file-name option to find compiler runtime

mgorny added a comment. In https://reviews.llvm.org/D25568#570222, @EricWF wrote: > This doesn't seem right seeing as `print-libgcc_file-name` prints the > `libgcc.a` path, and we were previously linking `libgcc_s`. Do you have any other solution in mind? There is no switch to print the

[PATCH] D25610: [clang-move] Add header guard for the new header.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. The header guard generated by clang-move isn't always a perfect style, just avoid getting the header included multiple times during compiling period. Also, we can use llvm-Header-guard

r284228 - Removed duplicate header include

Author: ioeric Date: Fri Oct 14 06:48:10 2016 New Revision: 284228 URL: http://llvm.org/viewvc/llvm-project?rev=284228=rev Log: Removed duplicate header include Reviewers: ioeric Subscribers: klimek Patch by Krasimir Georgiev! Differential Revision: https://reviews.llvm.org/D25599 Modified:

[PATCH] D23524: [libc++abi] Fix backtrace_test.pass.cpp failure seemingly caused by inlining differences.

EricWF abandoned this revision. EricWF added a comment. Another fix was committed. https://reviews.llvm.org/D23524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25608: [libclang] Make tests for python bindings pass on Windows.

ikudrin created this revision. ikudrin added reviewers: hansonw, compnerd, indygreg, eliben. ikudrin added a subscriber: cfe-commits. Please note that this patch fixes only Windows-related issues. https://reviews.llvm.org/D25470 is required to pass all the tests.

[PATCH] D25431: [libcxx] [CMake] Build Solaris compat as separate C lib, to avoid -std= issues

EricWF added a comment. Why not just compile the sources files as C++ by changing their extensions? This change seems all kinds of wrong because we're throwing away *all* of our flags, including things like `-m32` or `-target `. https://reviews.llvm.org/D25431

[PATCH] D25568: [libcxx] [cmake] Use -print-libgcc-file-name option to find compiler runtime

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. This doesn't seem right seeing as `print-libgcc_file-name` prints the `libgcc.a` path, and we were previously linking `libgcc_s`. https://reviews.llvm.org/D25568

r284222 - Try to fix windows bot file path style failure caused by r284219.

Author: ioeric Date: Fri Oct 14 05:10:26 2016 New Revision: 284222 URL: http://llvm.org/viewvc/llvm-project?rev=284222=rev Log: Try to fix windows bot file path style failure caused by r284219. Modified: cfe/trunk/unittests/Tooling/RefactoringTest.cpp Modified:

[PATCH] D25606: alpha.core.UnreachableCode - don't warn about unreachable code inside macro

danielmarjamaki created this revision. danielmarjamaki added reviewers: NoQ, dcoughlin. danielmarjamaki added subscribers: cfe-commits, xazax.hun, zaks.anna, a.sidorin. danielmarjamaki set the repository for this revision to rL LLVM. This patch fixes false positives for such code: #define

[clang-tools-extra] r284221 - [clang-move] Matching static class member more correctly.

Author: hokein Date: Fri Oct 14 05:07:58 2016 New Revision: 284221 URL: http://llvm.org/viewvc/llvm-project?rev=284221=rev Log: [clang-move] Matching static class member more correctly. Reviewers: ioeric Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D25598 Modified:

[PATCH] D25598: [clang-move] Matching static class member more correctly.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284221: [clang-move] Matching static class member more correctly. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D25598?vs=74633=74650#toc Repository: rL LLVM

[PATCH] D25593: [libcxx] Build with -fvisibility-inlines-hidden -- Remove 20 inline definitions from the dylib

EricWF added a comment. I just spoke with Jonathan Wakely about this change, and he believes that it should be ABI safe. https://reviews.llvm.org/D25593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25604: Add support for Mageia Linux

v.g.vassilev created this revision. v.g.vassilev added reviewers: chandlerc, rsmith. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D25604 Files: lib/Driver/ToolChains.cpp Index:

[PATCH] D25597: Try to fix buildbot failure in VirtualFileSystem caused by r284129.

bkramer added a comment. I think the assertion is correct, there's something fishy with the inputs. The paths coming in should be absolute, and there should never be a .. at the start in a absolute path. This only fails on a single buildbot and doesn't reproduce anywhere else. @bruno any

[PATCH] D25600: [ASTMatcher] Add isStaticDataMember matcher for varDecl.

hokein created this revision. hokein added a reviewer: klimek. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D25600 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp Index:

[PATCH] D23657: Remove some false positives when taking the address of packed members

rogfer01 updated this revision to Diff 74638. rogfer01 added a comment. Updated patch, now we check if the innermost base of a MemberExpr is a DeclRefExpr and check for its declaration in case it provides stronger alignment guarantees. https://reviews.llvm.org/D23657 Files:

[PATCH] D25598: [clang-move] Matching static class member more correctly.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D25598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r284219 - Deduplicate sets of replacements by file names.

Author: ioeric Date: Fri Oct 14 04:32:06 2016 New Revision: 284219 URL: http://llvm.org/viewvc/llvm-project?rev=284219=rev Log: Deduplicate sets of replacements by file names. Summary: If there are multiple pairs with the same file path after removing dots, we only keep one

[PATCH] D25565: Deduplicate sets of replacements by file names.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284219: Deduplicate sets of replacements by file names. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D25565?vs=74634=74636#toc Repository: rL LLVM

[PATCH] D25565: Deduplicate sets of replacements by file names.

ioeric updated this revision to Diff 74634. ioeric added a comment. - Merge branch 'master' of http://llvm.org/git/clang into arcpatch-D25565 - Forgot to update names in tests... https://reviews.llvm.org/D25565 Files: include/clang/Tooling/Core/Replacement.h

[PATCH] D25598: [clang-move] Matching static class member more correctly.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D25598 Files: clang-move/ClangMove.cpp test/clang-move/Inputs/test.cpp test/clang-move/Inputs/test.h test/clang-move/move-class.cpp Index:

[libcxxabi] r284217 - Mark test as unsupported without threads

Author: ericwf Date: Fri Oct 14 04:12:53 2016 New Revision: 284217 URL: http://llvm.org/viewvc/llvm-project?rev=284217=rev Log: Mark test as unsupported without threads Modified: libcxxabi/trunk/test/libcxxabi/test/config.py libcxxabi/trunk/test/thread_local_destruction_order.pass.cpp

[PATCH] D25565: Deduplicate sets of replacements by file names.

ioeric updated this revision to Diff 74632. ioeric added a comment. - Change name to groupReplacementsByFile https://reviews.llvm.org/D25565 Files: include/clang/Tooling/Core/Replacement.h include/clang/Tooling/Refactoring.h lib/Tooling/Core/Replacement.cpp lib/Tooling/Refactoring.cpp

[PATCH] D25597: Try to fix buildbot failure in VirtualFileSystem caused by r284129.

ioeric updated this revision to Diff 74631. ioeric added a comment. - Separate assertions to get more information. https://reviews.llvm.org/D25597 Files: lib/Basic/VirtualFileSystem.cpp Index: lib/Basic/VirtualFileSystem.cpp

[libcxx] r284216 - Remove dead CMake target

Author: ericwf Date: Fri Oct 14 04:06:38 2016 New Revision: 284216 URL: http://llvm.org/viewvc/llvm-project?rev=284216=rev Log: Remove dead CMake target Modified: libcxx/trunk/cmake/Modules/HandleLibCXXABI.cmake libcxx/trunk/lib/CMakeLists.txt Modified:

[PATCH] D25565: Deduplicate sets of replacements by file names.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. I'd not rename the function. Otherwise looks good. https://reviews.llvm.org/D25565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

rmaprath closed this revision. rmaprath added a comment. Committed as r284128. https://reviews.llvm.org/D24864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25597: Try to fix buildbot failure in VirtualFileSystem caused by r284129.

ioeric created this revision. ioeric added a reviewer: bkramer. ioeric added a subscriber: cfe-commits. Since `remove_dots` does not delete leading "../" anymore, assertion test need to be updated. https://reviews.llvm.org/D25597 Files: lib/Basic/VirtualFileSystem.cpp Index:

[PATCH] D25596: alpha.core.Conversion - Fix false positive for 'U32 += S16; ' expression, that is not unsafe

danielmarjamaki created this revision. danielmarjamaki added a reviewer: NoQ. danielmarjamaki added subscribers: cfe-commits, xazax.hun, dcoughlin. danielmarjamaki set the repository for this revision to rL LLVM. This patch fix false positives for loss of sign in addition and subtraction

[libcxx] r284214 - XFAIL aligned allocation tests for older Clang versions

Author: ericwf Date: Fri Oct 14 03:47:09 2016 New Revision: 284214 URL: http://llvm.org/viewvc/llvm-project?rev=284214=rev Log: XFAIL aligned allocation tests for older Clang versions Modified: libcxx/trunk/test/libcxx/test/config.py

[PATCH] D24958: Test linked to D24957

This revision was automatically updated to reflect the committed changes. Closed by commit rL284213: [x86][ms-inline-asm] use of "jmp short" in asm is not supported (authored by mzuckerm). Changed prior to commit: https://reviews.llvm.org/D24958?vs=72624=74626#toc Repository: rL LLVM

r284213 - [x86][ms-inline-asm] use of "jmp short" in asm is not supported

Author: mzuckerm Date: Fri Oct 14 03:13:27 2016 New Revision: 284213 URL: http://llvm.org/viewvc/llvm-project?rev=284213=rev Log: [x86][ms-inline-asm] use of "jmp short" in asm is not supported Test linked to: https://reviews.llvm.org/D24957 Committing in the name of Ziv Izhar: After check-all

[PATCH] D25586: [clang-move] Use cl::list and cl::CommaSeparated for the list of names.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rL LLVM https://reviews.llvm.org/D25586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25576: Add 64-bit MS _Interlocked functions as builtins again

mstorsjo added a comment. > (should they be also on AArch64? I had problems with testing it for AArch64, > so I left it) Technically, I think they should be on AArch64 as well. But clang/LLVM probably doesn't support AArch64/Windows yet (I guess?), so testing it probably is impossible.

[libcxx] r284209 - Add void_t and invoke feature test macros

Author: ericwf Date: Fri Oct 14 02:19:52 2016 New Revision: 284209 URL: http://llvm.org/viewvc/llvm-project?rev=284209=rev Log: Add void_t and invoke feature test macros Added: libcxx/trunk/test/std/utilities/function.objects/func.invoke/invoke_feature_test_macro.pass.cpp

[PATCH] D25595: [libcxx] Support std::regex_constants::match_not_null

timshen created this revision. timshen added reviewers: mclow.lists, EricWF. timshen added a subscriber: cfe-commits. Fixes PR21597. https://reviews.llvm.org/D25595 Files: libcxx/include/regex libcxx/test/std/re/re.alg/re.alg.search/pr21597.pass.cpp Index:

[libcxx] r284208 - Update OS X ABI list

Author: ericwf Date: Fri Oct 14 01:49:30 2016 New Revision: 284208 URL: http://llvm.org/viewvc/llvm-project?rev=284208=rev Log: Update OS X ABI list Modified: libcxx/trunk/lib/abi/x86_64-apple-darwin16.0.abilist Modified: libcxx/trunk/lib/abi/x86_64-apple-darwin16.0.abilist URL:

[libcxx] r284207 - Correct ABI changelog revision number

Author: ericwf Date: Fri Oct 14 01:47:37 2016 New Revision: 284207 URL: http://llvm.org/viewvc/llvm-project?rev=284207=rev Log: Correct ABI changelog revision number Modified: libcxx/trunk/lib/abi/CHANGELOG.TXT Modified: libcxx/trunk/lib/abi/CHANGELOG.TXT URL:

[libcxx] r284206 - Implement P0035R4 -- Add C++17 aligned allocation functions

Author: ericwf Date: Fri Oct 14 01:46:30 2016 New Revision: 284206 URL: http://llvm.org/viewvc/llvm-project?rev=284206=rev Log: Implement P0035R4 -- Add C++17 aligned allocation functions Summary: This patch implements the library side of P0035R4. The implementation is thanks to @rsmith. In

[PATCH] D25593: [libcxx] Build with -fvisibility-inlines-hidden -- Remove 20 inline definitions from the dylib

EricWF created this revision. EricWF added reviewers: mclow.lists, emaste, dexonsmith, joker-eph, compnerd, jroelofs, danalbert, dim. EricWF added a subscriber: cfe-commits. Herald added subscribers: modocache, mgorny, beanz. This patch turns on `-fvisibility-inlines-hidden` when building the

<    1   2