Re: [libcxx] r286789 - Add check-cxx-abilist target when supported.

> Eric, this part of this change seems wrong to me. It causes the headers to > be installed into the libcxx build directory instead of the LLVM one. If > you build using the LLVM runtimes directory this puts the headers in the > wrong place for clang to find them. > > Is there a reason you're

r289783 - CodeGen: force builtins to be local

Author: compnerd Date: Thu Dec 15 01:29:04 2016 New Revision: 289783 URL: http://llvm.org/viewvc/llvm-project?rev=289783=rev Log: CodeGen: force builtins to be local Unfortunately _setjmp3 can be both import or local. The ASAN tests try to emulate the flags which makes this harder to detect.

[libcxx] r289781 - Fix typo

Author: ericwf Date: Thu Dec 15 01:23:44 2016 New Revision: 289781 URL: http://llvm.org/viewvc/llvm-project?rev=289781=rev Log: Fix typo Modified: libcxx/trunk/test/std/utilities/utility/pairs/pairs.pair/dtor.pass.cpp Modified:

[libcxx] r289780 - Add tests for LWG 2796

Author: ericwf Date: Thu Dec 15 01:15:39 2016 New Revision: 289780 URL: http://llvm.org/viewvc/llvm-project?rev=289780=rev Log: Add tests for LWG 2796 Added: libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/dtor.pass.cpp

[libcxx] r289778 - Add more test cases for PR31384

Author: ericwf Date: Thu Dec 15 01:05:19 2016 New Revision: 289778 URL: http://llvm.org/viewvc/llvm-project?rev=289778=rev Log: Add more test cases for PR31384 Modified: libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/PR31384.pass.cpp Modified:

r289776 - CodeGen: fix runtime function dll storage

Author: compnerd Date: Thu Dec 15 00:59:05 2016 New Revision: 289776 URL: http://llvm.org/viewvc/llvm-project?rev=289776=rev Log: CodeGen: fix runtime function dll storage Properly attribute DLL storage to runtime functions. When generating the runtime function, scan for an existing declaration

[PATCH] D27786: [libcxx] [test] Strip trailing whitespace.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. You can commit whitespace and formatting changes w/o review. https://reviews.llvm.org/D27786 ___ cfe-commits mailing list

[libcxx] r289774 - Add test case for PR31384

Author: ericwf Date: Thu Dec 15 00:38:07 2016 New Revision: 289774 URL: http://llvm.org/viewvc/llvm-project?rev=289774=rev Log: Add test case for PR31384 Added: libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/PR31384.pass.cpp Added:

[libcxx] r289773 - Revert r289727 due to PR31384

Author: ericwf Date: Thu Dec 15 00:34:54 2016 New Revision: 289773 URL: http://llvm.org/viewvc/llvm-project?rev=289773=rev Log: Revert r289727 due to PR31384 This patch reverts the changes to tuple which fixed construction from types derived from tuple. It breaks the code mentioned in

[libcxx] r289767 - XFAIL test for more apple-clang versions

Author: ericwf Date: Wed Dec 14 23:41:07 2016 New Revision: 289767 URL: http://llvm.org/viewvc/llvm-project?rev=289767=rev Log: XFAIL test for more apple-clang versions Modified: libcxx/trunk/test/std/iterators/stream.iterators/istream.iterator/istream.iterator.cons/default.pass.cpp

[PATCH] D27796: Fix printf specifier handling: invalid specifier should not be marked as "consuming data arguments"

mehdi_amini created this revision. mehdi_amini added reviewers: rsmith, bruno, dexonsmith. mehdi_amini added a subscriber: cfe-commits. https://reviews.llvm.org/D27796 Files: clang/include/clang/Analysis/Analyses/FormatString.h clang/test/CodeGen/builtins.c clang/test/Sema/format-strings.c

r289763 - Revert "Fix printf specifier handling: invalid specifier should not be marked as "consuming data arguments""

Author: mehdi_amini Date: Wed Dec 14 22:58:51 2016 New Revision: 289763 URL: http://llvm.org/viewvc/llvm-project?rev=289763=rev Log: Revert "Fix printf specifier handling: invalid specifier should not be marked as "consuming data arguments"" This reverts commit r289762, wasn't ready to be

r289762 - Fix printf specifier handling: invalid specifier should not be marked as "consuming data arguments"

Author: mehdi_amini Date: Wed Dec 14 22:51:22 2016 New Revision: 289762 URL: http://llvm.org/viewvc/llvm-project?rev=289762=rev Log: Fix printf specifier handling: invalid specifier should not be marked as "consuming data arguments" Modified:

r289761 - Fix os_log formating with arbitrary precision and field width

Author: mehdi_amini Date: Wed Dec 14 22:02:31 2016 New Revision: 289761 URL: http://llvm.org/viewvc/llvm-project?rev=289761=rev Log: Fix os_log formating with arbitrary precision and field width Modified: cfe/trunk/lib/Analysis/OSLog.cpp cfe/trunk/test/CodeGen/builtins.c Modified:

r289754 - [c++1z] Permit constant evaluation of a call through a function pointer whose

Author: rsmith Date: Wed Dec 14 20:35:39 2016 New Revision: 289754 URL: http://llvm.org/viewvc/llvm-project?rev=289754=rev Log: [c++1z] Permit constant evaluation of a call through a function pointer whose type differs from the type of the actual function due to having a different exception

r289753 - Move checks for creation of objects of abstract class type from the various

Author: rsmith Date: Wed Dec 14 20:28:18 2016 New Revision: 289753 URL: http://llvm.org/viewvc/llvm-project?rev=289753=rev Log: Move checks for creation of objects of abstract class type from the various constructs that can do so into the initialization code. This fixes a number of different

r289752 - Include SmallSet.h in BackendUtil.cpp

Author: hfinkel Date: Wed Dec 14 20:19:17 2016 New Revision: 289752 URL: http://llvm.org/viewvc/llvm-project?rev=289752=rev Log: Include SmallSet.h in BackendUtil.cpp BackendUtil.cpp uses llvm::SmallSet but did not include the header. It was included indirectly, but this will change once the

[PATCH] D26267: [Modules] Include builtins with #include instead of #import for ObjC

rsmith added a comment. Other options: Do we need to perfectly preserve the functionality of `#pragma once` / `#import`? That is, would it be acceptable to you if we spuriously enter files that have been imported in that way, while building a module? If we view them as pure optimization, we

[PATCH] D27794: Make some diagnostic tests C++11 clean

probinson created this revision. probinson added a reviewer: rsmith. probinson added subscribers: cfe-commits, tigerleapgorge. Another half-dozen test revisions in the ongoing campaign to make things ready for C++11 as Clangs's default dialect. Most of these are straightforward, but I am not

[PATCH] D27788: [CUDA] Add --ptxas-path= flag.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added a subscriber: cfe-commits. This lets you build with one CUDA installation but use ptxas from another install. This is useful e.g. if you want to avoid bugs in an old ptxas without actually upgrading wholesale to a newer

[PATCH] D27786: [libcxx] [test] Strip trailing whitespace.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Strip trailing whitespace. https://reviews.llvm.org/D27786 Files: test/std/experimental/utilities/meta/meta.detect/detected_or.pass.cpp

[PATCH] D27785: [libcxx] [test] Fix recently introduced warnings emitted by MSVC.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix recently introduced warnings emitted by MSVC. test/std/utilities/allocator.adaptor/allocator.adaptor.members/construct_pair_const_lvalue_pair.pass.cpp

[PATCH] D26564: Use PIC relocation mode by default for PowerPC64 ELF

This revision was automatically updated to reflect the committed changes. Closed by commit rL289744: Use PIC relocation mode by default for PowerPC64 ELF (authored by joerg). Changed prior to commit: https://reviews.llvm.org/D26564?vs=77670=81495#toc Repository: rL LLVM

r289744 - Use PIC relocation mode by default for PowerPC64 ELF

Author: joerg Date: Wed Dec 14 18:02:57 2016 New Revision: 289744 URL: http://llvm.org/viewvc/llvm-project?rev=289744=rev Log: Use PIC relocation mode by default for PowerPC64 ELF Most of the PowerPC64 code generation already creates PIC access. This changes to a full PIC default, similar to

[libcxx] r289741 - Work around bug in initialization of std::array base class with older clangs

Author: ericwf Date: Wed Dec 14 17:24:12 2016 New Revision: 289741 URL: http://llvm.org/viewvc/llvm-project?rev=289741=rev Log: Work around bug in initialization of std::array base class with older clangs Modified:

[PATCH] D21298: [Clang-tidy] delete null check

Prazek added inline comments. Comment at: clang-tidy/readability/DeleteNullPointerCheck.cpp:33 + Finder->addMatcher( + ifStmt(allOf(hasCondition( + anyOf(PointerCondition, BinaryPointerCheckCondition)), I think allOf matcher is

[libcxx] r289735 - Fix PR31378 - std::list::remove should not require a default constructible allocator.

Author: ericwf Date: Wed Dec 14 16:48:38 2016 New Revision: 289735 URL: http://llvm.org/viewvc/llvm-project?rev=289735=rev Log: Fix PR31378 - std::list::remove should not require a default constructible allocator. In list::remove we collect the nodes we're removing in a seperate list instance.

[libcxx] r289734 - [libcxx] [test] Fix MSVC x64 truncation warnings with 32-bit allocator size_type/difference_type.

Author: stl_msft Date: Wed Dec 14 16:46:46 2016 New Revision: 289734 URL: http://llvm.org/viewvc/llvm-project?rev=289734=rev Log: [libcxx] [test] Fix MSVC x64 truncation warnings with 32-bit allocator size_type/difference_type.

[PATCH] D27740: [analyzer] Include type name in Retain Count Checker diagnostics

zaks.anna updated this revision to Diff 81482. zaks.anna added a comment. Address Devin's comment regarding 'id'. https://reviews.llvm.org/D27740 Files: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp test/Analysis/edges-new.mm test/Analysis/inlining/path-notes.m

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

Prazek accepted this revision. Prazek added a comment. This revision is now accepted and ready to land. LGTM, thanks for all the fixes. Can you leave FIXIT comment somewhere in the code near the FixitHint about the function pointers? https://reviews.llvm.org/D27166

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Looks good to me, other than some super tiny nits! Thanks for iterating on this -- it is awesome that the analyzer will be able to model this now!! Comment at:

[PATCH] D26267: [Modules] Include builtins with #include instead of #import for ObjC

bruno updated this revision to Diff 81478. bruno added a comment. Here is the Decl dump in the end of `ReadDeclRecord` for each Decl before it fails: - ParmVarDecl 0x7ffe23053b20 col:12 in libc.math hidden 'int' -- FunctionDecl 0x7ffe23053a48 col:5 in libc.math hidden abs 'int (int)'

[PATCH] D27606: [libcxx] Fix tuple construction/assignment from types derived from tuple/pair/array.

This revision was automatically updated to reflect the committed changes. Closed by commit rL289727: [libcxx] Fix tuple construction/assignment from types derived from… (authored by EricWF). Changed prior to commit: https://reviews.llvm.org/D27606?vs=81456=81476#toc Repository: rL LLVM

[libcxx] r289727 - [libcxx] Fix tuple construction/assignment from types derived from tuple/pair/array.

Author: ericwf Date: Wed Dec 14 16:22:38 2016 New Revision: 289727 URL: http://llvm.org/viewvc/llvm-project?rev=289727=rev Log: [libcxx] Fix tuple construction/assignment from types derived from tuple/pair/array. Summary: The standard requires tuple have the following constructors: ```

[PATCH] D27606: [libcxx] Fix tuple construction/assignment from types derived from tuple/pair/array.

EricWF accepted this revision. EricWF added a reviewer: EricWF. EricWF added a comment. Accepting revision. @mpark mentioned that this was good to go offline. Ignore the inline comment about `base.operator=`, phab won't let me delete it. Comment at: include/tuple:884

[PATCH] D26167: [Clang-tidy] check for malloc, realloc and free calls

malcolm.parsons added a comment. In https://reviews.llvm.org/D26167#621942, @JonasToth wrote: > what do you think about configuration of the allocating functions? e.g. for > aligned memory you must use OS-specific allocation functions. > should the check catch custom allocation functions as

[PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

yaxunl updated this revision to Diff 81471. yaxunl marked 2 inline comments as done. yaxunl added a comment. Added serialisation of types and declarations associated with extensions. Brought the patch up to date. https://reviews.llvm.org/D21698 Files:

[PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

yaxunl marked 6 inline comments as done. yaxunl added inline comments. Comment at: lib/Serialization/ASTReader.cpp:3167 case OPENCL_EXTENSIONS: - // Later tables overwrite earlier ones. - OpenCLExtensions.swap(Record); Anastasia wrote: > Btw,

[PATCH] D27777: [libcxx] [test] Fix MSVC x64 truncation warnings with 32-bit allocator size_type/difference_type.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC x64 truncation warnings with 32-bit allocator size_type/difference_type.

[PATCH] D27270: [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 4/4.

STL_MSFT abandoned this revision. STL_MSFT added a comment. Abandoning; I have changes in our STL to fix the bulk of these warnings, plus a small number of test changes that I'm about to send out. https://reviews.llvm.org/D27270 ___ cfe-commits

[PATCH] D27740: [analyzer] Include type name in Retain Count Checker diagnostics

dcoughlin added inline comments. Comment at: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp:2000 +if (Sym->getType().isNull()) { + os << " returns an Objective-C object with a "; +} else { I think we should use this diagnostic text

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

malcolm.parsons updated this revision to Diff 81465. malcolm.parsons added a comment. Add tests for implicit vars and pointers to pointers to auto. https://reviews.llvm.org/D27166 Files: clang-tidy/modernize/UseAutoCheck.cpp docs/ReleaseNotes.rst

[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

dcoughlin created this revision. dcoughlin added reviewers: zaks.anna, NoQ. dcoughlin added subscribers: cfe-commits, alexfh, sbenza. Herald added a subscriber: mgorny. gtest is a widely-used unit-testing API provides macros for unit test assertions: ASSERT_TRUE(p != nullptr); that expand

[libcxx] r289716 - XFAIL test on apple-clang-7.0

Author: ericwf Date: Wed Dec 14 15:44:08 2016 New Revision: 289716 URL: http://llvm.org/viewvc/llvm-project?rev=289716=rev Log: XFAIL test on apple-clang-7.0 Modified: libcxx/trunk/test/std/iterators/stream.iterators/istream.iterator/istream.iterator.cons/default.pass.cpp Modified:

r289715 - Create SampleProfileLoader pass in llvm instead of clang

Author: dehao Date: Wed Dec 14 15:41:04 2016 New Revision: 289715 URL: http://llvm.org/viewvc/llvm-project?rev=289715=rev Log: Create SampleProfileLoader pass in llvm instead of clang Summary: We used to create SampleProfileLoader pass in clang. This makes LTO/ThinLTO unable to add this pass in

r289713 - Revert 289252 (and follow-up 289285), it caused PR31374

Author: nico Date: Wed Dec 14 15:38:18 2016 New Revision: 289713 URL: http://llvm.org/viewvc/llvm-project?rev=289713=rev Log: Revert 289252 (and follow-up 289285), it caused PR31374 Removed: cfe/trunk/test/CodeGenOpenCL/amdgpu-nullptr.cl Modified: cfe/trunk/include/clang/AST/APValue.h

r289712 - Update MSVC compat docs about debug info

Author: nico Date: Wed Dec 14 15:34:19 2016 New Revision: 289712 URL: http://llvm.org/viewvc/llvm-project?rev=289712=rev Log: Update MSVC compat docs about debug info https://reviews.llvm.org/D27769 Modified: cfe/trunk/docs/MSVCCompatibility.rst Modified:

[libcxx] r289710 - [libcxx] Fix PR24075, PR23841 - Add scoped_allocator_adaptor::construct(pair<T, U>*, ...) overloads.

Author: ericwf Date: Wed Dec 14 15:29:29 2016 New Revision: 289710 URL: http://llvm.org/viewvc/llvm-project?rev=289710=rev Log: [libcxx] Fix PR24075, PR23841 - Add scoped_allocator_adaptor::construct(pair*, ...) overloads. Summary: For more information see: *

[PATCH] D21298: [Clang-tidy] delete null check

SilverGeri updated this revision to Diff 81458. https://reviews.llvm.org/D21298 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/DeleteNullPointerCheck.cpp clang-tidy/readability/DeleteNullPointerCheck.h clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D27744: Create SampleProfileLoader pass in llvm instead of clang

danielcdh reopened this revision. danielcdh added a comment. This revision is now accepted and ready to land. was reverted due to bot breaking https://reviews.llvm.org/D27744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27612: [libcxx] Fix PR24075, PR23841 - Add scoped_allocator_adaptor::construct(pair<T, U>*, ...) overloads.

EricWF accepted this revision. EricWF added a reviewer: EricWF. EricWF added a comment. This revision is now accepted and ready to land. Accepting for post-commit review. Comment at: include/scoped_allocator:644 +{ +using _Tup = tuple<_Args&&...,

[libcxx] r289708 - Recommit r286884: P0503R0, adopted in Issaquah, rewords some requirements on nullptr_t and istream_iterator.

Author: ericwf Date: Wed Dec 14 15:22:48 2016 New Revision: 289708 URL: http://llvm.org/viewvc/llvm-project?rev=289708=rev Log: Recommit r286884: P0503R0, adopted in Issaquah, rewords some requirements on nullptr_t and istream_iterator. No code changes were needed, but I updated a few tests.

[PATCH] D27606: [libcxx] Fix tuple construction/assignment from types derived from tuple/pair/array.

EricWF updated this revision to Diff 81456. EricWF marked 4 inline comments as done. EricWF added a comment. Address review comments. @mpark any other concerns/comments? https://reviews.llvm.org/D27606 Files: include/__tuple include/tuple include/type_traits

Regression caused by r276159 - [modules] Don't emit initializers for VarDecls within a module eagerly whenever

> On Jul 20, 2016, at 12:10 PM, Richard Smith via cfe-commits > wrote: > > Author: rsmith > Date: Wed Jul 20 14:10:16 2016 > New Revision: 276159 > > URL: http://llvm.org/viewvc/llvm-project?rev=276159=rev > Log: > [modules] Don't emit initializers for VarDecls

[PATCH] D21298: [Clang-tidy] delete null check

SilverGeri updated this revision to Diff 81452. SilverGeri added a comment. remove unused string using early exit in condition shorten check-message lines add check-fisex to 'else' part https://reviews.llvm.org/D21298 Files: clang-tidy/readability/CMakeLists.txt

[PATCH] D27769: Update MSVC compat docs about debug info.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Thanks! Comment at: docs/MSVCCompatibility.rst:77 + debug information if ``/Z7`` or ``/Zi`` is passed. Microsoft's link.exe will + transform the CodeView debug information into

[PATCH] D27769: Update MSVC compat docs about debug info.

thakis updated this revision to Diff 81448. thakis added a comment. reword slightly https://reviews.llvm.org/D27769 Files: docs/MSVCCompatibility.rst Index: docs/MSVCCompatibility.rst === --- docs/MSVCCompatibility.rst +++

[PATCH] D27769: Update MSVC compat docs about debug info.

thakis added inline comments. Comment at: docs/MSVCCompatibility.rst:77 + debug information if ``/Z7`` or ``/Zi`` is passed. Microsoft's link.exe will + transform the CodeView debug information into a PDB that works in modern + Windows debuggers and tools like ETW. Work to

[PATCH] D27769: Update MSVC compat docs about debug info.

rnk added inline comments. Comment at: docs/MSVCCompatibility.rst:77 + debug information if ``/Z7`` or ``/Zi`` is passed. Microsoft's link.exe will + transform the CodeView debug information into a PDB that works in modern + Windows debuggers and tools like ETW. Work to

[PATCH] D27769: Update MSVC compat docs about debug info.

thakis updated this revision to Diff 81443. thakis added a comment. no dwarf or gcc mode https://reviews.llvm.org/D27769 Files: docs/MSVCCompatibility.rst Index: docs/MSVCCompatibility.rst === --- docs/MSVCCompatibility.rst

[PATCH] D27769: Update MSVC compat docs about debug info.

thakis added inline comments. Comment at: docs/MSVCCompatibility.rst:80 + Windows debuggers and tools like ETW. + There is no way to request DWARF debug info in clang-cl mode, so linking + with either binutils' ld or LLVM's lld won't produce debug info. Work to

[PATCH] D27763: Debug Info: Modified DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. (Clang part)

This revision was automatically updated to reflect the committed changes. Closed by commit rL289701: [DebugInfo] Changed DIBuilder::createCompileUnit() to take DIFile instead of… (authored by aaboud). Changed prior to commit: https://reviews.llvm.org/D27763?vs=81397=81438#toc Repository: rL

[PATCH] D27769: Update MSVC compat docs about debug info.

rnk added inline comments. Comment at: docs/MSVCCompatibility.rst:80 + Windows debuggers and tools like ETW. + There is no way to request DWARF debug info in clang-cl mode, so linking + with either binutils' ld or LLVM's lld won't produce debug info. Work to

[PATCH] D27769: Update MSVC compat docs about debug info.

thakis added inline comments. Comment at: docs/MSVCCompatibility.rst:80 + Windows debuggers and tools like ETW. + There is no way to request DWARF debug info in clang-cl mode, so linking + with either binutils' ld or LLVM's lld won't produce debug info. Work to

r289701 - [DebugInfo] Changed DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory.

Author: aaboud Date: Wed Dec 14 14:24:40 2016 New Revision: 289701 URL: http://llvm.org/viewvc/llvm-project?rev=289701=rev Log: [DebugInfo] Changed DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. This way it will be easier to expand DIFile (e.g., to contain

[PATCH] D27769: Update MSVC compat docs about debug info.

thakis created this revision. thakis added a reviewer: rnk. thakis added a subscriber: cfe-commits. https://reviews.llvm.org/D27769 Files: docs/MSVCCompatibility.rst Index: docs/MSVCCompatibility.rst === ---

Re: r289698 - Remove unused variable found by GCC warning.

If you spell it `/*IsWritten=*/foo`, then clang-format will know to not insert a space after the comment. On Wed, Dec 14, 2016 at 2:45 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Wed Dec 14 13:45:03 2016 > New Revision: 289698 > > URL:

r289698 - Remove unused variable found by GCC warning.

Author: rsmith Date: Wed Dec 14 13:45:03 2016 New Revision: 289698 URL: http://llvm.org/viewvc/llvm-project?rev=289698=rev Log: Remove unused variable found by GCC warning. Modified: cfe/trunk/lib/Serialization/ASTReader.cpp Modified: cfe/trunk/lib/Serialization/ASTReader.cpp URL:

[PATCH] D27740: [analyzer] Include type name in Retain Count Checker diagnostics

zaks.anna updated this revision to Diff 81429. zaks.anna added a comment. Devin did not like the '*' in the diagnostic for ObjC objects, so remove the '*'. https://reviews.llvm.org/D27740 Files: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp test/Analysis/edges-new.mm

r289692 - AArch64: add architecture version feature to Clang invocation.

Author: tnorthover Date: Wed Dec 14 13:21:30 2016 New Revision: 289692 URL: http://llvm.org/viewvc/llvm-project?rev=289692=rev Log: AArch64: add architecture version feature to Clang invocation. Otherwise we don't get the correct predefines and so on in the front-end (or the right features in

[PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

This revision was automatically updated to reflect the committed changes. Closed by commit rL289689: Prepare PrettyStackTrace for LLDB adoption (authored by spyffe). Changed prior to commit: https://reviews.llvm.org/D27683?vs=81304=81426#toc Repository: rL LLVM

[PATCH] D27597: [DebugInfo] Restore test case for long double constants.

This revision was automatically updated to reflect the committed changes. Closed by commit rL289686: [DebugInfo] Restore test case for long double constants. (authored by dgross). Changed prior to commit: https://reviews.llvm.org/D27597?vs=81321=81423#toc Repository: rL LLVM

r289686 - [DebugInfo] Restore test case for long double constants.

Author: dgross Date: Wed Dec 14 12:52:33 2016 New Revision: 289686 URL: http://llvm.org/viewvc/llvm-project?rev=289686=rev Log: [DebugInfo] Restore test case for long double constants. Summary: D27549 (partial fix for PR26619) emits a constant value in the debug metadata for a floating-point

r289685 - [Driver] Add tests for enabled static analyzer checkers.

Author: dcoughlin Date: Wed Dec 14 12:46:01 2016 New Revision: 289685 URL: http://llvm.org/viewvc/llvm-project?rev=289685=rev Log: [Driver] Add tests for enabled static analyzer checkers. The driver passes flags to cc1 that enable various checkers based on the target triple. This commit adds

[PATCH] D27673: [clang-move] Only move used helper declarations.

hokein added inline comments. Comment at: clang-move/ClangMove.cpp:492 + isDefinition(), unless(InMovedClass), InOldCC, + anyOf(isStaticStorageClass(), hasParent(namespaceDecl(isAnonymous(); + auto HelperFuncOrVar =

[PATCH] D27673: [clang-move] Only move used helper declarations.

hokein updated this revision to Diff 81413. hokein marked 18 inline comments as done. hokein added a comment. - Address review comments. - Add more test cases. https://reviews.llvm.org/D27673 Files: clang-move/CMakeLists.txt clang-move/ClangMove.cpp clang-move/ClangMove.h

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

Eugene.Zelenko added a comment. I think will be good idea to extend check for class members. Comment at: test/clang-tidy/readability-one-name-per-declaration-modern.cpp:13 + public: +vector() {} +vector(initializer_list init) {} Please use

r289678 - Improve our handling of tag decls in function prototypes

Author: rnk Date: Wed Dec 14 11:44:11 2016 New Revision: 289678 URL: http://llvm.org/viewvc/llvm-project?rev=289678=rev Log: Improve our handling of tag decls in function prototypes r289225 broke AST invariants by reparenting enumerators into function decl contexts. This improves things by only

r289675 - revert r289670 which breaks bot.

Author: dehao Date: Wed Dec 14 11:22:53 2016 New Revision: 289675 URL: http://llvm.org/viewvc/llvm-project?rev=289675=rev Log: revert r289670 which breaks bot. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp URL:

[PATCH] D27758: [change-namespace] don't crash when type reference is in function type parameter list.

This revision was automatically updated to reflect the committed changes. Closed by commit rL289672: [change-namespace] don't crash when type reference is in function type… (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D27758?vs=81388=81400#toc Repository: rL LLVM

[clang-tools-extra] r289672 - [change-namespace] don't crash when type reference is in function type parameter list.

Author: ioeric Date: Wed Dec 14 11:01:52 2016 New Revision: 289672 URL: http://llvm.org/viewvc/llvm-project?rev=289672=rev Log: [change-namespace] don't crash when type reference is in function type parameter list. Reviewers: hokein Subscribers: cfe-commits Differential Revision:

[PATCH] D27763: Debug Info: Modified DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. (Clang part)

aaboud created this revision. aaboud added a reviewer: rnk. aaboud added a subscriber: cfe-commits. Changed DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. This way it will be easier to expand DIFile (e.g., to contain checksum) without the need to modify the

[PATCH] D27758: [change-namespace] don't crash when type reference is in function type parameter list.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D27758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r289670 - Create SampleProfileLoader pass in llvm instead of clang

Author: dehao Date: Wed Dec 14 10:49:34 2016 New Revision: 289670 URL: http://llvm.org/viewvc/llvm-project?rev=289670=rev Log: Create SampleProfileLoader pass in llvm instead of clang Summary: We used to create SampleProfileLoader pass in clang. This makes LTO/ThinLTO unable to add this pass in

[PATCH] D27700: [clang-tidy] refactor ExprSequence out of misc-use-after-move check

mboehme accepted this revision. mboehme added a comment. This revision is now accepted and ready to land. LG apart from minor comments by others and me Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:18 using namespace clang::ast_matchers; +using namespace

[PATCH] D27758: [change-namespace] don't crash when type reference is in function type parameter list.

ioeric created this revision. ioeric added a reviewer: hokein. ioeric added a subscriber: cfe-commits. https://reviews.llvm.org/D27758 Files: change-namespace/ChangeNamespace.cpp test/change-namespace/lambda-function.cpp Index: test/change-namespace/lambda-function.cpp

[PATCH] D27754: [clang-format] Implement comment reflowing (again).

klimek added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1174-1175 LineIndex != EndIndex; ++LineIndex) { -if (!DryRun) - Token->replaceWhitespaceBefore(LineIndex, Whitespaces); +Token->replaceWhitespaceBefore(LineIndex,

r289660 - Update the default of the Mozilla coding style

Author: sylvestre Date: Wed Dec 14 10:09:29 2016 New Revision: 289660 URL: http://llvm.org/viewvc/llvm-project?rev=289660=rev Log: Update the default of the Mozilla coding style Summary: I also proposed the change in Firefox .clang-format file:

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

malcolm.parsons added a comment. In https://reviews.llvm.org/D27166#622127, @Prazek wrote: > In https://reviews.llvm.org/D27166#622108, @malcolm.parsons wrote: > > > In https://reviews.llvm.org/D27166#622103, @Prazek wrote: > > > > > There is also problem with function pointers > > > > > > The

[clang-tools-extra] r289658 - Deleted unused typedef

Author: prazek Date: Wed Dec 14 09:42:23 2016 New Revision: 289658 URL: http://llvm.org/viewvc/llvm-project?rev=289658=rev Log: Deleted unused typedef Modified: clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp Modified: clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp

r289657 - Fix assert message. NFC.

Author: kli Date: Wed Dec 14 09:39:58 2016 New Revision: 289657 URL: http://llvm.org/viewvc/llvm-project?rev=289657=rev Log: Fix assert message. NFC. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp URL:

[PATCH] D27754: [clang-format] Implement comment reflowing (again).

krasimir added inline comments. Comment at: lib/Format/BreakableToken.cpp:471 + WhitespaceManager ) { + if (Tok.is(TT_LineComment)) { +// If this is the first line of a token, inform Whitespace Manager about it.

[clang-tools-extra] r289656 - modernize-use-auto NFC fixes

Author: prazek Date: Wed Dec 14 09:29:23 2016 New Revision: 289656 URL: http://llvm.org/viewvc/llvm-project?rev=289656=rev Log: modernize-use-auto NFC fixes Modified: clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

Prazek added a comment. In https://reviews.llvm.org/D27166#622108, @malcolm.parsons wrote: > In https://reviews.llvm.org/D27166#622103, @Prazek wrote: > > > There is still one more problem: > > > > /home/prazek/llvm/lib/Analysis/ScalarEvolution.cpp:2442:11: warning: use > > auto when

[PATCH] D27123: Add AVR target and toolchain to Clang

jroelofs added a comment. In https://reviews.llvm.org/D27123#617118, @jroelofs wrote: > In https://reviews.llvm.org/D27123#616887, @saaadhu wrote: > > > Make defines for CHAR16_TYPE, {U,}INT_{LEAST,FAST}16_TYPE use int instead > > of short. > > > > {U,}INT16_TYPE still gets defined as short

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

malcolm.parsons updated this revision to Diff 81377. malcolm.parsons added a comment. Use qualType(hasDescendant(autoType())) to fix skipping of declarations that are already using auto. https://reviews.llvm.org/D27166 Files: clang-tidy/modernize/UseAutoCheck.cpp docs/ReleaseNotes.rst

[PATCH] D27744: Create SampleProfileLoader pass in llvm instead of clang

dnovillo accepted this revision. dnovillo added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D27744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

malcolm.parsons added a comment. In https://reviews.llvm.org/D27166#622103, @Prazek wrote: > There is still one more problem: > > /home/prazek/llvm/lib/Analysis/ScalarEvolution.cpp:2442:11: warning: use > auto when initializing with a template cast to avoid duplicating the type > name

[PATCH] D27754: [clang-format] Implement comment reflowing (again).

klimek added inline comments. Comment at: lib/Format/BreakableToken.cpp:471 + WhitespaceManager ) { + if (Tok.is(TT_LineComment)) { +// If this is the first line of a token, inform Whitespace Manager about it.

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

Prazek added a comment. There is still one more problem: /home/prazek/llvm/lib/Analysis/ScalarEvolution.cpp:2442:11: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto] const auto **O = SCEVAllocator.Allocate(Ops.size());

  1   2   >