[PATCH] D28889: Change where we handle arg-dependent diagnose_if attributes

george.burgess.iv created this revision. As it turns out, emitting diagnostics from places where you're not meant to emit them from is a very bad idea. :) After some looking around, it seems that it's less insane to check for `diagnose_if` attributes in code that's already checking for e.g.

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda added a comment. Thanks for all the feedback. I've tried to address all your comments, and reworked the documentation. Please let me know if I missed or misunderstood anything. https://reviews.llvm.org/D20693 ___ cfe-commits mailing

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda updated this revision to Diff 84926. hintonda marked 22 inline comments as done. hintonda added a comment. - Add support for matching MemberPointerType's. - Add noexcept(false) option plus test; allow invalid replacement ranges; enhance diagnostics. - Updated docs.

Re: [PATCH] D28467: [Sema] Add warning for unused lambda captures

On Jan 18, 2017 7:34 PM, "Akira Hatanaka via Phabricator" < revi...@reviews.llvm.org> wrote: ahatanak added a comment. In https://reviews.llvm.org/D28467#649861, @krasin wrote: > This change makes Clang hardly incompatible with MSVC++. Consider the following program: > > #include > > int

[PATCH] D28849: [compiler-rt] [test] Fix page address logic in clear_cache_test to use binary negation

compnerd added a comment. I wonder if we should take this a bit further. Use something like a `PAGE_SIZE` constant to avoid this confusion entirely. Furthremore, different targets could use different page sizes. IIRC, SPARC has a 8K page size by default. Repository: rL LLVM

[PATCH] D28785: Split exception.cpp and new.cpp implementation into different files for different runtimes

compnerd added a comment. While I love this direction (the original version really was an unintelligible pile of code), I really think that this change may be taking on too much. Why not split it up first and do nothing else. We could do the MS ABI implementation in a subsequent change.

[PATCH] D28862: [compiler-rt] [test] Use approximate comparison on float types

compnerd added a comment. I think that the checks should be exact. Instead, we should check the compilation mode and change the exact value (i.e. if we are using i387 mode, we would use the adjusted value). Repository: rL LLVM https://reviews.llvm.org/D28862

Re: r291955 - PR31606: Generalize our tentative DR resolution for inheriting copy/move

Merged in r292463. Cheers, Hans On Tue, Jan 17, 2017 at 9:25 PM, Richard Smith wrote: > Yes, let's. > > On 17 Jan 2017 9:11 pm, "Hans Wennborg" wrote: > > What do you think; time to merge it? > > On Fri, Jan 13, 2017 at 1:21 PM, Richard Smith

r292458 - Add -fdebug-info-for-profiling to emit more debug info for sample pgo profile collection

Author: dehao Date: Wed Jan 18 18:44:21 2017 New Revision: 292458 URL: http://llvm.org/viewvc/llvm-project?rev=292458=rev Log: Add -fdebug-info-for-profiling to emit more debug info for sample pgo profile collection Summary: SamplePGO uses profile with debug info to collect profile. Unlike the

[PATCH] D28467: [Sema] Add warning for unused lambda captures

ahatanak added a comment. In https://reviews.llvm.org/D28467#649861, @krasin wrote: > This change makes Clang hardly incompatible with MSVC++. Consider the > following program: > > #include > > int main(void) { > const int kDelta = 1001; > auto g = [kDelta](int i) >

[PATCH] D28785: Split exception.cpp and new.cpp implementation into different files for different runtimes

smeenai added a comment. @EricWF and I discussed this on IRC a bunch yesterday. We were inadvertently statically linking the Microsoft C++ libraries into tests, which is why `std::set_new_handler` was working with this patch. With that incorrect link removed, we get an undefined reference to

[PATCH] D25435: Add -fdebug-info-for-profiling to emit more debug info for sample pgo profile collection

echristo accepted this revision. echristo added a comment. Thanks for explaining all of this and going through it Dehao. LGTM. -eric https://reviews.llvm.org/D25435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28843: IRGen: Start using the WriteThinLTOBitcode pass.

pcc updated this revision to Diff 84907. pcc added a comment. Herald added a subscriber: mgorny. - Add missing test dependency https://reviews.llvm.org/D28843 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CMakeLists.txt clang/test/CodeGenCXX/type-metadata-thinlto.cpp Index:

r292450 - Add llvm-dis dependency to check-clang.

Author: pcc Date: Wed Jan 18 18:04:44 2017 New Revision: 292450 URL: http://llvm.org/viewvc/llvm-project?rev=292450=rev Log: Add llvm-dis dependency to check-clang. Modified: cfe/trunk/test/CMakeLists.txt Modified: cfe/trunk/test/CMakeLists.txt URL:

[PATCH] D28843: IRGen: Start using the WriteThinLTOBitcode pass.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D28843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r292448 - Move vtable type metadata emission behind a cc1-level flag.

Author: pcc Date: Wed Jan 18 17:55:27 2017 New Revision: 292448 URL: http://llvm.org/viewvc/llvm-project?rev=292448=rev Log: Move vtable type metadata emission behind a cc1-level flag. In ThinLTO mode, type metadata will require the module to be written as a multi-module bitcode file, which is

[PATCH] D28843: IRGen: Start using the WriteThinLTOBitcode pass.

pcc updated this revision to Diff 84903. pcc added a comment. Refresh https://reviews.llvm.org/D28843 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGenCXX/type-metadata-thinlto.cpp Index: clang/test/CodeGenCXX/type-metadata-thinlto.cpp

[PATCH] D28877: Move vtable type metadata emission behind a cc1-level flag.

This revision was automatically updated to reflect the committed changes. Closed by commit rL292448: Move vtable type metadata emission behind a cc1-level flag. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D28877?vs=84900=84902#toc Repository: rL LLVM

[PATCH] D28877: Move vtable type metadata emission behind a cc1-level flag.

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D28877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28843: IRGen: Start using the WriteThinLTOBitcode pass.

pcc added inline comments. Comment at: clang/test/CodeGenCXX/type-metadata-thinlto.cpp:2 +// RUN: %clang_cc1 -flto=thin -triple x86_64-unknown-linux -fvisibility hidden -emit-llvm-bc -o %t %s +// RUN: llvm-modextract -o - -n 1 %t | llvm-dis | FileCheck %s +

[PATCH] D28877: Move vtable type metadata emission behind a cc1-level flag.

pcc created this revision. In ThinLTO mode, type metadata will require the module to be written as a multi-module bitcode file, which is currently incompatible with the Darwin linker. It is also useful to be able to enable or disable multi-module bitcode for testing purposes. This introduces a

[PATCH] D28467: [Sema] Add warning for unused lambda captures

malcolm.parsons added a comment. MSVC's behaviour is discussed here: https://social.msdn.microsoft.com/Forums/SqlServer/en-US/4abf18bd-4ae4-4c72-ba3e-3b13e7909d5f/error-c2057-or-c3493-trying-to-use-an-integral-constant-expression-inside-a-lambda?forum=vclanguage and here:

[libcxx] r292443 - [libcxx] [test] Add msvc_stdlib_force_include.hpp.

Author: stl_msft Date: Wed Jan 18 16:19:14 2017 New Revision: 292443 URL: http://llvm.org/viewvc/llvm-project?rev=292443=rev Log: [libcxx] [test] Add msvc_stdlib_force_include.hpp. No functional change; nothing includes this, instead our test harness injects it via the /FI compiler option. No

[PATCH] D28867: [Profile] Warn about out-of-date profiles only when there are mismatches

mehdi_amini added a comment. In https://reviews.llvm.org/D28867#649760, @vsk wrote: > Ah ok, so it sounds like a better approach would be to split the missing > record message into a separate off-by-default warning. I'm in favor of this. https://reviews.llvm.org/D28867

[PATCH] D28467: [Sema] Add warning for unused lambda captures

krasin added a comment. This change makes Clang hardly incompatible with MSVC++. Consider the following program: #include int main(void) { const int kDelta = 1001; auto g = [kDelta](int i) { printf("%d\n", i % kDelta); }; g(2);

[PATCH] D28843: IRGen: Start using the WriteThinLTOBitcode pass.

tejohnson added inline comments. Comment at: clang/test/CodeGenCXX/type-metadata-thinlto.cpp:2 +// RUN: %clang_cc1 -flto=thin -triple x86_64-unknown-linux -fvisibility hidden -emit-llvm-bc -o %t %s +// RUN: llvm-modextract -o - -n 1 %t | llvm-dis | FileCheck %s +

[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

manmanren added a comment. Ping :] Hoping to wrap this up this week. Cheers, Manman https://reviews.llvm.org/D28299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27689: Module: hash the pcm content and use it as SIGNATURE for implicit modules.

manmanren marked an inline comment as done. manmanren added a comment. Ping :] I am hoping to wrap this up this week. Thanks, Manman https://reviews.llvm.org/D27689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28843: IRGen: Start using the WriteThinLTOBitcode pass.

mehdi_amini added inline comments. Comment at: clang/test/CodeGenCXX/type-metadata-thinlto.cpp:2 +// RUN: %clang_cc1 -flto=thin -triple x86_64-unknown-linux -fvisibility hidden -emit-llvm-bc -o %t %s +// RUN: llvm-modextract -o - -n 1 %t | llvm-dis | FileCheck %s +

[PATCH] D28843: IRGen: Start using the WriteThinLTOBitcode pass.

tejohnson added inline comments. Comment at: clang/test/CodeGenCXX/type-metadata-thinlto.cpp:2 +// RUN: %clang_cc1 -flto=thin -triple x86_64-unknown-linux -fvisibility hidden -emit-llvm-bc -o %t %s +// RUN: llvm-modextract -o - -n 1 %t | llvm-dis | FileCheck %s +

[PATCH] D28843: IRGen: Start using the WriteThinLTOBitcode pass.

mehdi_amini added inline comments. Comment at: clang/test/CodeGenCXX/type-metadata-thinlto.cpp:2 +// RUN: %clang_cc1 -flto=thin -triple x86_64-unknown-linux -fvisibility hidden -emit-llvm-bc -o %t %s +// RUN: llvm-modextract -o - -n 1 %t | llvm-dis | FileCheck %s +

[PATCH] D28843: IRGen: Start using the WriteThinLTOBitcode pass.

pcc added inline comments. Comment at: clang/test/CodeGenCXX/type-metadata-thinlto.cpp:2 +// RUN: %clang_cc1 -flto=thin -triple x86_64-unknown-linux -fvisibility hidden -emit-llvm-bc -o %t %s +// RUN: llvm-modextract -o - -n 1 %t | llvm-dis | FileCheck %s +

r292439 - Remove now redundant code that ensured debug info for class definitions was emitted under certain circumstances

Author: dblaikie Date: Wed Jan 18 15:15:18 2017 New Revision: 292439 URL: http://llvm.org/viewvc/llvm-project?rev=292439=rev Log: Remove now redundant code that ensured debug info for class definitions was emitted under certain circumstances Introduced in r181561 - it may've been subsumed by

[PATCH] D28843: IRGen: Start using the WriteThinLTOBitcode pass.

mehdi_amini added inline comments. Comment at: clang/test/CodeGenCXX/type-metadata-thinlto.cpp:2 +// RUN: %clang_cc1 -flto=thin -triple x86_64-unknown-linux -fvisibility hidden -emit-llvm-bc -o %t %s +// RUN: llvm-modextract -o - -n 1 %t | llvm-dis | FileCheck %s +

[PATCH] D28820: Warn when calling a non interrupt function from an interrupt on ARM

jroelofs added a comment. In https://reviews.llvm.org/D28820#649770, @efriedma wrote: > > There would be a big performance penalty for ISRs with callees that don't > > use VFP regs. > > Sacrificing correctness for the sake of performance seems like a bad idea... I don't quite see it that way,

[PATCH] D28843: IRGen: Start using the WriteThinLTOBitcode pass.

pcc added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:694 +else + PerModulePasses.add( + createBitcodeWriterPass(*OS, CodeGenOpts.EmitLLVMUseLists)); tejohnson wrote: > Can we transform other callers of

[PATCH] D28781: [OpenMP] Support for the if-clause on the combined directive 'target parallel'.

This revision was automatically updated to reflect the committed changes. Closed by commit rL292437: [OpenMP] Support for the if-clause on the combined directive 'target parallel'. (authored by arpith). Changed prior to commit: https://reviews.llvm.org/D28781?vs=84816=84883#toc Repository:

r292435 - [Modules] Correct test comment from obsolete earlier version of code. NFC

Author: graydon Date: Wed Jan 18 14:34:44 2017 New Revision: 292435 URL: http://llvm.org/viewvc/llvm-project?rev=292435=rev Log: [Modules] Correct test comment from obsolete earlier version of code. NFC Summary: Code committed in rL290219 went through a few iterations; test wound up with stale

r292437 - [OpenMP] Support for the if-clause on the combined directive 'target parallel'.

Author: arpith Date: Wed Jan 18 14:40:48 2017 New Revision: 292437 URL: http://llvm.org/viewvc/llvm-project?rev=292437=rev Log: [OpenMP] Support for the if-clause on the combined directive 'target parallel'. The if-clause on the combined directive potentially applies to both the 'target' and the

[PATCH] D28779: [ASTReader] Add a DeserializationListener callback for IMPORTED_MODULES

This revision was automatically updated to reflect the committed changes. Closed by commit rL292436: [ASTReader] Add a DeserializationListener callback for IMPORTED_MODULES (authored by graydon). Changed prior to commit: https://reviews.llvm.org/D28779?vs=84594=84881#toc Repository: rL LLVM

r292436 - [ASTReader] Add a DeserializationListener callback for IMPORTED_MODULES

Author: graydon Date: Wed Jan 18 14:36:59 2017 New Revision: 292436 URL: http://llvm.org/viewvc/llvm-project?rev=292436=rev Log: [ASTReader] Add a DeserializationListener callback for IMPORTED_MODULES Summary: Add a callback from ASTReader to DeserializationListener when the former reads an

[PATCH] D28790: [Modules] Correct test comment from obsolete earlier version of code. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL292435: [Modules] Correct test comment from obsolete earlier version of code. NFC (authored by graydon). Changed prior to commit: https://reviews.llvm.org/D28790?vs=84616=84879#toc Repository: rL

[PATCH] D28820: Warn when calling a non interrupt function from an interrupt on ARM

efriedma added a comment. > There would be a big performance penalty for ISRs with callees that don't use > VFP regs. Sacrificing correctness for the sake of performance seems like a bad idea... especially given that the optimizer can insert calls to memcpy where they didn't originally exist

[libcxx] r292434 - [libcxx] [test] Fix comment typos, strip trailing whitespace.

Author: stl_msft Date: Wed Jan 18 14:10:25 2017 New Revision: 292434 URL: http://llvm.org/viewvc/llvm-project?rev=292434=rev Log: [libcxx] [test] Fix comment typos, strip trailing whitespace. No functional change, no code review. Modified:

[libcxx] r292432 - [libcxx] [test] Fix MSVC warnings C4127 and C6326 about constants.

Author: stl_msft Date: Wed Jan 18 14:09:56 2017 New Revision: 292432 URL: http://llvm.org/viewvc/llvm-project?rev=292432=rev Log: [libcxx] [test] Fix MSVC warnings C4127 and C6326 about constants. MSVC has compiler warnings C4127 "conditional expression is constant" (enabled by /W4) and C6326

[PATCH] D28867: [Profile] Warn about out-of-date profiles only when there are mismatches

vsk added a comment. Ah ok, so it sounds like a better approach would be to split the missing record message into a separate off-by-default warning. I don't have the time to update this diff this week, but will shoot for the next. https://reviews.llvm.org/D28867

[PATCH] D28820: Warn when calling a non interrupt function from an interrupt on ARM

jroelofs added a comment. In https://reviews.llvm.org/D28820#649738, @jroelofs wrote: > In https://reviews.llvm.org/D28820#649726, @efriedma wrote: > > > Why can't the compiler handle this case itself transparently? According to > > your description, the interrupt calling convention is

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

timshen marked an inline comment as done. timshen added a comment. Friendly ping. :) We still have internal test failures that this patch (and the next one) fixes, and I think this is the last "hard to review" patch in the APFloat refactoring. https://reviews.llvm.org/D27872

[PATCH] D28820: Warn when calling a non interrupt function from an interrupt on ARM

jroelofs added a comment. In https://reviews.llvm.org/D28820#649726, @efriedma wrote: > Why can't the compiler handle this case itself transparently? According to > your description, the interrupt calling convention is different from the > normal hard-float AAPCS calling convention: the VFP

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

bader added inline comments. Comment at: docs/UsersManual.rst:2065 + + $ clang -cc1 -triple spir64-unknown-unknown -cl-ext=-cl_khr_fp64 test.cl + pekka.jaaskelainen wrote: > Anastasia wrote: > > pekka.jaaskelainen wrote: > > > Is this correct? I cannot make

[PATCH] D28867: [Profile] Warn about out-of-date profiles only when there are mismatches

xur added a comment. This change gonna hide the missing profile for a function permanently if there is no mismatch. Like, if a user adds a new function without changing existing functions, he will never get a warning if using the old profiles. In LLVM IR level PGO, we also find the missing

[PATCH] D28755: [OpenMP] Codegen for the 'target parallel' directive on the NVPTX device.

This revision was automatically updated to reflect the committed changes. Closed by commit rL292428: [OpenMP] Codegen for the 'target parallel' directive on the NVPTX device. (authored by arpith). Changed prior to commit: https://reviews.llvm.org/D28755?vs=84512=84870#toc Repository: rL

r292428 - [OpenMP] Codegen for the 'target parallel' directive on the NVPTX device.

Author: arpith Date: Wed Jan 18 13:35:00 2017 New Revision: 292428 URL: http://llvm.org/viewvc/llvm-project?rev=292428=rev Log: [OpenMP] Codegen for the 'target parallel' directive on the NVPTX device. This patch adds codegen for the 'target parallel' directive on the NVPTX device. We term

[PATCH] D28820: Warn when calling a non interrupt function from an interrupt on ARM

efriedma added a comment. Why can't the compiler handle this case itself transparently? According to your description, the interrupt calling convention is different from the normal hard-float AAPCS calling convention: the VFP registers are all callee-save. The compiler knows this; it should

[PATCH] D25213: Fix PR28181: Prevent operator overloading related assertion failure crash that happens in C only

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lib/Sema/SemaExpr.cpp:11523 // being assigned to. if (Opc == BO_Assign && pty->getKind() == BuiltinType::Overload) { + if

r292426 - PR9551: Implement DR1004 (http://wg21.link/cwg1004).

Author: rsmith Date: Wed Jan 18 13:19:22 2017 New Revision: 292426 URL: http://llvm.org/viewvc/llvm-project?rev=292426=rev Log: PR9551: Implement DR1004 (http://wg21.link/cwg1004). This rule permits the injected-class-name of a class template to be used as both a template type argument and a

[PATCH] D28867: [Profile] Warn about out-of-date profiles only when there are mismatches

vsk created this revision. Clang warns that a profile is out-of-date if it can't find a profile record for any function in a TU. This warning is now noisy because llvm can dead-strip functions with profiling instrumentation. Only emit the out-of-date warning if there is an actual record

Re: [libcxxabi] r292418 - Revert r286788

On 1/18/17 11:26 AM, Richard Smith via cfe-commits wrote: On 18 January 2017 at 10:12, Jonathan Roelofs via cfe-commits > wrote: Author: jroelofs Date: Wed Jan 18 12:12:39 2017 New Revision: 292418 URL:

r292419 - [OpenMP] Codegen support for 'target parallel' on the host.

Author: arpith Date: Wed Jan 18 12:18:53 2017 New Revision: 292419 URL: http://llvm.org/viewvc/llvm-project?rev=292419=rev Log: [OpenMP] Codegen support for 'target parallel' on the host. This patch adds support for codegen of 'target parallel' on the host. It is also the first combined

Re: [libcxxabi] r292418 - Revert r286788

On 18 January 2017 at 10:12, Jonathan Roelofs via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jroelofs > Date: Wed Jan 18 12:12:39 2017 > New Revision: 292418 > > URL: http://llvm.org/viewvc/llvm-project?rev=292418=rev > Log: > Revert r286788 > > The Itanium ABI [1] specifies that

[libcxxabi] r292418 - Revert r286788

Author: jroelofs Date: Wed Jan 18 12:12:39 2017 New Revision: 292418 URL: http://llvm.org/viewvc/llvm-project?rev=292418=rev Log: Revert r286788 The Itanium ABI [1] specifies that __cxa_demangle accept either: 1) symbol names, which start with "_Z" 2) type manglings, which do not start

[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

LegalizeAdulthood added a comment. Don't do this without introducing an option to turn it off. https://reviews.llvm.org/D28667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28334: [clang-tidy] Add -extra-arg and -extra-arg-before to run-clang-tidy.py

This revision was automatically updated to reflect the committed changes. ehsan marked an inline comment as done. Closed by commit rL292415: [clang-tidy] Add -extra-arg and -extra-arg-before to run-clang-tidy.py (authored by ehsan). Changed prior to commit:

[clang-tools-extra] r292415 - [clang-tidy] Add -extra-arg and -extra-arg-before to run-clang-tidy.py

Author: ehsan Date: Wed Jan 18 11:49:35 2017 New Revision: 292415 URL: http://llvm.org/viewvc/llvm-project?rev=292415=rev Log: [clang-tidy] Add -extra-arg and -extra-arg-before to run-clang-tidy.py Summary: These flags allow specifying extra arguments to the tool's command line which don't

[PATCH] D28334: [clang-tidy] Add -extra-arg and -extra-arg-before to run-clang-tidy.py

ehsan marked an inline comment as done. ehsan added inline comments. Comment at: clang-tidy/tool/run-clang-tidy.py:80 + for arg in extra_arg: + start.append('-extra-arg=%s' % arg[0]) + for arg in extra_arg_before: alexfh wrote: > Why arg[0] and not just

Re: [PATCH] D28845: Prototype of modules codegen

Oh, remembered I had one other question/idea: Tangentially related to the question about non-inline functions in headers: Currently .pcm files have the 'interesting decls' list. Are there any interesting decls once modules codegen is in use? It seems mostly the interesting decls are things like

Re: [PATCH] D28845: Prototype of modules codegen

On Wed, Jan 18, 2017 at 4:12 AM Hal Finkel via Phabricator < revi...@reviews.llvm.org> wrote: > hfinkel added a comment. > > Can you provide a high-level description of what you're trying to > accomplish and the usage model? > Oh, for sure - sorry for the assumption/missing info. Stuff that's

[clang-tools-extra] r292405 - [include-fixer] Don't return a correction if the header insertion failed.

Author: d0k Date: Wed Jan 18 10:22:58 2017 New Revision: 292405 URL: http://llvm.org/viewvc/llvm-project?rev=292405=rev Log: [include-fixer] Don't return a correction if the header insertion failed. This is could happen in cases involving macros and we don't want to return an invalid fixit for

r292406 - [ASTUnit] Reset diag state when creating the ASTUnit.

Author: d0k Date: Wed Jan 18 10:25:48 2017 New Revision: 292406 URL: http://llvm.org/viewvc/llvm-project?rev=292406=rev Log: [ASTUnit] Reset diag state when creating the ASTUnit. A client could call this with a dirty diagnostic engine, don't crash. Modified:

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

pekka.jaaskelainen added inline comments. Comment at: docs/UsersManual.rst:2065 + + $ clang -cc1 -triple spir64-unknown-unknown -cl-ext=-cl_khr_fp64 test.cl + Anastasia wrote: > pekka.jaaskelainen wrote: > > Is this correct? I cannot make it work: > > > >

[PATCH] D28514: [CodeCompletion] Reset the hidden declaration obtained after lookup when caching UsingShadowDecls

arphaman added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:961 +// then incorrectly applied to the target declaration. This can be avoided +// by resetting the declaration that's being hidden. +if (Hiding && isa(Hiding)) ahatanak

[PATCH] D28514: [CodeCompletion] Reset the hidden declaration obtained after lookup when caching UsingShadowDecls

arphaman updated this revision to Diff 84842. arphaman marked an inline comment as done. arphaman added a comment. Avoid the hidden declaration in `VisibleDeclsRecord::checkHidden` instead of the decl consumer in code-completion Repository: rL LLVM https://reviews.llvm.org/D28514 Files:

[PATCH] D28862: [compiler-rt] [test] Use approximate comparison on float types

mgorny created this revision. Herald added a subscriber: dberris. Use approximate comparison between the result of __divsc3() and the canonical value calculated, to allow the possible difference of 1 representable value resulting from optimization. For example, the value of (0.01+j0.01)

[PATCH] D25213: Fix PR28181: Prevent operator overloading related assertion failure crash that happens in C only

arphaman added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D25213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r292402 - [Basic] Remove source manager references from diag state points.

Author: d0k Date: Wed Jan 18 09:50:26 2017 New Revision: 292402 URL: http://llvm.org/viewvc/llvm-project?rev=292402=rev Log: [Basic] Remove source manager references from diag state points. This is just wasted space, we don't support state points from multiple source managers. Validate that

r292400 - Revert r292374 to debug Windows buildbot failure.

Author: arpith Date: Wed Jan 18 09:36:05 2017 New Revision: 292400 URL: http://llvm.org/viewvc/llvm-project?rev=292400=rev Log: Revert r292374 to debug Windows buildbot failure. Removed: cfe/trunk/test/OpenMP/target_parallel_codegen.cpp

[libunwind] r292398 - Creating release directory for release_400.

Author: hans Date: Wed Jan 18 09:32:43 2017 New Revision: 292398 URL: http://llvm.org/viewvc/llvm-project?rev=292398=rev Log: Creating release directory for release_400. Added: libunwind/tags/RELEASE_400/ ___ cfe-commits mailing list

[libunwind] r292399 - Creating release candidate rc1 from release_400 branch

Author: hans Date: Wed Jan 18 09:32:46 2017 New Revision: 292399 URL: http://llvm.org/viewvc/llvm-project?rev=292399=rev Log: Creating release candidate rc1 from release_400 branch Added: libunwind/tags/RELEASE_400/rc1/ - copied from r292398, libunwind/branches/release_40/

[libcxx] r292385 - Creating release candidate rc1 from release_400 branch

Author: hans Date: Wed Jan 18 09:32:14 2017 New Revision: 292385 URL: http://llvm.org/viewvc/llvm-project?rev=292385=rev Log: Creating release candidate rc1 from release_400 branch Added: libcxx/tags/RELEASE_400/rc1/ (props changed) - copied from r292384, libcxx/branches/release_40/

[libcxxabi] r292387 - Creating release candidate rc1 from release_400 branch

Author: hans Date: Wed Jan 18 09:32:18 2017 New Revision: 292387 URL: http://llvm.org/viewvc/llvm-project?rev=292387=rev Log: Creating release candidate rc1 from release_400 branch Added: libcxxabi/tags/RELEASE_400/rc1/ - copied from r292386, libcxxabi/branches/release_40/

[libcxxabi] r292386 - Creating release directory for release_400.

Author: hans Date: Wed Jan 18 09:32:16 2017 New Revision: 292386 URL: http://llvm.org/viewvc/llvm-project?rev=292386=rev Log: Creating release directory for release_400. Added: libcxxabi/tags/RELEASE_400/ ___ cfe-commits mailing list

[libcxx] r292384 - Creating release directory for release_400.

Author: hans Date: Wed Jan 18 09:32:11 2017 New Revision: 292384 URL: http://llvm.org/viewvc/llvm-project?rev=292384=rev Log: Creating release directory for release_400. Added: libcxx/tags/RELEASE_400/ ___ cfe-commits mailing list

[PATCH] D28820: Warn when calling a non interrupt function from an interrupt on ARM

jroelofs closed this revision. jroelofs added a comment. r292375 https://reviews.llvm.org/D28820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r292375 - Warn when calling a non interrupt function from an interrupt on ARM

Author: jroelofs Date: Wed Jan 18 09:31:11 2017 New Revision: 292375 URL: http://llvm.org/viewvc/llvm-project?rev=292375=rev Log: Warn when calling a non interrupt function from an interrupt on ARM The idea for this originated from a really tricky bug: ISRs on ARM don't automatically save off

[PATCH] D28820: Warn when calling a non interrupt function from an interrupt on ARM

jroelofs added a comment. In https://reviews.llvm.org/D28820#649384, @rengolin wrote: > Seems like a very specific corner case on ARM, but is that attribute > guaranteed to be ARM-only? > > If so, LGTM as is. If not, avoid mentioning "VFP" on the error message. Yeah, the attribute is parsed

[PATCH] D28850: [docs] Tell Doxygen to expand LLVM_ALIGNAS to nothing

malcolm.parsons added a comment. In https://reviews.llvm.org/D28850#649462, @aaron.ballman wrote: > LGTM, though I freely admit that I am no doxygen expert (from reading the > docs, this looks like the sensible approach though). I couldn't find a code owner for docs to ask for review. There

[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

This revision was automatically updated to reflect the committed changes. Closed by commit rL292374: [OpenMP] Codegen support for 'target parallel' on the host. (authored by arpith). Changed prior to commit: https://reviews.llvm.org/D28753?vs=84689=84832#toc Repository: rL LLVM

r292374 - [OpenMP] Codegen support for 'target parallel' on the host.

Author: arpith Date: Wed Jan 18 09:14:52 2017 New Revision: 292374 URL: http://llvm.org/viewvc/llvm-project?rev=292374=rev Log: [OpenMP] Codegen support for 'target parallel' on the host. This patch adds support for codegen of 'target parallel' on the host. It is also the first combined

[PATCH] D28781: [OpenMP] Support for the if-clause on the combined directive 'target parallel'.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28781 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28860: [OpenCL] Diagnose write_only image3d when extension is disabled

svenvh created this revision. Prior to OpenCL 2.0, image3d_t can only be used with the write_only access qualifier when the cl_khr_3d_image_writes extension is enabled. Clang did not diagnose write_only image3d arguments when the extension was disabled. Guard uses of write_only image3d in the

[PATCH] D28850: [docs] Tell Doxygen to expand LLVM_ALIGNAS to nothing

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though I freely admit that I am no doxygen expert (from reading the docs, this looks like the sensible approach though). https://reviews.llvm.org/D28850

[PATCH] D27985: Add demangling support for C++11 thread_local variables

davidb added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D27985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

Armpit, fine, leave it as is Best regards, Alexey Bataev > 18 янв. 2017 г., в 15:50, Arpith Jacob via Phabricator > написал(а): > > arpith-jacob added inline comments. > > > > Comment at: lib/Sema/SemaOpenMP.cpp:1933-1937 > + StmtResult SR = S; >

[PATCH] D28820: Warn when calling a non interrupt function from an interrupt on ARM

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Seems like a very specific corner case on ARM, but is that attribute guaranteed to be ARM-only? If so, LGTM as is. If not, avoid mentioning "VFP" on the error message.

[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

arpith-jacob added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:1933-1937 + StmtResult SR = S; + int ThisCaptureLevel = + getOpenMPCaptureLevels(DSAStack->getCurrentDirective()); + while (--ThisCaptureLevel >= 0) +SR = ActOnCapturedRegionEnd(SR.get());

[PATCH] D28753: [OpenMP] Codegen support for 'target parallel' on the host.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with nits Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:848-860 +const StringRef outlinedHelperName, const RegionCodeGenTy ) {

[PATCH] D28845: Prototype of modules codegen

hfinkel added a comment. Can you provide a high-level description of what you're trying to accomplish and the usage model? https://reviews.llvm.org/D28845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28781: [OpenMP] Support for the if-clause on the combined directive 'target parallel'.

arpith-jacob updated this revision to Diff 84816. arpith-jacob added a comment. Inherit from OMPLexical scope with an added argument to reduce code duplication. https://reviews.llvm.org/D28781 Files: include/clang/AST/OpenMPClause.h include/clang/AST/RecursiveASTVisitor.h

[PATCH] D28850: [docs] Tell Doxygen to expand LLVM_ALIGNAS to nothing

malcolm.parsons created this revision. Docs for clang::Decl and clang::TemplateSpecializationType have not been generated since LLVM_ALIGNAS was added to them. Tell Doxygen to expand LLVM_ALIGNAS to nothing as described at https://www.stack.nl/~dimitri/doxygen/manual/preprocessing.html

[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

leanil updated this revision to Diff 84805. leanil added a comment. Add test cases for the new functionality. These should not produce warnings, because their raw string replacement would be longer. https://reviews.llvm.org/D28667 Files: clang-tidy/modernize/RawStringLiteralCheck.cpp

  1   2   >