majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D43033
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: ibiryukov
Date: Wed Feb 7 23:37:35 2018
New Revision: 324575
URL: http://llvm.org/viewvc/llvm-project?rev=324575&view=rev
Log:
Resubmit "[clangd] The new threading implementation"
Initially submitted as r324356 and reverted in r324386.
This change additionally contains a fix to crashes
martell added a comment.
Updated to just ignore the flag just like how clang-cl does for /bigobj
Repository:
rC Clang
https://reviews.llvm.org/D41597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
martell updated this revision to Diff 133374.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D41597
Files:
include/clang/Driver/Options.td
Index: include/clang/Driver/Options.td
===
--- i
Author: marshall
Date: Wed Feb 7 23:20:45 2018
New Revision: 324573
URL: http://llvm.org/viewvc/llvm-project?rev=324573&view=rev
Log:
Temporarily comment out deduction guide tests while I figure out what to do
with old bots
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/it
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D42614#1001279, @compnerd wrote:
> @rjmccall, I've updated the approach and no longer abuse the existing
> decoration styles. This uses a custom namespace with
Author: marshall
Date: Wed Feb 7 22:34:03 2018
New Revision: 324569
URL: http://llvm.org/viewvc/llvm-project?rev=324569&view=rev
Log:
Implement deduction guide for basic_string as described in P0433
Added:
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc.fail.cpp
Modified:
Author: marshall
Date: Wed Feb 7 21:47:40 2018
New Revision: 324566
URL: http://llvm.org/viewvc/llvm-project?rev=324566&view=rev
Log:
Improve a test. NFC
Modified:
libcxx/trunk/test/libcxx/memory/is_allocator.pass.cpp
Modified: libcxx/trunk/test/libcxx/memory/is_allocator.pass.cpp
URL:
htt
simark updated this revision to Diff 133367.
simark added a comment.
Herald added subscribers: ioeric, jkorous-apple.
New version
Here's a new version of the patch, quite reworked. I scaled down the scope a
little bit to make it simpler (see commit log). We'll add more features later
on.
Repo
EricWF updated this revision to Diff 133365.
EricWF added a comment.
@rsmith Is this the direction you were thinking?
I haven't updated the tests yet, but I wanted to make the other changes visible
earlier.
https://reviews.llvm.org/D43047
Files:
include/clang/Basic/Builtins.def
include/cl
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
NoQ added a dependency: D43056: [CFG] [analyzer] Add construction context for
CXXBindTemporaryExpr..
Patch https://reviews.llvm.org/D43056 ad
smeenai added a comment.
LGTM, but I'd like @majnemer to take a look, since I'm not very familiar with
this code.
https://reviews.llvm.org/D43033
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
EricWF added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:1309-1344
RValue CodeGenFunction::EmitBuiltinNewDeleteCall(const FunctionProtoType *Type,
- const Expr *Arg,
- bool
EricWF marked an inline comment as done.
EricWF added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:1309-1344
RValue CodeGenFunction::EmitBuiltinNewDeleteCall(const FunctionProtoType *Type,
- const Expr *Arg,
-
erichkeane created this revision.
erichkeane added reviewers: samparker, fhahn, rengolin, echristo, craig.topper.
Herald added subscribers: fedor.sergeev, kbarton, aheejin, jgravelle-google,
sbc100, nhaehnle, nemanjai, sdardis, dylanmckay, jyknight, dschuff, jfb.
A followup to: https://reviews.ll
NoQ added a reviewer: rsmith.
NoQ added a subscriber: rsmith.
NoQ added a comment.
Added @rsmith because we're trying to give him a heads up every time large CFG
changes are coming, because if we mess up it would affect not only the analyzer
but the whole compiler through analysis-based compiler
NoQ added a comment.
I poked Devin offline and we agreed that the overall approach is good to go.
Maxim, thank you for picking it up!
We still don't have scopes for segments of code that don't have any variables
in them, so i guess it's not yet in the shape where it is super useful for
loops,
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324553: [clang-format] Set ObjCBinPackProtocolList to Never
for google style (authored by benhamilton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42708?vs=132189&id=133349#toc
R
Author: benhamilton
Date: Wed Feb 7 17:49:10 2018
New Revision: 324553
URL: http://llvm.org/viewvc/llvm-project?rev=324553&view=rev
Log:
[clang-format] Set ObjCBinPackProtocolList to Never for google style
Summary:
This is split off from D42650, and sets ObjCBinPackProtocolList
to Never for the
jakehehrlich added a comment.
After the comments I just made are resolved, I'm fine with the low level
details of the parts of this change that are here
Comment at: clang-doc/ClangDoc.cpp:47
+
+comments::FullComment *ClangDocCallback::getComment(const NamedDecl *D) {
+ RawCom
Author: rafael
Date: Wed Feb 7 17:17:26 2018
New Revision: 324552
URL: http://llvm.org/viewvc/llvm-project?rev=324552&view=rev
Log:
Add a testcase for PR36268.
Added:
cfe/trunk/test/CodeGenObjC/availability-dso-local.m
Added: cfe/trunk/test/CodeGenObjC/availability-dso-local.m
URL:
http://
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
This covers temporary constructors for which a destructor is necessary. It is
necessary to support `CXXTemporaryObjectExpr` here, which is a
bsdjhb updated this revision to Diff 10.
bsdjhb added a comment.
- Add a test case.
Repository:
rC Clang
https://reviews.llvm.org/D42972
Files:
lib/Driver/ToolChains/FreeBSD.cpp
test/Driver/freebsd.c
Index: test/Driver/freebsd.c
=
stephanemoore accepted this revision.
stephanemoore added a comment.
Pretty unanimous from the Google style arbitration side. Looks good to me.
Repository:
rC Clang
https://reviews.llvm.org/D42708
___
cfe-commits mailing list
cfe-commits@lists.ll
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
SGTM.
Repository:
rC Clang
https://reviews.llvm.org/D43044
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Author: ericwf
Date: Wed Feb 7 15:50:25 2018
New Revision: 324545
URL: http://llvm.org/viewvc/llvm-project?rev=324545&view=rev
Log:
Fix size and alignment of array.
An array T[1] isn't necessarily the same say when it's
a member of a struct. This patch addresses that problem and corrects
the tes
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
This looks good to me, but I think you should include your explanatory comments
in the commit message to the comment itself to help future violators of the
assertion out!
mclow.lists requested changes to this revision.
mclow.lists added a comment.
This revision now requires changes to proceed.
Since we've implemented P0600, I believe that this patch is out of date.
The correct macro is `_LIBCPP_NODISCARD_AFTER_CXX17`, and I think that several
of these cases are no
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324542: Fix compilation in C++17 mode. (authored by rsmith,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42987?vs=133089&id=133323#toc
Rep
Author: rsmith
Date: Wed Feb 7 15:23:23 2018
New Revision: 324542
URL: http://llvm.org/viewvc/llvm-project?rev=324542&view=rev
Log:
Fix compilation in C++17 mode.
C++17 removes `std::unexpected_handler`, but libc++abi needs it to define
`__cxa_exception`. When building against libc++, this is ea
rsmith added a comment.
I defined `_LIBCPP_BUILDING_LIBRARY` instead to match the existing code in
libc++abi (stdlib_exception.cpp, stdlib_new_delete.cpp), which uses the
`_BUILDING_LIBRARY` macro as a general way to say "give me all the symbols
because I'm building the library". That seemed to
rsmith added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:1309-1344
RValue CodeGenFunction::EmitBuiltinNewDeleteCall(const FunctionProtoType *Type,
- const Expr *Arg,
- bool
compnerd added a comment.
@rjmccall, I've updated the approach and no longer abuse the existing
decoration styles. This uses a custom namespace with artificial types to
differentiate the types. I've also ensured that the parameter types do not
encode the type information.
Repository:
rC C
compnerd updated this revision to Diff 133319.
compnerd edited the summary of this revision.
compnerd added a comment.
Address comments from @rjmccall
Repository:
rC Clang
https://reviews.llvm.org/D42614
Files:
lib/AST/MicrosoftMangle.cpp
test/CodeGenObjCXX/msabi-objc-extensions.mm
tes
Author: erichkeane
Date: Wed Feb 7 15:04:38 2018
New Revision: 324540
URL: http://llvm.org/viewvc/llvm-project?rev=324540&view=rev
Log:
[NFCi] Replace a couple of usages of const StringRef& with StringRef
No sense passing these by reference when a copy is about as free, and
saves on potential in
Author: rafael
Date: Wed Feb 7 15:04:06 2018
New Revision: 324539
URL: http://llvm.org/viewvc/llvm-project?rev=324539&view=rev
Log:
Don't try to use copy relocations with tls variables.
Should fix the lldb bot.
Modified:
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
cfe/trunk/test/CodeGen/dso
EricWF created this revision.
EricWF added reviewers: rsmith, majnemer, aaron.ballman, erik.pilkington,
bogner, ahatanak.
Libc++'s default allocator uses `__builtin_operator_new` and
`__builtin_operator_delete` in order to allow the calls to new/delete to be
ellided. However, libc++ now needs t
dim added a comment.
FWIW, this allows me to build wine again for x86_64, without any crashes or
assertions. So that looks good, in any case.
Repository:
rC Clang
https://reviews.llvm.org/D43016
___
cfe-commits mailing list
cfe-commits@lists.llv
Author: rsmith
Date: Wed Feb 7 14:25:16 2018
New Revision: 324537
URL: http://llvm.org/viewvc/llvm-project?rev=324537&view=rev
Log:
PR36055: fix computation of *-dependence in nested initializer lists.
When we synthesize an implicit inner initializer list when analyzing an outer
initializer list
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I agree with Marshall. This should define
`_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS` instead of
`_LIBCPP_BUILDING_LIBRARY`. Other than that, this LGTM.
Repository:
rCXXA libc++abi
Author: rafael
Date: Wed Feb 7 14:15:33 2018
New Revision: 324535
URL: http://llvm.org/viewvc/llvm-project?rev=324535&view=rev
Log:
Recommit r324107 again.
The difference from the previous try is that we no longer directly
access function declarations from position independent executables. It
sh
arphaman abandoned this revision.
arphaman added subscribers: dcoughlin, dexonsmith.
arphaman added a comment.
Thanks for your input. You're right, this warning is quite correct (even though
it seems like too much).
I discussed this with @dexonsmith and @dcoughlin and we decided to keep the
wa
kzhuravl added a comment.
Need to only define canonical names.
https://reviews.llvm.org/D36802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: danalbert
Date: Wed Feb 7 13:58:48 2018
New Revision: 324534
URL: http://llvm.org/viewvc/llvm-project?rev=324534&view=rev
Log:
Stop using __strtonum_fallback on Android.
Fallback implementations are now provided by bionic when necessary,
which these may conflict with.
Modified:
libc
erichkeane created this revision.
erichkeane added reviewers: samparker, fhahn, rengolin, echristo, Hahnfeld.
Herald added a subscriber: jholewinski.
A followup to: https://reviews.llvm.org/D42978
This patch adds NVPTX support for
enabling the march notes.
Repository:
rC Clang
https://reviews
NoQ updated this revision to Diff 133299.
NoQ added a comment.
Remove the check in `shouldInlineCall()` as well. It's quite covered by the
`IsConstructorWithImproperlyModeledTargetRegion` check.
https://reviews.llvm.org/D42991
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine
scott.linder created this revision.
scott.linder added reviewers: aprantl, JDevlieghere.
Herald added a subscriber: cfe-commits.
scott.linder added a dependency: D43043: [DebugInfo] Unify ChecksumKind and
Checksum value in DIFile.
Update to match new DIFile API.
Repository:
rC Clang
https://
Author: marshall
Date: Wed Feb 7 13:30:17 2018
New Revision: 324531
URL: http://llvm.org/viewvc/llvm-project?rev=324531&view=rev
Log:
Fix PR#31454 - 'basic_string::push_back() crashes if sizeof(T)>sizeof(long
long)'. We were mishandling the small-string optimization calculations for very
large
EricWF updated this revision to Diff 133294.
EricWF added reviewers: aaron.ballman, bogner, majnemer.
EricWF added a comment.
Ping.
- Rebase off trunk.
https://reviews.llvm.org/D37035
Files:
docs/LanguageExtensions.rst
include/clang/AST/Expr.h
include/clang/AST/ExprCXX.h
include/clang/
vitalybuka added a comment.
ping
https://reviews.llvm.org/D42680
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Feb 7 13:25:25 2018
New Revision: 324529
URL: http://llvm.org/viewvc/llvm-project?rev=324529&view=rev
Log:
Fix -verify static assert messages for older Clang versions
Modified:
libcxx/trunk/test/std/containers/sequences/array/array.fill/fill.fail.cpp
libcxx/trunk
EricWF updated this revision to Diff 133290.
EricWF added a comment.
- Rebase off master.
https://reviews.llvm.org/D40218
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/DiagnosticSemaKinds.td
lib/AST/ExprConstant.cpp
lib/CodeGen/CGBuiltin.cpp
lib/Sema/SemaChecking.cpp
t
erichkeane created this revision.
erichkeane added reviewers: samparker, fhahn, rengolin, echristo, craig.topper.
A followup to: https://reviews.llvm.org/D42978
This patch adds X86 and X86_64 support for
enabling the march notes.
Repository:
rC Clang
https://reviews.llvm.org/D43041
Files:
Author: vedantk
Date: Wed Feb 7 13:17:22 2018
New Revision: 324527
URL: http://llvm.org/viewvc/llvm-project?rev=324527&view=rev
Log:
[clang-import-test] Run clang-format, NFC
I ran across clang-import-test while looking into testing for lldb.
There shouldn't be any harm in running clang-format o
EricWF added a comment.
Ping.
https://reviews.llvm.org/D40218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324526: [libc++] Fix PR35491 - std::array of zero-size
doesn't work with non-default… (authored by EricWF, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX324526: [libc++] Fix PR35491 - std::array of zero-size
doesn't work with non-default… (authored by EricWF, committed by ).
Repository:
rCXX libc++
https://reviews.llvm.org/D41223
Files:
include/__
EricWF accepted this revision.
EricWF added a comment.
Accepting new version.
https://reviews.llvm.org/D41223
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Feb 7 13:06:13 2018
New Revision: 324526
URL: http://llvm.org/viewvc/llvm-project?rev=324526&view=rev
Log:
[libc++] Fix PR35491 - std::array of zero-size doesn't work with non-default
constructible types.
Summary:
This patch fixes llvm.org/PR35491 and LWG2157
(https:/
EricWF updated this revision to Diff 133285.
EricWF added a comment.
- Update with new, hopefully working, version.
https://reviews.llvm.org/D41223
Files:
include/__config
include/array
test/libcxx/containers/sequences/array/array.zero/db_back.pass.cpp
test/libcxx/containers/sequences/a
EricWF reopened this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
This was reverted as it caused build failures. Re-opening with new version.
Repository:
rCXX libc++
https://reviews.llvm.org/D41223
___
cfe-co
russellmcc added a comment.
Thanks for the feedback! I'm very motivated to get some support for these
features since they are required for my style guide. Let me know if my recent
changes made sense to you.
Comment at: lib/Format/ContinuationIndenter.cpp:756
State
russellmcc updated this revision to Diff 133280.
russellmcc added a comment.
Responded to review feedback:
- Fix bug where `AllowAllArgumentsOnNextLine` overrode
`AllowAllParametersOfDeclarationOnNextLine`
- Add tests demonstrating independence of `AllowAllArgumentsOnNextLine` and
`AllowAllPara
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324514: [PR36008] Avoid -Wsign-compare warning for enum
constants in (authored by arphaman, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42
Author: hans
Date: Wed Feb 7 12:47:12 2018
New Revision: 324525
URL: http://llvm.org/viewvc/llvm-project?rev=324525&view=rev
Log:
Creating release candidate rc2 from release_600 branch
Added:
libunwind/tags/RELEASE_600/rc2/
- copied from r324524, libunwind/branches/release_60/
___
SjoerdMeijer added a comment.
Thanks for fixing this. Looks very reasonable to me.
Question about the failures: I am now wondering if this means we were and still
are missing tests?
Nit: for future reviews, I think it is better to split patches up if they are
commits to
different repos.
htt
Author: hans
Date: Wed Feb 7 12:46:26 2018
New Revision: 324519
URL: http://llvm.org/viewvc/llvm-project?rev=324519&view=rev
Log:
Creating release candidate rc2 from release_600 branch
Added:
libcxxabi/tags/RELEASE_600/rc2/
- copied from r324518, libcxxabi/branches/release_60/
___
Author: hans
Date: Wed Feb 7 12:46:19 2018
New Revision: 324518
URL: http://llvm.org/viewvc/llvm-project?rev=324518&view=rev
Log:
Creating release candidate rc2 from release_600 branch
Added:
libcxx/tags/RELEASE_600/rc2/ (props changed)
- copied from r324517, libcxx/branches/release_
Author: arphaman
Date: Wed Feb 7 12:45:39 2018
New Revision: 324514
URL: http://llvm.org/viewvc/llvm-project?rev=324514&view=rev
Log:
[PR36008] Avoid -Wsign-compare warning for enum constants in
typeof expressions
This commit looks through typeof type at the original expression when diagnosing
-
rjmccall added a comment.
I don't understand why your description of this patch mentions the void*
placement new[] operator. There's no cookie to poison for that operator.
Repository:
rC Clang
https://reviews.llvm.org/D43013
___
cfe-commits mai
Author: george.karpenkov
Date: Wed Feb 7 11:56:52 2018
New Revision: 324507
URL: http://llvm.org/viewvc/llvm-project?rev=324507&view=rev
Log:
[analyzer] [NFC] Factor out generating path diagnostics for a statement into a
function
Differential Revision: https://reviews.llvm.org/D42558
Modified:
Author: chill
Date: Wed Feb 7 11:57:04 2018
New Revision: 324508
URL: http://llvm.org/viewvc/llvm-project?rev=324508&view=rev
Log:
Revert [DebugInfo] Improvements to representation of enumeration types
(PR36168)"
Revert due to breaking buildbots (LLDB tests)
Removed:
cfe/trunk/test/CodeGen
Author: rafael
Date: Wed Feb 7 11:44:15 2018
New Revision: 324505
URL: http://llvm.org/viewvc/llvm-project?rev=324505&view=rev
Log:
Revert "Recommit r324107."
This reverts commit r324500.
The bots found two failures:
ThreadSanitizer-x86_64 :: Linux/pie_no_aslr.cc
ThreadSanitizer-x86_64
sbc100 created this revision.
Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google,
dschuff, jfb.
Repository:
rC Clang
https://reviews.llvm.org/D43035
Files:
include/clang/Basic/TargetCXXABI.h
lib/Basic/Targets.cpp
lib/Basic/Targets/WebAssembly.cpp
lib/CodeGen/CGB
Author: marshall
Date: Wed Feb 7 11:24:37 2018
New Revision: 324503
URL: http://llvm.org/viewvc/llvm-project?rev=324503&view=rev
Log:
Comment on 'Review' issues
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llv
lebedev.ri added inline comments.
Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:75
+ // libcxx implementation of std::experimental::simd requires at least C++11.
+ if (!Result.Context->getLangOpts().CPlusPlus11)
+return;
timshen wrote:
> MaskRa
rnk created this revision.
rnk added reviewers: smeenai, majnemer.
Herald added a subscriber: eraman.
Fixes PR36247, which is where WinEHPrepare replaces inline asm in
funclets with unreachable.
Make getBundlesForFunclet return by value to simplify some call sites.
https://reviews.llvm.org/D430
Author: ericwf
Date: Wed Feb 7 11:17:03 2018
New Revision: 324501
URL: http://llvm.org/viewvc/llvm-project?rev=324501&view=rev
Log:
Fix r324498: the commit removed the '-' before the disable-llvm-verifier flag
Modified:
cfe/trunk/lib/Driver/ToolChains/Clang.cpp
Modified: cfe/trunk/lib/Drive
Author: rafael
Date: Wed Feb 7 11:16:49 2018
New Revision: 324500
URL: http://llvm.org/viewvc/llvm-project?rev=324500&view=rev
Log:
Recommit r324107.
It now includes a fix to not mark available_externally definitions as
dso_local.
Original message:
Start setting dso_local in clang.
This start
timshen added inline comments.
Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:75
+ // libcxx implementation of std::experimental::simd requires at least C++11.
+ if (!Result.Context->getLangOpts().CPlusPlus11)
+return;
MaskRay wrote:
> lebedev.r
espindola closed this revision.
espindola added a comment.
r324499
https://reviews.llvm.org/D42924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rafael
Date: Wed Feb 7 11:04:41 2018
New Revision: 324499
URL: http://llvm.org/viewvc/llvm-project?rev=324499&view=rev
Log:
Don't pass ForDefinition_t in places it is redundant.
I found this while looking at the ppc failures caused by the dso_local
change.
The issue was that the patch w
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
These ABIInfo classes don't have any state, so just building one on the stack
as needed is the way to go. Thanks for the fix!
Repository:
rC Clang
https://reviews.llvm.org/D43016
__
MaskRay updated this revision to Diff 133255.
MaskRay marked an inline comment as done.
MaskRay added a comment.
readability-simd-intrinsics.rst
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42983
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/Readabil
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D43017
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324498: [Driver] Add option to manually control discarding
value names in LLVM IR. (authored by EricWF, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D42887
Files:
docs/UsersManual.r
Author: ericwf
Date: Wed Feb 7 10:36:51 2018
New Revision: 324498
URL: http://llvm.org/viewvc/llvm-project?rev=324498&view=rev
Log:
[Driver] Add option to manually control discarding value names in LLVM IR.
Summary:
Currently, assertion-disabled Clang builds emit value names when generating
LLV
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D42887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
I'm guessing things were structured this way so that a function definition
could have its visibility set before giving it a body, i.e. it would look like
a declaration, but the visibility shou
EricWF updated this revision to Diff 133251.
EricWF marked an inline comment as done.
EricWF added a comment.
- Fix documentation as requested.
- Put entire statement inside of `#ifdef` blocks.
https://reviews.llvm.org/D42887
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
lib
EricWF marked 5 inline comments as done.
EricWF added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:3269-3274
+ const bool IsAssertBuild =
#ifdef NDEBUG
- CmdArgs.push_back("-disable-llvm-verifier");
- // Discard LLVM value names in -asserts builds.
- CmdArgs.
MaskRay marked 2 inline comments as done.
MaskRay added inline comments.
Comment at: include/clang-c/Index.h:6159
+ */
+ CXSymbolRole role;
} CXIdxEntityRefInfo;
ilya-biryukov wrote:
> Why do we need to store both `CXIdxEntityRefKind` and `CXSymbolRole`? Can
espindola added a comment.
Ping.
https://reviews.llvm.org/D42924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This LGTM.
Comment at: include/valarray:3728
+{
+__clear();
if (__n)
I thought that you had lost an exception guarantee here, but it turns
lebedev.ri added inline comments.
Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:77
+void SIMDIntrinsicsCheck::registerMatchers(MatchFinder *Finder) {
+ Finder->addMatcher(
+
callExpr(callee(functionDecl(matchesName("^::(_mm_|_mm256_|_mm512_|vec_)"))),
MaskRay marked 3 inline comments as done.
MaskRay added inline comments.
Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:26
+
+ static const llvm::StringMap Mapping{
+// [simd.alg]
lebedev.ri wrote:
> You probably want to move `Mapping` out of the
mclow.lists added a comment.
This all looks good to me.
I think that one more test should be added - and that's one that tests `__sqr`
directly.
Since that's not a public routine, the test should go in
"test/libcxx/numerics/complex.number"
https://reviews.llvm.org/D41629
___
MaskRay marked 2 inline comments as done.
MaskRay added inline comments.
Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:75
+ // libcxx implementation of std::experimental::simd requires at least C++11.
+ if (!Result.Context->getLangOpts().CPlusPlus11)
+return;
-
MaskRay updated this revision to Diff 133239.
MaskRay added a comment.
Use unnamed namespace to enclose AST_MATCHER and TrySuggest*
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42983
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule
MaskRay updated this revision to Diff 133237.
MaskRay added a comment.
Add check-specific option `Experimental`
StringRef Std;
if (Result.Context->getLangOpts().CPlusPlus2a) {
Std = "std";
} else if (Result.Context->getLangOpts().CPlusPlus11 && Experimental) {
// libcxx implementati
1 - 100 of 140 matches
Mail list logo
