[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

rjmccall added inline comments. Comment at: lib/CodeGen/CGExprAgg.cpp:1002 + return EmitFinalDestCopy( + E->getType(), CGF.MakeNaturalAlignAddrLValue(Select, E->getType())); +} Is there something in Sema actually validating that the comparison types is

r330681 - [X86] Remove '#ifdef __x86_64__' around mask_set1_epi64 intrinsics.

Author: ctopper Date: Mon Apr 23 20:36:08 2018 New Revision: 330681 URL: http://llvm.org/viewvc/llvm-project?rev=330681=rev Log: [X86] Remove '#ifdef __x86_64__' around mask_set1_epi64 intrinsics. The unmasked versions already didn't have this restrction. I don't think gcc or icc limit these to

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

On Mon, Apr 23, 2018 at 8:23 PM, Richard Smith wrote: > On 23 April 2018 at 16:23, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Mon, Apr 23, 2018 at 4:12 PM John McCall wrote: >> >>> On Mon, Apr 23, 2018 at 6:32 PM,

r330674 - Make add_clang_tool() formatting a bit more consistent.

Author: nico Date: Mon Apr 23 18:30:44 2018 New Revision: 330674 URL: http://llvm.org/viewvc/llvm-project?rev=330674=rev Log: Make add_clang_tool() formatting a bit more consistent. Modified: cfe/trunk/tools/clang-rename/CMakeLists.txt Modified: cfe/trunk/tools/clang-rename/CMakeLists.txt

[PATCH] D45284: [RISCV] More validations on the input value of -march=

apazos updated this revision to Diff 143674. apazos added a comment. Hi Alex, the refactoring will be simple and can be done later when we need it, all the pieces are already parsed (type, name, major, minor) and are in strings, we will only need to convert to the preferred type (enum, int,

[PATCH] D45996: [HWASan] Update HWASan assembly snippet in the docs

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D45996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r330671 - Fix build break due to content moving from Scalar.h to InstCombine.h in LLVM

Author: dblaikie Date: Mon Apr 23 17:59:22 2018 New Revision: 330671 URL: http://llvm.org/viewvc/llvm-project?rev=330671=rev Log: Fix build break due to content moving from Scalar.h to InstCombine.h in LLVM Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified:

[PATCH] D45884: [Sema] Fix parsing of anonymous union in language linkage specification

rsmith added inline comments. Comment at: Sema/SemaDecl.cpp:4654-4656 + while (OwnerScope->getDeclKind() == Decl::LinkageSpec) { +OwnerScope = OwnerScope->getParent(); + } vsapsai wrote: > Looks like `DeclContext::isTransparentContext()` might

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

On 23 April 2018 at 16:23, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Apr 23, 2018 at 4:12 PM John McCall wrote: > >> On Mon, Apr 23, 2018 at 6:32 PM, David Blaikie >> wrote: >> >>> On Mon, Apr 23, 2018 at 3:29 PM John

[PATCH] D45997: [CMake] Pass additional CMake flags in Fuchsia cache files

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett. Herald added subscribers: cfe-commits, mgorny. This allows passing additional CMake flags to builtins and runtimes build through Fuchsia cache files. We now also set build type and enable assertions for

[PATCH] D45884: [Sema] Fix parsing of anonymous union in language linkage specification

vsapsai added a comment. For the record, DR154: Anonymous unions in unnamed namespaces is relevant here. Comment at: Sema/SemaDecl.cpp:4654-4656 + while (OwnerScope->getDeclKind() == Decl::LinkageSpec) {

[PATCH] D45685: [Sema] Add -wtest global flag that silences -Wself-assign for overloaded operators.

rsmith added a comment. I would feel a lot more comfortable adding a `-wtest` flag if we had more than one warning that it would control. If there's really only one warning out of >600 that qualifies for this treatment, I really don't think we have a good argument to introduce a new feature

[PATCH] D45996: [HWASan] Update HWASan assembly snippet in the docs

alekseyshl created this revision. alekseyshl added a reviewer: eugenis. To complement https://reviews.llvm.org/D45840 Repository: rC Clang https://reviews.llvm.org/D45996 Files: docs/HardwareAssistedAddressSanitizerDesign.rst Index: docs/HardwareAssistedAddressSanitizerDesign.rst

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

On Mon, Apr 23, 2018 at 4:12 PM John McCall wrote: > On Mon, Apr 23, 2018 at 6:32 PM, David Blaikie wrote: > >> On Mon, Apr 23, 2018 at 3:29 PM John McCall via Phabricator < >> revi...@reviews.llvm.org> wrote: >> >>> rjmccall added a comment. >>> >>> In

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

On Mon, Apr 23, 2018 at 6:32 PM, David Blaikie wrote: > On Mon, Apr 23, 2018 at 3:29 PM John McCall via Phabricator < > revi...@reviews.llvm.org> wrote: > >> rjmccall added a comment. >> >> In https://reviews.llvm.org/D45766#1076176, @dblaikie wrote: >> >> > Is there anything

[PATCH] D45456: [Attr] Print enum attributes at correct position

jdenny added a comment. Ping. In case it's not clear: this patch doesn't depend on other patches, but others depend on it. https://reviews.llvm.org/D45456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45093: [AST] Fix -ast-print for _Bool when have diagnostics

jdenny updated this revision to Diff 143667. jdenny added a comment. Rebased. https://reviews.llvm.org/D45093 Files: include/clang/AST/ASTContext.h include/clang/Sema/Sema.h lib/Parse/ParseDecl.cpp lib/Sema/Sema.cpp lib/Sema/SemaChecking.cpp lib/Sema/SemaCodeComplete.cpp

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

vsapsai added a comment. Herald added a subscriber: jkorous. Ping. https://reviews.llvm.org/D34331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

On Mon, Apr 23, 2018 at 3:29 PM John McCall via Phabricator < revi...@reviews.llvm.org> wrote: > rjmccall added a comment. > > In https://reviews.llvm.org/D45766#1076176, @dblaikie wrote: > > > Is there anything else in the "-w" namespace other than the literal "-w" > so > > far? > > > No. This

[PATCH] D45470: Emit an error when mixing and

vsapsai added a comment. Herald added a subscriber: jkorous. Ping. https://reviews.llvm.org/D45470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

rjmccall added a comment. In https://reviews.llvm.org/D45766#1076176, @dblaikie wrote: > Is there anything else in the "-w" namespace other than the literal "-w" so > far? No. This would be novel. > I mean, I could imagine it might make more sense to default these warnings > off & users can

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

Is there anything else in the "-w" namespace other than the literal "-w" so far? I mean, I could imagine it might make more sense to default these warnings off & users can turn them on for non-test code, potentially? So "-Wnon-test" might make sense. On Mon, Apr 23, 2018 at 3:22 PM John McCall

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

dblaikie added a comment. Is there anything else in the "-w" namespace other than the literal "-w" so far? I mean, I could imagine it might make more sense to default these warnings off & users can turn them on for non-test code, potentially? So "-Wnon-test" might make sense. Repository: rL

[PATCH] D44609: [Clang-Format] New option BreakBeforeLambdaBody to manage lambda line break inside function parameter call

Wawha added a comment. Hi djasper, Here a project where there is lambda and allman style for them : https://github.com/boostorg/hof/blob/develop/example/in.cpp https://github.com/boostorg/hof/blob/develop/example/sequence.cpp Example of code: // Function to find an iterator using a

r330657 - [X86] Move __builtin_ia32_movnti64 andd __builtin_ia32_rdrand64_step to BuiltinsX86_64.def to make them unavailable in 32-bit mode.

Author: ctopper Date: Mon Apr 23 15:18:34 2018 New Revision: 330657 URL: http://llvm.org/viewvc/llvm-project?rev=330657=rev Log: [X86] Move __builtin_ia32_movnti64 andd __builtin_ia32_rdrand64_step to BuiltinsX86_64.def to make them unavailable in 32-bit mode. Modified:

r330658 - [X86] Move the 32-bit versions of rdfsbase/rdgsbase/wrfsbase/wrgsbase to BuiltinsX86_64.def.

Author: ctopper Date: Mon Apr 23 15:18:36 2018 New Revision: 330658 URL: http://llvm.org/viewvc/llvm-project?rev=330658=rev Log: [X86] Move the 32-bit versions of rdfsbase/rdgsbase/wrfsbase/wrgsbase to BuiltinsX86_64.def. The 32-bit refers to their input/output type, but the instructions are

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

rjmccall added a comment. In https://reviews.llvm.org/D45766#1076090, @dblaikie wrote: > FWIW I don't fundamentalyl object to also having something like -wtest. > Probably needs a better name though (unfortunately the double-negative gets > confusing... - like you want to describe the set of

[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3069 + if (hasAggregateEvaluationKind(type) && + getContext().isParamDestroyedInCallee(type)) { +EHScopeStack::stable_iterator cleanup = ahatanak wrote: > rjmccall wrote: > > I wonder

r330656 - [AST] strcmp/memcmp always compares unsigned chars.

Author: d0k Date: Mon Apr 23 15:04:34 2018 New Revision: 330656 URL: http://llvm.org/viewvc/llvm-project?rev=330656=rev Log: [AST] strcmp/memcmp always compares unsigned chars. This makes it return the right result in a couple of edge cases. The wide versions always do the comparison on the

[libcxx] r330655 - Re-commit r330627 "[libcxx] implement declarations based on P0214R7."

Author: timshen Date: Mon Apr 23 14:54:06 2018 New Revision: 330655 URL: http://llvm.org/viewvc/llvm-project?rev=330655=rev Log: Re-commit r330627 "[libcxx] implement declarations based on P0214R7." There are 3 changes: * Renamed genertor.pass.cpp to generator.pass.cpp * Removed

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

craig.topper added inline comments. Comment at: lib/Headers/movdirintrin.h:39 +// Move quadword as direct store +static __inline__ void +__attribute__((__always_inline__, __nodebug__, __target__("movdiri"))) Sorry, the X86_64 preprocessor check should have

[PATCH] D45839: [analyzer] Add support for WebKit "unified sources".

NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:144 +// includes the full path. +if (SM.getFilename(IL).contains("UnifiedSource")) { + StringRef Name = SM.getFilename(SL); NoQ wrote: >

[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor

ahatanak added a comment. x. Comment at: lib/CodeGen/CGCall.cpp:3069 + if (hasAggregateEvaluationKind(type) && + getContext().isParamDestroyedInCallee(type)) { +EHScopeStack::stable_iterator cleanup = rjmccall wrote: > I wonder if this is something

r330654 - [Docs] Regenerate command line documentation.

Author: ctopper Date: Mon Apr 23 14:41:06 2018 New Revision: 330654 URL: http://llvm.org/viewvc/llvm-project?rev=330654=rev Log: [Docs] Regenerate command line documentation. Modified: cfe/trunk/docs/ClangCommandLineReference.rst Modified: cfe/trunk/docs/ClangCommandLineReference.rst URL:

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

dblaikie added a subscriber: lebedev.ri. dblaikie added a comment. FWIW I don't fundamentalyl object to also having something like -wtest. Probably needs a better name though (unfortunately the double-negative gets confusing... - like you want to describe the set of diagnostics that should not be

[PATCH] D45685: [Sema] Add -wtest global flag that silences -Wself-assign for overloaded operators.

lebedev.ri added a comment. @brooksmoses The simple `-Wno-self-assign-overloaded` variant (https://reviews.llvm.org/D45766) has landed, so the issue should be resolved? Not sure what to do with this differential, should i abandon it until there is more interest for such functionality?

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

FWIW I don't fundamentalyl object to also having something like -wtest. Probably needs a better name though (unfortunately the double-negative gets confusing... - like you want to describe the set of diagnostics that should not be used in test code, so that as a group might be "-Wnon-test" but

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

lebedev.ri added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11527-11528 - S.Diag(OpLoc, diag::warn_self_assignment) - << LHSDeclRef->getType() - << LHSExpr->getSourceRange() << RHSExpr->getSourceRange(); + S.Diag(OpLoc, IsBuiltin ?

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

This revision was automatically updated to reflect the committed changes. Closed by commit rL330651: [Sema] Add -Wno-self-assign-overloaded (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r330651 - [Sema] Add -Wno-self-assign-overloaded

Author: lebedevri Date: Mon Apr 23 14:35:21 2018 New Revision: 330651 URL: http://llvm.org/viewvc/llvm-project?rev=330651=rev Log: [Sema] Add -Wno-self-assign-overloaded Summary: It seems there isn't much enthusiasm for `-wtest` D45685. This is more conservative version, which i had in the very

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

GBuella updated this revision to Diff 143647. https://reviews.llvm.org/D45984 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h

[PATCH] D45839: [analyzer] Add support for WebKit "unified sources".

NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:144 +// includes the full path. +if (SM.getFilename(IL).contains("UnifiedSource")) { + StringRef Name = SM.getFilename(SL); probinson wrote: >

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

lebedev.ri updated this revision to Diff 143645. lebedev.ri added a comment. Add negative tests, too. Repository: rC Clang https://reviews.llvm.org/D45766 Files: docs/ReleaseNotes.rst include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

GBuella updated this revision to Diff 143644. https://reviews.llvm.org/D45984 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h

[PATCH] D45839: [analyzer] Add support for WebKit "unified sources".

probinson added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:144 +// includes the full path. +if (SM.getFilename(IL).contains("UnifiedSource")) { + StringRef Name = SM.getFilename(SL);

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

GBuella updated this revision to Diff 143642. https://reviews.llvm.org/D45984 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h

[libclc] r330649 - log10: Use sw implementation from amd builtins

Author: jvesely Date: Mon Apr 23 14:10:42 2018 New Revision: 330649 URL: http://llvm.org/viewvc/llvm-project?rev=330649=rev Log: log10: Use sw implementation from amd builtins Add missing table. Fixes log10d CTS on carrizo. Signed-off-by: Jan Vesely Acked-by: Aaron Watry

[PATCH] D45505: [GCC] Match a GCC version with a patch suffix without a third version component

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D45505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

GBuella updated this revision to Diff 143640. https://reviews.llvm.org/D44387 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/CodeGen/CGBuiltin.cpp lib/Headers/CMakeLists.txt lib/Headers/cpuid.h

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

craig.topper added inline comments. Comment at: docs/ClangCommandLineReference.rst:2465 +.. option:: -mmovdiri, -mno-movdiri + Please alphabetize this correctly. Comment at: include/clang/Basic/BuiltinsX86.def:1896

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

GBuella updated this revision to Diff 143639. GBuella added a comment. Rebased the patch. Added pconfig to Icelake Server. https://reviews.llvm.org/D44387 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h

[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor

rsmith added a comment. In https://reviews.llvm.org/D45382#1060452, @ahatanak wrote: > In https://reviews.llvm.org/D45382#1060163, @rjmccall wrote: > > > Hmm. I'm not actually sure *why* it's not okay to forward callee-cleanup > > arguments. Do we just not have the necessary logic to disable

[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3069 + if (hasAggregateEvaluationKind(type) && + getContext().isParamDestroyedInCallee(type)) { +EHScopeStack::stable_iterator cleanup = I wonder if this is something we should be

[PATCH] D45985: [test] Add a testcase for MinGW sysroot detections from SVN r330244. NFC.

mstorsjo created this revision. mstorsjo added reviewers: rnk, compnerd, martell. After having a look at some similar tests, adding a proper testcase for this feature didn't turn out to be all that bad after all. Repository: rC Clang https://reviews.llvm.org/D45985 Files:

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

dblaikie accepted this revision. dblaikie added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaExpr.cpp:11527-11528 - S.Diag(OpLoc, diag::warn_self_assignment) - << LHSDeclRef->getType() - << LHSExpr->getSourceRange() <<

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

GBuella created this revision. GBuella added a reviewer: craig.topper. Herald added subscribers: cfe-commits, mgorny. Repository: rC Clang https://reviews.llvm.org/D45984 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

lebedev.ri added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11527-11528 - S.Diag(OpLoc, diag::warn_self_assignment) - << LHSDeclRef->getType() - << LHSExpr->getSourceRange() << RHSExpr->getSourceRange(); + S.Diag(OpLoc, IsBuiltin ?

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE330637: [clangd] Implementation of workspace/symbol request (authored by malaperle, committed by ). Changed prior to commit: https://reviews.llvm.org/D44882?vs=143220=143626#toc Repository: rCTE

[clang-tools-extra] r330637 - [clangd] Implementation of workspace/symbol request

Author: malaperle Date: Mon Apr 23 13:00:52 2018 New Revision: 330637 URL: http://llvm.org/viewvc/llvm-project?rev=330637=rev Log: [clangd] Implementation of workspace/symbol request Summary: This is a basic implementation of the "workspace/symbol" request which is used to find symbols by a

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

dblaikie added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11527-11528 - S.Diag(OpLoc, diag::warn_self_assignment) - << LHSDeclRef->getType() - << LHSExpr->getSourceRange() << RHSExpr->getSourceRange(); + S.Diag(OpLoc, IsBuiltin ?

[PATCH] D45920: [analyzer] Move RangeSet related declarations into the RangedConstraintManager header.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D45920#1074437, @george.karpenkov wrote: > > I could also move RangedConstraintManager.h under include > > We probably don't want to do that: currently it can only be

[libcxx] r330636 - Revert "[libcxx] implement declarations based on P0214R7."

Author: timshen Date: Mon Apr 23 12:56:20 2018 New Revision: 330636 URL: http://llvm.org/viewvc/llvm-project?rev=330636=rev Log: Revert "[libcxx] implement declarations based on P0214R7." This reverts commit r330627. This causes several bots to freak out. Removed:

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

vsapsai added a comment. In https://reviews.llvm.org/D45015#1064930, @EricWF wrote: > In https://reviews.llvm.org/D45015#1064922, @vsapsai wrote: > > > Another approach is `__has_feature` but I don't think it is applicable in > > this case. > > > > Is there a way right now to detect that

[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor

ahatanak updated this revision to Diff 143624. ahatanak marked 2 inline comments as done. ahatanak added a comment. Address review comments. Repository: rC Clang https://reviews.llvm.org/D45382 Files: lib/CodeGen/CGCall.cpp lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGDecl.cpp

r330634 - [OPENMP] Formatting and code improvement, NFC.

Author: abataev Date: Mon Apr 23 12:53:05 2018 New Revision: 330634 URL: http://llvm.org/viewvc/llvm-project?rev=330634=rev Log: [OPENMP] Formatting and code improvement, NFC. Modified: cfe/trunk/lib/Parse/ParseOpenMP.cpp Modified: cfe/trunk/lib/Parse/ParseOpenMP.cpp URL:

[PATCH] D45839: [analyzer] Add support for WebKit "unified sources".

NoQ marked 2 inline comments as done. NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:145-147 + if (Name.endswith_lower(".c") || Name.endswith_lower(".cpp") || + Name.endswith_lower(".cc") ||

[PATCH] D45517: [analyzer] WIP: False positive refutation with Z3

NoQ added a comment. In https://reviews.llvm.org/D45517#1074422, @rnkovacs wrote: > In https://reviews.llvm.org/D45517#1074057, @NoQ wrote: > > > So, yeah, that's a good optimization that we're not invoking the solver on > > every node. But i don't think we should focus on improving this > >

Re: [PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

On Mon, Apr 23, 2018 at 11:53 AM, Andrew V. Tischenko via Phabricator via cfe-commits wrote: > avt77 added a comment. > > In https://reviews.llvm.org/D45619#1075437, @bjope wrote: > > > I can't see that it has been reverted. > > But I guess that the table maybe is

[PATCH] D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals

LegalizeAdulthood added inline comments. Comment at: test/clang-tidy/modernize-raw-string-literal.cpp:44 +char const *const MultibyteSnowman("\xE2\x98\x83"); +// CHECK-FIXES: {{^}}char const *const MultibyteSnowman("\xE2\x98\x83");{{$}} IIRC, the default

r330633 - Fix typo in comment.

Author: nico Date: Mon Apr 23 12:22:52 2018 New Revision: 330633 URL: http://llvm.org/viewvc/llvm-project?rev=330633=rev Log: Fix typo in comment. Modified: cfe/trunk/tools/libclang/CMakeLists.txt Modified: cfe/trunk/tools/libclang/CMakeLists.txt URL:

[PATCH] D45920: [analyzer] Move RangeSet related declarations into the RangedConstraintManager header.

NoQ added a comment. In https://reviews.llvm.org/D45920#1074439, @george.karpenkov wrote: > Another approach would be to instead teach `RangedConstraintManager` to > convert it's constraints to Z3. That would be an unwanted dependency, but the > change would be much smaller, and the internals

[PATCH] D45920: [analyzer] Move RangeSet related declarations into the RangedConstraintManager header.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/RangedConstraintManager.h:130 +template <> +struct ProgramStateTrait + : public ProgramStatePartialTrait { george.karpenkov wrote: > Why not also `REGISTER_TRAIT_WITH_PROGRAMSTATE` here? ``` 33

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

NoQ added a comment. Guys, what do you think about a checker that warns on uninitialized fields only when at least one field is initialized? I'd be much more confident about turning such check on by default. We can still keep a `pedantic` version. > I can say with confidence that CodeChecker

[PATCH] D45597: [Driver] Android triples are not aliases for other triples.

danalbert added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D45597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45292: [Driver] Obey computed sysroot when finding libc++ headers.

danalbert added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D45292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45291: [Driver] Infer Android sysroot location.

danalbert added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D45291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

joerg added a comment. Things are different for a libgcc-based toolchain and a compiler-rt based toolchain. Repository: rL LLVM https://reviews.llvm.org/D41240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41148: [libcxx] implement declarations based on P0214R7.

This revision was automatically updated to reflect the committed changes. Closed by commit rL330627: [libcxx] implement experimental/simd declarations based on P0214R7. (authored by timshen, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[libcxx] r330627 - [libcxx] implement declarations based on P0214R7.

Author: timshen Date: Mon Apr 23 11:47:07 2018 New Revision: 330627 URL: http://llvm.org/viewvc/llvm-project?rev=330627=rev Log: [libcxx] implement declarations based on P0214R7. Summary: The patch includes all declarations, and also implements the following features: * ABI. *

[PATCH] D41148: [libcxx] implement declarations based on P0214R7.

timshen updated this revision to Diff 143610. timshen added a comment. Update formatting on static_asserts. https://reviews.llvm.org/D41148 Files: libcxx/include/experimental/__config libcxx/include/experimental/simd libcxx/include/module.modulemap

r330626 - DR727: remove wrong assertion for use of class-scope explicit

Author: rsmith Date: Mon Apr 23 11:38:30 2018 New Revision: 330626 URL: http://llvm.org/viewvc/llvm-project?rev=330626=rev Log: DR727: remove wrong assertion for use of class-scope explicit specialization without -fms-extensions. Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp

[PATCH] D45715: [libcxx] [test] Remove nonportable that errc::is_a_directory produces "Is a directory" from ios_base::failure tests

BillyONeal added a comment. In https://reviews.llvm.org/D45715#1075665, @mclow.lists wrote: > - if there are similar tests in the filesystem test suite, and you haven't > tripped over them because you spelled your error message the same as we did. Almost certainly. But we aren't running your

[PATCH] D45865: [Sema] Emit -Warray-bounds for multiple levels of subscript expressions.

aaron.ballman added a reviewer: rsmith. aaron.ballman added inline comments. Comment at: lib/Sema/SemaChecking.cpp:11284 + case Stmt::MemberExprClass: { +const MemberExpr *ME = cast(expr); +expr = ME->getBase(); Can use `const auto *` here

r330622 - Improve checks in test/Frontend/ftime-report-template-decl.cpp

Author: bjope Date: Mon Apr 23 11:05:35 2018 New Revision: 330622 URL: http://llvm.org/viewvc/llvm-project?rev=330622=rev Log: Improve checks in test/Frontend/ftime-report-template-decl.cpp Some buildbots seems to have problems with the CHECKs in test/Frontend/ftime-report-template-decl.cpp. I

[PATCH] D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:70-72 + if (Bytes.find_if([](char C) { +return static_cast(C) > 0x7Fu; + }) != StringRef::npos) I think you can use `isASCII()` from CharInfo.h rather

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

dexonsmith added a comment. In https://reviews.llvm.org/D30882#1075589, @dexonsmith wrote: > In https://reviews.llvm.org/D30882#1075576, @pete wrote: > > > Would it be ok to turn this on by default, without a flag, only in the case > > of the path actually existing, and only the found path

[PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

bjope added a comment. buildbots have been failing all day (and were still failing). So I pushed my suggested fix. I hope that was OK. Repository: rL LLVM https://reviews.llvm.org/D45619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45451: [ItaniumMangle] Undeduced auto type doesn't belong in the substitution table

rjmccall added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2342 + if (isa(Ty)) +return false; return true; erik.pilkington wrote: > rjmccall wrote: > > rjmccall wrote: > > > rjmccall wrote: > > > > I agree with your analysis that this

[PATCH] D41148: [libcxx] implement declarations based on P0214R7.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Herald added a subscriber: bixia. This looks ready to land to me. Comment at: libcxx/test/std/experimental/simd/simd.traits/is_simd_mask.pass.cpp:122

[PATCH] D45715: [libcxx] [test] Remove nonportable that errc::is_a_directory produces "Is a directory" from ios_base::failure tests

mclow.lists added a comment. I'm fine with this change, but I'm wondering: - if there are similar tests in the filesystem test suite, and you haven't tripped over them because you spelled your error message the same as we did. - Should part of this test be moved into test/libcxx

r330620 - [OPENMP] Do not cast captured by value variables with pointer types in

Author: abataev Date: Mon Apr 23 10:33:41 2018 New Revision: 330620 URL: http://llvm.org/viewvc/llvm-project?rev=330620=rev Log: [OPENMP] Do not cast captured by value variables with pointer types in NVPTX target. When generating the wrapper function for the offloading region, we need to call

[PATCH] D45722: [X86] Lowering SAD (sum of absolute differences) intrinsics to native IR (clang side)

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8431 + CGF.Builder.CreateZExt(CGF.Builder.CreateShuffleVector( + AD, llvm::UndefValue::get(BTy), ShuffleMask), + VTy);

[PATCH] D45722: [X86] Lowering SAD (sum of absolute differences) intrinsics to native IR (clang side)

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8426 + llvm::Type *BTy = llvm::VectorType::get(CGF.Builder.getInt8Ty(), N * 8); + SmallVector ShuffleMask; + for (unsigned i = 0; i < N; ++i) Size the ShuffleMask to

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

dexonsmith added a comment. In https://reviews.llvm.org/D30882#1075576, @pete wrote: > Oh, that actually wasn't my intention when I wrote it. > > Honestly I didn't expect it to log anything for missing paths at all, as we > don't currently log all the missing (but attempted) paths for regular

[PATCH] D30882: Add a callback for __has_include and use it for dependency scanning

pete added a comment. In https://reviews.llvm.org/D30882#1075461, @dexonsmith wrote: > In https://reviews.llvm.org/D30882#1075407, @ddunbar wrote: > > > In https://reviews.llvm.org/D30882#1074822, @dexonsmith wrote: > > > > > I don't think this is quite right. I know at least `make`-based > >

[PATCH] D45917: Pass -Oz/-Os along to the backend

paquette updated this revision to Diff 143584. paquette added a comment. Add context to diff. https://reviews.llvm.org/D45917 Files: lib/CodeGen/BackendUtil.cpp test/CodeGen/arm64-outline.c Index: test/CodeGen/arm64-outline.c

r330613 - Quick fix for rC330605: specify a target arch for test

Author: a.sidorin Date: Mon Apr 23 09:38:29 2018 New Revision: 330613 URL: http://llvm.org/viewvc/llvm-project?rev=330613=rev Log: Quick fix for rC330605: specify a target arch for test Modified: cfe/trunk/test/Analysis/sval-dump-int128.c Modified:

[PATCH] D45965: [Targets] Implement getConstraintRegister for ARM and AArch64

thopre added inline comments. Comment at: lib/Basic/Targets/AArch64.h:85-89 + StringRef getConstraintRegister(StringRef Constraint, + StringRef Expression) const override { +return Expression; + } + From what I understood

[PATCH] D45763: [clangd][tests] Fix handling of EOF in delimited input

jkorous closed this revision. jkorous added a comment. I forgot to mention review in commit message. git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@330608 91177308-0d34-0410-b5e6-96231b3b80d8 https://reviews.llvm.org/D45763

[PATCH] D45764: [clangd][tests] Fix delimiter handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL330609: [clangd][tests] Fix delimiter handling (authored by jkorous, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit:

  1   2   >