[PATCH] D57838: [clang-cl] support /Oy- on aarch64

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57838/new/ https://reviews.llvm.org/D57838 ___

[PATCH] D54978: Move the SMT API to LLVM

lebedev.ri added subscribers: mehdi_amini, lebedev.ri. lebedev.ri added a comment. Looks like this (all all other related Z3 reviews - D54975 , D54976 , D54977 ) review has completely omitted

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

kees added a comment. In D56571#1386973 , @kees wrote: > Not sure if this is the fault of the LLVM half or the Clang half, but I'm > seeing mis-compilations in the current patches (llvm > ca1e713fdd4fab5273b36ba6f292a844fca4cb2d with D53765 >

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

apazos added a comment. If this is a target flag in GCC, shouldn't we make it a LLVM Target feature and pass it as -mattr, just like done for mrelax? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57497/new/ https://reviews.llvm.org/D57497

[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language

kristina added a comment. The patch itself looks sound. However given that you have a specific use case in mind (TableGen files) could you provide supplementary coverage for that specific use case (unit tests for formatting `td` syntax using

[PATCH] D57874: [WebAssembly] Set '-matomics' when '-pthread' is set

aheejin updated this revision to Diff 185700. aheejin added a comment. - Small fix Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 Files: lib/Frontend/CompilerInvocation.cpp test/Driver/wasm32-unknown-unknown.cpp

[PATCH] D57874: [WebAssembly] Set '-matomics' when '-pthread' is set

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, sbc100. Herald added a project: clang. In wasm, we always use '-matomics' when we use '-pthread'. This will make users type one less option and options will be

r353373 - Move the SMT API to LLVM

Author: mramalho Date: Wed Feb 6 19:19:45 2019 New Revision: 353373 URL: http://llvm.org/viewvc/llvm-project?rev=353373=rev Log: Move the SMT API to LLVM Moved everything SMT-related to LLVM and updated the cmake scripts. Differential Revision: https://reviews.llvm.org/D54978 Added:

[PATCH] D54978: Move the SMT API to LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rC353373: Move the SMT API to LLVM (authored by mramalho, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D54976: [analyzer] Got rid of the `Z3ConstraintManager` class

This revision was automatically updated to reflect the committed changes. Closed by commit rC353371: Got rid of the `Z3ConstraintManager` class (authored by mramalho, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D54977: [analyzer] Moved the whole SMT API to a single file. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353372: Moved the whole SMT API to a single file. NFC. (authored by mramalho, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

r353372 - Moved the whole SMT API to a single file. NFC.

Author: mramalho Date: Wed Feb 6 19:18:21 2019 New Revision: 353372 URL: http://llvm.org/viewvc/llvm-project?rev=353372=rev Log: Moved the whole SMT API to a single file. NFC. There is no advantage in having them in separate files, I doubt some will ever use them separately. This also makes

r353371 - Got rid of the `Z3ConstraintManager` class

Author: mramalho Date: Wed Feb 6 19:18:10 2019 New Revision: 353371 URL: http://llvm.org/viewvc/llvm-project?rev=353371=rev Log: Got rid of the `Z3ConstraintManager` class Now, instead of passing the reference to a shared_ptr, we pass the shared_ptr instead. I've also removed the check if Z3

r353370 - Generalised the SMT state constraints

Author: mramalho Date: Wed Feb 6 19:17:36 2019 New Revision: 353370 URL: http://llvm.org/viewvc/llvm-project?rev=353370=rev Log: Generalised the SMT state constraints This patch moves the ConstraintSMT definition to the SMTConstraintManager header to make it easier to move the Z3 backend

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

sammccall updated this revision to Diff 185690. sammccall added a comment. Herald added a project: clang. Update matching to use Inputs.ASTSelection. Cover some more cases of names (I think?) Handle under-qualified names as well as unqualified ones. The main benefit of this is it's a step closer

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

sammccall commandeered this revision. sammccall edited reviewers, added: ilya-biryukov; removed: sammccall. sammccall added a comment. (Grabbing this as discussed offline) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56610/new/ https://reviews.llvm.org/D56610

[PATCH] D57804: [opaque pointer types] Make EmitCall pass Function Types to CreateCall/Invoke.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353356: [opaque pointer types] Make EmitCall pass Function Types to (authored by jyknight, committed by ). Changed prior to commit: https://reviews.llvm.org/D57804?vs=185476=185678#toc Repository:

r353356 - [opaque pointer types] Make EmitCall pass Function Types to

Author: jyknight Date: Wed Feb 6 17:15:41 2019 New Revision: 353356 URL: http://llvm.org/viewvc/llvm-project?rev=353356=rev Log: [opaque pointer types] Make EmitCall pass Function Types to CreateCall/Invoke. Also, remove the getFunctionType() function from CGCallee, since it accesses the

[PATCH] D57801: [opaque pointer types] Pass through function types for TLS initialization and global destructor calls.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353355: [opaque pointer types] Pass through function types for TLS (authored by jyknight, committed by ). Changed prior to commit: https://reviews.llvm.org/D57801?vs=185467=185677#toc Repository: rC

r353355 - [opaque pointer types] Pass through function types for TLS

Author: jyknight Date: Wed Feb 6 17:14:17 2019 New Revision: 353355 URL: http://llvm.org/viewvc/llvm-project?rev=353355=rev Log: [opaque pointer types] Pass through function types for TLS initialization and global destructor calls. Differential Revision: https://reviews.llvm.org/D57801

[PATCH] D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, though I am by no means a gtest expert. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57322/new/ https://reviews.llvm.org/D57322 ___

[PATCH] D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. This looks reasonable to me but I don't have strong opinions on refactoring gtest tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57322/new/

[PATCH] D57619: [analyzer] Canonicalize variable declarations in VarRegion objects.

This revision was automatically updated to reflect the committed changes. Closed by commit rL353353: [analyzer] Canonicalize declarations within variable regions. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r353353 - [analyzer] Canonicalize declarations within variable regions.

Author: dergachev Date: Wed Feb 6 16:30:20 2019 New Revision: 353353 URL: http://llvm.org/viewvc/llvm-project?rev=353353=rev Log: [analyzer] Canonicalize declarations within variable regions. Memory region that correspond to a variable is identified by the variable's declaration and, in case of

[PATCH] D57797: Variable auto-init: fix __block initialization

rjmccall added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1643 CharUnits Size = getContext().getTypeSizeInChars(type); if (!Size.isZero()) { switch (trivialAutoVarInit) { jfb wrote: > rjmccall wrote: > > Can't you just drill to the

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

phosek added a comment. In D56305#1363417 , @carwil wrote: > Hi, we're currently working on similar functionality for the ARM backend, so > I got pointed to take a look at this patch. > Looks good to me, I quite like the tablegen improvements, but agree

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

phosek updated this revision to Diff 185667. phosek marked 2 inline comments as done. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56305/new/ https://reviews.llvm.org/D56305

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Herald added a project: clang. Validate whether the

r353350 - Revert "[analyzer] Remove the "postponed" hack, deal with derived symbols..."

Author: dergachev Date: Wed Feb 6 15:56:43 2019 New Revision: 353350 URL: http://llvm.org/viewvc/llvm-project?rev=353350=rev Log: Revert "[analyzer] Remove the "postponed" hack, deal with derived symbols..." This reverts commit r341722. The "postponed" mechanism turns out to be necessary in

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, kristof.beyls, whisperity, javed.absar. Herald added a project:

[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language

rupprecht added a comment. Herald added a project: clang. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56943/new/ https://reviews.llvm.org/D56943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus created this revision. Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, mgrang, szepet, whisperity. Herald added a project: clang. Here we go

[PATCH] D57852: [clang-tidy] Don't use assignment for value-initialized enums

malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, alexfh, JonasToth. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. The modernize-use-default-member-init check crashes when trying to create an assignment value for a

[PATCH] D57797: Variable auto-init: fix __block initialization

jfb marked 5 inline comments as done. jfb added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1642 CharUnits Size = getContext().getTypeSizeInChars(type); if (!Size.isZero()) { rjmccall wrote: > Does this check handle flexible arrays on

[PATCH] D57850: [analyzer] Emit an error rather than assert on invalid checker option input

teemperor resigned from this revision. teemperor added a comment. LGTM for the CloneChecker changes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57850/new/ https://reviews.llvm.org/D57850 ___ cfe-commits mailing

[PATCH] D57850: [analyzer] Emit an error rather than assert on invalid checker option input

Szelethus created this revision. Szelethus added reviewers: george.karpenkov, NoQ, xazax.hun, rnkovacs, baloghadamsoftware. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Herald added a reviewer: teemperor. Herald added a

[PATCH] D57230: [analyzer] Toning down invalidation a bit

NoQ added a comment. There seem to be a few regressions - weird memory leaks of inner objects in C++ destructors. Trying to investigate/reproduce. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57230/new/ https://reviews.llvm.org/D57230

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

vsk updated this revision to Diff 185642. vsk added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/CC1Options.td

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

vsk added reviewers: fedor.sergeev, philip.pfaffe. vsk added a comment. Thanks @hiraditya. I'd also like to get a +1 from someone who's worked on the NewPM infrastructure extensively, just to make sure those changes look ok. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

rsmith added inline comments. Comment at: lib/AST/Stmt.cpp:628 + DiagOffs = CurPtr-StrStart-1; + return diag::err_asm_invalid_operand_for_goto_labels; +} jyu2 wrote: > rsmith wrote: > > I'm curious why we're checking this here, when all

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang-tidy/bugprone/ArgumentCommentCheck.cpp:1 -//===--- ArgumentCommentCheck.cpp - clang-tidy ===// // aaron.ballman wrote: > Why

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

MyDeveloperDay updated this revision to Diff 185632. MyDeveloperDay marked 5 inline comments as done. MyDeveloperDay added a comment. -Address review comments -Ignore argument comment addition for macro inputs -Add unit tests to cover the above -Fix clang-tidy suggestion (from

[PATCH] D57740: [ASTImporter] Import every Decl in lambda record

shafik added a comment. LGTM although I wish we had more lambda tests. Please remember to check the LLDB build bots when landing the patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57740/new/ https://reviews.llvm.org/D57740

[PATCH] D57835: Fix -ftime-report with -x ir

arsenm added a comment. I partially solved the problem with double printing the reports. It's from this in cc1_main: // If any timers were active but haven't been destroyed yet, print theirp // results now. This happens in -disable-free mode. llvm::TimerGroup::printAll(llvm::errs());

[PATCH] D57838: [clang-cl] support /Oy- on aarch64

froydnj created this revision. froydnj added a reviewer: mstorsjo. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. MSVC supports /Oy- on aarch64, so clang-cl should too. Repository: rC Clang https://reviews.llvm.org/D57838 Files:

[PATCH] D57835: Fix -ftime-report with -x ir

arsenm created this revision. Herald added a subscriber: wdng. This was only printing the clang frontend timer, and none of the backend timers. Set the llvm global for enabling the backend time report when creating the frontend timers, rather than in the BackendConsumer constructor.

r353337 - [COFF, ARM64] Add ARM64 support for MS intrinsic _fastfail

Author: tomtan Date: Wed Feb 6 12:08:26 2019 New Revision: 353337 URL: http://llvm.org/viewvc/llvm-project?rev=353337=rev Log: [COFF, ARM64] Add ARM64 support for MS intrinsic _fastfail The MSDN document was also updated to reflect this, but it probably will take a few days to show in below

[PATCH] D57631: [COFF, ARM64] Add ARM64 support for MS intrinsic _fastfail

This revision was automatically updated to reflect the committed changes. Closed by commit rL353337: [COFF, ARM64] Add ARM64 support for MS intrinsic _fastfail (authored by TomTan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great stuff! Sorry for the delay here. Comment at: clangd/IncludeFixer.h:59 +SourceLocation Loc; // Start location of the unresolved name. +// Callback to get

[PATCH] D57831: AMDGPU: set wchar_t and wint_t to be unsigned short on windows

compnerd requested changes to this revision. compnerd added inline comments. This revision now requires changes to proceed. Comment at: lib/Basic/Targets/AMDGPU.cpp:263 MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64; +#if _WIN32 + WCharType = UnsignedShort;

[PATCH] D57831: AMDGPU: set wchar_t and wint_t to be unsigned short on windows

b-sumner added a comment. Maybe there are already other types like this, but it saddens me that an offline compiled code object could potentially not work properly if the application is using any of these types. Or should the runtime try to detect a problem using argument metadata? CHANGES

[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

tra added a comment. In D57829#1387416 , @yaxunl wrote: > In D57829#1387412 , @tra wrote: > > > Could you elaborate on why you want to disable this metadata? I think the > > original idea of llvm.linker.options

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! You should give @rsmith a few days in case he wants to express an opinion though. Comment at: lib/AST/Expr.cpp:2643-2645 + } + + else if (auto *GSE =

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

This revision was automatically updated to reflect the committed changes. Closed by commit rL353327: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604) (authored by lebedevri, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[clang-tools-extra] r353327 - [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

Author: lebedevri Date: Wed Feb 6 11:17:30 2019 New Revision: 353327 URL: http://llvm.org/viewvc/llvm-project?rev=353327=rev Log: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604) Summary: The check should ignore the main function, the program entry point. It is not possible

[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

yaxunl added a comment. In D57829#1387412 , @tra wrote: > Could you elaborate on why you want to disable this metadata? I think the > original idea of llvm.linker.options was that it should be ignored if the > back-end does not support it. If backend

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

lebedev.ri added a comment. In D57787#1387406 , @aaron.ballman wrote: > LGTM aside from a nit. Thank you for the review. Comment at: clang-tidy/modernize/AvoidCArraysCheck.cpp:35 + const clang::DeclContext *DC =

[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

tra added a comment. Could you elaborate on why you want to disable this metadata? I think the original idea of llvm.linker.options was that it should be ignored if the back-end does not support it. Comment at: lib/CodeGen/CodeGenModule.cpp:441 if (CodeGenOpts.Autolink &&

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

hiraditya accepted this revision. hiraditya added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 ___ cfe-commits mailing list

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit. Comment at: clang-tidy/modernize/AvoidCArraysCheck.cpp:36-38 + if (!FD) // If not a FunctionDecl, then certainly not main entry

[PATCH] D57831: AMDGPU: set wchar_t and wint_t to be unsigned short on windows

yaxunl created this revision. yaxunl added a reviewer: b-sumner. Herald added subscribers: t-tye, Anastasia, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. In MSVC wchar_t and wint_t are unsigned short. There is static_assert in MSVC headers checking that. Since HIP and OpenCL share the

[PATCH] D45978: dllexport const variables must have external linkage.

aaron.ballman added a comment. Can you add tests for C mode as well, as it seems the behavior differs there. Given: __declspec(dllexport) int const x = 3; __declspec(dllexport) const int y; extern int const z = 4; int main() { int a = x + y + z; return a; } I get:

[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. HIP toolchain does not support llvm.linker.options in device compilation, therefore disable it. https://reviews.llvm.org/D57829 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCUDA/linker-options.cu Index:

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

Quuxplusone added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2953 + "have bases of non-trivial class types|have virtual bases|" + "have __weak fields under ARC|have fields of non-trivial class types}0">; ahatanak wrote: >

[PATCH] D57787: [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

lebedev.ri updated this revision to Diff 185587. lebedev.ri marked 4 inline comments as done and an inline comment as not done. lebedev.ri added a comment. And back to `dyn_cast()`. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57787/new/

[PATCH] D57804: [opaque pointer types] Make EmitCall pass Function Types to CreateCall/Invoke.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Cool, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57804/new/ https://reviews.llvm.org/D57804

[PATCH] D57801: [opaque pointer types] Pass through function types for TLS initialization and global destructor calls.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Great (: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57801/new/ https://reviews.llvm.org/D57801

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r353320 - Test commit. NFC

Author: plyster Date: Wed Feb 6 10:18:02 2019 New Revision: 353320 URL: http://llvm.org/viewvc/llvm-project?rev=353320=rev Log: Test commit. NFC Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp URL:

r353318 - Switch to cantFail(), since it does the same assertion.

Author: srhines Date: Wed Feb 6 09:59:39 2019 New Revision: 353318 URL: http://llvm.org/viewvc/llvm-project?rev=353318=rev Log: Switch to cantFail(), since it does the same assertion. Reviewers: cfe-commits, lhames Reviewed By: lhames Subscribers: hintonda, klimek, pirama Differential

[PATCH] D36806: Switch to cantFail(), since it does the same assertion.

This revision was automatically updated to reflect the committed changes. Closed by commit rL353318: Switch to cantFail(), since it does the same assertion. (authored by srhines, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES

[PATCH] D57464: Generalize method overloading on addr spaces to C++

Anastasia marked an inline comment as done. Anastasia added a comment. Btw, if we would implement something like this: http://lists.llvm.org/pipermail/cfe-dev/2019-January/060798.html Would it allow you to switch to more generic address space attributes and therefore help to decrease diverging

[PATCH] D53928: Enable builtins necessary for SLEEF [AArch64] vectorized trigonometry libm functions

steleman updated this revision to Diff 185578. steleman added a comment. Herald added a project: clang. This is a small - but signifcant - update to the original changeset. What's new in this update: ${top_srcdir}/lib/Frontend/CompilerInvocation.cpp: When -fveclib=SLEEF was passed on

[PATCH] D57824: [OpenCL][PR40603] Align the use of extensions in C++ to be backwards compatible with OpenCL C v2.0

Anastasia created this revision. Anastasia added reviewers: svenvh, rjmccall. Herald added subscribers: ebevhan, jfb, yaxunl. One of the goal of C++ mode for OpenCL is to preserve backwards compatibility with OpenCL C v2.0! This patch aligns extensions! https://reviews.llvm.org/D57824 Files:

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

kees added a comment. I reduced the C code to this: volatile int mystery = 0; static int noinline demo(int klen) { int err; int len; err = mystery * klen; if (err) return err; if (len > klen) len =

[PATCH] D57815: [clangd] Add type boost to fuzzy find in Dex.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353310: [clangd] Add type boost to fuzzy find in Dex. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D57815?vs=18=185556#toc Repository: rCTE Clang

[PATCH] D57815: [clangd] Add type boost to fuzzy find in Dex.

ioeric updated this revision to Diff 18. ioeric added a comment. - revert unintended change. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57815/new/ https://reviews.llvm.org/D57815 Files: clangd/CodeComplete.cpp clangd/index/Index.cpp

[clang-tools-extra] r353310 - [clangd] Add type boost to fuzzy find in Dex.

Author: ioeric Date: Wed Feb 6 07:36:23 2019 New Revision: 353310 URL: http://llvm.org/viewvc/llvm-project?rev=353310=rev Log: [clangd] Add type boost to fuzzy find in Dex. Summary: No noticeable impact on code completions overall except some improvement on cross-namespace completion.

[PATCH] D57815: [clangd] Add type boost to fuzzy find in Dex.

ioeric updated this revision to Diff 185554. ioeric marked 4 inline comments as done. ioeric added a comment. - address comments plus some refactoring. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57815/new/ https://reviews.llvm.org/D57815 Files:

[clang-tools-extra] r353309 - [clangd] Bump vscode-clangd v0.0.11

Author: hokein Date: Wed Feb 6 07:29:54 2019 New Revision: 353309 URL: http://llvm.org/viewvc/llvm-project?rev=353309=rev Log: [clangd] Bump vscode-clangd v0.0.11 CHANGELOG: - activate the extension on ObjC files. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/package.json

[clang-tools-extra] r353306 - [clangd] Format tweak's replacements.

Author: hokein Date: Wed Feb 6 07:24:50 2019 New Revision: 353306 URL: http://llvm.org/viewvc/llvm-project?rev=353306=rev Log: [clangd] Format tweak's replacements. Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp clang-tools-extra/trunk/clangd/ClangdUnit.cpp

[PATCH] D57739: [clangd] Format tweak's replacements.

hokein updated this revision to Diff 185551. hokein added a comment. Remove accident change. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57739/new/ https://reviews.llvm.org/D57739 Files: clangd/ClangdServer.cpp clangd/ClangdUnit.cpp

[PATCH] D57739: [clangd] Format tweak's replacements.

hokein updated this revision to Diff 185550. hokein marked an inline comment as done. hokein added a comment. Address comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57739/new/ https://reviews.llvm.org/D57739 Files:

[PATCH] D57819: [clangd] Reduce number of threads used by BackgroundIndex to number of physical cores.

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. clangd is using as many threads as logical cores for BackgroundIndex by default. Due to hyper-threading this causes

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric updated this revision to Diff 185546. ioeric marked 15 inline comments as done. ioeric added a comment. - address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57021/new/ https://reviews.llvm.org/D57021 Files:

[PATCH] D54295: [WIP, RISCV] Add inline asm constraint A for RISC-V

jrtc27 requested changes to this revision. jrtc27 added inline comments. This revision now requires changes to proceed. Herald added a project: clang. Comment at: test/CodeGen/riscv-inline-asm.c:32 +// CHECK-LABEL: define void @test_A(i32* %p) +// CHECK: call void asm volatile

[PATCH] D57739: [clangd] Format tweak's replacements.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM! Also a few NITs. Comment at: clangd/ClangdServer.cpp:155 Opts.ClangTidyOpts = ClangTidyOptProvider->getOptions(File); + // FIXME: cache this +

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam added a comment. > That seems like a reasonable place to try, to me. Ok. Let's see if this does the trick. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45978/new/ https://reviews.llvm.org/D45978 ___ cfe-commits mailing

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam updated this revision to Diff 185541. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45978/new/ https://reviews.llvm.org/D45978 Files: lib/Sema/SemaDecl.cpp test/Sema/dllexport-1.cpp test/Sema/dllexport-2.cpp Index: test/Sema/dllexport-2.cpp

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

riccibruno updated this revision to Diff 185539. riccibruno added a comment. Go back to using `dyn_cast`s. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57267/new/ https://reviews.llvm.org/D57267 Files: include/clang/AST/Expr.h lib/AST/Expr.cpp Index:

[PATCH] D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals

aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/ArgumentCommentCheck.cpp:228-236 +static bool isStringLiteral(const Expr *Arg) { + const auto *Cast = dyn_cast(Arg); + return Cast ? isa(Cast->getSubExpr()) : false; +} + +static bool isNullPtrLiteral(const

[PATCH] D57815: [clangd] Add type boost to fuzzy find in Dex.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/Index.h:457 std::vector ProximityPaths; - - // FIXME(ibiryukov): add expected type to the request. + /// Preferred types of symbols.

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

kees added a comment. Not sure if this is the fault of the LLVM half or the Clang half, but I'm seeing mis-compilations in the current patches (llvm ca1e713fdd4fab5273b36ba6f292a844fca4cb2d with D53765 .185490 and clang 01879634f01bdbfac4636ebe03b68e85b20cd664

[PATCH] D57814: [clangd] Update dev dependencies of clangd-vscode

This revision was automatically updated to reflect the committed changes. Closed by commit rL353296: [clangd] Update dev dependencies of clangd-vscode (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r353296 - [clangd] Update dev dependencies of clangd-vscode

Author: ibiryukov Date: Wed Feb 6 05:53:24 2019 New Revision: 353296 URL: http://llvm.org/viewvc/llvm-project?rev=353296=rev Log: [clangd] Update dev dependencies of clangd-vscode Summary: The version bumps are a result of running `npm audit`, which found 3 security issues in previous versions

[PATCH] D57815: [clangd] Add type boost to fuzzy find in Dex.

ioeric created this revision. ioeric added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. No noticeable impact on code completions overall except some improvement on cross-namespace completion.

[PATCH] D57813: [clangd] Enable clangd on Objective-C in VSCode

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353295: [clangd] Enable clangd on Objective-C in VSCode (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D57813?vs=185518=185534#toc Repository: rCTE Clang

[PATCH] D57814: [clangd] Update dev dependencies of clangd-vscode

ilya-biryukov added a comment. In D57814#1386902 , @hokein wrote: > This patch updates **dev** dependencies, please correct the commit title to > avoid confusion :) Done, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] r353295 - [clangd] Enable clangd on Objective-C in VSCode

Author: ibiryukov Date: Wed Feb 6 05:47:49 2019 New Revision: 353295 URL: http://llvm.org/viewvc/llvm-project?rev=353295=rev Log: [clangd] Enable clangd on Objective-C in VSCode Summary: Thanks to Andreas Ostermeyer for raising this on the mailing list. Reviewers: hokein Reviewed By: hokein

[PATCH] D57739: [clangd] Format tweak's replacements.

hokein added inline comments. Comment at: clangd/refactor/Tweak.h:56 +/// The style to format generated changes. +format::FormatStyle Style; }; ilya-biryukov wrote: > NIT: Maybe make this a second argument of `apply`? > This would convey the idea that

  1   2   >