[PATCH] D46140: [coroutines] Add std::experimental::task type

lewissbaker marked an inline comment as done. lewissbaker added a comment. Gentle ping. Is there anything else people would like to see changed? Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46140/new/ https://reviews.llvm.org/D46140

[PATCH] D60417: [libunwind] Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)

jeremfg added a comment. In D60417#1458778 , @mstorsjo wrote: > The change looks sensible to me, but should we maybe even skip the `#if` > altogether? If the files uses unified syntax and can't be parsed in thumb > mode otherwise, there's maybe no need

[PATCH] D59987: Add support for detection of devtoolset-8

tstellar added a comment. In D59987#1454543 , @rpopescu wrote: > In D59987#1454422 , @tstellar wrote: > > > Do you have commit access? > > > Hi Tom, I don't think that I do. I have created the account just before

[PATCH] D60432: [clang][ASTContext] Simplify caching for declaration-related comments

jkorous created this revision. jkorous added reviewers: gribozavr, arphaman, dexonsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. - I assume we can cache comments for canonical declarations only, not for every redeclaration. - Caching that we didn't find comments

[PATCH] D60279: [CUDA] Implemented _[bi]mma* builtins.

tra updated this revision to Diff 194226. tra added a comment. - Converted class to struct+function as Tim suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60279/new/ https://reviews.llvm.org/D60279 Files: clang/include/clang/Basic/BuiltinsNVPTX.def

[PATCH] D60429: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto.

tcwang created this revision. tcwang added a project: LLVM. Herald added subscribers: llvm-commits, cfe-commits, jsji, MaskRay, kbarton, kristof.beyls, arichardson, javed.absar, nemanjai, emaste. Herald added a reviewer: espindola. Herald added a project: clang. This enables -mcrypto and

r357957 - [clang-format] Add AfterCaseLabel to BraceWrapping

Author: owenpan Date: Mon Apr 8 16:36:25 2019 New Revision: 357957 URL: http://llvm.org/viewvc/llvm-project?rev=357957=rev Log: [clang-format] Add AfterCaseLabel to BraceWrapping Fixes PR38686 llvm-svn: 52527 Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst

[PATCH] D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping

owenpan added a comment. @MyDeveloperDay : > do you happen to know if this script is run by the build or is supposed to be > run by the developer after making the change to Format.h I believe the developer must run it manually. > If the latter, then I reckon the two are out of sync, perhaps I

[PATCH] D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping

owenpan updated this revision to Diff 194219. owenpan added a reviewer: reuk. owenpan added a comment. Thank you to all for reviewing this revision! Here is the update that addresses all of your comments. (Also added @reuk to the reviewer list per @MyDeveloperDay 's suggestion.) Repository:

r357952 - Revert "[MS] Add metadata for __declspec(allocator)"

Author: akhuang Date: Mon Apr 8 15:46:41 2019 New Revision: 357952 URL: http://llvm.org/viewvc/llvm-project?rev=357952=rev Log: Revert "[MS] Add metadata for __declspec(allocator)" This reverts commit e7bd735bb03a7b8141e32f7d6cb98e8914d8799e. Reverting because of buildbot failure. Removed:

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

morehouse added a comment. This patch caused the Windows sanitizer bot to break: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/44238 Please take a look. FAILED: projects/compiler-rt/lib/fuzzer/tests/FuzzerTestObjects.gtest-all.cc.x86_64.o cmd.exe /C "cd /D

[PATCH] D60379: Make precompiled headers reproducible

riccibruno added a comment. In D60379#1458799 , @thakis wrote: > In D60379#1458668 , @riccibruno > wrote: > > > After looking at the bug report (https://bugs.debian.org/877359), I would > > like to point out that

r357940 - [ASTImporter] Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

Author: shafik Date: Mon Apr 8 13:50:21 2019 New Revision: 357940 URL: http://llvm.org/viewvc/llvm-project?rev=357940=rev Log: [ASTImporter] Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName Summary: https://reviews.llvm.org/D51633 added error handling

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

This revision was automatically updated to reflect the committed changes. Closed by commit rC357940: [ASTImporter] Call to HandleNameConflict in VisitEnumDecl mistakeningly using… (authored by shafik, committed by ). Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D60379: Make precompiled headers reproducible

sylvestre.ledru added a comment. To be clear, this isn't about format stability and distributing but making sure that two same runs of clang produces the same output. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60379/new/ https://reviews.llvm.org/D60379

[PATCH] D57965: Clean up ObjCPropertyDecl printing

This revision was automatically updated to reflect the committed changes. Closed by commit rL357937: Clean up ObjCPropertyDecl printing (authored by dgoldman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

r357937 - Clean up ObjCPropertyDecl printing

Author: dgoldman Date: Mon Apr 8 12:52:45 2019 New Revision: 357937 URL: http://llvm.org/viewvc/llvm-project?rev=357937=rev Log: Clean up ObjCPropertyDecl printing Summary: - `@property(attr, attr2)` instead of `@property ( attr,attr2 )`. - Change priority of attributes (see code/comments

[PATCH] D60379: Make precompiled headers reproducible

thakis added a comment. In D60379#1458668 , @riccibruno wrote: > After looking at the bug report (https://bugs.debian.org/877359), I would > like to point out that there is currently *absolutely* no stability guarantee > for the serialization format

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman updated this revision to Diff 194195. dgoldman added a comment. Herald added a subscriber: dexonsmith. - Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965 Files: lib/AST/DeclPrinter.cpp

[PATCH] D60418: inline asm: Don't copy llvm::MemoryBuffers when showing diagnostics

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:2355 + // XXX so comment is handled before pp directive is done, so no linetable + // entry yet when the handler runs. if (ParsingPreprocessorDirective || CurPtr ==

[PATCH] D60417: [libunwind] Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)

mstorsjo added reviewers: ldionne, EricWF, mclow.lists. mstorsjo added a comment. Herald added a subscriber: dexonsmith. The change looks sensible to me, but should we maybe even skip the `#if` altogether? If the files uses unified syntax and can't be parsed in thumb mode otherwise, there's

[PATCH] D60418: inline asm: Don't copy llvm::MemoryBuffers when showing diagnostics

thakis created this revision. thakis added reviewers: rnk, rsmith. This fixes one TODO and one FIXME in ConvertBackendLocation() about not copying llvm::MemoryBuffers when converting from from llvm::SMDiagnostics to clang::Diagnostics. The basic idea is to use

[PATCH] D60417: [libunwind] Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)

jeremfg created this revision. jeremfg added a reviewer: mstorsjo. Herald added subscribers: libcxx-commits, ldionne, kristof.beyls, javed.absar. I'm a first time contributor to LLVM... While attempting to compile the assembly files ( .S) for a Cortex-M4 device using GCC's arm-none-eabi, I

r357933 - [OPENMP] Sync __kmpc_alloc/_kmpc_free function with the runtime.

Author: abataev Date: Mon Apr 8 12:06:42 2019 New Revision: 357933 URL: http://llvm.org/viewvc/llvm-project?rev=357933=rev Log: [OPENMP] Sync __kmpc_alloc/_kmpc_free function with the runtime. Functions __kmpc_alloc/__kmpc_free are updated with the new interfaces. Patch synchronizes the

[PATCH] D60379: Make precompiled headers reproducible

riccibruno added a comment. After looking at the bug report (https://bugs.debian.org/877359), I would like to point out that there is currently *absolutely* no stability guarantee for the serialization format (ie, you need the exact same revision). In regard of this I am wondering how sane it

[PATCH] D60379: Make precompiled headers reproducible

riccibruno added inline comments. Comment at: lib/Serialization/ASTWriter.cpp:4283 + // Sort to allow reproducible .pch files - https://bugs.debian.org/877359 + std::map> sortedOpenCLTypeExtMap; for (const auto : SemaRef.OpenCLTypeExtMap) { lebedev.ri

r357928 - [MS] Add metadata for __declspec(allocator)

Author: akhuang Date: Mon Apr 8 10:58:29 2019 New Revision: 357928 URL: http://llvm.org/viewvc/llvm-project?rev=357928=rev Log: [MS] Add metadata for __declspec(allocator) Summary: Emit !heapallocsite in the metadata for calls to functions marked with __declspec(allocator). Eventually this will

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

This revision was automatically updated to reflect the committed changes. Closed by commit rL357928: [MS] Add metadata for __declspec(allocator) (authored by akhuang, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D60379: Make precompiled headers reproducible

lebedev.ri added inline comments. Comment at: lib/Serialization/ASTWriter.cpp:4283 + // Sort to allow reproducible .pch files - https://bugs.debian.org/877359 + std::map> sortedOpenCLTypeExtMap; for (const auto : SemaRef.OpenCLTypeExtMap) { Anastasia

[PATCH] D60379: Make precompiled headers reproducible

Anastasia added inline comments. Comment at: lib/Serialization/ASTWriter.cpp:4283 + // Sort to allow reproducible .pch files - https://bugs.debian.org/877359 + std::map> sortedOpenCLTypeExtMap; for (const auto : SemaRef.OpenCLTypeExtMap) { lebedev.ri

[PATCH] D59985: [OpenCL] Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Great! Thanks! Comment at: lib/CodeGen/CGBuiltin.cpp:3709 + llvm::Value *EventWaitList = nullptr; + if (E->getArg(4)->isNullPointerConstant( +

[PATCH] D60237: [MS] Add metadata for __declspec(allocator)

akhuang updated this revision to Diff 194164. akhuang marked 2 inline comments as done. akhuang added a comment. Fixes to test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60237/new/ https://reviews.llvm.org/D60237 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D60302: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of named metadata.

rjmccall added a comment. Will the ARC-contract pass recognize both, or are you adding a BC upgrader that rewrites the global metadata into a module flag? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60302/new/ https://reviews.llvm.org/D60302

r357924 - [X86] Add some fp to integer conversion intrinsics to Sema::CheckX86BuiltinRoundingOrSAE so their rounding controls will be checked.

Author: ctopper Date: Mon Apr 8 10:05:57 2019 New Revision: 357924 URL: http://llvm.org/viewvc/llvm-project?rev=357924=rev Log: [X86] Add some fp to integer conversion intrinsics to Sema::CheckX86BuiltinRoundingOrSAE so their rounding controls will be checked. If we don't check this in the

[PATCH] D60406: Move the builtin headers to use the new license file header.

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60406/new/ https://reviews.llvm.org/D60406

r357923 - [OPENMP][NVPTX]Fixed processing of memory management directives.

Author: abataev Date: Mon Apr 8 09:53:57 2019 New Revision: 357923 URL: http://llvm.org/viewvc/llvm-project?rev=357923=rev Log: [OPENMP][NVPTX]Fixed processing of memory management directives. Added special processing of the memory management directives/clauses for NVPTX target. For private

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

vsk added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r357922 - Remove a bogus sed option in test.

Author: alexfh Date: Mon Apr 8 09:34:38 2019 New Revision: 357922 URL: http://llvm.org/viewvc/llvm-project?rev=357922=rev Log: Remove a bogus sed option in test. Modified: cfe/trunk/test/Tooling/clang-check-fixit.cpp Modified: cfe/trunk/test/Tooling/clang-check-fixit.cpp URL:

r357921 - Remove a useless assertion in clang-check.

Author: alexfh Date: Mon Apr 8 09:29:43 2019 New Revision: 357921 URL: http://llvm.org/viewvc/llvm-project?rev=357921=rev Log: Remove a useless assertion in clang-check. Re-commit r357915 with a fix for windows. The assertion prevents it from applying fixes when used along with compilation

[PATCH] D59746: [LibTooling] Fix '-h' option

hintonda added a comment. In D59746#1458461 , @hintonda wrote: > In D59746#1458432 , @klimek wrote: > > > If we make it an alias by default, can somebody overwrite that? > > > Unfortunately, that produces a runtime

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet marked 2 inline comments as done. Violet added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2895 // function and isn't necessarily referring to one of FD's parameters. - if (FD->getParamDecl(i) == PV) + if (i <

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel updated this revision to Diff 194157. ymandel added a comment. Add `operator()` to Stencil for compatability with TextGenerator. Stencil is technically independent of Transformer. However, Transformers replacements and explanations take a generic std::function (there abbreviated as

r357918 - Revert rL357915 from cfe/trunk: Remove a useless assertion in clang-check.

Author: rksimon Date: Mon Apr 8 08:49:19 2019 New Revision: 357918 URL: http://llvm.org/viewvc/llvm-project?rev=357918=rev Log: Revert rL357915 from cfe/trunk: Remove a useless assertion in clang-check. The assertion prevents it from applying fixes when used along with compilation databases

[PATCH] D60055: Check i < FD->getNumParams() before querying

lebedev.ri added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2895 // function and isn't necessarily referring to one of FD's parameters. - if (FD->getParamDecl(i) == PV) + if (i < FD->getNumParams() && FD->getParamDecl(i) == PV)

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet updated this revision to Diff 194152. Violet added a comment. Address reviewer comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 Files: clang/lib/Sema/SemaTemplateInstantiate.cpp

[PATCH] D59746: [LibTooling] Fix '-h' option

hintonda added a comment. In D59746#1458432 , @klimek wrote: > In D59746#1458424 , @hintonda wrote: > > > In D59746#1458086 , @klimek wrote: > > > > > In D59746#1440756

[PATCH] D60409: [clangd] Add -header-insertion=never flag to disable include insertion in code completion

ioeric added a comment. lg! Comment at: clangd/CodeComplete.cpp:1176 // This is available after Sema has run. - llvm::Optional Inserter; // Available during runWithSema. + llvm::Optional Inserter; // Optional during runWithSema. llvm::Optional FileProximity; //

[PATCH] D60362: [clang-format] [PR39719] clang-format converting object-like macro to function-like macro

klimek added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2467-2470 + if (Line.InPPDirective && Right.is(tok::l_paren) && + !Left.is(tok::identifier) && Left.Previous && + Left.Previous->is(tok::identifier) && Left.Previous->Previous && +

[PATCH] D60409: [clangd] Add -header-insertion=never flag to disable include insertion in code completion

sammccall created this revision. sammccall added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. One clear use case: use with an editor that reacts poorly to edits above the cursor. Repository:

[PATCH] D60055: Check i < FD->getNumParams() before querying

lebedev.ri added inline comments. Comment at: clang/test/SemaCXX/PR41139.cpp:3 + +// expected-no-diagnostics + Add a comment what this test does? ('just checking that the crash does not happen again') Comment at:

[PATCH] D59924: [PowerPC][Clang] Port MMX intrinsics and basic test cases to Power

jsji requested changes to this revision. jsji added a comment. This revision now requires changes to proceed. Since we are adding new headers that is not originated by this patch, please also update the description (and commit message) to include who actually contributed to `mmintrin.h` and

[PATCH] D59746: [LibTooling] Fix '-h' option

klimek added a comment. In D59746#1458424 , @hintonda wrote: > In D59746#1458086 , @klimek wrote: > > > In D59746#1440756 , @hintonda > > wrote: > > > > > A better

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

alexfh added a comment. In D59135#1458265 , @thorsten-klein wrote: > Hello @alexfh , > Let me extend your example > > $ cat a.cc > #include "b.h" > #include "d.h" > int main(){check(nullptr);} > $ cat b.h > #include "c.h" > inline void

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet added a comment. PING ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59746: [LibTooling] Fix '-h' option

hintonda added a comment. In D59746#1458086 , @klimek wrote: > In D59746#1440756 , @hintonda wrote: > > > A better alternative would have been to add a cl::aliasopt for '-h' in > > llvm's CommandLineParser when

r357917 - [python, tests] Disable Clang Python tests on SPARC

Author: ro Date: Mon Apr 8 08:01:06 2019 New Revision: 357917 URL: http://llvm.org/viewvc/llvm-project?rev=357917=rev Log: [python, tests] Disable Clang Python tests on SPARC Running `make check-all` fails on Solaris 11/SPARC since the clang python tests FAIL:

[PATCH] D60046: [python, tests] Disable Clang Python tests on SPARC

This revision was automatically updated to reflect the committed changes. Closed by commit rC357917: [python, tests] Disable Clang Python tests on SPARC (authored by ro, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60046/new/

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel created this revision. ymandel added a reviewer: ilya-biryukov. Herald added a subscriber: jfb. Herald added a project: clang. This revision allows users to specify independent changes to multiple (related) sections of the input. Previously, only a single section of input could be

[PATCH] D60046: [python, tests] Disable Clang Python tests on SPARC

ro added a comment. In D60046#1458399 , @mgorny wrote: > Thanks, looks good. Do you have commit access or do you need me to commit it > for you? I do have commit access, so I'll do it myself. Thanks. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357916: [clangd] Add fallback mode for code completion when compile command or preamble… (authored by ioeric, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[clang-tools-extra] r357916 - [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

Author: ioeric Date: Mon Apr 8 07:53:16 2019 New Revision: 357916 URL: http://llvm.org/viewvc/llvm-project?rev=357916=rev Log: [clangd] Add fallback mode for code completion when compile command or preamble is not ready. Summary: When calling TUScehduler::runWithPreamble (e.g. in code

[PATCH] D60046: [python, tests] Disable Clang Python tests on SPARC

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks, looks good. Do you have commit access or do you need me to commit it for you? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60046/new/

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59811/new/ https://reviews.llvm.org/D59811

[PATCH] D60046: [python, tests] Disable Clang Python tests on SPARC

ro added a comment. In D60046#1456034 , @mgorny wrote: > Just add it to the regex above. Done now. Initially I tried to check if it's also the ffi issue, until I noticed that some targets were skipped there for different reasons. I cannot check

[PATCH] D60046: [python, tests] Disable Clang Python tests on Solaris/SPARC

ro updated this revision to Diff 194144. ro added a comment. Skip SPARC like other targets. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60046/new/ https://reviews.llvm.org/D60046 Files: bindings/python/tests/CMakeLists.txt Index:

r357915 - Remove a useless assertion in clang-check.

Author: alexfh Date: Mon Apr 8 07:18:26 2019 New Revision: 357915 URL: http://llvm.org/viewvc/llvm-project?rev=357915=rev Log: Remove a useless assertion in clang-check. The assertion prevents it from applying fixes when used along with compilation databases with relative paths. Added a test

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

ioeric updated this revision to Diff 194141. ioeric marked 11 inline comments as done. ioeric added a comment. - address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59811/new/ https://reviews.llvm.org/D59811 Files:

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

ioeric added inline comments. Comment at: clangd/TUScheduler.cpp:881 + // asynchronous mode, as TU update should finish before this is run. + if (!It->second->Worker->isFirstPreambleBuilt() && + Consistency == StaleOrAbsent && PreambleTasks) { sammccall

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

This revision was automatically updated to reflect the committed changes. Closed by commit rC357913: Changed every use of ASTImporter::Import to Import_New (authored by balazske, committed by ). Changed prior to commit: https://reviews.llvm.org/D55049?vs=192110=194140#toc Repository: rC

r357913 - Changed every use of ASTImporter::Import to Import_New

Author: balazske Date: Mon Apr 8 06:59:15 2019 New Revision: 357913 URL: http://llvm.org/viewvc/llvm-project?rev=357913=rev Log: Changed every use of ASTImporter::Import to Import_New Reviewers: a.sidorin, shafik, martong, a_sidorin Reviewed By: a_sidorin Subscribers: rnkovacs, dkrupp,

[PATCH] D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check

DennisL updated this revision to Diff 194137. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60139/new/ https://reviews.llvm.org/D60139 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/PlacementNewTargetTypeMismatch.cpp

[PATCH] D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check

DennisL updated this revision to Diff 194136. DennisL retitled this revision from "[clang-tidy] Add misc-placement-new-target-type-mismatch check" to "[clang-tidy] Add bugprone-placement-new-target-type-mismatch check". DennisL added a comment. Removed debug output CHANGES SINCE LAST ACTION

[PATCH] D60139: [clang-tidy] Add misc-placement-new-target-type-mismatch check

DennisL updated this revision to Diff 194135. DennisL added a comment. The following has been updated: - moved check to bugprone instead of misc - more tests - rewritten check logic CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60139/new/ https://reviews.llvm.org/D60139 Files:

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

sammccall added inline comments. Comment at: unittests/clangd/ClangdTests.cpp:1082 + EXPECT_EQ(Res.Context, CodeCompletionContext::CCC_Recovery); + ASSERT_TRUE(Server.blockUntilIdleForTest()); + EXPECT_THAT(cantFail(runCodeComplete(Server, FooCpp, Code.point(),

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

sammccall added a comment. API looks good. Implementation looks like it can be simplified a bit, unless I'm missing something. Comment at: clangd/CodeComplete.h:117 + /// (e.g. preamble is still being built). + bool AllowFallbackMode = false; }; nit:

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

ioeric updated this revision to Diff 194132. ioeric added a comment. - Fix unit test Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59811/new/ https://reviews.llvm.org/D59811 Files: clangd/ClangdServer.cpp clangd/CodeComplete.h

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

ioeric planned changes to this revision. ioeric added a comment. Oops, forgot to update tests... Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59811/new/ https://reviews.llvm.org/D59811 ___ cfe-commits

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

ioeric added inline comments. Comment at: clangd/TUScheduler.h:204 + Callback Action, + bool AllowFallback = false); ilya-biryukov wrote: > sammccall wrote: > > I think this isn't orthogonal to `PreambleConsistency`.

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

ioeric updated this revision to Diff 194129. ioeric marked 3 inline comments as done. ioeric added a comment. - split out the compile command change. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59811/new/ https://reviews.llvm.org/D59811 Files:

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev added a comment. Fix hashing update: https://reviews.llvm.org/D60404 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58675/new/ https://reviews.llvm.org/D58675 ___ cfe-commits mailing list

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

thorsten-klein added a comment. Hello @alexfh , Let me extend your example $ cat a.cc #include "b.h" #include "d.h" int main(){check(nullptr);} $ cat b.h #include "c.h" inline void b() { c(/*y=*/42); } $ cat c.h void c(int x); $ cat d.h inline char* check(char* buffer)

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

reuk closed this revision. reuk added a comment. Closed by https://reviews.llvm.org/rG91f60b44958f, https://reviews.llvm.org/rL357908, https://reviews.llvm.org/rC357908 (sorry, I forgot to update the body of the commit message to close this automatically) CHANGES SINCE LAST ACTION

r357908 - [clang-format] Optionally insert a space after unary ! operator

Author: reuk Date: Mon Apr 8 05:54:48 2019 New Revision: 357908 URL: http://llvm.org/viewvc/llvm-project?rev=357908=rev Log: [clang-format] Optionally insert a space after unary ! operator Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst cfe/trunk/include/clang/Format/Format.h

[PATCH] D60316: [clangd] Include insertion: require header guards, drop other heuristics, treat .def like .inc.

ioeric added inline comments. Comment at: clangd/index/SymbolCollector.cpp:157 + return Canonical.str(); +else if (Canonical != Filename) + return toURI(SM, Canonical, Opts); nit: no need for `else`? Comment at:

[PATCH] D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping

MyDeveloperDay added a subscriber: reuk. MyDeveloperDay added a comment. @ownenpan might be worth checking with @reuk who has been adding some options for the JUCE style guide and looking at the JUCE code it seems this style might match their style. Comment at:

[PATCH] D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping

krasimir added inline comments. Comment at: include/clang/Format/Format.h:638 +/// \endcode +bool AfterCaseLabel; /// Wrap class definitions. This comment seems outdated (the one in `ClangFormatStyleOptions.rst` seems more recent). The

[PATCH] D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

klimek added inline comments. Comment at: cfe/trunk/docs/ClangFormatStyleOptions.rst:384 + + * ``SIS_WithoutElse`` (in configuration: ``WithoutElse``) +Allow short if functions on the same line, as long as else MyDeveloperDay wrote: > klimek wrote: > > Is

[PATCH] D59509: Make static constructors + destructors minsize + cold (except for in -O0)

jyknight added a comment. Looks reasonable to me. Comment at: clang/test/CodeGen/static-attr.cpp:4 + +// WITHOUT-NOT: cold minsize noinline +// WITH: define internal void @__cxx_global_var_init() [[ATTR:#[0-9]]] lebedev.ri wrote: > This is fragile, it may have

[PATCH] D60323: [clangd] Include compile command inference in fileStatus API

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clangd/GlobalCompilationDatabase.cpp:70 /*Output=*/""); + Result.Heuristic = "default flags for unknown file"; + return

[PATCH] D59744: Fix i386 ABI "__m64" type bug

RKSimon added inline comments. Comment at: test/CodeGen/x86_32-mmx-linux.c:2 +// RUN: %clang_cc1 -w -O2 -fblocks -triple i386-pc-linux-gnu -target-cpu pentium4 -emit-llvm -o %t %s +// RUN: FileCheck < %t %s + Test on more triples and add the test file to trunk

[PATCH] D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. In D59087#1456129 , @krasimir wrote: > I believe there is no such thing as an "short else statement". The `else` is > part of the `if` statement and if it is present, I

[PATCH] D46940: [ASTImporter] make sure that ACtx::getParents still works

r.stahl abandoned this revision. r.stahl added a comment. Herald added a reviewer: shafik. ASTContext::getParents should not be used this way. This use-case is solved by function-scoped ParentMaps or AnalysisDeclContext::getParentMap. Discussion:

[PATCH] D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

klimek added inline comments. Comment at: cfe/trunk/docs/ClangFormatStyleOptions.rst:384 + + * ``SIS_WithoutElse`` (in configuration: ``WithoutElse``) +Allow short if functions on the same line, as long as else Is that actually the status quo or is the

[PATCH] D59746: [LibTooling] Fix '-h' option

klimek added a comment. In D59746#1440756 , @hintonda wrote: > A better alternative would have been to add a cl::aliasopt for '-h' in llvm's > CommandLineParser when '-help' was first added. However, that's no longer > possible since some llvm based

[PATCH] D59756: [clangd] Support dependent bases in type hierarchy

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/unittests/clangd/TypeHierarchyTests.cpp:405 + *Result, + AllOf(WithName("S"), WithKind(SymbolKind::Struct), +Parents(AllOf(WithName("S"),

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55049/new/ https://reviews.llvm.org/D55049 ___

[PATCH] D60379: Make precompiled headers reproducible

sylvestre.ledru added a comment. I won't have time to write the test for that (and would not know where to start). I am just the messenger :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60379/new/ https://reviews.llvm.org/D60379

[PATCH] D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC.

alexfh added a comment. It looks like there's a number of users of this function beyond what you've mentioned: clang-tidy/readability/IsolateDeclarationCheck.cpp:210 clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:43 clang-tidy/readability/NamespaceCommentCheck.cpp:106

[PATCH] D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping

klimek accepted this revision. klimek added a comment. Apart from the typo I think this is a simple enough change and a widely enough used style that it LG. Comment at: lib/Format/UnwrappedLineParser.cpp:181 + CompoundStatementIndenter(UnwrappedLineParser *Parser, unsigned ,

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

klimek accepted this revision. klimek added a comment. lg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60320/new/ https://reviews.llvm.org/D60320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >