Re: r358104 - Don't emit an unreachable return block.

On 10 Apr 2019, at 21:50, wolfgang.p...@sony.com wrote: Hi, This commit seems to be causing a test failure on several buildbots (e.g. http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/26305). instrprof-shared-gcov-flush.test is failing because of differences in profile

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

hintonda updated this revision to Diff 194633. hintonda edited the summary of this revision. hintonda added a comment. - Fix bug in updateArgStr() where it didn't handle isInAllSubCommands() correctly, and refactored code based on how SubCommands work. Repository: rG LLVM Github Monorepo

[PATCH] D60409: [clangd] Add -header-insertion=never flag to disable include insertion in code completion

MaskRay added a comment. In D60409#1461579 , @phosek wrote: > Our Mac builders have started failing after this change with the following: > > [3145/3502] Building CXX object > tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o >

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

Ywicheng updated this revision to Diff 194631. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55411/new/ https://reviews.llvm.org/D55411 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/SafelyScopedCheck.cpp

[PATCH] D60552: Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake

liutianle created this revision. liutianle added reviewers: craig.topper, smaslov, LuoYuanke, wxiao3, annita.zhang. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. 1. Enable infrastructure of AVX512_BF16, which is supported for BFLOAT16 in Cooper Lake; 2. Enable

RE: r358104 - Don't emit an unreachable return block.

Hi, This commit seems to be causing a test failure on several buildbots (e.g. http://lab.llvm.org:8011/builders/clang-ppc64be-linux-lnt/builds/26305). instrprof-shared-gcov-flush.test is failing because of differences in profile info. The test passes when I revert your change, so perhaps it's

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

Ywicheng updated this revision to Diff 194623. Ywicheng marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55411/new/ https://reviews.llvm.org/D55411 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194622. Dosi-Dough added a comment. added white space to check doc. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194621. Dosi-Dough marked 2 inline comments as done. Dosi-Dough added a comment. added whitespace to check doc Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files:

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/abseil-wrap-unique.rst:5 +== +Looks for instances of factory functions which uses a non-public constructor +that returns a ``std::unqiue_ptr`` then recommends using ``absl::wrap_unique(new

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194618. Dosi-Dough marked 3 inline comments as done. Dosi-Dough added a comment. removed parens from turnary, added whitespace. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/

Re: Notice: The buildbot bb.pgr.jp will be suspended within a few days

Takumi, I am very sorry it took me almost 18 months to respond to this note. I'm sorry to see you had to shutter bb.pgr.jp. It was a very helpful resource to the community. Thank you very much for your contribution of effort and resources to make bb.pgr.jp available to the LLVM community for as

[PATCH] D55409: [clang-tidy] check for using declarations not in an anonymous namespace when there exists one

Naysh marked an inline comment as done. Naysh added inline comments. Comment at: clang-tidy/abseil/AnonymousEnclosedAliasesCheck.cpp:41 +// to the vector containing all candidate using declarations. +if (AnonymousNamespaceDecl) { +

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

Ywicheng updated this revision to Diff 194614. Ywicheng marked an inline comment as done. Ywicheng edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55411/new/ https://reviews.llvm.org/D55411 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D17407: [Sema] PR25755 Handle out of order designated initializers

hintonda added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17407/new/ https://reviews.llvm.org/D17407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang added a comment. If no more changes need to be made, is this okay to be merged in? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/WrapUniqueCheck.cpp:85 + +std::string Left = (ConsDecl) ? "auto " + NameRef.str() + " = " : ""; +std::string NewText = I don't think that you need round brackets around ConsDecl. Same

[PATCH] D60432: [clang][ASTContext] Simplify caching for declaration-related comments

jkorous updated this revision to Diff 194609. jkorous added a comment. rename RawCommentAndCacheFlags -> CommentAndOrigin CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60432/new/ https://reviews.llvm.org/D60432 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194608. Dosi-Dough added a comment. fixed docs and white spacing Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough updated this revision to Diff 194607. Dosi-Dough marked an inline comment as done. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D60432: [clang][ASTContext] Simplify caching for declaration-related comments

jkorous updated this revision to Diff 194604. jkorous added a comment. Second attempt on reducing the cache size and number of operations. I try in this order 1. cache lookup for the specific provided declaration 2. try to find comment attached to the specific provided declaration without

[PATCH] D60548: Variable auto-init: also auto-init alloca

jfb added a comment. One downside to alloca is that we can's use `__attribute__((uninitialized))` because it's a builtin. Maybe we need a separate uninitialized alloca? What do you all think? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60548/new/

[PATCH] D60548: Variable auto-init: also auto-init alloca

jfb created this revision. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. alloca isn’t auto-init’d right now because it’s a different path in clang that all the other stuff we support (it’s a builtin, not an expression). Interestingly, alloca doesn’t

[PATCH] D60432: [clang][ASTContext] Simplify caching for declaration-related comments

jkorous marked an inline comment as done. jkorous added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:372 D = adjustDeclToTemplate(D); + const Decl* CanonicalDecl = D->getCanonicalDecl(); gribozavr wrote: > jkorous wrote: > > arphaman wrote: >

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

hintonda added a comment. ping, and should we add new warning messages as suggested by @Rakete ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59754/new/ https://reviews.llvm.org/D59754 ___

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 

stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1479 +/// \endcode +AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOfInterface, + internal::Matcher, I am

[PATCH] D59121: [analyzer] Fix macro names in diagnostics within bigger macros.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59121/new/ https://reviews.llvm.org/D59121 ___ cfe-commits mailing

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 

stephanemoore created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stephanemoore added a reviewer: aaron.ballman. This change adds a new AST matcher to detect Objective-C classes that are subclasses of matching Objective-C interfaces. Test Notes: Ran

[PATCH] D60544: Support objc_nonlazy_class attribute on Objective-C implementations

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, aaron.ballman. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. Fixes rdar://49523079 Repository: rC Clang https://reviews.llvm.org/D60544 Files:

[PATCH] D60542: Add support for attributes on @implementations in Objective-C

erik.pilkington created this revision. erik.pilkington added reviewers: aaron.ballman, rjmccall. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. We want to make `objc_nonlazy_class` apply to implementations, but ran into this. There doesn't seem to be any reason

[PATCH] D60541: [clang-format] Use SpacesBeforeTrailingComments for "option" directive

dchai created this revision. dchai added a reviewer: krasimir. Herald added a project: clang. Herald added a subscriber: cfe-commits. AnnotatingParser::next() is needed to implicitly set TT_BlockComment versus TT_LineComment. On most other paths through AnnotatingParser::parseLine(), all tokens

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

Szelethus added a comment. Hmmm, interesting. Could there be an issue with `NoteTag` not being trivially destructible? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58367/new/ https://reviews.llvm.org/D58367

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus added inline comments. Comment at: docs/analyzer/checkers.rst:225-226 +``std::string``s, by recognizing member functions that may re/deallocate the buffer +before use. In the future, it would be great to add support for other STL and +non-STL containers, and most

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

Szelethus added a comment. Sorry, I rushed my earlier comment -- I definitely think that we should get rid of the `UINT_MAX` thing before landing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59555/new/ https://reviews.llvm.org/D59555

[PATCH] D60112: [analyzer] Treat write into a top-level parameter variable with destructor as escape.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Okay, I played around with this patch, I see now where this is going! LGTM! > Do you think i should document it somehow? Aye, the description you gave was enlightening, thanks! If you

[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Approved pending the LLVM side changes/discussion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59347/new/ https://reviews.llvm.org/D59347

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

dblaikie added a comment. In D59673#1460605 , @aaronpuchert wrote: > Ok, here is an idea. We introduce `-split-dwarf-output` in Clang instead of > `-fsplit-dwarf-dwo-name-attr`. If given, it overrides the output file name > for the Split DWARF file,

[PATCH] D60539: Add -std=c++14 language standard option to tests that require C++14 default

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Generally it's a good thing for our test suite to be robust against changes to Clang's default language mode. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60539/new/

[PATCH] D60539: Add -std=c++14 language standard option to tests that require C++14 default

amyk created this revision. amyk added reviewers: ilya-biryukov, sammccall, ioeric, hokein, akyrtzi, yvvan. amyk added projects: clang, LLVM. Herald added subscribers: kadircet, arphaman, dexonsmith, jkorous. On one of the platforms that we build on, we build with the CMake macro,

r358136 - Fix a test, NFC

Author: epilk Date: Wed Apr 10 14:18:21 2019 New Revision: 358136 URL: http://llvm.org/viewvc/llvm-project?rev=358136=rev Log: Fix a test, NFC This test was duplicated, and the last declaration had some syntax errors since the invalid attribute caused the @implementation to be skipped by the

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

dblaikie added a comment. In D59923#1460696 , @MaskRay wrote: > > is that to imply that the first block all do not use split DWARF? > > The first block do not use split DWARF. That doesn't sound like what I'd expect (& would represent a change in

[PATCH] D60055: Check i < FD->getNumParams() before querying

This revision was automatically updated to reflect the committed changes. Closed by commit rC358134: Check i FD-getNumParams() before querying (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D60055?vs=194152=194581#toc Repository: rC Clang CHANGES

r358134 - Check i < FD->getNumParams() before querying

Author: gribozavr Date: Wed Apr 10 13:25:07 2019 New Revision: 358134 URL: http://llvm.org/viewvc/llvm-project?rev=358134=rev Log: Check i < FD->getNumParams() before querying Summary: As was already stated in a previous comment, the parameter isn't necessarily referring to one of the

r358133 - [clang][ASTContext] Try to exit early before loading serialized comments from AST files

Author: jkorous Date: Wed Apr 10 13:23:33 2019 New Revision: 358133 URL: http://llvm.org/viewvc/llvm-project?rev=358133=rev Log: [clang][ASTContext] Try to exit early before loading serialized comments from AST files Loading external comments is expensive. This change probably doesn't apply to

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

rjmccall closed this revision. rjmccall added a comment. Committed as r358132. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60161/new/ https://reviews.llvm.org/D60161 ___ cfe-commits mailing list

r358132 - Add IRGen APIs to fetch ctor/dtor helper functions for non-trivial structs.

Author: rjmccall Date: Wed Apr 10 12:57:20 2019 New Revision: 358132 URL: http://llvm.org/viewvc/llvm-project?rev=358132=rev Log: Add IRGen APIs to fetch ctor/dtor helper functions for non-trivial structs. Patch by Tony Allevato! Modified: cfe/trunk/include/clang/CodeGen/CodeGenABITypes.h

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

rsmith added a comment. I expect that we get this wrong in the same way for all the `SemaDeclRefs` declarations (`StdNamespace`, `StdBadAlloc`, and `StdAlignValT`). I think the place where this is going wrong is `ASTDeclReader::findExisting`, which is assuming that the prior declaration for

RE: [clang-tools-extra] r358103 - clangd: fix the build with XPC

Hi Saleem, This fix does not seem to work on the PS4 linux build bot. Can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/46575 FAILED: tools/clang/tools/extra/clangd/fuzzer/CMakeFiles/clangd-fuzzer.dir/clangd-fuzzer.cpp.o /usr/bin/clang++

[clang-tools-extra] r358127 - clangd-fuzzer: repair the build

Author: compnerd Date: Wed Apr 10 12:16:14 2019 New Revision: 358127 URL: http://llvm.org/viewvc/llvm-project?rev=358127=rev Log: clangd-fuzzer: repair the build The inclusion of private headers of clangd percolates into the fuzzer. Modified:

r358126 - [OPENMP]Improve detection of number of teams, threads in target

Author: abataev Date: Wed Apr 10 12:11:33 2019 New Revision: 358126 URL: http://llvm.org/viewvc/llvm-project?rev=358126=rev Log: [OPENMP]Improve detection of number of teams, threads in target regions. Added more complex analysis for number of teams and number of threads in the target regions,

r358125 - Fix for different build configurations.

Author: rjmccall Date: Wed Apr 10 12:11:32 2019 New Revision: 358125 URL: http://llvm.org/viewvc/llvm-project?rev=358125=rev Log: Fix for different build configurations. Modified: cfe/trunk/test/CodeGen/unreachable-ret.c Modified: cfe/trunk/test/CodeGen/unreachable-ret.c URL:

[PATCH] D60263: [clang-format] Preserve include blocks in ObjC Google style

stephanemoore added a comment. Looks good to me. Comment at: cfe/trunk/lib/Format/Format.cpp:881 +// "Regroup" doesn't work well for ObjC yet (main header heuristic, +// relationship between ObjC standard library headers and other heades, +// #imports, etc.)

[PATCH] D60523: [clang] Bugfixe for 41400

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. this is a bugfixe for bugtracker added nullptr check at the relevent place and test Repository: rC Clang

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel updated this revision to Diff 194551. ymandel added a comment. tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59371/new/ https://reviews.llvm.org/D59371 Files: clang/include/clang/Tooling/Refactoring/Stencil.h

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel added a comment. Thanks for the review. I've changed most of the things with only a few open questions. PTAL. Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:45 + /// Evaluates this part to a string and appends it to `result`. + virtual llvm::Error

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel updated this revision to Diff 194550. ymandel added a comment. deleted some stray comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59371/new/ https://reviews.llvm.org/D59371 Files:

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel updated this revision to Diff 194549. ymandel marked 13 inline comments as done. ymandel added a comment. Responded to comments and added wrapper for Stencil::cat in stencil namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D58016: fixes copy constructor generation of classes containing 0-length arrays followed by exactly 1 trivial field (fixes #40682)

rjmccall closed this revision. rjmccall added a comment. Committed as r358115. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58016/new/ https://reviews.llvm.org/D58016 ___ cfe-commits mailing list

r358115 - Fix an off-by-one mistake in IRGen's copy-construction

Author: rjmccall Date: Wed Apr 10 11:07:18 2019 New Revision: 358115 URL: http://llvm.org/viewvc/llvm-project?rev=358115=rev Log: Fix an off-by-one mistake in IRGen's copy-construction special cases in the presence of zero-length arrays. Patch by Joran Bigalet! Modified:

[PATCH] D60513: [HIP] Use -mlink-builtin-bitcode to link device library

ashi1 accepted this revision. ashi1 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60513/new/ https://reviews.llvm.org/D60513 ___ cfe-commits mailing list

[PATCH] D59746: [LibTooling] Fix '-h' option

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1187 +// FIXME: This is needed, but not sure why. +updateArgStr(Opt, NewArg, ChosenSubCommand); +Opt->setArgStr(NewArg);

[clang-tools-extra] r358107 - build: add binary dir to the unittests

Author: compnerd Date: Wed Apr 10 10:25:14 2019 New Revision: 358107 URL: http://llvm.org/viewvc/llvm-project?rev=358107=rev Log: build: add binary dir to the unittests Missed part of the change to make clangd build on Darwin. Fixes the build after SVN r358103. Modified:

[PATCH] D60409: [clangd] Add -header-insertion=never flag to disable include insertion in code completion

phosek added a comment. Our Mac builders have started failing after this change with the following: [3145/3502] Building CXX object tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o FAILED: tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o

[PATCH] D59988: [PR41276] Generate address space cast of 'this' for objects attributed by an address space in C++

rjmccall added inline comments. Comment at: test/CodeGenCXX/address-space-of-this.cpp:9 +//CHECK: call void @_ZN6MyTypeC1Ei(%struct.MyType* addrspacecast (%struct.MyType addrspace(10)* @m to %struct.MyType*), i32 123) +MyType __attribute__((address_space(10))) m = 123;

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnhandledSelfAssignmentCheck.cpp:20 +void UnhandledSelfAssignmentCheck::registerMatchers(MatchFinder *Finder) { + + // We don't care about deleted, default or implicit operator

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

Szelethus added a comment. We agreed to disagree on the static function stuff -- it doesn't really matter, and I don't insist. I have no objections against this patch, great job! I won't formally accept to make it stand out a little more. Thanks! CHANGES SINCE LAST ACTION

[PATCH] D57072: Don't codegen an unreachable return block

rjmccall commandeered this revision. rjmccall edited reviewers, added: bmoody; removed: rjmccall. rjmccall added a comment. This revision now requires review to proceed. Committed as r358104, thanks for your patience. Repository: rC Clang CHANGES SINCE LAST ACTION

r358104 - Don't emit an unreachable return block.

Author: rjmccall Date: Wed Apr 10 10:03:09 2019 New Revision: 358104 URL: http://llvm.org/viewvc/llvm-project?rev=358104=rev Log: Don't emit an unreachable return block. Patch by Brad Moody. Added: cfe/trunk/test/CodeGen/unreachable-ret.c Modified: cfe/trunk/lib/CodeGen/CGCall.cpp

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

andrewjcg added a comment. Sorry for the delay. Just catching up on the code this covers, so apologies if the questions don't make sense. Comment at: lib/Sema/SemaDeclCXX.cpp:9214-9215 getStdNamespace()->setImplicit(true); +if (getLangOpts().Modules) +

[clang-tools-extra] r358103 - clangd: fix the build with XPC

Author: compnerd Date: Wed Apr 10 09:48:52 2019 New Revision: 358103 URL: http://llvm.org/viewvc/llvm-project?rev=358103=rev Log: clangd: fix the build with XPC `Transport.h` does not include `Features.inc`. However, since it is used in a subdirectory, it cannot directly include the header as

[PATCH] D59746: [LibTooling] Fix '-h' option

hintonda updated this revision to Diff 194539. hintonda added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. - Add DefaultOption logic. Still needs tests, but wanted to get early feedback on basic approach. Repository: rG LLVM Github Monorepo

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

allevato added a comment. Oh, and in case I need to mention this (I don't contribute to llvm/clang frequently), I don't have commit access so I'll need someone else to merge it in. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60161/new/

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60161/new/ https://reviews.llvm.org/D60161

[clang-tools-extra] r358098 - [clangd] Fix non-indexing of builtin functions like printf when the TU is C

Author: sammccall Date: Wed Apr 10 09:26:58 2019 New Revision: 358098 URL: http://llvm.org/viewvc/llvm-project?rev=358098=rev Log: [clangd] Fix non-indexing of builtin functions like printf when the TU is C Modified: clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

sbenza added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:45 + /// Evaluates this part to a string and appends it to `result`. + virtual llvm::Error eval(const ast_matchers::MatchFinder::MatchResult , + std::string

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

allevato marked 2 inline comments as done. allevato added a comment. Thanks for the review! This is ready to go on my end if there aren't any other comments. Comment at: clang/lib/CodeGen/CGNonTrivialStruct.cpp:845 + // actually use them (it overwrites them with the

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

allevato updated this revision to Diff 194530. allevato added a comment. - Rename generate* to get* and cleanup param names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60161/new/ https://reviews.llvm.org/D60161 Files:

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet updated this revision to Diff 194528. kadircet marked 10 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/new/ https://reviews.llvm.org/D59302 Files:

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet added inline comments. Comment at: clangd/Diagnostics.cpp:396 + for (llvm::StringRef Inc : IncludeStack) +OS << "In file included from: " << Inc << ":\n"; +} ilya-biryukov wrote: > kadircet wrote: > > ilya-biryukov wrote: >

[clang-tools-extra] r358094 - [clangd] Use #if CLANGD_BUILD_XPC because it may be defined as 0

Author: maskray Date: Wed Apr 10 08:45:54 2019 New Revision: 358094 URL: http://llvm.org/viewvc/llvm-project?rev=358094=rev Log: [clangd] Use #if CLANGD_BUILD_XPC because it may be defined as 0 Modified: clang-tools-extra/trunk/clangd/Transport.h Modified:

[clang-tools-extra] r358093 - clangd: repair the build after SVN r358091

Author: compnerd Date: Wed Apr 10 08:45:05 2019 New Revision: 358093 URL: http://llvm.org/viewvc/llvm-project?rev=358093=rev Log: clangd: repair the build after SVN r358091 Fix the name of the variable being checked. NFCI. Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp

[PATCH] D59692: [ASTImporter] Fix name conflict handling

martong added a comment. Ping @a_sidorin @shafik Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59692/new/ https://reviews.llvm.org/D59692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59692: [ASTImporter] Fix name conflict handling

martong updated this revision to Diff 194527. martong marked an inline comment as done. martong added a comment. - Put back the call to GetOriginalDecl Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59692/new/ https://reviews.llvm.org/D59692 Files:

[PATCH] D59746: [LibTooling] Fix '-h' option

jhenderson added a comment. Just chiming in from a LLVM binutils developer perspective. Some of the binutils are missing -h as an alias, when they really should have it for compatibility (specifically I checked llvm-nm and llvm-symbolizer). As a result, a solution that auto-adds -h as an alias

[PATCH] D60516: [LTO] Add plumbing to save stats during LTO on MacOS.

fhahn created this revision. fhahn added reviewers: anemet, tejohnson, thegameg. Herald added subscribers: cfe-commits, dang, dexonsmith, steven_wu, hiraditya, inglorion, mehdi_amini. Herald added projects: clang, LLVM. Gold and ld on Linux already support saving stats, but the infrastructure is

[PATCH] D60503: [clangd] Don't insert extra namespace qualifiers when Sema gets lost.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358091: [clangd] Dont insert extra namespace qualifiers when Sema gets lost. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[clang-tools-extra] r358091 - [clangd] Don't insert extra namespace qualifiers when Sema gets lost.

Author: sammccall Date: Wed Apr 10 08:16:54 2019 New Revision: 358091 URL: http://llvm.org/viewvc/llvm-project?rev=358091=rev Log: [clangd] Don't insert extra namespace qualifiers when Sema gets lost. Summary: There are cases where Sema can't tell that "foo" in foo::Bar is a namespace qualifier,

[PATCH] D60513: [HIP] Use -mlink-builtin-bitcode to link device library

yaxunl created this revision. yaxunl added reviewers: tra, ashi1. Herald added a subscriber: jdoerfert. Use -mlink-builtin-bitcode instead of llvm-link to link device library so that device library bitcode and user device code can be compiled in a consistent way. This is the same approach used

[PATCH] D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64

manojgupta added a comment. In D60472#1461351 , @peter.smith wrote: > > Is that not a limitation of the build system? I'd expect a package to be able > to locally override a global default rather than vice-versa. Although crypto > might be the area

[PATCH] D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64

manojgupta added a comment. In D60472#1461351 , @peter.smith wrote: > > Is that not a limitation of the build system? I'd expect a package to be able > to locally override a global default rather than vice-versa. Although crypto > might be the area

[PATCH] D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64

peter.smith added a comment. In D60472#1461336 , @manojgupta wrote: > The motivation for this change is to make "crypto" setting an additive option > e.g. like "-mavx" used in many media packages. Some packages in Chrome want > to enable crypto

[PATCH] D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64

manojgupta added a comment. The motivation for this change is to make "crypto" setting an additive option e.g. like "-mavx" used in many media packages. Some packages in Chrome want to enable crypto conditionally for a few files to allow crypto feature to be used based on runtime cpu

r358087 - clang-cl: Fix parsing of the /F option (PR41405)

Author: hans Date: Wed Apr 10 07:27:47 2019 New Revision: 358087 URL: http://llvm.org/viewvc/llvm-project?rev=358087=rev Log: clang-cl: Fix parsing of the /F option (PR41405) Modified: cfe/trunk/include/clang/Driver/CLCompatOptions.td cfe/trunk/test/Driver/cl-options.c Modified:

[PATCH] D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64

peter.smith added a comment. I'm not in favour of adding AArch64 support to -mcrypto -mnocrypto for a few reasons: - Arm are trying to keep the options for controlling target features as consistent as possible with GCC and this option isn't supported in GCC

[PATCH] D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64

DavidSpickett added a comment. What's the motivation for this change, are you working towards common flags for both platforms? The current way to select crypto on AArch64 is '-march=armv8.x-a+crypto/nocrypto'. I can see that would be an issue if Power PC doesn't support that syntax, or doesn't

[PATCH] D60055: Check i < FD->getNumParams() before querying

gribozavr added a comment. I'd be happy to land it, but I do want @rsmith to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 ___ cfe-commits

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet added a comment. Thanks. Can you land it for me? I'm a newcommer without landing privilege. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 ___

[PATCH] D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check

DennisL updated this revision to Diff 194505. DennisL marked an inline comment as done. DennisL added a comment. Changed the following - addressed reviewer feedback - fetch the placement parameter as written - add further test cases as requested - stylistic changes - add nothrow parameter

[PATCH] D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check

DennisL marked 12 inline comments as done. DennisL added a comment. In D60139#1460233 , @JonasToth wrote: > Hey Dennis, > > my 2cents on the check. I think it is very good to have! Did you check coding > guidelines if they say something to this issue?

  1   2   >