[PATCH] D60362: [clang-format] [PR39719] clang-format converting object-like macro to function-like macro

owenpan added a comment. Actually, there is a neater way: https://reviews.llvm.org/D60853 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60362/new/ https://reviews.llvm.org/D60362 ___ cfe-commits mailing list

[PATCH] D60853: clang-format incorrectly inserts a space after a macro function name that is a keyword

owenpan created this revision. owenpan added reviewers: klimek, djasper, reuk, russellmcc, sammccall, MyDeveloperDay. owenpan added a project: clang. Herald added a subscriber: cfe-commits. See https://bugs.llvm.org/show_bug.cgi?id=39719 and discussion: https://reviews.llvm.org/D60362

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

hintonda added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:69 + IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)), + IgnoreListInit(Options.get("IgnoreListInit", false)) {} hintonda wrote: > axzhang wrote: > >

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

hintonda added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:69 + IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)), + IgnoreListInit(Options.get("IgnoreListInit", false)) {} axzhang wrote: > hintonda wrote: > >

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang marked an inline comment as done. axzhang added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:69 + IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)), + IgnoreListInit(Options.get("IgnoreListInit", false)) {}

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

hintonda added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:69 + IgnoreMacros(Options.getLocalOrGlobal("IgnoreMacros", true)), + IgnoreListInit(Options.get("IgnoreListInit", false)) {} You’re setting it false here.

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang marked an inline comment as done. axzhang added a comment. I'm having some issues with the AbseilTidyModule options. I am storing IgnoreListInit as true for the abseil-make-unique check, but when I run the check it shows IgnoreListInit as being false. Any ideas why this is happening?

[PATCH] D60848: [Parser] Avoid correcting delayed typos in array subscript multiple times.

vsapsai created this revision. vsapsai added reviewers: rsmith, erik.pilkington, majnemer. Herald added subscribers: dexonsmith, jkorous. We correct some typos in `ActOnArraySubscriptExpr` and `ActOnOMPArraySectionExpr`, so when their result is `ExprError`, we can end up correcting delayed typos

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

Ywicheng updated this revision to Diff 195661. Ywicheng marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55411/new/ https://reviews.llvm.org/D55411 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 updated this revision to Diff 195660. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/vector.c test/CodeGen/x86_32-arguments-darwin.c test/CodeGen/x86_32-arguments-linux.c

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 updated this revision to Diff 195659. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/x86_32-arguments-linux.c test/CodeGen/x86_32-mmx-linux.c Index: test/CodeGen/x86_32-mmx-linux.c

[PATCH] D55409: [clang-tidy] check for using declarations not in an anonymous namespace when there exists one

Ywicheng updated this revision to Diff 195656. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55409/new/ https://reviews.llvm.org/D55409 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/AnonymousEnclosedAliasesCheck.cpp

r358633 - Split out modules-specific declaration handling from SemaDecl.cpp into a

Author: rsmith Date: Wed Apr 17 17:57:02 2019 New Revision: 358633 URL: http://llvm.org/viewvc/llvm-project?rev=358633=rev Log: Split out modules-specific declaration handling from SemaDecl.cpp into a new SemaModule.cpp. Added: cfe/trunk/lib/Sema/SemaModule.cpp Modified:

r358632 - Add '#pragma clang __debug module_map module.name' to dump the module

Author: rsmith Date: Wed Apr 17 17:57:01 2019 New Revision: 358632 URL: http://llvm.org/viewvc/llvm-project?rev=358632=rev Log: Add '#pragma clang __debug module_map module.name' to dump the module map being used for the module 'module.name'. Modified:

r358631 - [c++2a] Improve diagnostic for use of declaration from another TU's

Author: rsmith Date: Wed Apr 17 17:56:58 2019 New Revision: 358631 URL: http://llvm.org/viewvc/llvm-project?rev=358631=rev Log: [c++2a] Improve diagnostic for use of declaration from another TU's global module fragment. We know that the declaration in question should have been introduced by a

[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

NoQ planned changes to this revision. NoQ added a comment. In D60808#1469734 , @NoQ wrote: > Hmm, i think i'd love to know why doesn't the uninitialized variable checker > fire on the if-statement as farmed by the body farm: Passing arguments to this

r358630 - [clang-format] Remove unused Environment constructor.

Author: alexfh Date: Wed Apr 17 17:36:51 2019 New Revision: 358630 URL: http://llvm.org/viewvc/llvm-project?rev=358630=rev Log: [clang-format] Remove unused Environment constructor. Modified: cfe/trunk/lib/Format/TokenAnalyzer.h Modified: cfe/trunk/lib/Format/TokenAnalyzer.h URL:

[PATCH] D60362: [clang-format] [PR39719] clang-format converting object-like macro to function-like macro

owenpan added a comment. A more straightforward way, IMO, is to add to the `spaceRequiredBetween` function a separate `if` statement that returns false for the sequence of tokens: `#`, `define`, tok::identifier, and `(` Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

rsmith added a comment. In D60845#1470986 , @NoQ wrote: > Yup, i confirm that this improves discoverability of this feature :) Maybe it > deserves its own .rst doc, like FileCheck > , but for now

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

ssijaric added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1058 + + // 1. For return types <= 16 bytes, use the C return semantics. + richard.townsend.arm wrote: > Microsoft have updated the spec since this was written, it now says to check >

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

NoQ added a comment. Yup, i confirm that this improves discoverability of this feature :) Maybe it deserves its own .rst doc, like FileCheck , but for now doxygen seems to be the best source of truth on how to use -verify and i consult it

r358626 - Fix test on PS4 which defaults to gnu99 which does not emit the expected warnings.

Author: dyung Date: Wed Apr 17 17:00:06 2019 New Revision: 358626 URL: http://llvm.org/viewvc/llvm-project?rev=358626=rev Log: Fix test on PS4 which defaults to gnu99 which does not emit the expected warnings. Modified: cfe/trunk/test/Analysis/security-syntax-checks.c Modified:

r358627 - Move the implementation of getInnermostBlockDecl to the .cpp file to fix

Author: ahatanak Date: Wed Apr 17 17:00:16 2019 New Revision: 358627 URL: http://llvm.org/viewvc/llvm-project?rev=358627=rev Log: Move the implementation of getInnermostBlockDecl to the .cpp file to fix failing bots. Modified: cfe/trunk/include/clang/AST/DeclBase.h

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Thanks you! I really like live working examples, I hope not just me. Could you link https://github.com/llvm/llvm-project/blob/master/clang/test/Analysis/use-after-move.cpp as well as a

[PATCH] D60826: Clarify -Winfinite-recursion message

rsmith requested changes to this revision. rsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:64 def warn_infinite_recursive_function : Warning< - "all paths through this function will call

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

Dosi-Dough added a comment. Hi I was wondering if there were any other changes anyone recomends should be made to this revision? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435

[PATCH] D60845: [VerifyDiagnosticConsumer] Document -verify= in doxygen

jdenny created this revision. jdenny added reviewers: NoQ, Charusso, hfinkel, rsmith. Herald added a project: clang. Previously, it was only documented by `-cc1 -help`, so people weren't aware of it, as discussed in D60732 . Repository: rG LLVM Github Monorepo

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

rsmith added a comment. I think you're missing the enforcement of the rule that the same field name cannot be designated multiple times in a single //designated-initializer-list//. I'm fine with that being done separately (not as part of this patch), though. Comment at:

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

This revision was automatically updated to reflect the committed changes. Closed by commit rL358624: [Sema][ObjC] Dont warn about an implicitly retained self if the (authored by ahatanak, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r358624 - [Sema][ObjC] Don't warn about an implicitly retained self if the

Author: ahatanak Date: Wed Apr 17 16:14:44 2019 New Revision: 358624 URL: http://llvm.org/viewvc/llvm-project?rev=358624=rev Log: [Sema][ObjC] Don't warn about an implicitly retained self if the retaining block and all of the enclosing blocks are non-escaping. If the block implicitly retaining

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

richard.townsend.arm added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1058 + + // 1. For return types <= 16 bytes, use the C return semantics. + Microsoft have updated the spec since this was written, it now says to check for aggregate-ness,

[clang-tools-extra] r358621 - [clang-tidy] Don't issue cppcoreguidelines-macro-usage on builtin macros

Author: alexfh Date: Wed Apr 17 15:35:36 2019 New Revision: 358621 URL: http://llvm.org/viewvc/llvm-project?rev=358621=rev Log: [clang-tidy] Don't issue cppcoreguidelines-macro-usage on builtin macros Before the patch calling clang-tidy with -header-filter=.* -system-headers would result in a

[PATCH] D60186: Support CLANG_ENABLE_DEFAULT_PIE like gcc --enable-default-pie

jiangyi added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60186/new/ https://reviews.llvm.org/D60186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195644. gtbercea added a comment. - Update tests. - Move error check in sema. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

erik.pilkington accepted this revision. erik.pilkington added a comment. LGTM too, thanks! Comment at: lib/Sema/SemaDecl.cpp:13169 +do { + R = R || !CurBD->doesNotEscape(); + if (R) This can just be R = !CurBD->doesNotEscape(); Repository: rC

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

This revision was automatically updated to reflect the committed changes. Closed by commit rL358620: [clang-tidy] Add a check for [super self] in initializers  (authored by stephanemoore, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

ahatanak updated this revision to Diff 195639. ahatanak added a comment. Diagnose implicitly retained self in `ActOnFinishFunctionBody`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60736/new/ https://reviews.llvm.org/D60736 Files:

[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a couple of nits. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:582 +if (!L.hasValidLocation()) { + // Do we need to suppress our report

[PATCH] D60417: [libunwind] Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)

mclow.lists added a comment. I have no problem with this. Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60417/new/ https://reviews.llvm.org/D60417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap

riccibruno added a comment. By the way, I am wondering about how much this is tested. I did look quickly in `test/PCH` and it appears that there are only 3 (short) tests : `ocl_types.cl`, `opencl-extensions.cl` and `no-validate-pch`. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap

riccibruno created this revision. riccibruno added reviewers: Anastasia, lebedev.ri. riccibruno added a project: clang. Herald added subscribers: cfe-commits, mgrang, yaxunl. Sort the elements of `Sema::OpenCLTypeExtMap` and `Sema::OpenCLDeclExtMap` by `TypeID`s and `DeclID`s to guarantee a

[PATCH] D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map

riccibruno added a comment. What about something like D60835 ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60778/new/ https://reviews.llvm.org/D60778 ___ cfe-commits mailing list

Re: [PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

On Wed, Apr 17, 2019 at 05:34:04PM +, Kamil Rytarowski via Phabricator wrote: > Right now this blocks upgrades on NetBSD as a number of CPUs is affected (but > not x86, so it was overlooked before 8.0 by others than @joerg). Note that this is not about anything really specific to NetBSD,

[PATCH] D60417: [libunwind] Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. I'm relaying approval to @mstorsjo, who seems okay with the change. Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60417/new/

[PATCH] D60552: [X86] Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake

RKSimon added inline comments. Comment at: lib/Headers/avx512bf16intrin.h:23 + +static __inline__ __m512bh __DEFAULT_FN_ATTRS512 +_mm512_cvtne2ps_pbh(__m512 __A, __m512 __B) { All of these need proper doxygen based descriptions - see xmmintrin.h etc. for

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

sammccall added a comment. @kadircet if you're interested in the behavior here, you can patch this in and try out with vscode. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60605/new/ https://reviews.llvm.org/D60605

[PATCH] D60819: [clangd] Strip the ' [some-check-name]' suffix from clang-tidy diagnostics. The check name is reported in Diagnostic.code.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE358612: [clangd] Strip the [some-check-name] suffix from clang-tidy diagnostics. The… (authored by sammccall, committed by ). Changed prior to commit:

[clang-tools-extra] r358612 - [clangd] Strip the ' [some-check-name]' suffix from clang-tidy diagnostics. The check name is reported in Diagnostic.code.

Author: sammccall Date: Wed Apr 17 13:15:08 2019 New Revision: 358612 URL: http://llvm.org/viewvc/llvm-project?rev=358612=rev Log: [clangd] Strip the ' [some-check-name]' suffix from clang-tidy diagnostics. The check name is reported in Diagnostic.code. Reviewers: kadircet Subscribers:

[PATCH] D60822: [clangd] Use shorter, more recognizable codes for diagnostics.

sammccall added a comment. In D60822#1470227 , @kadircet wrote: > I agree that these are more useful. What about also adding "-W" in front of > warning flags to make them more explicit and stand out from "non-flag" error > names? I went back and forth

[PATCH] D60822: [clangd] Use shorter, more recognizable codes for diagnostics.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE358611: [clangd] Use shorter, more recognizable codes for diagnostics. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D60822?vs=195623=195624#toc

[clang-tools-extra] r358611 - [clangd] Use shorter, more recognizable codes for diagnostics.

Author: sammccall Date: Wed Apr 17 13:12:03 2019 New Revision: 358611 URL: http://llvm.org/viewvc/llvm-project?rev=358611=rev Log: [clangd] Use shorter, more recognizable codes for diagnostics. Summary: - for warnings, use the flag the warning is controlled by (-Wfoo) - for errors, keep using

[PATCH] D60822: [clangd] Use shorter, more recognizable codes for diagnostics.

sammccall updated this revision to Diff 195623. sammccall added a comment. -Wfoo instead of foo Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60822/new/ https://reviews.llvm.org/D60822 Files: clangd/Diagnostics.cpp

[PATCH] D59812: [analyzer] PR41185: Fix regression where __builtin_* functions weren't recognized

This revision was automatically updated to reflect the committed changes. Closed by commit rL358609: [analyzer] PR41185: Fix regression where __builtin_* functions werent… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D60417: [libunwind] Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax)

mstorsjo added a comment. In D60417#1464070 , @mstorsjo wrote: > In D60417#1459249 , @mstorsjo wrote: > > > Given that, the suggested form of this patch is indeed correct - sorry for > > the noise. > > > > I can

r358609 - [analyzer] PR41185: Fix regression where __builtin_* functions weren't recognized

Author: szelethus Date: Wed Apr 17 12:56:40 2019 New Revision: 358609 URL: http://llvm.org/viewvc/llvm-project?rev=358609=rev Log: [analyzer] PR41185: Fix regression where __builtin_* functions weren't recognized For the following code snippet: void builtin_function_call_crash_fixes(char *c) {

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:382 + if module == 'llvm' or module == 'clang': +namespace = module + '_checker' + else: hintonda wrote: > aaron.ballman wrote: > > I thought we were going with

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Alright, LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60736/new/ https://reviews.llvm.org/D60736 ___

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added a comment. Other tests in presence of the requires directive with the clause? Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8975 +CGM.Error(Clause->getBeginLoc(), + "Target region emitted before requires directive."); +

[PATCH] D59812: [analyzer] PR41185: Fix regression where __builtin_* functions weren't recognized

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Awesome, thanks! LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59812/new/ https://reviews.llvm.org/D59812 ___ cfe-commits mailing

[PATCH] D59812: [analyzer] PR41185: Fix regression where __builtin_* functions weren't recognized

Szelethus updated this revision to Diff 195619. Szelethus edited the summary of this revision. Szelethus added a comment. Uhh, sorry for the spam. Realized that these are not path sensitive checkers. Removed the core packages from the invocations. Actual logic of the patch is untouched.

[PATCH] D59812: [analyzer] PR41185: Fix regression where __builtin_* functions weren't recognized

Szelethus updated this revision to Diff 195617. Szelethus retitled this revision from "[analyzer] Detect usages of unsafe I/O functions - Bug fixing" to "[analyzer] PR41185: Fix regression where __builtin_* functions weren't recognized". Szelethus edited the summary of this revision. Szelethus

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

hintonda updated this revision to Diff 195611. hintonda added a comment. - Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59754/new/ https://reviews.llvm.org/D59754 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

hintonda updated this revision to Diff 195610. hintonda added a comment. - Removed auto and added specific warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59754/new/ https://reviews.llvm.org/D59754 Files:

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8975 +CGM.Error(Clause->getBeginLoc(), + "Target region emitted before requires directive."); + HasRequiresUnifiedSharedMemory =

[PATCH] D60719: Demonstrate how to fix freestanding for memcpy

t.p.northover added a comment. > IIUC freestanding environment should not rely on memcpy being present so my > take on it was that by "fixing" freestanding I could have my cake and eat it > too. The formal situation is that freestanding implementations are only required to provide language

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195609. gtbercea marked an inline comment as done. gtbercea added a comment. - Update error message. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files:

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195608. gtbercea marked an inline comment as done. gtbercea added a comment. - Add support for declare target routines. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files:

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/lib/Tooling/Refactoring/Stencil.cpp:78 + +template <> bool isEqualData(const RawTextData , const RawTextData ) { + return A.Text == B.Text; ymandel wrote: > sbenza wrote:

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel updated this revision to Diff 195606. ymandel added a comment. Convert template specialization to overload sets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59371/new/ https://reviews.llvm.org/D59371 Files:

[PATCH] D60815: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE358605: [clangd] Recognize dont include me directly pattern, and suppress include… (authored by sammccall, committed by ). Changed prior to commit:

[clang-tools-extra] r358605 - [clangd] Recognize "don't include me directly" pattern, and suppress include insertion.

Author: sammccall Date: Wed Apr 17 11:33:07 2019 New Revision: 358605 URL: http://llvm.org/viewvc/llvm-project?rev=358605=rev Log: [clangd] Recognize "don't include me directly" pattern, and suppress include insertion. Summary: Typically used with umbrella headers, e.g. GTK: #if !defined

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1479 +/// \endcode +AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOfInterface, + internal::Matcher, jordan_rose wrote: > aaron.ballman wrote: > > jordan_rose

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 

jordan_rose added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1479 +/// \endcode +AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOfInterface, + internal::Matcher, aaron.ballman wrote: > jordan_rose wrote: > > aaron.ballman

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1479 +/// \endcode +AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOfInterface, + internal::Matcher, jordan_rose wrote: > aaron.ballman wrote: > > jordan_rose

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 

jordan_rose added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1479 +/// \endcode +AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOfInterface, + internal::Matcher, aaron.ballman wrote: > jordan_rose wrote: > > aaron.ballman

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:127 + // Allow Stencils to operate as std::function, for compatibility with + // Transformer's TextGenerator. Calls `eval()` and asserts on failure. + std::string operator()(const

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

erik.pilkington added inline comments. Comment at: lib/Parse/ParseObjc.cpp:3696-3699 + + Actions.ActOnEndOfObjCMethodDef(); + // Clean up the remaining EOF token. Any reason not to do this check in `ActOnFinishFunctionBody` (which is called by

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

ymandel updated this revision to Diff 195602. ymandel marked 9 inline comments as done. ymandel added a comment. Responded to comments, including changing call operator to return Expected instead of string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1479 +/// \endcode +AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOfInterface, + internal::Matcher, jordan_rose wrote: > aaron.ballman wrote: > >

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 

jordan_rose added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1479 +/// \endcode +AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOfInterface, + internal::Matcher, aaron.ballman wrote: > stephanemoore wrote: > >

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek added a comment. In D59168#1469186 , @jdenny wrote: > Is there anything I can do to help this patch make progress? I think it's ready to land. I was just waiting if anyone else wants to chime in, but it doesn't seem like. I was also thinking

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

ahatanak updated this revision to Diff 195601. ahatanak marked an inline comment as done. ahatanak added a comment. Rename function. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60736/new/ https://reviews.llvm.org/D60736 Files: include/clang/AST/DeclBase.h

[PATCH] D60516: [LTO] Add plumbing to save stats during LTO on Darwin.

steven_wu added a comment. forgot to save the inline comments. Comment at: llvm/lib/LTO/LTOCodeGenerator.cpp:601 // If statistics were requested, print them out after codegen. - if (llvm::AreStatisticsEnabled()) + if (llvm::AreStatisticsEnabled() && !StatsFile)

[PATCH] D60516: [LTO] Add plumbing to save stats during LTO on Darwin.

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM with one additional small comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60516/new/ https://reviews.llvm.org/D60516

[PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

krytarowski added a comment. In D60728#1469794 , @hans wrote: > In D60728#1468713 , @krytarowski > wrote: > > > In D60728#1468486 , @hans wrote: > > > > > What's the value

[PATCH] D60516: [LTO] Add plumbing to save stats during LTO on Darwin.

tejohnson added a comment. LGTM with a minor fix needed below. Darwin still uses the old LTO API, which is why the lto Config based handling in the new LTO API (LTO.h/LTO.cpp) are not being used on this path. Comment at: llvm/lib/LTO/LTOCodeGenerator.cpp:101 +

[PATCH] D60691: [ARM] Replace fp-only-sp and d16 with fp64 and d32.

dmgreen added a comment. I don't think we here care about auto-updating, not supporting bitcode/lto libraries. Comment at: llvm/lib/Target/ARM/ARMFastISel.cpp:1362 + if (Ty->isDoubleTy() && (!Subtarget->hasVFP2Base() || !Subtarget->hasFP64())) + return false;

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

rjmccall added inline comments. Comment at: include/clang/AST/DeclBase.h:1798 + /// innermost enclosing BlockDecl or null if there are no enclosing blocks. + const BlockDecl *getInnerMostBlockDecl() const { +const DeclContext *Ctx = this; "innermost" is

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

hans added a comment. I don't really know about the functionality here, just adding a few comments on the code itself. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1966 + QualType PointeeTy = D.getTypePtr()->getPointeeType(); + llvm::DIType *DI = getOrCreateType(PointeeTy,

[PATCH] D60691: [ARM] Replace fp-only-sp and d16 with fp64 and d32.

ostannard edited reviewers, added: ostannard; removed: olista01. ostannard added a comment. For the auto-upgrader, these limited FPUs only exist for microcontrollers, where I doubt any users are keeping bitcode files around for a long time, so I'd be fine with not doing this. I've had a skim

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

keryell added a comment. In D60455#1470030 , @Anastasia wrote: > > I am not sure we need to add a keyword actually, the attribute can just be > added in AST since it's not supposed to be used in the source code? The attribute is used by the SYCL

[PATCH] D59371: [LibTooling] Add Stencil library for format-string style codegen.

sbenza added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:45 + /// Evaluates this part to a string and appends it to `result`. + virtual llvm::Error eval(const ast_matchers::MatchFinder::MatchResult , + std::string

[PATCH] D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map

Anastasia added a comment. In D60778#1470176 , @lebedev.ri wrote: > In D60778#1470152 , @Anastasia wrote: > > > In D60778#1468825 , @lebedev.ri > > wrote: > > > > > > Not

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

ahatanak added inline comments. Comment at: lib/Sema/SemaExpr.cpp:2580 +if (const BlockDecl *BD = CurContext->getInnerMostBlockDecl()) + if (!getDiagnostics().isIgnored(diag::warn_implicitly_retains_self, Loc)) +

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

ahatanak updated this revision to Diff 195589. ahatanak marked 2 inline comments as done. ahatanak added a comment. Remove a potentially expensive check. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60736/new/ https://reviews.llvm.org/D60736 Files:

[PATCH] D58236: Make address space conversions a bit stricter.

rjmccall accepted this revision. rjmccall added a comment. Alright, this seems reasonable to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58236/new/ https://reviews.llvm.org/D58236 ___ cfe-commits mailing list

r358595 - [OPENMP][NVPTX]Run combined constructs with if clause in SPMD mode.

Author: abataev Date: Wed Apr 17 09:53:08 2019 New Revision: 358595 URL: http://llvm.org/viewvc/llvm-project?rev=358595=rev Log: [OPENMP][NVPTX]Run combined constructs with if clause in SPMD mode. All target-parallel-based constructs can be run in SPMD mode from now on. Even if num_threads

[PATCH] D60818: [CUDA][Windows] restrict long double device functions declarations to Windows

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Thank you for cleaning this up. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60818/new/ https://reviews.llvm.org/D60818

[PATCH] D60828: [ARM] Fix armv8 features tree and add fp16fml

ostannard added a reviewer: simon_tatham. ostannard added inline comments. Comment at: lib/Basic/Targets/ARM.cpp:443 HasLegalHalfType = true; + HW_FP |= HW_FP_SP | HW_FP_DP | HW_FP_HP; + FPU |= VFP4FPU; Is it always correct to set HW_FP_DP here,

  1   2   >