[PATCH] D62926: [analyzer] ReturnVisitor: Bypass constructing objects to see inlined calls

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:842-849 + if (Optional CEE = Node->getLocationAs()) if (CEE->getCalleeContext()->getCallSite() == S) break; - if (auto SP = Node->getLocationAs()) -

[PATCH] D62952: [analyzer][tests] Use normalize_sarif in place of diff_sarif

hubert.reinterpretcast added a comment. @aaron.ballman, for similar cases in the plist output, it has been proposed - that the reference expected file be committed into the tree pre-normalized, and - that tool be modified such that the output file has a newline at the end of the file. Does

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast added a comment. I've tested the pre-normalization and it looks like I can commit it tomorrow. I noticed that the following three files appear to be unreferenced: clang/test/Analysis/Inputs/expected-plists/cstring-plist.c.plist

[PATCH] D63041: [PlistSupport] Produce a newline to end plist output files

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: NoQ, sfertile, xingxue, jasonliu, daltenty. Herald added a subscriber: jsji. Herald added a project: clang. As suggested in the review of D62949 , this patch updates the plist

Re: [PATCH] D61914: [Support][Test] Time profiler: add regression test

--target= Sent from ProtonMail Mobile On Fri, Jun 7, 2019 at 2:01 PM, Anton Afanasyev via Phabricator wrote: > anton-afanasyev marked an inline comment as done. > anton-afanasyev added a comment. > > In D61914#1534508 , @plotfi wrote: > >>

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

skan updated this revision to Diff 203664. skan added a comment. make macro more compact CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62115/new/ https://reviews.llvm.org/D62115 Files: lib/Frontend/HeaderIncludeGen.cpp test/Frontend/clang_H_opt.c Index:

[PATCH] D63029: [CUDA] Fix grep pattern in cuda-types.cu

hubert.reinterpretcast marked 3 inline comments as done. hubert.reinterpretcast added inline comments. Comment at: test/Preprocessor/cuda-types.cu:11 // RUN: %clang --cuda-host-only -nocudainc -target i386-unknown-linux-gnu -x cuda -E -dM -o - /dev/null \ -// RUN: | grep

[PATCH] D63029: [NFC][CUDA] Avoid undefined grep in cuda-types.cu

hubert.reinterpretcast updated this revision to Diff 203659. hubert.reinterpretcast added a comment. Fix grep pattern in cuda-types.cu As requested, further fix so that the `SIZEOF` and `WIDTH` macros are checked. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D63039: Various improvements to Clang MSVC Visualizers

mspertus created this revision. mspertus added reviewers: aaron.ballman, zturner. mspertus added a project: clang. Herald added a subscriber: cfe-commits. This change adds/improves MSVC visualizers for many Clang types, including array types, trailing return types in function, deduction guides,

r362856 - DebugInfo: Add support for 'nodebug' attribute on typedefs and alias templates

Author: dblaikie Date: Fri Jun 7 17:01:21 2019 New Revision: 362856 URL: http://llvm.org/viewvc/llvm-project?rev=362856=rev Log: DebugInfo: Add support for 'nodebug' attribute on typedefs and alias templates Seems like a logical extension to me - and of interest because it might help reduce the

[PATCH] D62885: [analyzer] Add werror flag for analyzer warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rL362855: [analyzer] Add werror flag for analyzer warnings (authored by kfischer, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r362855 - [analyzer] Add werror flag for analyzer warnings

Author: kfischer Date: Fri Jun 7 16:34:00 2019 New Revision: 362855 URL: http://llvm.org/viewvc/llvm-project?rev=362855=rev Log: [analyzer] Add werror flag for analyzer warnings Summary: We're using the clang static analyzer together with a number of custom analyses in our CI system to ensure

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D63031: DebugInfo: Render the canonical name of a class template specialization, even when nested in another class template specialization

dblaikie created this revision. dblaikie added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D63031 Files: lib/AST/TypePrinter.cpp lib/CodeGen/CGDebugInfo.cpp

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 203638. plotfi added a comment. -U99 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass constructing objects to see inlined calls

Charusso added a comment. In D62926#1533560 , @NoQ wrote: > I'd like to have a test in which the constructor is //inlined//. What do you mean by that test? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62926/new/

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass constructing objects to see inlined calls

Charusso updated this revision to Diff 203635. Charusso marked 2 inline comments as done. Charusso added a comment. - Added `CallExpr` as being purged away - More test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62926/new/ https://reviews.llvm.org/D62926 Files:

[PATCH] D63030: [WebAssembly] Modernize include path handling

sbc100 updated this revision to Diff 203634. sbc100 added a comment. - more OS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63030/new/ https://reviews.llvm.org/D63030 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp

[PATCH] D63030: [WebAssembly] Modernize include path handling

sbc100 created this revision. Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google, dschuff. Herald added a project: clang. Move include path construction from InitHeaderSearch::AddDefaultIncludePaths in the Driver which appears to be the more modern/correct way of doing

[PATCH] D63029: [NFC][CUDA] Avoid undefined grep in cuda-types.cu

hubert.reinterpretcast added inline comments. Comment at: test/Preprocessor/cuda-types.cu:11 // RUN: %clang --cuda-host-only -nocudainc -target i386-unknown-linux-gnu -x cuda -E -dM -o - /dev/null \ -// RUN: | grep 'define __[^ ]*\(TYPE\|MAX\|SIZEOF|WIDTH\)\|define

[PATCH] D63029: [NFC][CUDA] Avoid undefined grep in cuda-types.cu

tra added inline comments. Comment at: test/Preprocessor/cuda-types.cu:11 // RUN: %clang --cuda-host-only -nocudainc -target i386-unknown-linux-gnu -x cuda -E -dM -o - /dev/null \ -// RUN: | grep 'define __[^ ]*\(TYPE\|MAX\|SIZEOF|WIDTH\)\|define __GCC_ATOMIC' \ -// RUN:

[PATCH] D63029: [NFC][CUDA] Avoid undefined grep in cuda-types.cu

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: jlebar, daltenty, xingxue, jasonliu. Herald added subscribers: jsji, jfb. Herald added a project: clang. vertical-line is not a BRE special character. POSIX.1-2017 XBD Section 9.3.2 indicates that the

[PATCH] D61914: [Support][Test] Time profiler: add regression test

anton-afanasyev marked an inline comment as done. anton-afanasyev added a comment. In D61914#1534508 , @plotfi wrote: > cfe/trunk/test/Driver/check-time-trace.cpp appears to fail on Darwin. Did you > mean to pass the target explicitly ? This commit is

[PATCH] D62885: [analyzer] Add werror flag for analyzer warnings

Szelethus accepted this revision. Szelethus added a comment. Comment at: include/clang/Driver/CC1Options.td:170 +def analyzer_werror : Flag<["-"], "analyzer-werror">, + HelpText<"Emit analyzer results as errors, not warnings">; + how about "rather than

[PATCH] D60974: Clang IFSO driver action.

rupprecht added a reviewer: rupprecht. rupprecht added a comment. Can you upload this patch with context? Either use arc or upload w/ -U9 I seem to have a lot of comments, but they're all nits -- my major concern being the `llvm_unreachable`s should be errors instead (i.e. should be

r362836 - Relax test so that the clang binary doesn't need to be named "clang".

Author: pcc Date: Fri Jun 7 13:26:47 2019 New Revision: 362836 URL: http://llvm.org/viewvc/llvm-project?rev=362836=rev Log: Relax test so that the clang binary doesn't need to be named "clang". Modified: cfe/trunk/test/Driver/symbol-partition.c Modified:

[PATCH] D63018: [X86] Attempt to make the Intel core CPU inheritance a little more readable and maintainable

craig.topper updated this revision to Diff 203597. craig.topper added a comment. Fix mistake in a comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63018/new/ https://reviews.llvm.org/D63018 Files: clang/lib/Basic/Targets/X86.cpp Index: clang/lib/Basic/Targets/X86.cpp

[PATCH] D62962: Clang implementation of sizeless types

jfb added a comment. How do these types mangle? Comment at: test/Sema/sizeless-1.c:60 + (void)__atomic_is_lock_free(1, _int8); + (void)__atomic_always_lock_free(1, _int8); + What do you expect these to return? Repository: rC Clang CHANGES SINCE LAST

[PATCH] D63020: [HIP] Fix visibility for 'extern' device variables.

hliao created this revision. hliao added a reviewer: yaxunl. Herald added subscribers: cfe-commits, nhaehnle, jvesely. Herald added a project: clang. - Fix a bug which misses the change for a variable to be set with target-specific attributes. Repository: rG LLVM Github Monorepo

[PATCH] D61914: [Support][Test] Time profiler: add regression test

plotfi added inline comments. Comment at: cfe/trunk/test/Driver/check-time-trace.cpp:1 +// RUN: %clangxx -ftime-trace %s 2>&1 | grep "Time trace json-file dumped to" \ +// RUN: | awk '{print $NF}' | xargs cat \ This test should probably have // REQUIRES: shell

[PATCH] D61914: [Support][Test] Time profiler: add regression test

plotfi added a comment. cfe/trunk/test/Driver/check-time-trace.cpp appears to fail on Darwin. Did you mean to pass the target explicitly ? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61914/new/ https://reviews.llvm.org/D61914

r362830 - Revert "[CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods."

Author: vlad.tsyrklevich Date: Fri Jun 7 12:18:30 2019 New Revision: 362830 URL: http://llvm.org/viewvc/llvm-project?rev=362830=rev Log: Revert "[CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods." This reverts commit f1f6e0fc2468e9c120b22b939507c527d08b8ee8,

Re: r362785 - [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods.

This change caused LSan failures and has been reverted in r362830: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/32809 On Fri, Jun 7, 2019 at 2:42 AM Sam McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: sammccall > Date: Fri Jun 7 02:45:17 2019 > New

[PATCH] D62636: Driver, IRGen: Set partitions on GlobalValues according to -fsymbol-partition flag.

This revision was automatically updated to reflect the committed changes. pcc marked an inline comment as done. Closed by commit rL362829: Driver, IRGen: Set partitions on GlobalValues according to -fsymbol-partition… (authored by pcc, committed by ). Herald added a project: LLVM. Herald added a

r362829 - Driver, IRGen: Set partitions on GlobalValues according to -fsymbol-partition flag.

Author: pcc Date: Fri Jun 7 12:10:08 2019 New Revision: 362829 URL: http://llvm.org/viewvc/llvm-project?rev=362829=rev Log: Driver, IRGen: Set partitions on GlobalValues according to -fsymbol-partition flag. Differential Revision: https://reviews.llvm.org/D62636 Added:

[PATCH] D62636: Driver, IRGen: Set partitions on GlobalValues according to -fsymbol-partition flag.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Driver/Options.td:938 HelpText<"Disable C++ static destructor registration">; +def fsymbol_partition_EQ : Joined<["-"],

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

nickdesaulniers added inline comments. Comment at: clang-tools-extra/test/clang-tidy/linuxkernel-must-check-errs.c:6 +// Prototypes of the error functions. +void * __must_check ERR_PTR(long error); +long __must_check PTR_ERR(const void *ptr); Let's come up with

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast added a comment. In D62949#1533605 , @NoQ wrote: > Ok! I'll be happy to have this addressed incrementally. I think it should be safe to at least commit the pre-normalization directly first. I'll take a look, and update the patch

r362824 - Revert "[Support][Test] Time profiler: add regression test"

Author: anton-afanasyev Date: Fri Jun 7 11:35:58 2019 New Revision: 362824 URL: http://llvm.org/viewvc/llvm-project?rev=362824=rev Log: Revert "[Support][Test] Time profiler: add regression test" This reverts commit 44282a60c90fdded249d57d91b12c6c0907102ec. This breaks buildbot. Removed:

[PATCH] D62009: [clang] perform semantic checking in constant context

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, looks great. Comment at: clang/lib/Sema/SemaChecking.cpp:13941 /// +/// \param isConstantEvaluated wether the evalaution should be permormed in +/// constant

[PATCH] D62399: [clang] Add storage for APValue in ConstantExpr

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks like a good first step, thanks! Comment at: clang/include/clang/AST/ASTContext.h:2821-2823 + /// Adds an APValue that will be destructed during the destruction of the

r362821 - [Support][Test] Time profiler: add regression test

Author: anton-afanasyev Date: Fri Jun 7 11:13:48 2019 New Revision: 362821 URL: http://llvm.org/viewvc/llvm-project?rev=362821=rev Log: [Support][Test] Time profiler: add regression test Summary: Add output to `llvm::errs()` when `-ftime-trace` option is enabled, add regression test checking

r362816 - Revert rL362792 : [Support][Test] Time profiler: add regression test

Author: rksimon Date: Fri Jun 7 10:37:04 2019 New Revision: 362816 URL: http://llvm.org/viewvc/llvm-project?rev=362816=rev Log: Revert rL362792 : [Support][Test] Time profiler: add regression test Summary: Add output to `llvm::errs()` when `-ftime-trace` option is enabled, add regression test

[PATCH] D61790: [C++20] add Basic consteval specifier

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Only minor comments remain (other than the `-Wc++17-compat` warning). In the interest of incremental progress, let's leave the `-Wc++17-compat` warning for a later patch; feel free to commit

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

dmgreen added a comment. Hello. Hopefully fixed in rC362814 ! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60710/new/ https://reviews.llvm.org/D60710 ___ cfe-commits mailing list

r362814 - [ARM] Add ACLE feature macros for MVE.

Author: dmgreen Date: Fri Jun 7 10:28:12 2019 New Revision: 362814 URL: http://llvm.org/viewvc/llvm-project?rev=362814=rev Log: [ARM] Add ACLE feature macros for MVE. Fixup uninitialised variable. Modified: cfe/trunk/lib/Basic/Targets/ARM.cpp Modified: cfe/trunk/lib/Basic/Targets/ARM.cpp

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

thakis added a comment. The test is failing on some bots, e.g. http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu/builds/13430/steps/test-stage1-compiler/logs/stdio /home/buildslave/buildslave1a/clang-with-lto-ubuntu/llvm.src/tools/clang/test/Preprocessor/arm-target-features.c:762:20:

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:831 + }; return HI; }}, kadircet wrote: > ilya-biryukov wrote: > > kadircet wrote: > > >

r362812 - AST Matchers tutorial requests to enable clang-tools-extra. NFC

Author: ibiryukov Date: Fri Jun 7 09:31:06 2019 New Revision: 362812 URL: http://llvm.org/viewvc/llvm-project?rev=362812=rev Log: AST Matchers tutorial requests to enable clang-tools-extra. NFC Otherwise the examples do not build. Modified: cfe/trunk/docs/LibASTMatchersTutorial.rst

[PATCH] D62999: [clangd] Return empty results on spurious completion triggers

This revision was automatically updated to reflect the committed changes. Closed by commit rL362811: [clangd] Return empty results on spurious completion triggers (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[clang-tools-extra] r362811 - [clangd] Return empty results on spurious completion triggers

Author: ibiryukov Date: Fri Jun 7 09:24:38 2019 New Revision: 362811 URL: http://llvm.org/viewvc/llvm-project?rev=362811=rev Log: [clangd] Return empty results on spurious completion triggers Summary: We currently return an error, this causes `coc.nvim` and VSCode to show an error message in

[PATCH] D62999: [clangd] Return empty results on spurious completion triggers

ilya-biryukov updated this revision to Diff 203567. ilya-biryukov added a comment. - Return empty results instead of an error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62999/new/ https://reviews.llvm.org/D62999 Files:

[PATCH] D62999: [clangd] Return empty results on spurious completion triggers

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:734 +"ignored auto-triggered completion, preceding char did not match", +ErrorCode::RequestCancelled));

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea created this revision. gtbercea added reviewers: ABataev, AlexEichenberger, caomhin. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. Add a new call to Clang to perform task allocation for the target. Repository: rC Clang

[PATCH] D62533: Build with _XOPEN_SOURCE defined on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rL362808: Build with _XOPEN_SOURCE defined on AIX (authored by daltenty, committed by ). Changed prior to commit: https://reviews.llvm.org/D62533?vs=202822=203563#toc Repository: rL LLVM CHANGES

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362806: [ARM] Add ACLE feature macros for MVE (authored by SjoerdMeijer, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r362806 - [ARM] Add ACLE feature macros for MVE

Author: sjoerdmeijer Date: Fri Jun 7 08:20:56 2019 New Revision: 362806 URL: http://llvm.org/viewvc/llvm-project?rev=362806=rev Log: [ARM] Add ACLE feature macros for MVE If MVE is present at all, then the macro __ARM_FEATURE_MVE is defined to a value which has bit 0 set for integer MVE, and

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

SjoerdMeijer added a comment. Thanks for reviewing! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60710/new/ https://reviews.llvm.org/D60710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62574: Initial draft of target-configurable address spaces.

ebevhan updated this revision to Diff 203559. ebevhan added a comment. Replaced `compatiblyIncludes` and its dependents with ASTContext accessors instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62574/new/ https://reviews.llvm.org/D62574 Files: include/clang/AST/ASTContext.h

[PATCH] D62574: Initial draft of target-configurable address spaces.

ebevhan added a comment. >> I'll have to see if that's possible without breaking a few more interfaces, >> since you can throw around Qualifiers and check for compatibility without an >> ASTContext today. >> >>> I was just thinking about testing the new logic. Should we add something >>> like

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60710/new/ https://reviews.llvm.org/D60710 ___ cfe-commits mailing list

[PATCH] D62696: AMDGPU: Use AMDGPU toolchain for other OSes

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62696/new/ https://reviews.llvm.org/D62696 ___ cfe-commits mailing list

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

aganea added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/regular_cdb.json:4 + "directory": "DIR", + "command": "clang -c DIR/regular_cdb.cpp -IInputs -MD -MF DIR/regular_cdb.d", + "file": "DIR/regular_cdb.cpp" Is `-MD -MF` required for

[PATCH] D62569: [PowerPC] [Clang] Port SSE2 intrinsics to PowerPC

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for porting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62569/new/ https://reviews.llvm.org/D62569 ___ cfe-commits mailing

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

SjoerdMeijer updated this revision to Diff 203555. SjoerdMeijer added a comment. Yep, sorry, missed that one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60710/new/ https://reviews.llvm.org/D60710 Files: clang/lib/Basic/Targets/ARM.cpp clang/lib/Basic/Targets/ARM.h

[PATCH] D62009: [clang] perform semantic checking in constant context

Tyker added a comment. @rsmith ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62009/new/ https://reviews.llvm.org/D62009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61790: [C++20] add Basic consteval specifier

Tyker updated this revision to Diff 203551. Tyker marked 9 inline comments as done. Tyker added a comment. fixed requested changes except some i commented upon. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61790/new/ https://reviews.llvm.org/D61790 Files:

[PATCH] D61790: [C++20] add Basic consteval specifier

Tyker added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2491 + if (DS.hasConstexprSpecifier() && DSC != DeclSpecContext::DSC_condition) { Diag(DS.getConstexprSpecLoc(), diag::err_typename_invalid_constexpr); DS.ClearConstexprSpec();

[PATCH] D61637: [Syntax] Introduce syntax trees

sammccall added a comment. In D61637#1527727 , @ilya-biryukov wrote: > I've addressed most of the comments, except the naming ones. > We need a convention for naming the language nodes and names for composite > and leaf structural nodes. > > For

[PATCH] D62962: Clang implementation of sizeless types

rsandifo-arm updated this revision to Diff 203546. rsandifo-arm added a comment. Add tests for ext_vector_type Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62962/new/ https://reviews.llvm.org/D62962 Files: docs/SizelessTypes.rst include/clang/AST/Expr.h

[PATCH] D62839: [clangd] Index API and implementations for relations

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:202 + for (const auto : RelationSlabs) { +for (const auto : *RelationSlab) { + AllRelations.push_back(R); nit: braces

[PATCH] D61914: [Support][Test] Time profiler: add regression test

This revision was automatically updated to reflect the committed changes. Closed by commit rL362792: [Support][Test] Time profiler: add regression test (authored by anton-afanasyev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61914?vs=203532=203544#toc Repository: rL

r362792 - [Support][Test] Time profiler: add regression test

Author: anton-afanasyev Date: Fri Jun 7 05:59:32 2019 New Revision: 362792 URL: http://llvm.org/viewvc/llvm-project?rev=362792=rev Log: [Support][Test] Time profiler: add regression test Summary: Add output to `llvm::errs()` when `-ftime-trace` option is enabled, add regression test checking

[PATCH] D61914: [Support][Test] Time profiler: add regression test

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. Thanks Anton! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61914/new/ https://reviews.llvm.org/D61914

[PATCH] D62998: [ARM] Fix bugs introduced by the fp64/d32 rework.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362791: [ARM] Fix bugs introduced by the fp64/d32 rework. (authored by statham, committed by ). Herald added a subscriber: kristina. Changed prior to commit:

r362791 - [ARM] Fix bugs introduced by the fp64/d32 rework.

Author: statham Date: Fri Jun 7 05:42:54 2019 New Revision: 362791 URL: http://llvm.org/viewvc/llvm-project?rev=362791=rev Log: [ARM] Fix bugs introduced by the fp64/d32 rework. Change D60691 caused some knock-on failures that weren't caught by the existing tests. Firstly, selecting a CPU that

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

ostannard added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:465 + MVE |= MVE_INT | MVE_FP; + HW_FP |= HW_FP_SP | HW_FP_HP; } SjoerdMeijer wrote: > ostannard wrote: > > Does this also need to set FPU and HasLegalHalfType? > Yep,

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet updated this revision to Diff 203533. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://reviews.llvm.org/D62814 Files:

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:831 + }; return HI; }}, ilya-biryukov wrote: > kadircet wrote: > > ilya-biryukov wrote: > > > kadircet wrote: > > > > ilya-biryukov wrote: > >

[PATCH] D61914: [Support][Test] Time profiler: add regression test

anton-afanasyev updated this revision to Diff 203532. anton-afanasyev marked 2 inline comments as done. anton-afanasyev added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61914/new/ https://reviews.llvm.org/D61914 Files:

[PATCH] D61914: [Support][Test] Time profiler: add regression test

anton-afanasyev marked 4 inline comments as done. anton-afanasyev added a comment. In D61914#1512021 , @aganea wrote: > Could you please move the test to a more approriate location? (ie. > clang/trunk/test/Driver/) Thanks, I've moved it there.

[PATCH] D62998: [ARM] Fix bugs introduced by the fp64/d32 rework.

SjoerdMeijer added a comment. Cheers, LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62998/new/ https://reviews.llvm.org/D62998 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62998: [ARM] Fix bugs introduced by the fp64/d32 rework.

simon_tatham updated this revision to Diff 203526. simon_tatham added a comment. Renamed `FeaturesAfter` to `ExtensionFeatures` and added a comment explaining why it has to be separate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62998/new/

[PATCH] D50147: clang-format: support external styles

Typz added a comment. In D50147#157 , @sammccall wrote: > One thing that's unclear to me is whether your aim is to > > 1. solve a concrete problem for your organization > 2. solve a family of problems for similar organizations > 3. add a new way of

[PATCH] D62808: [clangd] Print the ignored variant symbols

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/include-mapping/gen_std.py:119 +( a list of tuple (symbol_name, relative_path_to_symbol_page), + a list of tuple (variant_symbol_name, caption_text) ) """

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

SjoerdMeijer updated this revision to Diff 203522. SjoerdMeijer added a comment. Set FullFP16 for +mve.fp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60710/new/ https://reviews.llvm.org/D60710 Files: clang/lib/Basic/Targets/ARM.cpp clang/lib/Basic/Targets/ARM.h

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

SjoerdMeijer marked an inline comment as done. SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:465 + MVE |= MVE_INT | MVE_FP; + HW_FP |= HW_FP_SP | HW_FP_HP; } ostannard wrote: > Does this also need to set FPU and

[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL362786: [X86][test] Add test cases using immediates to builtins-x86.c (authored by russell_gallop, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r362786 - [X86][test] Add test cases using immediates to builtins-x86.c

Author: russell_gallop Date: Fri Jun 7 02:51:44 2019 New Revision: 362786 URL: http://llvm.org/viewvc/llvm-project?rev=362786=rev Log: [X86][test] Add test cases using immediates to builtins-x86.c These builtins should work with immediate or variable shift operand for gcc compatibility.

[PATCH] D62582: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rL362785: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified… (authored by sammccall, committed by ). Herald added a project: LLVM.

r362785 - [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods.

Author: sammccall Date: Fri Jun 7 02:45:17 2019 New Revision: 362785 URL: http://llvm.org/viewvc/llvm-project?rev=362785=rev Log: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods. Summary: - when a method is not available because of the target value kind

[PATCH] D62962: Clang implementation of sizeless types

jaykang10 added inline comments. Comment at: test/Sema/sizeless-1.c:29 + +typedef svint8_t vec_int8 __attribute__((vector_size(64))); // expected-error {{invalid vector element type}} + Please check "__attribute__((ext_vector_type()))". I guess it is also

[PATCH] D62999: [clangd] Return 'RequestCancelled' on spurious completion triggers

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:734 +"ignored auto-triggered completion, preceding char did not match", +

[PATCH] D62958: [clang-tidy] Fix descriptions for modernize-make-unique/shared checks.

hokein abandoned this revision. hokein added a comment. As discussed offline, we don't need a separate fix description for this check, as the check warning message clearly implies what the fix will do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62998: [ARM] Fix bugs introduced by the fp64/d32 rework.

SjoerdMeijer added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:103 std::vector , + std::vector , const llvm::Triple ) { Nitpick: can you comment in

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

ostannard added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:465 + MVE |= MVE_INT | MVE_FP; + HW_FP |= HW_FP_SP | HW_FP_HP; } Does this also need to set FPU and HasLegalHalfType? CHANGES SINCE LAST ACTION

[PATCH] D62998: [ARM] Fix bugs introduced by the fp64/d32 rework.

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM with one change. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:294 + std::vector FeaturesAfter; + You explained it in the commit

[PATCH] D62835: [X86] -march=cooperlake (clang)

This revision was automatically updated to reflect the committed changes. Closed by commit rL362781: [X86] -march=cooperlake (clang) (authored by pengfei, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r362781 - [X86] -march=cooperlake (clang)

Author: pengfei Date: Fri Jun 7 01:53:37 2019 New Revision: 362781 URL: http://llvm.org/viewvc/llvm-project?rev=362781=rev Log: [X86] -march=cooperlake (clang) Support intel -march=cooperlake in clang Patch by Shengchen Kan (skan) Differential Revision: https://reviews.llvm.org/D62835

[PATCH] D62999: [clangd] Return 'RequestCancelled' on spurious completion triggers

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. We currently return 'UnknownErrorCode' and it causes `coc.nvim` to show an error message to the user, which we want to

  1   2   >