[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

vzakhari added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:226 +// Add this function to global destructors. +appendToGlobalDtors(M, Func, 0); + } FYI, llvm.global_dtors does not work on Windows. The symbol

[PATCH] D65846: Improve error message from FrontendAction

jfb planned changes to this revision. jfb added a comment. There's a failure in `clang/test/Index/pch-from-libclang.c`. @thakis disabled that test for all but Darwin in r352809, and with my change I now get: Internal compiler error: LFS error for

[PATCH] D65846: Improve error message from FrontendAction

jfb created this revision. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. jfb planned changes to this revision. jfb added a comment. There's a failure in `clang/test/Index/pch-from-libclang.c`. @thakis disabled that test for all but Darwin in r352809, and with

[PATCH] D65839: [Driver] Add verbatim dry run option

compnerd added inline comments. Comment at: clang/include/clang/Driver/Options.td:333 HelpText<"Print (but do not run) the commands to run for this compilation">; +def _HASH_HASH_HASH_VERBATIM : Flag<["-"], "###-verbatim">, +Flags<[DriverOption, CoreOption]>,

Re: LLVM Types

To avoid confusion, there's both a LLVM Type and a Clang Type. The LLVM Type is used in the LLVM IR while the Clang Type represents types in a language, like C++. The Clang Doxygen pages have this hierarchy, although it's truncated because Type is so large, but you can click through to get the

[PATCH] D65838: [Driver] Use enumeration for quoting mode. NFC

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65838/new/ https://reviews.llvm.org/D65838

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev marked 14 inline comments as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:69 + + using MemoryBuffersVector = SmallVectorImpl>; + ABataev wrote: > Why not `ArrayRef`? Changed to

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran updated this revision to Diff 213776. DiegoAstiazaran added a comment. Remove unnecessary type casting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65483/new/ https://reviews.llvm.org/D65483 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp

[PATCH] D65841: [Driver] Switch -stdlib++-isystem test to -###-verbatim

smeenai created this revision. smeenai added reviewers: compnerd, phosek, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows the test to pass on Windows and avoid backslash quoting issues. Repository: rG LLVM Github Monorepo

[PATCH] D65839: [Driver] Add verbatim dry run option

smeenai updated this revision to Diff 213773. smeenai edited the summary of this revision. smeenai added a comment. Output to stdout Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65839/new/ https://reviews.llvm.org/D65839 Files:

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/docs/clang-doc.rst:93 +--public- Document only public declarations. +--repository= - + URL of repository that hosts code.

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran updated this revision to Diff 213772. DiegoAstiazaran marked 7 inline comments as done. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Add comments. Change name of flag; `root-directory` -> `--source-root` Moved fixing of repository link to

[PATCH] D65839: [Driver] Add verbatim dry run option

smeenai added a comment. I'm not tied to the name `-###-verbatim` and am open to suggestions if anyone can think of something better. My troll suggestion was `-`, but @compnerd didn't like that for some reason... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64538: [Driver] Don't escape backslashes on Windows

smeenai abandoned this revision. smeenai added a comment. Abandoning in favor of D65839 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64538/new/ https://reviews.llvm.org/D64538

[PATCH] D65839: [Driver] Add verbatim dry run option

smeenai created this revision. smeenai added reviewers: compnerd, phosek, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. smeenai added a parent revision: D65838: [Driver] Use enumeration for quoting mode. NFC. When writing driver tests, it's useful to have a way to

[PATCH] D65838: [Driver] Use enumeration for quoting mode. NFC

smeenai created this revision. smeenai added reviewers: compnerd, phosek, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. Boolean parameters are generally hard to understand, especially when we don't consistently have a comment for them. Change to an enumeration.

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc on ARM

jcai19 marked 4 inline comments as done. jcai19 added inline comments. Comment at: llvm/lib/Target/ARM/ARMFastISel.cpp:2418 + bool PushLR = IntrinsicName && + !memcmp(IntrinsicName, "\01__gnu_mcount_nc", sizeof("\01__gnu_mcount_nc")); + unsigned CallOpc =

[PATCH] D65663: [analyzer] ConditionBRVisitor: Fix HTML PathDiagnosticPopUpPieces

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yay! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65663/new/ https://reviews.llvm.org/D65663 ___ cfe-commits mailing list

[PATCH] D65663: [analyzer] ConditionBRVisitor: Fix HTML PathDiagnosticPopUpPieces

Charusso added a comment. Thanks for the review! It is much better: F9740817: report-Driver.cpp-operator()-6-2.html Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2420 + if (!IsAssuming) { +PathDiagnosticLocation

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc on ARM

jcai19 updated this revision to Diff 213762. jcai19 added a comment. Update based on comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65019/new/ https://reviews.llvm.org/D65019 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D65663: [analyzer] ConditionBRVisitor: Fix HTML PathDiagnosticPopUpPieces

Charusso updated this revision to Diff 213763. Charusso marked 2 inline comments as done. Charusso added a comment. - Fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65663/new/ https://reviews.llvm.org/D65663 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp

[PATCH] D65684: [WebAssembly] Lower ASan constructor priority on Emscripten

sbc100 added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:132 static const uint64_t kAsanCtorAndDtorPriority = 1; +static const uint64_t kAsanEmscriptenCtorAndDtorPriority = 50; static const char *const kAsanReportErrorTemplate =

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc on ARM

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/ARM/ARMFastISel.cpp:211 unsigned ARMMoveToIntReg(MVT VT, unsigned SrcReg); -unsigned ARMSelectCallOp(bool UseReg); +unsigned ARMSelectCallOp(bool UseReg, bool PushLR = false); unsigned

[PATCH] D65663: [analyzer] ConditionBRVisitor: Fix HTML PathDiagnosticPopUpPieces

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2420 + if (!IsAssuming) { +PathDiagnosticLocation Loc(BExpr->getLHS(), BRC.getSourceManager(), LCtx); return std::make_shared(Loc, Message); Charusso wrote: >

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdenny created this revision. jdenny added a reviewer: ABataev. Herald added a subscriber: guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. For `map`, the following restriction changed in OpenMP 5.0: - OpenMP 4.5 [2.15.5.1, Restrictions]: "A list item cannot appear in

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc on ARM

jcai19 marked an inline comment as done. jcai19 added inline comments. Comment at: llvm/lib/Target/ARM/ARMFastISel.cpp:211 unsigned ARMMoveToIntReg(MVT VT, unsigned SrcReg); -unsigned ARMSelectCallOp(bool UseReg); +unsigned ARMSelectCallOp(bool UseReg, bool PushLR =

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

jkorous added a comment. Thanks Puyan! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65829/new/ https://reviews.llvm.org/D65829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc on ARM

jcai19 updated this revision to Diff 213748. jcai19 marked 6 inline comments as done. jcai19 added a comment. Update based on comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65019/new/ https://reviews.llvm.org/D65019 Files:

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL368108: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in create (authored by zer0, committed by ).

r368108 - [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in create

Author: zer0 Date: Tue Aug 6 16:25:34 2019 New Revision: 368108 URL: http://llvm.org/viewvc/llvm-project?rev=368108=rev Log: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in create I also have replaced all the instances of "auto DW = DirectoryWatcher::create" with

[PATCH] D65833: [Tooling] Expose ExecutorConcurrency option.

DiegoAstiazaran created this revision. DiegoAstiazaran added a reviewer: juliehockett. https://reviews.llvm.org/D65833 Files: clang/include/clang/Tooling/AllTUsExecution.h clang/lib/Tooling/AllTUsExecution.cpp Index: clang/lib/Tooling/AllTUsExecution.cpp

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

plotfi added a comment. In D65829#1617864 , @compnerd wrote: > @lhames - I like the `logAllUnhandledErrors`! @lhames @compnerd @jkorous Only downside to using logAllUnhandledErrors over just letting the llvm::Expected's destructor handle the error

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

plotfi updated this revision to Diff 213742. plotfi added a comment. Updated to use logAllUnhandledErrors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65829/new/ https://reviews.llvm.org/D65829 Files:

r368104 - Delay diagnosing asm constraints that require immediates until after inlining

Author: void Date: Tue Aug 6 15:41:22 2019 New Revision: 368104 URL: http://llvm.org/viewvc/llvm-project?rev=368104=rev Log: Delay diagnosing asm constraints that require immediates until after inlining Summary: An inline asm call may result in an immediate input value after inlining.

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

Meinersbur added a comment. Looking at the similar situation of `unroll(enable)`/`unroll_count(4)`, `unroll_count` also does not set `llvm.loop.unroll.enable`, but it is handled by the LoopUnroll pass itself: bool ExplicitUnroll = PragmaCount > 0 || PragmaFullUnroll ||

[PATCH] D65549: [Sema] Prevent -Wunused-lambda-capture from generating false positive warnings on templated member function

nickdesaulniers added a comment. Thanks for the patch @ziangwan ! Comment at: clang/lib/Sema/SemaExpr.cpp:5631 + } +} + LLVM style is not to use `{}` for single statement bodies. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D65828: [clang-tidy] Add check to linuxkernel for unbalanced irq calls

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/IrqUnbalancedCheck.cpp:13 + +std::string annotation = "ignore_irq_balancing"; + Should be static and may be StringRef? Comment at:

[PATCH] D65770: hwasan: Instrument globals.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368102: hwasan: Instrument globals. (authored by pcc, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D65770?vs=213477=213732#toc Repository:

r368102 - hwasan: Instrument globals.

Author: pcc Date: Tue Aug 6 15:07:29 2019 New Revision: 368102 URL: http://llvm.org/viewvc/llvm-project?rev=368102=rev Log: hwasan: Instrument globals. Globals are instrumented by adding a pointer tag to their symbol values and emitting metadata into a special section that allows the runtime to

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

jkorous added a comment. I was about to suggest something similar. SGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65829/new/ https://reviews.llvm.org/D65829 ___ cfe-commits mailing list

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc on ARM

nickdesaulniers added a comment. Thanks so much for this patch! I look forward to support for `__gnu_mcount` for the arm32 Linux kernel. > What a horrible function. AAPCS? Who cares about that? haha Comment at: llvm/lib/Target/ARM/ARMExpandPseudoInsts.cpp:1944 + + //

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

plotfi marked an inline comment as done. plotfi added a comment. In D65829#1617850 , @lhames wrote: > I think the right line is: > > logAllUnhandledErrors(DW.takeError(), errs(), ""); > > > It's a bit wordy, but will log a sensible error and works

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

compnerd added a comment. @lhames - I like the `logAllUnhandledErrors`! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65829/new/ https://reviews.llvm.org/D65829 ___ cfe-commits mailing list

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

paulkirth updated this revision to Diff 213725. paulkirth added a comment. Use existing LLVM code for mapping case literals to their case arms. This update refactors a great deal of the implementation and test code. 1. Removes the CaseMap data structure completely. LLVM already maintains a

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

lhames added a comment. I think the right line is: logAllUnhandledErrors(DW.takeError(), errs(), ""); It's a bit wordy, but will log a sensible error and works with and without ENABLE_ABI_BREAKING_CHECKS enabled. I'm not against improving the output for cantFail, nor totally against abusing

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc on ARM

jcai19 added a comment. In D65019#1615898 , @efriedma wrote: > > introduce quite some code to the target-independent part of SelectionDAG, > > specifically SelectionDAGBuilder and SelectionDAG classes > > Not sure why you think this would be necessary.

[PATCH] D65684: [WebAssembly] Lower ASan constructor priority on Emscripten

This revision was automatically updated to reflect the committed changes. Closed by commit rL368101: [WebAssembly] Lower ASan constructor priority on Emscripten (authored by quantum, committed by ). Changed prior to commit: https://reviews.llvm.org/D65684?vs=213720=213730#toc Repository: rL

r368101 - [WebAssembly] Lower ASan constructor priority on Emscripten

Author: quantum Date: Tue Aug 6 14:52:58 2019 New Revision: 368101 URL: http://llvm.org/viewvc/llvm-project?rev=368101=rev Log: [WebAssembly] Lower ASan constructor priority on Emscripten Summary: This change gives Emscripten the ability to use more than one constructor priorities that runs

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc on ARM

jcai19 updated this revision to Diff 213728. jcai19 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introduce a new ARM intrinsic for __gnu_mcount_nc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65019/new/

[PATCH] D65203: [ASTImporter] Do not import FunctionTemplateDecl in record twice.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65203/new/ https://reviews.llvm.org/D65203

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

compnerd added a comment. @gribozavr I think that this usage here is actually useful because it a) tests the actual behaviour b) provides example code for other users The check here ensures that the rest of the code is properly executed, *but* because the error is not actually consumed (you

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

gribozavr added inline comments. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:323 + /*waitForInitialSync=*/false); + // llvm::Expected will throw an error if DW is an Error. + if (!DW) plotfi wrote: > gribozavr wrote: > >

r368092 - fix clang-scan-deps test to match filepaths on Windows

Author: arphaman Date: Tue Aug 6 14:45:43 2019 New Revision: 368092 URL: http://llvm.org/viewvc/llvm-project?rev=368092=rev Log: fix clang-scan-deps test to match filepaths on Windows Modified: cfe/trunk/test/ClangScanDeps/header_stat_before_open.m Modified:

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:323 + /*waitForInitialSync=*/false); + // llvm::Expected will throw an error if DW is an Error. + if (!DW)

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev added a comment. In D65819#1617736 , @Hahnfeld wrote: > Can you detail what "incorrect linking" means? AFAIK the additional sections > were just bloating the executable, but how do they affect correctness? > > Will this patch change the ability

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

gribozavr added inline comments. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:323 + /*waitForInitialSync=*/false); + // llvm::Expected will throw an error if DW is an Error. + if (!DW) plotfi wrote: > gribozavr wrote: > >

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:323 + /*waitForInitialSync=*/false); + // llvm::Expected will throw an error if DW is an Error. + if (!DW)

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

gribozavr added inline comments. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:323 + /*waitForInitialSync=*/false); + // llvm::Expected will throw an error if DW is an Error. + if (!DW) plotfi wrote: > gribozavr wrote: > > Call

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:323 + /*waitForInitialSync=*/false); + // llvm::Expected will throw an error if DW is an Error. + if (!DW)

[PATCH] D65684: [WebAssembly] Lower ASan constructor priority on Emscripten

quantum updated this revision to Diff 213720. quantum added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add constructor priority test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65684/new/

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

gribozavr added inline comments. Comment at: clang/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:323 + /*waitForInitialSync=*/false); + // llvm::Expected will throw an error if DW is an Error. + if (!DW) Call `llvm::cantFail` and there will be

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi added a comment. @jkorous Can you lemme know if you're happy with https://reviews.llvm.org/D65829. @gribozavr lemme also know any other feedback in D65829 , as this diff here is already closed. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D65829: [clang][DirectoryWatcher][NFC] Swapping asserts for llvm fatal_error in ::create.

plotfi created this revision. plotfi added reviewers: jkorous, compnerd, gribozavr. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Also I went ahead and replaced all the instances of "auto DW = DirectoryWatcher::create" with "llvm::Expected> DW =

[PATCH] D65828: [clang-tidy] Add check to linuxkernel for unbalanced irq calls

Nathan-Huckleberry created this revision. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65828 Files: clang-tools-extra/clang-tidy/linuxkernel/CMakeLists.txt

[PATCH] D65827: [clang-doc] Fix paths of js in import tags

This revision was automatically updated to reflect the committed changes. Closed by commit rL368087: [clang-doc] Fix paths of js in import tags (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65000: [ARM] Set default alignment to 64bits

thegameg added a comment. In D65000#1616368 , @dnsampaio wrote: > I have tested this in our MacOS and linux environments. @thakis @thegameg > @phosek, would it be possible for you to check if this works for you? I just built trunk with this patch

[clang-tools-extra] r368087 - [clang-doc] Fix paths of js in import tags

Author: diegoastiazaran Date: Tue Aug 6 13:59:14 2019 New Revision: 368087 URL: http://llvm.org/viewvc/llvm-project?rev=368087=rev Log: [clang-doc] Fix paths of js in import tags HTML requires posix-style paths. Differential Revision: https://reviews.llvm.org/D65827 Modified:

[PATCH] D65827: [clang-doc] Fix paths of js in import tags

DiegoAstiazaran created this revision. DiegoAstiazaran added a reviewer: juliehockett. DiegoAstiazaran added a project: clang-tools-extra. juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM (let's make sure we double check this

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: cfe/trunk/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:287 /*waitForInitialSync=*/true); + if (!DW) return; plotfi wrote: > gribozavr wrote: > > plotfi wrote: > >

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

Hahnfeld added a comment. Can you detail what "incorrect linking" means? AFAIK the additional sections were just bloating the executable, but how do they affect correctness? Will this patch change the ability to consume a bundled object file without calling the unbundler? Using known ELF tools

[PATCH] D65827: [clang-doc] Fix paths of js in import tags

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM (let's make sure we double check this next time) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65827/new/ https://reviews.llvm.org/D65827

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: cfe/trunk/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:287 /*waitForInitialSync=*/true); + if (!DW) return; gribozavr wrote: > plotfi wrote: > > gribozavr wrote:

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran updated this revision to Diff 213706. DiegoAstiazaran added a comment. Changed `JumpToSection` in Index struct and `genHTML(const Index , ...)` function to `llvm::Optional`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65030/new/ https://reviews.llvm.org/D65030

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

This revision was automatically updated to reflect the committed changes. Closed by commit rL368086: [clang-scan-deps] Implementation of dependency scanner over minimized sources (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r368086 - [clang-scan-deps] Implementation of dependency scanner over minimized sources

Author: arphaman Date: Tue Aug 6 13:43:25 2019 New Revision: 368086 URL: http://llvm.org/viewvc/llvm-project?rev=368086=rev Log: [clang-scan-deps] Implementation of dependency scanner over minimized sources This commit implements the fast dependency scanning mode in clang-scan-deps: the

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:76 +CachedFileSystemEntry +CachedFileSystemEntry::createDirectoryEntry(llvm::vfs::Status Stat) { +

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

gribozavr added inline comments. Comment at: cfe/trunk/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:287 /*waitForInitialSync=*/true); + if (!DW) return; plotfi wrote: > gribozavr wrote: > > plotfi wrote: > > > gribozavr wrote: > > > > Why? This

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: cfe/trunk/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 - /// Returns nullptr if \param Path doesn't exist or isn't a directory. - /// Returns nullptr if OS kernel API told us we can't

[clang-tools-extra] r368083 - [clangd] Unfold SourceLocation flattening from findNameLoc in preparation for adding more overloads. NFC

Author: sammccall Date: Tue Aug 6 13:25:59 2019 New Revision: 368083 URL: http://llvm.org/viewvc/llvm-project?rev=368083=rev Log: [clangd] Unfold SourceLocation flattening from findNameLoc in preparation for adding more overloads. NFC Modified: clang-tools-extra/trunk/clangd/AST.cpp

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: cfe/trunk/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp:329 + assert(!Path.empty() && "Path.empty()"); const int InotifyFD = inotify_init1(IN_CLOEXEC); @gribozavr

[PATCH] D65753: Builtins: Add some v2f16 variants

scanon added a comment. (Ideally we would just call them e.g. __builtin_floor, but that would be source-breaking. __builtin_tgmath_floor seems like a good compromise.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65753/new/ https://reviews.llvm.org/D65753

[PATCH] D65753: Builtins: Add some v2f16 variants

scanon added a comment. Strongly agree with what @rjmccall said. If we can make these generic builtins instead of ending up with O(100) variants of each math operation, that would make life immensely nicer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65753/new/

[PATCH] D63976: Allow clang -Os and -Oz to work with -flto and lld

mehdi_amini added a comment. > with a funny command line like `clang -Oz -flto -o foo a.o b.c`, where one > (or all) of the input arguments is a source file? Would it invoke the bitcode > compile of the source files with the requested `-Oz` and then invoke the LTO > linker plugin with

[PATCH] D65776: [Clang] Pragma vectorize_predicate implies vectorize

SjoerdMeijer added a comment. Hi Florian, thanks for your input! > IMO it would make sense to have the more specific pragmas imply > vectorize(enable) here (or update the docs accordingly). Yep, fully agree with that, as I also wrote in my previous comment. And thanks for digging up that PR.

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: cfe/trunk/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:287 /*waitForInitialSync=*/true); + if (!DW) return; gribozavr wrote: > plotfi wrote: > > gribozavr wrote:

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:7077 +// someContainer.add(std::move(localOWner)); +// return p; +if (!IsTempGslOwner && pathOnlyInitializesGslPointer(Path) && xazax.hun wrote: > gribozavr wrote: > > Why

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: cfe/trunk/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 - /// Returns nullptr if \param Path doesn't exist or isn't a directory. - /// Returns nullptr if OS kernel API told us we can't

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

gribozavr added inline comments. Comment at: cfe/trunk/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 - /// Returns nullptr if \param Path doesn't exist or isn't a directory. - /// Returns nullptr if OS kernel API told us we can't start watching. In such - /// case

[PATCH] D65688: [AIX][test/Index] Set/propagate AIXTHREAD_STK for AIX

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65688/new/ https://reviews.llvm.org/D65688 ___

[PATCH] D65704: DirectoryWatcher::create: Adding better error handling.

jkorous added inline comments. Comment at: cfe/trunk/include/clang/DirectoryWatcher/DirectoryWatcher.h:102 - /// Returns nullptr if \param Path doesn't exist or isn't a directory. - /// Returns nullptr if OS kernel API told us we can't start watching. In such - /// case

[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rL368072: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes (authored by xazax, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r368072 - Teach some warnings to respect gsl::Pointer and gsl::Owner attributes

Author: xazax Date: Tue Aug 6 12:13:29 2019 New Revision: 368072 URL: http://llvm.org/viewvc/llvm-project?rev=368072=rev Log: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes This patch extends some existing warnings to utilize the knowledge about the gsl::Pointer and

[PATCH] D65648: [clang-format] Add support to SpacesBeforeTrailingComments to add spaces before Block comments.

Manikishan marked an inline comment as done. Manikishan added inline comments. Comment at: unittests/Format/FormatTest.cpp:3663 + FormatStyle Style = getGoogleStyle(); + Style.SpacesBeforeTrailingComments = 0; EXPECT_EQ("#define MACRO() \\\n"

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. LGTM, thank you! In D63907#1617417 , @arphaman wrote: > Just for reference, this patch still doesn't reuse the FileManager across > invocations in a

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

ABataev added inline comments. Comment at: clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp:69 + + using MemoryBuffersVector = SmallVectorImpl>; + Why not `ArrayRef`? Comment at:

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev created this revision. ABataev added reviewers: yaxunl, tra, jlebar, hfinkel. Herald added a reviewer: jdoerfert. Herald added a project: clang. Previously, object files were bundled using partial linking. It resulted in the following structure of the bundled objects:

[PATCH] D65690: [clang-doc] Add index in each info html file

This revision was automatically updated to reflect the committed changes. Closed by commit rL368070: [clang-doc] Add index in each info html file (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r368070 - [clang-doc] Add index in each info html file

Author: diegoastiazaran Date: Tue Aug 6 11:31:46 2019 New Revision: 368070 URL: http://llvm.org/viewvc/llvm-project?rev=368070=rev Log: [clang-doc] Add index in each info html file An index structure is created while generating the output file for each info. This structure is parsed to JSON and

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman added a comment. Just for reference, this patch still doesn't reuse the FileManager across invocations in a thread. We expect to get even better performance once we reuse it, but I'm going have to improve its API first. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D63907: [clang-scan-deps] Implementation of dependency scanner over minimized sources

arphaman added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:117 +std::mutex CacheLock; +llvm::StringMap> Cache; + }; aganea wrote: > Why not use a bump allocator here? (it would be

  1   2   >