[PATCH] D70157: Align branches within 32-Byte boundary

LuoYuanke added a comment. In D70157#1773180 , @reames wrote: > Recording something so I don't forget it when we get back to the prefix > padding version. The write up on the bundle align mode stuff mentions a > concerning memory overhead for the

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

michele.scandale added a comment. I've noticed you removed the change for `CompilerInvocation.cpp` about the initialization of the codegen option `NoTrappingMath`. Was that an accident? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/

[PATCH] D71159: [Attr] Move ParsedTargetAttr out of the TargetAttr class

craig.topper marked an inline comment as done. craig.topper added inline comments. Comment at: clang/include/clang/AST/Attr.h:359 } } // end namespace clang There's an ending namespace comment here and there's no namespace starting since the end of my

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

This revision was automatically updated to reflect the committed changes. Closed by commit rG198fbcb81749: Driver: Dont look for libc++ headers in the install directory on Android. (authored by pcc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 198fbcb - Driver: Don't look for libc++ headers in the install directory on Android.

Author: Peter Collingbourne Date: 2019-12-06T18:24:23-08:00 New Revision: 198fbcb817492ff45946e3f7517de15e8cdf0607 URL: https://github.com/llvm/llvm-project/commit/198fbcb817492ff45946e3f7517de15e8cdf0607 DIFF:

[PATCH] D71159: [Attr] Move ParsedTargetAttr out of the TargetAttr class

erichkeane added a comment. Should this be in a namespace? Can't tell from the header file, is it at least in clang? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71159/new/ https://reviews.llvm.org/D71159 ___ cfe-commits mailing list

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun updated this revision to Diff 232681. xazax.hun marked 7 inline comments as done. xazax.hun added a comment. - Make the annotation acceptable on both types and declarations. - Fix some TODOs. - Teach TypePrinter to print the annotations. - Address review comments. CHANGES SINCE LAST

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7412 + diag::warn_type_attribute_wrong_type_str) +<< Attr.getAttrName()->getName() << "non-function" << CurType; +return; aaron.ballman wrote: > You

[PATCH] D70839: [clang][IFS] Claiming -emit-merged-ifs in clang driver when -c is used.

plotfi abandoned this revision. plotfi added a comment. This commit is no good. I got some wrong inspiration from a lot of the code claiming random args in the driver. abandoning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70839/new/

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1230 - "unknown '%0' device kind trait in the 'device' context selector set, expected" - " one of 'host', 'nohost', 'cpu', 'gpu' or 'fpga'">;

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

sbc100 added a comment. Ping .. I think this is good to go now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70520/new/ https://reviews.llvm.org/D70520 ___ cfe-commits mailing list

[PATCH] D71159: [Attr] Move ParsedTargetAttr out of the TargetAttr class

craig.topper created this revision. craig.topper added reviewers: rnk, echristo, erichkeane. Need to forward declare it in ASTContext.h for D68627 , so it can't be a nested struct. https://reviews.llvm.org/D71159 Files: clang/include/clang/AST/Attr.h

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

danalbert accepted this revision. danalbert added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/android-no-installed-libcxx.cpp:8 +// RUN: -stdlib=libc++ -fsyntax-only %s -### 2>&1 | FileCheck %s +// CHECK-NOT:

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1230 - "unknown '%0' device kind trait in the 'device' context selector set, expected" - " one of 'host', 'nohost', 'cpu', 'gpu' or 'fpga'">; ABataev wrote: >

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

pcc marked an inline comment as done. pcc added inline comments. Comment at: clang/test/Driver/android-no-installed-libcxx.cpp:8 +// RUN: -stdlib=libc++ -fsyntax-only %s -### 2>&1 | FileCheck %s +// CHECK-NOT: "-internal-isystem" "{{.*}}v1" danalbert wrote: >

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

danalbert requested changes to this revision. danalbert added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Driver/android-no-installed-libcxx.cpp:8 +// RUN: -stdlib=libc++ -fsyntax-only %s -### 2>&1 | FileCheck %s +// CHECK-NOT:

[PATCH] D71152: [analyzer] Keep track of escaped locals.

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ProgramState.cpp:48-61 +namespace { +struct EscapedLocals{}; +} // namespace + +template <> +struct ProgramStateTrait : + public ProgramStatePartialTrait> {

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

merge_guards_bot added a comment. Build result: pass - 60573 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[clang] 5253d91 - [c++20] Determine whether a defaulted comparison should be deleted or

Author: Richard Smith Date: 2019-12-06T16:32:48-08:00 New Revision: 5253d9138eb31252594f5e14133df731551839c7 URL: https://github.com/llvm/llvm-project/commit/5253d9138eb31252594f5e14133df731551839c7 DIFF: https://github.com/llvm/llvm-project/commit/5253d9138eb31252594f5e14133df731551839c7.diff

[PATCH] D71155: [analyzer] CERT: StrChecker: 30.c

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Charusso added a comment. Charusso added a parent revision:

[PATCH] D71155: [analyzer] CERT: StrChecker: 30.c

Charusso added a comment. Examples generated by CodeChecker from the `curl` project: F10986729: str30-c.tar.gz Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71155/new/ https://reviews.llvm.org/D71155

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

sbc100 updated this revision to Diff 232673. sbc100 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70520/new/ https://reviews.llvm.org/D70520 Files: clang/include/clang/Basic/Attr.td

[PATCH] D71033: [analyzer] CERT: StrChecker: 32.c

Charusso updated this revision to Diff 232672. Charusso edited the summary of this revision. Charusso added a comment. - Add docs. - Move to alpha. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71033/new/ https://reviews.llvm.org/D71033 Files: clang/docs/analyzer/checkers.rst

[PATCH] D71152: [analyzer] Keep track of escaped locals.

xazax.hun updated this revision to Diff 232675. xazax.hun added a comment. - Add cleanup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71152/new/ https://reviews.llvm.org/D71152 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h

[PATCH] D70411: [analyzer] CERT: StrChecker: 31.c

Charusso added a comment. Please let us measure your examples at first to have a consensus what we would like to see from this checker. In D70411#1769803 , @NoQ wrote: > In D70411#1769628 , @Charusso wrote: > > >

[PATCH] D70411: [analyzer] CERT: StrChecker: 31.c

Charusso updated this revision to Diff 232671. Charusso marked 10 inline comments as done. Charusso added a comment. - Make the checker alpha. - Add docs. - Copy-paste @NoQ's test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70411/new/ https://reviews.llvm.org/D70411 Files:

[PATCH] D71154: Driver: Don't look for libc++ headers in the install directory on Android.

pcc created this revision. pcc added reviewers: danalbert, srhines. Herald added a reviewer: EricWF. Herald added a subscriber: ldionne. Herald added a project: clang. The NDK uses a separate set of libc++ headers in the sysroot. Any headers in the installation directory are not going to work on

[PATCH] D54406: Add matchDynamic convenience functions

steveire closed this revision. steveire added a comment. Herald added a project: clang. Committed in 2e8dc8590d8b412 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54406/new/

[clang] 2e8dc85 - Add matchDynamic convenience functions

Author: Stephen Kelly Date: 2019-12-07T00:01:29Z New Revision: 2e8dc8590d8b412a131b127e7aa4aad0d7fc7fa0 URL: https://github.com/llvm/llvm-project/commit/2e8dc8590d8b412a131b127e7aa4aad0d7fc7fa0 DIFF: https://github.com/llvm/llvm-project/commit/2e8dc8590d8b412a131b127e7aa4aad0d7fc7fa0.diff

[PATCH] D71152: [analyzer] Keep track of escaped locals.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ProgramState.cpp:48-61 +namespace { +struct EscapedLocals{}; +} // namespace + +template <> +struct ProgramStateTrait : + public ProgramStatePartialTrait> { Wait, you are preventing direct

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1230 - "unknown '%0' device kind trait in the 'device' context selector set, expected" - " one of 'host', 'nohost', 'cpu', 'gpu' or 'fpga'">;

[PATCH] D71142: [Sema] Validate large bitfields

rsmith added a comment. It seems fine and reasonable to reject this as a violation of an implementation limit. Can we actually support the full range 2^64 bits range, or would it be wiser to pick a smaller limit? (There's at least no point in allowing bit-widths that would mean the size of the

[PATCH] D71152: [analyzer] Keep track of escaped locals.

NoQ added a comment. I've been hiding these internal traits in ExprEngine lately but i don't have a strong preference. I don't see any immediate need to expose this info to the checkers, nor do i see a need to actively hide it. And, yeah, needs dead region cleanup :)

[PATCH] D71152: [analyzer] Keep track of escaped locals.

NoQ added a comment. Hiding the trait in `ExprEngine` has the additional benefit of disallowing *direct* access to the trait - it can only be accessed through getters. It also doesn't prevent us from exposing the trait to checkers as a method on `ProgramState` in the future, because

[PATCH] D68627: [Sema][X86] Consider target attribute into the checks in validateOutputSize and validateInputSize.

rnk added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2826 + /// valid feature names. + TargetAttr::ParsedTargetAttr + filterFunctionTargetAttrs(const TargetAttr *TD) const; I reverted this because it requires TargetAttr to be complete

[PATCH] D62056: Use ASTDumper to dump the AST from clang-query

steveire closed this revision. steveire added a comment. Committed in b22d8ae7f436bfe63 . I don't know why this review didn't automatically update. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[clang] eff08f4 - Revert "[Sema][X86] Consider target attribute into the checks in validateOutputSize and validateInputSize."

Author: Reid Kleckner Date: 2019-12-06T15:42:14-08:00 New Revision: eff08f40976e177923fe95759917e59375458f71 URL: https://github.com/llvm/llvm-project/commit/eff08f40976e177923fe95759917e59375458f71 DIFF: https://github.com/llvm/llvm-project/commit/eff08f40976e177923fe95759917e59375458f71.diff

[clang-tools-extra] b22d8ae - Use ASTDumper to dump the AST from clang-query

Author: Stephen Kelly Date: 2019-12-06T23:38:56Z New Revision: b22d8ae7f436bfe63b28ceddea743071a6601eb1 URL: https://github.com/llvm/llvm-project/commit/b22d8ae7f436bfe63b28ceddea743071a6601eb1 DIFF: https://github.com/llvm/llvm-project/commit/b22d8ae7f436bfe63b28ceddea743071a6601eb1.diff

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille updated this revision to Diff 232667. serge-sans-paille added a comment. Fix interaction with fortify warnings (cc @efriedma) Also I've checked interactions with the test suite I wrote here https://github.com/serge-sans-paille/fortify-test-suite/ and clang now passes all the

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1230 - "unknown '%0' device kind trait in the 'device' context selector set, expected" - " one of 'host', 'nohost', 'cpu', 'gpu' or 'fpga'">; ABataev wrote: >

[clang] e1578fd - [Sema][X86] Consider target attribute into the checks in validateOutputSize and validateInputSize.

Author: Craig Topper Date: 2019-12-06T15:30:59-08:00 New Revision: e1578fd2b79fe5af5f80c0c166a8abd0f816c022 URL: https://github.com/llvm/llvm-project/commit/e1578fd2b79fe5af5f80c0c166a8abd0f816c022 DIFF: https://github.com/llvm/llvm-project/commit/e1578fd2b79fe5af5f80c0c166a8abd0f816c022.diff

[PATCH] D68627: [Sema][X86] Consider target attribute into the checks in validateOutputSize and validateInputSize.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1578fd2b79f: [Sema][X86] Consider target attribute into the checks in validateOutputSize and… (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71152: [analyzer] Keep track of escaped locals.

xazax.hun created this revision. xazax.hun added reviewers: NoQ, Szelethus, baloghadamsoftware, dcoughlin, haowei. xazax.hun added a project: clang. Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet. xazax.hun added a comment. So

[clang-tools-extra] 60573ae - Remove Expr.h include from ASTContext.h, NFC

Author: Reid Kleckner Date: 2019-12-06T15:30:49-08:00 New Revision: 60573ae6fe509b618dc6a2c5c55d921bccd77608 URL: https://github.com/llvm/llvm-project/commit/60573ae6fe509b618dc6a2c5c55d921bccd77608 DIFF: https://github.com/llvm/llvm-project/commit/60573ae6fe509b618dc6a2c5c55d921bccd77608.diff

[PATCH] D71152: [analyzer] Keep track of escaped locals.

xazax.hun added a comment. So some of the questions that came to my mind: 1. Should this be exposed to the checkers? 2. Where should we actually have this trait registered? ProgramState? ExprEngine? Both of them need access, and due to layering I feel like it cannot be in ExprEngine but I

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

steveire added a comment. I tried using DenseMap, but couldn't make it compile. I stuck with std::map for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61837/new/ https://reviews.llvm.org/D61837

[PATCH] D70877: [WebAssebmly][MC] Support .import_name/.import_field asm directives

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4f4e370b59a: [WebAssebmly][MC] Support .import_name/.import_field asm directives (authored by sbc100). Changed prior to commit: https://reviews.llvm.org/D70877?vs=231619=232660#toc Repository: rG

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a717d5b5d31: Make it possible control matcher traversal kind with ASTContext (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D61837?vs=230678=232661#toc Repository: rG

[clang] 0a717d5 - Make it possible control matcher traversal kind with ASTContext

Author: Stephen Kelly Date: 2019-12-06T23:11:32Z New Revision: 0a717d5b5d31fc2d5bc98ca695031fb09e65beb0 URL: https://github.com/llvm/llvm-project/commit/0a717d5b5d31fc2d5bc98ca695031fb09e65beb0 DIFF: https://github.com/llvm/llvm-project/commit/0a717d5b5d31fc2d5bc98ca695031fb09e65beb0.diff

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3efd6957474: [ObjC] Make sure that the implicit arguments for direct methods have been setup (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f3efd69 - [ObjC] Make sure that the implicit arguments for direct methods have been setup

Author: Alex Lorenz Date: 2019-12-06T14:28:28-08:00 New Revision: f3efd6957474bfd3b9b232ac6e4b3608174c3b79 URL: https://github.com/llvm/llvm-project/commit/f3efd6957474bfd3b9b232ac6e4b3608174c3b79 DIFF: https://github.com/llvm/llvm-project/commit/f3efd6957474bfd3b9b232ac6e4b3608174c3b79.diff

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

arphaman added a comment. In D71091#1773494 , @MadCoder wrote: > @liuliu I wouldn't be surprised this addresses your issues if snapchat is > using PCH This also impacts modules, so builds that use could've been affected. CHANGES SINCE LAST ACTION

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/ https://reviews.llvm.org/D71091 ___ cfe-commits mailing list

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:674 } Record.push_back(D->isInstanceMethod()); Record.push_back(D->isVariadic()); arphaman wrote: > @MadCoder Given the fact that you're now setting SelfDecl and

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder updated this revision to Diff 232644. MadCoder marked an inline comment as done. MadCoder added a comment. @liuliu I wouldn't be surprised this addresses your issues if snapchat is using PCH CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

arphaman added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:674 } Record.push_back(D->isInstanceMethod()); Record.push_back(D->isVariadic()); @MadCoder Given the fact that you're now setting SelfDecl and CmdDecl for

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

aaron.ballman added a comment. In D70469#1766084 , @xazax.hun wrote: > @aaron.ballman > > Type attributes are definitely more flexible as in they can be applied in > more contexts. These attributes, however, make no sense outside of a function >

[PATCH] D71142: [Sema] Validate large bitfields

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5186-5189 +def warn_bitfield_width_exceeds_maximum_width: Error< + "width of bit-field %0 doesn't fit in a 64 bit unsigned integer">; +def

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/ https://reviews.llvm.org/D70804

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder updated this revision to Diff 232641. MadCoder marked an inline comment as done. MadCoder added a comment. woops a bogus hunk went in CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/ https://reviews.llvm.org/D71091 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder added inline comments. Comment at: clang/lib/Sema/SemaDeclObjC.cpp:4839 + ObjCMethod->createImplicitParams(Context, ObjCMethod->getClassInterface()); + MadCoder wrote: > liuliu wrote: > > Yeah, I applied this change. As I said, for my trivial example

[PATCH] D71080: [NFC] Separate getLastArgIntValue to Basic

yaxunl updated this revision to Diff 232639. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71080/new/ https://reviews.llvm.org/D71080 Files: clang/include/clang/Basic/OptionUtils.h

[clang] 040c39d - [analyzer] Fix false positive on introspection of a block's internal layout.

Author: Artem Dergachev Date: 2019-12-06T13:24:20-08:00 New Revision: 040c39d50fb9c60de9020caf86e1a1fccfd6f861 URL: https://github.com/llvm/llvm-project/commit/040c39d50fb9c60de9020caf86e1a1fccfd6f861 DIFF:

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder updated this revision to Diff 232638. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/ https://reviews.llvm.org/D71091 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib/CodeGen/CGObjCMac.cpp clang/lib/Sema/SemaDeclObjC.cpp

[PATCH] D70877: [WebAssebmly][MC] Support .import_name/.import_field asm directives

sbc100 added a comment. Ping .. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70877/new/ https://reviews.llvm.org/D70877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71080: [NFC] Separate getLastArgIntValue to Basic

yaxunl marked 5 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/OptionUtils.h:24 + +class ArgList; + tra wrote: > What are the rules on using LLVM headers here? Can we just include > llvm/Option/ArgList.h instead? In

[PATCH] D70553: [clang-apply-replacements] Add command line option to overwrite readonly files.

aaron.ballman added a comment. In D70553#1773046 , @zturner wrote: > In D70553#1757862 , @aaron.ballman > wrote: > > > Can you add a test case for this functionality? > > > The reason there's no test case is

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1230 - "unknown '%0' device kind trait in the 'device' context selector set, expected" - " one of 'host', 'nohost', 'cpu', 'gpu' or 'fpga'">;

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef AttributeSpelling = +CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))"; if (PP) { aaron.ballman

[PATCH] D71049: Remove implicit conversion that promotes half to other larger precision types for fp classification builtins

aaron.ballman added a comment. Thank you for the patch -- can you add some test cases? Comment at: clang/lib/Sema/SemaChecking.cpp:5835-5836 +"is the only expected cast here"); +Cast->setSubExpr(nullptr); +TheCall->setArg(NumArgs-1, CastArg); +

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

aaron.ballman added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef AttributeSpelling = +CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))"; if (PP) { Mordante wrote: > aaron.ballman wrote: > > This

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

aaron.ballman added a comment. In D71005#1773042 , @bader wrote: > @aaron.ballman, thank you for fixing the problem with documentation > generation. No problem! > With regards to attributes naming question, let me check if I get it right. > > 1. You

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1230 - "unknown '%0' device kind trait in the 'device' context selector set, expected" - " one of 'host', 'nohost', 'cpu', 'gpu' or 'fpga'">; ABataev wrote: >

[clang-tools-extra] a7bdab2 - [clang-tidy] Pass -faligned-allocation on the compiler command line to

Author: Akira Hatanaka Date: 2019-12-06T12:29:21-08:00 New Revision: a7bdab2e9d59ba0fdf06390f4ddadfd00fe50f2e URL: https://github.com/llvm/llvm-project/commit/a7bdab2e9d59ba0fdf06390f4ddadfd00fe50f2e DIFF:

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder marked an inline comment as done. MadCoder added inline comments. Comment at: clang/lib/Sema/SemaDeclObjC.cpp:4839 + ObjCMethod->createImplicitParams(Context, ObjCMethod->getClassInterface()); + liuliu wrote: > Yeah, I applied this change. As I said,

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef AttributeSpelling = +CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))"; if (PP) { aaron.ballman

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

efriedma added a comment. It looks like this patch accidentally suppresses certain warnings when _FORTIFY_SOURCE is enabled. For example, Sema::CheckMemaccessArguments only gets called for recognized builtin functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71142: [Sema] Validate large bitfields

Mordante created this revision. Mordante added reviewers: rsmith, majnemer, aaron.ballman. Mordante added a project: clang. Note: I'm not entirely happy with the text of the diagnostics and I'm open to suggestions. Fixes PR23505: Large bitfield: Assertion `getActiveBits() <= 64 && "Too many

[clang] 779a180 - [OPENMP50]Add if clause in distribute simd directive.

Author: Alexey Bataev Date: 2019-12-06T14:49:49-05:00 New Revision: 779a180d964bf362f26f4c493db749cbbae550c5 URL: https://github.com/llvm/llvm-project/commit/779a180d964bf362f26f4c493db749cbbae550c5 DIFF: https://github.com/llvm/llvm-project/commit/779a180d964bf362f26f4c493db749cbbae550c5.diff

[PATCH] D71134: [OpenMP] Require trivially copyable type for mapping

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71134/new/ https://reviews.llvm.org/D71134

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

bryanpkc updated this revision to Diff 232627. bryanpkc marked 2 inline comments as done. bryanpkc added a comment. Removed unrelated changes from this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/ https://reviews.llvm.org/D70804

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

aaron.ballman added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:693 +StringRef AttributeSpelling = +CPlusPlus14 ? "[[deprecated]]" : "__attribute__((deprecated))"; if (PP) { This attribute also exists with this spelling in C2x,

[PATCH] D71134: [OpenMP] Require trivially copyable type for mapping

Hahnfeld marked 2 inline comments as done. Hahnfeld added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:14917 if (FullCheck && !SemaRef.CurContext->isDependentContext() && - !QTy.isTrivialType(SemaRef.Context)) +

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

liuliu marked an inline comment as done. liuliu added inline comments. Comment at: clang/lib/Sema/SemaDeclObjC.cpp:4839 + ObjCMethod->createImplicitParams(Context, ObjCMethod->getClassInterface()); + Yeah, I applied this change. As I said, for my trivial

[PATCH] D71141: [Wdocumentation] Use C++14 deprecated attribute

Mordante created this revision. Mordante added a reviewer: gribozavr2. Mordante added a project: clang. This replaces the non-standard `__attribute__((deprecated))` with the standard `[[deprecated]]` when compiling in C++14 mode. Discovered while looking at

[PATCH] D71140: [Wdocumentation] Properly place deprecated attribute

Mordante created this revision. Mordante added a reviewer: gribozavr2. Mordante added a project: clang. It is now placed before the function: - allows to replace `__attribute__((deprecated))` with `[[deprecated]]`. - required for trailing returns. Fixes bug:

[PATCH] D71139: [Wdocumentation] Use the command marker

Mordante created this revision. Mordante added a reviewer: gribozavr2. Mordante added a project: clang. Use the proper marker for `-Wdocumentation-deprecated-sync` instead of hard-coded the backslash. Discovered while looking at https://bugs.llvm.org/show_bug.cgi?id=43753 Repository: rG

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

bryanpkc marked 6 inline comments as done. bryanpkc added inline comments. Comment at: clang/test/OpenMP/openmp_offload_registration.cpp:3-5 +// RUN: %clang_cc1 -verify -fopenmp -x c -triple x86_64-unknown-linux-gnu

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder added a comment. In D71091#1773066 , @liuliu wrote: > With this latest fix applied on top of > b220662a45c8067a2ae485ae34c1138d93506df9 > , in our > company's internal code,

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

arphaman requested changes to this revision. arphaman added a comment. This revision now requires changes to proceed. @MadCoder unfortunately this change causes several test failures when `check-clang` runs: Clang :: Analysis/analyzeOneFunction.m Clang :: Index/c-index-api-loadTU-test.m

[clang] dbd1129 - Stop checking whether std::strong_* has ::equivalent members.

Author: Richard Smith Date: 2019-12-06T11:35:41-08:00 New Revision: dbd112972416f48f7e5b117e7a14b6e4b4d38146 URL: https://github.com/llvm/llvm-project/commit/dbd112972416f48f7e5b117e7a14b6e4b4d38146 DIFF: https://github.com/llvm/llvm-project/commit/dbd112972416f48f7e5b117e7a14b6e4b4d38146.diff

[PATCH] D49091: Warn about usage of __has_include/__has_include_next in macro expansions

torarnv added a comment. I'm picking this up on the Qt side and removing our wrapper macro. Does this apply to other cases as well? The standard mentions `_­_­has_­cpp_­attribute`, but what about `__has_builtin`, `__has_attribute`, and `__has_include_next`? Repository: rC Clang CHANGES

[PATCH] D70157: Align branches within 32-Byte boundary

reames added a comment. Recording something so I don't forget it when we get back to the prefix padding version. The write up on the bundle align mode stuff mentions a concerning memory overhead for the feature. Since the basic implementation techniques are similar, we need to make sure we

[PATCH] D70849: [AST] Traverse the class type loc inside the member pointer type loc.

rnk added a comment. We also hit this, and I have a repro here, but it depends on the Chromium Blink GC plugin: https://bugs.chromium.org/p/chromium/issues/detail?id=1031274#c4 I think you just need an RAV client that walks over some particular AST node to trigger the assert. I assume there is

[PATCH] D71134: [OpenMP] Require trivially copyable type for mapping

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:14917 if (FullCheck && !SemaRef.CurContext->isDependentContext() && - !QTy.isTrivialType(SemaRef.Context)) + !QTy.isTriviallyCopyableType(SemaRef.Context)) SemaRef.Diag(SL,

[PATCH] D71080: [NFC] Separate getLastArgIntValue to Basic

tra added inline comments. Comment at: clang/include/clang/Basic/OptionUtils.h:24 + +class ArgList; + What are the rules on using LLVM headers here? Can we just include llvm/Option/ArgList.h instead? Comment at:

[PATCH] D71134: [OpenMP] Require trivially copyable type for mapping

Hahnfeld created this revision. Hahnfeld added reviewers: ABataev, jdoerfert. Herald added subscribers: cfe-commits, guansong. Herald added a project: clang. A trivially copyable type provides a trivial copy constructor and a trivial copy assignment operator. This is enough for the runtime to

[PATCH] D71133: [OpenCL] Add ExtVectorElementExpr constant evaluation (PR42387)

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added a subscriber: yaxunl. Add constexpr evaluation for ExtVectorElementExpr nodes by evaluating the underlying vector expression. Add basic folding too, for the case that Evaluate does not return an LValue.

[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. 2cc11941a2e88236e0b4842229454ae6d85142cd CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70424/new/

[clang] 2cc1194 - clang/AMDGPU: Fix default for frame-pointer attribute

Author: Matt Arsenault Date: 2019-12-07T00:09:10+05:30 New Revision: 2cc11941a2e88236e0b4842229454ae6d85142cd URL: https://github.com/llvm/llvm-project/commit/2cc11941a2e88236e0b4842229454ae6d85142cd DIFF:

  1   2   >