[PATCH] D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

sammccall added a comment. I like the goal here, a few high-level comments: - it seems unfortunate to solve this mostly in xrefs rather than mostly in SelectionTree. All the other clients potentially want this behavior. - the allSelectedNodes API on SelectionTree feels non-orthogonal: it's only

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. F11163406: 0001-Add-extra-tests.patch shows a couple of false positives. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943

[PATCH] D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61162 tests passed, 0 failed and 728 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72041 Files:

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

mstorsjo added a comment. In D71037#1799792 , @mstorsjo wrote: > This broke my builds. I pushed a revert for this for now, to unbreak things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71037/new/

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61165 tests passed, 0 failed and 728 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71963: clang-tidy doc: Add the severities description

sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. ok, thanks! I will remove them tomorrow or the next day. Do you have any guidance about the next steps to add them back? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

arichardson updated this revision to Diff 235724. arichardson marked 9 inline comments as done. arichardson added a comment. - Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71499/new/ https://reviews.llvm.org/D71499 Files:

[clang] 8be5a0f - [OPENMP]Emit artificial threprivate vars as threadlocal, if possible.

Author: Alexey Bataev Date: 2019-12-31T14:11:36-05:00 New Revision: 8be5a0fe12bb9114bb82986b1dcb9205699aa085 URL: https://github.com/llvm/llvm-project/commit/8be5a0fe12bb9114bb82986b1dcb9205699aa085 DIFF: https://github.com/llvm/llvm-project/commit/8be5a0fe12bb9114bb82986b1dcb9205699aa085.diff

[PATCH] D72028: [CodeGen] Emit conj/conjf/confjl libcalls as fneg instructions if possible.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e5a1d279096: [CodeGen] Emit conj/conjf/confjl libcalls as fneg instructions if possible. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5e5a1d2 - [CodeGen] Emit conj/conjf/confjl libcalls as fneg instructions if possible.

Author: Craig Topper Date: 2019-12-31T10:41:00-08:00 New Revision: 5e5a1d27909626169c15b8f63e10d22fcbdf88d9 URL: https://github.com/llvm/llvm-project/commit/5e5a1d27909626169c15b8f63e10d22fcbdf88d9 DIFF: https://github.com/llvm/llvm-project/commit/5e5a1d27909626169c15b8f63e10d22fcbdf88d9.diff

[PATCH] D71963: clang-tidy doc: Add the severities description

aaron.ballman added a comment. In D71963#1800087 , @sylvestre.ledru wrote: > OK, do you want me to prepare a patch to remove the severities? > or to update the values using another list? I think we should remove the severities from the table for now.

[PATCH] D71963: clang-tidy doc: Add the severities description

sylvestre.ledru added a comment. OK, do you want me to prepare a patch to remove the severities? or to update the values using another list? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71963/new/ https://reviews.llvm.org/D71963

[PATCH] D71963: clang-tidy doc: Add the severities description

aaron.ballman added a comment. In D71963#1800056 , @sylvestre.ledru wrote: > > I may have missed this in prior discussions, and if so, I'm sorry -- but > > why are we taking CodeChecker as the model for this? > > I went ahead and use it because: > > -

[PATCH] D72028: [CodeGen] Emit conj/conjf/confjl libcalls as fneg instructions if possible.

craig.topper marked an inline comment as done. craig.topper added inline comments. Comment at: clang/test/CodeGen/complex-libcalls.c:115-118 +// NO__ERRNO-NOT: .conj +// NO__ERRNO-NOT: @conj +// HAS_ERRNO-NOT: .conj +// HAS_ERRNO-NOT: @conj spatel wrote: > Could

[PATCH] D71963: clang-tidy doc: Add the severities description

sylvestre.ledru added a comment. > I may have missed this in prior discussions, and if so, I'm sorry -- but why > are we taking CodeChecker as the model for this? I went ahead and use it because: - it is there and maintained (I contributed to the list a few time) - it is pretty good from my

[PATCH] D71977: Implement additional traverse() overloads

This revision was automatically updated to reflect the committed changes. Closed by commit rG69bb99914f35: Implement additional traverse() overloads (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D71977?vs=235520=235719#toc Repository: rG LLVM Github Monorepo

[PATCH] D71976: Match code following lambdas when ignoring invisible nodes

This revision was automatically updated to reflect the committed changes. Closed by commit rGd89c4cb93807: Match code following lambdas when ignoring invisible nodes (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 06fdbf3 - Unnest struct in Matcher implementation

Author: Stephen Kelly Date: 2019-12-31T17:04:39Z New Revision: 06fdbf3dafb76e54ea76e0eb5f690bc3d6773023 URL: https://github.com/llvm/llvm-project/commit/06fdbf3dafb76e54ea76e0eb5f690bc3d6773023 DIFF: https://github.com/llvm/llvm-project/commit/06fdbf3dafb76e54ea76e0eb5f690bc3d6773023.diff

[clang] d89c4cb - Match code following lambdas when ignoring invisible nodes

Author: Stephen Kelly Date: 2019-12-31T17:04:39Z New Revision: d89c4cb938070a6de11e624984e5bd0e989fb334 URL: https://github.com/llvm/llvm-project/commit/d89c4cb938070a6de11e624984e5bd0e989fb334 DIFF: https://github.com/llvm/llvm-project/commit/d89c4cb938070a6de11e624984e5bd0e989fb334.diff

[PATCH] D72014: [PowerPC]: Add powerpcspe target triple subarch component

jhibbits updated this revision to Diff 235716. jhibbits added a comment. Add triple unit test. I chose freebsd as the OS since that's my environment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72014/new/ https://reviews.llvm.org/D72014 Files:

[PATCH] D71980: [clang-tidy] Disable Checks on If constexpr statements in template Instantiations for BugproneBranchClone and ReadabilityBracesAroundStatements

njames93 added a comment. I have a version with a new DiscaredStmt working, but it's currently lacking test cases, docs and it was pretty much made as a copy paste job from NullStmt so I'm not going to hurry up about trying to polish that one. The new lines and test cases patch I'll get done

[clang] ff429c5 - [OpenCL] Remove redundant foreach in OpenCLBuiltins.td; NFC

Author: Sven van Haastregt Date: 2019-12-31T15:30:02Z New Revision: ff429c5eaf79529aacdc15582c90c0915080e082 URL: https://github.com/llvm/llvm-project/commit/ff429c5eaf79529aacdc15582c90c0915080e082 DIFF: https://github.com/llvm/llvm-project/commit/ff429c5eaf79529aacdc15582c90c0915080e082.diff

[PATCH] D72018: [attributes] [analyzer] Add an attribute to prevent checkers from modeling a function

aaron.ballman added a comment. > What do you think? Is this reasonable or do you have any alternative ideas? This seems like a very specialized attribute for the static analyzer and I'm not certain how much utility it adds, but that may be because I don't understand the analyzer requirements

[PATCH] D71963: clang-tidy doc: Add the severities description

vingeldal added a comment. In D71963#1799956 , @aaron.ballman wrote: > I may have missed this in prior discussions, and if so, I'm sorry -- but why > are we taking CodeChecker as the model for this? I'm not opposed to having > some notion of severity

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2844 +The builtins ``__builtin_align_up``, ``__builtin_align_down``, return their +first argument aligned up/down to the next multiple of the second argument. +The builtin ``__builtin_is_aligned``

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:385 +unsigned getNumArgs(const CallEvent ) { + return Call.getNumArgs() + static_cast(isa(Call)); } steakhal wrote: > I'm not sure why should we adjust

[PATCH] D71980: [clang-tidy] Disable Checks on If constexpr statements in template Instantiations for BugproneBranchClone and ReadabilityBracesAroundStatements

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with newlines in the test files. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71980/new/ https://reviews.llvm.org/D71980 ___ cfe-commits mailing list

[PATCH] D71857: Fixes -Wrange-loop-analysis warnings

aaron.ballman added a comment. It seems like some of the deductions are not spelling out the qualifiers or pointer/references explicitly in some cases, at least from my spot-checking. Can you go back through this patch to make sure we're getting those correct? Comment at:

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

kbobyrev added a comment. For some reason, running this patch on a recent version of the source tree fails. The AST parsing fails with fatal diagnostics, but I can't understand why: E[15:14:33.084] source file unknown type name 'PathRef' is illformed: 1 E[15:15:02.831] source file unknown

[PATCH] D71963: clang-tidy doc: Add the severities description

aaron.ballman added a comment. I may have missed this in prior discussions, and if so, I'm sorry -- but why are we taking CodeChecker as the model for this? I'm not opposed to having some notion of severity for our checks (basically every tool and many coding standards have the same concept),

[PATCH] D71982: [docs] Update path to clang-tools-extra

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:66 -Once you are done, change to the ``llvm/tools/clang/tools/extra`` directory, and +Once you are done, change to the ``llvm/clang-tools-extra`` directory, and let's start!

[PATCH] D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364

aaron.ballman added a comment. In D71846#1798115 , @njames93 wrote: > Sorry I didn't make it obvious with the test cases. The fix will never extend > the lifetime of variables either in the condition or declared in the else > block. It will only apply

[PATCH] D72028: [CodeGen] Emit conj/conjf/confjl libcalls as fneg instructions if possible.

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. Code change LGTM - see inline for a question about the testing. Comment at: clang/test/CodeGen/complex-libcalls.c:115-118 +// NO__ERRNO-NOT: .conj +// NO__ERRNO-NOT: @conj

[PATCH] D71976: Match code following lambdas when ignoring invisible nodes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM assuming the behavioral change did not break anything in clang-tools-extra. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71977: Implement additional traverse() overloads

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71977/new/ https://reviews.llvm.org/D71977

[PATCH] D71857: Fixes -Wrange-loop-analysis warnings

xbolva00 added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp:22 #include "lldb/Target/Process.h" #include "lldb/Utility/Log.h" NFC patch? Repository: rG LLVM Github

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth updated this revision to Diff 235705. JonasToth added a comment. - clarify FIXME problem Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54395/new/ https://reviews.llvm.org/D54395 Files:

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:385 +unsigned getNumArgs(const CallEvent ) { + return Call.getNumArgs() + static_cast(isa(Call)); } I'm not sure why should we adjust (//workaround//) the

[PATCH] D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

steakhal created this revision. steakhal added reviewers: NoQ, Szelethus, boga95. steakhal added a project: clang. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. steakhal added a parent revision:

[PATCH] D71963: clang-tidy doc: Add the severities description

whisperity added a comment. @vingeldal Apologies, in that case. However, I would still claim that `style` (as a //potential// severity) has its purpose for Tidy checkers, not just for `clang-format`. In D71963#1798871 , @vingeldal wrote: > If

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth updated this revision to Diff 235704. JonasToth added a comment. - adjust skipLParens code slightly to remove redundant checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54395/new/ https://reviews.llvm.org/D54395 Files:

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth updated this revision to Diff 235703. JonasToth added a comment. - improve test situation and fix a crash coming from invalid source locations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54395/new/ https://reviews.llvm.org/D54395

[PATCH] D71991: Fix external-names.c test when separator is \\

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c7ca82161b5: Fix external-names.c test when separator is \\ (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71991/new/

[PATCH] D71991: Fix external-names.c test when separator is \\

michaelplatings added a comment. Thanks for accepting. The repo is up to date. I guess the reason the failure hasn't happened with the build bots is that our downstream test setup differs somewhat from the norm - our test runner imports lit.discovery & lit.LitConfig directly rather than using

[clang] 0c7ca82 - Fix external-names.c test when separator is \\

Author: Michael Platings Date: 2019-12-31T11:15:46Z New Revision: 0c7ca82161b519856bb1d54e181b578dc067cd3e URL: https://github.com/llvm/llvm-project/commit/0c7ca82161b519856bb1d54e181b578dc067cd3e DIFF: https://github.com/llvm/llvm-project/commit/0c7ca82161b519856bb1d54e181b578dc067cd3e.diff

[PATCH] D36051: Move from a long list of checkers to tables

sylvestre.ledru added a comment. Thanks. Fixed in https://github.com/llvm/llvm-project/commit/e8c9110b56b516a22b41e95e347bc141814ab87c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36051/new/ https://reviews.llvm.org/D36051

[clang-tools-extra] e8c9110 - clang-tidy doc: modernize-make-unique has an autofix

Author: Sylvestre Ledru Date: 2019-12-31T11:56:17+01:00 New Revision: e8c9110b56b516a22b41e95e347bc141814ab87c URL: https://github.com/llvm/llvm-project/commit/e8c9110b56b516a22b41e95e347bc141814ab87c DIFF:

[PATCH] D36051: Move from a long list of checkers to tables

JonasToth added a comment. In D36051#1799785 , @sylvestre.ledru wrote: > @malcolm.parsons really? Oh, where is it implemented? > >

[PATCH] D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation

mstorsjo added a comment. This broke my builds. A configure test that tries to compile `int main (void) { for( int i = 0; i < 9; i++ ); return 0; }` (a single line source file), with `-Wall` enabled, now triggers failed asserts: clang-10: ../tools/clang/lib/Parse/ParseStmt.cpp:1236: static

[PATCH] D36051: Move from a long list of checkers to tables

sylvestre.ledru added a comment. @malcolm.parsons really? Oh, where is it implemented? https://github.com/llvm/llvm-project/blob/61504079515f76ca094bb836c4d53b41064220d6/clang-tools-extra/clang-tidy/modernize/MakeUniqueCheck.cpp I didn't see it here Repository: rG LLVM Github Monorepo

[PATCH] D36051: Move from a long list of checkers to tables

malcolm.parsons added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:205 + `modernize-make-shared `_, "Yes", "low" + `modernize-make-unique `_, , "low" + `modernize-pass-by-value `_, "Yes", "low" modernize-make-unique offers