[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62286 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73547: [Analyzer] Split container modeling from iterator modeling

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ouch, whoops, i didn't notice the new test file. LGTM then! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73547/new/ https://reviews.llvm.org/D73547

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 241055. serge-sans-paille added a comment. @arichardson doc updated, any other advice? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files:

[PATCH] D73547: [Analyzer] Split container modeling from iterator modeling

baloghadamsoftware added a comment. In D73547#1845339 , @NoQ wrote: > This patch is simply moving code around, right? If so, why did tests need to > be removed? All of the container begin- and end-tests were removed from `iterator-modeling.cpp` and

[PATCH] D73464: [clang] Add TagDecl AST matcher

f00kat added a comment. In D73464#1845511 , @aaron.ballman wrote: > In D73464#1844402 , @f00kat wrote: > > > In D73464#1844310 , @aaron.ballman > > wrote: > > > > > LGTM!

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

jdoerfert added a comment. In D72304#1846115 , @fghanim wrote: > Thanks for trying. > > It compiles fine with me. How can I reproduce the problems you're getting? is > there a way to pack what you have and send it to me so I can have a look? Did you

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim added a comment. Thanks for trying. It compiles fine with me. How can I reproduce the problems you're getting? is there a way to pack what you have and send it to me so I can have a look? Also, a second question, how trustworthy is harbormaster when it says something is buildable?

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

jdoerfert added a comment. I tried to push this today but the build failed: /data/src/llvm-project/llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:252:36: error: use of undeclared identifier 'BumpPtrAllocator' StringMap, BumpPtrAllocator> InternalVars;

[PATCH] D73603: Driver: Add gcc search path for RHEL devtoolset-9

tstellar created this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73603 Files: clang/lib/Driver/ToolChains/Gnu.cpp Index: clang/lib/Driver/ToolChains/Gnu.cpp === ---

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

MaskRay added a comment. In D73500#1846036 , @arphaman wrote: > In D73500#1846003 , @MaskRay wrote: > > > Should they use -nostdlibinc instead? > > > Unfortunately they can't control the flag in this specific case,

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

arphaman added a comment. In D73500#1846003 , @MaskRay wrote: > Should they use -nostdlibinc instead? Unfortunately they can't control the flag in this specific case, only add flags for specific files. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

This revision was automatically updated to reflect the committed changes. Closed by commit rGf96f64d0f279: [driver][Darwin] Add an -ibuiltininc flag that lets Darwin driver include Clang… (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f96f64d - [driver][Darwin] Add an -ibuiltininc flag that lets Darwin driver

Author: Alex Lorenz Date: 2020-01-28T18:18:43-08:00 New Revision: f96f64d0f2793fe720bf847cac4a45d74a81c0ef URL: https://github.com/llvm/llvm-project/commit/f96f64d0f2793fe720bf847cac4a45d74a81c0ef DIFF: https://github.com/llvm/llvm-project/commit/f96f64d0f2793fe720bf847cac4a45d74a81c0ef.diff

[clang] bd31243 - Fix more implicit conversions. Getting closer to having clang working with gcc 5 again

Author: Benjamin Kramer Date: 2020-01-29T02:57:59+01:00 New Revision: bd31243a34da8a045c642ddc77b27b0a45a9bf1e URL: https://github.com/llvm/llvm-project/commit/bd31243a34da8a045c642ddc77b27b0a45a9bf1e DIFF:

[PATCH] D73596: [CodeComplete] WIP member completion for concept-constrained type parameters

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62281 tests passed, 0 failed and 827 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 7 warnings

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

MaskRay added a comment. Should they use -nostdlibinc instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73500/new/ https://reviews.llvm.org/D73500 ___ cfe-commits mailing list

[clang] bb39b52 - Fix conversions in clang and examples

Author: Benjamin Kramer Date: 2020-01-29T02:48:15+01:00 New Revision: bb39b52950e77e650fbdd86f7d5e4b89ff0aac4d URL: https://github.com/llvm/llvm-project/commit/bb39b52950e77e650fbdd86f7d5e4b89ff0aac4d DIFF:

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Okay, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73500/new/ https://reviews.llvm.org/D73500

[PATCH] D73570: [FPEnv][X86] Platform-specific builtin constrained FP enablement

craig.topper added inline comments. Comment at: clang/test/CodeGen/fma-builtins-constrained.c:4 +// RUN: %clang_cc1 -ffreestanding %s -triple=x86_64-apple-darwin -target-feature +fma -S -o - | FileCheck --check-prefix=COMMON --check-prefix=CHECK-ASM %s +// RUN: %clang_cc1

[PATCH] D73596: [CodeComplete] WIP member completion for concept-constrained type parameters

sammccall created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, mgrang, ilya-biryukov. Herald added a project: clang. see https://github.com/clangd/clangd/issues/261 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73596 Files:

[clang] 2b36e85 - GCC5 buildbot made it to clang. Fix implicit conversions it found.

Author: Benjamin Kramer Date: 2020-01-29T02:19:49+01:00 New Revision: 2b36e85542d24161ff4460cb4f0da635e9f5ab62 URL: https://github.com/llvm/llvm-project/commit/2b36e85542d24161ff4460cb4f0da635e9f5ab62 DIFF:

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

arphaman updated this revision to Diff 241029. arphaman marked 2 inline comments as done. arphaman added a comment. Add suggested changes. The `-ibuiltininc` flag now interacts with `-nobuiltininc` as well, i.e. it's cancelled out if `-nobuiltininc` comes after it, and vice-versa. Repository:

[clang-tools-extra] 9a5c448 - [clangd] Fix null check in FindTarget.

Author: Sam McCall Date: 2020-01-29T02:01:42+01:00 New Revision: 9a5c448a31bacc08e73fcae4636094f9b6e2be6a URL: https://github.com/llvm/llvm-project/commit/9a5c448a31bacc08e73fcae4636094f9b6e2be6a DIFF: https://github.com/llvm/llvm-project/commit/9a5c448a31bacc08e73fcae4636094f9b6e2be6a.diff

[clang] 735f90f - Fix one round of implicit conversions found by g++5.

Author: Benjamin Kramer Date: 2020-01-29T01:52:48+01:00 New Revision: 735f90fe42e55935035d842752e01361b5216c11 URL: https://github.com/llvm/llvm-project/commit/735f90fe42e55935035d842752e01361b5216c11 DIFF:

[clang-tools-extra] 0eb64fc - Fix clangd-xpc-test-client build after 777180a32b6107

Author: Nico Weber Date: 2020-01-28T19:48:31-05:00 New Revision: 0eb64fcb89a5b236962b344cc506873ebbf734de URL: https://github.com/llvm/llvm-project/commit/0eb64fcb89a5b236962b344cc506873ebbf734de DIFF: https://github.com/llvm/llvm-project/commit/0eb64fcb89a5b236962b344cc506873ebbf734de.diff

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

mravishankar marked an inline comment as done. mravishankar added inline comments. Comment at: mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp:73 + + using mlir::matchers::m_Val; + auto a = m_Val(block.getArgument(0)); antiagainst wrote: > mravishankar

[clang-tools-extra] 95cb22d - Fix xpc build after 777180a32b6107

Author: Nico Weber Date: 2020-01-28T19:35:11-05:00 New Revision: 95cb22d0f9f3b01703f01baacec3ea6c6d5df22b URL: https://github.com/llvm/llvm-project/commit/95cb22d0f9f3b01703f01baacec3ea6c6d5df22b DIFF: https://github.com/llvm/llvm-project/commit/95cb22d0f9f3b01703f01baacec3ea6c6d5df22b.diff

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

vsk updated this revision to Diff 241019. vsk marked 2 inline comments as done. vsk edited the summary of this revision. vsk added a comment. Rebase, address Florian's feedback. Apologies for the delay here. I haven't had time to push this forward, but I have also been waiting to get an

[PATCH] D73562: [ASTMatchers] Add hasPlacementArg and hasAnyPlacementArg traversal matcher for CXXNewExpr

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62276 tests passed, 1 failed and 827 were skipped. failed: Clang.CodeGenOpenCL/amdgpu-features.cl {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build

[clang] ddf77f1 - One more batch of things found by g++ 6

Author: Benjamin Kramer Date: 2020-01-29T00:50:34+01:00 New Revision: ddf77f10a301d04ab47ede3bed596b21cda44794 URL: https://github.com/llvm/llvm-project/commit/ddf77f10a301d04ab47ede3bed596b21cda44794 DIFF:

[clang] 0d401fa - Fix a couple more implicit conversions that Clang doesn't diagnose.

Author: Benjamin Kramer Date: 2020-01-29T00:42:56+01:00 New Revision: 0d401fa36b532b7d766fd51368b9afb88ad46d1a URL: https://github.com/llvm/llvm-project/commit/0d401fa36b532b7d766fd51368b9afb88ad46d1a DIFF:

[PATCH] D73567: [NFC] Removing experimental designation for ninja in docs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG84118fac3abe: [NFC] Removing experimental designation for ninja in docs. (authored by ncv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73567/new/

[clang] 43a1c80 - Fix another implicit conversion in the directory watcher

Author: Jonas Devlieghere Date: 2020-01-28T15:28:22-08:00 New Revision: 43a1c80508d17fa42c78b690d426105eaa84c539 URL: https://github.com/llvm/llvm-project/commit/43a1c80508d17fa42c78b690d426105eaa84c539 DIFF:

[clang] 84118fa - [NFC] Removing experimental designation for ninja in docs.

Author: Nate Voorhies Date: 2020-01-28T15:28:40-08:00 New Revision: 84118fac3abee44ba89a4cfe1c0c40b254e63830 URL: https://github.com/llvm/llvm-project/commit/84118fac3abee44ba89a4cfe1c0c40b254e63830 DIFF: https://github.com/llvm/llvm-project/commit/84118fac3abee44ba89a4cfe1c0c40b254e63830.diff

[clang] b1a8189 - [NFC] Fix comment typo

Author: Francis Visoiu Mistrih Date: 2020-01-28T15:23:28-08:00 New Revision: b1a8189d7d7584ca22251a94948457b6cad19421 URL: https://github.com/llvm/llvm-project/commit/b1a8189d7d7584ca22251a94948457b6cad19421 DIFF:

[PATCH] D73562: [ASTMatchers] Add hasPlacementArg and hasAnyPlacementArg traversal matcher for CXXNewExpr

njames93 updated this revision to Diff 241012. njames93 added a comment. - Changed isPlacement to hasPlacementArg and hasAnyPlacementArg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73562/new/ https://reviews.llvm.org/D73562 Files:

[clang] 00d834e - Fix more implicit conversions

Author: Jonas Devlieghere Date: 2020-01-28T15:19:27-08:00 New Revision: 00d834e08719c994f12b216c7eb17bbc0c976714 URL: https://github.com/llvm/llvm-project/commit/00d834e08719c994f12b216c7eb17bbc0c976714 DIFF:

[clang] a153d78 - [Driver] Fix implicit conversion guarded by #ifdef _WIN32

Author: Benjamin Kramer Date: 2020-01-29T00:18:45+01:00 New Revision: a153d78c7eb079bcba5ebb37fc1ab9b3c82b99a4 URL: https://github.com/llvm/llvm-project/commit/a153d78c7eb079bcba5ebb37fc1ab9b3c82b99a4 DIFF:

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

dblaikie added a comment. Yeah, in general I think special casing a particular name mangling is probably not a great idea (what about in Microsoft mode with a different mangling scheme?), so I'm somewhat inclined towards doing this in general as @aprantl was suggesting. CHANGES SINCE LAST

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

arichardson added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2259 +``__builtin_memcpy_inline(dst, src, size)`` is identical to +``__builtin_memcpy(dst, src, size)`` expect that the generated code is +guaranteed not to call any external functions. See [LLVM IR

[PATCH] D72829: Implement -fsemantic-interposition

arichardson added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:907 + +.. option:: -fsemantic-interposition, -fno-semantic-interposition + This looks like it should be reordered? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

shafik added a comment. Example as requested, using the same code from `clang/test/CodeGenCXX/debug-info-block-invocation-linkage-name.cpp` the DWARF for block created in `f()` and passed to `g()` as an argument changes from: 0x0052: DW_TAG_subprogram DW_AT_low_pc

[PATCH] D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation

jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:661 +AfterIP = InsertPointTy(ForkBB, ForkBB->end()); + } fghanim wrote: > jdoerfert wrote: > > Why do we need all of this? Can't we just *not do it* instead? This is

[PATCH] D72531: Set traversal explicitly where needed in tests

shafik added a comment. I was looking at the changes to `ASTImporterTest.cpp` and it not obvious to me how you determined where it was needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72531/new/ https://reviews.llvm.org/D72531

[PATCH] D73495: [CodeGen] Attach no-builtin attributes to function definitions with no Decl

gchatelet added a comment. Thx for the fix @thegameg Comment at: clang/lib/CodeGen/CGCall.cpp:1845 + + // First, handle the language options passed through -fno-builtin[-] + if (LangOpts.NoBuiltin) { Can you remove the trailing `[-]`? Repository: rG LLVM

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

Alundra added a comment. @Wawha In the same style of this missing feature, I think you are also aware of the miss of clang-format about struct/array initializer like: https://bugs.llvm.org/show_bug.cgi?id=40411 Basically to have the break for braces after the '=' of the struct/array

[PATCH] D73580: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, hokein, aaron.ballman, njames93, MyDeveloperDay. Eugene.Zelenko added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Herald added a project: clang. Also use //check// in add_new_check.py for

[PATCH] D65270: [CMake] Fix source path generation for install in multi-config (MSBuild)

risa2000 added a comment. I wonder if someone could explain what happened and if this has been dropped because of the comment from @beanz? I am not using XCode so I cannot comment on its requirements nor fix the code for it. Someone has subscribed to this bug on

[PATCH] D73495: [CodeGen] Attach no-builtin attributes to function definitions with no Decl

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e799ada5860: [CodeGen] Attach no-builtin attributes to function definitions with no Decl (authored by thegameg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4e799ad - [CodeGen] Attach no-builtin attributes to function definitions with no Decl

Author: Francis Visoiu Mistrih Date: 2020-01-28T13:59:08-08:00 New Revision: 4e799ada5860d1029ea89226b9b867302e792251 URL: https://github.com/llvm/llvm-project/commit/4e799ada5860d1029ea89226b9b867302e792251 DIFF:

[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62281 tests passed, 0 failed and 827 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D52136: [clang-tidy] Add modernize-concat-nested-namespaces check

wgml added a comment. In D52136#1844384 , @grandinj wrote: > Hi > > Thanks a lot for this checker - would it be possible to enhance it to also > update stuff in associated header files? > > Thanks Check out D61989 ,

[PATCH] D73548: [clang-tidy] Added option for disabling const qualifiers in readability-qualified-auto

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-qualified-auto.rst:41 + auto *const Bar = cast(Baz2); + auto *volatile FooBar = cast(Baz3); + njames93 wrote: > Quuxplusone wrote: > > Is it worth adding

[PATCH] D73495: [CodeGen] Attach no-builtin attributes to function definitions with no Decl

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM There's maybe some argument that we should be calling getNonClosureContext() or something like that to find the parent function, at least for some attributes. But that seems less

[PATCH] D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation

fghanim marked an inline comment as done. fghanim added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:661 +AfterIP = InsertPointTy(ForkBB, ForkBB->end()); + } jdoerfert wrote: > Why do we need all of this? Can't we just *not do

[clang] eaabaf7 - Revert "[MS] Overhaul how clang passes overaligned args on x86_32"

Author: Hans Wennborg Date: 2020-01-28T22:25:07+01:00 New Revision: eaabaf7e04fe98990a8177a3e053346395efde1c URL: https://github.com/llvm/llvm-project/commit/eaabaf7e04fe98990a8177a3e053346395efde1c DIFF: https://github.com/llvm/llvm-project/commit/eaabaf7e04fe98990a8177a3e053346395efde1c.diff

[PATCH] D73464: [clang] Add TagDecl AST matcher

aaron.ballman added a comment. In D73464#1844402 , @f00kat wrote: > In D73464#1844310 , @aaron.ballman > wrote: > > > LGTM! Do you need someone to commit on your behalf? > > > Yes, please. I don`t know how :)

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

aaron.ballman added a comment. In D73457#1844475 , @thakis wrote: > Since we auto-detect -fmsc-version if it's not explicitly installed and since > this warning is on by default, it makes the test suite depend on the > environment a good bit. Given how

[PATCH] D73562: [ASTMatchers] Add isPlacement traversal matcher for CXXNewExpr

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6763 +/// matches the expression 'new (Storage) MyClass()'. +AST_MATCHER(CXXNewExpr, isPlacement) { return Node.getNumPlacementArgs() > 0; } + I think a better

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61841 tests passed, 5 failed and 780 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp

[PATCH] D71469: [AArch64] Add IR intrinsics for sq(r)dmulh_lane(q)

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71469/new/ https://reviews.llvm.org/D71469

[PATCH] D72829: Implement -fsemantic-interposition

MaskRay accepted this revision. MaskRay added a comment. In D72829#1845396 , @serge-sans-paille wrote: > > I suppose you mean whether "SemanticInterposition" should be invalidated > > when "PIC Level" does not exist or "PIE Level" exists. I am a bit

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. > I suppose you mean whether "SemanticInterposition" should be invalidated when > "PIC Level" does not exist or "PIE Level" exists. I am a bit inclined to make > it more flexible/orthogonal in the backend,

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 240966. serge-sans-paille marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:2531 +}); + auto Env = Ok, this comment is more a discussion point rather than a review comment. Was there a reason you needed to put the TrailingCommaInserter pass after the

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay added a comment. Nit: please add a release note and regenerate the ClangFormatStyleOptions.rst (if there are any changes because you modified Format.h). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326

[PATCH] D73547: [Analyzer] Split container modeling from iterator modeling

NoQ added a comment. This patch is simply moving code around, right? If so, why did tests need to be removed? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73547/new/ https://reviews.llvm.org/D73547 ___ cfe-commits

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

ilya-biryukov added a comment. I've opted for duplicating the common flags across all the introduced enums (contains-unexpanded-pack, instantiation-dependent) , this is somewhat ugly, but everything else is even more complicated to use. Less enums would also be a good idea probably, see the

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

ilya-biryukov updated this revision to Diff 240958. ilya-biryukov marked an inline comment as done and an inline comment as not done. ilya-biryukov added a comment. - Use different types for different AST categories - Rename to getDependence Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D73570: [FPEnv][X86] Platform-specific builtin constrained FP enablement

kpn created this revision. kpn added reviewers: craig.topper, andrew.w.kaylor. Herald added a project: clang. Herald added a subscriber: cfe-commits. [FPEnv][X86] Platform-specific builtin constrained FP enablement When constrained floating point is enabled the X86-specific builtins don't use

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3659 // Use llvm function name. -Name = Fn->getName(); +if (Fn->getName().startswith("___Z")) + LinkageName = Fn->getName(); shafik wrote: > dblaikie wrote: > >

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

shafik marked an inline comment as done. shafik added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3659 // Use llvm function name. -Name = Fn->getName(); +if (Fn->getName().startswith("___Z")) + LinkageName = Fn->getName();

[PATCH] D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation

jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:661 +AfterIP = InsertPointTy(ForkBB, ForkBB->end()); + } Why do we need all of this? Can't we just *not do it* instead? This is code complexity that we should avoid.

[PATCH] D73567: [NFC] Removing experimental designation for ninja in docs.

ncv created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ncv added a reviewer: nikola. Ninja is no longer an experimental tool, documentation changed to reflect this. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73567 Files:

[PATCH] D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation

fghanim updated this revision to Diff 240949. fghanim added a comment. - Squashing all the commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73285/new/ https://reviews.llvm.org/D73285 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D73299: [HIP] Fix environment variable HIP_DEVICE_LIB_PATH

yaxunl added a comment. In D73299#1845162 , @thakis wrote: > This breaks check-clang on Windows: http://45.33.8.238/win/6843/step_7.txt > > You probably want "env FOO=bar" instead of "FOO=bar" in the test file. Fixed. Thanks. Repository: rG LLVM

[clang] b8d9ac0 - Fix test hip-device-libs.hip

Author: Yaxun (Sam) Liu Date: 2020-01-28T13:58:18-05:00 New Revision: b8d9ac08703b1ae9c3cd721c39774053786a9980 URL: https://github.com/llvm/llvm-project/commit/b8d9ac08703b1ae9c3cd721c39774053786a9980 DIFF:

[PATCH] D73299: [HIP] Fix environment variable HIP_DEVICE_LIB_PATH

thakis added a comment. This breaks check-clang on Windows: http://45.33.8.238/win/6843/step_7.txt You probably want "env FOO=bar" instead of "FOO=bar" in the test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73299/new/

[PATCH] D73562: [ASTMatchers] Add isPlacement traversal matcher for CXXNewExpr

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62272 tests passed, 1 failed and 827 were skipped. failed: Clang.CodeGenOpenCL/amdgpu-features.cl {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

kpyzhov added a comment. I've pushed the fix already. Is something still broken? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://reviews.llvm.org/D72723 ___ cfe-commits mailing list

[PATCH] D72829: Implement -fsemantic-interposition

MaskRay added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3011 + if (Args.hasArg(OPT_fsemantic_interposition) && Opts.PICLevel && !Opts.PIE) +Opts.SemanticInterposition = 1; + `Opts.SemanticInterposition` is initialized to 0 and

[clang] 987aa34 - Corrected clang amdgpu-features.cl test for 6d614a82a4230ea69e322f56dc18dcbd815ed37b (AMDGPU MFMA built-ins)

Author: Konstantin Pyzhov Date: 2020-01-28T05:41:42-05:00 New Revision: 987aa3435f4517d663f776e261683b1620eb8101 URL: https://github.com/llvm/llvm-project/commit/987aa3435f4517d663f776e261683b1620eb8101 DIFF:

[PATCH] D72829: Implement -fsemantic-interposition

MaskRay added a comment. In D72829#1844050 , @serge-sans-paille wrote: > @MaskRay should we add a verifier step to check that > pie/pic/semanticinterposition module flags are consistent, or leave that to > clang ? I suppose you mean whether

[PATCH] D73231: [CUDA] Assume the latest known CUDA version if we've found an unknown one.

tra added a subscriber: hans. tra added a comment. @hans : that's another candidate for 10.x cherry-pick, if you're OK with it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73231/new/ https://reviews.llvm.org/D73231

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

njames93 added a comment. In D72527#1845009 , @Eugene.Zelenko wrote: > Rebase from master. Committed, I still not 100% sure on landing on behalf of someone else so I think it hasn't credited you unfortunately, arc should have better docs...

[PATCH] D73231: [CUDA] Assume the latest known CUDA version if we've found an unknown one.

This revision was automatically updated to reflect the committed changes. Closed by commit rG12fefeef203a: [CUDA] Assume the latest known CUDA version if weve found an unknown one. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73184: [CodeGen] Emit IR for compound assignment with fixed-point operands.

rjmccall added a comment. Please test the cases where the result is used; this should be handled for you automatically, but still. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73184/new/ https://reviews.llvm.org/D73184

[PATCH] D72723: Built-in functions for AMDGPU MFMA instructions.

thakis added a comment. Things have been broken for 1.5 hours now. Time to revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72723/new/ https://reviews.llvm.org/D72723 ___ cfe-commits mailing list

[clang] 12fefee - [CUDA] Assume the latest known CUDA version if we've found an unknown one.

Author: Artem Belevich Date: 2020-01-28T10:11:42-08:00 New Revision: 12fefeef203ab4ef52d19bcdbd4180608a4deae1 URL: https://github.com/llvm/llvm-project/commit/12fefeef203ab4ef52d19bcdbd4180608a4deae1 DIFF:

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

This revision was automatically updated to reflect the committed changes. Closed by commit rG66e47a57205b: [clang-tidy] adjust scripts to subsubsections in Release Notes (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 6 inline comments as done. mibintc added a comment. In D72841#1842772 , @andrew.w.kaylor wrote: > It's not clear to me from reading this how the "precise" control is going to > work with relation to the fast math flags. I don't think MSVC

[PATCH] D73183: [CodeGen] Emit IR for fixed-point unary operators.

rjmccall added a comment. Please test prefix increment/decrement as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73183/new/ https://reviews.llvm.org/D73183 ___ cfe-commits mailing list

[PATCH] D73545: Fix a crash when casting _Complex and ignoring the results

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in 554791928088d6139e0fb3480d79cd76ea59198f CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73545/new/ https://reviews.llvm.org/D73545

[PATCH] D73536: [analyser][taint] Remove taint from symbolic expressions if used in comparisons

NoQ requested changes to this revision. NoQ added a comment. This revision now requires changes to proceed. > Describing value constraints in the taint config file is unfeasible. This is the only correct way to go, because, as you yourself point out, every sink function (or other use of tainted

[clang-tools-extra] 66e47a5 - [clang-tidy] adjust scripts to subsubsections in Release Notes

Author: Nathan James Date: 2020-01-28T18:10:22Z New Revision: 66e47a57205b1c2a6be3c89413ae9d47b747ed38 URL: https://github.com/llvm/llvm-project/commit/66e47a57205b1c2a6be3c89413ae9d47b747ed38 DIFF: https://github.com/llvm/llvm-project/commit/66e47a57205b1c2a6be3c89413ae9d47b747ed38.diff LOG:

[clang] 5547919 - Fix a crash when casting _Complex and ignoring the results.

Author: Aaron Ballman Date: 2020-01-28T13:05:56-05:00 New Revision: 554791928088d6139e0fb3480d79cd76ea59198f URL: https://github.com/llvm/llvm-project/commit/554791928088d6139e0fb3480d79cd76ea59198f DIFF: https://github.com/llvm/llvm-project/commit/554791928088d6139e0fb3480d79cd76ea59198f.diff

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

svenvh added a comment. In D71460#1844959 , @Anastasia wrote: > Adding @svenvh mainly to check if any fix is needed for the TableGen BIFs too? Yes I believe we should also update `clang/lib/Sema/OpenCLBuiltins.td`. CHANGES SINCE LAST ACTION

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

Eugene.Zelenko updated this revision to Diff 240922. Eugene.Zelenko added a comment. Rebase from master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72527/new/ https://reviews.llvm.org/D72527 Files:

[PATCH] D73360: [OpenCL] Restrict address space conversions in nested pointers

rjmccall requested changes to this revision. rjmccall added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Misc/warning-flags.c:41 CHECK-NEXT: warn_asm_label_on_auto_decl +CHECK-NEXT: warn_bad_cxx_cast_nested_pointer_addr_space

[PATCH] D73545: Fix a crash when casting _Complex and ignoring the results

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73545/new/ https://reviews.llvm.org/D73545 ___ cfe-commits mailing list

  1   2   3   >