[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr marked an inline comment as done. alexeyr added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-redundant-expression.cpp:114 if (P.a[X++] != P.a[X++]) return 1; + if (X && X++ && X) return 1; aaron.ballman wrote: >

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr marked an inline comment as done. alexeyr added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-redundant-expression.cpp:114 if (P.a[X++] != P.a[X++]) return 1; + if (X && X++ && X) return 1; alexeyr wrote: >

[PATCH] D73865: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition

MaskRay reopened this revision. MaskRay added a comment. Accidentally committed. Sorry.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73865/new/ https://reviews.llvm.org/D73865 ___ cfe-commits

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr updated this revision to Diff 242266. alexeyr added a comment. Added tests for overloaded operators and fixed parent check logic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73775/new/ https://reviews.llvm.org/D73775 Files:

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17254 +SourceLocation(), Context.getTranslationUnitDecl()); + } Thanks, this looks a lot better. Should this be moved to SemaOpenMP.cpp (and renamed to be OpenMP-specific), or

LLVM buildmaster will be updated and restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl updated this revision to Diff 242251. yaxunl marked 5 inline comments as done. yaxunl added a comment. revised by John's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70172/new/ https://reviews.llvm.org/D70172 Files: clang/include/clang/Sema/Sema.h

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey updated this revision to Diff 242250. awpandey added a comment. Hi @dblaikie, I removed the condition and put false as the third argument of PrintBool. I have also removed the updated bitcode file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73462/new/

[PATCH] D73942: [hip] Properly populate macros based on host processor.

hliao created this revision. hliao added reviewers: tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - The device compilation needs to have a consistent source code compared to the corresponding host compilation. If macros based on the host-specific target

[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

rsmith added a comment. It would be really useful to provide these extra parameters to `FindAllocationFunctions` too. For example, we could support direct dispatch to a size-class-specific allocation function: void *operator new(std::size_t n) __attribute__((enable_if(n == 16, "optimized

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith added a comment. In D67678#1836953 , @dexonsmith wrote: > In D67678#1836922 , @rsmith wrote: > > > If there's no timeline to update the macOS SDK, then perhaps we could add a > > hack to Clang to allow

[PATCH] D73513: [memtag] Plug in stack safety analysis.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:670 + if (AllocaRange.contains(AS.Use.Range)) { +

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Some nits and very minor things, but I think this is generally good to go with those fixed. Sorry for the long review delay, and thanks for working on it! Comment at:

[PATCH] D73937: [Driver] Change -fmax-tokens $arg to -fmax-tokens=$arg

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62431 tests passed, 0 failed and 845 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73937: [Driver] Change -fmax-tokens $arg to -fmax-tokens=$arg

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62431 tests passed, 0 failed and 845 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73937: [Driver] Change -fmax-tokens $arg to -fmax-tokens=$arg

MaskRay updated this revision to Diff 242236. MaskRay added a comment. Update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73937/new/ https://reviews.llvm.org/D73937 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D73937: [Driver] Change -fmax-tokens $arg to -fmax-tokens=$arg

MaskRay created this revision. MaskRay added reviewers: hans, rnk, rsmith, thakis. Herald added subscribers: cfe-commits, usaxena95, kadircet, ilya-biryukov. Herald added a project: clang. `-foption $arg` is very uncommon in clangDriver (especially a Separate without a corresponding Joined).

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

dblaikie added a comment. Might be easier in smaller patches - Bitcode & IR support, then LLVM/codegen emission and Clang/IR gen. > I have to update dityperefs-3.8.ll and dityperefs-3.8.ll.bc because they are > no longer compatible with this patch. The bitcode files in test/Bitcode generally

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

shafik added a comment. In D73282#1855888 , @dblaikie wrote: > I don't think the more targeted fix is a good thing - is the same problem of > not demangling names not there for the other cases that the original fix > addressed? AFAIK no, the other

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

jroelofs added a comment. +1, looks good with a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73904/new/ https://reviews.llvm.org/D73904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62417 tests passed, 0 failed and 845 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rGac430336318a: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC] (authored by kkwli0). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ac43033 - [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

Author: Kelvin Li Date: 2020-02-03T18:30:36-05:00 New Revision: ac430336318a1abe6e4726e8df49ee0e6b779691 URL: https://github.com/llvm/llvm-project/commit/ac430336318a1abe6e4726e8df49ee0e6b779691 DIFF: https://github.com/llvm/llvm-project/commit/ac430336318a1abe6e4726e8df49ee0e6b779691.diff

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17127 + template + class UsedDeclVisitor : public EvaluatedExprVisitor>{ + protected: This should inherit from `EvaluatedExprVisitor`, or else calls from `EvaluatedExprVisitor` and

[PATCH] D72972: [WebAssembly] Add experimental multivalue calling ABI

tlively marked 3 inline comments as done. tlively added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:741 + explicit WebAssemblyABIInfo(CodeGen::CodeGenTypes , ABIKind _Kind) + : SwiftABIInfo(CGT), defaultInfo(CGT), Kind(_Kind) {} aheejin

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker added a comment. @aaron.ballman do you think you can review this ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

dblaikie added a comment. I don't think the more targeted fix is a good thing - is the same problem of not demangling names not there for the other cases that the original fix addressed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73282/new/ https://reviews.llvm.org/D73282

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram updated this revision to Diff 242196. tmsriram added a comment. Splitting the clang patch into several pieces: 1. This is the parent patch and just contains support for basic block section options. 2. A separate patch for unique internal function names 3. A separate patch for an option

[PATCH] D71092: [VFS] More consistent support for Windows

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71092/new/ https://reviews.llvm.org/D71092 ___ cfe-commits mailing list

[PATCH] D73926: [WebAssembly] Enable recently implemented SIMD operations

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62428 tests passed, 0 failed and 845 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71092: [VFS] More consistent support for Windows

amccarth updated this revision to Diff 242190. amccarth marked an inline comment as done. amccarth added a comment. Addressed rnk's comments: fixed path style detection bug, and used `StringRef::endswith`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71092/new/

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62417 tests passed, 0 failed and 845 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 6 warnings

[PATCH] D73926: [WebAssembly] Enable recently implemented SIMD operations

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. Moves a batch of instructions from unimplemented-simd128 to simd128 because they have

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri added a comment. bump @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73380/new/ https://reviews.llvm.org/D73380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73020: [Sema] Perform call checking when building CXXNewExpr

lebedev.ri added a comment. bump @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73020/new/ https://reviews.llvm.org/D73020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71092: [VFS] More consistent support for Windows

amccarth marked 3 inline comments as done. amccarth added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:-1113 + sys::path::Style style = sys::path::Style::posix; + if (sys::path::is_absolute(WorkingDir.get(), sys::path::Style::windows)) { +style =

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG, but still would be good to add some references to the standard. Some of the features use special wording, which very hard to find in the standard. CHANGES SINCE LAST ACTION

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 marked 2 inline comments as done. kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:216

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 updated this revision to Diff 242166. kkwli0 added a comment. Change `requires unified_address` status to partial. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72901/new/ https://reviews.llvm.org/D72901 Files: clang/docs/OpenMPSupport.rst Index:

[clang] 4b05fc2 - [analyzer] Suppress linker invocation in scan-build tests.

Author: Artem Dergachev Date: 2020-02-04T00:12:24+03:00 New Revision: 4b05fc248b0068e203f27bea034020f137a6de2c URL: https://github.com/llvm/llvm-project/commit/4b05fc248b0068e203f27bea034020f137a6de2c DIFF:

[PATCH] D69781: [analyzer] Add test directory for scan-build

This revision was automatically updated to reflect the committed changes. Closed by commit rG5521236a1807: [analyzer] Re-land 0aba69e Add test directory for scan-build. (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D69781?vs=227815=242164#toc Repository: rG

[clang] 5521236 - [analyzer] Re-land 0aba69e "Add test directory for scan-build."

Author: Artem Dergachev Date: 2020-02-03T23:59:57+03:00 New Revision: 5521236a18074584542b81fd680158d89a845fca URL: https://github.com/llvm/llvm-project/commit/5521236a18074584542b81fd680158d89a845fca DIFF:

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62418 tests passed, 0 failed and 845 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 2 warnings

[PATCH] D71155: [analyzer] CERT: STR30-C

Charusso added a comment. Thanks! I have felt that may I create a too complex symbolic value. Sorry for stealing your time. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2097-2098 +void CStringChecker::evalCharPtrCommon(CheckerContext , +

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62418 tests passed, 0 failed and 845 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 2 warnings

[PATCH] D71155: [analyzer] CERT: STR30-C

Charusso updated this revision to Diff 242159. Charusso marked 8 inline comments as done. Charusso added a comment. - Remove the modeling from CStringChecker. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71155/new/ https://reviews.llvm.org/D71155 Files:

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman updated this revision to Diff 242155. dgoldman added a comment. - Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73916/new/ https://reviews.llvm.org/D73916 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[clang-tools-extra] 80e63c1 - Revert "[clang-doc] Improving Markdown Output"

Author: Petr Hosek Date: 2020-02-03T12:27:09-08:00 New Revision: 80e63c17c0a4f02a730b8d00a426fcf0e018f9bb URL: https://github.com/llvm/llvm-project/commit/80e63c17c0a4f02a730b8d00a426fcf0e018f9bb DIFF: https://github.com/llvm/llvm-project/commit/80e63c17c0a4f02a730b8d00a426fcf0e018f9bb.diff

[PATCH] D72954: [clang-doc] Improving Markdown Output

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fbaf3a7c239: [clang-doc] Improving Markdown Output (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72954/new/

[PATCH] D73916: [clang] Add `forceReload` clangd extension to 'textDocument/didChange'

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, jfb, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. - This option forces a preamble rebuild to handle the odd case of a

[PATCH] D73856: [docu] Improve docu of misc-misplaced-const

AlexanderLanin abandoned this revision. AlexanderLanin added a comment. @aaron.ballman I was ready to complain, but you are right. It would make absolutely no sense to move the const, it's just where it should be. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 0fbaf3a - [clang-doc] Improving Markdown Output

Author: Petr Hosek Date: 2020-02-03T12:14:17-08:00 New Revision: 0fbaf3a7c2395d751cfa4ecd7f483f077b03d9bd URL: https://github.com/llvm/llvm-project/commit/0fbaf3a7c2395d751cfa4ecd7f483f077b03d9bd DIFF: https://github.com/llvm/llvm-project/commit/0fbaf3a7c2395d751cfa4ecd7f483f077b03d9bd.diff

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl updated this revision to Diff 242145. yaxunl added a comment. revised by John's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70172/new/ https://reviews.llvm.org/D70172 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaCUDA.cpp

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim updated this revision to Diff 242144. fghanim added a comment. Addressing errors/warnings from commit build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/ https://reviews.llvm.org/D72304 Files:

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

jkorous added a comment. We should either simplify the implementation to reflect that we don't support e. g. `*:42` (seems preferable to me) or have the codepaths that are currently not accessible through `-fverify` tested by other means. Comment at:

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson marked 3 inline comments as done. tejohnson added inline comments. Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:830 enum Kind { +Unknown, ///< Unknown (analysis not performed, don't lower) Unsat, ///< Unsatisfiable type (i.e. no global has

[PATCH] D73842: [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

ianlevesque marked 2 inline comments as done. ianlevesque added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:832 +Fn->addFnAttr("xray-skip-exit"); + } + if (!CGM.getCodeGenOpts().XRayInstrumentationBundle.has( @hiraditya I

[libunwind] 221c5af - Fix a -Wbitwise-conditional-parentheses warning in _LIBUNWIND_ARM_EHABI libunwind builds

Author: Nico Weber Date: 2020-02-03T14:17:50-05:00 New Revision: 221c5af4e4f4a504a4d1f352dd7b76d305e56a62 URL: https://github.com/llvm/llvm-project/commit/221c5af4e4f4a504a4d1f352dd7b76d305e56a62 DIFF: https://github.com/llvm/llvm-project/commit/221c5af4e4f4a504a4d1f352dd7b76d305e56a62.diff

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

dmgreen added a comment. I added some `This?`'s around, which may or may not be needed too. Comment at: llvm/include/llvm/Support/ARMTargetParser.h:196 unsigned DefaultFPU; unsigned ArchBaseExtensions; T ID; This? Comment at:

[PATCH] D73852: [clang] detect switch fallthrough marked by a comment (PR43465)

This revision was automatically updated to reflect the committed changes. Closed by commit rG398b4ed87d48: [clang] detect switch fallthrough marked by a comment (PR43465) (authored by llunak). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D73282: Fix debug-info generation for block invocations so that we set the LinkageName instead of the Name

shafik added a comment. Also note that blocks are an clang extension and also work in C whereas lambdas are a standard C++ feature and naming although implementation defined mostly falls out of the fact that C++ has member functions and so can be placed inside class as `operator()`. CHANGES

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62298 tests passed, 121 failed and 845 were skipped. failed: Clang.CXX/modules-ts/basic/basic_link/p3.cppm failed: Clang.CXX/modules-ts/codegen-basics.cppm failed: Clang.CodeGen/arm-aapcs-vfp.c failed:

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-redundant-expression.cpp:114 if (P.a[X++] != P.a[X++]) return 1; + if (X && X++ && X) return 1; alexeyr wrote: > aaron.ballman wrote: > > What do you think

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

miyuki updated this revision to Diff 242114. miyuki added a comment. Fix one missing unsigned->uint64_t occurrence CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73906/new/ https://reviews.llvm.org/D73906 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D73865: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG789a46f2d742: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition (authored by MaskRay). Repository:

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

peter.smith added a comment. I think this is the right thing to do. According to https://sourceware.org/binutils/docs/ld/Options.html#Options Add the archive or object file specified by namespec to the list of files to link. This option may be used any number of times. If namespec is of the

[PATCH] D73900: [BPF] use base lvalue type for preserve_{struct,union}_access_index metadata

anakryiko accepted this revision. anakryiko added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73900/new/ https://reviews.llvm.org/D73900

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:411 + if (ExplodedNode *N = C.generateErrorNode(State)) { +// FIXME Add detailed diagnostic. +std::string Msg = "Function argument constraint is not

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

miyuki created this revision. miyuki added reviewers: simon_tatham, eli.friedman, ostannard, dmgreen. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch changes the underlying type of the ARM::ArchExtKind enumeration to

[PATCH] D73897: [analyzer] StdLibraryFunctionsChecker refactor: remove macros

NoQ added a comment. This looks fantastic, i didn't think of this originally. All hail type safety! Nits below. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:182 + +FunctionSummaryTy (ValueRangeSet VRS) { + Ranges.push_back(VRS);

[clang] 6c3252e - [OPENMP][DOCS]Update status of conditional lastprivate, NFC.

Author: Alexey Bataev Date: 2020-02-03T12:43:40-05:00 New Revision: 6c3252e5211b0c6ce6eb4a1123d60bb74faec0be URL: https://github.com/llvm/llvm-project/commit/6c3252e5211b0c6ce6eb4a1123d60bb74faec0be DIFF: https://github.com/llvm/llvm-project/commit/6c3252e5211b0c6ce6eb4a1123d60bb74faec0be.diff

[clang] a781521 - [OPENMP50]Codegen support for order(concurrent) clause.

Author: Alexey Bataev Date: 2020-02-03T12:27:33-05:00 New Revision: a781521867e9952e8d5856e10bf900b37f8ec4e8 URL: https://github.com/llvm/llvm-project/commit/a781521867e9952e8d5856e10bf900b37f8ec4e8 DIFF: https://github.com/llvm/llvm-project/commit/a781521867e9952e8d5856e10bf900b37f8ec4e8.diff

[PATCH] D73897: [analyzer] StdLibraryFunctionsChecker refactor: remove macros

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62099 tests passed, 5 failed and 784 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62418 tests passed, 0 failed and 845 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:3412-3414 +def fsycl : Flag<["-"], "fsycl">, Group, + HelpText<"Enable SYCL kernels compilation for device">; +def sycl_std_EQ : Joined<["-"], "sycl-std=">, Group, Flags<[CC1Option]>,

[PATCH] D69591: Devirtualize a call on alloca without waiting for post inline cleanup and next DevirtSCCRepeatedPass iteration.

yamauchi updated this revision to Diff 242103. yamauchi added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69591/new/ https://reviews.llvm.org/D69591 Files: clang/test/CodeGenCXX/member-function-pointer-calls.cpp

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof created this revision. christof added reviewers: peter.smith, jroelofs. Herald added a project: clang. Herald added a subscriber: cfe-commits. When the clang baremetal driver selects the rt.builtins static library it prefix with "-l" and appends ".a". The result is a nonsense option

[PATCH] D73903: [AArch64][SVE] Add remaining SVE2 intrinsics for widening DSP operations

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, dancgr, efriedma, c-rhodes. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. kmclaughlin added a parent revision: D73719:

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked an inline comment as done. bader added inline comments. Comment at: clang/include/clang/Driver/Options.td:3412-3414 +def fsycl : Flag<["-"], "fsycl">, Group, + HelpText<"Enable SYCL kernels compilation for device">; +def sycl_std_EQ : Joined<["-"], "sycl-std=">,

[PATCH] D73900: [BPF] use base lvalue type for preserve_{struct,union}_access_index metadata

yonghong-song created this revision. yonghong-song added reviewers: ast, anakryiko. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Linux commit

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

jdoerfert marked 4 inline comments as done. jdoerfert added a comment. In D71830#1854989 , @kiranchandramohan wrote: > Had a quick look today. Will spend some more time tomorrow. > Please see a few comments inline. Thanks! I'll rebase asap to address

[PATCH] D69781: [analyzer] Add test directory for scan-build

NoQ reopened this revision. NoQ added a comment. This revision is now accepted and ready to land. I'll try to re-land this. I heard there were a lot more issues than just honoring `CLANG_INSTALL_SCANBUILD=NO` (which i'll do my best to test before pushing), so i'll monitor the buildbots

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

kiranchandramohan added a comment. Had a quick look today. Will spend some more time tomorrow. Please see a few comments inline. Comment at: clang/include/clang/AST/OpenMPClause.h:6429 +/// and an ordered collection of properties. +struct OpenMPTraitInfo { + struct

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

NoQ added a comment. Also, yay, thanks for using the new API! Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:41 const SVal = UndefinedVal()) const; - void handleAssign(CheckerContext , const SVal ) const; - void

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:731 + } + return C.getNoteTag([Text, Name](BugReport ) -> std::string { + SmallString<256> Msg; You'll need to check whether the container is actually of

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:194 +--+--+--+---+ -|

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong created this revision. martong added a reviewer: NoQ. Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project: clang. Repository: rG LLVM

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

NoQ added a comment. Other than the packaging debate, i think this check looks good! Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:641 -} // end: "optin.cplusplus" - -let ParentPackage = CplusplusAlpha in { - -def ContainerModeling :

[PATCH] D73897: [analyzer] StdLibraryFunctionsChecker refactor: remove macros

martong created this revision. martong added a reviewer: NoQ. Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project: clang. Repository: rG LLVM

[PATCH] D73520: [analyzer] BugReporterVisitors: Refactor and documentation

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:195 + + static const char *getTag() { return "FindLastStore"; } + Charusso wrote: > I have made every tag a small-string. This way it's harder to

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

simoncook updated this revision to Diff 242082. simoncook added a comment. Rebase changes on top of experimental feature support (D73891 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/

[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72901/new/ https://reviews.llvm.org/D72901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

simoncook updated this revision to Diff 242080. simoncook added a comment. Don't put option in m_riscv_Features_Group, we don't want it being handled like a feature. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73891/new/ https://reviews.llvm.org/D73891 Files:

[PATCH] D71433: [analyzer] CERT: POS34-C

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/PutenvWithAutoChecker.cpp:57-58 +bugreporter::trackExpressionValue(Report->getErrorNode(), ArgExpr, *Report); + } else if (const SymbolRef Sym = + ArgV.getAsSymbol()) { // It is

[PATCH] D71155: [analyzer] CERT: STR30-C

NoQ added a comment. Let's separate `CStringChecker` improvements into a separate patch and have a separate set of tests for it. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2097-2098 +void CStringChecker::evalCharPtrCommon(CheckerContext , +

[PATCH] D73876: [clang-tidy] Fix a false positive about C++17 deduced class template types in unused-using-decl check.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d4c23b349f8: [clang-tidy] Fix a false positive about C++17 deduced class template types in… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73876: [clang-tidy] Fix a false positive about C++17 deduced class template types in unused-using-decl check.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62415 tests passed, 0 failed and 839 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[clang-tools-extra] 7d4c23b - [clang-tidy] Fix a false positive about C++17 deduced class template types in unused-using-decl check.

Author: Haojian Wu Date: 2020-02-03T16:25:10+01:00 New Revision: 7d4c23b349f8d0575304182650850f2594935d7c URL: https://github.com/llvm/llvm-project/commit/7d4c23b349f8d0575304182650850f2594935d7c DIFF: https://github.com/llvm/llvm-project/commit/7d4c23b349f8d0575304182650850f2594935d7c.diff

[PATCH] D72954: [clang-doc] Improving Markdown Output

Clayton updated this revision to Diff 242066. Clayton added a comment. build error fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72954/new/ https://reviews.llvm.org/D72954 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/MDGenerator.cpp

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. In D72705#1854641 , @baloghadamsoftware wrote: > Please add tests for all the functions in the list. How to handle the combinatoric explosion in test code? It is too much code to add all functions to

  1   2   >