[PATCH] D74591: [Driver] Rename AddGoldPlugin to addLTOOptions. NFC

MaskRay created this revision. MaskRay added reviewers: evgeny777, tejohnson. Herald added subscribers: cfe-commits, dexonsmith, inglorion, emaste. Herald added a project: clang. AddGoldPlugin does more than adding `-plugin path/to/LLVMgold.so`. It works with lld and GNU ld, and adds other LTO

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey updated this revision to Diff 244571. awpandey marked 2 inline comments as done. awpandey added a comment. Hi @aprantl, I have added a test that two DITemplateTypeParameter only differ in the isDefault parameter are not equal. CHANGES SINCE LAST ACTION

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 244566. modocache added a comment. Clean up coroutine intrinsics as part of the ThinLTO pre-link pipeline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/ https://reviews.llvm.org/D71903 Files:

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

andrew.w.kaylor added a subscriber: MaskRay. andrew.w.kaylor added a comment. In D74436#1875386 , @thakis wrote: > The revert of this breaks tests everywhere, as far as I can tell. It looks like something strange happened with the revert: > clang-11:

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 updated this revision to Diff 244557. njames93 added a comment. - Fix order in release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files:

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 updated this revision to Diff 244555. njames93 added a comment. - Added option to enable transforming template dependent types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files:

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

sfertile added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:520 + +class XLCXXABI final : public ItaniumCXXABI { +public: Xiangling_L wrote: > sfertile wrote: > > Here would be a good place to add a comment to indicate that XL has several >

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

JonChesterfield added a comment. @tra that's great context, thank you very much for writing it up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74571/new/ https://reviews.llvm.org/D74571 ___ cfe-commits mailing list

[clang] 1d49eb0 - [AsmPrinter] De-capitalize all AsmPrinter::Emit* but EmitInstruction

Author: Fangrui Song Date: 2020-02-13T17:06:24-08:00 New Revision: 1d49eb00d97a8e920ae34ff433419d0cd61641fd URL: https://github.com/llvm/llvm-project/commit/1d49eb00d97a8e920ae34ff433419d0cd61641fd DIFF: https://github.com/llvm/llvm-project/commit/1d49eb00d97a8e920ae34ff433419d0cd61641fd.diff

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

thakis added a comment. The revert of this breaks tests everywhere, as far as I can tell. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436 ___ cfe-commits

[clang] 0a1123e - Reland D74436 "Change clang option -ffp-model=precise to select ffp-contract=on"

Author: Fangrui Song Date: 2020-02-13T16:22:03-08:00 New Revision: 0a1123eb43f945593b26dd037490e0c909fa3c4f URL: https://github.com/llvm/llvm-project/commit/0a1123eb43f945593b26dd037490e0c909fa3c4f DIFF: https://github.com/llvm/llvm-project/commit/0a1123eb43f945593b26dd037490e0c909fa3c4f.diff

[PATCH] D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount.

huihuiz updated this revision to Diff 244546. huihuiz marked 2 inline comments as done. huihuiz added a comment. Thanks Eli for the review! Add test cases to check for size query changes in ConstantExpr::getGetElementPtr(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

jdoerfert marked 11 inline comments as done. jdoerfert added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:367 } else { -llvm_unreachable("Unknown SimpleArgument type!"); +OS << "if (SA->get" << getUpperName() << "())\n "; +

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

jdoerfert added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:1723 +llvm::APInt CondVal = +Selector.ScoreOrCondition->EvaluateKnownConstInt(ASTCtx); +if (CondVal.isNullValue()) aaron.ballman wrote: > jdoerfert wrote: > >

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

tra added a comment. In D74571#1875296 , @JonChesterfield wrote: > Interesting distinction. > > Should compiling without warning indicate comprehensive support, or merely > that we ran the tests and they passed? The test in LLVM do have very limited

[PATCH] D74554: [ASTImporter] Added visibility check for scoped enums.

a_sidorin accepted this revision. a_sidorin added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:4870 + Decl *ToTU = getToTuDecl( + R"( + enum class E; Maybe it's better to use just non-raw string literals here? ``` Decl *ToTU =

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. @jsji Will your backend tolerate -ffp-contract=on if optimizations are not disabled, e.g. -O2? We are proposing that the default floating point model be -ffp-model=precise, and with precise model, the ffp-contract=on. However you are right we don't want the frontend

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

nemanjai added a comment. > You're right, -O0 shouldn't generate FMA. I'm preparing to revert this now -- > just verifying the build. Perhaps this should be `off` with no optimization `on` with `-O1/-O2/-O3/-Os/-Oz` `fast` with fast math Just a suggestion, I'm not sure whether that would be

[clang] 88ec01c - Revert "Revert "Revert "Change clang option -ffp-model=precise to select ffp-contract=on"""

Author: Melanie Blower Date: 2020-02-13T15:06:12-08:00 New Revision: 88ec01ca1bfa4c3a29225db93d36e6d32278190d URL: https://github.com/llvm/llvm-project/commit/88ec01ca1bfa4c3a29225db93d36e6d32278190d DIFF:

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. In D74436#1875273 , @jsji wrote: > This is also breaking test-suites in our internal buildbots .. > > This change is actually changing the default behavior: if user does NOT > supply `-ffp-contract`, it becomes

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

JonChesterfield added a comment. Interesting distinction. Should compiling without warning indicate comprehensive support, or merely that we ran the tests and they passed? I assumed the latter on the basis that we probably don't have comprehensive support for cuda 10.1 either. No preference

[PATCH] D74554: [ASTImporter] Added visibility check for scoped enums.

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74554/new/ https://reviews.llvm.org/D74554

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

jsji added a comment. This is also breaking test-suites in our internal buildbots .. This change is actually changing the default behavior: if user does NOT supply `-ffp-contract`, it becomes `-ffp-contract=on`. So this means any code without explicitly add `-ffp-contract=off` will have

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

Xiangling_L marked 3 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:520 + +class XLCXXABI final : public ItaniumCXXABI { +public: sfertile wrote: > Here would be a good place to add a comment to

[clang] f7e2227 - [clang] Fix bad line ending (DOS instead of Unix) inside the release notes.

Author: Wawha Date: 2020-02-13T22:52:28+01:00 New Revision: f7e2227832a6691bf2d07cebf4bd772d5eafbe1a URL: https://github.com/llvm/llvm-project/commit/f7e2227832a6691bf2d07cebf4bd772d5eafbe1a DIFF: https://github.com/llvm/llvm-project/commit/f7e2227832a6691bf2d07cebf4bd772d5eafbe1a.diff LOG:

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

a_sidorin accepted this revision. a_sidorin added a comment. Nice solution! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74542/new/ https://reviews.llvm.org/D74542 ___ cfe-commits mailing list

[PATCH] D74572: [WIP][BPF] implement intrinsic function __builtin__btf_type_id()

yonghong-song updated this revision to Diff 244529. yonghong-song edited the summary of this revision. yonghong-song added a comment. Herald added a subscriber: ormris. add the type_id assignment to FieldInfo relocation .btf.ext ELF section. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

jdoerfert added a comment. In D74513#1874825 , @atmnpatel wrote: > I am unable to commit this myself, can someone commit for me? I'll do that later. Ping me if I forget please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

Wawha added a comment. In D44609#1871612 , @MyDeveloperDay wrote: > Correct follow that description on how to request commit access It's done. I have the commit right, and push that change on github :

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa0118e6e588: [clang-format] Add new option BeforeLambdaBody in Allman style. (authored by Wawha). Herald added a reviewer: jdoerfert. Changed prior to commit:

[clang] fa0118e - [clang-format] Add new option BeforeLambdaBody in Allman style.

Author: Wawha Date: 2020-02-13T22:16:41+01:00 New Revision: fa0118e6e588fe303b08e7e06ba28ac1f8d50c68 URL: https://github.com/llvm/llvm-project/commit/fa0118e6e588fe303b08e7e06ba28ac1f8d50c68 DIFF: https://github.com/llvm/llvm-project/commit/fa0118e6e588fe303b08e7e06ba28ac1f8d50c68.diff LOG:

[PATCH] D72736: [AIX] Add improved interface for retrieving load module paths

hubert.reinterpretcast requested changes to this revision. hubert.reinterpretcast added inline comments. This revision now requires changes to proceed. Comment at: llvm/lib/Support/Unix/Path.inc:243 +#elif defined(_AIX) + return

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

lebedev.ri added a comment. D72362 has landed. I'd advise to see if any of the testcases here aren't being reported by that check, and filing a bugs for them. Other than that, abandon? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D72736: [AIX] Add improved interface for retrieving load module paths

xingxue accepted this revision. xingxue added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72736/new/ https://reviews.llvm.org/D72736 ___ cfe-commits mailing list

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

aprantl added a comment. The upgrade test look good, I found a missing test in the unit tests though. Comment at: llvm/unittests/IR/MetadataTest.cpp:2089 + EXPECT_NE(N, DITemplateTypeParameter::get(Context, Name, +

[clang] e3548e2 - Remove unnecessary typedef that GCC doesn't like

Author: Reid Kleckner Date: 2020-02-13T12:51:06-08:00 New Revision: e3548e23657d6c4988f815e9c87350f53e48e783 URL: https://github.com/llvm/llvm-project/commit/e3548e23657d6c4988f815e9c87350f53e48e783 DIFF: https://github.com/llvm/llvm-project/commit/e3548e23657d6c4988f815e9c87350f53e48e783.diff

[clang] 7ecf066 - [OPENMP][DOCS]Fix misprint, NFC.

Author: Alexey Bataev Date: 2020-02-13T15:43:05-05:00 New Revision: 7ecf066e65d8d5970b2254c2674ad12ce3a76e31 URL: https://github.com/llvm/llvm-project/commit/7ecf066e65d8d5970b2254c2674ad12ce3a76e31 DIFF: https://github.com/llvm/llvm-project/commit/7ecf066e65d8d5970b2254c2674ad12ce3a76e31.diff

[PATCH] D74081: [clang][Analysis] CallGraph: store the actual call `Expr*` in the CallGraphNode::CallRecord

This revision was automatically updated to reflect the committed changes. Closed by commit rGd68c7b8e3e4d: [clang][Analysis] CallGraph: store the actual call `Expr*` in the CallGraphNode… (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

This revision was automatically updated to reflect the committed changes. Closed by commit rG49bffa5f8b79: [clang-tidy] misc-no-recursion: a new check (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72362/new/

[clang-tools-extra] 49bffa5 - [clang-tidy] misc-no-recursion: a new check

Author: Roman Lebedev Date: 2020-02-13T23:37:53+03:00 New Revision: 49bffa5f8b790b6f180897b2a03840def645d8f0 URL: https://github.com/llvm/llvm-project/commit/49bffa5f8b790b6f180897b2a03840def645d8f0 DIFF: https://github.com/llvm/llvm-project/commit/49bffa5f8b790b6f180897b2a03840def645d8f0.diff

[clang] d68c7b8 - [clang][Analysis] CallGraph: store the actual call `Expr*` in the CallGraphNode::CallRecord

Author: Roman Lebedev Date: 2020-02-13T23:37:53+03:00 New Revision: d68c7b8e3e4d605912ed36a843bbbcaa36234461 URL: https://github.com/llvm/llvm-project/commit/d68c7b8e3e4d605912ed36a843bbbcaa36234461 DIFF: https://github.com/llvm/llvm-project/commit/d68c7b8e3e4d605912ed36a843bbbcaa36234461.diff

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

lebedev.ri updated this revision to Diff 244509. lebedev.ri marked 8 inline comments as done. lebedev.ri added a comment. In D72362#1874690 , @aaron.ballman wrote: > LGTM aside from some nits. Thank you for the review! Nits addressed. Repository:

[PATCH] D74081: [clang][Analysis] CallGraph: store the actual call `Expr*` in the CallGraphNode::CallRecord

lebedev.ri updated this revision to Diff 244508. lebedev.ri added a comment. Herald added a subscriber: martong. Rebased, NFC. In D74081#1860932 , @NoQ wrote: > Looks great, thanks! Thank you for the review! Repository: rG LLVM Github Monorepo

[PATCH] D66919: Warn about zero-parameter K definitions in -Wstrict-prototypes

aaronpuchert added a comment. Ping @aaron.ballman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66919/new/ https://reviews.llvm.org/D66919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74554: [ASTImporter] Added visibility check for scoped enums.

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2600 + EnumDecl *FoundDef = FoundEnum->getDefinition(); + if (D->isThisDeclarationADefinition() && FoundDef) +return Importer.MapImported(D, FoundDef); shafik

[clang-tools-extra] 8c4cf23 - Fix crash in InfinteLoopCheck

Author: Nathan James Date: 2020-02-13T20:20:37Z New Revision: 8c4cf23dee1ac3f259c4795b275cc9bb1234aa29 URL: https://github.com/llvm/llvm-project/commit/8c4cf23dee1ac3f259c4795b275cc9bb1234aa29 DIFF: https://github.com/llvm/llvm-project/commit/8c4cf23dee1ac3f259c4795b275cc9bb1234aa29.diff LOG:

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

jdoerfert added a comment. In D74571#1875022 , @kkwli0 wrote: > In D74571#1874950 , @jdoerfert wrote: > > > > in order to avoid bug 44587 which requires >9.0.1 to be the build > > > compiler? > > > > Do we already

[clang] 3eb1b59 - [OPENMP50][DOCS]Claim iterators and add reference to array shaping

Author: Alexey Bataev Date: 2020-02-13T15:05:19-05:00 New Revision: 3eb1b59ec0347d60f9809f88cfe7e98c48492621 URL: https://github.com/llvm/llvm-project/commit/3eb1b59ec0347d60f9809f88cfe7e98c48492621 DIFF: https://github.com/llvm/llvm-project/commit/3eb1b59ec0347d60f9809f88cfe7e98c48492621.diff

[PATCH] D74569: [clang-scan-deps] Switch to using a ThreadPool

aganea added a comment. Thanks for the quick response! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74569/new/ https://reviews.llvm.org/D74569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

tra added a comment. In D74571#1875002 , @kkwli0 wrote: > In D74571#1874947 , @JonChesterfield > wrote: > > > Do the in tree tests all pass with the 10.2 toolchain? That's not exactly > > the same as whether it

[clang] 3203e1b - [OPENMP50][DOCS]Update list of supported constructs, NFC.

Author: Alexey Bataev Date: 2020-02-13T15:02:59-05:00 New Revision: 3203e1bc2e190aeee31a5b037f2535d03f2ca818 URL: https://github.com/llvm/llvm-project/commit/3203e1bc2e190aeee31a5b037f2535d03f2ca818 DIFF: https://github.com/llvm/llvm-project/commit/3203e1bc2e190aeee31a5b037f2535d03f2ca818.diff

[clang] 0b2eaa3 - Fix MSVC buildbots after ast_type_traits namespace removal

Author: Reid Kleckner Date: 2020-02-13T11:57:00-08:00 New Revision: 0b2eaa373d12dacf58a72fd9e35ea6159a138647 URL: https://github.com/llvm/llvm-project/commit/0b2eaa373d12dacf58a72fd9e35ea6159a138647 DIFF: https://github.com/llvm/llvm-project/commit/0b2eaa373d12dacf58a72fd9e35ea6159a138647.diff

[PATCH] D74569: [clang-scan-deps] Switch to using a ThreadPool

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74569/new/ https://reviews.llvm.org/D74569 ___ cfe-commits mailing list

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 added a comment. In D74571#1874950 , @jdoerfert wrote: > > in order to avoid bug 44587 which requires >9.0.1 to be the build compiler? > > Do we already require CUDA 10 as part of the libomptarget cmake (with a nice > message) to avoid the errors

[PATCH] D74498: [clang-tidy] Fix performance-noexcept-move-constructor-fix.cpp on non-English locale

This revision was automatically updated to reflect the committed changes. Closed by commit rG47abb43fc364: [clang-tidy] Fix performance-noexcept-move-constructor-fix test on non-English… (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 added a comment. In D74571#1874947 , @JonChesterfield wrote: > Do the in tree tests all pass with the 10.2 toolchain? That's not exactly the > same as whether it works but is the closest approximation we have available. > > Assuming yes, this

[clang-tools-extra] 47abb43 - [clang-tidy] Fix performance-noexcept-move-constructor-fix test on non-English locale

Author: Alexandre Ganea Date: 2020-02-13T14:46:44-05:00 New Revision: 47abb43fc36433154eb796bd1d098f100503473e URL: https://github.com/llvm/llvm-project/commit/47abb43fc36433154eb796bd1d098f100503473e DIFF:

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

tra requested changes to this revision. tra added a comment. This revision now requires changes to proceed. It's a bit premature to call CUDA-10.2 supported. We can compile using it, but clang/llvm has no support for the new things introduced by CUDA-10.2. E.g. CUDA-10.2 introduces new PTX

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

plotfi added a comment. @MadCoder Could there be a way to mark objc_direct methods as something like __attribute__((visibility("default"))) or __declspec(dllexport) to denote that a given method should be directly callable but still retain the metadata to be called through an objc_msgSend from

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

JonChesterfield added a comment. Do the in tree tests all pass with the 10.2 toolchain? That's not exactly the same as whether it works but is the closest approximation we have available. Assuming yes, this patch seems uncontroversial. CHANGES SINCE LAST ACTION

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

rriddle accepted this revision. rriddle added a comment. This revision is now accepted and ready to land. (Appeasing herald for MLIR changes). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71775/new/ https://reviews.llvm.org/D71775 ___

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

jdoerfert added a reviewer: ye-luo. jdoerfert added a comment. > Do we also want to put this patch to 10.0.0 RC2 Yes, if there is nothing else needed to support 10.2 we should for sure do that. > in order to avoid bug 44587 which requires >9.0.1 to be the build compiler? Do we already require

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

sfertile added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:520 + +class XLCXXABI final : public ItaniumCXXABI { +public: Here would be a good place to add a comment to indicate that XL has several C++ ABIs, but this represents the one used

[PATCH] D74572: [WIP][BPF] implement intrinsic function __builtin__btf_type_id()

yonghong-song created this revision. yonghong-song added reviewers: ast, anakryiko. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, mgorny. Herald added projects: clang, LLVM. The builtin signature looks like: unsigned type_id = __builtin_btf_type_id(expression); The

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 created this revision. kkwli0 added reviewers: jdoerfert, ABataev, JonChesterfield, tra. Herald added a subscriber: guansong. kkwli0 edited the summary of this revision. This patch is to add CUDA 10.2 support. It essentially removes the warning message regarding the CUDA 10.2 toolkit not

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

Xiangling_L updated this revision to Diff 244476. Xiangling_L marked 4 inline comments as done. Xiangling_L added a comment. Adjust ABI name to `XL`; Simplify the testcase; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74015/new/ https://reviews.llvm.org/D74015 Files:

[PATCH] D74498: [clang-tidy] Fix performance-noexcept-move-constructor-fix.cpp on non-English locale

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, if the diff comes out wrong, that will not result in an incorrect pass/fail, but only less debugable output. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74498/new/

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

atmnpatel added a comment. I am unable to commit this myself, can someone commit for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74513/new/ https://reviews.llvm.org/D74513 ___ cfe-commits

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

erik.pilkington added a comment. In D74417#1874747 , @dgoldman wrote: > Added but it's still failing due to a different assertion failure, do you > think this could be because the abbreviation is different for the ParamVars? > I'm not sure how to handle

[clang] 2fb6268 - [OPENMP50]Add support for hint clause in atomic directive.

Author: Alexey Bataev Date: 2020-02-13T13:28:43-05:00 New Revision: 2fb6268854f178609e974002e4781dbdb1074b90 URL: https://github.com/llvm/llvm-project/commit/2fb6268854f178609e974002e4781dbdb1074b90 DIFF: https://github.com/llvm/llvm-project/commit/2fb6268854f178609e974002e4781dbdb1074b90.diff

[PATCH] D74569: [clang-scan-deps] Switch to using a ThreadPool

aganea created this revision. aganea added reviewers: arphaman, dexonsmith, Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, tschuett, hiraditya. Herald added projects: clang, LLVM. aganea updated this revision to Diff 244475. This was already reviewed as part of D71775

[PATCH] D74569: [clang-scan-deps] Switch to using a ThreadPool

aganea updated this revision to Diff 244475. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74569/new/ https://reviews.llvm.org/D74569 Files: clang/tools/clang-scan-deps/ClangScanDeps.cpp Index: clang/tools/clang-scan-deps/ClangScanDeps.cpp

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr added a comment. Yes, I do. Thank you (and @Eugene.Zelenko) for your help making this better! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73775/new/ https://reviews.llvm.org/D73775 ___ cfe-commits mailing list

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 5PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

dgoldman updated this revision to Diff 244467. dgoldman added a comment. - Add test (fails due to different assertion) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74417/new/ https://reviews.llvm.org/D74417 Files:

[PATCH] D74554: [ASTImporter] Added visibility check for scoped enums.

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2600 + EnumDecl *FoundDef = FoundEnum->getDefinition(); + if (D->isThisDeclarationADefinition() && FoundDef) +return Importer.MapImported(D, FoundDef); Can you

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

dgoldman added a comment. In D74417#1873287 , @erik.pilkington wrote: > This looks good, but please add a testcase. Added but it's still failing due to a different assertion failure, do you think this could be because the abbreviation is different for

[PATCH] D74550: [AArch64][SVE] Add SVE index intrinsic

andwar added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:10923 +static SDValue LowerSVEIntrinsicIndex(SDNode *N, SelectionDAG ) { + SDLoc dl(N); + SDValue Op1 = N->getOperand(1); [nit] This should be `DL`:

[PATCH] D74473: [analyzer] StdLibraryFunctionsChecker: Use platform dependent EOF and UCharMax

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CheckerHelpers.cpp:114-117 + const auto MacroIt = llvm::find_if( + PP.macros(), [&](const auto ) { return K.first->getName() == Macro; }); + if (MacroIt == PP.macro_end()) +return llvm::None;

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. Build with this patch being built on GitHub Actions on Windows MSVC, Windows MinGW, Linux, macOS: https://github.com/cristianadam/llvm-project/actions/runs/38838989 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74214: [clang-tidy] Fix PR#34798 'readability-braces-around-statements breaks statements containing braces.'

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/BracesAroundStatementsCheck.cpp:76-77 + + // We need to check that it is not 'InitListExpr' which ends with + // the tokens '};' because it will break the following analysis +

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some nits. Comment at: clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp:70 + +template class SmartSmallSetVector { +public:

[PATCH] D74473: [analyzer] StdLibraryFunctionsChecker: Use platform dependent EOF and UCharMax

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CheckerHelpers.cpp:114-117 + const auto MacroIt = llvm::find_if( + PP.macros(), [&](const auto ) { return K.first->getName() == Macro; }); + if (MacroIt == PP.macro_end()) +return llvm::None;

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

aaron.ballman accepted this revision. aaron.ballman added a comment. Still LGTM, thank you! If you need me to commit this on your behalf, I'm happy to do so, just let me know. It'll have to wait until next week, though (unless someone else does it first). CHANGES SINCE LAST ACTION

[clang] 43b98ff - [OPENMP][DOCS]Update status of support constructs, NFC.

Author: Alexey Bataev Date: 2020-02-13T12:28:17-05:00 New Revision: 43b98ffed08a5691dd2d8275b8952569f55f015d URL: https://github.com/llvm/llvm-project/commit/43b98ffed08a5691dd2d8275b8952569f55f015d DIFF: https://github.com/llvm/llvm-project/commit/43b98ffed08a5691dd2d8275b8952569f55f015d.diff

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:185 +// An argument of type \p type with name \p name. +class GenericPointerArgument : Argument { + string Type = type; jdoerfert wrote: > aaron.ballman wrote: > > The name seems

[clang] e0ca479 - [OPENMP50]Add cancellation support in taskloop-based directives.

Author: Alexey Bataev Date: 2020-02-13T12:03:43-05:00 New Revision: e0ca4792fa4598359dc5364bcc466f7e78616113 URL: https://github.com/llvm/llvm-project/commit/e0ca4792fa4598359dc5364bcc466f7e78616113 DIFF: https://github.com/llvm/llvm-project/commit/e0ca4792fa4598359dc5364bcc466f7e78616113.diff

[PATCH] D73369: [clangd] Simplify "preferred" vs "definition" logic a bit in XRefs AST code.

kadircet added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73369/new/ https://reviews.llvm.org/D73369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

kadircet added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73696/new/ https://reviews.llvm.org/D73696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

Fznamznon added a comment. > In D74387#1869845 , @rjmccall wrote: > >> The right approach here is probably what we do in ObjC ARC when we see types >> that are illegal in ARC: in system headers, we allow the code but add a >> special `UnavailableAttr`

[PATCH] D72281: [Matrix] Add matrix type to Clang (WIP).

fhahn added subscribers: jwakely, jfb. fhahn added a comment. @jwakely it would be great if you could have a brief look at our recent proposal for matrix support in Clang and could let us know if you have any concerns? The original proposal is being discussed on cfe-dev

[PATCH] D74555: [clangd] Add a flag for setting isIncomplete flag true in all responses

kadircet added a comment. some drive-by comments: if this is a client-specific option, wouldn't it be equally hard for client to just set this in the LSP layer, instead of telling clangd to do that? by looking at the current patch, it rather seems like a user-specific option, which will help

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam created this revision. cristian.adam added reviewers: chapuni, yvvan. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. On Linux and macOS it was possible to build libclang statically by configuring CMake with: -D LIBCLANG_BUILD_STATIC=ON -D

[PATCH] D74562: [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class

fghanim created this revision. fghanim added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, guansong. Herald added a project: clang. This patch introduces a new helper class `OMPBuilderCBHelpers`, which will contain all reusable C/C++ language specific function- alities required

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

bruno updated this revision to Diff 244435. bruno added a comment. Address Richard's review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71734/new/ https://reviews.llvm.org/D71734 Files: clang/include/clang/AST/Decl.h

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

bruno marked 3 inline comments as done. bruno added a comment. Thanks for taking a look Richard, comments inline. Comment at: clang/include/clang/AST/Decl.h:4009-4010 + + /// Store the ODR hash for this decl. + unsigned ODRHash; }; rsmith wrote: > We

[clang] 18789bf - [OPENMP50]Fix handling of clauses in parallel master taskloop directive.

Author: Alexey Bataev Date: 2020-02-13T11:00:01-05:00 New Revision: 18789bfe3a39f69f6cfe6490a24a61ea2ff0b5af URL: https://github.com/llvm/llvm-project/commit/18789bfe3a39f69f6cfe6490a24a61ea2ff0b5af DIFF: https://github.com/llvm/llvm-project/commit/18789bfe3a39f69f6cfe6490a24a61ea2ff0b5af.diff

[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

jdoerfert added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:84 " o - object\n" + " oo - object; output file is a list of unbundled objects\n" " gch -

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong updated this revision to Diff 244430. martong added a comment. - Rebase to master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73898/new/ https://reviews.llvm.org/D73898 Files:

[PATCH] D74550: [AArch64][SVE] Add SVE index intrinsic

cameron.mcinally accepted this revision. cameron.mcinally added a comment. This revision is now accepted and ready to land. Herald added a subscriber: tatyana-krasnukha. LGTM Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:804 +[IntrNoMem]>; + class

  1   2   >