[PATCH] D74634: Remove "ELF Only" restriction from section flags

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74634/new/ https://reviews.llvm.org/D74634

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

jdoerfert added a comment. I did run clang-format on the OMPIRBuilder files and replaced tabs with spaces. I think you need to teach your editor to use spaces in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

MaskRay added a comment. `test/CodeGen/opt-record-1.c` triggers an assertion failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/ https://reviews.llvm.org/D72304 ___ cfe-commits mailing

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7438059a9032: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder. (authored by fghanim, committed by jdoerfert). Changed prior to commit:

[clang-tools-extra] 803ad31 - [FIX] Repair clang-tidy check after D72304

Author: Johannes Doerfert Date: 2020-02-15T01:15:45-06:00 New Revision: 803ad3137b6b81afca487e6b661460e05089699b URL: https://github.com/llvm/llvm-project/commit/803ad3137b6b81afca487e6b661460e05089699b DIFF:

[clang] 7438059 - [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

Author: Fady Ghanim Date: 2020-02-15T01:15:45-06:00 New Revision: 7438059a90326d4fe46377bf1833180333b48fff URL: https://github.com/llvm/llvm-project/commit/7438059a90326d4fe46377bf1833180333b48fff DIFF: https://github.com/llvm/llvm-project/commit/7438059a90326d4fe46377bf1833180333b48fff.diff

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG577c9b02ab57: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang (authored by atmnpatel, committed by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D74513?vs=244334=244815#toc

[clang] 5313abd - [OpenMP][NFC] Update OpenMPSupport table

Author: Johannes Doerfert Date: 2020-02-15T00:40:39-06:00 New Revision: 5313abdbca802d842ba1d27729420d186f653a2d URL: https://github.com/llvm/llvm-project/commit/5313abdbca802d842ba1d27729420d186f653a2d DIFF:

[clang] 577c9b0 - [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

Author: Atmn Patel Date: 2020-02-15T00:38:12-06:00 New Revision: 577c9b02ab572b7767420a34b4de8d5e19347117 URL: https://github.com/llvm/llvm-project/commit/577c9b02ab572b7767420a34b4de8d5e19347117 DIFF: https://github.com/llvm/llvm-project/commit/577c9b02ab572b7767420a34b4de8d5e19347117.diff

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

jdoerfert added a comment. In D74571#1877000 , @kkwli0 wrote: > > I am not sure I understand. Do we need to modify stuff outside of > > `/openmp`? I was hoping it is our CMake that can be adjusted to make this > > work as described earlier. TBH, he

[PATCH] D74562: [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class

jdoerfert added a comment. This is great, thanks a lot! I only have two comments where I am not sure I understand the code/change. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3134 // TODO: Replace with a generic helper function for emitting body auto BodyGenCB

[PATCH] D69471: [Coverage] Revise format to reduce binary size

vsk updated this revision to Diff 244790. vsk added a comment. Rebase. Sorry this hasn't seen any update: at this point in our release cycle I've had to put this on the back burner. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69471/new/ https://reviews.llvm.org/D69471 Files:

[PATCH] D69868: Allow "callbr" to return non-void values

void added a comment. Another friendly ping. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, thanks. Comment at: clang/lib/Sema/SemaObjCProperty.cpp:2436 + if (!GetterMethod) { +if (const ObjCCategoryDecl *CatDecl = dyn_cast(CD)) { +

[clang] 859654c - [FIX] Add missing InGroup to warning introduced as part of D71830

Author: Johannes Doerfert Date: 2020-02-14T17:22:40-06:00 New Revision: 859654c065583a320d3621d22a09cad89abfc3e9 URL: https://github.com/llvm/llvm-project/commit/859654c065583a320d3621d22a09cad89abfc3e9 DIFF:

[PATCH] D69471: [Coverage] Revise format to reduce binary size

rnk added a comment. I haven't forgotten about this, even though it's been two months. Hopefully I get to it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69471/new/ https://reviews.llvm.org/D69471

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

xbolva00 added a comment. >> Perhaps we can also see what the defaults are for GCC and unify with those? +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

andrew.w.kaylor added a comment. In D74436#1875315 , @nemanjai wrote: > > You're right, -O0 shouldn't generate FMA. I'm preparing to revert this now > > -- just verifying the build. > > Perhaps this should be > `off` with no optimization > `on` with

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

Xiangling_L added a comment. In D74631#1876995 , @sfertile wrote: > > Will we report an error somewhere in the backend if we encounter a COMDAT? I hit this when I was doing my static init patch as well: `error in backend: COMDAT not yet supported

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

MadCoder added inline comments. Comment at: clang/lib/Sema/SemaObjCProperty.cpp:1630-1637 + if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic && + PIDecl->getPropertyDecl() && + PIDecl->getPropertyDecl()->isDirectProperty()) { +

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

MadCoder updated this revision to Diff 244773. MadCoder marked 10 inline comments as done. MadCoder added a comment. @erik.pilkington review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73755/new/ https://reviews.llvm.org/D73755 Files: clang/include/clang/Basic/Attr.td

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

michele.scandale created this revision. michele.scandale added reviewers: rjmccall, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. michele.scandale updated this revision to Diff 244756. michele.scandale added a comment. Missed GNU style attributes The syntax

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

MadCoder added a comment. In D73755#1874962 , @plotfi wrote: > @MadCoder Could there be a way to mark objc_direct methods as something like > __attribute__((visibility("default"))) or __declspec(dllexport) to denote > that a given method should be

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

michele.scandale updated this revision to Diff 244756. michele.scandale added a comment. Missed GNU style attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74643/new/ https://reviews.llvm.org/D74643 Files:

[PATCH] D74639: Add linkage check to ASTNodeImporter::hasSameVisibilityContext and rename to hasSameVisibilityContextAndLinkage

shafik added a comment. I would love to have a minimal test case for this but every approach I tried has failed, so I would appreciate if there are ideas here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74639/new/ https://reviews.llvm.org/D74639

[PATCH] D74639: Add linkage check to ASTNodeImporter::hasSameVisibilityContext and rename to hasSameVisibilityContextAndLinkage

shafik created this revision. shafik added reviewers: martong, teemperor, balazske, a_sidorin. Herald added a subscriber: rnkovacs. This fixed is based on the assert in `LinkageComputer::getLVForDecl(…)` which assumes that all the decls in a redecl chain have the same linkage. This change was

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

sfertile added a comment. 1. We should probably update the COMDAT section of the lang ref to mention XCOFF doens't support COMDATS. 2. Will we report an error somewhere in the backend if we encounter a COMDAT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 added a comment. > I am not sure I understand. Do we need to modify stuff outside of `/openmp`? > I was hoping it is our CMake that can be adjusted to make this work as > described earlier. TBH, he warning is even not my biggest problem. As long as > we get a libomptarget.bc we should

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

compositeprimes updated this revision to Diff 244737. compositeprimes added a comment. Updated to serialize the ranges in yaml. This required making a few abstractions around the representation of CharSourceRange. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69782/new/

[PATCH] D74602: Fix standalone build interaction with compiler extension

Keruspe accepted this revision. Keruspe added a comment. This revision is now accepted and ready to land. Fixes the regression introduced in D74464 when running cmake inside the clang directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 87e80e5 - fix some comment typos to cycle bots

Author: Nico Weber Date: 2020-02-14T15:18:50-05:00 New Revision: 87e80e5e289249cb9c1b6ed0f9502434375335a9 URL: https://github.com/llvm/llvm-project/commit/87e80e5e289249cb9c1b6ed0f9502434375335a9 DIFF: https://github.com/llvm/llvm-project/commit/87e80e5e289249cb9c1b6ed0f9502434375335a9.diff

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

jdoerfert added a comment. In D74571#1876952 , @kkwli0 wrote: > It turns out that having the warning message also affects the C_SUPPORTS_FPIC > test in `cmake/modules/HandleLLVMOptions.cmake`. As a result, `cmake` thinks > that `-fPIC` is not

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 added a comment. It turns out that having the warning message also affects the C_SUPPORTS_FPIC test in `cmake/modules/HandleLLVMOptions.cmake`. As a result, `cmake` thinks that `-fPIC` is not supported. Eventually, it leads to error in `libclang-cpp.so`.

[PATCH] D74634: Remove "ELF Only" restriction from section flags

rnk created this revision. rnk added reviewers: hans, aaron.ballman. Herald added subscribers: sunfish, aheejin. Herald added a project: clang. -ffunction-sections and -fdata-sections are well supported by many object file formats: - ELF - COFF - XCOFF - wasm Only MachO ignores this flag.

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

dgoldman added a comment. In D74417#1874826 , @erik.pilkington wrote: > In D74417#1874747 , @dgoldman wrote: > > > Added but it's still failing due to a different assertion failure, do you > > think this could be

[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

dgoldman updated this revision to Diff 244728. dgoldman added a comment. - Fix parameter abbreviation for ParamVarDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74417/new/ https://reviews.llvm.org/D74417 Files:

RE: [PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

Thanks Melanie. I have pushed one fix to test-suite to explicitly add -ffp-contract=off to unblock our internal buildbot for now. https://github.com/llvm/llvm-test-suite/commit/c04a7178a3a50fe919964df59b041c5671db50f7 Our buildbot are OK now. I think you can proceed as long as the change is

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

jsji added a comment. > We normally default to `-ffp-contract=on ` only for -O3 and above (for legacy > compilers XL/gcc on PowerPC). Correction: XL on PowerPC default to generate FMA at -O0 as well. The corresponding option is -qfloat=maf.

[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

ABataev added a comment. In D74262#1876835 , @grokos wrote: > In D74262#1867245 , @ABataev wrote: > > > Partial linking may lead to some incorrect results with global > > constructors. How are you going to handle

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 5PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66919: Warn about zero-parameter K definitions in -Wstrict-prototypes

aaronpuchert added a comment. Just FYI, I had to fix some tests after this in rG705306526b5ca7eed2fa28ebf832873cbb5085ec . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74262: [clang-offload-bundler] Enable handling of partially-linked fat objects

grokos marked 2 inline comments as done. grokos added a comment. In D74262#1867245 , @ABataev wrote: > Partial linking may lead to some incorrect results with global constructors. > How are you going to handle this? Can you give me an example of what

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

tra added a comment. In D74571#1876647 , @jdoerfert wrote: > That sounds like the right approach for OpenMP. We require a minimal CUDA > version, based on what we use internally, but no maximal version if possible > since we don't use new features

[PATCH] D74572: [WIP][BPF] implement intrinsic function __builtin__btf_type_id()

yonghong-song updated this revision to Diff 244709. yonghong-song edited the summary of this revision. yonghong-song added a comment. Addressing some Alexei's comments: Change comments in clang CGBuiltin.cpp to make it easier to understand. Remove BPFMIPreserveDIType.cpp and fold into

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

Xiangling_L marked 3 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:520 + +class XLCXXABI final : public ItaniumCXXABI { +public: sfertile wrote: > Xiangling_L wrote: > > sfertile wrote: > > > Here

[clang] 7053065 - Fix tests after previous commit

Author: Aaron Puchert Date: 2020-02-14T19:41:01+01:00 New Revision: 705306526b5ca7eed2fa28ebf832873cbb5085ec URL: https://github.com/llvm/llvm-project/commit/705306526b5ca7eed2fa28ebf832873cbb5085ec DIFF: https://github.com/llvm/llvm-project/commit/705306526b5ca7eed2fa28ebf832873cbb5085ec.diff

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

daltenty updated this revision to Diff 244708. daltenty added a comment. - Add missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74631/new/ https://reviews.llvm.org/D74631 Files: clang/test/CodeGen/xcoff-comdat.cpp

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

daltenty created this revision. daltenty added reviewers: stevewan, sfertile, Xiangling_L. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. daltenty updated this revision to Diff 244708. daltenty added a comment. - Add missing newline XCOFF

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

rjmccall added a comment. Yeah, I agree with Steve here. The great virtue of `-ffp-contract=on` over the more aggressive modes is that FMA formation is purely local to a single source expression, which means there's really no obstacle to treating it as implementation-guaranteed semantics.

[PATCH] D66919: Warn about zero-parameter K definitions in -Wstrict-prototypes

This revision was automatically updated to reflect the committed changes. aaronpuchert marked an inline comment as done. Closed by commit rG2f26bc554270: Warn about zero-parameter KR definitions in -Wstrict-prototypes (authored by aaronpuchert). Changed prior to commit:

[PATCH] D74555: [clangd] Add a flag for setting isIncomplete flag true in all responses

kbobyrev abandoned this revision. kbobyrev added a comment. Okay, makes sense! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74555/new/ https://reviews.llvm.org/D74555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 2f26bc5 - Warn about zero-parameter K definitions in -Wstrict-prototypes

Author: Aaron Puchert Date: 2020-02-14T19:25:02+01:00 New Revision: 2f26bc5542705c390bf17af2fdfc31e056147ea9 URL: https://github.com/llvm/llvm-project/commit/2f26bc5542705c390bf17af2fdfc31e056147ea9 DIFF: https://github.com/llvm/llvm-project/commit/2f26bc5542705c390bf17af2fdfc31e056147ea9.diff

[PATCH] D66919: Warn about zero-parameter K definitions in -Wstrict-prototypes

aaronpuchert marked 5 inline comments as done. aaronpuchert added a comment. Thanks! Comment at: clang/test/Sema/warn-strict-prototypes.c:11 +// function definition with 0 params, no prototype. +void foo1() {} // expected-warning {{this old-style function definition is not

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

andrew.w.kaylor added a subscriber: scanon. andrew.w.kaylor added a comment. In D74436#1875320 , @mibintc wrote: > However you are right we don't want the frontend to create FMA when > optimizations are disabled -O0 I've been discussing this with

[PATCH] D66919: Warn about zero-parameter K definitions in -Wstrict-prototypes

aaron.ballman added inline comments. Comment at: clang/test/Sema/warn-strict-prototypes.c:11 +// function definition with 0 params, no prototype. +void foo1() {} // expected-warning {{this old-style function definition is not preceded by a prototype}} +// function definition

[PATCH] D66919: Warn about zero-parameter K definitions in -Wstrict-prototypes

aaronpuchert added inline comments. Comment at: clang/test/Sema/warn-strict-prototypes.c:11 +// function definition with 0 params, no prototype. +void foo1() {} // expected-warning {{this old-style function definition is not preceded by a prototype}} +// function definition

[PATCH] D66919: Warn about zero-parameter K definitions in -Wstrict-prototypes

aaronpuchert added inline comments. Comment at: clang/test/Sema/warn-strict-prototypes.c:11 +// function definition with 0 params, no prototype. +void foo1() {} // expected-warning {{this old-style function definition is not preceded by a prototype}} +// function definition

[PATCH] D74116: [Sema][C++] Strawman patch to propagate conversion type in order to specialize the diagnostics

rjmccall added a comment. The C diagnostic changes seem like improvements, yeah. The virtue of re-using the same infrastructure across language modes. Comment at: clang/lib/Sema/SemaExprCXX.cpp:3880 +ToType, From->getType(), From, Action); +// assert(Diagnosed &&

[PATCH] D74116: [Sema][C++] Strawman patch to propagate conversion type in order to specialize the diagnostics

Anastasia added a comment. > It looks like there's already some type analysis in > `DiagnoseAssignmentResult` to get a specialized diagnostic for certain cases > of function-pointer assignment. That could probably be easily moved into > `CheckAssignmentConstraints` by just adding a few more

[PATCH] D74116: [Sema][C++] Strawman patch to propagate conversion type in order to specialize the diagnostics

Anastasia updated this revision to Diff 244691. Anastasia added a comment. Herald added a reviewer: jdoerfert. - Switched to using `CheckAssignmentConstraints` - Duplicated all extensions and warnings as errors for C++ mode - Added `IncompatibleFunctionPointer` CHANGES SINCE LAST ACTION

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some small nits. Comment at: clang/include/clang/Basic/Attr.td:186-192 +// an OMPTraitInfo object. The structure of an OMPTraitInfo object is a +// tree as defined below: +// +//

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

jdoerfert added a comment. In D74571#1876617 , @kkwli0 wrote: > Thanks for all the comments. It makes sense to keep the warning there before > any ptx65 features are added. The warning should also apply to both the CUDA > and OpenMP compile paths. As

[PATCH] D74620: [ARM,MVE] Add vector-scalar intrinsics

miyuki added a comment. I would prefer not to format the Clang test cases to avoid code churn. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74620/new/ https://reviews.llvm.org/D74620 ___ cfe-commits

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 added a comment. Thanks for all the comments. It makes sense to keep the warning there before any ptx65 features are added. The warning should also apply to both the CUDA and OpenMP compile paths. As a result, I will pursue to ignore the warning in the build of libomp (i.e.

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

CarolineConcatto marked an inline comment as done. CarolineConcatto added inline comments. Comment at: clang/test/Driver/flang/clang-driver-2-frontend01.f90:10 +! RUN: cp %clang %t1 +! RUN: %clang --driver-mode=flang -fortran-fe %basename_t.tmp1 -### %s 2>&1 | FileCheck

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

richard.barton.arm added inline comments. Comment at: clang/include/clang/Driver/Options.td:268 +def fortran_fe : Separate<["-"], "fortran-fe">, InternalDriverOpt, + HelpText<"Name for native Fortran compiler">; richard.barton.arm wrote: > This is not right.

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

richard.barton.arm added a comment. Still not sure why all the tests are needed here. The first one looks fine, i.e. we test that --fortran-fe= calls to that copy. The second one appears to test the default behaviour with no option, but why does it do it via a different name for clang, why

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

jsji added a comment. In D74436#1875320 , @mibintc wrote: > @jsji Will your backend tolerate -ffp-contract=on if optimizations are not > disabled, e.g. -O2? We are proposing that the default floating point model > be -ffp-model=precise, and with

[PATCH] D74555: [clangd] Add a flag for setting isIncomplete flag true in all responses

sammccall added a comment. The idea is this is an easy option for the user to work-around editors that do client-side filtering badly (everyone lets you add flags). But as mentioned offline, I don't think we actually have an example of an editor this fixes (I think it fixes neither vscode nor

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

balazske added a comment. Probably a better solution can be: For every "case" build a single `SVal` that contains all argument constraints for that case. It is possible using multiple `evalBinOp` calls (with <=, >=, logical or) to build such a condition (or repeated calls to other assume

[PATCH] D74591: [Driver] Rename AddGoldPlugin to addLTOOptions. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG597dfb3bd56c: [Driver] Rename AddGoldPlugin to addLTOOptions. NFC (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74591/new/

[PATCH] D74617: [ARM] Keeping sign information on bitcasts for Neon vdot_lane intrinsics

pratlucas created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. Sign information was being lost on Neon's vdot_lane intrinsics arguments when bitcasting explicitly to uint32 vector types. This patch introduces a new cast option to allow

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

thakis added a comment. Yep, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74051/new/ https://reviews.llvm.org/D74051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74618: [ARM] Creating 'call_mangled' for Neon intrinsics definitions

pratlucas created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. As multiple versions ofthe same Neon intrinsic can be created through the same TableGen definition with the same argument types, the existing 'call' operator is not always able to

[PATCH] D74616: [ARM] Setting missing isLaneQ attribute on Neon Intrisics definitions

pratlucas created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. Some of the '*_laneq' intrinsics defined in arm_neon.td were missing the setting of the 'isLaneQ' attribute. This patch sets the attribute on the re lated definitions, as they

[clang] 597dfb3 - [Driver] Rename AddGoldPlugin to addLTOOptions. NFC

Author: Fangrui Song Date: 2020-02-14T08:06:37-08:00 New Revision: 597dfb3bd56cdb65a89c67775ce348f10af36aa0 URL: https://github.com/llvm/llvm-project/commit/597dfb3bd56cdb65a89c67775ce348f10af36aa0 DIFF: https://github.com/llvm/llvm-project/commit/597dfb3bd56cdb65a89c67775ce348f10af36aa0.diff

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:403 +return; + case nonloc::ConcreteIntKind: { + This check works now with concrete int values. We have a known value and a list of ranges with

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware abandoned this revision. baloghadamsoftware added a comment. Superseded by [[ https://reviews.llvm.org/D73720 | [Analyzer] Use note tags to track container begin and and changes ]], [[ https://reviews.llvm.org/D74541 | [Analyzer] Use note tags to track iterator increments and

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

dstenb added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp:870 if (MI->isCandidateForCallSiteEntry() && -DAG->getTarget().Options.EnableDebugEntryValues) +DAG->getTarget().Options.SupportsDebugEntryValues)

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware updated this revision to Diff 244667. baloghadamsoftware added a comment. Minor update: ignore parentheses and casts when taking the name of the expression. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73720/new/ https://reviews.llvm.org/D73720 Files:

[PATCH] D74615: [Analyzer] Add visitor to track iterator invalidation

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: steakhal, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun. To understand the bug report issued by the

RE: [PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

I reverted MaskRay's "reland" since the original patch is causing trouble on PowerPC, check-all is passing on my box. Sorry for the trouble. > -Original Message- > From: Andy Kaylor via Phabricator > Sent: Thursday, February 13, 2020 9:20 PM > To: Blower, Melanie I ;

[clang] 9122b92 - Revert "Reland D74436 "Change clang option -ffp-model=precise to select ffp-contract=on""

Author: Melanie Blower Date: 2020-02-14T07:32:09-08:00 New Revision: 9122b92f8e046bfeabdc503d978cf098c86f6e49 URL: https://github.com/llvm/llvm-project/commit/9122b92f8e046bfeabdc503d978cf098c86f6e49 DIFF:

[PATCH] D74569: [clang-scan-deps] Switch to using a ThreadPool

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9049e871f30: [clang-scan-deps] Switch to using a ThreadPool (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74569/new/

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

This revision was automatically updated to reflect the committed changes. Closed by commit rG8404aeb56a73: [Support] On Windows, ensure hardware_concurrency() extends to all CPU sockets… (authored by aganea). Changed prior to commit: https://reviews.llvm.org/D71775?vs=237197=244664#toc

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

arichardson added a comment. Turns out those scripts use different code to write the updated file. The failure should hopefully be fixed in rGc29310707e9a85e70a226277657cd9d9182a5d04 Repository: rG LLVM Github Monorepo

[clang] d9049e8 - [clang-scan-deps] Switch to using a ThreadPool

Author: Alexandre Ganea Date: 2020-02-14T10:24:22-05:00 New Revision: d9049e871f309199a3d8fd7d3c0f76c86af9db91 URL: https://github.com/llvm/llvm-project/commit/d9049e871f309199a3d8fd7d3c0f76c86af9db91 DIFF:

[clang-tools-extra] 8404aeb - [Support] On Windows, ensure hardware_concurrency() extends to all CPU sockets and all NUMA groups

Author: Alexandre Ganea Date: 2020-02-14T10:24:22-05:00 New Revision: 8404aeb56a73ab24f9b295111de3b37a37f0b841 URL: https://github.com/llvm/llvm-project/commit/8404aeb56a73ab24f9b295111de3b37a37f0b841 DIFF:

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

arichardson added a comment. In D74051#1876291 , @thakis wrote: > Fails on windows, looks like line endings: > http://45.33.8.238/win/8350/step_7.txt Are the other update_test_checks.py and update_llc_test_checks.py tests running on that bot? I would

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

ldionne added a comment. I think this was addressed by https://reviews.llvm.org/D71997. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73138/new/ https://reviews.llvm.org/D73138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] 13700c3 - Revert "[clang-tools-extra] fix the check for if '-latomic' is necessary"

Author: Luís Marques Date: 2020-02-14T15:01:52Z New Revision: 13700c383fdbb172fac281bff6738a62989631c5 URL: https://github.com/llvm/llvm-project/commit/13700c383fdbb172fac281bff6738a62989631c5 DIFF: https://github.com/llvm/llvm-project/commit/13700c383fdbb172fac281bff6738a62989631c5.diff LOG:

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

thakis added a comment. Fails on windows, looks like line endings: http://45.33.8.238/win/8350/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74051/new/ https://reviews.llvm.org/D74051 ___

[PATCH] D74609: [clangd] Update the CompletionItemKind.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5dc2314d5ecf: [clangd] Update the CompletionItemKind. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74609/new/

[clang-tools-extra] 5dc2314 - [clangd] Update the CompletionItemKind.

Author: Haojian Wu Date: 2020-02-14T15:48:30+01:00 New Revision: 5dc2314d5ecf3fe246ee0134f519183844287456 URL: https://github.com/llvm/llvm-project/commit/5dc2314d5ecf3fe246ee0134f519183844287456 DIFF: https://github.com/llvm/llvm-project/commit/5dc2314d5ecf3fe246ee0134f519183844287456.diff

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG61dd0603bd8a: Move update_cc_test_checks.py tests to clang (authored by arichardson). Changed prior to commit: https://reviews.llvm.org/D74051?vs=243859=244650#toc Repository: rG LLVM Github

[PATCH] D74609: [clangd] Update the CompletionItemKind.

hokein added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:106 + case SK::ConversionFunction: +return CompletionItemKind::Operator; case SK::Variable: kadircet wrote: > I believe `function` still captures the intend better here,

[PATCH] D74395: [clangd] Add tracer to the rename workflow, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG74c97ca1b4b7: [clangd] Add tracer to the rename workflow, NFC (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74395/new/

[clang-tools-extra] 74c97ca - [clangd] Add tracer to the rename workflow, NFC

Author: Haojian Wu Date: 2020-02-14T15:39:29+01:00 New Revision: 74c97ca1b4b7d1a7497cebc0c9c91d2764a6f4b4 URL: https://github.com/llvm/llvm-project/commit/74c97ca1b4b7d1a7497cebc0c9c91d2764a6f4b4 DIFF: https://github.com/llvm/llvm-project/commit/74c97ca1b4b7d1a7497cebc0c9c91d2764a6f4b4.diff

[clang] 61dd060 - Move update_cc_test_checks.py tests to clang

Author: Alex Richardson Date: 2020-02-14T14:39:55Z New Revision: 61dd0603bd8afeaa0d467d19c1522b5fbcf0104c URL: https://github.com/llvm/llvm-project/commit/61dd0603bd8afeaa0d467d19c1522b5fbcf0104c DIFF: https://github.com/llvm/llvm-project/commit/61dd0603bd8afeaa0d467d19c1522b5fbcf0104c.diff

[PATCH] D74609: [clangd] Update the CompletionItemKind.

hokein updated this revision to Diff 244646. hokein marked 2 inline comments as done. hokein added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74609/new/ https://reviews.llvm.org/D74609 Files:

  1   2   >