[PATCH] D75003: [X86] Fix __code_model_*__ predefine names

This revision was automatically updated to reflect the committed changes. Closed by commit rG271f96477328: [Preprocessor][X86] Fix __code_model_*__ predefine macros (authored by mcgrathr, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 271f964 - [Preprocessor][X86] Fix __code_model_*__ predefine macros

Author: Roland McGrath Date: 2020-02-21T23:30:07-08:00 New Revision: 271f96477328f42cbf31a2b42433cdef8ed91914 URL: https://github.com/llvm/llvm-project/commit/271f96477328f42cbf31a2b42433cdef8ed91914 DIFF:

[PATCH] D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2e949eed5b4: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does (authored by mcgrathr, committed by MaskRay). Changed prior to commit: https://reviews.llvm.org/D75002?vs=246060=246061#toc

[clang] d2e949e - [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does

Author: Roland McGrath Date: 2020-02-21T23:27:36-08:00 New Revision: d2e949eed5b49ca70a8845dfaf7bac6ca40c429d URL: https://github.com/llvm/llvm-project/commit/d2e949eed5b49ca70a8845dfaf7bac6ca40c429d DIFF:

[PATCH] D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does

MaskRay updated this revision to Diff 246060. MaskRay added a comment. Add tests Rebase after -mcmodel cleanups (including fc6057e34fb3b1cfbbfcd5d71ae25ba24eb3ffa3 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] fc6057e - [Frontend] Replace CC1 option -mcode-model with -mcmodel=

Author: Fangrui Song Date: 2020-02-21T23:10:50-08:00 New Revision: fc6057e34fb3b1cfbbfcd5d71ae25ba24eb3ffa3 URL: https://github.com/llvm/llvm-project/commit/fc6057e34fb3b1cfbbfcd5d71ae25ba24eb3ffa3 DIFF: https://github.com/llvm/llvm-project/commit/fc6057e34fb3b1cfbbfcd5d71ae25ba24eb3ffa3.diff

[clang] 0123744 - [Preprocessor][test] Fix __VERSION__ in init-aarch64.c

Author: Fangrui Song Date: 2020-02-21T22:38:20-08:00 New Revision: 0123744d46a1fd6041755b403633af2d6c47f64a URL: https://github.com/llvm/llvm-project/commit/0123744d46a1fd6041755b403633af2d6c47f64a DIFF: https://github.com/llvm/llvm-project/commit/0123744d46a1fd6041755b403633af2d6c47f64a.diff

[clang] 59a572e - [Preprocessor][test] Move AArch64 tests from init.c to init-aarch.c

Author: Fangrui Song Date: 2020-02-21T22:22:59-08:00 New Revision: 59a572eb742437c17b78f6cf63f14d4b808fe61f URL: https://github.com/llvm/llvm-project/commit/59a572eb742437c17b78f6cf63f14d4b808fe61f DIFF: https://github.com/llvm/llvm-project/commit/59a572eb742437c17b78f6cf63f14d4b808fe61f.diff

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. I like this way better. I was hoping we could do it in our cmake only :) Give others a day or so to comment before your commit but I'm fine with this. CHANGES SINCE LAST ACTION

[PATCH] D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:200 +CodeModel = "small"; + for (auto& c : CodeModel) { +c = toupper(c); This can be simplified. I'll do that. Repository: rG LLVM Github

[PATCH] D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does

mcgrathr added a comment. Thanks! Can you land it for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75002/new/ https://reviews.llvm.org/D75002 ___ cfe-commits mailing list

[PATCH] D75003: [X86] Fix __code_model_*__ predefine names

mcgrathr added a comment. Thanks! Can you land it for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75003/new/ https://reviews.llvm.org/D75003 ___ cfe-commits mailing list

[PATCH] D74643: [Parse] Consider attributes in `TryParsePtrOperatorSeq`.

michele.scandale added a comment. @rsmith: is this fine for you as well? If this is ready for landing, I would appreciate if somebody can land this on my behalf since I do not have commit rights. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75003: [X86] Fix __code_model_*__ predefine names

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LG. The full story: // gcc/config/i386/i386-c.c case CM_SMALL: case CM_SMALL_PIC: def_or_undef (parse_in, "__code_model_small__"); break; case CM_MEDIUM:

[PATCH] D75003: [X86] Fix __code_model_*__ predefine names

mcgrathr created this revision. mcgrathr added a reviewer: tamur. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC defines __code_model_*__ (two trailing underscores), not __code_model_*_ (one trailing underscore). Repository: rG LLVM Github Monorepo

[PATCH] D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does

mcgrathr created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. mcgrathr updated this revision to Diff 246043. mcgrathr added a comment. mcgrathr edited the summary of this revision. update log Make Clang on aarch64 targets predefine

[PATCH] D75002: [AArch64] Predefine __AARCH64_CMODEL_*__ as GCC does

mcgrathr updated this revision to Diff 246043. mcgrathr added a comment. update log Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75002/new/ https://reviews.llvm.org/D75002 Files: clang/lib/Basic/Targets/AArch64.cpp

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

kkwli0 created this revision. kkwli0 added reviewers: tra, ABataev, JonChesterfield, jdoerfert, ye-luo. Herald added subscribers: guansong, mgorny. With CUDA 10.2 installed on the system, the compiler issues a warning about unknown CUDA version. The warning message makes the

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

scott.linder added a comment. Recommitted as 340feac6721e840f88c1e77dd79931eea5eaccf3 , hopefully this version sticks, cheers! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 340feac - [Driver] Escape the program path for -frecord-command-line

Author: Scott Linder Date: 2020-02-21T19:16:59-05:00 New Revision: 340feac6721e840f88c1e77dd79931eea5eaccf3 URL: https://github.com/llvm/llvm-project/commit/340feac6721e840f88c1e77dd79931eea5eaccf3 DIFF: https://github.com/llvm/llvm-project/commit/340feac6721e840f88c1e77dd79931eea5eaccf3.diff

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

jdoerfert updated this revision to Diff 246035. jdoerfert added a comment. Revert test check lines to the parser part only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74941/new/ https://reviews.llvm.org/D74941 Files:

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

jdoerfert updated this revision to Diff 246032. jdoerfert marked an inline comment as done. jdoerfert added a comment. Herald added a subscriber: jfb. Add tests and address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74941/new/

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/test/OpenMP/begin-declare-variant_elided_range_withouth_end.c:5 +// TODO: Improve the error message +#pragma omp begin declare variant match(device={kind(cpu)}) // expected-error

[PATCH] D74996: [arcconfig] Delete subproject arcconfigs

smeenai created this revision. smeenai added reviewers: jyknight, phosek, rnk. Herald added a reviewer: bollu. Herald added projects: clang, Sanitizers, LLDB, libc++, OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits, libcxx-commits, lldb-commits, Sanitizers, cfe-commits.

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

scott.linder added a comment. Sorry for the delay; I can just commit this, no need to update the review. I will hopefully be back to a terminal to push it a bit later tonight. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74811/new/

[PATCH] D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

vsapsai updated this revision to Diff 246005. vsapsai added a comment. - Fix some clang-format checks. Ignore the check to add a space between a generic name and its type parameters as it's not the style the rest of the header uses and not what Apple SDK headers are using. Repository: rG

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

ABataev added a comment. Sure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74970/new/ https://reviews.llvm.org/D74970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69868: Allow "callbr" to return non-void values

qcolombet added a comment. > I've been concerned about the register live-ins too (I'm less concerned about > the successors issue). Is there documentation on the original decision to > disallow physical register live-ins for MBBs before register allocation? We > could then check to see if

[PATCH] D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

vsapsai added a comment. In D72872#1872242 , @hans wrote: > [...snip...] > Thanks! I applied the patch and was able to build large parts of Chromium > without any problems. Thanks for checking! Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

jdoerfert marked 6 inline comments as done. jdoerfert added a comment. In D74941#1887367 , @fpetrogalli wrote: > 1. I am not familiar with `OpenMP technical report 8 (TR8)`. Could you please > provide a link in the description? Same for PR42061, PR42798,

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

cchen added a comment. @ABataev, can you land it for me when you have time? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74970/new/ https://reviews.llvm.org/D74970 ___ cfe-commits mailing list

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

ABataev added a comment. In D74941#1887381 , @kkwli0 wrote: > Since it is a TR8 feature, should we have this guarded by `-fopenmp-version=`? Not this one. It is required to fix the issues with math functions and should work for all versions of OpenMP.

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74970/new/ https://reviews.llvm.org/D74970

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

cchen updated this revision to Diff 245995. cchen added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74970/new/ https://reviews.llvm.org/D74970 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/target_messages.cpp

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

kkwli0 added a comment. Since it is a TR8 feature, should we have this guarded by `-fopenmp-version=`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74941/new/ https://reviews.llvm.org/D74941 ___

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

ABataev added a comment. In D74970#1887337 , @cchen wrote: > Fix test and sorry for my carelessness No problem. But I don't see the changes in the test. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15473 +

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

fpetrogalli added a comment. Hi @jdoerfert , thank you for working on this. I have a couple of high level comments. 1. I am not familiar with `OpenMP technical report 8 (TR8)`. Could you please provide a link in the description? Same for PR42061, PR42798, PR42799. It would be useful to get

[PATCH] D74972: [hexagon] Define __ELF__ by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd37cbda5f9a4: [Hexagon] Define __ELF__ by default. (authored by sidneym). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74972/new/

[clang] d37cbda - [Hexagon] Define __ELF__ by default.

Author: Sid Manning Date: 2020-02-21T16:10:31-06:00 New Revision: d37cbda5f9a47a4206439632ef4fa1534e66f856 URL: https://github.com/llvm/llvm-project/commit/d37cbda5f9a47a4206439632ef4fa1534e66f856 DIFF: https://github.com/llvm/llvm-project/commit/d37cbda5f9a47a4206439632ef4fa1534e66f856.diff

[PATCH] D74939: clang/Modules: Finish renaming CompilerInstance::ModuleManager, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6c8698924d2: clang/Modules: Finish renaming CompilerInstance::ModuleManager, NFC. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a6c8698 - clang/Modules: Finish renaming CompilerInstance::ModuleManager, NFC.

Author: Volodymyr Sapsai Date: 2020-02-21T13:56:50-08:00 New Revision: a6c8698924d2b31a2f096e0f4c06a7015ecccb5e URL: https://github.com/llvm/llvm-project/commit/a6c8698924d2b31a2f096e0f4c06a7015ecccb5e DIFF:

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

cchen updated this revision to Diff 245983. cchen added a comment. Fix test and sorry for my carelessness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74970/new/ https://reviews.llvm.org/D74970 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15358-15360 + if (!AE->getIdx()->isValueDependent()) +if (AE->getIdx()->EvaluateAsInt(Result, SemaRef.getASTContext())) { if (!Result.Val.getInt().isNullValue()) {

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

kkwli0 added a comment. So an alternative is to: - patch `openmp/runtime/cmake/LibompCheckLinkerFlag.cmake` to make the `libomp_check_linker_flag` function to ignore the "Unknown CUDA version" warning, AND - ask users to build with `-DCMAKE_CXX_FLAGS=-Wno-unknown-cuda-version

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

cchen updated this revision to Diff 245978. cchen added a comment. Add test for mapping function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74970/new/ https://reviews.llvm.org/D74970 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

cchen added a comment. In D74970#1887252 , @ABataev wrote: > In D74970#1887246 , @cchen wrote: > > > In D74970#1887193 , @ABataev wrote: > > > > > Did you try to run the

[PATCH] D74500: clang: Treat ieee mode as the default for denormal-fp-math

arsenm updated this revision to Diff 245972. arsenm edited the summary of this revision. arsenm added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74500/new/ https://reviews.llvm.org/D74500 Files: clang/include/clang/Basic/CodeGenOptions.h

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

kkwli0 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1251 "expected '#pragma omp end declare target'">; +def err_expected_end_declare_target_or_variant : Error< + "expected '#pragma omp end declare %select{target|variant}0'">;

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

ABataev added a comment. In D74970#1887246 , @cchen wrote: > In D74970#1887193 , @ABataev wrote: > > > Did you try to run the tests? I would suggest adding a test, at least, > > where a function is mapped. We

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

efriedma added a comment. In D74935#1886020 , @nhaehnle wrote: > I find this phrasing pretty confusing. How about the following: > > > This indicates that objects accessed via pointer values based on the > > argument or return value are not **modified**,

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

cchen marked an inline comment as done. cchen added a comment. In D74970#1887193 , @ABataev wrote: > Did you try to run the tests? I would suggest adding a test, at least, where > a function is mapped. We should see the error message here. Seems to me,

[PATCH] D62962: Clang implementation of sizeless types

efriedma added a comment. Can you make a list of the complete stack of patches here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62962/new/ https://reviews.llvm.org/D62962 ___ cfe-commits mailing

[PATCH] D74842: [clangd] Make use of syntax tokens in ReplayPreamble

kadircet updated this revision to Diff 245962. kadircet added a comment. - Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74842/new/ https://reviews.llvm.org/D74842 Files: clang-tools-extra/clangd/ParsedAST.cpp

[PATCH] D74842: [clangd] Make use of syntax tokens in ReplayPreamble

kadircet marked 7 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:138 + : Includes(Includes), Delegate(Delegate), SM(SM), PP(PP) { +MainFileTokens = syntax::tokenize(SM.getMainFileID(), SM, LangOpts); + }

[PATCH] D74842: [clangd] Make use of syntax tokens in ReplayPreamble

kadircet updated this revision to Diff 245960. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments. - Add tests by mimicking a clang-tidy check. - only tokenize the preamble section, not the whole file. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44958)

aganea added a comment. @llunak Small typo: your patch fixes PR44953, not PR44958. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74846/new/ https://reviews.llvm.org/D74846 ___ cfe-commits mailing list

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

ABataev added a comment. Did you try to run the tests? I would suggest adding a test, at least, where a function is mapped. We should see the error message here. Seems to me, we don't have this one. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15422-15423 +

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44958)

dblaikie added a comment. Please simplify the test case - at least to remove the long/uppercase identifiers to use placeholder names (this avoids any accidental semantic meaning they might carry (or appear to carry, but not actually carry)). What's the failure mode this is avoiding? There's no

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

cchen updated this revision to Diff 245955. cchen added a comment. Fix by feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74970/new/ https://reviews.llvm.org/D74970 Files: clang/lib/Sema/SemaOpenMP.cpp Index:

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

cchen marked 11 inline comments as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15450 } + bool VisitCXXThisExpr(CXXThisExpr *CTE) { return true; } + bool VisitStmt(Stmt *) { ABataev wrote: > Do you really need this function?

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 245929. Xiangling_L edited the summary of this revision. Xiangling_L added a comment. Update the testcase; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 Files: clang/include/clang/AST/Mangle.h

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

This revision was automatically updated to reflect the committed changes. Closed by commit rG0781e93a6eaa: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V (authored by luismarques). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0781e93 - [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

Author: Luís Marques Date: 2020-02-21T19:29:57Z New Revision: 0781e93a6eaa71ec5d87be3bbd053067f7ee URL: https://github.com/llvm/llvm-project/commit/0781e93a6eaa71ec5d87be3bbd053067f7ee DIFF: https://github.com/llvm/llvm-project/commit/0781e93a6eaa71ec5d87be3bbd053067f7ee.diff LOG:

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15319 } + return Visit(E); +} `return RelevantExpr || Visit(E);`? Comment at: clang/lib/Sema/SemaOpenMP.cpp:15346 } + return Visit(E); +}

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44958)

aganea added a reviewer: rsmith. aganea added a comment. I've tested this patch and it solves our original issue. Could anyone please take a look so that it can be landed & merged into 10.0? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74846/new/

[PATCH] D72579: Evaluate __{c11_,}atomic_is_lock_free to 0 (avoid libcall) if larger than MaxAtomicPromoteWidth

jyknight requested changes to this revision. jyknight added a comment. This revision now requires changes to proceed. This isn't correct. The atomic interface is designed to be forward-compatible with new CPUs that have wider atomic instructions. That clang has a MaxAtomicPromoteWidth value

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver marked an inline comment as done. zoecarver added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1834 +case CK_Tigerlake: +case CK_Lakemont: + craig.topper wrote: > zoecarver wrote: > > craig.topper wrote: > > > zoecarver wrote: >

[PATCH] D66178: Remove std::shared_ptr::make_shared and std::shared_ptr::allocate_shared

zoecarver added a comment. @ldionne friendly ping. This patch now //only// removes `std::shared_ptr::allocate_shared`. Should be an easy change. And I think we fixed @phosek's issue by breaking `__hold2.get()->get()` into a variable so that compilers that parse args backwards still work here.

[PATCH] D66178: Remove std::shared_ptr::make_shared and std::shared_ptr::allocate_shared

zoecarver updated this revision to Diff 245918. zoecarver added a comment. - Use __create_with_control_block in allocate_shared Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66178/new/ https://reviews.llvm.org/D66178 Files:

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1834 +case CK_Tigerlake: +case CK_Lakemont: + zoecarver wrote: > craig.topper wrote: > > zoecarver wrote: > > > craig.topper wrote: > > > > I think Lakemont is 16 bytes.

[PATCH] D74734: [AArch64][SVE] Add the SVE dupq_lane intrinsic

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:7495 + // DUPQ can be used when idx is in range. + auto CIdx = dyn_cast(Idx128); + if (CIdx &&

[clang] 1723f21 - Fix MSVC "not all control paths return a value" warning. NFCI.

Author: Simon Pilgrim Date: 2020-02-21T18:23:55Z New Revision: 1723f219939e1d4dc1c53ec7caf10c9380822b99 URL: https://github.com/llvm/llvm-project/commit/1723f219939e1d4dc1c53ec7caf10c9380822b99 DIFF: https://github.com/llvm/llvm-project/commit/1723f219939e1d4dc1c53ec7caf10c9380822b99.diff

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor class.

cchen updated this revision to Diff 245912. cchen added a comment. Fix based on feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74970/new/ https://reviews.llvm.org/D74970 Files: clang/lib/Sema/SemaOpenMP.cpp Index:

[PATCH] D68887: [clang-tidy] Copy the Ranges field from the Diagnostic when creating the ClangTidyError

compositeprimes updated this revision to Diff 245915. compositeprimes edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68887/new/ https://reviews.llvm.org/D68887 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp Index:

[PATCH] D74912: [AArch64][SVE] Add SVE2 intrinsics for bit permutation & table lookup

efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:1220 +void AArch64DAGToDAGISel::SelectTableSVE2(SDNode *N, unsigned Opc) { + SDLoc DL(N); Is it possible to write this as a TableGen pattern? We manage for other

[PATCH] D66178: Remove std::shared_ptr::make_shared and std::shared_ptr::allocate_shared

zoecarver updated this revision to Diff 245907. zoecarver edited the summary of this revision. zoecarver added a comment. Herald added projects: clang, libc++. Herald added a subscriber: cfe-commits. - Remove std::shared_ptr::allocate_shared Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74847/new/ https://reviews.llvm.org/D74847

[PATCH] D66178: Remove std::shared_ptr::make_shared and std::shared_ptr::allocate_shared

zoecarver updated this revision to Diff 245908. zoecarver added a comment. - Remove std::shared_ptr::allocate_shared Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66178/new/ https://reviews.llvm.org/D66178 Files: libcxx/include/memory Index:

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor clause.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15356 + Expr::EvalResult Result; + if (AE->getIdx()->EvaluateAsInt(Result, SemaRef.getASTContext())) { +if (!Result.Val.getInt().isNullValue()) { cchen wrote: > ABataev

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:151 + + using ValueConstraintPtr = std::shared_ptr; + /// The complete list of constraints that defines a single branch.

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor clause.

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15356 + Expr::EvalResult Result; + if (AE->getIdx()->EvaluateAsInt(Result, SemaRef.getASTContext())) { +if (!Result.Val.getInt().isNullValue()) {

[PATCH] D74833: [AArch64][SVE] Add intrinsics for SVE2 cryptographic instructions

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74833/new/ https://reviews.llvm.org/D74833

[PATCH] D74934: [Clang interpreter] Rename Block.{h,cpp} to InterpBlock.{h,cpp}

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4df934ca7b4: [Clang interpreter] Rename Block.{h,cpp} to InterpBlock.{h,cpp} (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

martong created this revision. martong added reviewers: NoQ, Szelethus, balazske, gamesh411, baloghadamsoftware, steakhal. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a project: clang.

[clang] e4df934 - [Clang interpreter] Rename Block.{h,cpp} to InterpBlock.{h,cpp}

Author: Fangrui Song Date: 2020-02-21T09:47:28-08:00 New Revision: e4df934ca7b408cfb52531016198545a8d50f41a URL: https://github.com/llvm/llvm-project/commit/e4df934ca7b408cfb52531016198545a8d50f41a DIFF: https://github.com/llvm/llvm-project/commit/e4df934ca7b408cfb52531016198545a8d50f41a.diff

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

jasonliu added a comment. Just kindly reminder that you might want to update the Summary in the commit message to reflect the new name we picked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74015/new/ https://reviews.llvm.org/D74015

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver updated this revision to Diff 245897. zoecarver added a comment. - Update getCPUCacheLineSize to return optional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/ https://reviews.llvm.org/D74918 Files:

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver updated this revision to Diff 245896. zoecarver marked 6 inline comments as done. zoecarver added a comment. - Update values returned by getCPUCacheLineSize based on review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

compositeprimes added a comment. I don't have commit rights (this is my first llvm commit!), so could someone help out? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69782/new/ https://reviews.llvm.org/D69782 ___ cfe-commits

[PATCH] D74912: [AArch64][SVE] Add SVE2 intrinsics for bit permutation & table lookup

sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:1226 + // intrinsic currently, where NumVecs is always 2 + unsigned NumVecs = 2; + nit: You can just as well inline this value now. Comment at:

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! Do you have commit rights or should someone help you committing the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69782/new/ https://reviews.llvm.org/D69782

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver marked an inline comment as done. zoecarver added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1834 +case CK_Tigerlake: +case CK_Lakemont: + craig.topper wrote: > zoecarver wrote: > > craig.topper wrote: > > > I think Lakemont

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

xur updated this revision to Diff 245891. xur added reviewers: mehdi_amini, serge-sans-paille. xur added a comment. Update the patch based on the reviews from Mehdi and Serge. Reuse Sege's warning code in https://reviews.llvm.org/D74871?id=245594. CHANGES SINCE LAST ACTION

[PATCH] D74970: [OpenMP] Refactor the analysis in checkMapClauseBaseExpression using StmtVisitor clause.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15238 + Sema + OpenMPClauseKind CKind; + OMPClauseMappableExprCommon::MappableExprComponentList Default initializer here Comment at:

[PATCH] D74840: [AST matchers] Add basic matchers for googletest EXPECT/ASSERT calls.

This revision was automatically updated to reflect the committed changes. Closed by commit rG23444edf30ba: [AST matchers] Add basic matchers for googletest EXPECT/ASSERT calls. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74972: [hexagon] Define __ELF__ by default.

sidneym created this revision. sidneym added reviewers: kparzysz, bcain. Herald added subscribers: Sanitizers, cfe-commits, mgorny. Herald added projects: clang, Sanitizers, LLVM. __ELF__ is not enabled by default. Correcting an issue in compiler-rt's cmake revealed that __ELF__ was not

[clang] 23444ed - [AST matchers] Add basic matchers for googletest EXPECT/ASSERT calls.

Author: Yitzhak Mandelbaum Date: 2020-02-21T12:05:15-05:00 New Revision: 23444edf30ba00ccefa3a582ac7ddc29774e9da5 URL: https://github.com/llvm/llvm-project/commit/23444edf30ba00ccefa3a582ac7ddc29774e9da5 DIFF:

Re: [PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

OK. I will add a warning but not turn it off at the CodeGenOpt (but it will not pass to LLVMContext). I will update the patch shortly. On Fri, Feb 21, 2020 at 1:53 AM serge via Phabricator < revi...@reviews.llvm.org> wrote: > serge-sans-paille added a comment. > > Let's go that way then. @xur I

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

luismarques updated this revision to Diff 245881. luismarques edited the summary of this revision. luismarques added a comment. Herald added a subscriber: fedor.sergeev. As suggested by @efriedma, the patch was reworked to have one target with native atomics, and one without. No RUN run with a

  1   2   >