[PATCH] D75561: Remove const qualifier from Modules returned by ExternalASTSource. (NFC)

aprantl added a comment. I added a comment to D75488 . It's in getOrCreateModule(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75561/new/ https://reviews.llvm.org/D75561 ___ cfe-commits mailing list

[PATCH] D76772: [AMDGPU] Add __builtin_amdgcn_workgroup_size_x/y/z

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13428 +return Call; + return CGF.Builder.CreateAddrSpaceCast(Call, RetTy); +} arsenm wrote: > Why is this necessary? The builtin always has the same return type? due to

[PATCH] D74541: [Analyzer] Use note tags to track iterator increments and decrements

baloghadamsoftware marked 4 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/test/Analysis/iterator-modelling.cpp:434 + //expected-note@-1 0-1{{Calling 'next}} + //expected-note@-2 0-1{{Passing the value 1 via 2nd parameter 'n'}} +

[PATCH] D76772: [AMDGPU] Add __builtin_amdgcn_workgroup_size_x/y/z

yaxunl updated this revision to Diff 252621. yaxunl marked 9 inline comments as done. yaxunl added a comment. Revised by Matt's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76772/new/ https://reviews.llvm.org/D76772 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def

[PATCH] D76525: Expose cache line size in __builtin_get_cpu_cache_line_size

zoecarver added a comment. @jyknight yes, the current plan is to use it in libc++'s implementation. I can put that implementation (which uses this builtin) up for review before this lands. That way we can discuss the implementation before adding a (possibly unneeded) builtin. Sound good?

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb915aec6b591: Add method to TargetInfo to get CPU cache line size (authored by zoecarver). Repository: rG LLVM Github

[PATCH] D76741: [clangd] Support multiple cursors in selectionRange.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f237f9b09aa: [clangd] Support multiple cursors in selectionRange. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76741/new/

[PATCH] D76610: [ARM,CDE] Implement predicated Q-register CDE intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb4da94e5b5f: [ARM,CDE] Implement predicated Q-register CDE intrinsics (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76610/new/

[PATCH] D76443: Use ConstantExpr cached APValues if present for code generation

wchilders updated this revision to Diff 252610. wchilders added a comment. Updated to remove duplicated (and out dated) APValue generation logic, and fixed formatting issues. (Thanks for pointing out something was awry Tyker) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76443/new/

[PATCH] D76782: [CodeGenObjC] Fix a crash when attempting to copy a zero-sized bit-field in a non-trivial C struct

erik.pilkington created this revision. erik.pilkington added a reviewer: ahatanak. Herald added subscribers: ributzka, dexonsmith, jkorous. Zero sized bit-fields aren't included in the CGRecordLayout, so we shouldn't be calling EmitLValueForField for them. rdar://60695105

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

Anastasia added a comment. Sorry for the delayed comments. It would be good to address those in a separate commit if possible. Comment at: clang/test/CodeGenOpenCL/pipe_types_mangling.cl:12 +// WINDOWS: define dso_local void @"?test1@@YAXU?$ocl_pipe@H$00@__clang@@@Z" +//

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_runtime_wrapper.h:82-94 #undef __CUDACC__ #if CUDA_VERSION < 9000 #define __CUDABE__ #else +#define __CUDACC__ #define __CUDA_LIBDEVICE__ #endif hliao wrote: > hliao wrote: > > tra

[PATCH] D76770: [CodeComplete] Don't replace the rest of line in #include completion.

sammccall added a comment. Does this regress the case where you complete a file rather than a directory? e.g. `#include "foo/^one.h"` If you select "two.h", then we definitely want to replace "one.h", right? The root here is that we have to decide what to replace independently of the completion

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added inline comments. Comment at: clang/include/clang/AST/Expr.h:3465 +SubExprs[RHS] = rhs; +hasFPFeatures = true; +isCompoundAssign = 1; mibintc wrote: > rjmccall wrote: > > Okay, so this is *always* adding trailing storage. Is there a

[PATCH] D76525: Expose cache line size in __builtin_get_cpu_cache_line_size

jyknight added a comment. I don't think there's a particularly good reason to expose this as a builtin, unless it's to be used by the standard library implementation. (Which again I do not think we should implement.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

JonChesterfield added a comment. edit: actually you've already done the clang-format on trunk as I hoped, phabricator mislead me. Apologies for the noise Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver added a comment. @lebedev.ri my misunderstanding. I'll commit :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/ https://reviews.llvm.org/D74918 ___ cfe-commits mailing list

[clang] bb4da94 - [ARM, CDE] Implement predicated Q-register CDE intrinsics

Author: Mikhail Maltsev Date: 2020-03-25T17:08:19Z New Revision: bb4da94e5b5f64ea68197de9be44c7c5a4c91ce7 URL: https://github.com/llvm/llvm-project/commit/bb4da94e5b5f64ea68197de9be44c7c5a4c91ce7 DIFF: https://github.com/llvm/llvm-project/commit/bb4da94e5b5f64ea68197de9be44c7c5a4c91ce7.diff

[clang-tools-extra] 8f237f9 - [clangd] Support multiple cursors in selectionRange.

Author: Sam McCall Date: 2020-03-25T17:59:09+01:00 New Revision: 8f237f9b09aa10fcb684a2ceddc3128e1cafadc7 URL: https://github.com/llvm/llvm-project/commit/8f237f9b09aa10fcb684a2ceddc3128e1cafadc7 DIFF: https://github.com/llvm/llvm-project/commit/8f237f9b09aa10fcb684a2ceddc3128e1cafadc7.diff

[clang] eaa7d00 - [analyzer][NFC] Add missing LLVM header blurb (and license)

Author: Gabor Marton Date: 2020-03-25T17:57:29+01:00 New Revision: eaa7d00f366ba53e9cf4391163b93253065c2e6c URL: https://github.com/llvm/llvm-project/commit/eaa7d00f366ba53e9cf4391163b93253065c2e6c DIFF: https://github.com/llvm/llvm-project/commit/eaa7d00f366ba53e9cf4391163b93253065c2e6c.diff

[clang] b915aec - Add method to TargetInfo to get CPU cache line size

Author: zoecarver Date: 2020-03-25T09:50:38-07:00 New Revision: b915aec6b591bdd9a9ffef73db241353b5ba2e2c URL: https://github.com/llvm/llvm-project/commit/b915aec6b591bdd9a9ffef73db241353b5ba2e2c DIFF: https://github.com/llvm/llvm-project/commit/b915aec6b591bdd9a9ffef73db241353b5ba2e2c.diff

[PATCH] D75661: Remove SequentialType from the type heirarchy.

ctetreau added a comment. I'd like the see the clang-format complaints actually addressed, but don't bother unless you need to upload another patch for some other reason anyways. That aside, LGTM. This has been looked at by 3 people (plus yourself). So far, nobody has had any serious

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:409 - Optional FoundSummary = findFunctionSummary(FD, CE, C); + for (const ValueConstraintPtr& VC : Summary.ArgConstraints) { +ProgramStateRef SuccessSt =

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/include/clang/AST/Expr.h:3465 +SubExprs[RHS] = rhs; +hasFPFeatures = true; +isCompoundAssign = 1; rjmccall wrote: > Okay, so this is *always* adding trailing

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

lebedev.ri added a comment. Like i said in previous comments, this can be moved later, that is not a blocker. Ship it first :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/ https://reviews.llvm.org/D74918

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. I don't see those Harbormaster fails, using trunk and RHEL8 on architecture x86_64, Debug build of clang;clang-tools-extra and check-all. I ran all the failed lit tests separately and each passed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver added a comment. I don't know enough about clang and llvm to know what is both possible and preferable. @craig.topper @lebedev.ri what is the best course of action here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/

[PATCH] D76525: Expose cache line size in __builtin_get_cpu_cache_line_size

zoecarver added a comment. @craig.topper thanks for the comments! I'm going to hold off on updating this until we figure out what's happening with D74918 , though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added inline comments. Comment at: clang/include/clang/AST/Expr.h:2573 + FPOptions FPFeatures; + Let's split the CallExpr changes out into a separate patch, so that we have one patch that's *purely* about unifying BinaryOperator and

[PATCH] D76772: [AMDGPU] Add __builtin_amdgcn_workgroup_size_x/y/z

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13428 +return Call; + return CGF.Builder.CreateAddrSpaceCast(Call, RetTy); +} Why is this necessary? The builtin always has the same return type? Comment at:

[PATCH] D43159: Modernize: Use nullptr more.

ldionne added a comment. Ping -- is there still interest in moving forward with this? If so, please address the comments and update the patch, otherwise you can abandon the revision to clean up the libc++ review queue. Repository: rCXX libc++ CHANGES SINCE LAST ACTION

[PATCH] D76761: [clang-tidy] Fix crash in readability-redundant-string-cstr

gribozavr2 added a comment. In D76761#1941380 , @njames93 wrote: > In D76761#1941070 , @gribozavr2 > wrote: > > > Could you provide more information about why these null checks are needed > > in this case? > > >

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:1 +#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h" +#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

jdoerfert added a comment. Herald added a subscriber: kerbowa. [reverse ping] Is this still active? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70366/new/ https://reviews.llvm.org/D70366 ___

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:409 - Optional FoundSummary = findFunctionSummary(FD, CE, C); + for (const ValueConstraintPtr& VC : Summary.ArgConstraints) { +ProgramStateRef SuccessSt =

[PATCH] D31343: Add an attribute plugin example

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f03c12a51be: Add an attribute plugin example (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31343/new/

[PATCH] D76704: Don't normalise CXX11/C2X attribute names to start with ::

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc3f171090f6: Dont normalise CXX11/C2X attribute names to start with :: (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org/D76704?vs=252308=252578#toc Repository: rG LLVM

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

kmclaughlin updated this revision to Diff 252575. kmclaughlin marked an inline comment as done. kmclaughlin added a comment. Use SmallSetVector for the list of functions gathered by runOnModule to preserve the order of iteration CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76078/new/

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

This revision was automatically updated to reflect the committed changes. Closed by commit rG86e0a6c60627: Add MS Mangling for OpenCL Pipe types, add mangling test. (authored by erichkeane). Herald added a project: clang. Changed prior to commit:

[PATCH] D76761: [clang-tidy] Fix crash in readability-redundant-string-cstr

njames93 added a comment. In D76761#1941070 , @gribozavr2 wrote: > Could you provide more information about why these null checks are needed in > this case? Well the fact it was crashing without those null checks was the reason they were added. I'm

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao marked 3 inline comments as done. hliao added inline comments. Comment at: clang/lib/Headers/__clang_cuda_runtime_wrapper.h:82-94 #undef __CUDACC__ #if CUDA_VERSION < 9000 #define __CUDABE__ #else +#define __CUDACC__ #define __CUDA_LIBDEVICE__ #endif

[PATCH] D75779: [OpenMP] `omp begin/end declare variant` - part 2, sema (+"CG")

hfinkel added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5396 + IdentifierInfo = Context.Idents.get( + (D.getIdentifier()->getName() + "." + DVScope.NameSuffix).str()); + D.SetIdentifier(, D.getBeginLoc()); jdoerfert wrote: > hfinkel

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:409 - Optional FoundSummary = findFunctionSummary(FD, CE, C); + for (const ValueConstraintPtr& VC : Summary.ArgConstraints) {

[PATCH] D31343: Add an attribute plugin example

aaron.ballman added a comment. I think this was the last remaining review for the feature to support attributes as plugins, yes? If so, can you please add a release note about the feature to the release notes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31343/new/

[clang] 86e0a6c - Add MS Mangling for OpenCL Pipe types, add mangling test.

Author: Erich Keane Date: 2020-03-25T07:59:22-07:00 New Revision: 86e0a6c6062705ec8f6f7333872d566e74d66424 URL: https://github.com/llvm/llvm-project/commit/86e0a6c6062705ec8f6f7333872d566e74d66424 DIFF: https://github.com/llvm/llvm-project/commit/86e0a6c6062705ec8f6f7333872d566e74d66424.diff

Re: [clang] c278e8f - Build fix: AttributeCommonInfo::AS_C2x

Thanks, I was about to fix that myself (I was sure I'd built and tested everything before committing, but it appears I failed somehow). John From: cfe-commits on behalf of Hans Wennborg via cfe-commits Sent: 25 March 2020 14:43 To: cfe-commits@lists.llvm.org

[clang] c278e8f - Build fix: AttributeCommonInfo::AS_C2x

Author: Hans Wennborg Date: 2020-03-25T15:42:21+01:00 New Revision: c278e8f8f916fd8781f24e41a8685514cc448670 URL: https://github.com/llvm/llvm-project/commit/c278e8f8f916fd8781f24e41a8685514cc448670 DIFF: https://github.com/llvm/llvm-project/commit/c278e8f8f916fd8781f24e41a8685514cc448670.diff

[clang] 3f03c12 - Add an attribute plugin example

Author: John Brawn Date: 2020-03-25T14:33:44Z New Revision: 3f03c12a51be656c595301ace832c24a68601ee2 URL: https://github.com/llvm/llvm-project/commit/3f03c12a51be656c595301ace832c24a68601ee2 DIFF: https://github.com/llvm/llvm-project/commit/3f03c12a51be656c595301ace832c24a68601ee2.diff LOG:

[PATCH] D75010: [OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime calls.

This revision was automatically updated to reflect the committed changes. Closed by commit rG72b51d6f93b5: OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime… (authored by sstefan1). Changed prior to commit: https://reviews.llvm.org/D75010?vs=250599=252572#toc

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5a034e771d0: [SYCL] Implement __builtin_unique_stable_name. (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bc3f171 - Don't normalise CXX11/C2X attribute names to start with ::

Author: John Brawn Date: 2020-03-25T14:33:44Z New Revision: bc3f171090f6d9f84a5d7b333bc70a1e14afffd4 URL: https://github.com/llvm/llvm-project/commit/bc3f171090f6d9f84a5d7b333bc70a1e14afffd4 DIFF: https://github.com/llvm/llvm-project/commit/bc3f171090f6d9f84a5d7b333bc70a1e14afffd4.diff LOG:

[PATCH] D76774: [cmake] Link libc++ tests against static libc++/libc++abi in CrossWinToARMLinux.cmake

broadwaylamb created this revision. broadwaylamb added a reviewer: vvereschaka. Herald added subscribers: cfe-commits, kristof.beyls, mgorny. Herald added a project: clang. Now that D72687 has landed, we can enable this setting in our cache file. Repository:

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75685: Add MS Mangling for OpenCL Pipe types, add mangling test.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75685/new/ https://reviews.llvm.org/D75685 ___ cfe-commits mailing

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux marked 5 inline comments as done. yroux added a comment. Thanks for the review Sam, I'll update the patch with more tests (for CPSR/LR it was part of D76068 but you are right it should be done here) and take your comments into account. In D76066#1921331

[clang] 72b51d6 - OpenMP] Adding InaccessibleMemOnly and InaccessibleMemOrArgMemOnly for runtime calls.

Author: sstefan1 Date: 2020-03-25T14:08:50Z New Revision: 72b51d6f93b503be23ead4dce850b5240834bbb7 URL: https://github.com/llvm/llvm-project/commit/72b51d6f93b503be23ead4dce850b5240834bbb7 DIFF: https://github.com/llvm/llvm-project/commit/72b51d6f93b503be23ead4dce850b5240834bbb7.diff LOG:

[clang] b5a034e - [SYCL] Implement __builtin_unique_stable_name.

Author: Erich Keane Date: 2020-03-25T07:01:50-07:00 New Revision: b5a034e771d0e4d7d8e71fc545b230d98e5a1f42 URL: https://github.com/llvm/llvm-project/commit/b5a034e771d0e4d7d8e71fc545b230d98e5a1f42 DIFF: https://github.com/llvm/llvm-project/commit/b5a034e771d0e4d7d8e71fc545b230d98e5a1f42.diff

[PATCH] D76764: [AST] Build recovery expressions for nonexistent member exprs.

hokein updated this revision to Diff 252559. hokein marked an inline comment as done. hokein added a comment. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous. address comment and fix a failing testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76772: [AMDGPU] Add __builtin_amdgcn_workgroup_size_x/y/z

yaxunl created this revision. yaxunl added reviewers: arsenm, b-sumner, cfang. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. The main purpose of introducing these builtins is to add a range metadata [1, 1025) on the work group size loaded from

[PATCH] D76741: [clangd] Support multiple cursors in selectionRange.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. Thanks. LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76741/new/ https://reviews.llvm.org/D76741

[PATCH] D76770: [CodeComplete] Don't replace the rest of line in #include completion.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. The previous behavior was aggressive, #include "abc/f^/abc.h" foo/ -> candidate "f/abc.h" is replaced with

[PATCH] D71612: [analyzer] Add PlacementNewChecker

Szelethus added inline comments. Herald added subscribers: ASDenysPetrov, steakhal. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:1 +#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h" +#include

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76140/new/ https://reviews.llvm.org/D76140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76764: [AST] Build recovery expressions for nonexistent member exprs.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang/lib/Parse/ParseExpr.cpp:2107 + } else if (OrigLHS && Name.isValid()) { +// Preserve the member expr if the LHS is an invalid

[PATCH] D76688: [AArch64][SVE] Add SVE intrinsics for masked loads & stores

This revision was automatically updated to reflect the committed changes. Closed by commit rG05606329e235: [AArch64][SVE] Add SVE intrinsics for masked loads stores (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76688/new/

[PATCH] D76741: [clangd] Support multiple cursors in selectionRange.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1194-1201 if (Params.positions.size() != 1) { elog("{0} positions provided to SelectionRange. Supports exactly one " "position.", Params.positions.size());

[PATCH] D76761: [clang-tidy] Fix crash in readability-redundant-string-cstr

gribozavr2 added a comment. Could you provide more information about why these null checks are needed in this case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76761/new/ https://reviews.llvm.org/D76761

[PATCH] D76741: [clangd] Support multiple cursors in selectionRange.

sammccall updated this revision to Diff 252545. sammccall marked 8 inline comments as done. sammccall added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76741/new/ https://reviews.llvm.org/D76741 Files:

[PATCH] D76764: [AST] Build recovery expressions for nonexistent member exprs.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Previously, we dropped the AST node for nonexistent member exprs. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76764 Files: clang/lib/Parse/ParseExpr.cpp

[PATCH] D76694: [Sema][SVE] Allow casting SVE types to themselves in C

This revision was automatically updated to reflect the committed changes. Closed by commit rG856bdd01fd65: [Sema][SVE] Allow casting SVE types to themselves in C (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76694/new/

[PATCH] D76693: [Sema][SVE] Allow ?: to select between SVE types in C

This revision was automatically updated to reflect the committed changes. Closed by commit rG578fb2501a66: [Sema][SVE] Allow ?: to select between SVE types in C (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76693/new/

[clang] 856bdd0 - [Sema][SVE] Allow casting SVE types to themselves in C

Author: Richard Sandiford Date: 2020-03-25T10:52:43Z New Revision: 856bdd01fd65002d8d88b491bbff53648b6002c1 URL: https://github.com/llvm/llvm-project/commit/856bdd01fd65002d8d88b491bbff53648b6002c1 DIFF: https://github.com/llvm/llvm-project/commit/856bdd01fd65002d8d88b491bbff53648b6002c1.diff

[clang] 578fb25 - [Sema][SVE] Allow ?: to select between SVE types in C

Author: Richard Sandiford Date: 2020-03-25T10:31:09Z New Revision: 578fb2501a66e407187ec0ac4da20995265f91c8 URL: https://github.com/llvm/llvm-project/commit/578fb2501a66e407187ec0ac4da20995265f91c8 DIFF: https://github.com/llvm/llvm-project/commit/578fb2501a66e407187ec0ac4da20995265f91c8.diff

[PATCH] D76761: [clang-tidy] Fix crash in readability-redundant-string-cstr

njames93 created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76761 Files: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp

[PATCH] D76714: [ARM,MVE] Add missing tests for vqdmlash intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f1651ccead1: [ARM,MVE] Add missing tests for vqdmlash intrinsics. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76714/new/

[PATCH] D76741: [clangd] Support multiple cursors in selectionRange.

usaxena95 added a comment. Mostly looks good. Few nits. Thanks. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1194-1201 if (Params.positions.size() != 1) { elog("{0} positions provided to SelectionRange. Supports exactly one " "position.",

[clang] 8f1651c - [ARM, MVE] Add missing tests for vqdmlash intrinsics.

Author: Simon Tatham Date: 2020-03-25T09:46:16Z New Revision: 8f1651ccead149fbd2e6fe692fb8a7f787a222bd URL: https://github.com/llvm/llvm-project/commit/8f1651ccead149fbd2e6fe692fb8a7f787a222bd DIFF: https://github.com/llvm/llvm-project/commit/8f1651ccead149fbd2e6fe692fb8a7f787a222bd.diff LOG:

[PATCH] D76054: [clang-apply-replacements] No longer deduplucates replacements from the same TU

This revision was automatically updated to reflect the committed changes. Closed by commit rG6538b4393dc3: [clang-apply-replacements] No longer deduplucates replacements from the same TU (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware updated this revision to Diff 252519. baloghadamsoftware added a comment. Test added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73720/new/ https://reviews.llvm.org/D73720 Files: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp

[PATCH] D76714: [ARM,MVE] Add missing tests for vqdmlash intrinsics.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76714/new/ https://reviews.llvm.org/D76714

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske added a comment. So what is missing or wrong in this change to be accepted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75682/new/ https://reviews.llvm.org/D75682 ___ cfe-commits mailing

[clang-tools-extra] 6538b43 - [clang-apply-replacements] No longer deduplucates replacements from the same TU

Author: Nathan James Date: 2020-03-25T09:36:36Z New Revision: 6538b4393dc3e7df9fee2b07eba148d4cf603a24 URL: https://github.com/llvm/llvm-project/commit/6538b4393dc3e7df9fee2b07eba148d4cf603a24 DIFF: https://github.com/llvm/llvm-project/commit/6538b4393dc3e7df9fee2b07eba148d4cf603a24.diff LOG:

[PATCH] D70411: [analyzer] CERT: STR31-C

balazske added inline comments. Comment at: clang/docs/analyzer/checkers.rst:1935 + +alpha.security.cert.str.31c +""" Charusso wrote: > Szelethus wrote: > > balazske wrote: > > > There are already more checkers that can check for CERT

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/ https://reviews.llvm.org/D76062

[PATCH] D76744: [clang-tidy] Add check to ensure llvm-libc implementations are defined in correct namespace.

njames93 added a comment. This check should only worry about the first declaration of the function, any redecls or the definition could appear outside the namespace like this: namespace blah{ void foo(); } void blah::foo(); void blah::foo(){} There are some missing test cases I'd

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0788acbccbec: [AST] Build recovery expressions by default for C++. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D76696?vs=252513=252515#toc Repository: rG LLVM Github

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:2440 TEST_F(FormatTest, FormatsExternC) { - verifyFormat("extern \"C\" {\nint a;"); - verifyFormat("extern \"C\" {}"); + verifyFormat("extern \"C\" {\nint a; /*2.1*/"); +

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

jhenderson accepted this revision. jhenderson added a comment. LGTM, with nit, with regards to the llvm-readobj and libObject parts. I haven't looked at the other bits though. Comment at: llvm/lib/CodeGen/AsmPrinter/OcamlGCPrinter.cpp:150 + ">=

[PATCH] D75561: Remove const qualifier from Modules returned by ExternalASTSource. (NFC)

teemperor added a comment. Can you link what code is actually requiring this change? I just went over the patch series and it's not obvious to me what exactly this is used for. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75561/new/ https://reviews.llvm.org/D75561

[PATCH] D76595: [clangd-vscode] NFC; Improve wording in documentation and update VSCode tasks

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. In D76595#1938727 , @kbobyrev wrote: > In D76595#1936408 , @hokein wrote: > > > thanks. regarding files in

[clang-tools-extra] 0788acb - [AST] Build recovery expressions by default for C++.

Author: Haojian Wu Date: 2020-03-25T09:00:48+01:00 New Revision: 0788acbccbec094903a3425ffe5a98f8d55cbd64 URL: https://github.com/llvm/llvm-project/commit/0788acbccbec094903a3425ffe5a98f8d55cbd64 DIFF: https://github.com/llvm/llvm-project/commit/0788acbccbec094903a3425ffe5a98f8d55cbd64.diff

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

hokein added a comment. In D76696#1939513 , @sammccall wrote: > Do you also want to update LangOpts.td to make the default for the langopt > equal to CPlusPlus? > (I saw other opts doing that, not sure exactly what it affects, may be > voodoo cargo

[PATCH] D76696: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 252513. hokein marked an inline comment as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76696/new/ https://reviews.llvm.org/D76696 Files:

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:713 + StringRef Name; + if (const auto *DRE = dyn_cast(ContE->IgnoreParenCasts())) { +Name = DRE->getDecl()->getName(); baloghadamsoftware wrote: > NoQ wrote: >

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:409 - Optional FoundSummary = findFunctionSummary(FD, CE, C); + for (const ValueConstraintPtr& VC : Summary.ArgConstraints) { +ProgramStateRef SuccessSt =

<    1   2