[PATCH] D77482: [clang-tools-extra] NFC: Fix trivial typo in documents and comments

kiszk added a comment. Thank you for letting me know. I will do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77482/new/ https://reviews.llvm.org/D77482 ___ cfe-commits mailing list

[PATCH] D77484: [Vector] Pass VectLib to LTO backend so TLI build correct vector function list

wenlei created this revision. wenlei added reviewers: hoyFB, spatel. Herald added subscribers: cfe-commits, dang, dexonsmith, steven_wu, MaskRay, hiraditya, arichardson, inglorion, emaste. Herald added a reviewer: espindola. Herald added a project: clang. -fveclib switch not propagated to LTO

[PATCH] D77482: [clang-tools-extra] NFC: Fix trivial typo in documents and comments

Eugene.Zelenko added a comment. In D77482#1962000 , @kiszk wrote: > @sammccall, I am very sorry that I led to the build break due to my > misoperation in https://reviews.llvm.org/D77458 You could just update diff in existing revision. No need to create

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

rsmith added a comment. In D77184#1961495 , @thakis wrote: > In D77184#1961220 , @rsmith wrote: > > > In D77184#1961214 , @rsmith wrote: > > > > > In D77184#1961208

[PATCH] D77482: [clang-tools-extra] NFC: Fix trivial typo in documents and comments

kiszk added a subscriber: sammccall. kiszk added a comment. Herald added a subscriber: wuzish. @sammccall, I am very sorry that I led to the build break due to my misoperation in https://reviews.llvm.org/D77458 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77482: [clang-tools-extra] NFC: Fix trivial typo in documents and comments

kiszk created this revision. Herald added subscribers: cfe-commits, phosek, usaxena95, kadircet, jfb, arphaman, jkorous, kbarton, nemanjai. Herald added a project: clang. This also includes the build failure due to https://reviews.llvm.org/D77458 Repository: rG LLVM Github Monorepo

[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments

This revision was automatically updated to reflect the committed changes. Closed by commit rGabdd042bb7a5: [clang-tools-extra] NFC: Fix trivial typo in documents and comments (authored by kiszk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D57835: Fix -ftime-report with -x ir

arsenm updated this revision to Diff 255095. arsenm added a comment. Rebase, add new PM run line CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57835/new/ https://reviews.llvm.org/D57835 Files: clang/lib/CodeGen/CodeGenAction.cpp clang/lib/Frontend/CompilerInstance.cpp

[PATCH] D77252: [OpenMP] Try to find an existing base for `omp begin/end declare variant`

jdoerfert added a comment. In D77252#1961913 , @mikerice wrote: > [...] > >[...] > TypeSourceInfo *TInfo = GetTypeForDeclarator(D, S); > QualType FType = TInfo->getType(); > [...] > I think this is a key part of what I was missing. I'll try

[clang-tools-extra] abdd042 - [clang-tools-extra] NFC: Fix trivial typo in documents and comments

Author: Kazuaki Ishizaki Date: 2020-04-05T11:26:19+09:00 New Revision: abdd042bb7a58bdb2511f0c776ced2c7cb71cac4 URL: https://github.com/llvm/llvm-project/commit/abdd042bb7a58bdb2511f0c776ced2c7cb71cac4 DIFF:

[PATCH] D77252: [OpenMP] Try to find an existing base for `omp begin/end declare variant`

mikerice added a comment. I just moved your lookup code and tried to get the same info from the declarator. The function looks like this: FunctionDecl * Sema::ActOnStartOfFunctionDefinitionInOpenMPDeclareVariantScope(Scope *S,

[PATCH] D77252: [OpenMP] Try to find an existing base for `omp begin/end declare variant`

jdoerfert marked 2 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5512 + + if (!BaseFD) { +// TODO: Determine if we can reuse the declarator to create a declaration mikerice wrote: > I think if you do the

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper updated this revision to Diff 255086. craig.topper added a comment. -Add methods to get the index of a Node or Edge to remove calls to std::distance in various places CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75936/new/ https://reviews.llvm.org/D75936 Files:

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper updated this revision to Diff 255084. craig.topper added a comment. -Apply updates to comments. -Use nodes()/edges() to implement nodes_begin/end and edges_begin/end to simplify the code a little -Reorder fields in the Graph class. CHANGES SINCE LAST ACTION

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper marked 2 inline comments as done. craig.topper added inline comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:329 +size_type VI = 0, EI = 0; +for (; VI < static_cast(AdjList.size()); ++VI) { + VertexArray[VI].Value =

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper marked 2 inline comments as done. craig.topper added inline comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:285 + std::unique_ptr Edges; + size_type EdgesSize; +}; sconstab wrote: > @craig.topper It now occurs to me that these fields

[PATCH] D77252: [OpenMP] Try to find an existing base for `omp begin/end declare variant`

mikerice added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5512 + + if (!BaseFD) { +// TODO: Determine if we can reuse the declarator to create a declaration I think if you do the base lookup in

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

sconstab added inline comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:307 +public: + using NodeRef = size_type; + Just noticed that `ImmutableGraphBuilder` and `ImmutableGraph` have non-identical types called `NodeRef`. Suggest renaming this one to

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

sconstab added a comment. Overall, the restyling by @craig.topper looks much better than what I had committed before. I agree that `std::unique_ptr` is the right "container" in this circumstance. And the addition of `ArrayRef<>` accessors is also a nice touch. A few extra inline comments.

[PATCH] D77474: [analyzer][MallocChecker] Make NewDeleteLeaks depend on DynamicMemoryModeling rather than NewDelete

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, martong, balazske, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin,

[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments

kiszk updated this revision to Diff 255071. kiszk added a comment. address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77458/new/ https://reviews.llvm.org/D77458 Files:

[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments

kiszk added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/fuchsia-multiple-inheritance.cpp:48 // Inherits from multiple concrete classes. -// CHECK-MESSAGES: [[@LINE+2]]:1: warning: inheriting mulitple classes that aren't pure virtual is discouraged

[PATCH] D77471: address review comment

kiszk added a comment. Sorry, I made a mistake. This should not be reviewed. This should be deleted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77471/new/ https://reviews.llvm.org/D77471 ___

[PATCH] D77471: address review comment

kiszk created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. kiszk added a comment. kiszk removed a project: clang. kiszk removed a subscriber: cfe-commits. Herald added a project: clang. Sorry, I made a mistake. This should not be reviewed. This should be

[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! Comment at: clang-tools-extra/test/clang-tidy/checkers/fuchsia-multiple-inheritance.cpp:48 // Inherits from multiple concrete classes. -// CHECK-MESSAGES:

[PATCH] D77470: [clang] NFC: Fix trivial typo in comments and document

kiszk created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `the the` -> `the` Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77470 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/AST/ASTStructuralEquivalence.h

[PATCH] D77468: [clang] fix undefined behaviour in RawComment::getFormattedText()

obruns created this revision. obruns added reviewers: teemperor, ioeric, cfe-commits. Herald added subscribers: usaxena95, kadircet, ilya-biryukov. Herald added a project: clang. Calling `back()` and `pop_back()` on the empty string is undefined behavior [1,2]. The issue manifested itself as an

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

mikerice added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1693 +ExprResult TemplateInstantiator::TransformCallExpr(CallExpr *E) { + ExprResult R = TreeTransform::TransformCallExpr(E); + if (!SemaRef.getLangOpts().OpenMP || !R.isUsable() ||

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

thakis added a comment. > Can you describe your symlink setup in enough detail that I can recreate it > locally please? I've landed a workaround that should make things go for you again in 7db64e202f9 . I'd still be curious

[PATCH] D75364: [clang-format] Handle macros in function params and return value

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:313 +// for example: +// void f(volatile ElfW(Addr)* addr = nullptr); +if (HasStarToken) { I assume it could be almost anything? void f(volatile

[clang] ceed44a - [OpenMP][NFC] Remove unnecessary argument

Author: Johannes Doerfert Date: 2020-04-04T11:34:58-05:00 New Revision: ceed44adfd1ae9d714eaa4f0e7fa5a1a149b4dc5 URL: https://github.com/llvm/llvm-project/commit/ceed44adfd1ae9d714eaa4f0e7fa5a1a149b4dc5 DIFF:

[PATCH] D75788: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants

jdoerfert updated this revision to Diff 255050. jdoerfert added a comment. Cleanup and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75788/new/ https://reviews.llvm.org/D75788 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

sconstab added inline comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:285 + std::unique_ptr Edges; + size_type EdgesSize; +}; @craig.topper It now occurs to me that these fields should probably be reordered to: ``` std::unique_ptr Nodes;

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f9e1e3ae750: [clang-tidy]: fix false positive of cert-oop54-cpp check. (authored by ztamas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76990/new/

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

sconstab added inline comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:318 +} +auto *VertexArray = new Node[VertexSize + 1 /* terminator node */]; +auto *EdgeArray = new Edge[EdgeSize]; mattdr wrote: > sconstab wrote: > > mattdr wrote: > >

[PATCH] D77290: [OpenMP] Specialize OpenMP calls after template instantiation

jdoerfert updated this revision to Diff 255043. jdoerfert edited the summary of this revision. jdoerfert added a comment. Rebase on D77252 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77290/new/

[PATCH] D71739: [WIP] Use operand bundles to encode alignment assumptions

jdoerfert added a comment. @lebedev.ri We'd need to identify other uses of the alignment encoding in-tree so we can replace them as well. Also, this patch uses not only the alignment but also the offset in the operand bundle. We can either allow that or encode the offset via a gep in the IR.

[clang-tools-extra] 0f9e1e3 - [clang-tidy]: fix false positive of cert-oop54-cpp check.

Author: Tamás Zolnai Date: 2020-04-04T17:19:17+02:00 New Revision: 0f9e1e3ae750df483b7fff905a8bc89262e3179e URL: https://github.com/llvm/llvm-project/commit/0f9e1e3ae750df483b7fff905a8bc89262e3179e DIFF: https://github.com/llvm/llvm-project/commit/0f9e1e3ae750df483b7fff905a8bc89262e3179e.diff

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

f00kat updated this revision to Diff 255039. f00kat added a comment. 1. Maybe build fix 2. Added tests for nested arrays of structures 3. Fixed bugs in implementation for ElementRegion cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76996/new/ https://reviews.llvm.org/D76996

[PATCH] D77113: [OpenMP][NFC] Move and simplify directive -> allowed clause mapping

jdoerfert updated this revision to Diff 255041. jdoerfert added a comment. Herald added subscribers: yaxunl, mgorny. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77113/new/ https://reviews.llvm.org/D77113 Files:

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

thakis added a comment. In D77184#1961220 , @rsmith wrote: > In D77184#1961214 , @rsmith wrote: > > > In D77184#1961208 , @rsmith wrote: > > > > > This has broken my ability

[PATCH] D76990: [clang-tidy]: fix false positive of cert-oop54-cpp check.

ztamas updated this revision to Diff 255038. ztamas added a comment. Add suggested test case and rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76990/new/ https://reviews.llvm.org/D76990 Files:

[PATCH] D77461: [clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

vingeldal created this revision. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. Herald added a project: clang. vingeldal added a comment. Herald added a subscriber: wuzish. After looking in to it I got less certain of where the error lies and eventually I got uncertain if

[PATCH] D77461: [clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

vingeldal added a comment. Herald added a subscriber: wuzish. After looking in to it I got less certain of where the error lies and eventually I got uncertain if this even is a false negative, so I started out with just posting a change where the unit test is updated to detect the issue. This

[PATCH] D71739: [WIP] Use operand bundles to encode alignment assumptions

lebedev.ri added a comment. What's the status here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71739/new/ https://reviews.llvm.org/D71739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

tuktuk updated this revision to Diff 255032. tuktuk added a comment. Thank you for your interest in this feature! It is unfortunate indeed that the patch was not merged when accepted, so here is an update that matches the current status of the code base. Dear reviewers, can you please make

Re: [clang] 4ede887 - PR45402: Make the restrictions on constant evaluation of memcmp and

Hi Richard, This breaks libcxx. Can we please revert this or is a quick fix to libcxx possible? FAIL: libc++ :: std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/compare.pass.cpp (58624 of 62672) TEST 'libc++ ::

[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments

kiszk added a comment. I used aspell for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77458/new/ https://reviews.llvm.org/D77458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

CarlosAlbertoEnciso added a comment. In D77184#1960473 , @thakis wrote: > I pushed Andrew's fix (thanks!) (with minor formatting tweaks) in > dbb0d8ecb3a024bd6817ebd8ad8c5c199a51d933 >

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper updated this revision to Diff 255028. craig.topper added a comment. -Add edge_begin()/edge_end()/edges() to Node class. Hides the N+1 trick used to find the end of a Node's edges. -Add nodes()/edges() and use range-based for loops. -Stop using things in the traits class since it

[PATCH] D76606: [clang-tidy] Change checks that take enum configurations to use a new access method.

njames93 updated this revision to Diff 255027. njames93 added a comment. Herald added subscribers: arphaman, kbarton, nemanjai. - Change checks that take enum configurations to use a new access method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 added a comment. I added support for bools. The previous integer parsing behaviour is still there, however now it also responds to `true` or `false`. This won't parse `True|TRUE|False|FALSE` etc as I wanted it to be in line with `.clang-format` configuration files for handling of bool.

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 updated this revision to Diff 255023. njames93 added a comment. - Extended support for boolean types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77085/new/ https://reviews.llvm.org/D77085 Files:

[PATCH] D77385: [clangd] Add index export to dexp

mnauw updated this revision to Diff 255019. mnauw retitled this revision from "[clangd] Add index inspection helper tool" to "[clangd] Add index export to dexp". mnauw edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77385/new/

[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments

sylvestre.ledru added a comment. Herald added a subscriber: wuzish. You used codespell for this? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77458/new/ https://reviews.llvm.org/D77458 ___

[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments

kiszk created this revision. Herald added subscribers: cfe-commits, phosek, usaxena95, kadircet, jfb, arphaman, jkorous, kbarton, nemanjai. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77458 Files:

[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

kadircet added a comment. > But I'm wondering how good an idea this is for plaintext: "Returns 'foo' on > failure" is better than "Returns foo on failure", right? (With backticks > instead of single quotes, phab is eating my formatting) ah sorry missed that one. That's actually a good point,

[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Regarding spaces between code and text chunks, are you suggesting we should print: Tests primality of`p` if so, i do believe having a space before the backtick vs not

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

mattdr added inline comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:318 +} +auto *VertexArray = new Node[VertexSize + 1 /* terminator node */]; +auto *EdgeArray = new Edge[EdgeSize]; sconstab wrote: > mattdr wrote: > > As a general rule

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

vitalybuka updated this revision to Diff 255016. vitalybuka added a comment. try arc diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77374/new/ https://reviews.llvm.org/D77374 Files: clang/lib/CodeGen/CGExpr.cpp

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:647-653 CmdLineOption ]>, Szelethus wrote: > Ah, okay, I see which one you refer to. We

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper updated this revision to Diff 255011. craig.topper added a comment. Use unique_ptr::operator[] in a few places. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75936/new/ https://reviews.llvm.org/D75936 Files: clang/include/clang/Driver/Options.td

[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

sammccall added a comment. Some saturday morning procrastination. But I'm wondering how good an idea this is for plaintext: "Returns 'foo' on failure" is better than "Returns foo on failure", right? (With backticks instead of single quotes, phab is eating my formatting) Maybe we should have an

[PATCH] D77456: [clangd] Parse `foo` in documentation comments and render as code.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sammccall added a comment. Some saturday morning procrastination. But I'm wondering how good an idea

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper updated this revision to Diff 255008. craig.topper added a comment. This revision is now accepted and ready to land. Use std::unique_ptr for arrays in the graph. I started trying to use std::vector, but it kept crashing. Which initially I thought was some issue with the fact that

[clang-tools-extra] ebd522a - [clangd] Tweak parseDocumentation loop to use raw lines. NFC

Author: Sam McCall Date: 2020-04-04T08:07:51+02:00 New Revision: ebd522aaa8aad74ea44db5bb4b74f1b784da9f99 URL: https://github.com/llvm/llvm-project/commit/ebd522aaa8aad74ea44db5bb4b74f1b784da9f99 DIFF: https://github.com/llvm/llvm-project/commit/ebd522aaa8aad74ea44db5bb4b74f1b784da9f99.diff