[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

dexonsmith added a comment. In D77621#2000237 , @nikic wrote: > Okay, I'm basically fine with that, if it is our stance that SmallVector > should always be preferred over std::vector. Not really related to this > revision, but it would probably help to

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

Quuxplusone added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2804 +return; + } + Asking silly questions because I don't stand a chance of understanding either the code or the tests... In the x86-64 ABI, an ordinary 16-byte `struct`

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

yaxunl updated this revision to Diff 259796. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by John's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77954/new/ https://reviews.llvm.org/D77954 Files: clang/lib/Sema/SemaOverload.cpp

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane created this revision. erichkeane added a reviewer: craig.topper. After speaking with Craig Topper about some recent defects, he pointed out that _ExtInts should be passed indirectly if larger than the largest int register, and like ints when smaller than that. This patch implements

[PATCH] D78733: [OPENMP]Use new interface for task reduction.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. One nit below. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:170 ArrayRef ReductionOps); - /// Emits lvalue for a reduction item. + ///

[PATCH] D78655: [HIP] Let lambda be host device by default

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:723 +Method->addAttr(CUDADeviceAttr::CreateImplicit(Context)); +Method->addAttr(CUDAHostAttr::CreateImplicit(Context)); +return; pfultz2

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

sameerds accepted this revision. sameerds added a comment. This revision is now accepted and ready to land. Thanks @saiislam ... this looks much better! Two nitpicks, that must be fixed. But it is okay if you directly submit after fixing them. 1. The change description should use "const char

[PATCH] D78694: [clang-format] Fix lambda with ellipsis in return type

johnchen902 updated this revision to Diff 259792. johnchen902 added a comment. Rebased to HEAD. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78694/new/ https://reviews.llvm.org/D78694 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D78190: Add Bfloat IR type

rjmccall added a comment. Thanks for doing it this way, I think this is going to be much better long-term for LLVM. Comment at: llvm/docs/LangRef.rst:2896 + * - ``bfloat`` + - 16-bit brain floating-point value (8-bit mantissa) + scanon wrote: > bfloat

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9749 + if (isBetterMultiversionCandidate(Cand1, Cand2)) +return true; + tra wrote: > rjmccall wrote: > > erichkeane wrote: > > > yaxunl wrote: > > > > echristo wrote: > > > > >

[PATCH] D78694: [clang-format] Fix lambda with ellipsis in return type

johnchen902 updated this revision to Diff 259789. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78694/new/ https://reviews.llvm.org/D78694 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Index: clang/unittests/Format/FormatTest.cpp

[PATCH] D78784: [clangd] Add some logging to explain why textual fallback navigation failed

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. nridge added a comment. Applies on top of D76451 . Depends on

[PATCH] D78784: [clangd] Add some logging to explain why textual fallback navigation failed

nridge added a comment. Applies on top of D76451 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78784/new/ https://reviews.llvm.org/D78784 ___ cfe-commits mailing

[PATCH] D78655: [HIP] Let lambda be host device by default

pfultz2 added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:723 +Method->addAttr(CUDADeviceAttr::CreateImplicit(Context)); +Method->addAttr(CUDAHostAttr::CreateImplicit(Context)); +return; Shouldn't we add these attributes if there are no

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

This revision was automatically updated to reflect the committed changes. Closed by commit rG14aaf4457c64: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2c3ee88 - [Sema][test] Fix implicit-int-float-conversion.c on Windows

Author: Fangrui Song Date: 2020-04-23T18:52:04-07:00 New Revision: 2c3ee8812c14ab13203de22e0d0ece90f4a8291e URL: https://github.com/llvm/llvm-project/commit/2c3ee8812c14ab13203de22e0d0ece90f4a8291e DIFF: https://github.com/llvm/llvm-project/commit/2c3ee8812c14ab13203de22e0d0ece90f4a8291e.diff

[clang] 14aaf44 - [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

Author: Fangrui Song Date: 2020-04-23T18:26:06-07:00 New Revision: 14aaf4457c641bd5130072ba2a035e254b92fad3 URL: https://github.com/llvm/llvm-project/commit/14aaf4457c641bd5130072ba2a035e254b92fad3 DIFF: https://github.com/llvm/llvm-project/commit/14aaf4457c641bd5130072ba2a035e254b92fad3.diff

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

MaskRay added a comment. In D73845#2000455 , @sthibaul wrote: > Thanks! I don't have commit access, could somebody commit this for me? Can you provide your `name `? I need this information to run `git c --amend --author=` CHANGES SINCE LAST ACTION

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaOverload.cpp:9749 + if (isBetterMultiversionCandidate(Cand1, Cand2)) +return true; + rjmccall wrote: > erichkeane wrote: >

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Index.cpp:27 +llvm::StringRef SpanName, SymbolIndex::Stub *Stub, ClangdRequestT Request, +std::function>( +SymbolIndex::Stub *, grpc::ClientContext *, const RPCRequestT &)>

[PATCH] D78777: [AST] Use PrintingPolicy for format string diagnosis

jrtc27 created this revision. jrtc27 added reviewers: rsmith, Anastasia. Herald added subscribers: cfe-commits, arichardson. Herald added a project: clang. This is a small improvement for OpenCL diagnostics, but is also useful for our CHERI fork, as our __capability qualifier is suppressed from

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259762. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve couple more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 Files:

[PATCH] D78190: Add Bfloat IR type

arsenm added a comment. What's the plan for handling this in LLT where we don't have specific types with the same size? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190

[PATCH] D76452: Use LLD by default for Android.

nickdesaulniers added a comment. Can we use `-DCLANG_DEFAULT_LINKER=lld` to configure AOSP's distribution of LLD, then require the use of `-fuse-ld=` when targeting OSX host tools? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76452/new/

[PATCH] D78190: Add Bfloat IR type

jfb added a comment. Thanks for adding the IR type. At a high-level this looks good to me, but I haven't done an in-depth review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9749 + if (isBetterMultiversionCandidate(Cand1, Cand2)) +return true; + erichkeane wrote: > yaxunl wrote: > > echristo wrote: > > > rjmccall wrote: > > > > yaxunl wrote: > > > > >

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

saugustine added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1215 +else + CmdArgs.push_back("-l:libunwind.so"); break; itollefsen wrote: > If you are building with `-DLIBUNWIND_ENABLE_SHARED:OFF >

[clang] bd6942e - Re-land "[MS] Fix assert handling enum forward decls in hasVisibleDefinition"

Author: Reid Kleckner Date: 2020-04-23T16:22:01-07:00 New Revision: bd6942eb215ec1ddf8dc2335dfe9df06a5ba1581 URL: https://github.com/llvm/llvm-project/commit/bd6942eb215ec1ddf8dc2335dfe9df06a5ba1581 DIFF: https://github.com/llvm/llvm-project/commit/bd6942eb215ec1ddf8dc2335dfe9df06a5ba1581.diff

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk updated this revision to Diff 259751. rnk added a comment. - Lots of documentation words Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65543/new/ https://reviews.llvm.org/D65543 Files: clang/docs/ReleaseNotes.rst

[PATCH] D78190: Add Bfloat IR type

scanon requested changes to this revision. scanon added inline comments. This revision now requires changes to proceed. Comment at: llvm/docs/LangRef.rst:3240 +double are represented using the 16-digit form shown above (which matches the +IEEE754 representation for double); half

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

itollefsen added a comment. This fails to account for whether you actually //have// the shared and/or static version of the library. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1215 +else + CmdArgs.push_back("-l:libunwind.so"); break;

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv marked an inline comment as done. ilinpv added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8058 + def : Pat<(v8f16 (OpNode (v8f16 V128:$Rd), (v8f16 V128:$Rn), + (AArch64duplane16 (v8f16 V128:$Rm), +

[PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

This revision was automatically updated to reflect the committed changes. Closed by commit rGdef7c7f60205: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...) (authored by shafik). Herald added projects: clang, LLDB. Changed prior to commit:

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

ahatanak created this revision. ahatanak added reviewers: arphaman, erik.pilkington, rjmccall. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. This improves upon https://reviews.llvm.org/D21099, which taught -Wcast-align to look at the aligned attribute

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 added a comment. Fix a format issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 259737. wxz2020 added a comment. fix a format issus. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp llvm/include/llvm/Support/AArch64TargetParser.def

[clang] def7c7f - [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

Author: shafik Date: 2020-04-23T15:18:48-07:00 New Revision: def7c7f6020530ef2deb64f786d28775b5d0e47f URL: https://github.com/llvm/llvm-project/commit/def7c7f6020530ef2deb64f786d28775b5d0e47f DIFF: https://github.com/llvm/llvm-project/commit/def7c7f6020530ef2deb64f786d28775b5d0e47f.diff LOG:

[PATCH] D76458: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [by modifying X86RetpolineThunks.cpp]

sconstab abandoned this revision. sconstab added a comment. Superseded by D76810 , D76811 , and D76812 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76458/new/

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul added a comment. Thanks! I don't have commit access, could somebody commit this for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___ cfe-commits mailing list

[PATCH] D78693: Make "#pragma clang attribute" support uninitialized attribute.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcbc613ad8b7: Make #pragma clang attribute support uninitialized attribute. (authored by jcai19). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78693/new/

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. I think this should not be blocked on the gtest update. If getting an updated gtest into the repo takes to much time and the reviewers are happy, I'm fine with doing that change as a

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

xazax.hun added inline comments. Comment at: clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:24 + do \ +if (!LLVM_WITH_Z3)

[PATCH] D78192: Support compiler extensions as a normal component

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM. As with every change to the build system, please look out broken configurations after committing. You will have noticed already that there is a lot of variety in how others

[PATCH] D78760: Check a class has a definition before iterating over its base classes

ahatanak added a comment. I'm not sure why this shouldn't be caught in `Sema::CheckBaseSpecifier`. But there is a check for the definition of the class before `findCircularInheritance` is called, so I'm guessing there is a reason the code shouldn't be rejected here. Repository: rG LLVM

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

xazax.hun accepted this revision. xazax.hun added a comment. Overall looks good for me, thanks for tackling this problem! I think this should be good to go once Eli's comment is fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77809/new/

[PATCH] D78457: [analyzer][Z3-refutation] Fix refutation BugReporterVisitor bug and refactor

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78457/new/ https://reviews.llvm.org/D78457

[PATCH] D78760: Check a class has a definition before iterating over its base classes

ahatanak created this revision. ahatanak added a reviewer: rsmith. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. ahatanak added a comment. I'm not sure why this shouldn't be caught in `Sema::CheckBaseSpecifier`. But there is a check for the definition

[clang] fcbc613 - Make "#pragma clang attribute" support uninitialized attribute.

Author: Jian Cai Date: 2020-04-23T14:25:13-07:00 New Revision: fcbc613ad8b7785f710996f58726f26ad4ace50b URL: https://github.com/llvm/llvm-project/commit/fcbc613ad8b7785f710996f58726f26ad4ace50b DIFF: https://github.com/llvm/llvm-project/commit/fcbc613ad8b7785f710996f58726f26ad4ace50b.diff

[PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

shafik updated this revision to Diff 259703. shafik marked 2 inline comments as done. shafik added a comment. Capitalization fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78000/new/ https://reviews.llvm.org/D78000 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:18 #include "index/dex/Dex.h" +#include "index/remote/Client.h" #include "llvm/ADT/ScopeExit.h" sammccall wrote: > Being able to include this header but not call the

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259701. kbobyrev marked 13 inline comments as done. kbobyrev added a comment. Resolve comments that refer to the outdated patch and address few small issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78674: [SveEmitter] Add builtins for contiguous prefetches

efriedma accepted this revision. efriedma added a comment. LGTM Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/negative/acle_sve_prfb.c:22 + // expected-error@+1 {{argument value -1 is outside the valid range [0, 13]}} + return svprfb(pg, base, -1); +}

[PATCH] D78756: [SveEmitter] Add builtins for svreinterpret

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma, ctetreau. Herald added subscribers: kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. The reinterpret builtins are generated separately because they need the cross product

[PATCH] D78751: [SveEmitter] Add builtins for scatter stores

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78751/new/ https://reviews.llvm.org/D78751

[PATCH] D78755: [SveEmitter] Add builtins for svlen

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma. Herald added a subscriber: tschuett. Herald added a project: clang. The svlen builtins return the number of elements in a vector and are implemented using `llvm.vscale`. Repository: rG LLVM Github Monorepo

[PATCH] D78748: [SveEmitter] Add builtins for svld1rq

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78748/new/ https://reviews.llvm.org/D78748

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

nikic added a comment. In D77621#157 , @dblaikie wrote: > @nikic any sense of the noise floor/level on these measurements? It doesn't > /look/ like there's much left in this that would cause problems. & I assume > these measurements were made on an

[PATCH] D78521: [clangd] Extend dexp to support remote index

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Features.inc.in:2 #define CLANGD_BUILD_XPC @CLANGD_BUILD_XPC@ +#define CLANGD_REMOTE @CLANGD_ENABLE_REMOTE@ nit: can we use the same name for the cmake variable and the preprocessor define?

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

dschuff added a comment. We can definitely still talk about what you are trying to do, and it would probably be useful to have more folks involved. Opening an issue on https://github.com/WebAssembly/tool-conventions/ might be useful since it involves the conventions that LLVM and clang use. If

[PATCH] D78747: [SveEmitter] Add builtins for compares and ReverseCompare flag.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM with one minor comment Comment at: clang/include/clang/Basic/arm_sve.td:74 // +// w: vector of element type promoted to 64bits +// j: element type promoted to

[PATCH] D78747: [SveEmitter] Add builtins for compares and ReverseCompare flag.

efriedma added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:74 // +// w: vector of element type promoted to 64bits +// j: element type promoted to 64bits (splat to vector type) Isn't "w" the same as the existing "g"? Or is there some

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv added a comment. @erik.pilkington How about just adding numeric hash of block parameters for now ? This way we don't have to change the mangling / demangling scheme at all. The mangling / demangling changes bring me into parts of LLVM that I'm not familiar with. (PS - I still have to

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

efriedma added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2928 + // FIXME: This does not find the VLA if it is embedded in other types, + // like here: `void (*vla)(int[x]);` for (const VariableArrayType* VA = FindVA(VD->getType().getTypePtr());

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv updated this revision to Diff 259684. alexbdv marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 Files: clang/lib/AST/Mangle.cpp Index: clang/lib/AST/Mangle.cpp

[PATCH] D78751: [SveEmitter] Add builtins for scatter stores

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma, andwar. Herald added a subscriber: tschuett. Herald added a project: clang. D77735 only added scatters for the non-temporal variants. Repository: rG LLVM Github Monorepo

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma, ctetreau. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen added a parent revision: D78748: [SveEmitter] Add builtins for svld1rq. - svdupq builtins that duplicate scalars to every

[PATCH] D78748: [SveEmitter] Add builtins for svld1rq

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma, ctetreau. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen added a child revision: D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane. Repository: rG LLVM Github Monorepo

[PATCH] D78569: [SVE][CodeGen] Lower SDIV & UDIV to SVE intrinsics

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:11388 return LowerSVEIntrinsicEXT(N, DAG); +case Intrinsic::aarch64_sve_sdiv: +return

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9749 + if (isBetterMultiversionCandidate(Cand1, Cand2)) +return true; + yaxunl wrote: > echristo wrote: > > rjmccall wrote: > > > yaxunl wrote: > > > > rjmccall wrote: > > > > >

[PATCH] D78457: [analyzer][Z3-refutation] Fix refutation BugReporterVisitor bug and refactor

steakhal updated this revision to Diff 259674. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78457/new/ https://reviews.llvm.org/D78457 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h

[PATCH] D78457: [analyzer][Z3-refutation] Fix refutation BugReporterVisitor bug and refactor

steakhal marked 7 inline comments as done. steakhal added a comment. I'm really embarrassed that I uploaded the wrong diff. I appologize. Most of the comments are done :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78457/new/

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

steakhal marked 4 inline comments as done. steakhal added a comment. I addressed most of the comments. Comment at: clang/unittests/StaticAnalyzer/CheckerRegistration.h:81 +template +bool runCheckerOnCodeWithArgs(const std::string , std::string , +

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9749 + if (isBetterMultiversionCandidate(Cand1, Cand2)) +return true; + echristo wrote: > rjmccall wrote: > > yaxunl wrote: > > > rjmccall

[PATCH] D78704: [analyzer][NFC] Add unittest for FalsePositiveRefutationBRVisitor

steakhal updated this revision to Diff 259668. steakhal marked 6 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78704/new/ https://reviews.llvm.org/D78704 Files: clang/unittests/StaticAnalyzer/CMakeLists.txt

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

f00kat updated this revision to Diff 259667. f00kat added a comment. 1. Build fix CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76996/new/ https://reviews.llvm.org/D76996 Files: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp clang/test/Analysis/placement-new.cpp Index:

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

dblaikie added a comment. In D77621#1999757 , @browneee wrote: > I resubmitted the report_fatal_error checks again under D77601 > > >

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

bernhard added a comment. > Would it work to increase the memory size, and then put your data in the new > space this creates at the end of memory? > `__data_end` and `__heap_base` aren't things you can move around once the > linker has defined them. Their values can be baked in elsewhere in

[PATCH] D78743: [clangd] Preserve line information while build PreamblePatch

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D78740 . Repository: rG LLVM Github Monorepo

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

phosek accepted this revision. phosek added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

khuttun added a comment. I ran the check for LLVM code using configuration `key: bugprone-map-subscript-operator-lookup.MapTypes, value: "::std::map;::std::unordered_map;::llvm::DenseMapBase;::llvm::MapVector;::llvm::StringMap"`. It gave 1212 warnings (see the attachment).F11784386:

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This will enable extraction of correct line locations in preamble patch for includes. Repository:

[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

khuttun updated this revision to Diff 259656. khuttun added a comment. The patch is now updated to be based on the monorepo. I also fixed all the comments from the previous review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46317/new/ https://reviews.llvm.org/D46317 Files:

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

tambre updated this revision to Diff 259653. tambre marked 4 inline comments as done. tambre added a comment. Remove SVE, add another check to parser test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77940/new/ https://reviews.llvm.org/D77940

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

tambre added a comment. In D77940#1998856 , @sdesmalen wrote: > It seems a NVIDIA Developer Program Membership is needed in order to download > the TRM. I'm not sure if that is just a matter of creating an account, but > without it I can't really verify

[PATCH] D78693: Make "#pragma clang attribute" support uninitialized attribute.

jcai19 updated this revision to Diff 259652. jcai19 added a comment. Update test cases and documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78693/new/ https://reviews.llvm.org/D78693 Files: clang/docs/LanguageExtensions.rst

[PATCH] D78693: Make "#pragma clang attribute" support uninitialized attribute.

jcai19 added a comment. Thank you all for the comments. I just realized I forgot to update clang documentation. Added that too. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78693/new/ https://reviews.llvm.org/D78693

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam marked an inline comment as done. cristian.adam added a comment. Since I do not have commit rights, I require help to get this merged. Comment at: clang/tools/libclang/CMakeLists.txt:88 +if (WIN32 AND ENABLE_SHARED AND ENABLE_STATIC) + unset(ENABLE_STATIC)

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259644. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve the last comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 Files:

[PATCH] D78289: [analyzer] Stability improvements for IteratorModeling functions

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. This revision is now accepted and ready to land. Thanks for fixing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78289/new/ https://reviews.llvm.org/D78289

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

rnk added a comment. Thanks David, I'm comfortable with that stance for DWARF. I know @amccarth is looking into the recent VS visualizer issue, and I would like him to confirm if it was this change or not when he gets a chance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75068: libclang: Add static build support for Windows

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, assuming my understanding is correct. Comment at: clang/tools/libclang/CMakeLists.txt:88 +if (WIN32 AND ENABLE_SHARED AND ENABLE_STATIC) + unset(ENABLE_STATIC)

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

f00kat updated this revision to Diff 259636. f00kat marked 4 inline comments as done. f00kat added a comment. 1. Refactoring 2. Build fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76996/new/ https://reviews.llvm.org/D76996 Files:

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

browneee added a comment. I resubmitted the report_fatal_error checks again under D77601 http://llvm-compile-time-tracker.com/compare.php?from=7375212172951d2fc283c81d03c1a8588c3280c6=a30e7ea88e75568feed020aedae73c52de35=max-rss

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

echristo added a subscriber: erichkeane. echristo added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9749 + if (isBetterMultiversionCandidate(Cand1, Cand2)) +return true; + rjmccall wrote: > yaxunl wrote: > > rjmccall wrote: > > > If we move

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish added a comment. In D70500#1999268 , @bernhard wrote: > > It's for users who want smaller wasm binaries. It's not currently > > documented, though yes, it would be nice to document it. > > But how would a user even end up with wasm-opt in the

[PATCH] D78726: [CUDA] Define __CUDACC_DEBUG__ when compiling device code in debug mode

tambre abandoned this revision. tambre marked an inline comment as done. tambre added a comment. Abandoning as there are good reasons to not add this. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:632 + if (mustEmitDebugInfo(DriverArgs) == EmitSameDebugInfoAsHost) +

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:486-501 + Options.BBSections = + llvm::StringSwitch(CodeGenOpts.BBSections) + .Case("all", llvm::BasicBlockSection::All) + .Case("labels", llvm::BasicBlockSection::Labels) +

[PATCH] D78572: [Clang][Sema] Capturing section type conflicts on #pragma clang section

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Seems reasonable. Comment at: clang/test/Sema/pragma-clang-section.c:2 // RUN: %clang_cc1 -fsyntax-only -verify %s -triple arm-none-eabi -#pragma clang section bss="mybss.1"

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram updated this revision to Diff 259626. tmsriram marked 5 inline comments as done. tmsriram added a comment. Herald added subscribers: dexonsmith, steven_wu, hiraditya, arichardson, emaste. Herald added a reviewer: espindola. Document the flags, rename the options. CHANGES SINCE LAST

[PATCH] D78163: [AVR][NFC] Move preprocessor tests to Preprocessor directory

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78163/new/ https://reviews.llvm.org/D78163

  1   2   3   >