[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > but the operator declared at global scope returns void. void -> void pointer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80966/new/

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale updated this revision to Diff 268667. michele.scandale added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D81131: [DebugInfo] Fix assertion for extern void type

yonghong-song added a comment. Thanks, @dblaikie >> I think if we're going to support "const void" we should support "void" too >> & fix the verifier to allow this & make sure LLVM produces the correct debug >> info for it (which is probably a DW_TAG_variable without a DW_AT_type >> attribute

[PATCH] D81222: [WebAssembly] Implement prototype SIMD rounding instructions

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. As specified in https://github.com/WebAssembly/simd/pull/232. These instructions are

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser updated this revision to Diff 268649. junparser added a comment. address the comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80979/new/ https://reviews.llvm.org/D80979 Files: clang/docs/LanguageExtensions.rst clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1818-1819 +llvm::APFloat Probability = Eval.Val.getFloat(); +if (!(Probability >= llvm::APFloat(0.0) && + Probability <= llvm::APFloat(1.0))) { + Diag(ProbArg->getLocStart(),

[PATCH] D81188: [RISCV] Support experimental v extensions.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81188/new/ https://reviews.llvm.org/D81188

[PATCH] D81213: [RISCV] Support experimental v extension v0.9.

HsiangKai created this revision. HsiangKai added reviewers: evandro, rogfer01, rkruppe. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, MaskRay,

[PATCH] D78900: [HIP][AMDGPU] Enable structurizer workarounds

sameerds abandoned this revision. sameerds added a comment. Abandoned in favour of enabling the workarounds in the AMDGPU backend: https://reviews.llvm.org/D81211 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78900/new/

[PATCH] D81188: [RISCV] Support experimental v extensions.

HsiangKai updated this revision to Diff 268642. HsiangKai added a comment. Address @MaskRay's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81188/new/ https://reviews.llvm.org/D81188 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp

[clang] e5158b5 - [Driver] Migrate some -f/-fno options to use OptInFFlag and OptOutFFlag

Author: Fangrui Song Date: 2020-06-04T19:33:14-07:00 New Revision: e5158b52730d323bb8cd2cba6dc6c89b90cba452 URL: https://github.com/llvm/llvm-project/commit/e5158b52730d323bb8cd2cba6dc6c89b90cba452 DIFF: https://github.com/llvm/llvm-project/commit/e5158b52730d323bb8cd2cba6dc6c89b90cba452.diff

[clang] c57f8a3 - PR46209: properly determine whether a copy assignment operator is

Author: Richard Smith Date: 2020-06-04T19:19:01-07:00 New Revision: c57f8a3a20540fcf9fbf98c0a73f381ec32fce2a URL: https://github.com/llvm/llvm-project/commit/c57f8a3a20540fcf9fbf98c0a73f381ec32fce2a DIFF: https://github.com/llvm/llvm-project/commit/c57f8a3a20540fcf9fbf98c0a73f381ec32fce2a.diff

[clang] c13dd74 - Set the captures on a CXXRecordDecl representing a lambda closure type

Author: Richard Smith Date: 2020-06-04T19:19:01-07:00 New Revision: c13dd74e311d2ac70dd3ea663d800307d1aa5b6b URL: https://github.com/llvm/llvm-project/commit/c13dd74e311d2ac70dd3ea663d800307d1aa5b6b DIFF: https://github.com/llvm/llvm-project/commit/c13dd74e311d2ac70dd3ea663d800307d1aa5b6b.diff

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

HsiangKai marked an inline comment as done. HsiangKai added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrFormats.td:56 +def NoConstraint : RISCVVConstraint<0>; +def WidenV : RISCVVConstraint<1>; +def WidenW : RISCVVConstraint<2>;

[PATCH] D80979: [clang] Implement VectorType logic not operator.

junparser marked 2 inline comments as done. junparser added inline comments. Comment at: clang/test/CodeGen/vector-1.cpp:2 +// RUN: %clang_cc1 -emit-llvm %s -o - | FileCheck %s + +typedef __attribute__((__vector_size__(16))) float float4; erichkeane wrote: > I

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

rsmith added a comment. In D79378#2058753 , @dnsampaio wrote: > Hi @rsmith, > are you still looking into this? > cheers Sorry for the delay, I'll be getting back to this soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80996: [AMDGPU][OpenMP] Fix duplicate copies of arguments in commands

pdhaliwal abandoned this revision. pdhaliwal marked an inline comment as done. pdhaliwal added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:389 - for (Arg *A : Args) { -DAL->append(A); + if (DeviceOffloadKind != Action::OFK_OpenMP) { +for (Arg *A

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

ABataev abandoned this revision. ABataev added a comment. In D81192#2074878 , @jdoerfert wrote: > In D81192#2074762 , @ABataev wrote: > > > In D81192#2074732 , @jdoerfert >

[PATCH] D81203: clang-cl: accept -f[no-]data-sections and -f[no-]function-sections

thakis requested changes to this revision. thakis added a comment. This revision now requires changes to proceed. In other words: The point of clang-cl is to use cl.exe flag spellings where they exist. So unless there's some good reason for adding this, I don't think we should add it.

[PATCH] D81203: clang-cl: accept -f[no-]data-sections and -f[no-]function-sections

thakis added a comment. The clang-cl spelling of this is /Gy and /Gw. If you want to use the gcc spelling, you can do that through the /clang: flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81203/new/ https://reviews.llvm.org/D81203

[PATCH] D79830: Add support of __builtin_expect_with_probability

davidxl added a comment. Can you add some tests at the LLVM side? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L updated this revision to Diff 268624. Xiangling_L marked 11 inline comments as done. Xiangling_L added a comment. Add `PreferredAlignment` and `PreferredNVAlignment` field; Adjust `-fdump-record-layouts` format for AIX; Update the testcase formatting; Repository: rG LLVM Github

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2506 if (!Target->allowsLargerPreferedTypeAlignment()) return ABIAlign; jyknight wrote: > I think from here on down is currently X86-specific, even though it's not > phrased

[PATCH] D62922: [WebAssembly] Implement "Reactor" mode

sunfish marked an inline comment as done. sunfish added inline comments. Comment at: clang/test/Driver/wasm-toolchain.c:116 +// CHECK-COMMAND: clang{{.*}}" "-cc1" {{.*}} "-o" "[[temp:[^"]*]]" +// CHECK-COMMAND: wasm-ld{{.*}}" "crt1.o" "[[temp]]" "-lc"

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij updated this revision to Diff 268614. stuij marked an inline comment as done. stuij added a comment. Resolved merge conflicts with head. Fixed minor oversight. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/

[PATCH] D81203: clang-cl: accept -f[no-]data-sections and -f[no-]function-sections

inglorion created this revision. inglorion added reviewers: hans, thakis. Herald added a project: clang. This adds -fdata-sections, -ffunction-sections, and their negations to the list of -f options accepted by clang-cl. As a result, these options can be used with the same spelling for both clang

[PATCH] D81045: [MLIR] Modify HasParent trait to allow one of several op's as a parent

jurahul updated this revision to Diff 268618. jurahul added a comment. Herald added subscribers: cfe-commits, msifontes. Herald added a project: clang. Fix Clang build failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij updated this revision to Diff 268616. stuij marked 7 inline comments as done. stuij added a comment. addressed remaining nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm.org/D79708 Files:

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij marked 2 inline comments as done. stuij added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:6989 + false, + getTarget().hasBFloat16Type()); llvm::Type *Ty = VTy;

[PATCH] D80961: WIP: Ignore template instantiations if not in AsIs mode

steveire added a comment. In D80961#2074915 , @steveire wrote: > Hmm, `IgnoreUnlessSpelledInSource` is designed and named to fill that role. In other words: to me this change is a bug fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 072192d - [WebAssembly] Fix a testcase to be independent of the sysroot default

Author: Dan Gohman Date: 2020-06-04T16:04:44-07:00 New Revision: 072192d54aa0a5c4bb694be8280dd4fef495b582 URL: https://github.com/llvm/llvm-project/commit/072192d54aa0a5c4bb694be8280dd4fef495b582 DIFF: https://github.com/llvm/llvm-project/commit/072192d54aa0a5c4bb694be8280dd4fef495b582.diff

[PATCH] D80961: WIP: Ignore template instantiations if not in AsIs mode

steveire added a comment. In D80961#2073049 , @klimek wrote: > Without jumping into the discussion whether it should be the default, I think > we should be able to control template instantiation visitation separately > from other implicit nodes. Hmm,

[PATCH] D80849: [apple clang] disable in-process CC1 to preserve crashlog compatibility

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, but next we should get the crash reproductions working with in-process `-cc1`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a95c08d - [Analyzer][NoUncountedMembersChecker] Fix crash for C structs

Author: Jan Korous Date: 2020-06-04T15:57:19-07:00 New Revision: a95c08db122ef33576cd8f35094afcd1ea668d68 URL: https://github.com/llvm/llvm-project/commit/a95c08db122ef33576cd8f35094afcd1ea668d68 DIFF: https://github.com/llvm/llvm-project/commit/a95c08db122ef33576cd8f35094afcd1ea668d68.diff

[clang] b16ed49 - [Fuchsia] Rely on linker switch rather than dead code ref for profile runtime

Author: Petr Hosek Date: 2020-06-04T15:47:05-07:00 New Revision: b16ed493ddc22a100341b1e7d9b11282a8994e96 URL: https://github.com/llvm/llvm-project/commit/b16ed493ddc22a100341b1e7d9b11282a8994e96 DIFF: https://github.com/llvm/llvm-project/commit/b16ed493ddc22a100341b1e7d9b11282a8994e96.diff

[clang] e1ab900 - Revert "[Fuchsia] Rely on linker switch rather than dead code ref for profile runtime"

Author: Petr Hosek Date: 2020-06-04T15:44:10-07:00 New Revision: e1ab90001a0bac1d1bebe4116ce0e89567138283 URL: https://github.com/llvm/llvm-project/commit/e1ab90001a0bac1d1bebe4116ce0e89567138283 DIFF: https://github.com/llvm/llvm-project/commit/e1ab90001a0bac1d1bebe4116ce0e89567138283.diff

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

evandro added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrFormats.td:56 +def NoConstraint : RISCVVConstraint<0>; +def WidenV : RISCVVConstraint<1>; +def WidenW : RISCVVConstraint<2>; Methinks that these constraints `WidenV`,

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

stuij added a comment. In D80716#2073251 , @LukeGeeson wrote: > Besides from rebasing to get @pratlucas changes upstream. > > @stuij please could you confirm if you are happy with this, so I can merge Hi Luke, For the backend tests it would be good if

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

stuij added a comment. For the backend tests, I suggest using `-asm-verbose=0` with llc to only print instructions and get rid of `// kill: ..` and friends. Use `update_cc_test_checks.py` again to regenerate the testing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

jdoerfert added a comment. In D81192#2074762 , @ABataev wrote: > In D81192#2074732 , @jdoerfert wrote: > > > I doubt this is the right fix. I'll take a closer look. > > > I believe, the issue is caused by the new

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

njames93 added inline comments. Comment at: llvm/lib/Support/YAMLTraits.cpp:894 + std::string ) { + Val.clear(); + size_t CurrentPos = 0; If you want to do the same here... ``` SmallVector Lines;

[PATCH] D79830: Add support of __builtin_expect_with_probability

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10804-10807 + "probability of __builtin_expect_with_probability must be constant " + "floating-point expression">; +def err_probability_out_of_range : Error< + "probability of

[PATCH] D80932: [SYCL] Make default address space a superset of OpenCL address spaces.

Anastasia added a comment. In D80932#2073542 , @Naghasan wrote: > In D80932#2072064 , @Anastasia wrote: > > > In D80932#2071321 , @bader wrote: > > > > > In D80932#2068863

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

ABataev updated this revision to Diff 268592. ABataev added a comment. Rebase and fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81192/new/ https://reviews.llvm.org/D81192 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81115/new/ https://reviews.llvm.org/D81115

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

ABataev added a comment. In D81192#2074732 , @jdoerfert wrote: > I doubt this is the right fix. I'll take a closer look. I believe, the issue is caused by the new attributes for kmpc_critical/kmpc_end_critical functions. They are marked as

[clang] f9ea86e - [Docs] Add the entry for `Advanced builds` in UserGuide.rst

Author: Yuanfang Chen Date: 2020-06-04T14:52:51-07:00 New Revision: f9ea86eaa1a3ba18973666c4de56dfde8d488574 URL: https://github.com/llvm/llvm-project/commit/f9ea86eaa1a3ba18973666c4de56dfde8d488574 DIFF: https://github.com/llvm/llvm-project/commit/f9ea86eaa1a3ba18973666c4de56dfde8d488574.diff

[clang] 4e3d462 - Fix undefined behaviour when trying to deref nullptr.

Author: Alexey Bataev Date: 2020-06-04T17:52:06-04:00 New Revision: 4e3d4622b1e7bd419815510e5f7cd0f96595b2a3 URL: https://github.com/llvm/llvm-project/commit/4e3d4622b1e7bd419815510e5f7cd0f96595b2a3 DIFF: https://github.com/llvm/llvm-project/commit/4e3d4622b1e7bd419815510e5f7cd0f96595b2a3.diff

[PATCH] D79835: [Fuchsia] Rely on linker switch rather than dead code ref for profile runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rGd51054217403: [Fuchsia] Rely on linker switch rather than dead code ref for profile runtime (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D79835?vs=267336=268591#toc

[clang] d510542 - [Fuchsia] Rely on linker switch rather than dead code ref for profile runtime

Author: Petr Hosek Date: 2020-06-04T14:25:19-07:00 New Revision: d51054217403b47f452619e11318bd214749a845 URL: https://github.com/llvm/llvm-project/commit/d51054217403b47f452619e11318bd214749a845 DIFF: https://github.com/llvm/llvm-project/commit/d51054217403b47f452619e11318bd214749a845.diff

[PATCH] D80450: [CUDA][HIP] Fix implicit HD function resolution

This revision was automatically updated to reflect the committed changes. Closed by commit rG263390d4f5f2: [CUDA][HIP] Fix implicit HD function resolution (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D80450?vs=266366=268590#toc

[PATCH] D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling

stevewan updated this revision to Diff 268588. stevewan added a comment. Reduce the nested 'if' and reorder it to prefer the more likely case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81115/new/ https://reviews.llvm.org/D81115 Files:

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

jdoerfert added a comment. I doubt this is the right fix. I'll take a closer look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81192/new/ https://reviews.llvm.org/D81192 ___ cfe-commits mailing list

[PATCH] D80730: [OPENMP50]Codegen for use_device_addr clauses.

ABataev updated this revision to Diff 268587. ABataev added a comment. Rebase and fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80730/new/ https://reviews.llvm.org/D80730 Files: clang/lib/AST/OpenMPClause.cpp

[clang] 263390d - [CUDA][HIP] Fix implicit HD function resolution

Author: Yaxun (Sam) Liu Date: 2020-06-04T16:54:52-04:00 New Revision: 263390d4f5f23967a31af09eb6e0c12e633d6104 URL: https://github.com/llvm/llvm-project/commit/263390d4f5f23967a31af09eb6e0c12e633d6104 DIFF:

[PATCH] D79948: [OPENMP50]Codegen for inscan reductions in worksharing directives.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd1c03d7b7c8: [OPENMP50]Codegen for inscan reductions in worksharing directives. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

mikerice added a comment. Is it possible to have the same problem with other directives, like 'omp single' or 'omp master'? I haven't seen any test fail for those yet though. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:357 ///should be called. +

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

DmitryPolukhin updated this revision to Diff 268583. DmitryPolukhin added a comment. Apply suggested changes with string split Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files:

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

ABataev added a comment. In D81192#2074677 , @mikerice wrote: > Is it possible to have the same problem with other directives, like 'omp > single' or 'omp master'? I haven't seen any test fail for those yet though. I rather doubt. The main problem

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

dim added a comment. For completeness sake, here are the valgrind outputs of clang rGf7f1abdb889 (llvmorg-11-init-16778) built by gcc 9.3.0-10ubuntu2 (in RelWithDebInfo mode): F12078364:

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79587/new/ https://reviews.llvm.org/D79587 ___ cfe-commits mailing list

[clang] bd1c03d - [OPENMP50]Codegen for inscan reductions in worksharing directives.

Author: Alexey Bataev Date: 2020-06-04T16:29:33-04:00 New Revision: bd1c03d7b7c8bdd80b534cf2fa956c36a2f8249f URL: https://github.com/llvm/llvm-project/commit/bd1c03d7b7c8bdd80b534cf2fa956c36a2f8249f DIFF: https://github.com/llvm/llvm-project/commit/bd1c03d7b7c8bdd80b534cf2fa956c36a2f8249f.diff

[PATCH] D81138: [SemaOverload] Use iterator_range to iterate over VectorTypes (NFC).

This revision was automatically updated to reflect the committed changes. Closed by commit rG714e84be4615: [SemaOverload] Use iterator_range to iterate over VectorTypes (NFC). (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D81138?vs=268408=268572#toc Repository: rG

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

fhahn updated this revision to Diff 268569. fhahn added a comment. Ping. Simplified code and update tests to use more targeted check lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72778/new/ https://reviews.llvm.org/D72778 Files:

[PATCH] D81138: [SemaOverload] Use iterator_range to iterate over VectorTypes (NFC).

fhahn added a comment. In D81138#2074313 , @rjmccall wrote: > Thanks, LGTM. (But you can use QualType by value.) Thanks, changed in the committed version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81169: [clangd] Improve hover on arguments to function call

kadircet marked an inline comment as done. kadircet added a comment. thanks! that looks really useful, especially knowing when a parameter is being passed as a ref/val. Comment at: clang-tools-extra/clangd/Hover.cpp:292 +void fillParam(const ParmVarDecl *PVD,

[PATCH] D81188: [RISCV] Support experimental v extensions.

MaskRay added inline comments. Comment at: clang/test/Driver/riscv-arch.c:364 + +// RUN: %clang -target riscv32-unknown-elf -march=rv32iv -### %s \ +// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-EXPERIMENTAL-V-NOFLAG %s For the RUN lines, I'd prefer

[PATCH] D81192: [OPENMP]Fix PR45854: prevent code movement out of the critical region.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: llvm-commits, sstefan1, jfb, guansong, hiraditya, yaxunl. Herald added projects: clang, LLVM. Need to emit memory barriers upon enter/exit to/from critical region to prevent code movement.

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

danielkiss added a comment. depends on D80791 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75181/new/ https://reviews.llvm.org/D75181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80743: (PR46111) Desugar Elaborated types in Deduction Guides.

rsmith added a comment. In D80743#2074121 , @erichkeane wrote: > @rsmith I think this implements what you've suggested? Yes, thanks. > This seems to 'work' for a small subset of works, but it doesn't properly > register the typedef to the

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

evandro added a comment. Again, the `clang` part should be split in another patch and be made a child of D81188 . Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:297 +LMUL_F8 = 5, +LMUL_F4 = 6, +LMUL_F2 = 7

[clang] 714e84b - [SemaOverload] Use iterator_range to iterate over VectorTypes (NFC).

Author: Florian Hahn Date: 2020-06-04T20:47:16+01:00 New Revision: 714e84be4615d6e1195f2798c0c3c8c54017dd5f URL: https://github.com/llvm/llvm-project/commit/714e84be4615d6e1195f2798c0c3c8c54017dd5f DIFF: https://github.com/llvm/llvm-project/commit/714e84be4615d6e1195f2798c0c3c8c54017dd5f.diff

[PATCH] D80743: (PR46111) Desugar Elaborated types in Deduction Guides.

erichkeane added a comment. In D80743#2074121 , @erichkeane wrote: > @rsmith I think this implements what you've suggested? I'm struggling a > little with the template instantiations here, I'm not terribly sure I > understand them as well as I'd hope. >

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

evandro added a comment. It looks pretty GTM. At this point, I'd be fine with accepting this patch as the major issues seem to have already been addressed. Should there be any other minor issue, it could be addressed later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81180: AST Matchers test: use arrays instead of vectors

This revision was automatically updated to reflect the committed changes. Closed by commit rGa180d5409f21: AST Matchers test: use arrays instead of vectors (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81180/new/

[PATCH] D81180: AST Matchers test: use arrays instead of vectors

gribozavr2 added a comment. > probably didn't need a review this one I don't believe in post-commit review anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81180/new/ https://reviews.llvm.org/D81180

[clang] a180d54 - AST Matchers test: use arrays instead of vectors

Author: Dmitri Gribenko Date: 2020-06-04T21:40:30+02:00 New Revision: a180d5409f218d933bec99bc28f7a9970fb293d4 URL: https://github.com/llvm/llvm-project/commit/a180d5409f218d933bec99bc28f7a9970fb293d4 DIFF:

[PATCH] D81188: [RISCV] Support experimental v extensions.

HsiangKai created this revision. HsiangKai added reviewers: MaskRay, rogfer01. Herald added subscribers: cfe-commits, evandro, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng,

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

HsiangKai added a comment. In D69987#2074265 , @MaskRay wrote: > Drive-by comment: the clang side change isn't tightly coupled with the LLVM > side changes. It should be a separate patch. Create https://reviews.llvm.org/D81188 for clang side change.

[PATCH] D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

vsk added a subscriber: phosek. vsk added a comment. In D81122#2074213 , @keith wrote: > FYI I actually removed that piece this morning since I felt like since this > now supports `-path-equivalence=.,foo` which is the "expected" behavior from > lldb,

[PATCH] D81180: AST Matchers test: use arrays instead of vectors

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. cheers LGTM, probably didn't need a review this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81180/new/

[PATCH] D81138: [SemaOverload] Use iterator_range to iterate over VectorTypes (NFC).

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. (But you can use QualType by value.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81138/new/

[PATCH] D81176: [HIP] Add default header and include path

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Thank you for the patch. This will make my life a lot easier. There are a few nits, but it's LGTM in general. Do I understand it correctly that for detection of HIP installation all we need is to

[PATCH] D81157: Propose naming principle for NodeRole and apply it

This revision was automatically updated to reflect the committed changes. Closed by commit rG42f6fec3878d: Propose naming principle for NodeRole and apply it (authored by eduucaldas, committed by gribozavr). Changed prior to commit: https://reviews.llvm.org/D81157?vs=268519=268543#toc

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

MaskRay added a comment. Drive-by comment: the clang side change isn't tightly coupled with the LLVM side changes. It should be a separate patch. Comment at: llvm/test/MC/RISCV/rvv/add.s:1 +# RUN: llvm-mc -triple=riscv64 -show-encoding --mattr=+experimental-v < %s \ +# RUN:

[PATCH] D81150: Use libClangTesting in the unittest for AST matchers

gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersTest.h:62 +inline ArrayRef langCxx11OrLater() { + static std::vector Result = {Lang_CXX11, Lang_CXX14, Lang_CXX17, +

[PATCH] D81180: AST Matchers test: use arrays instead of vectors

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr2 added a reviewer: njames93. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81180 Files: clang/unittests/ASTMatchers/ASTMatchersTest.h Index:

[PATCH] D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

keith added a comment. FYI I actually removed that piece this morning since I felt like since this now supports `-path-equivalence=.,foo` which is the "expected" behavior from lldb, that was "good enough". lmk if you want me to add it back! Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 42f6fec - Propose naming principle for NodeRole and apply it

Author: Eduardo Caldas Date: 2020-06-04T20:08:35+02:00 New Revision: 42f6fec3878d708f2791ab0be3a060b07dac9d76 URL: https://github.com/llvm/llvm-project/commit/42f6fec3878d708f2791ab0be3a060b07dac9d76 DIFF:

[PATCH] D81178: [FPEnv] Initialization of C++ globals not strictfp aware

kpn created this revision. kpn added reviewers: rjmccall, pcc, mibintc. Herald added a project: clang. Herald added a subscriber: cfe-commits. The rules of the strictfp attribute say that if it is used inside a function then it must also be in the function definition. Initialization of C++

[PATCH] D79710: [clang][BFloat] Add create/set/get/dup intrinsics

miyuki updated this revision to Diff 268528. miyuki added a comment. Fixed the "RUN:" line in the A32 test, implemented vduph_lane for A32. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79710/new/ https://reviews.llvm.org/D79710 Files: clang/include/clang/Basic/arm_neon.td

[PATCH] D78477: [profile] Don't crash when forking in several threads

rovka added a comment. Hi! I think this commit is causing some instability on the 10.0.1 branch on 32-bit arm: https://bugs.llvm.org/show_bug.cgi?id=46092 Can you have a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78477/new/

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

dim added a comment. In D69825#2071687 , @dim wrote: > Trying to reduce this now. Unfortunately this turned out to be a red herring, as the test case got reduced by `creduce` to just: a() { b(""); } The valgrind warnings are also different when you

[PATCH] D80743: (PR46111) Desugar Elaborated types in Deduction Guides.

erichkeane updated this revision to Diff 268524. erichkeane added a comment. @rsmith I think this implements what you've suggested? I'm struggling a little with the template instantiations here, I'm not terribly sure I understand them as well as I'd hope. This seems to 'work' for a small

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr

zinovy.nis marked an inline comment as done. zinovy.nis added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-redundant-expression.cpp:196 bool operator>(const MyStruct& lhs, MyStruct& rhs) { rhs.x--; return lhs.x > rhs.x; } bool

[PATCH] D81131: [DebugInfo] Fix assertion for extern void type

dblaikie added a comment. Patches without tests shouldn't be approved - and at least the usual/rough metric I use for patch approval is (most often - unless I'm reviewing the work of the code owner in any area who wants a second opinion, etc) - I approve it if I'd be willing to commit a

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr

zinovy.nis updated this revision to Diff 268527. zinovy.nis added a comment. Simplify test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80896/new/ https://reviews.llvm.org/D80896 Files: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp

[PATCH] D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Lgtm. Thanks for making the addition to the command guide! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81122/new/ https://reviews.llvm.org/D81122

[PATCH] D81176: [HIP] Add default header and include path

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kerbowa, mgorny, nhaehnle, jvesely. To support std::complex and some other standard C/C++ functions in HIP device code, they need to be forced to be `__host__ __device__` functions by pragmas. This is done by

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/ https://reviews.llvm.org/D80752 ___ cfe-commits mailing list

  1   2   3   >