[PATCH] D84087: [NFC] Clean up doc comment and implementation for Module::isSubModuleOf.

varungandhi-apple updated this revision to Diff 278972. varungandhi-apple added a comment. Updated commit message with reviewer information and revision link. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84087/new/ https://reviews.llvm.org/D84087

[PATCH] D84087: [NFC] Clean up doc comment and implementation for Module::isSubModuleOf.

varungandhi-apple created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84087 Files: clang/include/clang/Basic/Module.h clang/lib/Basic/Module.cpp Index: clang/lib/Basic/Module.cpp

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

fghanim accepted this revision. fghanim added a comment. This revision is now accepted and ready to land. Great. Thank you! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82470/new/ https://reviews.llvm.org/D82470

[PATCH] D83398: [OPENMP50]Perform data mapping analysis only for explicitly mapped data.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83398/new/ https://reviews.llvm.org/D83398

[PATCH] D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def

jdoerfert added a comment. In D81031#2159895 , @jhuber6 wrote: > Fixing errors caused by unused attribute sets. Adding missing attributes to > barrier_codegen.cpp. > > Should I go ahead and commit this considering the previous was temporarily >

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

jdoerfert updated this revision to Diff 278952. jdoerfert added a comment. Reuse builder Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82470/new/ https://reviews.llvm.org/D82470 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

vsapsai added a comment. In D82118#2154310 , @zixuw wrote: > In D82118#2154280 , @vsapsai wrote: > > > Didn't get into details but overall GenModuleActionWrapper approach looks > > pretty complicated. Haven't

[PATCH] D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def

jhuber6 updated this revision to Diff 278949. jhuber6 added a comment. Fixing errors caused by unused attribute sets. Adding missing attributes to barrier_codegen.cpp. Should I go ahead and commit this considering the previous was temporarily reverted? Or should I just wait a bit to see if it

[clang] 1050560 - [clang][NFC] Add a missing 'override'

Author: Logan Smith Date: 2020-07-17T17:35:59-07:00 New Revision: 105056045d9ab0b1a49781a18129ada48893452e URL: https://github.com/llvm/llvm-project/commit/105056045d9ab0b1a49781a18129ada48893452e DIFF: https://github.com/llvm/llvm-project/commit/105056045d9ab0b1a49781a18129ada48893452e.diff

[PATCH] D84082: [tsan] Allow TSan in the Clang driver for Apple Silicon Macs

kubamracek created this revision. kubamracek added reviewers: dcoughlin, delcypher, yln, arphaman, steven_wu. kubamracek added a project: Sanitizers. Herald added subscribers: cfe-commits, Charusso, dexonsmith. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def

jhuber6 added a comment. In D81031#2159796 , @leonardchan wrote: > In D81031#2159646 , @sstefan1 wrote: > > > Just in case you haven't seen already, > > `clang/test/OpenMP/barrier_codegen.cpp` needs to be updated

[PATCH] D83731: Add Debug Info Size to Symbol Status

wallace accepted this revision. wallace added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:65 +@skipIfWindows +@ skipUnlessDarwin +@skipIfRemote remove this whitespace Repository: rG LLVM Github

[PATCH] D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def

leonardchan added a comment. In D81031#2159646 , @sstefan1 wrote: > Just in case you haven't seen already, > `clang/test/OpenMP/barrier_codegen.cpp` needs to be updated as well. Also chiming in to say we're seeing these failures on our bots

[PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

This revision was automatically updated to reflect the committed changes. Closed by commit rG53880b8cb9c6: [CMake] Make `intrinsics_gen` dependency unconditional. (authored by michele.scandale, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 53880b8 - [CMake] Make `intrinsics_gen` dependency unconditional.

Author: Michele Scandale Date: 2020-07-17T16:43:17-07:00 New Revision: 53880b8cb9c61e81457d13c0adefe51ff41664fa URL: https://github.com/llvm/llvm-project/commit/53880b8cb9c61e81457d13c0adefe51ff41664fa DIFF:

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny marked 2 inline comments as done. jdenny added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7934-7940 +// If any element has the present modifier, then make sure the runtime +// doesn't attempt to allocate the struct. +if (CurTypes.end()

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs marked 4 inline comments as done. dokyungs added inline comments. Comment at: compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp:119 +return internal_memcmp(s1, s2, n); + ensureFuzzerInited(); + int result = REAL(memcmp)(s1, s2, n); morehouse wrote: >

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs updated this revision to Diff 278924. dokyungs marked 2 inline comments as done. dokyungs added a comment. Removed CustomAllocatorTest.cpp. Instead, use EmptyTest.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83494/new/

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs updated this revision to Diff 278923. dokyungs added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83494/new/ https://reviews.llvm.org/D83494 Files: clang/include/clang/Driver/SanitizerArgs.h

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278922. aelitashen added a comment. Add TODO comment for Linux, Use ostringstream for Debug Info Size message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731

[PATCH] D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def

sstefan1 added a comment. Just in case you haven't seen already, `clang/test/OpenMP/barrier_codegen.cpp` needs to be updated as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81031/new/ https://reviews.llvm.org/D81031

[PATCH] D83731: Add Debug Info Size to Symbol Status

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. The logic looks very good, just some final comments and the code will be high quality Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:66

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny marked 4 inline comments as done. jdenny added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:3067-3068 + unsigned Type = getOpenMPSimpleClauseType(OMPC_map, PP.getSpelling(Tok)); + if (Type < OMPC_MAP_MODIFIER_unknown) +return

[clang-tools-extra] 7fcc1bb - [clangd] Fix the build with clang <3.9.

Author: Michael Spencer Date: 2020-07-17T16:12:31-06:00 New Revision: 7fcc1bb4b654461c3109b01e1fe7eae191a86f7f URL: https://github.com/llvm/llvm-project/commit/7fcc1bb4b654461c3109b01e1fe7eae191a86f7f DIFF:

[PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

michele.scandale added a comment. In D83454#2145086 , @michele.scandale wrote: > In D83454#2144386 , @JDevlieghere > wrote: > > > In D83454#2142719 , > >

[PATCH] D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def

This revision was automatically updated to reflect the committed changes. Closed by commit rG09fe0c5ab9ca: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D81031?vs=278905=278908#toc Repository:

[PATCH] D83652: Merge some of the PCH object support with modular codegen

dblaikie added a comment. @hans - could you perhaps give me a quick summary of commands I could use to test this feature in Chromium (or anything else you might suggest) on a Linux box? I don't have a Windows machine, or any projects that use PCH. (or if you'd be willing to test this, that'd

[PATCH] D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def

jhuber6 updated this revision to Diff 278905. jhuber6 added a comment. Removed usage of alignment and deference attributes and changed several functions to use barrier attributes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81031/new/

[clang] c2d69d8 - Remove clang matrix lowering test for now as it is still failing under the NPM.

Author: Sjoerd Meijer Date: 2020-07-17T22:42:12+01:00 New Revision: c2d69d8d62f2aac941453177e2ae872f5f82feda URL: https://github.com/llvm/llvm-project/commit/c2d69d8d62f2aac941453177e2ae872f5f82feda DIFF: https://github.com/llvm/llvm-project/commit/c2d69d8d62f2aac941453177e2ae872f5f82feda.diff

[PATCH] D83722: [PowerPC] Add options to control paired vector memops support

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPC.td:243 + "32Byte load and store instructions", + [FeatureISA3_0]>; Is this supposed to be `FeatureISA3_1`? Comment at:

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

amyk added a comment. Please also change the function names. Comment at: clang/lib/Headers/altivec.h:17151 + +/* vs[l | r | raq] */ +static __inline__ vector unsigned __int128 __ATTRS_o_ai Actually, sorry, I think this comment should be the following instead:

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

morehouse added inline comments. Comment at: compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp:62 + +static int internal_strncmp(const char *s1, const char *s2, uintptr_t n) { + for (uintptr_t i = 0; i < n; i++) { Can we use `size_t` instead of `uintptr_t`?

[PATCH] D81442: [PowerPC] Add clang options to control MMA support

amyk accepted this revision. amyk added a comment. I think overall it LGTM. Comment at: llvm/lib/Target/PowerPC/PPCScheduleP9.td:44 // Do not support QPX (Quad Processing eXtension), SPE (Signal Processing // Engine), prefixed instructions on Power 9, PC relative mem

[PATCH] D83877: [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling

NoQ accepted this revision. NoQ added inline comments. Comment at: clang/test/Analysis/Inputs/system-header-simulator-cxx.h:964-965 + + template + void swap(unique_ptr , unique_ptr ) noexcept { +x.swap(y); vrnithinkumar wrote: > xazax.hun wrote: > > NoQ

[PATCH] D83836: [Analyzer] Add checkRegionChanges for SmartPtrModeling

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I think this looks great! P.S. I unforgot why we won't be able to remove the option after all. That's because when we partially evalCall and partially inline, inlining breaks. Like, once we

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7043-7044 OMP_MAP_CLOSE = 0x400, +/// Produce a runtime error if the data is not already allocated. +OMP_MAP_PRESENT = 0x800, /// The 16 MSBs of the flags indicate whether the

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278900. aelitashen added a comment. Merge if statements in GetDebugInfoSizeInSection() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files:

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278898. aelitashen added a comment. Merge Codes and Improve Readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files:

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

evandro added a comment. Just a couple of nits, but otherwise it LGTM. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:776 } -return ""; +llvm_unreachable("Unknown SEW."); } I'd rather the first case be the `default` case and

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278894. aelitashen added a comment. Create help function in tests for code re-use. Take care of both macOS and Linux system. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs updated this revision to Diff 278892. dokyungs added a comment. Introduce internal_(memcmp|strncmp|strstr) and use them before interceptors are fully initialized. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83494/new/

[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

dgoldman updated this revision to Diff 278890. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84067/new/ https://reviews.llvm.org/D84067 Files: clang/include/clang/Sema/SemaInternal.h

[clang] ec6ada6 - [AIX] report_fatal_error on `-fregister_global_dtors_with_atexit` for static init

Author: Xiangling Liao Date: 2020-07-17T16:14:49-04:00 New Revision: ec6ada62643cf7cded8160e04cce163323112ade URL: https://github.com/llvm/llvm-project/commit/ec6ada62643cf7cded8160e04cce163323112ade DIFF:

[PATCH] D83974: [AIX] report_fatal_error on `-fregister_global_dtors_with_atexit` for static init

This revision was automatically updated to reflect the committed changes. Closed by commit rGec6ada62643c: [AIX] report_fatal_error on `-fregister_global_dtors_with_atexit` for static… (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

tra added a comment. Could you walk me through how you see this working in practice? IIUIC, the idea is to have bitcode files located somewhere within clang installation. If that's the case, will we ship those bitcode libraries with clang, or do they come from ROCm packages? If we ship them

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5385 + if (getCodeGenOpts().hasMaybeUnusedDebugInfo() && CRD->hasDefinition()) +DI->completeUnusedClass(*CRD); + else if (auto *ES = D->getASTContext().getExternalSource())

[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

dgoldman updated this revision to Diff 278881. dgoldman added a comment. - CheckAndAdvanceTypoExprCorrectionStreams comment fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84067/new/ https://reviews.llvm.org/D84067 Files:

[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

dgoldman updated this revision to Diff 278876. dgoldman added a comment. - Minor comment fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84067/new/ https://reviews.llvm.org/D84067 Files: clang/include/clang/Sema/SemaInternal.h

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

arsenm created this revision. arsenm added reviewers: yaxunl, tra. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. This should be the preferred way of locating the libraries, and it's a packaging problem to ensure the libraries are symlinked into the

[PATCH] D84067: Fix issue in typo handling which could lead clang to hang

dgoldman created this revision. dgoldman added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. We need to detect when certain TypoExprs are not being transformed due to invalid trees, otherwise we risk endlessly trying to fix it. Repository: rG LLVM

[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

stefanp accepted this revision as: stefanp. stefanp added a comment. LGTM. Please wait for Lei to give the approval as well before you commit. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll:2 +; NOTE: Assertions have been autogenerated by

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

davidvancleve added a comment. Seems like it's working as expected now! Thanks again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83099/new/ https://reviews.llvm.org/D83099 ___ cfe-commits mailing

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks added a comment. In D83519#2158938 , @ychen wrote: > In D83519#2144616 , @aeubanks wrote: > > > In D83519#2144463 , @aeubanks > > wrote: > > > > > In

[PATCH] D84058: Pass -rtlib=libgcc in tests conditioned on the default.

atrosinenko added a reviewer: atrosinenko. atrosinenko added a comment. If I get it right, the only thing this patch weakens about msp430-toolchain.c test is an assumption that libgcc is used by default. On one hand, now there is no `clang_rt.builtins` for MSP430, so testing this assumption

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks updated this revision to Diff 278871. aeubanks added a comment. Remove required passes part Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83519/new/ https://reviews.llvm.org/D83519 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

gamesh411 updated this revision to Diff 278870. gamesh411 added a comment. rename Offset -> Amount inside handleRandomIncrOrDecl minor local variable renaming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83190/new/ https://reviews.llvm.org/D83190

[PATCH] D84058: Pass -rtlib=libgcc in tests conditioned on the default.

saugustine added a comment. This is a reasonable workaround, as it seems to be checking the position of various arguments, and as things work today, lgcc and the compiler-rt variants appear in exactly the same places. If we wanted to be really strict, we would add some new test that tested

[clang] 5d06e8b - Pass -rtlib=libgcc in tests conditioned on the default.

Author: Stella Laurenzo Date: 2020-07-17T11:28:18-07:00 New Revision: 5d06e8b24f97202764c7522efcfb6e2febdce6b7 URL: https://github.com/llvm/llvm-project/commit/5d06e8b24f97202764c7522efcfb6e2febdce6b7 DIFF:

[PATCH] D84058: Pass -rtlib=libgcc in tests conditioned on the default.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d06e8b24f97: Pass -rtlib=libgcc in tests conditioned on the default. (authored by stellaraccident). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84058: Pass -rtlib=libgcc in tests conditioned on the default.

stellaraccident updated this revision to Diff 278865. stellaraccident added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84058/new/ https://reviews.llvm.org/D84058 Files: clang/test/Driver/msp430-toolchain.c Index:

[PATCH] D84058: Pass -rtlib=libgcc in tests conditioned on the default.

echristo added a reviewer: saugustine. echristo added a comment. (Adding Sterling as well) I think this will be an OK workaround for now, go ahead and reply on the main thread as I think they'll want to set the default runtime library as part of the toolchain. I'm surprised at this behavior as

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

stellaraccident added a comment. The msp430-toolchain.c test was failing in our setup, and I've put together a fix in D84058 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81676/new/

[PATCH] D84058: Pass -rtlib=libgcc in tests conditioned on the default.

stellaraccident created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - This test was failing in our builds that configure compiler-rt as the configure-time rtlib. - Opted for this test fix instead of a rollback, and hopefully TI can fix forward if this

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

gamesh411 updated this revision to Diff 278853. gamesh411 marked an inline comment as done. gamesh411 added a comment. apply review suggestions - rename variables - remove 1 assert - rename tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

gamesh411 marked 6 inline comments as done. gamesh411 added a comment. Thanks for reviewing this patch this quickly! I have updated the diff according to your suggestions, but I will not land it till I run a llvm+clang analysis with it. Do you think non-ctu mode is enough to test the stability?

[PATCH] D83812: [clang][RelativeVTablesABI] Do not emit stubs for architectures that support a PLT relocation

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:633 + auto Arch = targetTriple.getArch(); + if (Arch == llvm::Triple::aarch64 || Arch == llvm::Triple::x86_64) +return false; Could you add a method to TargetCodeGenInfo for this

[PATCH] D84032: [clang] Make clear Sema::CheckForConstantInitializer is for C-only codepath.

hokein planned changes to this revision. hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/test/SemaCXX/compound-literal.cpp:92 -// This doesn't necessarily need to be an error, but CodeGen can't handle it -// at the moment. -int PR17415

[PATCH] D83088: Introduce CfgTraits abstraction

arsenm added inline comments. Comment at: llvm/include/llvm/CodeGen/MachineCfgTraits.h:44 +// use on a 32-bit architecture. +assert(wrapped != (uintptr_t)-1 && wrapped != (uintptr_t)-2); + I feel like there should be a better way to do this; we should

[PATCH] D83665: [OpenCL] Fixed missing address space for templated copy constructor

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3811 + if(S.getLangOpts().OpenCL) +ArgType = S.deduceOpenCLPointeeAddrSpace(ArgType); ArgType = S.Context.getLValueReferenceType(ArgType); I feel we can

[PATCH] D83519: [NewPM] Support optnone under new pass manager

ychen added a comment. In D83519#2144616 , @aeubanks wrote: > In D83519#2144463 , @aeubanks wrote: > > > In D83519#2144403 , @ychen wrote: > > > > > High-level request: how

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

baloghadamsoftware updated this revision to Diff 278832. baloghadamsoftware added a comment. Rebased, updated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76590/new/ https://reviews.llvm.org/D76590 Files: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp

[PATCH] D84021: [Driver] Add support for -msve-vector-bits=scalable.

sdesmalen added a comment. Still LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84021/new/ https://reviews.llvm.org/D84021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

njames93 added a comment. In D83717#2155103 , @gamesh411 wrote: > My thoughts exactly! I also thought about anchor-points as a feature in > file-check, as that would immensely increase the readability of the test-code > in such cases. I've put in an

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

erichkeane updated this revision to Diff 278825. erichkeane added a comment. Woops, left in a TODO from when I was planning on how to do this patch. Should be ready now :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84048/new/ https://reviews.llvm.org/D84048 Files:

[PATCH] D83788: Removed unused variable in clang

hiraditya accepted this revision. hiraditya added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83788/new/ https://reviews.llvm.org/D83788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

erichkeane added a comment. I added @rsmith directly, since I suspect he's the most knowledgeable in SemaTemplateDeduction.cpp, but if anyone knows of someone else who is a good fit for this review, please add them as well! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84048/new/

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

erichkeane created this revision. erichkeane added reviewers: rsmith, rjmccall, aaron.ballman. DR2303 fixes the case where the derived-base match for template deduction is ambiguous if a base-of-base ALSO matches. The canonical example (as shown in the test) is just like the MSVC implementation

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. This revision is now accepted and ready to land. Looks good, aside from the few naming issues I mentioned. Please try it on //LLVM/Clang// before committing it to avoid unexpected crashes. Comment

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

This revision was automatically updated to reflect the committed changes. Closed by commit rGd19f0666bcd8: [clang][Tooling] Try to avoid file system access if there is no record for the… (authored by ArcsinX, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] d19f066 - [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

Author: Aleksandr Platonov Date: 2020-07-17T18:49:14+02:00 New Revision: d19f0666bcd8f7d26aaf4019244c3ed91e47b1b7 URL: https://github.com/llvm/llvm-project/commit/d19f0666bcd8f7d26aaf4019244c3ed91e47b1b7 DIFF:

[PATCH] D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json

sammccall added a comment. In D83621#2153711 , @ArcsinX wrote: > As far as I do not have commit access, could you please commit for me? > Aleksandr Platonov Oops, missed this! Committed as d19f0666bcd8f7d26aaf4019244c3ed91e47b1b7

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

Anastasia added inline comments. Comment at: clang/test/CodeGen/fp-function-attrs.cpp:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -ffast-math -ffinite-math-only -menable-unsafe-fp-math \ +// RUN: -menable-no-infs -menable-no-nans -fno-signed-zeros -freciprocal-math \ +//

[PATCH] D83991: With MSVC, file needs to be compiled with /BIGOBJ

This revision was automatically updated to reflect the committed changes. Closed by commit rG14dde438d69c: With MSVC, file needs to be compiled with /BIGOBJ (authored by amccarth). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] 14dde43 - With MSVC, file needs to be compiled with /BIGOBJ

Author: Adrian McCarthy Date: 2020-07-17T09:43:06-07:00 New Revision: 14dde438d69c81ab4651157a94d32ee804ff URL: https://github.com/llvm/llvm-project/commit/14dde438d69c81ab4651157a94d32ee804ff DIFF:

[PATCH] D83680: [clang-tidy] Refactor IncludeInserter

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83680/new/ https://reviews.llvm.org/D83680

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

calixte accepted this revision. calixte added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83149/new/ https://reviews.llvm.org/D83149 ___ cfe-commits mailing list

[PATCH] D83680: [clang-tidy] Refactor IncludeInserter

njames93 updated this revision to Diff 278807. njames93 marked 5 inline comments as done. njames93 added a comment. Address reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83680/new/ https://reviews.llvm.org/D83680 Files:

[PATCH] D84021: [Driver] Add suppoort for -msve-vector-bits=scalable.

paulwalker-arm updated this revision to Diff 278803. paulwalker-arm added a comment. Herald added a subscriber: dang. Sorry for the post acceptance change, but I spotted the help text needed an update also. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. The problem with `fgetc` is here that the returned value indicates not only if there was failure or not. In the following (over simplified) example no warning is needed even if there is no check for EOF. Because this case, for such kind of functions any comparison of

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83492/new/ https://reviews.llvm.org/D83492

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

saiislam updated this revision to Diff 278799. saiislam added a comment. Corrected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83492/new/ https://reviews.llvm.org/D83492 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp Index:

[PATCH] D83901: [clang] Disable a few formatting options for test/

riccibruno added a comment. In D83901#2155127 , @MyDeveloperDay wrote: > clang-format -n warnings before this change in clang/test/Analysis/*.cpp > (clang-format -n *.cpp |& grep warning | wc -l) > > before = 6903 vs after=6595, if it helps I'd say

[PATCH] D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP support

jsji added a comment. In D83915#2156346 , @jsji wrote: > In D83915#2155650 , > @hubert.reinterpretcast wrote: > > > Should we indicate planned removal in the Release Notes for version 11 and > > actual removal in

[PATCH] D83822: [clangd] Support config over LSP.

sammccall added a comment. There are lots of choices and overlapping ideas for how the protocol should look, little urgency (it isn't going to make clangd 11), and few concrete use cases to evaluate the options. Let's table this for now and let the ideas sink in and more use cases crop up. I

[PATCH] D83974: [AIX] report_fatal_error on `-fregister_global_dtors_with_atexit` for static init

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM; thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83974/new/ https://reviews.llvm.org/D83974 ___ cfe-commits mailing list

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

saiislam updated this revision to Diff 278787. saiislam added a comment. Removed getNVPTXWarpSize() changes for a separate patch and rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83492/new/ https://reviews.llvm.org/D83492 Files:

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:654 + unsigned LaneIDBits = + CGF.getTarget().getGridValue(llvm::omp::GV_Warp_Size_Log2); return Bld.CreateAShr(getNVPTXThreadID(CGF),

[PATCH] D84021: [Driver] Add suppoort for -msve-vector-bits=scalable.

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. nit: s/suppoort/support/ (in title) LGTM otherwise! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84021/new/

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

jdenny marked 3 inline comments as done. jdenny added a comment. Thanks for the review. Will try to push soon. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83922/new/ https://reviews.llvm.org/D83922 ___ cfe-commits mailing list

[PATCH] D84032: [clang] Make clear Sema::CheckForConstantInitializer is for C-only codepath.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11072 // rules there don't matter.) + assert(!getLangOpts().CPlusPlus || getLangOpts().OpenCLCPlusPlus); const Expr *Culprit; openCL for C++ is

  1   2   >