[clang] 4fc69ab - Revert "[OpenMP][FIX] Verify compatible types for declare variant calls"

Author: Johannes Doerfert Date: 2020-09-29T00:37:11-05:00 New Revision: 4fc69ab002382675d84f611f22599cb3cb4a0787 URL: https://github.com/llvm/llvm-project/commit/4fc69ab002382675d84f611f22599cb3cb4a0787 DIFF:

[PATCH] D88384: [OpenMP][FIX] Verify compatible types for declare variant calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc942095790de: [OpenMP][FIX] Verify compatible types for declare variant calls (authored by jdoerfert). Changed prior to commit:

[clang] c942095 - [OpenMP][FIX] Verify compatible types for declare variant calls

Author: Johannes Doerfert Date: 2020-09-28T23:26:21-05:00 New Revision: c942095790decf525a445f3bd68fb9bcc9aa43c6 URL: https://github.com/llvm/llvm-project/commit/c942095790decf525a445f3bd68fb9bcc9aa43c6 DIFF:

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > For my installation configured with > -DCMAKE_INSTALL_PREFIX=/home/antipov/.local/llvm-12.0.0, it's possible to > filter out 80 of 200 VFS lookups, from: The strace dump is too long.

[PATCH] D86629: [AVR][clang] Pass the address of the data section to the linker for ATmega328

benshi001 added a comment. I think this patch is OK to be committed. And I hope 1. Temporarily using an array for more devices, before a solution of getting info from the tblgen. 2. Distinghuish the arguments for "-L" and "-m". It is correct for atmega328 that avr-ld needs

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

dmantipov added a comment. Thanks @MaskRay for the method, some of my numbers are shown below. Before: # strace -fc -e file /home/antipov/.local/llvm-12.0.0/bin/clang++ test.cc % time seconds usecs/call callserrors syscall -- --- --- - -

[clang] 5a3023a - [HIP] Return non-zero value for invalid target ID

Author: Yaxun (Sam) Liu Date: 2020-09-28T23:07:39-04:00 New Revision: 5a3023a91c0ec82e7272569c5ca7a6eb372b129f URL: https://github.com/llvm/llvm-project/commit/5a3023a91c0ec82e7272569c5ca7a6eb372b129f DIFF:

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

dmantipov updated this revision to Diff 294873. dmantipov added a comment. Prefer locals and function parameters to class members. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87901/new/ https://reviews.llvm.org/D87901 Files:

[PATCH] D88410: [clang][AVR] Improve avr-ld command line options

benshi001 updated this revision to Diff 294872. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88410/new/ https://reviews.llvm.org/D88410 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-link-mcu-family-unimplemented.c clang/test/Driver/avr-mmcu.c Index:

[clang] 187658b - Recommit "[HIP] Change default --gpu-max-threads-per-block value to 1024"

Author: Yaxun (Sam) Liu Date: 2020-09-28T22:43:17-04:00 New Revision: 187658b8a6112446d9e7797d495bc7542ac83905 URL: https://github.com/llvm/llvm-project/commit/187658b8a6112446d9e7797d495bc7542ac83905 DIFF:

[PATCH] D88463: [clangd] Try harder to get accurate ranges for documentSymbols in macros

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Fixes https://github.com/clangd/clangd/issues/500 Repository: rG LLVM

[clang] 10eb3bf - Skip -fPIE for AMDGPU and HIP toolchain

Author: Yaxun (Sam) Liu Date: 2020-09-28T22:03:18-04:00 New Revision: 10eb3bf2d430825195bf092d3a75c4745d463826 URL: https://github.com/llvm/llvm-project/commit/10eb3bf2d430825195bf092d3a75c4745d463826 DIFF:

[PATCH] D88425: Skip -fPIE for AMDGPU and HIP toolchain

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG10eb3bf2d430: Skip -fPIE for AMDGPU and HIP toolchain (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[PATCH] D88462: FP math settings for static duration initialization - work in progress

mibintc created this revision. mibintc added a reviewer: sepavloff. mibintc added a project: clang. mibintc requested review of this revision. When compiling this C test case with -frounding-math there is an error diagnostic due to the rounding float F3d = 0x1.01p0; This patch resets the

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 294864. atmnpatel added a comment. more fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp

[PATCH] D88410: [clang][AVR] Improve avr-ld command line options

benshi001 updated this revision to Diff 294854. benshi001 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88410/new/ https://reviews.llvm.org/D88410 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-link-mcu-family-unimplemented.c

[clang-tools-extra] cc6d1f8 - [clangd] When finding refs for a renaming alias, do not return refs to underlying decls

Author: Nathan Ridge Date: 2020-09-28T21:18:31-04:00 New Revision: cc6d1f8029b05cd747c46ad3244a1b31ae970c61 URL: https://github.com/llvm/llvm-project/commit/cc6d1f8029b05cd747c46ad3244a1b31ae970c61 DIFF: https://github.com/llvm/llvm-project/commit/cc6d1f8029b05cd747c46ad3244a1b31ae970c61.diff

[PATCH] D87225: [clangd] When finding refs for a renaming alias, do not return refs to underlying decls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc6d1f8029b0: [clangd] When finding refs for a renaming alias, do not return refs to… (authored by nridge). Changed prior to commit:

[PATCH] D87225: [clangd] When finding refs for a renaming alias, do not return refs to underlying decls

nridge updated this revision to Diff 294851. nridge marked 2 inline comments as done. nridge added a comment. Address final review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87225/new/ https://reviews.llvm.org/D87225 Files:

[PATCH] D87225: [clangd] When finding refs for a renaming alias, do not return refs to underlying decls

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1155 + AdditionalDecls.push_back(AD); +break; + } hokein wrote: > I think the `break` is not necessarily needed. In practice we should just > have one

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

aganea added inline comments. Comment at: lld/ELF/Driver.cpp:895 const char *argv[] = {config->progName.data(), opt.data()}; + cl::ResetAllOptionOccurrences(); if (cl::ParseCommandLineOptions(2, argv, "", )) ayrivera wrote: > MaskRay wrote: > > ayrivera

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

ayrivera added inline comments. Comment at: lld/ELF/Driver.cpp:895 const char *argv[] = {config->progName.data(), opt.data()}; + cl::ResetAllOptionOccurrences(); if (cl::ParseCommandLineOptions(2, argv, "", )) MaskRay wrote: > ayrivera wrote: > > Hi, > >

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

MaskRay added inline comments. Comment at: lld/ELF/Driver.cpp:895 const char *argv[] = {config->progName.data(), opt.data()}; + cl::ResetAllOptionOccurrences(); if (cl::ParseCommandLineOptions(2, argv, "", )) ayrivera wrote: > Hi, > > I built locally lld

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

rsmith added a comment. In D68364#2299336 , @ldionne wrote: > In D68364#2294569 , @jwakely wrote: > >> I don't think your implementation is valid. I think P0784 only allows >> new-expressions and calls to

[clang] c375635 - Ensure that we don't compute linkage for an anonymous class too early if

Author: Richard Smith Date: 2020-09-28T17:22:40-07:00 New Revision: c375635d05f6f10c7c95ecc74a0569213d176d8e URL: https://github.com/llvm/llvm-project/commit/c375635d05f6f10c7c95ecc74a0569213d176d8e DIFF: https://github.com/llvm/llvm-project/commit/c375635d05f6f10c7c95ecc74a0569213d176d8e.diff

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

ayrivera added inline comments. Comment at: lld/ELF/Driver.cpp:895 const char *argv[] = {config->progName.data(), opt.data()}; + cl::ResetAllOptionOccurrences(); if (cl::ParseCommandLineOptions(2, argv, "", )) Hi, I built locally lld and came across an

[PATCH] D87176: [clang] Enable selectively turning on/off format-insufficient-args warning

jkorous added a comment. Had to fix the order of expected warnings in warning-wall.c 6fd8c69049a8 [clang] Update warning-wall.c test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6fd8c69 - [clang] Update warning-wall.c test

Author: Jan Korous Date: 2020-09-28T17:19:51-07:00 New Revision: 6fd8c69049a8fc119278097be6d0bdc3e781f1ba URL: https://github.com/llvm/llvm-project/commit/6fd8c69049a8fc119278097be6d0bdc3e781f1ba DIFF: https://github.com/llvm/llvm-project/commit/6fd8c69049a8fc119278097be6d0bdc3e781f1ba.diff

[PATCH] D88150: BuildVectorType with a dependent (array) type is crashing the compiler - Fix for PR-47542

This revision was automatically updated to reflect the committed changes. Closed by commit rGefd04721c9a2: BuildVectorType with a dependent (array) type is crashing the compiler - Fix… (authored by zahiraam, committed by rnk). Herald added a project: clang. Herald added a subscriber:

[clang] efd0472 - BuildVectorType with a dependent (array) type is crashing the compiler - Fix for PR-47542

Author: Zahira Ammarguellat Date: 2020-09-28T17:10:32-07:00 New Revision: efd04721c9a2a856dd47e47a08c42d21efd5dd2b URL: https://github.com/llvm/llvm-project/commit/efd04721c9a2a856dd47e47a08c42d21efd5dd2b DIFF:

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

davidsj2 added a comment. I too am interested in this patch. In addition to the use cases already described, this would be helpful for projects that use several different static analysis tools and don't want to clutter code with a bunch of different suppression comments to satisfy each tool.

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added a comment. In D87528#2297647 , @sepavloff wrote: > In D87528#2295015 , @mibintc wrote: > >> I tried using the 0924 version of the patch on an internal workload SPEC >> "cpu2017" and found that a few

[clang] ee80615 - [clang][driver][AIX] Set compiler-rt as default rtlib

Author: David Tenty Date: 2020-09-28T19:45:43-04:00 New Revision: ee80615b5c1c5b15c90a92d6954007b3a82825b0 URL: https://github.com/llvm/llvm-project/commit/ee80615b5c1c5b15c90a92d6954007b3a82825b0 DIFF: https://github.com/llvm/llvm-project/commit/ee80615b5c1c5b15c90a92d6954007b3a82825b0.diff

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

This revision was automatically updated to reflect the committed changes. Closed by commit rGee80615b5c1c: [clang][driver][AIX] Set compiler-rt as default rtlib (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88182/new/

[PATCH] D78938: Make LLVM build in C++20 mode

dblaikie added inline comments. Comment at: llvm/include/llvm/IR/BasicBlock.h:324-325 +template ::value>> phi_iterator_impl(const phi_iterator_impl ) Quuxplusone wrote: > dblaikie wrote: > > BRevzin wrote: > > > dblaikie wrote: > > > > What tripped

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

jlebar added a comment. > It should. I did mention in a previous comment that > Looks like the > const-ness check should not be there, either. I need to revise the patch. Heh, okay. Sorry I missed that, somehow this patch was confusing to me. > Except that NVCC allows non-const __constant__,

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

tra added a comment. In D88345#2298879 , @jlebar wrote: > OK, now I'm starting to I understand this change.. > > Before, in function scope, we allow static const/non-const `__shared__`, and > allow static const so long as it's not `__device__` or

[PATCH] D78938: Make LLVM build in C++20 mode

Quuxplusone added inline comments. Comment at: llvm/include/llvm/IR/BasicBlock.h:324-325 +template ::value>> phi_iterator_impl(const phi_iterator_impl ) dblaikie wrote: > BRevzin wrote: > > dblaikie wrote: > > > What tripped over/required this SFINAE? >

[PATCH] D87176: [clang] Enable selectively turning on/off format-insufficient-args warning

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e86d637eb4f: [clang] Selectively ena/disa-ble format-insufficient-args warning (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] 1e86d63 - [clang] Selectively ena/disa-ble format-insufficient-args warning

Author: Jan Korous Date: 2020-09-28T16:24:50-07:00 New Revision: 1e86d637eb4f88e03fcd4b9fd78192487dc2a302 URL: https://github.com/llvm/llvm-project/commit/1e86d637eb4f88e03fcd4b9fd78192487dc2a302 DIFF: https://github.com/llvm/llvm-project/commit/1e86d637eb4f88e03fcd4b9fd78192487dc2a302.diff

[PATCH] D87043: [Analyzer] Fix for dereferece of smart pointer after branching on unknown inner pointer

vrnithinkumar added a comment. In D87043#2294531 , @Szelethus wrote: > Congrats on your GSoC! Unless I missed it, it seems like you haven't posted > your final report on cfe-dev, even though its an amazing looking document > with a lot of examples and

[PATCH] D88182: [clang][driver][AIX] Set compiler-rt as default rtlib

daltenty updated this revision to Diff 294822. daltenty added a comment. - Remove blankline - Fix path seperators in second test as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88182/new/ https://reviews.llvm.org/D88182 Files:

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 294819. jhuber6 added a comment. Removed now unused function for generating convergent runtime functions. Updated Clang to print an error message if the user attempts to specify incompatible architectures due to a difference in pointer sizes. Repository:

[PATCH] D88452: [Driver] Move detectLibcxxIncludePath to ToolChain

phosek created this revision. phosek added reviewers: kristina, leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. phosek requested review of this revision. This helper method is useful even outside of Gnu toolchains, so move it to ToolChain so it can be reused in

[PATCH] D68364: Implement C++20's P0784 (More constexpr containers)

ldionne added a comment. In D68364#2294569 , @jwakely wrote: > In D68364#2293971 , @leonardchan > wrote: > >> Is there a recommended way for working around this? We're using GCC 10.2.1. >> Thanks. > > I don't

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang added a comment. @tejohnson @MaskRay Do you have other comments to the change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808 ___ cfe-commits mailing

[PATCH] D87853: [SemaTemplate] Stop passing insertion position around during VarTemplate instantiation

bruno added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87853/new/ https://reviews.llvm.org/D87853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D88333: Better diagnostics for anonymous bit-fields with attributes or an initializer

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/Parse/ParseDecl.cpp:4126 /// struct-declarator: declarator[opt] ':' constant-expression -if (Tok.isNot(tok::colon)) { +if

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

leonardchan added a comment. Hi! It looks like this is causing a test failure on our aach64 builders (https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-linux-arm64/b8868095822628984976?): [1113/1114] Running the Clang regression tests llvm-lit:

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added a comment. Sounds good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88445: Use "default member initializer" instead of "in-class initializer" for diagnostics

rsmith added a comment. Thanks! Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:864-867 + "default member initialization of non-static data member is a C++11 " + "extension">, InGroup; def warn_cxx98_compat_nonstatic_member_init : Warning< + "default member

[PATCH] D78938: Make LLVM build in C++20 mode

dblaikie added inline comments. Comment at: llvm/include/llvm/IR/BasicBlock.h:324-325 +template ::value>> phi_iterator_impl(const phi_iterator_impl ) BRevzin wrote: > dblaikie wrote: > > What tripped over/required this SFINAE? > There's somewhere which

Re: [clang] af1d3e6 - Allow init_priority values <= 100 and > 65535 within system headers.

On Mon, Sep 28, 2020 at 4:46 PM Robinson, Paul wrote: > > -Original Message- > > From: cfe-commits On Behalf Of Aaron > > Ballman via cfe-commits > > Sent: Wednesday, September 23, 2020 3:27 PM > > To: cfe-commits@lists.llvm.org > > Subject: [clang] af1d3e6 - Allow init_priority values

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86790/new/ https://reviews.llvm.org/D86790 ___ cfe-commits mailing list

[clang] e7549da - Fix a think-o with the numerical suffixes in the docs for init_priority.

Author: Aaron Ballman Date: 2020-09-28T16:52:58-04:00 New Revision: e7549dafcd33ced4280a81ca1d1ee4cc78ed253f URL: https://github.com/llvm/llvm-project/commit/e7549dafcd33ced4280a81ca1d1ee4cc78ed253f DIFF: https://github.com/llvm/llvm-project/commit/e7549dafcd33ced4280a81ca1d1ee4cc78ed253f.diff

[PATCH] D88446: docs: add documentation describing API Notes

compnerd created this revision. compnerd added reviewers: MForster, gribozavr2, rsmith. Herald added a subscriber: jfb. Herald added a project: clang. compnerd requested review of this revision. API Notes are a feature which allows annotation of headers by an auxiliary file that contains metadata

RE: [clang] af1d3e6 - Allow init_priority values <= 100 and > 65535 within system headers.

> -Original Message- > From: cfe-commits On Behalf Of Aaron > Ballman via cfe-commits > Sent: Wednesday, September 23, 2020 3:27 PM > To: cfe-commits@lists.llvm.org > Subject: [clang] af1d3e6 - Allow init_priority values <= 100 and > 65535 > within system headers. > > > Author: Aaron

[PATCH] D83296: [clang-format] Add a MacroExpander.

sammccall added a comment. In D83296#2299062 , @nridge wrote: > What does this change mean for users of clang-format -- better formatting of > complicated (e.g. multi-line) macro invocations? Nothing from this change is exposed yet, it's part of a

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. OK, great. Summarize our discussion above, I will follow up with: - rename intrinsic eha.scope.begin() with seh.scope.begin(). - update LangRef.rst with detailed explanation - not to allow inlining under SEH direct lexical scope - add conditional cleanup test case and

[PATCH] D88445: Use "default member initializer" instead of "in-class initializer" for diagnostics

aaron.ballman created this revision. aaron.ballman added a reviewer: rsmith. aaron.ballman requested review of this revision. This changes some diagnostics to use terminology from the standard rather than invented terminology, which improves consistency with other diagnostics as well. There are

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 294798. jhuber6 added a comment. Herald added a subscriber: aaron.ballman. Reusing OMPBuilder from CGOpenMPRuntime. Altered the failing test case. This case failed when compiling for a 32 bit device on a 64 bit host. This case should be considered an error

[clang] 288c577 - [X86] Use inlineasm flag output for the _bittest* intrinsics.

Author: Craig Topper Date: 2020-09-28T13:33:22-07:00 New Revision: 288c5776c9d3cb14abe1c86f961c8ff166772d28 URL: https://github.com/llvm/llvm-project/commit/288c5776c9d3cb14abe1c86f961c8ff166772d28 DIFF: https://github.com/llvm/llvm-project/commit/288c5776c9d3cb14abe1c86f961c8ff166772d28.diff

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG288c5776c9d3: [X86] Use inlineasm flag output for the _bittest* intrinsics. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

jdoerfert added inline comments. Comment at: clang/test/CodeGen/attr-mustprogress-1.cpp:24 + } +} + Now here, and below with `while(1)` I would *not* expect `mustprogress`. Comment at: clang/test/CodeGen/attr-mustprogress-1.cpp:185 + do { +

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 294794. atmnpatel added a comment. attempt 3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp

[PATCH] D83296: [clang-format] Add a MacroExpander.

nridge added a comment. What does this change mean for users of clang-format -- better formatting of complicated (e.g. multi-line) macro invocations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83296/new/ https://reviews.llvm.org/D83296

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

Xiangling_L updated this revision to Diff 294787. Xiangling_L added a comment. Add delete[] function to the testcase; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86790/new/ https://reviews.llvm.org/D86790 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp

[PATCH] D88370: Emit predefined macro for wavefront size for amdgcn

yaxunl updated this revision to Diff 294790. yaxunl added a comment. revised by Matt's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88370/new/ https://reviews.llvm.org/D88370 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/lib/Basic/Targets/AMDGPU.h

[PATCH] D88403: Migrate Declarators to use the List API

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:593 +/// Shrink \p Range to a subrange that only contains tokens of a list. +ArrayRef shrinkToFitList(ArrayRef Range) { Comment at:

[PATCH] D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0156914275be: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types (authored by bsaleil). Repository: rG LLVM Github

[clang] 0156914 - [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types

Author: Baptiste Saleil Date: 2020-09-28T14:39:37-05:00 New Revision: 0156914275be5b07155ecefe4dc2d58588265abc URL: https://github.com/llvm/llvm-project/commit/0156914275be5b07155ecefe4dc2d58588265abc DIFF:

[PATCH] D87737: Add -fprofile-update={atomic,prefer-atomic,single}

MaskRay updated this revision to Diff 294781. MaskRay added a comment. Add documentation to UserManual.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87737/new/ https://reviews.llvm.org/D87737 Files: clang/docs/UsersManual.rst

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

sstefan1 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.h:38 + /// An OpenMP-IR-Builder instance. + llvm::OpenMPIRBuilder OMPBuilder; + jhuber6 wrote: > sstefan1 wrote: > > There's already an instance of `OpenMPIRBuilder` in

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

Conanap updated this revision to Diff 294778. Conanap marked an inline comment as done. Conanap added a comment. Changed the location of fix and added extra test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84962/new/ https://reviews.llvm.org/D84962 Files:

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.h:38 + /// An OpenMP-IR-Builder instance. + llvm::OpenMPIRBuilder OMPBuilder; + sstefan1 wrote: > There's already an instance of `OpenMPIRBuilder` in `CGOpenMPRuntime`. > > Maybe

[clang] 0c82fa6 - [python][tests] Fix string comparison with "is"

Author: Paweł Bylica Date: 2020-09-28T21:11:50+02:00 New Revision: 0c82fa677f24d8a9656af41ac9cc64ea4f818bc0 URL: https://github.com/llvm/llvm-project/commit/0c82fa677f24d8a9656af41ac9cc64ea4f818bc0 DIFF: https://github.com/llvm/llvm-project/commit/0c82fa677f24d8a9656af41ac9cc64ea4f818bc0.diff

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

sstefan1 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.h:38 + /// An OpenMP-IR-Builder instance. + llvm::OpenMPIRBuilder OMPBuilder; + There's already an instance of `OpenMPIRBuilder` in `CGOpenMPRuntime`. Maybe just make it

[PATCH] D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types

bsaleil updated this revision to Diff 294776. bsaleil added a comment. Use early exit in lowering functions and extend test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84968/new/ https://reviews.llvm.org/D84968 Files:

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

jlebar added a comment. OK, now I'm starting to I understand this change.. Before, in function scope, we allow static const/non-const `__shared__`, and allow static const so long as it's not `__device__` or `__constant__`. - `static` -> error? (I understood us saying above that it is, but now

[PATCH] D86841: [clang] Add mustprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 294773. atmnpatel added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo.h

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Yep, neat. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87888/new/ https://reviews.llvm.org/D87888 ___

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

tra added a comment. In D88345#2298688 , @jlebar wrote: > OK, backing up, what are the semantics of `static` on `__constant__`, > `__device__`, and `__shared__`? > > - My understanding is that `__shared__` behaves the same whether or not it's > static.

[PATCH] D88431: [clangd] Rename evaluate() to evaluateHeuristics()

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b1666f3ce2b: [clangd] Rename evaluate() to evaluateHeuristics() (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88431/new/

[clang-tools-extra] 9b1666f - [clangd] Rename evaluate() to evaluateHeuristics()

Author: Utkarsh Saxena Date: 2020-09-28T20:05:01+02:00 New Revision: 9b1666f3ce2b02be70f8e7f82c3ec5c81262010b URL: https://github.com/llvm/llvm-project/commit/9b1666f3ce2b02be70f8e7f82c3ec5c81262010b DIFF:

[PATCH] D77062: [analyzer] Improve zero assumption in CStringChecke::assumeZero

NoQ added a comment. Nice, very interesting! The contract of RegionStore with respect to type punning is that it stores the value //as written//, even if its type doesn't match the storage type, but then it casts the value to the correct type upon reading by invoking `CastRetrievedVal()` on

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

jlebar added a comment. OK, backing up, what are the semantics of `static` on `__constant__`, `__device__`, and `__shared__`? - My understanding is that `__shared__` behaves the same whether or not it's static. It's not equivalent to `namespace a { __shared__ int c = 4; }`, because that's

[PATCH] D88434: [clangd] Improve PopulateSwitch tweak to work on non-empty switches

tdeo created this revision. tdeo added a reviewer: sammccall. tdeo added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. tdeo requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov.

[PATCH] D87648: [Coverage][NFC] Remove skipped region after added into MappingRegions

zequanwu abandoned this revision. zequanwu added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:353 +SkippedRanges.erase( +std::remove_if( +SkippedRanges.begin(), SkippedRanges.end(), vsk wrote: > In the worst case,

[PATCH] D77062: [analyzer] Improve zero assumption in CStringChecke::assumeZero

ASDenysPetrov added a comment. @steakhal > If we get the value of `**b`, we get a //NonLoc// of type //unsigned char//. > The dump of `**b` confirms this: `reg_$4 Element{SymRegion{reg_$0},0 S64b,unsigned char}>`, which is a > `NonLoc` in deed. Exactly. That's what I've been trying to explaine

[PATCH] D88425: Skip -fPIE for AMDGPU and HIP toolchain

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-fpie-option.hip:34 + +// DEV-DAG: {{".*clang.*".* "-triple" "amdgcn-amd-amdhsa".* "-mrelocation-model" "pic" "-pic-level" "[1|2]" "-mframe-pointer=all"}} +//

[PATCH] D88431: [clangd] Rename evaluate() to evaluateHeuristics()

adamcz accepted this revision. adamcz added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88431/new/ https://reviews.llvm.org/D88431

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1964 for (StringRef Candidate : CandidateBiarchTripleAliases) ScanLibDirForGCCTriple(TargetTriple, Args, LibDir, Candidate, /*NeedsBiarchSuffix=*/

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2469 } Suffixes[] = { - // This is the normal place. - {"gcc/" + CandidateTriple.str(), "../..", true}, + // This is the normal place if Clang is installed alongside with GCC, +

[PATCH] D88431: [clangd] Rename evaluate() to evaluateHeuristics()

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Since we have 2 scoring functions (heuristics and decision forest), renaming

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 added a comment. This currently fails some Clang tests because of an error with how `size_t` is handled by Clang versus OMPKinds.def. The compiler will crash when generating code for a 32 bit device on a 64 bit host because Clang uses the `size_t` from the host while OMPKinds.def uses

[PATCH] D88424: [clang][codegen] Remove the insertion of `correctly-rounded-divide-sqrt-fp-math` fn-attr.

bader added a comment. You might need add [OpenCL] tag to the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88424/new/ https://reviews.llvm.org/D88424 ___ cfe-commits mailing list

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

kiranchandramohan added a subscriber: rovka. kiranchandramohan added a comment. In D87774#2298515 , @awarzynski wrote: > In D87774#2293283 , @sameeranjoshi > wrote: > >> Do you know if there are any bots

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. jhuber6 added projects: OpenMP, LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, guansong, yaxunl. jhuber6 requested review of this revision. Herald added a subscriber: sstefan1. Replace the OpenMP Runtime

[PATCH] D88424: [clang][codegen] Remove the insertion of `correctly-rounded-divide-sqrt-fp-math` fn-attr.

hliao updated this revision to Diff 294745. hliao added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88424/new/ https://reviews.llvm.org/D88424 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGenOpenCL/amdgpu-attrs.cl

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski updated this revision to Diff 294740. awarzynski marked an inline comment as done. awarzynski added a comment. Address the remaining PR comments, fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/

  1   2   >