[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2901 + // Skip the declaration if injected type is already set. + if (isa(RI->getTypeForDecl())) +continue; shafik wrote: > Is this to fix the bug or is this

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added a comment. In D89490#2481306 , @rjmccall wrote: > I do feel like this is a terrible idea, sorry. It's a *very* niche use case > to be dedicating a new compiler feature to, and it's a feature that demands a > lot from the internal compiler

[PATCH] D94060: [OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function

This revision was automatically updated to reflect the committed changes. Closed by commit rG4909cb1a0fe9: [OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4909cb1 - [OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function

Author: Pushpinder Singh Date: 2021-01-06T02:03:30-05:00 New Revision: 4909cb1a0fe9f2494ccbadc2856b6ddfc70051b5 URL: https://github.com/llvm/llvm-project/commit/4909cb1a0fe9f2494ccbadc2856b6ddfc70051b5 DIFF:

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92812/new/ https://reviews.llvm.org/D92812

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2481304 , @tmsriram wrote: > In D93747#2481223 , @tmsriram wrote: > >> In D93747#2481163 , @dblaikie wrote: >> >>> In D93747#2481095

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

SouraVX accepted this revision. SouraVX added a comment. LGTM! - Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93301/new/ https://reviews.llvm.org/D93301 ___ cfe-commits mailing list

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

rjmccall added a comment. Are you committed to the name `__ibm128`? I think a name that says something about floating point would be better than just a company name and a number. "double double" is the common name for this format pretty much everywhere, and while I certainly would *not*

[PATCH] D89490: Introduce __attribute__((darwin_abi))

rjmccall added a comment. I do feel like this is a terrible idea, sorry. It's a *very* niche use case to be dedicating a new compiler feature to, and it's a feature that demands a lot from the internal compiler architecture in ways that other features don't. If you really need to build code

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2481223 , @tmsriram wrote: > In D93747#2481163 , @dblaikie wrote: > >> In D93747#2481095 , @hoy wrote: >> >>> In D93747#2481073

[PATCH] D88298: Fix MaterializeTemporaryExpr's type when its an incomplete array.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88298/new/ https://reviews.llvm.org/D88298 ___ cfe-commits mailing list

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

rjmccall added a comment. People can't actually just copy/paste from the comment anyway because of the comment characters on the line, and I don't think anyone will misunderstand the example if the backslash is missing. It's silly that GCC has a problem with this, but since it does, let's

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

rjmccall added a comment. Without bothering to look it up, I would guess that the attribute-parsing code used to generically handle the ambiguity between identifier expressions and identifier attribute arguments by just always parsing simple identifiers as identifier arguments, making it

[clang] a032a4e - [-Wcalled-once-parameter][NFC] Fix operator precedence warning

Author: Yang Fan Date: 2021-01-06T12:16:30+08:00 New Revision: a032a4e7998c9adc7faea9e7b8e36a9552d3503b URL: https://github.com/llvm/llvm-project/commit/a032a4e7998c9adc7faea9e7b8e36a9552d3503b DIFF: https://github.com/llvm/llvm-project/commit/a032a4e7998c9adc7faea9e7b8e36a9552d3503b.diff

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2481163 , @dblaikie wrote: > In D93747#2481095 , @hoy wrote: > >> In D93747#2481073 , @dblaikie wrote: >> >>> In D93747#2481053

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie added a comment. In D93747#2481095 , @hoy wrote: > In D93747#2481073 , @dblaikie wrote: > >> In D93747#2481053 , @tmsriram wrote: >> >>> In D93747#2480442

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2481073 , @dblaikie wrote: > In D93747#2481053 , @tmsriram wrote: > >> In D93747#2480442 , @dblaikie wrote: >> >>> @tmsriram - any ideas what

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie added a comment. In D93747#2481053 , @tmsriram wrote: > In D93747#2480442 , @dblaikie wrote: > >> @tmsriram - any ideas what your case/example was like that might've caused >> degraded debugging

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2481053 , @tmsriram wrote: > In D93747#2480442 , @dblaikie wrote: > In D93747#2470178 , @tmsriram wrote: > In

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

This revision was automatically updated to reflect the committed changes. Closed by commit rG74f93bc373d0: [Sema] Fix deleted function problem in implicitly movable test (authored by nullptr.cpp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 74f93bc - [Sema] Fix deleted function problem in implicitly movable test

Author: Yang Fan Date: 2021-01-06T10:05:40+08:00 New Revision: 74f93bc373d089e757bb65cf8b30b63a4eae8b69 URL: https://github.com/llvm/llvm-project/commit/74f93bc373d089e757bb65cf8b30b63a4eae8b69 DIFF: https://github.com/llvm/llvm-project/commit/74f93bc373d089e757bb65cf8b30b63a4eae8b69.diff

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2480442 , @dblaikie wrote: >>> In D93747#2470178 , @tmsriram >>> wrote: >>> In D93747#2469556 , @hoy wrote: >> In D93656

[PATCH] D78058: option to write files to memory instead of disk

dexonsmith added a comment. In D78058#2480411 , @dexonsmith wrote: > In D78058#2471735 , @sammccall wrote: > >> @dexonsmith thanks for sharing! >> Some initial thoughts since abstracting outputs is something we're

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

rnk added a comment. Reposting my comment here, since this is where the discussion was: I think this change broke -gline-tables-only functionality. I compared object files before and after this change. The new object file had a large .debug_loc section, which is only present when full debug

[PATCH] D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize

aprantl added a comment. this lgtm with all other reviewer's concerns addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91806/new/ https://reviews.llvm.org/D91806 ___ cfe-commits mailing list

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9670 Info.MapTypesArray, Info.MappersArray, Info, - {/*ForEndTask=*/false, HasDependClauses}); +

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

mikerice added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9670 Info.MapTypesArray, Info.MappersArray, Info, - {/*ForEndTask=*/false, HasDependClauses}); +

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

dblaikie added inline comments. Comment at: llvm/test/tools/llvm-cov/branch-noShowBranch.test:3 +// RUN: llvm-profdata merge %S/Inputs/branch-c-general.proftext -o %t.profdata +// RUN: llvm-cov show %S/Inputs/branch-c-general.o32l -instr-profile %t.profdata

[PATCH] D93772: [Clang][Driver] Fix read-after-free when using /clang:

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93772/new/ https://reviews.llvm.org/D93772 ___

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

alanphipps marked an inline comment as done. alanphipps added inline comments. Comment at: llvm/test/tools/llvm-cov/branch-noShowBranch.test:3 +// RUN: llvm-profdata merge %S/Inputs/branch-c-general.proftext -o %t.profdata +// RUN: llvm-cov show %S/Inputs/branch-c-general.o32l

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

dblaikie added inline comments. Comment at: llvm/test/tools/llvm-cov/branch-noShowBranch.test:3 +// RUN: llvm-profdata merge %S/Inputs/branch-c-general.proftext -o %t.profdata +// RUN: llvm-cov show %S/Inputs/branch-c-general.o32l -instr-profile %t.profdata

[PATCH] D36475: [analyzer] Add "create_sink" annotation support to MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D36251: [analyzer] Suppress warning when bug path contains noreturn function or return from main in MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D36024: [analyzer] Improved bug reporting in MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D36023: [analyzer] Add array support for MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D36022: [analyzer] Add handle misuse analysis to MagentaHandleChecker

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D35968: [analyzer] Add MagentaHandleChecker for the Magenta kernel

haowei abandoned this revision. haowei added a comment. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. An updated version was landed in f4c26d993bdc

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2901 + // Skip the declaration if injected type is already set. + if (isa(RI->getTypeForDecl())) +continue; Is this to fix the bug or is this for efficiency

[PATCH] D94131: [clang-tidy] Use new mapAnyOf matcher

steveire updated this revision to Diff 314739. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94131/new/ https://reviews.llvm.org/D94131 Files: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp

[PATCH] D94127: [ASTMatchers] Add mapAnyOf matcher

steveire added a comment. This is part of a series of commits. See them in context here: https://github.com/steveire/llvm-project/commits/mapAnyOf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94127/new/ https://reviews.llvm.org/D94127

[clang] b12e473 - Allow dependent alias template specializations in the preferred_name

Author: Richard Smith Date: 2021-01-05T15:33:51-08:00 New Revision: b12e4735317ec96e1b35deee68b90d62a23a9353 URL: https://github.com/llvm/llvm-project/commit/b12e4735317ec96e1b35deee68b90d62a23a9353 DIFF: https://github.com/llvm/llvm-project/commit/b12e4735317ec96e1b35deee68b90d62a23a9353.diff

[PATCH] D94131: [clang-tidy] Use new mapAnyOf matcher

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: kbarton, xazax.hun, nemanjai. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D94130: [ASTMatchers] Add support for CXXRewrittenBinaryOperator

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94130 Files:

[PATCH] D94129: [ASTMatchers] Add binaryOperation matcher

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a simple utility which allows matching on binaryOperator and cxxOperatorCallExpr. It can also be

[PATCH] D94128: [ASTMatchers] Make cxxOperatorCallExpr matchers API-compatible with n-ary operators

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes them composable with mapAnyOf(). Repository: rG LLVM Github Monorepo

[PATCH] D94127: [ASTMatchers] Add mapAnyOf matcher

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make it possible to compose a matcher for different base nodes. This accepts one or more node matcher

[PATCH] D94126: [ASTMatchers] Make it possible to use empty variadic matchers

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When debugging a matcher it is convenient to be able to comment out nested matchers experimentally. This

[PATCH] D92434: [NFC][AMDGPU] AMDGPU code object V4 ABI documentation

tra added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:959 + = = = + ``EF_AMDGPU_FEATURE_XNACK_V2``0x01 Indicates if the ``xnack`` +

[PATCH] D93763: [clangd] Add a flag to disable the documentLinks LSP request

rapgenic updated this revision to Diff 314718. rapgenic marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93763/new/ https://reviews.llvm.org/D93763 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/clangd/ClangdLSPServer.h

[PATCH] D93763: [clangd] Add a flag to disable the documentLinks LSP request

rapgenic marked 4 inline comments as done. rapgenic added a comment. > In the future it may make sense to have other documentLinks too. (e.g. > imagine a comment Configures the Frobnicator - we should linkify Frobnicator > to point to a class, once documentLink supports target ranges). So we

[clang] 16c6e9c - [ASTMatchers] Fix child traversal over range-for loops

Author: Stephen Kelly Date: 2021-01-05T21:29:37Z New Revision: 16c6e9c58e9ae50a775945e6b407f1891f353d2f URL: https://github.com/llvm/llvm-project/commit/16c6e9c58e9ae50a775945e6b407f1891f353d2f DIFF: https://github.com/llvm/llvm-project/commit/16c6e9c58e9ae50a775945e6b407f1891f353d2f.diff

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16c6e9c58e9a: [ASTMatchers] Fix child traversal over range-for loops (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie added a comment. >> In D93747#2470178 , @tmsriram wrote: >> >>> In D93747#2469556 , @hoy wrote: >>> > In D93656 , @dblaikie wrote: > Though the C case is interesting

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

GGanesh updated this revision to Diff 314703. GGanesh edited the summary of this revision. GGanesh added a comment. Updaing the patch so that the simplified patch adds only few missing znver3 tests. The subsequent patches will comprehensively enable other znver3 features. Repository: rG LLVM

[PATCH] D78058: option to write files to memory instead of disk

dexonsmith added a comment. In D78058#2471735 , @sammccall wrote: > @dexonsmith thanks for sharing! > Some initial thoughts since abstracting outputs is something we're starting > to care about too... Thanks for looking. > This doesn't appear to be an

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

tra added inline comments. Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:73-74 +#define __HOST_DEVICE__ \ + static __host__ __device__ inline __attribute__((always_inline)) +__HOST_DEVICE__ double

[PATCH] D77598: Integral template argument suffix and cast printing

rsmith added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:111-115 + Out << "u8'" << Val << "'"; +else if (T->isUnsignedIntegerType() && T->isChar16Type()) + Out << "u16'" << Val << "'"; +else if (T->isUnsignedIntegerType() &&

[clang] 2168942 - [Coverage] Fix Profile test failures from commit rG9f2967bcfe2f

Author: Alan Phipps Date: 2021-01-05T14:53:07-06:00 New Revision: 216894211713bbb1e8beb249f2b008c11a9d8c2c URL: https://github.com/llvm/llvm-project/commit/216894211713bbb1e8beb249f2b008c11a9d8c2c DIFF: https://github.com/llvm/llvm-project/commit/216894211713bbb1e8beb249f2b008c11a9d8c2c.diff

[PATCH] D93587: [hip] Fix HIP version parsing.

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:91 -void RocmInstallationDetector::ParseHIPVersionFile(llvm::StringRef V) { +bool RocmInstallationDetector::parseHIPVersionFile(llvm::StringRef V) { SmallVector VersionParts; A

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

yaxunl added inline comments. Comment at: clang/lib/Headers/cuda_wrappers/ymath.h:16 + +#pragma clang force_cuda_host_device begin + I am wondering whether we only want to do this for windows, since ymath.h may be an ordinary users' header file on linux.

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:245 +ScopedIncrement ScopedDepth(); +if (!match(*Node->getLoopVariable()) ||

[PATCH] D92954: [clang-offload-bundler] Add option -list

tra added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:176 + /// List bundle IDs in \a Input. + virtual Error listBundleIDs(MemoryBuffer ) { +if (Error Err = ReadHeader(Input)) Now that listBundleIDs is only used

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1221 +if (Style.EmptyLineBeforeAccessModifier && +PreviousLine->Last->isOneOf(tok::semi, tok::r_brace) && +RootToken.NewlinesBefore == 1)

[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

dblaikie added a comment. In D94019#2478431 , @aeubanks wrote: > In D94019#2478423 , @dblaikie wrote: > >> In D94019#2478378 , @aeubanks wrote: >> >>> Oh sorry, yeah this

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

thezbyg marked an inline comment as done. thezbyg added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1221 +if (Style.EmptyLineBeforeAccessModifier && +PreviousLine->Last->isOneOf(tok::semi, tok::r_brace) && +

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

dexonsmith added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:102-107 + std::string getMacroName() const { +if (KeyPath.startswith("DiagnosticOpts.")) + return (Twine("DIAG_") + MarshallingInfo::MacroName).str(); + +return

[clang] f88a797 - [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

Author: Atmn Patel Date: 2021-01-05T09:56:16-05:00 New Revision: f88a7975210fc995197af4b393e3bb5030e97a5c URL: https://github.com/llvm/llvm-project/commit/f88a7975210fc995197af4b393e3bb5030e97a5c DIFF: https://github.com/llvm/llvm-project/commit/f88a7975210fc995197af4b393e3bb5030e97a5c.diff

[PATCH] D93702: [clang][cli] NFC: Make marshalling macros reusable

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3040 -#define OPTION_WITH_MARSHALLING( \ -PREFIX_TYPE, NAME, ID, KIND, GROUP, ALIAS, ALIASARGS, FLAGS, PARAM, \ -HELPTEXT,

[PATCH] D93701: [clang][cli] NFC: Make Diags optional in normalizer

dexonsmith added a comment. In D93701#2477239 , @jansvoboda11 wrote: > This will make more sense after looking at D84673 > . In short: parsing of diagnostic options > can happen outside of

[clang] 16f3401 - [Coverage] Fix test failures from commit rG9f2967bcfe2f

Author: Alan Phipps Date: 2021-01-05T13:35:52-06:00 New Revision: 16f3401eae4310c95163269c41d9b45261f0c7c3 URL: https://github.com/llvm/llvm-project/commit/16f3401eae4310c95163269c41d9b45261f0c7c3 DIFF: https://github.com/llvm/llvm-project/commit/16f3401eae4310c95163269c41d9b45261f0c7c3.diff

[PATCH] D93883: [WebAssembly] Prototype prefetch instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG497026c90233: [WebAssembly] Prototype prefetch instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 497026c - [WebAssembly] Prototype prefetch instructions

Author: Thomas Lively Date: 2021-01-05T11:32:03-08:00 New Revision: 497026c90233e82ffd3ce2438c5f9567be6dabe7 URL: https://github.com/llvm/llvm-project/commit/497026c90233e82ffd3ce2438c5f9567be6dabe7 DIFF: https://github.com/llvm/llvm-project/commit/497026c90233e82ffd3ce2438c5f9567be6dabe7.diff

[PATCH] D93701: [clang][cli] NFC: Make Diags optional in normalizer

dexonsmith added a comment. In D93701#2479574 , @jansvoboda11 wrote: > In D93701#2477239 , @jansvoboda11 > wrote: > >> Another solution would be to create a "dummy" `DiagnosticsEngine` for the >>

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

fhahn added a comment. Now that the test is fixed, this could be re-landed, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 ___ cfe-commits mailing list

[PATCH] D94101: [clang][cli] Specify correct integer width for -fbuild-session-timestamp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf111cf992df4: [clang][cli] Specify correct integer width for -fbuild-session-timestamp (authored by jansvoboda11). Repository: rG LLVM Github

[clang] f111cf9 - [clang][cli] Specify correct integer width for -fbuild-session-timestamp

Author: Jan Svoboda Date: 2021-01-05T20:10:07+01:00 New Revision: f111cf992df4ec00acfdd026eac12b36c3831999 URL: https://github.com/llvm/llvm-project/commit/f111cf992df4ec00acfdd026eac12b36c3831999 DIFF: https://github.com/llvm/llvm-project/commit/f111cf992df4ec00acfdd026eac12b36c3831999.diff

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. In D93630#2479757 , @aaron.ballman wrote: > In D93630#2479343 , @vsavchenko > wrote: > >> In D93630#2479260 , @aaron.ballman >> wrote: >> >>>

[PATCH] D94101: [clang][cli] Specify correct integer width for -fbuild-session-timestamp

jansvoboda11 created this revision. jansvoboda11 added a reviewer: arphaman. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes an issue where large integer values were rejected as

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

tlively added a comment. In the description I think "but LLVM does not have a way of that kind of behavior" is missing the word "modeling" => "but LLVM does not have a way of modeling that kind of behavior" Comment at: llvm/lib/CodeGen/WasmEHPrepare.cpp:374-375 + // be

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

steveire added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:245 +ScopedIncrement ScopedDepth(); +if (!match(*Node->getLoopVariable()) || !match(*Node->getRangeInit()) || +!match(*Node->getBody())) aaron.ballman wrote: >

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

steveire updated this revision to Diff 314654. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94031/new/ https://reviews.llvm.org/D94031 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp

[PATCH] D94038: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin

tlively accepted this revision. tlively added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:53 // throw / rethrow +// The immediate argument is an index to for a tag, which is 0 for C++. def

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:245 +ScopedIncrement ScopedDepth(); +if (!match(*Node->getLoopVariable()) || !match(*Node->getRangeInit()) || +!match(*Node->getBody())) steveire wrote: >

[PATCH] D93883: [WebAssembly] Prototype prefetch instructions

tlively added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:318 + Intrinsic<[], [llvm_ptr_ty], +[IntrInaccessibleMemOrArgMemOnly, IntrWillReturn, + ReadOnly>, NoCapture>], aheejin wrote: > It [[ >

[PATCH] D93883: [WebAssembly] Prototype prefetch instructions

tlively updated this revision to Diff 314647. tlively marked 3 inline comments as done. tlively added a comment. - Fix section headers in test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93883/new/ https://reviews.llvm.org/D93883 Files:

[PATCH] D93637: [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG675a2973ee77: [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s. (authored by ymandel). Repository: rG LLVM Github

[clang] 675a297 - [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s.

Author: Yitzhak Mandelbaum Date: 2021-01-05T17:57:41Z New Revision: 675a2973ee7745d1859e3b72be40a803dd349e55 URL: https://github.com/llvm/llvm-project/commit/675a2973ee7745d1859e3b72be40a803dd349e55 DIFF: https://github.com/llvm/llvm-project/commit/675a2973ee7745d1859e3b72be40a803dd349e55.diff

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

steveire added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:245 +ScopedIncrement ScopedDepth(); +if (!match(*Node->getLoopVariable()) || !match(*Node->getRangeInit()) || +!match(*Node->getBody())) aaron.ballman wrote: >

[clang] f22c0f4 - [ASTMatchers] Omit methods from explicit template instantations

Author: Stephen Kelly Date: 2021-01-05T17:42:33Z New Revision: f22c0f40b5d657c0293fc9332274c18d3c4f836c URL: https://github.com/llvm/llvm-project/commit/f22c0f40b5d657c0293fc9332274c18d3c4f836c DIFF: https://github.com/llvm/llvm-project/commit/f22c0f40b5d657c0293fc9332274c18d3c4f836c.diff

[PATCH] D94032: [ASTMatchers] Omit methods from explicit template instantations

This revision was automatically updated to reflect the committed changes. Closed by commit rGf22c0f40b5d6: [ASTMatchers] Omit methods from explicit template instantations (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D94032?vs=314451=314643#toc Repository: rG

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

dmajor added a comment. I tried the updated patch against our build and it was successful. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936 ___

[PATCH] D94031: [ASTMatchers] Fix child traversal over range-for loops

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:245 +ScopedIncrement ScopedDepth(); +if (!match(*Node->getLoopVariable()) || !match(*Node->getRangeInit()) || +!match(*Node->getBody())) Should we be

[PATCH] D93354: [clang-tidy] Make clang-format and include-order-check coherent again

kadircet added a comment. i thought clang-format was also putting angled includes and "OtherHeaders" into same category, by looking at: LLVMStyle.IncludeStyle.IncludeCategories = { {"^\"(llvm|llvm-c|clang|clang-c)/", 2, 0, false}, {"^(<|\"(gtest|gmock|isl|json)/)", 3, 0,

[PATCH] D93637: [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s.

ymandel added a comment. In D93637#2479576 , @tdl-g wrote: > Ah, if it's just an optimization that makes sense. I still think it's worth > having a test case to confirm that one of the specially-handled cases works. Sure. I added one for unique

[PATCH] D93637: [libTooling] Add support for smart pointers to relevant Transformer `Stencil`s.

ymandel updated this revision to Diff 314642. ymandel marked an inline comment as done. ymandel added a comment. Added test for unique_ptr specifically. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93637/new/ https://reviews.llvm.org/D93637

[PATCH] D93385: [Driver][MachineOutliner] Support outlining option with LTO

paquette accepted this revision. paquette added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93385/new/ https://reviews.llvm.org/D93385

[PATCH] D93785: [OpenMP][FIX] Ensure the isa trait is evaluated last

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93785/new/ https://reviews.llvm.org/D93785

[PATCH] D94032: [ASTMatchers] Omit methods from explicit template instantations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a commenting nit. Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:2288-2289 // TODO: If we could match on explicit

[PATCH] D93483: Add element-type to the Vector TypeLoc types.

erichkeane added inline comments. Comment at: clang/include/clang/AST/TypeLoc.h:1756 + +class VectorTypeLoc : public ConcreteTypeLoc { fhahn wrote: > Can we reuse/unify this with `MatrixTypeLoc`? And then have `MatrixTypeLoc` > just deal with the row/column

[PATCH] D94098: [Clang] Inline assembly support for the ACLE type 'data512_t'.

labrinea created this revision. labrinea added reviewers: cfe-commits, t.p.northover, ab, kristof.beyls, simon_tatham. labrinea requested review of this revision. Herald added a project: clang. This patch emits the new LLVM IR type introduced in https://reviews.llvm.org/D94091 when generating

  1   2   3   >