[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

jwakely added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; hubert.reinterpretcast wrote: > qiucf wrote: > >

LLVM build master will be restarted soon

Hello everyone, LLVM buildmaster will be restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. @NoQ, sorry for the absurdly dumb mistake. Not entirely sure what I was thinking. Can you please have a look at it now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD updated this revision to Diff 330422. RedDocMD added a comment. Removed an embarassingly dumb mistake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 Files:

[PATCH] D98504: [clang][Checkers] Fix PthreadLockChecker state cleanup at dead symbol.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Hmm this probably even deserves a warning? Like, the mutex goes out of scope but we don't know whether we've successfully destroyed it? Even if we perform the check later, we can't do anything

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; qiucf wrote: > hubert.reinterpretcast wrote: > >

[PATCH] D98554: Save strings for CC_PRINT env vars

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Driver/Driver.h:160 /// The file to log CC_PRINT_PROC_STAT_FILE output to, if enabled. - const char *CCPrintStatReportFilename; + std::string CCPrintStatReportFilename; I'm

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0bf2da53c12b: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue (authored by xling-Liao xiangling.l...@ibm.com). Repository:

[clang] 0bf2da5 - [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

Author: xling-Liao Date: 2021-03-12T21:41:36-06:00 New Revision: 0bf2da53c12b3d2bf213f667af74059280a0d661 URL: https://github.com/llvm/llvm-project/commit/0bf2da53c12b3d2bf213f667af74059280a0d661 DIFF: https://github.com/llvm/llvm-project/commit/0bf2da53c12b3d2bf213f667af74059280a0d661.diff

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. Retained `using` declarations look fine. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98552/new/ https://reviews.llvm.org/D98552 ___ cfe-commits

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

MaskRay added a comment. > There are also going to be binaries in our system build that don't use foo.h > and ideally shouldn't have any overhead since nothing inside them is > instrumented (they should behave as if -fprofile-instr-generate wasn't set > for them at all). That's not the case

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

Xiangling_L updated this revision to Diff 330415. Xiangling_L added a comment. Bring back two forward declarations to avoid changing pervasive `SmallVector` to `llvm::SmallVector` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98552/new/ https://reviews.llvm.org/D98552 Files:

[PATCH] D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata

tianshilei1992 added inline comments. Comment at: llvm/lib/IR/AbstractCallSite.cpp:209 + +if (!GEP || !GEP->hasOneUse()) + return nullptr; If we don't use have a size, `GEP` will be `nullptr` here, and we can just return it. Repository: rG LLVM

[PATCH] D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata

tianshilei1992 added a comment. We probably don't need the index for `size_t size`. If the `ArgNo` is out of range, we simply return `nullptr`. Besides, CUDA function `cudaLaunchKernel` doesn't have an argument for size as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98134: [RFC] Introduce callback argument encoding mode into callback metadata

tianshilei1992 updated this revision to Diff 330414. tianshilei1992 added a comment. add the support for stacked mode in `AbstractCallSite::getCallArgOperand` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98134/new/ https://reviews.llvm.org/D98134

[PATCH] D98572: [Fuchsia] Add check-polly to CLANG_BOOTSTRAP_TARGETS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75cdeff43b2b: [Fuchsia] Add check-polly to CLANG_BOOTSTRAP_TARGETS (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 75cdeff - [Fuchsia] Add check-polly to CLANG_BOOTSTRAP_TARGETS

Author: Petr Hosek Date: 2021-03-12T18:31:20-08:00 New Revision: 75cdeff43b2b83baf643ccfd318f6669844fe370 URL: https://github.com/llvm/llvm-project/commit/75cdeff43b2b83baf643ccfd318f6669844fe370 DIFF: https://github.com/llvm/llvm-project/commit/75cdeff43b2b83baf643ccfd318f6669844fe370.diff

[PATCH] D98572: [Fuchsia] Add check-polly to CLANG_BOOTSTRAP_TARGETS

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98572/new/ https://reviews.llvm.org/D98572

[PATCH] D98572: [Fuchsia] Add check-polly to CLANG_BOOTSTRAP_TARGETS

phosek created this revision. phosek added a reviewer: leonardchan. Herald added a subscriber: mgorny. Herald added a reviewer: bollu. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is necessary so we can run Polly tests in 2

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem marked 7 inline comments as done. gulfem added inline comments. Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:384 + bool shouldBuildRelLookupTables() { +const TargetMachine = getTLI()->getTargetMachine(); leonardchan wrote: > Sorry, I think

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. In D89909#2623250 , @aaron.ballman wrote: > In D89909#2623211 , @Anastasia wrote: > >> In D89909#2617194 , @bader wrote: >> >>> @Anastasia, do

[clang] 1ce846b - Replace func name with regex for update test scripts

Author: Giorgis Georgakoudis Date: 2021-03-12T17:37:09-08:00 New Revision: 1ce846be04f8ce7f899e37424772c0bef1851f76 URL: https://github.com/llvm/llvm-project/commit/1ce846be04f8ce7f899e37424772c0bef1851f76 DIFF:

[PATCH] D97107: Replace func name with regex for update test scripts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ce846be04f8: Replace func name with regex for update test scripts (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D97107: Replace func name with regex for update test scripts

ggeorgakoudis updated this revision to Diff 330407. ggeorgakoudis added a comment. Fix for upstreaming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97107/new/ https://reviews.llvm.org/D97107 Files:

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem updated this revision to Diff 330405. gulfem added a comment. 1. Used IsConstantOffsetFromGlobal() function 2. Added this pass to the end of legacy pass manager pipeline 3. Moved all the tests under a new test directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9f9a4df - Revert "Replace func name with regex for update test scripts"

Author: Giorgis Georgakoudis Date: 2021-03-12T17:20:00-08:00 New Revision: 9f9a4dfda7348eddbc840ae558e7082677c3bab6 URL: https://github.com/llvm/llvm-project/commit/9f9a4dfda7348eddbc840ae558e7082677c3bab6 DIFF:

[PATCH] D97107: Replace func name with regex for update test scripts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5eaf70afb5f8: Replace func name with regex for update test scripts (authored by ggeorgakoudis). Changed prior to commit:

[clang] 5eaf70a - Replace func name with regex for update test scripts

Author: Giorgis Georgakoudis Date: 2021-03-12T17:00:42-08:00 New Revision: 5eaf70afb5f8ae6789587e60d51c60f56caf18b0 URL: https://github.com/llvm/llvm-project/commit/5eaf70afb5f8ae6789587e60d51c60f56caf18b0 DIFF:

[PATCH] D97107: Replace func name with regex in update_cc_test_checks

ggeorgakoudis updated this revision to Diff 330399. ggeorgakoudis added a comment. NFC change in update_llc_test_checks for compatibility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97107/new/ https://reviews.llvm.org/D97107 Files:

[PATCH] D98095: [clang] Fix ICE on invalid type parameters for concepts

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4a8c7359b57: [clang] Fix ICE on invalid type parameters for concepts (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98095/new/

[clang] d4a8c73 - [clang] Fix ICE on invalid type parameters for concepts

Author: Matheus Izvekov Date: 2021-03-13T01:23:02+01:00 New Revision: d4a8c7359b57bafc7bfa2a9dea30017fb0153c1a URL: https://github.com/llvm/llvm-project/commit/d4a8c7359b57bafc7bfa2a9dea30017fb0153c1a DIFF:

[PATCH] D98546: [PowerPC] Add __PCREL__ when PC Relative is enabled.

nemanjai added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98546/new/ https://reviews.llvm.org/D98546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97990: [clang] Improve diagnostics on implicitly deleted defaulted comparisons

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9fd92d57398: [clang] Improve diagnostics on implicitly deleted defaulted comparisons (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c9fd92d - [clang] Improve diagnostics on implicitly deleted defaulted comparisons

Author: Matheus Izvekov Date: 2021-03-13T01:13:52+01:00 New Revision: c9fd92d573988c59b7a613f07909596cdad36095 URL: https://github.com/llvm/llvm-project/commit/c9fd92d573988c59b7a613f07909596cdad36095 DIFF:

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

sgraenitz accepted this revision. sgraenitz added a comment. Thanks. From my side this looks good now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 ___ cfe-commits mailing list

[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

arlosi updated this revision to Diff 330386. arlosi marked an inline comment as done. arlosi added a comment. Use automatic marshaling for command line arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98438/new/

[PATCH] D97990: [clang] Improve diagnostics on implicitly deleted defaulted comparisons

mizvekov added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8968-8970 def note_defaulted_comparison_calls_deleted : Note< "defaulted %0 is implicitly deleted because it would invoke a deleted " "comparison function%select{| for member %2|

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

Xiangling_L added inline comments. Comment at: clang/include/clang/Basic/LLVM.h:71 using llvm::SmallString; - using llvm::SmallVector; - using llvm::SmallVectorImpl; It's my bad to not wait for a build finished before updating the patch, I saw a lot of

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/Interpreter.cpp:93 + "Initialization failed. " + "Unable to create diagnostics engine"); + sgraenitz wrote: > It looks like

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev updated this revision to Diff 330381. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Address comments -- rename test file; add a logging diagnostic consumer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

MaskRay added a comment. @tstellar :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97993/new/ https://reviews.llvm.org/D97993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. Thanks @Xiangling_L and also to the other reviewers for the great comments. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

Xiangling_L updated this revision to Diff 330369. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Herald added a subscriber: jansvoboda11. Addressed the comments; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98552/new/

[PATCH] D98556: [ASTMatchers][Dynamic] Add missing matchers from Registry

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, steveire. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add the `fixedPointLiteral`, `hasAnyBody` and `templateArgumentLoc` to the dynamic matcher

[PATCH] D98554: Save strings for CC_PRINT env vars

SeanP created this revision. SeanP added reviewers: hubert.reinterpretcast, uweigand, Kai. SeanP requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The contents of the string returned by getenv() is not guaranteed across calls to getenv().

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

Xiangling_L marked 2 inline comments as done. Xiangling_L added inline comments. Comment at: clang/include/clang/Basic/LLVM.h:25 #include "llvm/ADT/None.h" +// Add this header as a workaround to unblock the XL build compiler issue. +#include "llvm/ADT/SmallVector.h"

[PATCH] D97990: [clang] Improve diagnostics on implicitly deleted defaulted comparisons

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8968-8970 def note_defaulted_comparison_calls_deleted : Note< "defaulted %0 is implicitly deleted

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

Xiangling_L added a comment. In D98552#2623399 , @jsji wrote: > If we use this workaround, can we also revert > 561fb7f60ab631e712c3fb6bbeb47061222c6818 > and >

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

RKSimon added inline comments. Comment at: clang/include/clang/Basic/LLVM.h:25 #include "llvm/ADT/None.h" +// Add this header as a workaround to unblock the XL build compiler issue. +#include "llvm/ADT/SmallVector.h" Is there a better comment? "unblock the XL

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

jsji added a comment. If we use this workaround, can we also revert 561fb7f60ab631e712c3fb6bbeb47061222c6818 and 8dc70bdcd0fe4efb65876dce0144d9c3386a2f07

[PATCH] D98552: [NFC] Adjust SmallVector.h header to workaround XL build compiler issue

Xiangling_L created this revision. Xiangling_L added reviewers: rzurob, hubert.reinterpretcast, jsji, lei, cebowleratibm. Herald added a subscriber: dexonsmith. Xiangling_L requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously we

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 updated this revision to Diff 330352. jhuber6 added a comment. Herald added a subscriber: ormris. Changed the RTL to have an argument that indicates if there is only one active caller for a team. This makes it easier to optimize. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

curdeius added a comment. I'm missing tests with both EmptyLineBeforeAccessModifier and EmptyLine(s)AfterAccessModifier options. And possibly other options that could interfere with them. Comment at: clang/include/clang/Format/Format.h:1957 + /// Defines how many lines are

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra closed this revision. amilendra added a comment. Commited the fix to LLVM Release 12.x branch. Rendering looks okay this time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/ https://reviews.llvm.org/D98277

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

aaron.ballman added a comment. In D89909#2623211 , @Anastasia wrote: > In D89909#2617194 , @bader wrote: > >> @Anastasia, do you suggest we copy >>

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. In D97058#2623160 , @thakis wrote: > I'm going to revert this in 30 minutes. The tree has been red for 12h due to > this then. I have committed the fix mentioned above. Apology for the delay. Repository: rG LLVM Github

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

kristof.beyls accepted this revision. kristof.beyls added a comment. This revision is now accepted and ready to land. Still LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/ https://reviews.llvm.org/D98277

[PATCH] D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct

TaWeiTu added a comment. I'm not familiar with this code and clang/sema in general, so not sure if the fix makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98548/new/ https://reviews.llvm.org/D98548

[PATCH] D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct

TaWeiTu created this revision. TaWeiTu added reviewers: tmatheson, rsmith, dnsampaio. TaWeiTu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes https://bugs.llvm.org/show_bug.cgi?id=49534, where the call to the constructor of

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. In D89909#2617194 , @bader wrote: > In D89909#2606180 , @Anastasia wrote: > >> In D89909#2600859 , @aaron.ballman >> wrote: >> >>> Just a few

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7cd208f08af: [DebugInfo] Add an attribute to force type info to be emitted for types that… (authored by akhuang). Repository: rG LLVM Github

[clang] d7cd208 - [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

Author: Amy Huang Date: 2021-03-12T12:30:01-08:00 New Revision: d7cd208f08afca450484be97604a55704a628e88 URL: https://github.com/llvm/llvm-project/commit/d7cd208f08afca450484be97604a55704a628e88 DIFF: https://github.com/llvm/llvm-project/commit/d7cd208f08afca450484be97604a55704a628e88.diff

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra requested review of this revision. amilendra added a comment. Sorry for the back-and-forth. Requesting re-review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/ https://reviews.llvm.org/D98277

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra updated this revision to Diff 330345. amilendra added a comment. Add a newline before the sub-list to fix a rendering issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/ https://reviews.llvm.org/D98277 Files:

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 330344. akhuang added a comment. add allowInC to attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.llvm.org/D97411 Files: clang/include/clang/Basic/Attr.td

[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

Anastasia added a comment. In D98539#2623038 , @thakis wrote: > Can we get this landed asap please? Done! Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98539/new/

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

thakis added a comment. I'm going to revert this in 30 minutes. The tree has been red for 12h due to this then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97058/new/ https://reviews.llvm.org/D97058

[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeed88e91f331: [OpenCL] Use spir target for CIndex tests for OpenCL. (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] eed88e9 - [OpenCL] Use spir target for CIndex tests for OpenCL.

Author: Anastasia Stulova Date: 2021-03-12T20:11:26Z New Revision: eed88e91f331d158d3d0c91e91fca408c9f1d1e1 URL: https://github.com/llvm/llvm-project/commit/eed88e91f331d158d3d0c91e91fca408c9f1d1e1 DIFF: https://github.com/llvm/llvm-project/commit/eed88e91f331d158d3d0c91e91fca408c9f1d1e1.diff

[PATCH] D98546: [PowerPC] Add __PCREL__ when PC Relative is enabled.

stefanp created this revision. stefanp added a reviewer: nemanjai. Herald added subscribers: shchenz, kbarton. stefanp requested review of this revision. Herald added a project: clang. This patch adds the __PCREL__ define when PC Relative addressing is enabled. Repository: rG LLVM Github

[clang] 42eb658 - [OpaquePtrs] Remove some uses of type-less CreateGEP() (NFC)

Author: Nikita Popov Date: 2021-03-12T21:01:16+01:00 New Revision: 42eb658f656c43ee63e25222f32acb86ad7b URL: https://github.com/llvm/llvm-project/commit/42eb658f656c43ee63e25222f32acb86ad7b DIFF: https://github.com/llvm/llvm-project/commit/42eb658f656c43ee63e25222f32acb86ad7b.diff

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 330337. arnamoy10 edited the summary of this revision. arnamoy10 added a comment. Update the path based on the patch D98522 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080

[PATCH] D98457: [WebAssembly] Remove unimplemented-simd target features

tlively added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:3801 Pass -z to the linker - dschuff wrote: > extraneous change? Yes, will revert, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98457: [WebAssembly] Remove unimplemented-simd target features

tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:191 -TARGET_BUILTIN(__builtin_wasm_qfma_f32x4, "V4fV4fV4fV4f", "nc", "unimplemented-simd128") -TARGET_BUILTIN(__builtin_wasm_qfms_f32x4, "V4fV4fV4fV4f", "nc",

[PATCH] D98504: [clang][Checkers] Fix PthreadLockChecker state cleanup at dead symbol.

ASDenysPetrov added a comment. Hi, @balazske Comment at: clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:290-304 // Existence in DestroyRetVal ensures existence in LockMap. // Existence in Destroyed also ensures that the lock state for lockR is either //

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra reopened this revision. amilendra added a comment. This revision is now accepted and ready to land. Reopening to add a missing empty line before starting the level-2 list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/

[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

thakis added a comment. Can we get this landed asap please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98539/new/ https://reviews.llvm.org/D98539 ___ cfe-commits mailing list

[clang] d7b7e20 - Revert "[Clang][ARM] Reenable arm_acle.c test."

Author: Nico Weber Date: 2021-03-12T14:37:37-05:00 New Revision: d7b7e2026b0a8b575df9ee7c4042ecff450f6549 URL: https://github.com/llvm/llvm-project/commit/d7b7e2026b0a8b575df9ee7c4042ecff450f6549 DIFF: https://github.com/llvm/llvm-project/commit/d7b7e2026b0a8b575df9ee7c4042ecff450f6549.diff

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra closed this revision. amilendra added a comment. Commited to LLVM Release 12.x branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/ https://reviews.llvm.org/D98277 ___ cfe-commits

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang updated this revision to Diff 330316. akhuang added a comment. Herald added a subscriber: jdoerfert. update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97411/new/ https://reviews.llvm.org/D97411 Files:

[clang] 5ae949a - [Clang][ARM] Reenable arm_acle.c test.

Author: David Green Date: 2021-03-12T19:21:21Z New Revision: 5ae949a9276542b46f41374fbe7aee01e480d9d6 URL: https://github.com/llvm/llvm-project/commit/5ae949a9276542b46f41374fbe7aee01e480d9d6 DIFF: https://github.com/llvm/llvm-project/commit/5ae949a9276542b46f41374fbe7aee01e480d9d6.diff LOG:

[PATCH] D98466: [WebAssembly] Remove experimental SIMD instructions

dschuff accepted this revision. dschuff added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:191 -TARGET_BUILTIN(__builtin_wasm_qfma_f32x4, "V4fV4fV4fV4f", "nc", "simd128")

[PATCH] D98457: [WebAssembly] Remove unimplemented-simd target features

dschuff accepted this revision. dschuff added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/ClangCommandLineReference.rst:3801 Pass -z to the linker - extraneous change? Comment at:

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. In D97058#2622883 , @azabaznov wrote: > Yes, I was able to reproduce the failure with `-target arm64-apple-macosx` > flag, I provided the fix to set explicit target: > https://reviews.llvm.org/D98539. I have approved it.

[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! I can't see why we would need to tests anything target-specific here anyway, so I think the change is reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov added a comment. Yes, I was able to reproduce the failure with `-target arm64-apple-macosx` flag, I provided the fix to set explicit target: https://reviews.llvm.org/D98539. @Anastasia, I tried to cherry-pick https://reviews.llvm.org/D92244, but the error is still reproducible.

[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh, thakis. Herald added subscribers: arphaman, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Otherwise (for other targets) testing may be

[PATCH] D98538: [clangd] Perform merging for stale symbols in MergeIndex

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Clangd drops symbols from static index

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD added a comment. In D96976#2622342 , @steakhal wrote: > I'm somewhat busy. If it's not urgent, I would postpone this. > Ping me in a few weeks. Sure ok. Is it okay if I tell someone else to take a look at this in the meanwhile? Repository:

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. I can't find why and how `opencl-c-base.h` is used for the test. But it feels it is adding the random noise to the testing as it is not expected to be used. I don't feel that this commit is affecting the header though, so it is something that might have already been

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. In D97058#2622750 , @Anastasia wrote: > In D97058#2622717 , @thakis wrote: > >> In case it's useful, here's the output of the RUN line on an m1 mac with >> this patch locally reverted

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. In D97058#2622717 , @thakis wrote: > In case it's useful, here's the output of the RUN line on an m1 mac with this > patch locally reverted (where the test passes): > http://pastie.org/p/2F3Y0xUMtH5RP9TVRzG4LI Thanks, this

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

thakis added a comment. In case it's useful, here's the output of the RUN line on an m1 mac with this patch locally reverted (where the test passes): http://pastie.org/p/2F3Y0xUMtH5RP9TVRzG4LI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. > (The `fatal error: 'opencl-c-base.h' file not found` bit is printed when the > test passes too, and is unrelated.) I can't reproduce this locally neither with nor without this commit. I think there is something wrong with the way this test runs, this might

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov added a comment. Thanks guys, I'm on way to trying that, just building clang from scratch. >   If it is, then just adding a fixed triple is fine. Yeah, it is expected as this change removes types which require extension from parsers state. X86 and SPIR support all extensions by

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. In D97058#2622681 , @svenvh wrote: > In D97058#2622669 , @thakis wrote: > >> Does it repro if you add `-target arm64-apple-macosx` as arg to c-index-test >> on the RUN line of that test?

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

thakis added a comment. It repros for me with this local diff % git diff diff --git a/clang/test/Index/opencl-types.cl b/clang/test/Index/opencl-types.cl index 496f38752fa2..13f6058864b5 100644 --- a/clang/test/Index/opencl-types.cl +++ b/clang/test/Index/opencl-types.cl @@ -1,4

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

svenvh added a comment. In D97058#2622669 , @thakis wrote: > Does it repro if you add `-target arm64-apple-macosx` as arg to c-index-test > on the RUN line of that test? I also had trouble reproducing the failure locally, but by specifying this target

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

thakis added a comment. Does it repro if you add `-target arm64-apple-macosx` as arg to c-index-test on the RUN line of that test? Here's the output of that RUN line on an arm mac when the test fails: http://pastie.org/p/1go1Y9WXjs5T371RtyJ3Gi Let's revert for now, things have been broken for

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov added a comment. Hi! Yeah,  I'm looking into it, but I can't reproduce it locally: the test passes at x86_64 linux system. I'll revert the change if it takes too much time to investigate what's going on. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >