[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf added inline comments. Comment at: clang/bindings/python/clang/cindex.py:2061-2062 TypeKind.FLOAT128 = TypeKind(30) TypeKind.HALF = TypeKind(31) +TypeKind.IBM128 = TypeKind(32) TypeKind.COMPLEX = TypeKind(100) hubert.reinterpretcast wrote: > This looks

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf updated this revision to Diff 330560. qiucf marked an inline comment as done. qiucf added a comment. Update cindex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 Files:

[PATCH] D98616: [RISCV] Add inline asm constraint 'v' in Clang for RISC-V 'V'.

jrtc27 added a comment. This seems like the obvious choice for the constraint, but it would be good to ensure there's consensus with GCC people, especially since their assembly constraints are intimately tied to their instruction patterns (or, really, the assembly constraints just expose those

[PATCH] D98616: [RISCV] Add inline asm constraint 'v' in Clang for RISC-V 'V'.

HsiangKai created this revision. HsiangKai added reviewers: craig.topper, frasercrmck, rogfer01. Herald added subscribers: StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrtc27,

[PATCH] D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'

luismarques added inline comments. Comment at: llvm/test/CodeGen/RISCV/patchable-function-entry.ll:1-3 +;; Test the function attribute "patchable-function-entry". +; RUN: llc -mtriple=riscv32 < %s | FileCheck %s --check-prefixes=CHECK,32 +; RUN: llc -mtriple=riscv64 < %s |

[PATCH] D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:53 +void RISCVInstrInfo::getNoop(MCInst ) const { + if (STI.getFeatureBits()[RISCV::FeatureStdExtC]) I will forever wonder why TII didn't make it `MCInst getNoop()`...

[PATCH] D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'

MaskRay updated this revision to Diff 330548. MaskRay added a comment. fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98610/new/ https://reviews.llvm.org/D98610 Files: clang/include/clang/Basic/Attr.td

[clang] 6e303a9 - Revert "[AST] Add generator for source location introspection"

Author: Stephen Kelly Date: 2021-03-15T01:16:10Z New Revision: 6e303a982d6ce5a281ba95238ed376a2caf27a52 URL: https://github.com/llvm/llvm-project/commit/6e303a982d6ce5a281ba95238ed376a2caf27a52 DIFF: https://github.com/llvm/llvm-project/commit/6e303a982d6ce5a281ba95238ed376a2caf27a52.diff

[clang] 370b9b4 - Revert "Attempt to fix ARM buildbot"

Author: Stephen Kelly Date: 2021-03-15T01:16:07Z New Revision: 370b9b4aea5fe1c9ca25e4c00f104eba75ac5c7b URL: https://github.com/llvm/llvm-project/commit/370b9b4aea5fe1c9ca25e4c00f104eba75ac5c7b DIFF: https://github.com/llvm/llvm-project/commit/370b9b4aea5fe1c9ca25e4c00f104eba75ac5c7b.diff

[PATCH] D98594: [clang/docs/LibASTMatchersTutorial.rst,clang/docs/HowToSetupToolingForLLVM.rst] ninja now uses `configure.py` rather than `bootstrap.py`

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, use `[Docs]` as tag for the commit, it should not be verbose but helpful to determine if a commit is interesting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98594/new/

[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

luismarques added a comment. This patch seems to be in pretty good shape now. One thing that might be useful (important?) to add is additional diagnostics when run in verbose mode. Currently `clang -v` will indicate that it found the GCC installation and will list the multilibs but there will

[clang] 12dac66 - Attempt to fix ARM buildbot

Author: Stephen Kelly Date: 2021-03-15T00:20:39Z New Revision: 12dac66f6b33dd14b72076800726817f682ab785 URL: https://github.com/llvm/llvm-project/commit/12dac66f6b33dd14b72076800726817f682ab785 DIFF: https://github.com/llvm/llvm-project/commit/12dac66f6b33dd14b72076800726817f682ab785.diff

[clang] 91abaa1 - [AST] Add generator for source location introspection

Author: Stephen Kelly Date: 2021-03-15T00:00:29Z New Revision: 91abaa1f8d97e8efa249c31686fd643ff5f1e2c2 URL: https://github.com/llvm/llvm-project/commit/91abaa1f8d97e8efa249c31686fd643ff5f1e2c2 DIFF: https://github.com/llvm/llvm-project/commit/91abaa1f8d97e8efa249c31686fd643ff5f1e2c2.diff

[clang] e312b4b - Revert "[AST] Add generator for source location introspection"

Author: Stephen Kelly Date: 2021-03-14T22:51:45Z New Revision: e312b4b6c74d455ba8193f46d7f0f8f1c8ac4757 URL: https://github.com/llvm/llvm-project/commit/e312b4b6c74d455ba8193f46d7f0f8f1c8ac4757 DIFF: https://github.com/llvm/llvm-project/commit/e312b4b6c74d455ba8193f46d7f0f8f1c8ac4757.diff

[clang] 9249861 - Revert "Ensure that cache variable is set when not building introspection"

Author: Stephen Kelly Date: 2021-03-14T22:51:40Z New Revision: 9249861437c0355c79c27c86229b9b92cd8eea5f URL: https://github.com/llvm/llvm-project/commit/9249861437c0355c79c27c86229b9b92cd8eea5f DIFF: https://github.com/llvm/llvm-project/commit/9249861437c0355c79c27c86229b9b92cd8eea5f.diff

[clang] 6b010c6 - Ensure that cache variable is set when not building introspection

Author: Stephen Kelly Date: 2021-03-14T22:46:07Z New Revision: 6b010c6f6e354966569e02841180c77df45bbd76 URL: https://github.com/llvm/llvm-project/commit/6b010c6f6e354966569e02841180c77df45bbd76 DIFF: https://github.com/llvm/llvm-project/commit/6b010c6f6e354966569e02841180c77df45bbd76.diff

[PATCH] D93164: [AST] Add generator for source location introspection

This revision was automatically updated to reflect the committed changes. Closed by commit rG477e4b974653: [AST] Add generator for source location introspection (authored by stephenkelly). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang] 477e4b9 - [AST] Add generator for source location introspection

Author: Stephen Kelly Date: 2021-03-14T22:32:42Z New Revision: 477e4b974653f92960c0bf569d88da7baacef68a URL: https://github.com/llvm/llvm-project/commit/477e4b974653f92960c0bf569d88da7baacef68a DIFF: https://github.com/llvm/llvm-project/commit/477e4b974653f92960c0bf569d88da7baacef68a.diff

[PATCH] D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. Overall LGTM. I just don't understand what you mean with "1-byte NOPs" in the patchable prefix case. Regular NOPs are emitted. Please clarify the comment/patch as needed.

[PATCH] D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'

MaskRay created this revision. MaskRay added reviewers: asb, craig.topper, HsiangKai, khchen. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

ggeorgakoudis added a comment. In D91556#2620928 , @jdoerfert wrote: > In D91556#2617144 , > @kiranchandramohan wrote: > >> Ping @llitchev. Would you have time to take this forward? > > I think @ggeorgakoudis is

[PATCH] D93164: [AST] Add generator for source location introspection

njames93 added a comment. It may be wise to alter this so there is no need for the python script. How about altering the dump tool to support outputting both json files and the cpp code needed for node introspection. Maybe have arguments to the tool `--json-output-path` and

[PATCH] D93164: [AST] Add generator for source location introspection

arichardson added inline comments. Comment at: clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py:1 +#!/usr/bin/python +# -*- coding: utf-8 -*- Maybe this should be `#!/use/bin/env python` (or python3) instead? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D93164: [AST] Add generator for source location introspection

nikic added a comment. @steveire When running the command manually I get: /root/llvm-compile-time-tracker/llvm-project/clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py --json-input-path /root/llvm-compile-time-tracker/llvm-project-build/ASTNodeAPI.json --output-file

[PATCH] D93164: [AST] Add generator for source location introspection

steveire added a comment. In D93164#2624798 , @nikic wrote: > Reverted in > https://github.com/llvm/llvm-project/commit/e0f70a8a979f5b843e90a0a20442ca79e2507208 > due to build failure. @nikic How do I run a test build on that machine? Or can you

[PATCH] D94741: [Utils] Check for more global information in update_test_checks

jdoerfert added a comment. In D94741#2624475 , @nikic wrote: > It looks like this has broken handling of `getelementptr %T`, and generates > `getelementptr [[T]]` for it now, see e.g. the first change in >

[PATCH] D93164: [AST] Add generator for source location introspection

steveire added a comment. In D93164#2624798 , @nikic wrote: > Reverted in > https://github.com/llvm/llvm-project/commit/e0f70a8a979f5b843e90a0a20442ca79e2507208 > due to build failure. Was the problem there just the shebang line? Repository: rG

[PATCH] D93164: [AST] Add generator for source location introspection

nikic reopened this revision. nikic added a comment. This revision is now accepted and ready to land. Reverted in https://github.com/llvm/llvm-project/commit/e0f70a8a979f5b843e90a0a20442ca79e2507208 due to build failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e0f70a8 - Revert "[AST] Add generator for source location introspection"

Author: Nikita Popov Date: 2021-03-14T17:05:08+01:00 New Revision: e0f70a8a979f5b843e90a0a20442ca79e2507208 URL: https://github.com/llvm/llvm-project/commit/e0f70a8a979f5b843e90a0a20442ca79e2507208 DIFF: https://github.com/llvm/llvm-project/commit/e0f70a8a979f5b843e90a0a20442ca79e2507208.diff

[PATCH] D93164: [AST] Add generator for source location introspection

steveire added a comment. In D93164#2624760 , @dmgreen wrote: > Hello. Does this work when the default target triple isn't native? This seems > to be trying to compile clang sources with the just built clang - something > that I don't think is always

[clang] cefe711 - Fix license headers

Author: Stephen Kelly Date: 2021-03-14T15:45:53Z New Revision: cefe711135c40b6fb9670cf92118f94f88964b23 URL: https://github.com/llvm/llvm-project/commit/cefe711135c40b6fb9670cf92118f94f88964b23 DIFF: https://github.com/llvm/llvm-project/commit/cefe711135c40b6fb9670cf92118f94f88964b23.diff

[PATCH] D93164: [AST] Add generator for source location introspection

steveire added a comment. In D93164#2624690 , @thakis wrote: > A few more high-level questions: > > - What's the point of the intermediary json file? Why not generate the final > c++ directly? (As far as I can tell, this wasn't discussed during the

[clang] 970c21e - Remove unneeded targets dependency

Author: Stephen Kelly Date: 2021-03-14T15:37:30Z New Revision: 970c21e345548a967c1bc000462198330982ed7e URL: https://github.com/llvm/llvm-project/commit/970c21e345548a967c1bc000462198330982ed7e DIFF: https://github.com/llvm/llvm-project/commit/970c21e345548a967c1bc000462198330982ed7e.diff

[clang] f72f122 - Update python script per review comments

Author: Stephen Kelly Date: 2021-03-14T15:37:30Z New Revision: f72f122feebe7f980c22ed4a7e04fc274ce2c976 URL: https://github.com/llvm/llvm-project/commit/f72f122feebe7f980c22ed4a7e04fc274ce2c976 DIFF: https://github.com/llvm/llvm-project/commit/f72f122feebe7f980c22ed4a7e04fc274ce2c976.diff

[PATCH] D93164: [AST] Add generator for source location introspection

dmgreen added a comment. Hello. Does this work when the default target triple isn't native? This seems to be trying to compile clang sources with the just built clang - something that I don't think is always possible. I'm seeing errors like `fatal error: 'cstddef' file not found`, and failing

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

njames93 updated this revision to Diff 330511. njames93 added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97121/new/ https://reviews.llvm.org/D97121 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.h

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

njames93 marked 6 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:217 bool AllowEnablingAnalyzerAlphaCheckers; + bool SelfContainedDiags; }; steveire wrote: > The order of

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/bindings/python/clang/cindex.py:2061-2062 TypeKind.FLOAT128 = TypeKind(30) TypeKind.HALF = TypeKind(31) +TypeKind.IBM128 = TypeKind(32) TypeKind.COMPLEX = TypeKind(100) This looks suspiciously

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

steveire added inline comments. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:178 + void setSelfContainedDiags(bool Value = true) { SelfContainedDiags = Value; } +

[PATCH] D93164: [AST] Add generator for source location introspection

thakis added a subscriber: rsmith. thakis added a comment. A few more high-level questions: - What's the point of the intermediary json file? Why not generate the final c++ directly? (As far as I can tell, this wasn't discussed during the review yet) - Do we need to generate code for this at

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. Herald added projects: LLVM, clang-tools-extra. Herald added a subscriber: llvm-commits. Is DAG required because the header file warnings are printed in a different order depending on

[PATCH] D98510: [Clang][ARM] Reenable arm_acle.c test.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b3c81314343: [Clang][ARM] Reenable arm_acle.c test. (authored by dmgreen). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] 2b3c813 - [Clang][ARM] Reenable arm_acle.c test.

Author: David Green Date: 2021-03-14T10:59:24Z New Revision: 2b3c8131434374caf3825c2bd4e012c85f8128de URL: https://github.com/llvm/llvm-project/commit/2b3c8131434374caf3825c2bd4e012c85f8128de DIFF: https://github.com/llvm/llvm-project/commit/2b3c8131434374caf3825c2bd4e012c85f8128de.diff LOG:

[clang] 77f7d2b - [AST] Add generator for source location introspection

Author: Stephen Kelly Date: 2021-03-14T10:54:33Z New Revision: 77f7d2be214a1de29d583c75739f563593991fc3 URL: https://github.com/llvm/llvm-project/commit/77f7d2be214a1de29d583c75739f563593991fc3 DIFF: https://github.com/llvm/llvm-project/commit/77f7d2be214a1de29d583c75739f563593991fc3.diff