[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

dyung added a comment. The test added in this commit was failing on the PS4 bot (https://lab.llvm.org/buildbot/#/builders/139/builds/4059). I've reverted the change in 59b419adc6e608db8d7c31efcc37f34c0b57b7d0 to get the bot

[clang] 59b419a - Revert "[Clang,Driver] Add -fveclib=Darwin_libsystem_m support."

Author: Douglas Yung Date: 2021-05-14T22:39:12-07:00 New Revision: 59b419adc6e608db8d7c31efcc37f34c0b57b7d0 URL: https://github.com/llvm/llvm-project/commit/59b419adc6e608db8d7c31efcc37f34c0b57b7d0 DIFF: https://github.com/llvm/llvm-project/commit/59b419adc6e608db8d7c31efcc37f34c0b57b7d0.diff

[PATCH] D102118: [BPF] add support for 32 bit registers in inline asm

alessandrod updated this revision to Diff 345599. alessandrod added a comment. Enable "w" constraint when -mcpu=v3 and fix whitespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102118/new/ https://reviews.llvm.org/D102118 Files:

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek added a comment. Ping, is this OK to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D101479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim created this revision. hctim added reviewers: cryptoad, pcc. Herald added subscribers: phosek, mgorny. hctim requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This patch moves -fsanitize=scudo to link the

[PATCH] D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`

mizvekov added a comment. In D100733#2761031 , @rsmith wrote: > What do we think about renaming `isRValue()` to `isPRValue()` and renaming > `VK_RValue` to `VK_PRValue`, adding a "real" `isRValue()`, and then > performing this cleanup? I think the

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 345587. nickdesaulniers added a comment. Herald added a subscriber: dang. - support up to +/- 4096 non-multiples of 8. We could get crazy with psuedo instructions and register scavenging, but this is really overkill; the very first case of positive

[PATCH] D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`

rsmith added a comment. I don't think out-of-tree experiments on possibilities for move semantics are especially motivating for this, one way or the other, but I do think it would be nice to make some kind of change here. What do we think about renaming `isRValue()` to `isPRValue()` and

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

dblaikie added a comment. In D102356#2761010 , @hoy wrote: > In D102356#2760973 , @dblaikie > wrote: > >> In D102356#2758371 , @hoy wrote: >> >>> In D102356#2758179

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

hoy added a comment. In D102356#2760973 , @dblaikie wrote: > In D102356#2758371 , @hoy wrote: > >> In D102356#2758179 , @dblaikie >> wrote: >> >>> This was previously

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

danlark added a comment. Failure looks unrelated, please submit on your behalf as I don't have commit rights Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

dblaikie added a comment. In D102356#2758371 , @hoy wrote: > In D102356#2758179 , @dblaikie > wrote: > >> This was previously crashing, I guess? Testing should validate the behavior >> beyond the crash, though

[PATCH] D100671: [ADT] Factor out in_place_t and expose in Optional ctor

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good, thanks! Probably skip the other two in_place_* until we have a use for them. Comment at: llvm/include/llvm/ADT/STLForwardCompat.h:53-73 + +template +struct

[PATCH] D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`

mizvekov added a comment. In D100733#2759592 , @aaronpuchert wrote: > Not sure how to feel about this, the value categories are already hard to > grasp for most C++ programmers. To solve the implicit move concerns with a > new value category seems

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102015/new/ https://reviews.llvm.org/D102015

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:12579 Stmt *Body = nullptr; - SmallVector OriginalInits; + SmallVector>, 4> OriginalInits(1); if (!OMPLoopBasedDirective::doForAllLoops( ABataev wrote: > Why still

[PATCH] D100713: [clang] NFC: refactor usage of getDecltypeForParenthesizedExpr

mizvekov added a comment. In D100713#2759637 , @aaronpuchert wrote: > Again, I'm not sure if it helps to use `getDecltypeForParenthesizedExpr` > where we don't actually have the `decltype` of a parenthesized expression. > > It's probably not entirely

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

danlark updated this revision to Diff 345568. danlark added a comment. - Address comment from Richard Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502 Files: clang/lib/Parse/ParseExprCXX.cpp

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2036 FRI->LoopVar = Actions.ActOnDeclStmt(DG, DeclStart, Tok.getLocation()); +assert(FRI->ColonLoc.isValid() &&

[PATCH] D102306: Add gfx1034

tra added a comment. In D102306#2760775 , @msearles wrote: > In D102306#2758166 , > @JonChesterfield wrote: > >> Is there documentation for the mapping from product names to gfx numbers? > > See the Processors

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 345565. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[clang] e8448a5 - [NFC] Directly get GV type

Author: Arthur Eubanks Date: 2021-05-14T14:27:07-07:00 New Revision: e8448a598560a7a8546ddb74ec5979974b47ed41 URL: https://github.com/llvm/llvm-project/commit/e8448a598560a7a8546ddb74ec5979974b47ed41 DIFF:

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:12579 Stmt *Body = nullptr; - SmallVector OriginalInits; + SmallVector>, 4> OriginalInits(1); if (!OMPLoopBasedDirective::doForAllLoops( Why still `std::vector`? Repository: rG

[PATCH] D102306: Add gfx1034

msearles added a comment. In D102306#2758166 , @JonChesterfield wrote: > Is there documentation for the mapping from product names to gfx numbers? See the Processors section of https://llvm.org/docs/AMDGPUUsage.html Repository: rG LLVM Github

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

danlark added a comment. In D102502#2759900 , @rsmith wrote: > Thanks, nice catch! > > Can we also add an assert when parsing a `for` statement that we actually > find a range if the tentative parse said we were expecting one? Done. Repository: rG

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 345562. Meinersbur marked 2 inline comments as done. Meinersbur added a comment. - Rebase - Address review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180 Files:

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

danlark updated this revision to Diff 345561. danlark added a comment. - Add assert of finding a for range declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502 Files:

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 updated this revision to Diff 345557. jhuber6 edited the summary of this revision. jhuber6 added a comment. Splitting patches into D97680 and D102532 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

ychen created this revision. ychen added reviewers: rsmith, faisalv, aaron.ballman. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - `this` used in lambda expression parameter declarations needs no capture. - Set up CXXThisOverride

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

efriedma updated this revision to Diff 345543. efriedma added a comment. Figured out a way to test the EmitDelegateCallArg codepath. (A thunk doesn't work because the code is guarded by `!CurFuncIsThunk`.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

yaxunl added a comment. I think the root cause might be duplicated decls are added to Sema::DeclsToCheckForDeferredDiags defined in https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Sema/Sema.h#L1789 When compiling source codes, a decl is added only once. However if modules

[PATCH] D102489: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support.

This revision was automatically updated to reflect the committed changes. Closed by commit rG187a14e1f399: [Clang,Driver] Add -fveclib=Darwin_libsystem_m support. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102489/new/

[clang] 187a14e - [Clang, Driver] Add -fveclib=Darwin_libsystem_m support.

Author: Florian Hahn Date: 2021-05-14T21:00:13+01:00 New Revision: 187a14e1f39942545b905679a8452365dfd87af8 URL: https://github.com/llvm/llvm-project/commit/187a14e1f39942545b905679a8452365dfd87af8 DIFF: https://github.com/llvm/llvm-project/commit/187a14e1f39942545b905679a8452365dfd87af8.diff

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

danlark added inline comments. Comment at: clang/test/CodeGenCXX/for-loop-init-ternary-operator-statement.cpp:1 +// RUN: %clang_cc1 -triple i386-unknown-unknown -O3 -emit-llvm -o - %s | FileCheck %s + rsmith wrote: > We don't use `-O3` tests for this kind of

[PATCH] D102502: [clang] Fix ternary operator in the second for loop statement

danlark updated this revision to Diff 345536. danlark marked 3 inline comments as done. danlark added a comment. - Add codegen and AST tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502 Files:

[PATCH] D102495: [clang][deps] Support inferred modules

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks for splitting out and moving the tool to clang/utils. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102495/new/

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L updated this revision to Diff 345530. Xiangling_L added a comment. Rebased on the latest master and updated the testcase accordingly; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87029/new/ https://reviews.llvm.org/D87029 Files: clang/lib/AST/RecordLayoutBuilder.cpp

[PATCH] D102459: [clang][ObjC] Allow different availability annotation on a method when implementing an optional protocol requirement

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102459/new/ https://reviews.llvm.org/D102459 ___ cfe-commits

[PATCH] D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102374/new/ https://reviews.llvm.org/D102374

[PATCH] D102459: [clang][ObjC] Allow different availability annotation on a method when implementing an optional protocol requirement

arphaman updated this revision to Diff 345529. arphaman added a comment. Do not apply this to 'deprecated' availability annotations - the user has no way to check for deprecated as `respondsToSelector` will still return true even if the class has marked the method as deprecated. CHANGES SINCE

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

eugenis added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102469/new/ https://reviews.llvm.org/D102469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

aaron.ballman added reviewers: rsmith, erichkeane. aaron.ballman added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2685 + bool UsesFPIntrin, bool isInline, + bool isImplicitlyDeclared,

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. There are 3 clang settings for ffp-contract (on, off, fast) but the FMF bits have only "allow contract". Clang sets the "allow contract" bit in the IRBuilder only when ffp-contract=fast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc updated this revision to Diff 345526. mibintc added a comment. I rebased and enhanced the test case clang/test/CodeGen/ffp-contract-option.c to show the effect of various ffp-contract={on,fast,off} * ffast-math=on,off in response to the request from @lebedev.ri ; sorry for leaving

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 345522. urnathan added a comment. force bot rebuild CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp clang/include/clang/AST/ASTContext.h

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

urnathan updated this revision to Diff 345520. urnathan added a comment. unbreaking bot testing of D102241 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101777/new/ https://reviews.llvm.org/D101777 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D102491: [clang][modules] Build inferred modules

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Looks great — thanks for splitting this out! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102491/new/ https://reviews.llvm.org/D102491

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 345519. quinnp added a comment. Removed some unused checks in a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files:

[PATCH] D102488: [clang][deps] Prune unused header search paths

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. The code looks mostly good; some inline comments. I think it'd be useful to have direct tests for "detecting used search paths". That might be a nice thing to separate out

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan added a comment. I don't understand why the build bot is failing to apply the precursor D101777 diff. that diff is marked as ok by the build bot. How can I find the actual error the build bot is encountering? CHANGES SINCE LAST ACTION

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

AbbasSabra added a comment. > Well, and how can I build them on Linux xD Ah, I don't think they are meant to be built on Linux :D Especially if they rely on Window specific features like SEH. If they do they will disable these features on Linux build. > How do you use clang exactly? I

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 345517. quinnp added a comment. Re-added some changes that were lost in the previous updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files:

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 345515. quinnp added a comment. Removing redundant tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 345512. quinnp added a comment. [PowerPC] Fixing previous update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D102482: [clang][deps] NFC: Report modules' context hash

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, although I'd slightly prefer the change to CompilerInstance.h be split out and committed after. Comment at:

[PATCH] D102519: [clangd] Set FileSystem for tweaks in Check tool.

usaxena95 created this revision. usaxena95 added a reviewer: kadircet. Herald added a subscriber: arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Tweaks like DefineOutline depend on FS

[PATCH] D102473: [clang][deps] NFC: Stop assuming the TU's context hash

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102473/new/ https://reviews.llvm.org/D102473

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 345510. quinnp added a comment. Fixed some formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp Index:

[PATCH] D100701: [clang][AVR] Redefine some types to be compatible with avr-gcc

efriedma added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:313 + Builder.defineMacro("__UINT16_TYPE__", "unsigned int"); + Builder.defineMacro("__INT16_TYPE__", "int"); benshi001 wrote: > efriedma wrote: > > Redefining `__INT16_TYPE__` like

[PATCH] D102494: [Clang, Driver] Default to Darwin_libsystem_m veclib on iOS based targets.

arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2492 + // Darwin_libsystem_m for iOS based targets. + if (isTargetIOSBased() && !DriverArgs.hasArgNoClaim(options::OPT_fveclib)) +CC1Args.push_back("-fveclib=Darwin_libsystem_m");

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra created this revision. AbbasSabra requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://docs.microsoft.com/en-us/cpp/extensions/abstract-cpp-component-extensions?view=msvc-160 Repository: rG LLVM Github Monorepo

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng marked 3 inline comments as done. pzheng added a comment. Thanks for all the feedbacks, @MaskRay! I will wait another day before committing the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 345500. urnathan added a comment. Let's try again. Logically this is separate from patch 3, but because that and this touch adjacent lines in the diagnostics file, we need to say patch 3 is a dependency, otherwise we get a conflict. CHANGES SINCE LAST

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 345498. pzheng added a comment. Address new comments from @MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 345491. urnathan added a comment. Herald added subscribers: cfe-commits, usaxena95, kadircet. Herald added a project: clang-tools-extra. reupload diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan marked an inline comment as done. urnathan added inline comments. Comment at: clang/test/CXX/dcl.dcl/basic.namespace/namespace.udecl/p3.cpp:20 class C { +public: int g(); bruno wrote: > bruno wrote: > > > The change to > > >

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan updated this revision to Diff 345487. urnathan added a comment. Address Bruno's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100276/new/ https://reviews.llvm.org/D100276 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan marked 5 inline comments as done. urnathan added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:12370 // If we weren't able to compute a valid scope, it might validly be a // dependent class scope or a dependent enumeration unscoped scope. If

[clang-tools-extra] fde5b24 - [clangd] Make unit test compatible with gtest 1.10.0

Author: Benjamin Kramer Date: 2021-05-14T19:37:46+02:00 New Revision: fde5b24963f42c8f21e32e1c5b19e81ddc52e575 URL: https://github.com/llvm/llvm-project/commit/fde5b24963f42c8f21e32e1c5b19e81ddc52e575 DIFF:

[PATCH] D102175: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete statement when the copied variable is unused.

flx added a comment. In D102175#2759945 , @ymandel wrote: > Hi Felix, > Can you clarify your concern over the warning? Is it the case that the > warning is not present before the fix and is only triggered after the fix? > I'm concerned that removing

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

steakhal added a comment. In D102280#2759480 , @AbbasSabra wrote: > In D102280#2759167 , @steakhal > wrote: > >> Do you have any good (mature, big enough) open-source projects for these >> msvc constructs? > >

[PATCH] D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

leonardchan updated this revision to Diff 345484. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102374/new/ https://reviews.llvm.org/D102374 Files: clang/include/clang/Basic/TargetCXXABI.h

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

Anastasia added inline comments. Comment at: clang/docs/SYCLSupport.rst:96 - global_space, constant_space + * - ``__attribute__((opencl_global_device))`` + - global_space I think we should extend conversion rules too. Repository: rG LLVM Github

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra updated this revision to Diff 345482. AbbasSabra added a comment. Updating D102273 : [analyzer] Update comments + fix typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102273/new/

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

Anastasia added inline comments. Comment at: clang/lib/Sema/Sema.cpp:306 +// Set conditionally to provide correct diagnostics for 'double' type +llvm::StringRef FP64Feature( +getLangOpts().OpenCLVersion >= 300 ? "__opencl_c_fp64" : "cl_khr_fp64");

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp:185-186 + return FD->getType()->isReferenceType(); +} else { + assert(false && "Unknown captured variable"); +} vsavchenko wrote: > AbbasSabra wrote:

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2759808 , @v.g.vassilev wrote: > Hi @hubert.reinterpretcast, > > Would you mind testing this patch: Does the test try to generate native object files in some way? There is functionality (with some

[PATCH] D102494: [Clang, Driver] Default to Darwin_libsystem_m veclib on iOS based targets.

scanon added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2492 + // Darwin_libsystem_m for iOS based targets. + if (isTargetIOSBased() && !DriverArgs.hasArgNoClaim(options::OPT_fveclib)) +CC1Args.push_back("-fveclib=Darwin_libsystem_m");

[PATCH] D100671: [ADT] Factor out in_place_t and expose in Optional ctor

scott.linder updated this revision to Diff 345475. scott.linder added a comment. Add constexpr convenience variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100671/new/ https://reviews.llvm.org/D100671 Files:

[PATCH] D102507: [HIP] Support in device code

tra added a subscriber: rsmith. tra added a comment. In effect this patch applies `__host__ __device__` to a subset of the standard library headers and whatever headers *they* happen to include. While it may happen to work, I'm not at all confident that it does not create interesting issues.

[PATCH] D100509: Support GCC's -fstack-usage flag

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LG with some nits. After fixes, please wait one day or so in case there are further comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5500 +

[PATCH] D102288: [HWASan] Add aliasing flag and enable HWASan to use it.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7d1ab75cf47: [HWASan] Add aliasing flag and enable HWASan to use it. (authored by morehouse). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102288/new/

[clang] b7d1ab7 - [HWASan] Add aliasing flag and enable HWASan to use it.

Author: Matt Morehouse Date: 2021-05-14T09:47:20-07:00 New Revision: b7d1ab75cf474fb3ffc7e7173762c4d83eb2ef8e URL: https://github.com/llvm/llvm-project/commit/b7d1ab75cf474fb3ffc7e7173762c4d83eb2ef8e DIFF:

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

AbbasSabra updated this revision to Diff 345471. AbbasSabra marked 7 inline comments as done. AbbasSabra added a comment. Updating D102273 : [analyzer] Apply code review part 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 345470. pzheng added a comment. Address @MaskRay's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG769cc335e6e6: [OpenCL] Simplify use of C11 atomic types. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a project: clang.

[clang] 769cc33 - [OpenCL] Simplify use of C11 atomic types.

Author: Anastasia Stulova Date: 2021-05-14T17:43:00+01:00 New Revision: 769cc335e6e63e5eac0c0ac849de44714326e20b URL: https://github.com/llvm/llvm-project/commit/769cc335e6e63e5eac0c0ac849de44714326e20b DIFF:

[PATCH] D102175: [clang-tidy] performance-unnecessary-copy-initialization: Remove the complete statement when the copied variable is unused.

ymandel added a comment. Hi Felix, Can you clarify your concern over the warning? Is it the case that the warning is not present before the fix and is only triggered after the fix? I'm concerned that removing the call may have unintended side effects and I would think it might better to leave

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes LGTM, but you should wait a bit before landing in case @rsmith or one of the other reviewers has concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D102397: [AArch64] Lower bitreverse in ISel

Rin updated this revision to Diff 345465. Rin added a comment. Add AutoUpgrade test and move bitreverse lowering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102397/new/ https://reviews.llvm.org/D102397 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2759808 , @v.g.vassilev wrote: > Hi @hubert.reinterpretcast, > > Would you mind testing this patch: Running it now. I've applied the first diff here to the base of my previously reported result to

[PATCH] D102508: [HIP] Add test libstd_functional

ashi1 added a comment. In D102508#2759906 , @yaxunl wrote: > In D102508#2759905 , @ashi1 wrote: > >> Looks good, let me verify on HIP builder. > > It depends on https://reviews.llvm.org/D102507 Okay, let's wait

[PATCH] D102508: [HIP] Add test libstd_functional

yaxunl added a comment. In D102508#2759905 , @ashi1 wrote: > Looks good, let me verify on HIP builder. It depends on https://reviews.llvm.org/D102507 Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102508/new/

[PATCH] D102508: [HIP] Add test libstd_functional

ashi1 added a comment. Looks good, let me verify on HIP builder. Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102508/new/ https://reviews.llvm.org/D102508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102502: [clang] Fix ternary operator in second for loop argument

rsmith added a comment. Thanks, nice catch! Can we also add an assert when parsing a `for` statement that we actually find a range if the tentative parse said we were expecting one? Comment at: clang/test/CodeGenCXX/for-loop-init-ternary-operator-statement.cpp:1 +// RUN:

[PATCH] D100733: [clang] NFC: change uses of `Expr->getValueKind` into `is?Value`

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. In D100733#2759592 , @aaronpuchert wrote: > @aaron.ballman, what do you think about this? We can't really prevent anyone > from writing `.getValueKind() == VK_*Value` instead of

[PATCH] D102508: [HIP] Add test libstd_functional

yaxunl created this revision. yaxunl added reviewers: tra, ashi1. Herald added a subscriber: mgorny. yaxunl requested review of this revision. This patch adds a test for using in HIP device code. Repository: rT test-suite https://reviews.llvm.org/D102508 Files:

[PATCH] D102502: [clang] Fix ternary operator in second for loop argument

danlark added a comment. Done, please, take a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102502: [clang] Fix ternary operator in second for loop argument

danlark updated this revision to Diff 345460. danlark added a comment. - Add codegen and AST tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102502/new/ https://reviews.llvm.org/D102502 Files: clang/lib/Parse/ParseTentative.cpp

[PATCH] D102507: [HIP] Support in device code

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: mgorny. yaxunl requested review of this revision. This patch adds wrapper headers for `` and a few others which is required to support ``. The basic idea is to make template functions defined in these headers

  1   2   >