[PATCH] D103131: support debug info for alias variable

dblaikie added a comment. In D103131#2835004 , @kamleshbhalui wrote: > In D103131#2834744 , @dblaikie > wrote: > >> Huh, that surprises me - guess gdb favors checking the symbol first. I guess >> maybe it is

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

zequanwu added a comment. Hi, this caused compiler crash on error "!dbg attachment points at wrong subprogram for function". So, I reverted it. I'm working on a reduced repro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104082/new/

[clang] f681fd9 - Revert "[CodeGen] Don't create fake FunctionDecls when generating block/byref"

Author: Zequan Wu Date: 2021-06-22T21:48:00-07:00 New Revision: f681fd927e883301658dcac9a78109ee0aba12a8 URL: https://github.com/llvm/llvm-project/commit/f681fd927e883301658dcac9a78109ee0aba12a8 DIFF: https://github.com/llvm/llvm-project/commit/f681fd927e883301658dcac9a78109ee0aba12a8.diff

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

xazax.hun added a comment. In D104616#2835030 , @RedDocMD wrote: > Looks like I have wasted a good deal of effort. :( Sorry about that! :( If we learned anything new in the process it was not wasted effort though. Repository: rG LLVM Github

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan updated this revision to Diff 353844. TaoPan added a comment. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. Make clang option -fbasic-block-sections and -funique-basic-block-section-names available on Windows COFF. Repository: rG LLVM Github Monorepo

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD added a comment. In D104616#2834770 , @xazax.hun wrote: > In D104616#2834714 , @NoQ wrote: > >> Why not simply delegate this job to `assume(evalBinOp(...))` over raw >> pointer values, which already has

[PATCH] D103131: support debug info for alias variable

kamleshbhalui added a comment. In D103131#2834744 , @dblaikie wrote: > Huh, that surprises me - guess gdb favors checking the symbol first. I guess > maybe it is using something that determines that that symbol comes from the > file with debug info -

[PATCH] D103501: [clang][AIX] Enable inlined quadword atomic operations

lkail added inline comments. Comment at: clang/test/CodeGen/ppc64-quadword-atomics.c:10 + +// CHECK-NOT: call void @__atomic_exchange +// CHECK: +quadword-atomics hubert.reinterpretcast wrote: > Can you add a link to something that demonstrates that the

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:58-80 +std::string OldName = Name.str(); std::string NewName = (Name + ModuleId).str(); if (const auto *C = ExportGV.getComdat()) if (C->getName() == Name)

[PATCH] D88327: [SemaTemplateInstantiate] Handle lack of TypeSourceInfo on special member functions in templated lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9aaf34b8db8: [SemaCXX] Handle lack of TypeSourceInfo on special member functions in… (authored by bruno). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] c9aaf34 - [SemaCXX] Handle lack of TypeSourceInfo on special member functions in templated lambdas

Author: Bruno Cardoso Lopes Date: 2021-06-22T17:26:05-07:00 New Revision: c9aaf34b8db884faa3d3ced4d2fb88fd45697408 URL: https://github.com/llvm/llvm-project/commit/c9aaf34b8db884faa3d3ced4d2fb88fd45697408 DIFF:

[PATCH] D104753: [Driver] Stop linking _p libs for -pg on FreeBSD 14

emaste added a comment. `-pg` is still supported (see the `OPT_pg` at line 253), gprof just won't be able to "see into" libc, libm, etc. For example a trivial test case calling snprintf and strcmp in a loop, on FreeBSD 11 with _p libs: % cumulative self self total

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added a comment. Regarding the tweakings in `constant-folding.c`, I have refrained from using cases which were resulting in `UNKNOWN` assertions as they were the primary reason for constraints being propagated. Comment at:

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas updated this revision to Diff 353825. manas added a comment. Added updated logic for reasoning using number of overflows. Also, changed a couple of tests which were leading to unwanted constriants being propagated further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102730: [clang-format] Support custom If macros

vlovich updated this revision to Diff 353823. vlovich added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102730/new/ https://reviews.llvm.org/D102730 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D104553: [compiler-rt][hwasan] Add InitState options to thread initialization

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104553/new/ https://reviews.llvm.org/D104553

[PATCH] D104553: [compiler-rt][hwasan] Add InitState options to thread initialization

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104553/new/ https://reviews.llvm.org/D104553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny added a comment. In D104714#2834696 , @arichardson wrote: > Thanks for working on this! Thanks for the review. > We have some tests downstream that check globals and currently have to use > `// UTC_ARGS: --disable` to manually retain them.

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

jonpa added a comment. In D96568#2832781 , @thopre wrote: > In D96568#2569296 , @jonpa wrote: > >>> Sounds good to me. Hopefully I'll get round to __builtin_isinf soon and a >>> single hook will make the patch

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

xazax.hun added a comment. In D104616#2834714 , @NoQ wrote: > Why not simply delegate this job to `assume(evalBinOp(...))` over raw pointer > values, which already has all this logic written down nicely? This is what I had in mind, I just did not want

[PATCH] D103131: support debug info for alias variable

dblaikie added a comment. Huh, that surprises me - guess gdb favors checking the symbol first. I guess maybe it is using something that determines that that symbol comes from the file with debug info - because on a similar test case (one file without debug info, defining some global variable

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

mizvekov added inline comments. Comment at: clang/test/SemaTemplate/resolve-single-template-id.cpp:73-75 + oneT < oneT; // expected-warning {{self-comparison always evaluates to false}} \ + // expected-warning {{relational comparison result unused}}

[PATCH] D104753: [Driver] Stop linking _p libs for -pg on FreeBSD 14

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. I mostly agree with this, but for the "silent ignoring" of `-pg` which this achieves. What would be the consequence of producing an error instead, like `-pg not supported for FreeBSD >= 14` ? Too

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

NoQ added a comment. In D104616#2830349 , @xazax.hun wrote: > In D104616#2829705 , @RedDocMD > wrote: > >> If `(ptr1 == ptr2)` is false, we can't say anything really. > > Well, I think it depends. If one of the

[PATCH] D103501: [clang][AIX] Enable inlined quadword atomic operations

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/ppc64-quadword-atomics.c:10 + +// CHECK-NOT: call void @__atomic_exchange +// CHECK: +quadword-atomics Can you add a link to something that demonstrates that the implementation of

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

arichardson accepted this revision. arichardson added a comment. Thanks for working on this! We have some tests downstream that check globals and currently have to use `// UTC_ARGS: --disable` to manually retain them. The other update script tests compare to an expected output file instead of

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA added a comment. > --implicit-check-not=vec-extabi maybe better? @jsji had to rename the test file because the filename was tripping the error  but this is better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

thakis added a comment. a8bf33ad36837b398d3dabfd5fff1142660a1dca fixed this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104484/new/ https://reviews.llvm.org/D104484

[PATCH] D104505: [HIP] Defer operator overloading errors

tra added a comment. In D104505#2833943 , @yaxunl wrote: > We don't defer such diags by default. We only defer them under option > -fgpu-defer-diags, which users have to specify explicitly. Thank you for pointing this out. I've missed that all the

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA updated this revision to Diff 353806. ZarkoCA marked an inline comment as done. ZarkoCA added a comment. check for `vec-extabi` instead of `-mabi=vec-extabi` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

mizvekov updated this revision to Diff 353805. mizvekov added a comment. Implement 2/3 of Arthur's suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104680/new/ https://reviews.llvm.org/D104680 Files:

[clang] a8bf33a - [clang] unbreak Index/preamble-reparse-changed-module.m with LLVM_APPEND_VC_REV=NO after 7942ebdf01b3

Author: Nico Weber Date: 2021-06-22T17:56:17-04:00 New Revision: a8bf33ad36837b398d3dabfd5fff1142660a1dca URL: https://github.com/llvm/llvm-project/commit/a8bf33ad36837b398d3dabfd5fff1142660a1dca DIFF: https://github.com/llvm/llvm-project/commit/a8bf33ad36837b398d3dabfd5fff1142660a1dca.diff

[PATCH] D104753: [Driver] Stop linking _p libs for -pg on FreeBSD 14

emaste created this revision. emaste added a reviewer: dim. Herald added subscribers: krytarowski, arichardson. emaste requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In FreeBSD 14 we plan to deprecate the _p.a special profiling libraries

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen updated this revision to Diff 353797. samitolvanen added a comment. Fix a use-of-uninitialized-value error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104058/new/ https://reviews.llvm.org/D104058 Files:

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

thakis added a comment. Probably the "need to bump AST serialization Version after adding a langopt" thing again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104484/new/ https://reviews.llvm.org/D104484

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

jsji added inline comments. Comment at: clang/test/Driver/aix-vec-extabi.c:2 +// RUN: %clang -### -target powerpc-unknown-aix -S %s 2>&1 | \ +// RUN: FileCheck %s --implicit-check-not=-mabi=vec-extabi +// RUN: %clang -### -target powerpc-unknown-aix -S -maltivec %s 2>&1 | \

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/test/Driver/aix-vec-extabi.c:12 +/ +// NOEXTABI-NOT: "-mabi=vec-extabi" jsji wrote: > Why not use `--implicit-check-not`? Thank you, I wasn't aware of this option before

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA updated this revision to Diff 353787. ZarkoCA added a comment. Use `--implicit-check-not` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/ https://reviews.llvm.org/D102094 Files:

[PATCH] D104664: [PowerPC][NFC] Clean up builtin sema checks

This revision was automatically updated to reflect the committed changes. Closed by commit rGb259740801d3: [PowerPC][NFC] Clean up builtin sema checks (authored by lei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104664/new/

[clang] b259740 - [PowerPC][NFC] Clean up builtin sema checks

Author: Lei Huang Date: 2021-06-22T16:06:28-05:00 New Revision: b259740801d3515810ecc15bf0c24b0d476a1608 URL: https://github.com/llvm/llvm-project/commit/b259740801d3515810ecc15bf0c24b0d476a1608 DIFF: https://github.com/llvm/llvm-project/commit/b259740801d3515810ecc15bf0c24b0d476a1608.diff

[PATCH] D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, PowerPC. NeHuang added projects: LLVM, clang. Herald added subscribers: shchenz, kbarton. NeHuang requested review of this revision. Herald added a subscriber: cfe-commits. This patch is in a series of patches to provide

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

thakis added a comment. This breaks check-clang: http://45.33.8.238/linux/49502/step_7.txt Please take a look and revert for now if it takes a while to fix. It's been a pretty rough day for the tree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104677: [OpenMP][AMDGCN] Apply fix for isnan, isinf and isfinite for amdgcn.

estewart08 updated this revision to Diff 353773. estewart08 added a comment. Add test_isnan function to hip-header.hip. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104677/new/ https://reviews.llvm.org/D104677 Files:

[PATCH] D104540: [clangd] Dont index ObjCCategoryDecls for completion

This revision was automatically updated to reflect the committed changes. Closed by commit rG544d20eab662: [clangd] Dont index ObjCCategoryDecls for completion (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104540/new/

[clang-tools-extra] 544d20e - [clangd] Dont index ObjCCategoryDecls for completion

Author: Kadir Cetinkaya Date: 2021-06-22T22:42:25+02:00 New Revision: 544d20eab662e29640c8435033e7458e5ee1857e URL: https://github.com/llvm/llvm-project/commit/544d20eab662e29640c8435033e7458e5ee1857e DIFF:

[PATCH] D104743: [UpdateCCTestChecks] Implement --global-hex-value-regex

jdenny created this revision. jdenny added reviewers: arichardson, ggeorgakoudis, jdoerfert, MaskRay, mtrofin, greened. jdenny requested review of this revision. Herald added a subscriber: sstefan1. Herald added projects: clang, LLVM. For example, in OpenMP offload codegen tests, global

[PATCH] D104742: [UpdateCCTestChecks] Implement --global-value-regex

jdenny created this revision. jdenny added reviewers: arichardson, ggeorgakoudis, jdoerfert, MaskRay, mtrofin, greened. jdenny requested review of this revision. Herald added a subscriber: sstefan1. Herald added projects: clang, LLVM. `--check-globals` activates checks for all global values, and

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny added a comment. In D104714#2833238 , @jdoerfert wrote: > LG, cool :) Thanks for the reviews. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/ https://reviews.llvm.org/D104714 ___

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

jdenny updated this revision to Diff 353765. jdenny added a comment. Fixed the reported test failure. (Sorry, I had accidentally put that fix in a later patch even though the associated test is in this patch.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104714/new/

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

This revision was automatically updated to reflect the committed changes. Closed by commit rG7942ebdf01b3: [clang] Add cc1 option for dumping layout for all complete types (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7942ebd - [clang] Add cc1 option for dumping layout for all complete types

Author: David Tenty Date: 2021-06-22T16:27:26-04:00 New Revision: 7942ebdf01b35fae240cd8a0550a3da9f03615c4 URL: https://github.com/llvm/llvm-project/commit/7942ebdf01b35fae240cd8a0550a3da9f03615c4 DIFF: https://github.com/llvm/llvm-project/commit/7942ebdf01b35fae240cd8a0550a3da9f03615c4.diff

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. @HazardyKnusperkeks thank you for the accept, if there are no objections from @curdeius , @krasimir and @sammccall I'd like to proceed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93528/new/

[PATCH] D104342: [IR] convert warn-stack-size from module flag to fn attr

dblaikie added a subscriber: aaron.ballman. dblaikie added a comment. In D104342#2834119 , @nickdesaulniers wrote: > In D104342#2831738 , @dblaikie > wrote: > >>> In D104342#2831717

[PATCH] D104664: [PowerPC][NFC] Clean up builtin sema checks

NeHuang accepted this revision. NeHuang added a comment. This revision is now accepted and ready to land. LGTM. Please give it some time (~24hrs) before commit to wait for the other reviewers' comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

This revision was automatically updated to reflect the committed changes. Closed by commit rG64cf5eba06bd: [clang-format] Add new LambdaBodyIndentation option (authored by vlovich, committed by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D102706?vs=347152=353753#toc

[clang] 64cf5eb - [clang-format] Add new LambdaBodyIndentation option

Author: Vitali Lovich Date: 2021-06-22T21:46:16+02:00 New Revision: 64cf5eba06bd4f81954253b1e7a10be6fe92403e URL: https://github.com/llvm/llvm-project/commit/64cf5eba06bd4f81954253b1e7a10be6fe92403e DIFF: https://github.com/llvm/llvm-project/commit/64cf5eba06bd4f81954253b1e7a10be6fe92403e.diff

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Driver/aix-vec-extabi.c:12 +/ +// NOEXTABI-NOT: "-mabi=vec-extabi" Why not use `--implicit-check-not`?

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA added inline comments. Comment at: clang/test/Driver/aix-vec-extabi.c:3 +// RUN: FileCheck %s --check-prefix=EXTABI // RUN: %clang -### -target powerpc-unknown-aix -S -maltivec -mabi=vec-default %s 2>&1 | \ +// RUN: FileCheck %s --check-prefix=DFLTABI

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA updated this revision to Diff 353748. ZarkoCA marked 2 inline comments as done. ZarkoCA added a comment. - Updated test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/ https://reviews.llvm.org/D102094 Files:

[PATCH] D104677: [OpenMP][AMDGCN] Apply fix for isnan, isinf and isfinite for amdgcn.

JonChesterfield added a comment. Looks like the __OPENMP_AMDGCN__ guard is sound to me, but can't really argue against having more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104677/new/ https://reviews.llvm.org/D104677

[PATCH] D104342: [IR] convert warn-stack-size from module flag to fn attr

nickdesaulniers added a comment. In D104342#2831738 , @dblaikie wrote: >> In D104342#2831717 , @dblaikie >> wrote: >> >>> Probably worth at least writing up the risk/instability in the docs for the >>> warning

[PATCH] D102940: [OpenMP] Remove OpenMP CUDA Target Parallel compiler flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc768aac2e4e: [OpenMP] Remove OpenMP CUDA Target Parallel compiler flag (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102940/new/

[clang] bc768aa - [OpenMP] Remove OpenMP CUDA Target Parallel compiler flag

Author: Joseph Huber Date: 2021-06-22T15:10:19-04:00 New Revision: bc768aac2e4ebc3613f1e5601b15f663a6385044 URL: https://github.com/llvm/llvm-project/commit/bc768aac2e4ebc3613f1e5601b15f663a6385044 DIFF: https://github.com/llvm/llvm-project/commit/bc768aac2e4ebc3613f1e5601b15f663a6385044.diff

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

thakis added a comment. Looks like this breaks check-llvm on mac, see http://45.33.8.238/mac/32814/summary.html Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104058/new/

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4c06bcb67a1: [CodeGen] Dont create fake FunctionDecls when generating block/byref (authored by ahatanak). Repository: rG LLVM Github Monorepo

[clang] f4c06bc - [CodeGen] Don't create fake FunctionDecls when generating block/byref

Author: Akira Hatanaka Date: 2021-06-22T11:42:53-07:00 New Revision: f4c06bcb67a1eba13a7f164961586dddaf8ebd5f URL: https://github.com/llvm/llvm-project/commit/f4c06bcb67a1eba13a7f164961586dddaf8ebd5f DIFF:

[PATCH] D102730: [clang-format] Support custom If macros

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Seems to be okay for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102730/new/ https://reviews.llvm.org/D102730

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

ahatanak updated this revision to Diff 353729. ahatanak marked 2 inline comments as done. ahatanak added a comment. Delete comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104082/new/ https://reviews.llvm.org/D104082 Files:

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104484/new/ https://reviews.llvm.org/D104484

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

jsji added inline comments. Comment at: clang/test/Driver/aix-vec-extabi.c:3 +// RUN: FileCheck %s --check-prefix=EXTABI // RUN: %clang -### -target powerpc-unknown-aix -S -maltivec -mabi=vec-default %s 2>&1 | \ +// RUN: FileCheck %s --check-prefix=DFLTABI

[PATCH] D104505: [HIP] Defer operator overloading errors

yaxunl added a comment. In D104505#2833746 , @tra wrote: > In D104505#2833271 , @yaxunl wrote: > >> Such host/device overloading resolution induced issue is not limited to >> device functions calling host

[clang] 9480162 - Improve clang -Wframe-larger-than= diagnostic

Author: Fangrui Song Date: 2021-06-22T11:20:49-07:00 New Revision: 948016228fdfb647ad7bcc978fde173504e3df82 URL: https://github.com/llvm/llvm-project/commit/948016228fdfb647ad7bcc978fde173504e3df82 DIFF: https://github.com/llvm/llvm-project/commit/948016228fdfb647ad7bcc978fde173504e3df82.diff

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

vsavchenko added a comment. Looks like a solid start! Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:301 + + bool addTransition = false; + ProgramStateRef State = C.getState(); nit: variable names should be capitalized

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA marked 2 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4779 CmdArgs.push_back("-mabi=vec-extabi"); +else if (A->getOption().getID() == options::OPT_mabi_EQ_vec_default) +

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

mibintc created this revision. mibintc added a reviewer: aaron.ballman. mibintc added a project: clang. Herald added subscribers: kerbowa, kbarton, jgravelle-google, sbc100, nhaehnle, jvesely, nemanjai, dschuff. mibintc requested review of this revision. Herald added a subscriber: aheejin. In

[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

ZarkoCA updated this revision to Diff 353721. ZarkoCA marked an inline comment as done. ZarkoCA added a comment. Addressed comments: - Removed redundant `elseif` and CHECK Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102094/new/

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 353719. mibintc added a comment. Herald added subscribers: jdoerfert, hiraditya. This patch addresses almost all the review comments, not yet sure about @aaron.ballman 's question about CoreOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 353716. quinnp marked 2 inline comments as done. quinnp added a comment. Fixing the 32bit AIX run line in the testcases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 353709. RedDocMD added a comment. Logic for handling special cases, when both are unique_ptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files:

[PATCH] D104505: [HIP] Defer operator overloading errors

tra added a comment. In D104505#2833271 , @yaxunl wrote: > Such host/device overloading resolution induced issue is not limited to > device functions calling host functions. It does not change the fact that the code in the test above is invalid,

[PATCH] D104088: Add clang frontend flags for MIP

ellis updated this revision to Diff 353705. ellis added a comment. Correctly link the runtime symbol for Mach-O. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104088/new/ https://reviews.llvm.org/D104088 Files:

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

This revision was automatically updated to reflect the committed changes. Closed by commit rG4474958d3a97: ThinLTO: Fix inline assembly references to static functions with CFI (authored by samitolvanen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102507: [HIP] Support in device code

ldionne added a comment. In D102507#2830688 , @yaxunl wrote: > In D102507#2792087 , @rsmith wrote: > >> @ldionne How should we go about establishing whether libc++ would be >> prepared to officially support

[PATCH] D104667: Improve the diagnostic of DiagnosticInfoResourceLimit (and warn-stack-size in particular)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf53d791520d8: Improve the diagnostic of DiagnosticInfoResourceLimit (and warn-stack-size in… (authored by MaskRay). Repository: rG LLVM Github

[clang] f53d791 - Improve the diagnostic of DiagnosticInfoResourceLimit (and warn-stack-size in particular)

Author: Fangrui Song Date: 2021-06-22T09:55:20-07:00 New Revision: f53d791520d85c5404381ff3ad92cb918256029d URL: https://github.com/llvm/llvm-project/commit/f53d791520d85c5404381ff3ad92cb918256029d DIFF: https://github.com/llvm/llvm-project/commit/f53d791520d85c5404381ff3ad92cb918256029d.diff

[PATCH] D101899: std::forward_list::swap to use propagate_on_container_swap for noexcept specification

This revision was automatically updated to reflect the committed changes. Closed by commit rG7adf713a5e22: [libc++] Change forward_list::swap to use propagate_on_container_swap for… (authored by airglow923, committed by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

hans added a comment. In D102186#2832900 , @predator5047 wrote: > @hans Can you commit on my behalf? > Email: Alexandru Octavian Butiu alexandru.octavian.butiu at gmail.com Sure! Pushed as

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78d404a11dd3: [clang][c++20] Fix false warning for unused private fields when a class has… (authored by Alexandru Octavian Butiu

[clang] 78d404a - [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

Author: Alexandru Octavian Butiu Date: 2021-06-22T18:40:16+02:00 New Revision: 78d404a11dd33c8349fd9b6ef5876d523c457f0e URL: https://github.com/llvm/llvm-project/commit/78d404a11dd33c8349fd9b6ef5876d523c457f0e DIFF:

[PATCH] D102824: [OpenMP] Internalize functions in OpenMPOpt to improve IPO passes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03d7e61c87eb: [OpenMP] Internalize functions in OpenMPOpt to improve IPO passes (authored by jhuber6). Herald added subscribers: cfe-commits,

[clang] 03d7e61 - [OpenMP] Internalize functions in OpenMPOpt to improve IPO passes

Author: Joseph Huber Date: 2021-06-22T12:38:10-04:00 New Revision: 03d7e61c87eb94083d22ff55cf30c0a378ab6824 URL: https://github.com/llvm/llvm-project/commit/03d7e61c87eb94083d22ff55cf30c0a378ab6824 DIFF: https://github.com/llvm/llvm-project/commit/03d7e61c87eb94083d22ff55cf30c0a378ab6824.diff

[PATCH] D101899: std::forward_list::swap to use propagate_on_container_swap for noexcept specification

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Thanks a lot for fixing this and sorry Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101899/new/ https://reviews.llvm.org/D101899

[PATCH] D88984: Prefer libc++ headers in the -isysroot over the toolchain

ldionne abandoned this revision. ldionne added a comment. Herald added a project: clang-tools-extra. Revisiting this, I don't think we need to move forward with this. Let's just carry our downstream patch until we don't need it anymore (which should be soon ish), and leave upstream Clang as it

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGBlocks.cpp:2144 CGM); // This is necessary to avoid inheriting the previous line number. + StartFunction(GlobalDecl(), ReturnTy, Fn, FI, args); Same here —

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

aprantl accepted this revision. aprantl added a comment. Block copy helpers don't have any source code associated with them, so as long as they are described by a DISubprogram, the exact format of it most likely does not matter. Comment at:

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11815 +if (IsError) + return Opc != BO_Cmp ? Context.getLogicalOperationType() : QualType(); + } Quuxplusone wrote: > Peanut gallery says: Is `QualType()` the right "placeholder"

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

Quuxplusone added a comment. > There isn't any wording on it or anything, yet, but we must jump the gun here > and just do away with it pronto. I think "must" is the wrong word here. "Might as well"? Anyway, I agree with this general idea, FWLIW. Comment at:

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

MyDeveloperDay added a comment. >> Since you use `== ' '` twice, `remainingLineCharCount` will count only >> consecutive spaces, right? >> But you want to count other characters, no? >> So, IIUC, the condition you want is `rF[wI] != '\n' && !(rF[wI] == ' ' && >> rF[wI - 1] == ' ')` (mind the

[PATCH] D104540: [clangd] Dont index ObjCCategoryDecls for completion

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1918 + // from the index, we reduce the noise in all the other completion scopes. + if (llvm::isa()) +return false; dgoldman wrote: > Seems like we should also ignore

[PATCH] D104540: [clangd] Dont index ObjCCategoryDecls for completion

kadircet updated this revision to Diff 353658. kadircet marked an inline comment as done. kadircet added a comment. - Also handle ObjcCategoryImplDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104540/new/ https://reviews.llvm.org/D104540

  1   2   >