[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD updated this revision to Diff 355445. RedDocMD added a comment. Fixed bug in enum conversion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2120 + } else +Addr = EmitLValue(E).getAddress(CGF); Addr = Builder.CreateElementBitCast(Addr, CGF.ConvertTypeForMem(DestTy)); junparser wrote: > junparser wrote:

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to to RISCVArchStringParser.

kito-cheng created this revision. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, niosHD, sabuasal, simoncook, johnrusso,

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

lxfind updated this revision to Diff 355431. lxfind added a comment. Put the post-split ramp function back to the CGSCC worklist Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95807/new/ https://reviews.llvm.org/D95807 Files:

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

ChuanqiXu added a comment. In D95807#2849128 , @lxfind wrote: >> If coroutine ramp function couldn't get inlined, it would disable coroutine >> elide optimization. Could you elaborate more on why do you want to do that? > > Ramp function will eventually

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

lxfind added a comment. > If coroutine ramp function couldn't get inlined, it would disable coroutine > elide optimization. Could you elaborate more on why do you want to do that? Ramp function will eventually be inlined, but not when you run Inliner on the inlinee. Let's say coroutine A calls

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

ChuanqiXu added a comment. In D95807#2849120 , @lxfind wrote: > In D95807#2849053 , @aeubanks wrote: > >> this will run the function simplification pipeline twice on every single >> function when coroutines are

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

lxfind added a comment. In D95807#2849053 , @aeubanks wrote: > this will run the function simplification pipeline twice on every single > function when coroutines are enabled, I don't think that's the intention > > I thought the intention was to do all

[PATCH] D105167: [analyzer] Fix HTML report deduplication.

NoQ created this revision. NoQ added reviewers: vsavchenko, xazax.hun, Szelethus, ASDenysPetrov. Herald added subscribers: manas, steakhal, martong, dkrupp, donat.nagy, arphaman, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. NoQ requested review of this revision. Folks, I

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

junparser added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2120 + } else +Addr = EmitLValue(E).getAddress(CGF); Addr = Builder.CreateElementBitCast(Addr, CGF.ConvertTypeForMem(DestTy)); junparser wrote: > efriedma wrote:

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

aeubanks added a comment. this will run the function simplification pipeline twice on every single function when coroutines are enabled, I don't think that's the intention I thought the intention was to do all the the re-adding of SCCs inside CoroSplit.cpp, including the SCC with the function

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

MarcusJohnson91 added inline comments. Comment at: clang/lib/AST/OSLog.cpp:212 + } else if (Lit->isUTF16()) { +std::wstring_convert, char16_t> Convert; +std::u16string U16 = Lit->getStringAsChar16(); aaron.ballman wrote: > cor3ntin wrote: > > I'm not

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

junparser added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2120 + } else +Addr = EmitLValue(E).getAddress(CGF); Addr = Builder.CreateElementBitCast(Addr, CGF.ConvertTypeForMem(DestTy)); efriedma wrote: > I don't think

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. In D95807#2847449 , @lxfind wrote: > In D95807#2846358 , @ChuanqiXu wrote: > >>> note that we don't

[PATCH] D105092: [PoC][RISCV] Add the tail policy argument to builtins/intrinsics.

HsiangKai updated this revision to Diff 355420. HsiangKai added a comment. - Use constant value for tail policy argument. - Rename HasPolicy to HasPolicyOp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105092/new/ https://reviews.llvm.org/D105092

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

jdoerfert added a comment. OpenMP side looks reasonable. Comment at: clang/lib/Headers/__clang_hip_cmath.h:96 +__DEVICE__ __CONSTEXPR__ bool isnan(float __x) { return ::__isnanf(__x); } +__DEVICE__ __CONSTEXPR__ bool isnan(double __x) { return ::__isnan(__x); }

[PATCH] D105143: [OPENMP]Fix PR50929: Ignored initializer clause in user-defined reduction.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105143/new/ https://reviews.llvm.org/D105143

Re: [PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

Sorry, been away from my setup lately. I'll approve once I'm back at my PC hopefully by EOD. On Tue, Jun 29, 2021, 1:13 PM Jonathan B Coe via Phabricator < revi...@reviews.llvm.org> wrote: > jbcoe accepted this revision. > jbcoe added a subscriber: krasimir. > jbcoe added a comment. > > Some

[PATCH] D105127: Implement P1401R5

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:3930 + ExprResult E = PerformContextuallyConvertToBool(CondExpr); + if (!IsConstexpr || CondExpr->isValueDependent()) +return E; Minor nit: I think it would be a tiny bit clearer if

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 355401. ychen added a comment. - Add description of `raw frame` in `Coroutines.rst`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915 Files:

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added a comment. > Thanks for clarifying. Let's solve the semantics problem first. > With the introduction about 'raw frame', I think it's necessary to introduce > this concept in the section 'Switched-Resume Lowering' or even the section > 'Introduction' in the document. Add a section to

[PATCH] D104285: [analyzer] Retrieve value by direct index from list initialization of constant array declaration.

chrish_ericsson_atx added a comment. In D104285#2847547 , @ASDenysPetrov wrote: > I don't think we should revert b30521c28a4d > because > it corrects symbol representation in CSA

[clang-tools-extra] 632e15e - Conditionalize function only used in an assert to address -Wunused-function

Author: David Blaikie Date: 2021-06-29T16:39:59-07:00 New Revision: 632e15e766ee625ae367b2e872f3df903e507bfb URL: https://github.com/llvm/llvm-project/commit/632e15e766ee625ae367b2e872f3df903e507bfb DIFF: https://github.com/llvm/llvm-project/commit/632e15e766ee625ae367b2e872f3df903e507bfb.diff

[PATCH] D104883: [CodeGen] Add ParmVarDecls to FunctionDecls that are created to generate ObjC property getter/setter functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cda73e3c449: [CodeGen] Add ParmVarDecls to FunctionDecls that are created to generate (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6cda73e - [CodeGen] Add ParmVarDecls to FunctionDecls that are created to generate

Author: Akira Hatanaka Date: 2021-06-29T16:27:24-07:00 New Revision: 6cda73e3c44968eb6fff4b73cb6f1d0ef7d861f4 URL: https://github.com/llvm/llvm-project/commit/6cda73e3c44968eb6fff4b73cb6f1d0ef7d861f4 DIFF:

[PATCH] D100000: [clang] WIP: Implement simpler alternative to two-phase lookup for NRVO

mizvekov updated this revision to Diff 355393. mizvekov added a comment. Patch now in workable state. Is Missing a few cleanups in the implementation. Updates coroutine implicit move tests, as now they can finally match C++20 behavior and don't need P2266

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

jdoerfert updated this revision to Diff 355391. jdoerfert added a comment. Herald added a subscriber: ormris. Adjust AAExecutionDomain properly to account for the new target agnostic kernel init, this makes D104911 obsolete. Repository: rG LLVM Github

[PATCH] D104847: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX 6.5 and 7.0 WMMA and MMA instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rG3644726a78e3: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX 6.5 and 7.0 WMMA… (authored by steffenlarsen, committed by tra). Changed prior to commit:

[PATCH] D104056: [clangd][nfc] Show more information in logs when compiler instance prepare fails

ArcsinX updated this revision to Diff 355389. ArcsinX added a comment. Check ASTDiags.take() for empty instead of ASTDiags.getNumErrors() value check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104056/new/ https://reviews.llvm.org/D104056

[PATCH] D104871: [Docs] use -fprofile-generate for IR PGO and -fprofile-instr-generate for code coverage

rnk added inline comments. Comment at: clang/docs/UsersManual.rst:2117-2118 -Clang also supports profiling via instrumentation. This requires building a -special instrumented version of the code and has some runtime overhead during the profiling, but it provides more detailed

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

owenpan added a comment. In D105099#2848317 , @curdeius wrote: > Formatting part and tests look good to me, but I'd rather see this patch > merge all related boolean options into one enum. > Just thinking out loud, but is it doable to merge >

[PATCH] D104649: Thread safety analysis: Rename parameters of ThreadSafetyAnalyzer::intersectAndWarn (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0b90771c318: Thread safety analysis: Rename parameters of ThreadSafetyAnalyzer… (authored by aaronpuchert). Changed prior to commit:

[PATCH] D104261: Thread safety analysis: Always warn when dropping locks on back edges

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. aaronpuchert marked an inline comment as done. Closed by commit rGf664e2ec371f: Thread safety analysis: Always warn when dropping locks on back edges (authored by

[clang] e0b9077 - Thread safety analysis: Rename parameters of ThreadSafetyAnalyzer::intersectAndWarn (NFC)

Author: Aaron Puchert Date: 2021-06-29T23:56:52+02:00 New Revision: e0b90771c318625e51c34c67db3f3dfbbb686df8 URL: https://github.com/llvm/llvm-project/commit/e0b90771c318625e51c34c67db3f3dfbbb686df8 DIFF: https://github.com/llvm/llvm-project/commit/e0b90771c318625e51c34c67db3f3dfbbb686df8.diff

[clang] f664e2e - Thread safety analysis: Always warn when dropping locks on back edges

Author: Aaron Puchert Date: 2021-06-29T23:56:52+02:00 New Revision: f664e2ec371f61b69e11147d7f9e045083335917 URL: https://github.com/llvm/llvm-project/commit/f664e2ec371f61b69e11147d7f9e045083335917 DIFF: https://github.com/llvm/llvm-project/commit/f664e2ec371f61b69e11147d7f9e045083335917.diff

[PATCH] D104766: [X86] Zero some outputs of Keylocker intrinsics in error case

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14834 +BasicBlock *NoError = createBasicBlock(StrNoErr, this->CurFn); +BasicBlock *Error = createBasicBlock(StrErr, this->CurFn); Sorry I'm late here. Instead of having 3

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

leonardchan updated this revision to Diff 355368. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104085/new/ https://reviews.llvm.org/D104085 Files: compiler-rt/lib/hwasan/CMakeLists.txt compiler-rt/lib/hwasan/hwasan_fuchsia.cpp

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

owenpan added a comment. In D105099#2847933 , @HazardyKnusperkeks wrote: > In D105099#2847328 , > @MyDeveloperDay wrote: > >> Seem similar to D90232: [clang-format] Formatting constructor initializer >> lists

[PATCH] D104647: [analyzer] Support SVal::getType for pointer-to-member values

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:85 const NamedDecl *D; + QualType T; llvm::ImmutableList L; What prevents you from obtaining the type from `D`? I guess `NamedDecl` itself

[clang] 8d21d54 - [CodeGen] Stop creating fake FunctionDecls when generating IR for

Author: Akira Hatanaka Date: 2021-06-29T14:22:33-07:00 New Revision: 8d21d5472501460933e78aead04cf59579025ba4 URL: https://github.com/llvm/llvm-project/commit/8d21d5472501460933e78aead04cf59579025ba4 DIFF:

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

owenpan added a comment. In D105099#2847332 , @MyDeveloperDay wrote: > We already have > > `AllowAllConstructorInitializersOnNextLine` and > `ConstructorInitializerAllOnOneLineOrOnePerLine` > > Sort of feels like we need to combine them with this, > >

[PATCH] D105148: [CMake] Don't use -Bsymbolic-functions for MinGW targets

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > but I don't know if the solaris linker supports -Bsymbolic-functions or not. According to a Solaris "man pages section 1: User Commands", -Bsymbolic-functions is supported. Repository:

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. So it worked out of the box? Great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105017/new/ https://reviews.llvm.org/D105017 ___ cfe-commits

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

ABataev created this revision. ABataev added reviewers: mikerice, jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a project: clang. Currently the last value of linear is calculated as var = init + num_iters * step. Replaced it with

[PATCH] D104918: [clang-repl] Implement partial translation units and error recovery.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. I'm (happily) surprised this required so few changes! Comment at: clang/include/clang/Basic/LangOptions.h:690-691 + + /// The translation unit is a partial translation

[PATCH] D105148: [CMake] Don't use -Bsymbolic-functions for MinGW targets

mstorsjo created this revision. mstorsjo added reviewers: MaskRay, phosek. Herald added subscribers: fedor.sergeev, mgorny. mstorsjo requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. This is an ELF specific option which isn't supported

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

NoQ added a comment. In D104925#2846283 , @balazske wrote: > I could not find a way to pass the needed information from the BugReport to > the `NoteTag`. The "sequence number" (in `EofSeqMap`) is only known when the > bug is detected, this should be

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

NoQ added a comment. I suspect that you might want to include `OperationKinds.def` instead of `OperationKinds.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104616/new/ https://reviews.llvm.org/D104616

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. In D104601#2847400 , @aaron.ballman wrote: > ... would add that it's very common for implementers to ask developers to run > their code through `-E` mode to submit preprocessed output in order to > reproduce a customer

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur updated this revision to Diff 355350. Meinersbur marked 6 inline comments as done. Meinersbur added a comment. - Address review by @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

curdeius added a comment. Formatting part and tests look good to me, but I'd rather see this patch merge all related boolean options into one enum. Just thinking out loud, but is it doable to merge AllowAllConstructorInitializersOnNextLine, ConstructorInitializerAllOnOneLineOrOnePerLine and

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

jbcoe accepted this revision. jbcoe added a subscriber: krasimir. jbcoe added a comment. Some outstanding nits to address but this looks good to me. With @krasimir I implemented a good fraction of the C# support and am confident that these changes are an improvement. CHANGES SINCE LAST ACTION

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

curdeius added a comment. I can't help with C# part either, unfortunately. I'll chime in if I see something strange, but current patch looks okay to me. I let other reviewers (@exv) accept it when they feel it's ok. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1793

[PATCH] D105145: [clang][Fuchsia] Remove relative-vtables multilibs

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a subscriber: mgorny. leonardchan requested review of this revision. As of D102374 , relative vtables is enabled on Fuchsia by

[PATCH] D105142: RFC: Implementing new mechanism for hard register operands to inline asm as a constraint.

anirudhp updated this revision to Diff 355332. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105142/new/ https://reviews.llvm.org/D105142 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/TargetInfo.cpp

[PATCH] D105142: RFC: Implementing new mechanism for hard register operands to inline asm as a constraint.

anirudhp created this revision. Herald added subscribers: pengfei, jfb, tpr. anirudhp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Relevant RFCs posted here https://lists.llvm.org/pipermail/llvm-dev/2021-June/151370.html

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

leonardchan added a comment. Let me know if this should be split up also. I think this might be small and and simple enough for one patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104085/new/ https://reviews.llvm.org/D104085

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90dfd059198e: [Clang] Add option to handle behaviour of vector bool/vector pixel. (authored by stefanp). Repository: rG LLVM Github Monorepo

[clang] 90dfd05 - [Clang] Add option to handle behaviour of vector bool/vector pixel.

Author: Stefan Pintilie Date: 2021-06-29T14:07:12-05:00 New Revision: 90dfd059198ed94334f9b1ccfd29b566feb75e8b URL: https://github.com/llvm/llvm-project/commit/90dfd059198ed94334f9b1ccfd29b566feb75e8b DIFF:

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

leonardchan updated this revision to Diff 355323. leonardchan added a comment. Ok. Ready for reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104085/new/ https://reviews.llvm.org/D104085 Files: compiler-rt/lib/hwasan/CMakeLists.txt

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2120 + } else +Addr = EmitLValue(E).getAddress(CGF); Addr = Builder.CreateElementBitCast(Addr, CGF.ConvertTypeForMem(DestTy)); I don't think it's legal to use

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

stefanp updated this revision to Diff 355320. stefanp added a comment. Removed the lines that specified that checks were auto generated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103615/new/ https://reviews.llvm.org/D103615 Files:

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

stefanp updated this revision to Diff 355315. stefanp added a comment. Updated test cases to avoid failures on non assert builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103615/new/ https://reviews.llvm.org/D103615 Files:

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

dblaikie added a comment. In D103615#2847965 , @stefanp wrote: > In D103615#2847650 , @dblaikie > wrote: > >> In D103615#2847118 , @bmahjour >> wrote: >> >>> In

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

stefanp added a comment. In D103615#2847650 , @dblaikie wrote: > In D103615#2847118 , @bmahjour > wrote: > >> In D103615#2847047 , @stefanp >> wrote: >> >>> I'm sorry I

[PATCH] D104946: [AMDGPU] Add builtin functions image_bvh_intersect_ray

yaxunl updated this revision to Diff 355309. yaxunl added a comment. Add check for ISA. Add comments about argument types. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104946/new/ https://reviews.llvm.org/D104946 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def

[PATCH] D105087: [clang-format] PR49960 clang-format doesn't handle ASI after "return" on JavaScript

mprobst added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1015 +if (!eof()) { + if (Next->is(tok::identifier)) { +// Peek the next token. can you add comments explaining what syntax is being detected here?

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

HazardyKnusperkeks added a comment. In D105099#2847328 , @MyDeveloperDay wrote: > Seem similar to D90232: [clang-format] Formatting constructor initializer > lists by putting them always on different lines (update to D14484) >

[PATCH] D105087: [clang-format] PR49960 clang-format doesn't handle ASI after "return" on JavaScript

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. It's a strange language :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105087/new/ https://reviews.llvm.org/D105087

[PATCH] D104946: [AMDGPU] Add builtin functions image_bvh_intersect_ray

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:221-224 +TARGET_BUILTIN(__builtin_amdgcn_image_bvh_intersect_ray, "V4UiUifV4fV4fV4fV4Ui", "nc", "gfx10-insts")

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

dblaikie added a comment. In D103615#2847704 , @bmahjour wrote: >> (generally: disabling the test in non-asserts builds isn't the right path, >> modifying the test so it doesn't depend on asserts IR naming is the right >> path) > > Agreed. > >> Yes,

[PATCH] D105135: [Internalize] Preserve variables externally initialized.

hliao added inline comments. Comment at: clang/test/CodeGenCUDA/host-used-device-var.cu:20 -// DEV-NEG-NOT: @v1 -__device__ int v1; BTW, as clang codegen tests, those checks should not rely on middle-end optimizations to work correctly.

[clang] aaba371 - [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

Author: Melanie Blower Date: 2021-06-29T13:26:23-04:00 New Revision: aaba37187fda7f5a7fdc4c1e6129cbaaa1bbf709 URL: https://github.com/llvm/llvm-project/commit/aaba37187fda7f5a7fdc4c1e6129cbaaa1bbf709 DIFF:

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

This revision was automatically updated to reflect the committed changes. Closed by commit rGaaba37187fda: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

RedDocMD added a comment. Sorry for not updating. Was down with fever. This patch does *not* work now. `operationKindFromOverloadedOperator` is broken because the maps don't get populated. I am not entirely sure why this is happening. Will try to fix tomorrow. @NoQ, @vsavchenko, @xazax.hun,

[PATCH] D97824: [ObjC][ARC] Don't add operand bundle `clang.arc.attachedcall` to a call if the call already has the operand bundle

This revision was automatically updated to reflect the committed changes. Closed by commit rG952944c12c0a: [ObjC][ARC] Dont add operand bundle clang.arc.attachedcall to a call if (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105135: [Internalize] Preserve variables externally initialized.

hliao created this revision. hliao added reviewers: yaxunl, bogner. Herald added subscribers: ormris, hiraditya. hliao requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. - ``externally_initialized`` variables would be

[clang] 952944c - [ObjC][ARC] Don't add operand bundle clang.arc.attachedcall to a call if

Author: Akira Hatanaka Date: 2021-06-29T10:23:01-07:00 New Revision: 952944c12c0aa917e97805e929b5cd4e40866f91 URL: https://github.com/llvm/llvm-project/commit/952944c12c0aa917e97805e929b5cd4e40866f91 DIFF:

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

bmahjour added a comment. > (generally: disabling the test in non-asserts builds isn't the right path, > modifying the test so it doesn't depend on asserts IR naming is the right > path) Agreed. > Yes, probably removing the entry: check would be sufficient - give it a test > locally and see

[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

dblaikie added a comment. In D103615#2847118 , @bmahjour wrote: > In D103615#2847047 , @stefanp wrote: > >> I'm sorry I missed the asserts requirement. >> I will recommit this patch after I add `REQUIRES:

[PATCH] D105092: [PoC][RISCV] Add the tail policy argument to builtins/intrinsics.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:1148 +if (HasPolicy) { + ProtoMaskSeq.push_back("z"); +} khchen wrote: > maybe the policy argument should be a constant value ("Kz")? Agreed.

[PATCH] D104285: [analyzer] Retrieve value by direct index from list initialization of constant array declaration.

ASDenysPetrov added a comment. @chrish_ericsson_atx Thanks for the new test case. I'll handle it ASAP. > To be clear, neither this new reproducer nor the one I originally posted fail > if commit b30521c28a4d > is >

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

balazske added a comment. Is it better to save the actual `ExplodedNode` in the note tag? Then the error node of the `BugReport` can be used to search the bug path and check if the saved node is encountered. In this way a `NoteTag` could be used and the "sequence numbers" would be unnecessary.

[PATCH] D105120: [clang] Fix UB when string.front() is used for the empty string

DmitryPolukhin updated this revision to Diff 355261. DmitryPolukhin added a comment. Fix clang-tidy style warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105120/new/ https://reviews.llvm.org/D105120 Files:

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

lxfind added a comment. In D95807#2846358 , @ChuanqiXu wrote: >> note that we don't really need to run Inliner again on the ramp function >> after split > > This isn't accurate. The inline may run again for ramp function after split > and it's required

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

aaron.ballman added a comment. I'm still mulling over the feature, but I have some nits with the patch while I was exploring it. I share the concerns raised by @dblaikie and would add that it's very common for implementers to ask developers to run their code through `-E` mode to submit

[PATCH] D105127: Implement P1401R5

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Support Narrowing conversions to bool in if constexpr condition under C++23 language mode. Only if constexpr is implemented as the behavior of

[PATCH] D104052: [clang] Fix CallExpr dependence bit may not respecting all its arguments.

sammccall added a comment. Ping - curious about your thoughts here! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104052/new/ https://reviews.llvm.org/D104052 ___ cfe-commits mailing list

[PATCH] D104056: [clangd][nfc] Show more information in logs when compiler instance prepare fails

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM Sorry about the delay - we got sidetracked into some ideas about whether these errors should actually be surfaced to the user as diagnostics instead. But that shouldn't

[PATCH] D104617: [clangd] Type hints for structured bindings

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Cool! Comment at: clang-tools-extra/clangd/InlayHints.cpp:40 +// types would be "tuple_element::type". +TypeHintPolicy.PrintCanonicalTypes = true; }

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

MyDeveloperDay added a comment. We already have `AllowAllConstructorInitializersOnNextLine` and `ConstructorInitializerAllOnOneLineOrOnePerLine` Sort of feels like we need to combine them with this, I should also say I'd quite like this functionality, its just how do we deliver it via the

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

MyDeveloperDay added a comment. Seem similar to D90232: [clang-format] Formatting constructor initializer lists by putting them always on different lines (update to D14484) which seems to have got stalled I sort of feel I prefer the design where we have an

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

steakhal marked an inline comment as done. steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:543 case CK_VectorSplat: { state = handleLVectorSplat(state, LCtx, CastE, Bldr, Pred); continue;

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:543 case CK_VectorSplat: { state = handleLVectorSplat(state, LCtx, CastE, Bldr, Pred); continue; NoQ wrote: > You didn't start it but that's, ugh,

[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

steakhal updated this revision to Diff 355245. steakhal marked an inline comment as done. steakhal added a comment. Evaluate `LValueToRValueBitCast`s the same way as we evaluate `LValueToRValue` casts. Extended the tests accordingly. Thanks for the hint @NoQ! It looks much better now. CHANGES

[PATCH] D103040: Print default template argument if manually specified in typedef declaration.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc33ebad73516: Print default template argument if manually specified in typedef declaration. (authored by reikdas, committed by v.g.vassilev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] c33ebad - Print default template argument if manually specified in typedef declaration.

Author: Pratyush Das Date: 2021-06-29T14:57:26Z New Revision: c33ebad73516ffcf7b00821a430aa6a0199941f0 URL: https://github.com/llvm/llvm-project/commit/c33ebad73516ffcf7b00821a430aa6a0199941f0 DIFF: https://github.com/llvm/llvm-project/commit/c33ebad73516ffcf7b00821a430aa6a0199941f0.diff LOG:

[PATCH] D104952: [hexagon] Add {hvx,}hexagon_{protos,circ_brev...}

bcain updated this revision to Diff 355234. bcain added a comment. Removed some unavailable instructions. Added include order fix in hexagon_circ_brev Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104952/new/ https://reviews.llvm.org/D104952

[PATCH] D105120: [clang] Fix UB when string.front() is used for the empty string

DmitryPolukhin updated this revision to Diff 355233. DmitryPolukhin added a comment. Replace tab with spaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105120/new/ https://reviews.llvm.org/D105120 Files:

[PATCH] D105120: [clang] Fix UB when string.front() is used for the empty string

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: kadircet, lh123, sammccall, hokein, ilya-biryukov. DmitryPolukhin added projects: clang, clang-tools-extra. Herald added a subscriber: usaxena95. DmitryPolukhin requested review of this revision. Compilation database might

  1   2   >