[PATCH] D108609: [clang] NFC: remove superfluous braces

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108609/new/ https://reviews.llvm.org/D108609

[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

vsapsai added a comment. In D108268#2961547 , @bnbarham wrote: > Unless we also change `DiagnosticEngine` it doesn't look like this is a > viable solution. The `PartialDiagnostic` can't be emitted straight to > `Diags`, since there may already be a

[PATCH] D108609: [clang] NFC: remove superfluous braces

zhouyizhou created this revision. zhouyizhou added reviewers: pengfei, rsmith, rjmccall, doug.gregor, sepavloff, craig.topper, klimek. zhouyizhou requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[PATCH] D105671: [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, thanks, seems like a good approach. Comment at: clang/test/CodeGenObjC/convert-messages-to-runtime-calls.m:34 + // CALLS-NOT: {{call.*@llvm.objc.release}} + //

[PATCH] D105972: Fix __attribute__((annotate("")) with non-zero globals AS

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Sorry for the delay; LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105972/new/ https://reviews.llvm.org/D105972

[PATCH] D107547: [CodeGen] Align calling convention bit-width to bitcode

rjmccall added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:562 /// The clang::CallingConv that this was originally created with. - unsigned ASTCallingConvention : 6; + unsigned ASTCallingConvention : 10; At some point, these

[PATCH] D108421: Mark openmp internal global dso_local

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2194 + getOrCreateInternalVariable(KmpCriticalNameTy, Name)); + if (!GV->isDSOLocal()) +GV->setDSOLocal(true); MaskRay wrote: > Can be variable be preemptible on ELF?

[PATCH] D108421: Mark openmp internal global dso_local

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2194 + getOrCreateInternalVariable(KmpCriticalNameTy, Name)); + if (!GV->isDSOLocal()) +GV->setDSOLocal(true); Can be variable be preemptible on ELF? (i.e. default

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui updated this revision to Diff 368261. kamleshbhalui added a comment. updated test and make changes local to auto generated global vars for lock. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108421/new/

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

rjmccall added a comment. In D108464#2960791 , @tlively wrote: > In D108464#2960623 , @rjmccall > wrote: > >> + JF, who knows something about Web Assembly, or can at least drag in the >> right people >> >> In

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

rjmccall added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1975 + bool AlignAttrCanDecreaseAlignment = + AlignIsRequired && (Ty->getAs() != nullptr || FieldPacked); + stevewan wrote: > rjmccall wrote: > > Okay, so first off, the

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya updated this revision to Diff 368256. haonanya added a comment. Fix formatting issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/ https://reviews.llvm.org/D106343 Files: clang/lib/Headers/opencl-c-base.h clang/lib/Headers/opencl-c.h

[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc728bd5bbaab: [X86] AVX512FP16 instructions enabling 5/6 (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

bnbarham added a comment. In D108268#2958568 , @vsapsai wrote: > `DiagnosticError` looks like a good fit for the task at hand, so it is worth > to try it. Though I don't know if it would end up in the end convoluted or OK. Unless we also change

[PATCH] D108603: [clang][codegen] Set CurLinkModule in CodeGenAction::ExecuteAction

inglorion created this revision. inglorion requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CodeGenAction::ExecuteAction creates a BackendConsumer for the purpose of handling diagnostics. The BackendConsumer's DiagnosticHandlerImpl method

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

vitalybuka added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:166 + ASanAccessInfo(bool IsWrite, bool CompileKernel, uint8_t AccessSizeIndex); +}; + .cpp file is missing Comment at:

[PATCH] D107685: [WebAssembly] Tidy up EH/SjLj options

aheejin added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:449 + // done in WasmEHPrepare pass after these IR passes, but Wasm SjLj requires + // Emscripten libraries and processed together in LowerEmscriptenEHSjLJ pass. + if

[PATCH] D107685: [WebAssembly] Tidy up EH/SjLj options

aheejin updated this revision to Diff 368237. aheejin marked 3 inline comments as done. aheejin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107685/new/ https://reviews.llvm.org/D107685 Files:

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368236. kstoimenov added a comment. Fixed code generation bug. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files: llvm/include/llvm/IR/Intrinsics.td

[PATCH] D108021: [dllexport] Instantiate default ctor default args

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe42ce422a978: [dllexport] Instantiate default ctor default args (authored by rnk). Repository: rG LLVM Github Monorepo

[clang] e42ce42 - [dllexport] Instantiate default ctor default args

Author: Reid Kleckner Date: 2021-08-23T15:56:29-07:00 New Revision: e42ce422a97876e5ecd1c845b12ec65f96f8a293 URL: https://github.com/llvm/llvm-project/commit/e42ce422a97876e5ecd1c845b12ec65f96f8a293 DIFF: https://github.com/llvm/llvm-project/commit/e42ce422a97876e5ecd1c845b12ec65f96f8a293.diff

[PATCH] D107685: [WebAssembly] Tidy up EH/SjLj options

dschuff accepted this revision. dschuff added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp:278 +// Two SjLj modes cannot be turned on at the same time +assert(!(EnableEmSjLj

[PATCH] D108592: [WIP][clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

leonardchan planned changes to this revision. leonardchan added a comment. Some extra comments/open questions: - This patch supports using `N.0.0` as a version number. Do we want to just only accept `N` and disallow any number for minor/subminor, or will zeros be allowed? - This currently will

[PATCH] D108592: [WIP][clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a reviewer: aaron.ballman. leonardchan requested review of this revision. This also adds a warning that triggers when a non-zero minor/subminor are used.

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

jdoerfert added a comment. There are 3 problems here (ignoring our test setup which should be discussed separately): 1. make sure clang finds libomp.so 2. make sure libomp.so (or clang?) finds libomptarget.so 3. make sure libomptartget.so finds the plugins All of which have to work nicely with

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:62 + bool postClangLink); +void AddStaticDeviceLibs(Compilation *C, const Tool *T, const JobAction *JA, + const InputInfoList *Inputs, const Driver

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

ye-luo added inline comments. Comment at: clang/tools/clang-nvlink-wrapper/ClangNvlinkWrapper.cpp:19 +/// Such an archive is then passed to this tool to extract cubin files before +/// passing to nvlink. +/// Right now clang-offload-bundler is only used to

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

tiagoma added a comment. In D54943#2959546 , @JonasToth wrote: > thanks for your testing! i will look at the `__unaligned` issue, not sure if > clang supports it, its an MSVC extension, is it? Yes it is. The clang frontend supports it. I am not sure

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman added a comment. LMK if you can think of a better approach to decide which language to use here. Likely will send a follow up diff to include more context in the Objective-C decl printing so they highlight properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108584: [clangd] Use the active file's language for hover code blocks

dgoldman created this revision. dgoldman added reviewers: kadircet, sammccall. Herald added subscribers: usaxena95, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This helps improve

[clang] 4c40c03 - Fixed doc build.

Author: Artem Belevich Date: 2021-08-23T13:45:36-07:00 New Revision: 4c40c03b3933ce32a2b5f532810dc30f6f329fd4 URL: https://github.com/llvm/llvm-project/commit/4c40c03b3933ce32a2b5f532810dc30f6f329fd4 DIFF:

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

aheejin planned changes to this revision. aheejin added a comment. Oh sorry I clicked the wrong button Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108582/new/ https://reviews.llvm.org/D108582 ___

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. Oh, I fortot I made this currently set `+multivalue` feature... Maybe we have to rethink that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1599-1618 +// For bitcode SDL, search for these 12 relative SDL filenames +SDLs.push_back( +Twine("/libdevice/libbc-" + Lib + "-" + Arch + "-" + Target + ".a") +.str());

[PATCH] D108582: [WebAssembly] Add Wasm SjLj option support for clang

aheejin created this revision. aheejin added reviewers: dschuff, tlively. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds support for Wasm

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

tianshilei1992 added a comment. In D102449#2960209 , @jdoerfert wrote: > Is this still WIP or should it be reviewed? Needs a proper commit message. Not yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107685: [WebAssembly] Tidy up EH/SjLj options

aheejin updated this revision to Diff 368203. aheejin added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add `-wasm-enable-eh` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107685/new/

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

saiislam updated this revision to Diff 368202. saiislam marked 7 inline comments as done. saiislam added a comment. Herald added a subscriber: sstefan1. 1. Added documentation. 2. Improved error handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108248: [CUDA] Bump the latest supported CUDA version to 11.4.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce4545db1d31: [CUDA] Bump the latest supported CUDA version to 11.4. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D108247: [CUDA] Improve CUDA version detection and diagnostics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3db8e486e560: [CUDA] Improve CUDA version detection and diagnostics. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108247/new/

[PATCH] D108239: [CUDA] Add support for CUDA-11.4.

This revision was automatically updated to reflect the committed changes. Closed by commit rG49d982d8cbbb: [CUDA] Add support for CUDA-11.4 (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108239/new/

[clang] ce4545d - [CUDA] Bump the latest supported CUDA version to 11.4.

Author: Artem Belevich Date: 2021-08-23T13:24:49-07:00 New Revision: ce4545db1d31f447bb42987099d691d5658da4bf URL: https://github.com/llvm/llvm-project/commit/ce4545db1d31f447bb42987099d691d5658da4bf DIFF:

[PATCH] D108235: [CUDA] Bump default GPU architecture to sm_35.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0060fffc8222: [CUDA] Bump default GPU architecture to sm_35. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108235/new/

[clang] 3db8e48 - [CUDA] Improve CUDA version detection and diagnostics.

Author: Artem Belevich Date: 2021-08-23T13:24:48-07:00 New Revision: 3db8e486e560183f064e31a228aada52fdeac5d6 URL: https://github.com/llvm/llvm-project/commit/3db8e486e560183f064e31a228aada52fdeac5d6 DIFF:

[clang] 49d982d - [CUDA] Add support for CUDA-11.4

Author: Artem Belevich Date: 2021-08-23T13:24:46-07:00 New Revision: 49d982d8c6e01b6f8e4f173ed6325beab08b URL: https://github.com/llvm/llvm-project/commit/49d982d8c6e01b6f8e4f173ed6325beab08b DIFF:

[clang] 0060fff - [CUDA] Bump default GPU architecture to sm_35.

Author: Artem Belevich Date: 2021-08-23T13:24:45-07:00 New Revision: 0060fffc822261ff7350e34371c4456f363f866d URL: https://github.com/llvm/llvm-project/commit/0060fffc822261ff7350e34371c4456f363f866d DIFF:

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

paulherman added a comment. In D108525#2960877 , @aaron.ballman wrote: > In D108525#2960765 , @paulherman > wrote: > >> Thanks for the very prompt review! I'm afraid I no longer have permissions >> to submit

[PATCH] D108571: [clang] allow -fstack-clash-protection on FreeBSD

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. You know your platform better than I do, and you already ran the patch without any issue, so LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108571/new/

[PATCH] D108481: Avoid nullptr dereferencing of 'Constraint'

schittir marked an inline comment as done. schittir added a comment. In D108481#2960875 , @aaron.ballman wrote: > LGTM, thanks for the cleanup! Do you need someone to commit on your behalf? > If so, what name and email address would you like me to use

[PATCH] D54880: Ignore gcc's stack-clash-protection flag

v.g.vassilev abandoned this revision. v.g.vassilev added a comment. Thanks for the information! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54880/new/ https://reviews.llvm.org/D54880 ___ cfe-commits mailing list

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

aaron.ballman added a comment. In D108525#2960765 , @paulherman wrote: > Thanks for the very prompt review! I'm afraid I no longer have permissions to > submit --my last commit was in 2015 and I recall that I had SVN access, but > many things have

[PATCH] D108481: Avoid nullptr dereferencing of 'Constraint'

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thanks for the cleanup! Do you need someone to commit on your behalf? If so, what name and email address would you like me to use for patch attribution? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108481/new/

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

JonChesterfield added a comment. In D101960#2960846 , @protze.joachim wrote: > The lit config has platform-specific rules to build the environmental > variables (including the use of the proper separators). I suggest to used > these values to create

[PATCH] D108481: Avoid nullptr dereferencing of 'Constraint'

schittir updated this revision to Diff 368183. schittir added a comment. 1. Removed the useless assert on TC. 2. Retained the change from `cast_or_null` to `cast` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108481/new/ https://reviews.llvm.org/D108481 Files:

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

protze.joachim added a comment. In D101960#2960641 , @JonChesterfield wrote: > Pasting `env LD_LIBRARY_PATH=` and `env LIBRARY_PATH` into the printed > commandline, as opposed to through magic, would solve most of my day to day > frustration here.

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

tom-anders added a comment. @sammccall @nridge Thanks for the positive feedback, let me know if I missed any of your suggestions! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108320/new/ https://reviews.llvm.org/D108320

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

tom-anders updated this revision to Diff 368181. tom-anders added a comment. - clang-format once again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108320/new/ https://reviews.llvm.org/D108320 Files:

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

tom-anders updated this revision to Diff 368179. tom-anders added a comment. - Remove accidentally added empty line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108320/new/ https://reviews.llvm.org/D108320 Files:

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

modimo updated this revision to Diff 368178. modimo added a comment. Remove llvm/test/ThinLTO/X86/weak_externals.ll from diffs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36850/new/ https://reviews.llvm.org/D36850 Files:

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

tlively added a comment. In D108464#2960623 , @rjmccall wrote: > + JF, who knows something about Web Assembly, or can at least drag in the > right people > > In D108464#2959591 , @wingo wrote: > >> In

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

tom-anders updated this revision to Diff 368177. tom-anders marked 3 inline comments as done. tom-anders added a comment. - Apply suggested renaming and fix nits - Use a map for extra modifiers instead of abusing conflict resolution - Use ArrayRef instead of callback - Add FIXME for handling

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

saghir updated this revision to Diff 368176. saghir added a comment. Added comments, and re-organized tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107647/new/ https://reviews.llvm.org/D107647 Files:

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

tom-anders marked 12 inline comments as done. tom-anders added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:314 // (these tend to be vague, like Type or Unknown) +// - Resolved tokens (i.e. without the "dependent-name" modifier) with kind +//

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

modimo updated this revision to Diff 368174. modimo added a comment. Minor test fixups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36850/new/ https://reviews.llvm.org/D36850 Files: clang/test/CodeGen/thinlto-distributed-cfi-devirt.ll

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

paulherman added a comment. Thanks for the very prompt review! I'm afraid I no longer have permissions to submit --my last commit was in 2015 and I recall that I had SVN access, but many things have changed. Would it be possible to submit this on my behalf? Repository: rG LLVM Github

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5c288948844: [NFC][clang] Use X86 Features declaration from X86TargetParser (authored by a.elovikov). Repository: rG LLVM Github Monorepo

[clang] f5c2889 - [NFC][clang] Use X86 Features declaration from X86TargetParser

Author: Andrei Elovikov Date: 2021-08-23T12:30:28-07:00 New Revision: f5c28894884488d236d66b766fe5da557cd1ac88 URL: https://github.com/llvm/llvm-project/commit/f5c28894884488d236d66b766fe5da557cd1ac88 DIFF:

[PATCH] D54880: Ignore gcc's stack-clash-protection flag

emaste added a comment. Superseded by e67cbac81211d40332a79d98c9d5953624cc1202 (D68720 ) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54880/new/

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

JonChesterfield added a comment. In D101960#2960657 , @jdoerfert wrote: > Do I understand correctly that adding runpath to libomp.so will help it find > libomptarget.so *and* still allows users to use LD_LIBRARY_PATH to make sure > a different

[PATCH] D108571: [clang] allow -fstack-clash-protection on FreeBSD

emaste added a comment. We make this change in FreeBSD's in-tree Clang about 9 months ago (https://reviews.freebsd.org/D27366) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108571/new/ https://reviews.llvm.org/D108571 ___ cfe-commits

[PATCH] D108571: [clang] allow -fstack-clash-protection on FreeBSD

emaste created this revision. emaste added reviewers: serge-sans-paille, craig.topper, dim. Herald added subscribers: krytarowski, arichardson. emaste requested review of this revision. `-fstack-clash-protection` was added in Clang commit e67cbac81211

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:150 +namespace AsanAccessInfo { + vitalybuka wrote: > kstoimenov wrote: > > vitalybuka wrote: > > > It's not how enums described here > > >

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

a.elovikov updated this revision to Diff 368164. a.elovikov added a comment. Address Erich's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108151/new/ https://reviews.llvm.org/D108151 Files: clang/include/clang/Basic/X86Target.def

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 368162. kstoimenov marked 4 inline comments as done. kstoimenov added a comment. Addressed the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files:

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

jdoerfert added a comment. Do I understand correctly that adding runpath to libomp.so will help it find libomptarget.so *and* still allows users to use LD_LIBRARY_PATH to make sure a different libomptarget.so is found? If the above is the case, can't we do the same for clang? Asked

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:648 +void tools::addOpenMPRuntimeSpecificRPath(const ToolChain , + const ArgList , JonChesterfield wrote: > protze.joachim

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108525/new/ https://reviews.llvm.org/D108525

[PATCH] D101935: [clang] Search runtimes build tree for openmp runtime

JonChesterfield added a comment. At present libomptarget_amdgcn_bc_path and nvptx need to be a path to a file. If we relax that to accept a path to a directory in which the corresponding file is found, then we can use that argument in place of LIBRARY_PATH from the test scripts. That will let

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

JonChesterfield added a comment. Pasting `env LD_LIBRARY_PATH=` and `env LIBRARY_PATH` into the printed commandline, as opposed to through magic, would solve most of my day to day frustration here. libomp.so and libomptarget.so are in two different directories, LD_LIBRARY_PATH turns out to be

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

lebedev.ri added a comment. In D101960#2960622 , @jdoerfert wrote: > To summarize the conversation, can we do LD_LIBRARY_PATH overwrites after > this patch or not? If so, I feel everyone is in favor, if not, we need a > different solution. +1

[PATCH] D108464: [clang][CodeGen] Refactor CreateTempAlloca function nest. NFC.

rjmccall added a reviewer: jfb. rjmccall added a comment. + JF, who knows something about Web Assembly, or can at least drag in the right people In D108464#2959591 , @wingo wrote: > In D108464#2957276 , @wingo

[PATCH] D101960: [openmp] Drop requirement on library path environment variables

jdoerfert added a comment. To summarize the conversation, can we do LD_LIBRARY_PATH overwrites after this patch or not? If so, I feel everyone is in favor, if not, we need a different solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108567: Implement #pragma clang final extension

beanz created this revision. beanz added reviewers: aaron.ballman, rsmith, lgerbarg, pete, lebedev.ri, dexonsmith. beanz requested review of this revision. Herald added a project: clang. This patch adds a new preprocessor extension ``#pragma clang final`` which enables warning on undefinition

Re: [llvm-dev] Phabricator Creator Pulling the Plug

If phabricator/phorge do turn out to be non-viable in the future, I think we may want to reopen the option of moving to Gerrit for the primary code-review platform. I'll note that the Golang folks are using Gerrit as their review platform, and they have a GitHub bot setup to translate GH

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Wed, 18 Aug 2021 at 18:17, MyDeveloper Day via llvm-dev < llvm-...@lists.llvm.org> wrote: > But unless I missed this, was there any discussion regarding the recent > "Winding Down" announcement of Phabricator? and what it might mean for us > in LLVM > I think we have our own self-hosted

[PATCH] D108456: [CUDA] Fix static device variables with -fgpu-rdc

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Please wait for @yaxunl . I believe he mentioned in D85223 that he'll check whether it works on AMD's end. Comment at:

[PATCH] D107769: [OpenCL] Make generic addrspace optional for -fdeclare-opencl-builtins

svenvh updated this revision to Diff 368136. svenvh edited the summary of this revision. svenvh added a comment. I have done an alternative spin of this patch: instead of introducing `RequireDisabledExtension`, simply always make the `private`, `global`, and `local` overloads available. This

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

svenvh added a comment. Thanks for the update! I have a comment about indentation, other than that this is looking good to me. Comment at: clang/lib/Sema/OpenCLBuiltins.td:1129 +let Extension = FuncExtFloatAtomicsFp64GlobalAdd in { +def : Builtin<"atomic_fetch_" #

[PATCH] D108544: [clang][deps] Avoid generating arguments for missing module map files

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. In D108544#2960279 , @dexonsmith wrote: > Is there a way to test this? Marking "request changes" for clarity. Since this drops

[PATCH] D108366: [clang][deps] Deduce resource directory from the compiler path

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. In D108366#2959736 , @jansvoboda11 wrote: > For `clang-scan-deps`, this is //almost// NFC. This code kicks in iff >

[PATCH] D107095: Implement #pragma clang restrict_expansion

This revision was automatically updated to reflect the committed changes. Closed by commit rG43de869d77f7: Implement #pragma clang restrict_expansion (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107095/new/

[clang] 43de869 - Implement #pragma clang restrict_expansion

Author: Chris Bieneman Date: 2021-08-23T09:46:38-07:00 New Revision: 43de869d77f77eedf9f8760f94940a249d2b5a41 URL: https://github.com/llvm/llvm-project/commit/43de869d77f77eedf9f8760f94940a249d2b5a41 DIFF:

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108151/new/ https://reviews.llvm.org/D108151 ___ cfe-commits mailing list

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 2 nits, give Craig a day or two to =1 as well please, particularly since he's the code-owner here. Comment at: clang/lib/Basic/Targets/X86.cpp:1063 +#ifndef NDEBUG

[PATCH] D108151: [NFC][clang] Use X86 Features declaration from X86TargetParser

a.elovikov marked an inline comment as done. a.elovikov added a comment. Hi guys, do you want me to fix anything else? I think I've addressed what I could. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108151/new/ https://reviews.llvm.org/D108151

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

paulherman updated this revision to Diff 368127. paulherman added a comment. Explaining the tag argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108525/new/ https://reviews.llvm.org/D108525 Files: clang/include/clang/Basic/AttrDocs.td

[PATCH] D108533: [clang] Move the soname declaration in a variable at the top of the file

sylvestre.ledru updated this revision to Diff 368126. sylvestre.ledru added a comment. Move the comment too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108533/new/ https://reviews.llvm.org/D108533 Files: clang/tools/libclang/CMakeLists.txt

[PATCH] D108533: [clang] Move the soname declaration in a variable at the top of the file

MaskRay added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:176 # The SOVERSION should be updated only if a change is made to the libclang # ABI, and when it is updated, it should be updated to the current The comment should be

[PATCH] D108540: [clang][deps] Collect precompiled deps from submodules too

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/ClangScanDeps/modules-pch-common-via-submodule.c:85 +// CHECK-TU: "-emit-module" +// CHECK-TU:

[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

dexonsmith added a comment. LGTM once @vsapsai is happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108268/new/ https://reviews.llvm.org/D108268 ___ cfe-commits mailing list

  1   2   >