[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

xgupta added a reviewer: Mordante. xgupta added a subscriber: Mordante. xgupta added a comment. The patch is not applying cleanly so can't be committed. please follow the above phabricator docs I suggested before to upload it. add @Mordante for libcxx change. CHANGES SINCE LAST ACTION

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

This revision was automatically updated to reflect the committed changes. Closed by commit rG451d0596d706: [clang] Fix JSON AST output when a filter is used (authored by woodruffw, committed by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 451d059 - [clang] Fix JSON AST output when a filter is used

Author: william woodruff Date: 2021-10-10T07:46:17+05:30 New Revision: 451d0596d70689190b5ac911ae3ab9fc4c1d7485 URL: https://github.com/llvm/llvm-project/commit/451d0596d70689190b5ac911ae3ab9fc4c1d7485 DIFF:

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

Meinersbur requested changes to this revision. Meinersbur added a comment. This revision now requires changes to proceed. Thanks for the path, but command line parsing should be done properly. Comment at: clang/tools/clang-nvlink-wrapper/ClangNvlinkWrapper.cpp:50 +static

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

salman-javed-nz added a comment. In D111208#3053370 , @carlosgalvezp wrote: > By the way, is `NOLINTBEGIN/END` expected to work/give errors when the check > name is something else than a real check name? See for example: > >

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

woodruffw updated this revision to Diff 378476. woodruffw added a comment. Resolve conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108441/new/ https://reviews.llvm.org/D108441 Files: clang/lib/Frontend/ASTConsumers.cpp

[PATCH] D111482: [Clang] [PowerPC] Fix header include typo in smmintrin.h

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. Can you please add a testcase that include `smmintrin.h` but use SSSE3? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111482/new/

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

SamuelMarks updated this revision to Diff 378467. SamuelMarks added a comment. push/popd for build dirs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111490/new/ https://reviews.llvm.org/D111490 Files: clang/docs/HowToSetupToolingForLLVM.rst clang/docs/LibASTMatchersTutorial.rst

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

SamuelMarks added inline comments. Comment at: clang/docs/LibASTMatchersTutorial.rst:34 - git clone https://github.com/martine/ninja.git - cd ninja - git checkout release xgupta wrote: > SamuelMarks wrote: > > xgupta wrote: > > > why removed `cd

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

SamuelMarks updated this revision to Diff 378466. SamuelMarks marked an inline comment as done. SamuelMarks added a comment. pushd/popd to the various build dirs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111490/new/ https://reviews.llvm.org/D111490 Files:

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

MyDeveloperDay added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:120 + /* bitcode SDL?*/ true, + /* PostClang Link? */ false); // Add an intermediate output file. This file now fails

[clang] 3019898 - [clang-format][NFC] improve the visual of the "clang-formatted %"

Author: mydeveloperday Date: 2021-10-09T19:37:03+01:00 New Revision: 3019898e0d1b494b7e7e76790adb3d83eff4aca1 URL: https://github.com/llvm/llvm-project/commit/3019898e0d1b494b7e7e76790adb3d83eff4aca1 DIFF:

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

xgupta added a comment. Please update the patch full context, see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface if using the web interface. (git diff HEAD~1 -U99 > mypatch.patch) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111490/new/

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

xgupta added inline comments. Comment at: clang/docs/LibASTMatchersTutorial.rst:34 - git clone https://github.com/martine/ninja.git - cd ninja - git checkout release SamuelMarks wrote: > xgupta wrote: > > why removed `cd ninja` & `git checkout

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

SamuelMarks updated this revision to Diff 378463. SamuelMarks added a comment. Also updates appveyor to latest release version of ninja CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111490/new/ https://reviews.llvm.org/D111490 Files: clang/docs/HowToSetupToolingForLLVM.rst

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

SamuelMarks added inline comments. Comment at: clang/docs/LibASTMatchersTutorial.rst:34 - git clone https://github.com/martine/ninja.git - cd ninja - git checkout release xgupta wrote: > why removed `cd ninja` & `git checkout release`? @xgupta To

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp added a comment. Thanks for the clarification, makes a lot of sense now! I'll see what I can do with that. By the way, is `NOLINTBEGIN/END` expected to work/give errors when the check name is something else than a real check name? See for example: https://godbolt.org/z/b6cbTeezs

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

xgupta added inline comments. Comment at: clang/docs/HowToSetupToolingForLLVM.rst:157 - $ git clone git://github.com/martine/ninja.git + $ git clone git://github.com/ninja-build/ninja.git $ cd ninja/ git -> https Comment at:

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

SamuelMarks created this revision. SamuelMarks added a project: LLVM. SamuelMarks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111490 Files:

[PATCH] D111242: Add `TypeLoc`-related matchers.

aaron.ballman added a comment. In D111242#3052562 , @jcking1034 wrote: > @aaron.ballman that sounds like a good idea, what's the process for adding a > release note? Does it involve editing `clang/docs/ReleaseNotes.rst`? That's correct! And because

[PATCH] D111459: Fix a diagnoses-valid in C++20 with variadic macros

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in af971365a2a8b0d982814c0652bb86844fd19cda Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 378392. Ericson2314 added a comment. Herald added a project: Flang. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files:

[clang] af97136 - Fix a diagnoses-valid in C++20 with variadic macros

Author: Aaron Ballman Date: 2021-10-09T08:20:20-04:00 New Revision: af971365a2a8b0d982814c0652bb86844fd19cda URL: https://github.com/llvm/llvm-project/commit/af971365a2a8b0d982814c0652bb86844fd19cda DIFF: https://github.com/llvm/llvm-project/commit/af971365a2a8b0d982814c0652bb86844fd19cda.diff

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

saiislam created this revision. saiislam added reviewers: Meinersbur, ye-luo, JonChesterfield. saiislam requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Added support of a "--path=" option in

[clang] 3e55379 - [clang-format][NFC] Fix spelling mistakes

Author: mydeveloperday Date: 2021-10-09T12:27:08+01:00 New Revision: 3e553791caa0c1f940cc91df0bb30c1b557f7c8a URL: https://github.com/llvm/llvm-project/commit/3e553791caa0c1f940cc91df0bb30c1b557f7c8a DIFF:

[PATCH] D111462: [Driver][OpenBSD] Use ToolChain reference instead of getToolChain().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6417260a57dd: [Driver][OpenBSD] Use ToolChain reference instead of getToolChain(). (authored by fcambus). Repository: rG LLVM Github Monorepo

[clang] 6417260 - [Driver][OpenBSD] Use ToolChain reference instead of getToolChain().

Author: Frederic Cambus Date: 2021-10-09T13:21:39+02:00 New Revision: 6417260a57dd4292ce91f2357479831e3fcf177e URL: https://github.com/llvm/llvm-project/commit/6417260a57dd4292ce91f2357479831e3fcf177e DIFF:

[clang] bbf4b3d - [clang-format][NFC] Fix spelling mistake

Author: mydeveloperday Date: 2021-10-09T12:18:25+01:00 New Revision: bbf4b3dbbe3bfaeecdff2a29ed49da172895d82c URL: https://github.com/llvm/llvm-project/commit/bbf4b3dbbe3bfaeecdff2a29ed49da172895d82c DIFF:

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

salman-javed-nz added a comment. In D111208#3053061 , @carlosgalvezp wrote: > Looking at the code, I see that you use `SuppressionIsSpecific` in order to > separate the errors into 2 error lists: `SpecificNolintBegins` and > `GlobalNolintBegins`.

[PATCH] D110803: [clang-format][docs][NFC] correct the "first supported versions" of some of the clang-format options

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2a826d8b66c: [clang-format][docs][NFC] correct the first supported versions of some of the… (authored by MyDeveloperDay). Changed prior to commit:

[clang] a2a826d - [clang-format][docs][NFC] correct the "first supported versions" of some of the clang-format options

Author: mydeveloperday Date: 2021-10-09T11:02:49+01:00 New Revision: a2a826d8b66cfc85499a92949767d153563078a0 URL: https://github.com/llvm/llvm-project/commit/a2a826d8b66cfc85499a92949767d153563078a0 DIFF:

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added a comment. ping @tiagoma are you still around to pursue this feature request or can this be commandeered? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95168/new/ https://reviews.llvm.org/D95168

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp updated this revision to Diff 378427. carlosgalvezp marked 5 inline comments as done. carlosgalvezp added a comment. -Fixed formatting comments. -Added test for NOLINT(), NOLINTNEXTLINE() and NOLINTBEGIN() -Changed last test to more effectively test NOLINT(*,-google*) CHANGES

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm updated this revision to Diff 378424. hsmhsm added a comment. Introduce a new instruction pointer which aid all the addressspace casts of static allocas to appear in the source order immediately after all static allocas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp marked an inline comment as done. carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:349 + // Allow specifying a few checks with a glob expression. + GlobList Globs(ChecksStr); + if

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp added a comment. Looking at the code, I see that you use `SuppressionIsSpecific` in order to separate the errors into 2 error lists: `SpecificNolintBegins` and `GlobalNolintBegins`. However you don't do anything different with either list, so why do they need to be different

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:353 + if (SuppressionIsSpecific) +*SuppressionIsSpecific = true; } salman-javed-nz wrote: > salman-javed-nz wrote: > > carlosgalvezp

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

salman-javed-nz added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:353 + if (SuppressionIsSpecific) +*SuppressionIsSpecific = true; } salman-javed-nz wrote: > carlosgalvezp wrote: > > salman-javed-nz

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

tejohnson added inline comments. Comment at: llvm/lib/Support/Caching.cpp:36 + SmallString<10> CacheName = CacheNameRef; return [=](unsigned Task, StringRef Key) -> AddStreamFn { noajshu wrote: > noajshu wrote: > > tejohnson wrote: > > > Is this copy