[PATCH] D117398: [clang-format] Fix bug in parsing `operator<` with template

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG560eb2277bb5: [clang-format] Fix bug in parsing `operator` with template (authored by pjessesco, committed by curdeius). Changed prior to commit:

[clang] 560eb22 - [clang-format] Fix bug in parsing `operator<` with template

Author: Jino Park Date: 2022-01-20T08:59:04+01:00 New Revision: 560eb2277bb5aea0982ce5f90321788cda3fe4b3 URL: https://github.com/llvm/llvm-project/commit/560eb2277bb5aea0982ce5f90321788cda3fe4b3 DIFF: https://github.com/llvm/llvm-project/commit/560eb2277bb5aea0982ce5f90321788cda3fe4b3.diff

[PATCH] D113336: [RISCV] Imply extensions in RISCVTargetInfo::initFeatureMap

eopXD updated this revision to Diff 401525. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113336/new/ https://reviews.llvm.org/D113336 Files: clang/lib/Basic/Targets/RISCV.cpp

[PATCH] D117398: [clang-format] Fix bug in parsing `operator<` with template

curdeius added a comment. Or I'll add it when landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117398/new/ https://reviews.llvm.org/D117398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117398: [clang-format] Fix bug in parsing `operator<` with template

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:9466 verifyFormat("operator SomeType>();"); + verifyFormat("operator< <>();"); + verifyFormat("< <>"); Looking at other related bug reports, I think that we should test

[PATCH] D112986: [RISCV] Restrict zvamo, zvlsseg with zve macro-s

eopXD abandoned this revision. eopXD added a comment. This revision is no longer needed as zvamo and zvlsseg will be removed from arch string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112986/new/ https://reviews.llvm.org/D112986

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

carlosgalvezp added a comment. Amazing job @salman-javed-nz ! Here's some initial comments. Reviewing the `NoLintPragmaHandler.cpp` will take some more time from me. It would have been easier to see the diff if the contents had been moved as an NFC patch to a separate file, and then applying

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:137 + +def GPR : RegisterClass<"RISCV", [XLenVT], 32, GPRAllocationList> { let RegInfos = XLenRI; Does putting this back the way it was and using "(add GPR)" in GPRF16,

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117468/new/ https://reviews.llvm.org/D117468

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vloxseg-rv32.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py -; RUN: llc -mtriple=riscv32 -mattr=+d,+experimental-zvlsseg,+zfh \ +; RUN: llc -mtriple=riscv32

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112408/new/ https://reviews.llvm.org/D112408

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

eopXD added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vloxseg-rv32.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py -; RUN: llc -mtriple=riscv32 -mattr=+d,+experimental-zvlsseg,+zfh \ +; RUN: llc -mtriple=riscv32

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

achieveartificialintelligence added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vloxseg-rv32.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py -; RUN: llc -mtriple=riscv32 -mattr=+d,+experimental-zvlsseg,+zfh \ +; RUN: llc

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

majnemer added inline comments. Comment at: clang/test/CodeGenCXX/dllimport.cpp:2 // RUN: %clang_cc1 -disable-noundef-analysis -triple i686-windows-msvc -fno-rtti -fno-threadsafe-statics -fms-extensions -emit-llvm -std=c++1y -O0 -o - %s -DMSABI -w | FileCheck

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:744 static const char *ImpliedExtsZfh[] = {"zfhmin"}; +static const char *ImpliedExtsZve64d[] = {"zve64f", "d"}; +static const char *ImpliedExtsZve64f[] = {"zve64x", "zve32f"}; I

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

majnemer added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2219 + Info.getLangOpts().CPlusPlus && !isForManglingOnly(Kind) && + Var->hasAttr()) // FIXME: Diagnostic! The summary and the bug both mention dllimport

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

majnemer requested changes to this revision. majnemer added a comment. This revision now requires changes to proceed. I have a question regarding how this work with respect to the dllimport semantics known by the linker. IIUC, we will now allow a program like: extern int __declspec(dllimport)

[PATCH] D116906: [OpenMP][AMDGPU] Optimize the linked in math libraries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f2ee1ca5e39: [OpenMP][AMDGPU] Optimize the linked in math libraries (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 6f2ee1c - [OpenMP][AMDGPU] Optimize the linked in math libraries

Author: Johannes Doerfert Date: 2022-01-19T23:36:36-06:00 New Revision: 6f2ee1ca5e39b4286f7eb1aeb63b408f952f93c9 URL: https://github.com/llvm/llvm-project/commit/6f2ee1ca5e39b4286f7eb1aeb63b408f952f93c9 DIFF:

[PATCH] D117746: [CMake] Pass CMAKE_C/CXX_COMPILER_LAUNCHER down to cross-compile and runtime build

ychen created this revision. ychen added a reviewer: dexonsmith. Herald added a subscriber: mgorny. ychen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Similar to D59032 . Repository:

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

MaskRay updated this revision to Diff 401498. MaskRay added a comment. fix a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117744/new/ https://reviews.llvm.org/D117744 Files: clang/include/clang/Driver/Options.td

[PATCH] D117744: [Driver] Remove obsoleted -gz=zlib-gnu

MaskRay created this revision. MaskRay added reviewers: compnerd, yaxunl. Herald added subscribers: dang, jvesely. Herald added a reviewer: ctetreau. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC added -gz=zlib-gnu in 2014

[PATCH] D115848: tidy-llvm

beanz added a comment. Sorry I’m a bit late here. If you want to use clang-tidy on a CMake built project (like LLVM) you can use CMake’s built-in support for clang-tidy: https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_CLANG_TIDY.html This will run clang-tidy during the project build

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf added a comment. In D116015#3203067 , @nemanjai wrote: > Converting more generic code to target-specific intrinsics is sometimes > necessary to ensure the generic IR doesn't get transformed in a way that is > disadvantageous. I believe that the

[PATCH] D117724: [RISCV] Remove Zvlsseg extension.

eopXD added a comment. Thank you for doing this patch, I was about to do it after I land zve. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117724/new/ https://reviews.llvm.org/D117724 ___ cfe-commits

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence added a comment. Ping. Any other suggestions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits mailing list

[PATCH] D117740: [NFC][clang] Simplify `isOneOf` function

achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: alexfh, danielmarjamaki. achieveartificialintelligence requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke updated this revision to Diff 401470. Sockke added a comment. Improve some description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 Files: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp

[PATCH] D117724: [RISCV] Remove Zvlsseg extension.

kito-cheng added a comment. Few more grep result (by `grep zvlsseg * -Rin`), I think should remove: clang/include/clang/Basic/riscv_vector.td:218: // Sub extension of vector spec. Currently only support Zvlsseg. clang/include/clang/Basic/riscv_vector.td:221: // Number of fields for

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

Chenbing.Zheng marked 8 inline comments as done. Chenbing.Zheng added a comment. In D117468#3255546 , @craig.topper wrote: > In D117468#3253879 , > @Chenbing.Zheng wrote: > >> In D117468#3253493

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

Chenbing.Zheng updated this revision to Diff 401468. Chenbing.Zheng added a comment. modify tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117468/new/ https://reviews.llvm.org/D117468 Files: clang/include/clang/Basic/BuiltinsRISCV.def

[PATCH] D117246: [OpenMP] Add support for linking AMDGPU images

jhuber6 updated this revision to Diff 401466. jhuber6 added a comment. Updating after upstreaming a portion of this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117246/new/ https://reviews.llvm.org/D117246 Files:

[PATCH] D117137: [Driver] Add CUDA support for --offline param

dcastagna added a comment. In D117137#3238275 , @tra wrote: > I think instead of setting the triple directly from the command line, we > should start with adding another `--cuda-gpu-arch` (AKA --offload-arch) > variant and derive the triple and other

[PATCH] D117137: [Driver] Add CUDA support for --offline param

dcastagna updated this revision to Diff 401461. dcastagna retitled this revision from "[Driver] Add a flag cuda-device-triple" to "[Driver] Add CUDA support for --offline param". dcastagna edited the summary of this revision. dcastagna added a comment. Using already existing --offload parameters

[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

ChuanqiXu added a comment. gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117087/new/ https://reviews.llvm.org/D117087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115867: [C++20] [Coroutines] Warning for always_inline coroutine

ChuanqiXu added a comment. @Quuxplusone @aaron.ballman gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115867/new/ https://reviews.llvm.org/D115867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu added a comment. @rsmith gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx updated this revision to Diff 401460. ksyx added a comment. Apply suggestion from clangfmt CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117520/new/ https://reviews.llvm.org/D117520 Files: clang/lib/Format/DefinitionBlockSeparator.cpp

[PATCH] D112903: [C++20] [Module] Fix bug47116 and implement [module.interface]/p6

ChuanqiXu added a comment. @aaron.ballman @urnathan gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112903/new/ https://reviews.llvm.org/D112903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117634: [OpenMP] Expand short verisions of OpenMP offloading triples

This revision was automatically updated to reflect the committed changes. Closed by commit rG28d718602ad2: [OpenMP] Expand short verisions of OpenMP offloading triples (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D117634?vs=401357=401454#toc Repository: rG LLVM

[clang] 28d7186 - [OpenMP] Expand short verisions of OpenMP offloading triples

Author: Joseph Huber Date: 2022-01-19T20:26:37-05:00 New Revision: 28d718602ad2bddbfcb445fff46bcbbdd0788471 URL: https://github.com/llvm/llvm-project/commit/28d718602ad2bddbfcb445fff46bcbbdd0788471 DIFF: https://github.com/llvm/llvm-project/commit/28d718602ad2bddbfcb445fff46bcbbdd0788471.diff

[PATCH] D117681: [RISCV] Add the policy operand for some masked RVV ternary IR intrinsics.

khchen updated this revision to Diff 401447. khchen added a comment. Address Craig's comment. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117681/new/ https://reviews.llvm.org/D117681 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D117647: [RISCV] Add destination operand for RVV nomask load intrinsics.

khchen updated this revision to Diff 401446. khchen added a comment. Address Craig's comments, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117647/new/ https://reviews.llvm.org/D117647 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx updated this revision to Diff 401445. ksyx marked an inline comment as done. ksyx added a comment. - Apply suggestions from clangfmt - Split assertion conditions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117520/new/ https://reviews.llvm.org/D117520 Files:

[clang] aba5b91 - Re-land [CodeView] Add full repro to LF_BUILDINFO record

Author: Alexandre Ganea Date: 2022-01-19T19:44:37-05:00 New Revision: aba5b91b699c556da0ee04418321b581bd33611e URL: https://github.com/llvm/llvm-project/commit/aba5b91b699c556da0ee04418321b581bd33611e DIFF:

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaba5b91b699c: Re-land [CodeView] Add full repro to LF_BUILDINFO record (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D117730: [DNM][VFS] Do not overwrite the path when nesting RedirectingFileSystems

bnbarham created this revision. Herald added subscribers: dexonsmith, hiraditya. bnbarham requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. 86e2af8043c7728710a711b623f27425801a36c3

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

sammccall added a comment. This looks good now, only blocker is dropping the change to LookupFile somehow. Is it valuable to land this before the imminent 14 branch cut? I think it's OK but as an indexing change a crash has the possibility to be really disruptive, and most of the rest of us

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman added a comment. PTAL, let me know what you think regarding the edits, had to make sure it works even if we generate multiple edits in the same file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1052 HFI.IndexHeaderMapHeader = 1; +} else if (CurDir->isFramework()) { + size_t SlashPos = Filename.find('/'); sammccall wrote: > This looks like a separate change, and

[PATCH] D117724: [RISCV] Remove Zvlsseg extension.

craig.topper added inline comments. Comment at: llvm/test/MC/RISCV/rvv/zvlsseg.s:11 # RUN: llvm-mc -triple=riscv64 -filetype=obj --mattr=+experimental-v \ # RUN: --mattr=+experimental-zvlsseg %s \ # RUN: | llvm-objdump -d - | FileCheck %s --check-prefix=CHECK-UNKNOWN

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre added a comment. @rsmith I've pulled+rebased again to avoid the (looks like pre-existing) failure. Copy-pasting the wording on https://llvm.org/docs/MyFirstTypoFix.html#commit-by-proxy: I don’t have commit access, can you land this patch for me? Please use “Devin Jeanpierre

[PATCH] D117724: [RISCV] Remove Zvlsseg extension.

khchen added inline comments. Comment at: llvm/test/MC/RISCV/rvv/zvlsseg.s:11 # RUN: llvm-mc -triple=riscv64 -filetype=obj --mattr=+experimental-v \ # RUN: --mattr=+experimental-zvlsseg %s \ # RUN: | llvm-objdump -d - | FileCheck %s --check-prefix=CHECK-UNKNOWN

[PATCH] D117681: [RISCV] Add the policy operand for some masked RVV ternary IR intrinsics.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:2187 +multiclass VPseudoTernaryNoMaskNoPolicyhttps://reviews.llvm.org/D117681/new/ https://reviews.llvm.org/D117681 ___ cfe-commits

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:295 +if (!R.second && !R.first->second.empty()) { + // Framework has known umbrella spelling, cache it for this header as + // well. sammccall wrote: >

[PATCH] D117056: [clangd] Properly compute framework-style include spelling

dgoldman updated this revision to Diff 401422. dgoldman marked 18 inline comments as done. dgoldman added a comment. Changes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117056/new/ https://reviews.llvm.org/D117056 Files:

[PATCH] D117647: [RISCV] Add destination operand for RVV nomask load intrinsics.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:1238 unsigned CurOp = 2; + bool IsTU = false; + if ((IntNo != Intrinsic::riscv_vlm && ``` bool IsTU = IntNo != Intrinsic::riscv_vlm &&

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre updated this revision to Diff 401419. devin.jeanpierre added a comment. pull/rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114732/new/ https://reviews.llvm.org/D114732 Files: clang/docs/LanguageExtensions.rst

[PATCH] D117717: [clang] Ignore -fconserve-stack

nathanchance added a comment. In D117717#3256293 , @MaskRay wrote: > Assuming scan-build is clang/tools/scan-build, which is in tree and can be > fixed instead. Yes, that is the one. > I am not familiar with it, but from > >> However, this caused

[PATCH] D117569: Constexpr not supported with __declspec(dllimport).

zahiraam updated this revision to Diff 401415. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117569/new/ https://reviews.llvm.org/D117569 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/PR19955.cpp clang/test/CodeGenCXX/dllimport.cpp clang/test/SemaCXX/PR19955.cpp

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood updated this revision to Diff 401414. LegalizeAdulthood added a comment. - Tweak documentation, make sure sphinx runs without errors CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 Files:

[PATCH] D116786: [clangd] Add designator inlay hints for initializer lists.

sammccall added a comment. In D116786#3247800 , @kadircet wrote: > a drive by concern around possible flakiness of the interaction. have you > checked how does it look like when the user is still forming the initializer? > it might be annoying if their

[PATCH] D116786: [clangd] Add designator inlay hints for initializer lists.

sammccall updated this revision to Diff 401410. sammccall marked 8 inline comments as done. sammccall added a comment. Address comments, rebase. This category is *off* by default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116786/new/

[clang-tools-extra] 058d212 - [clang-tidy] Use literal block instead of code block (NFC)

Author: Richard Date: 2022-01-19T15:23:48-07:00 New Revision: 058d2123792da54ae7460fea0946d2c90a032e1c URL: https://github.com/llvm/llvm-project/commit/058d2123792da54ae7460fea0946d2c90a032e1c DIFF: https://github.com/llvm/llvm-project/commit/058d2123792da54ae7460fea0946d2c90a032e1c.diff LOG:

[PATCH] D117717: [clang] Ignore -fconserve-stack

MaskRay added a comment. Assuming scan-build is clang/tools/scan-build, which is in tree and can be fixed instead. I am not familiar with it, but from > However, this caused issues with scan-build, as GCC is used as the compiler > but clang is invoked after it with all the -f options that GCC

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

rsmith added inline comments. Comment at: clang/test/SemaCXX/attr-trivial-abi.cpp:9-11 +// On Windows, trivial relocatability depends only on a trivial copy constructor existing. +// In this case, it is implicitly deleted. Similar concerns apply to later tests.

[libunwind] 429a717 - [cmake] Move HandleOutOfTreeLLVM to common cmake utils

Author: John Ericson Date: 2022-01-19T22:05:23Z New Revision: 429a717ea5ec141b5c0c93c2c53097dccf67e05a URL: https://github.com/llvm/llvm-project/commit/429a717ea5ec141b5c0c93c2c53097dccf67e05a DIFF: https://github.com/llvm/llvm-project/commit/429a717ea5ec141b5c0c93c2c53097dccf67e05a.diff LOG:

[PATCH] D117717: [clang] Ignore -fconserve-stack

nathanchance added a comment. In D117717#3256180 , @MaskRay wrote: > Clang has a long list of ignored options but most were added during the > catch-up phase when Clang strove to be a competitor compiler. > I think for new ignored options there needs to

[PATCH] D117717: [clang] Ignore -fconserve-stack

MaskRay added a comment. Clang has a long list of ignored options but most were added during the catch-up phase when Clang strove to be a competitor compiler. I think for new ignored options there needs to be some higher standard. From Debian Code Search

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

dexonsmith added inline comments. Comment at: clang/lib/Lex/MacroInfo.cpp:33 + +// MacroInfo is expected to take 40 bytes on platforms with an 8 byte pointer. +template class MacroInfoSizeChecker { aaron.ballman wrote: > dexonsmith wrote: > > aaron.ballman

[PATCH] D114966: [clang][deps] Split stat and file content caches

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114966/new/ https://reviews.llvm.org/D114966

[PATCH] D70549: [OPENMP]Fix PR41826: symbols visibility in device code.

ABataev added a comment. In D70549#3256063 , @JonChesterfield wrote: > @ABataev @jhuber6 and I would like to change this to annotate variables with > whatever visibility the user asked for. > > Can you recall if the concern about premption here was for

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre added a comment. In D114732#3256046 , @devin.jeanpierre wrote: > Sorry, I missed your other comments. Let me know if there's anything else I > didn't address. I just noticed that there's a "Done" checkbox next to each comment, and it

[PATCH] D117717: [clang] Ignore -fconserve-stack

nathanchance created this revision. nathanchance added reviewers: aaron.ballman, MaskRay, srhines. Herald added a subscriber: dang. nathanchance requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This flag is used when building the Linux

[PATCH] D70549: [OPENMP]Fix PR41826: symbols visibility in device code.

JonChesterfield added subscribers: jhuber6, JonChesterfield. JonChesterfield added a comment. Herald added subscribers: asavonic, sstefan1, yaxunl. @ABataev @jhuber6 and I would like to change this to annotate variables with whatever visibility the user asked for. Can you recall if the concern

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre updated this revision to Diff 401379. devin.jeanpierre added a comment. Fix copy-paste error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114732/new/ https://reviews.llvm.org/D114732 Files: clang/docs/LanguageExtensions.rst

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre added a comment. Sorry, I missed your other comments. Let me know if there's anything else I didn't address. Comment at: clang/test/SemaCXX/attr-trivial-abi.cpp:146 +#ifdef _WIN32 +static_assert(!__is_trivially_relocatable(CopyDeleted), ""); +#else

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

Quuxplusone added inline comments. Comment at: clang/test/SemaCXX/attr-trivial-abi.cpp:9-11 +// On Windows, trivial relocatability depends only on a trivial copy constructor existing. +// In this case, it is implicitly deleted. Similar concerns apply to later tests.

[PATCH] D117634: [OpenMP] Expand short verisions of OpenMP offloading triples

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LG, thanks! Comment at: clang/lib/Driver/Driver.cpp:778 + // We want to normalize the shortened versions of triples passed in to + //

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

Izaron marked 4 inline comments as done. Izaron added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5179 +/// consteval int bar(); +/// void baz() { if consteval {} } +/// \endcode aaron.ballman wrote: > It'd be good to show an

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

Izaron updated this revision to Diff 401365. Izaron added a comment. Fixed commit (with clang-format) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117613/new/ https://reviews.llvm.org/D117613 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:134 + OperateIndex + 1 < Lines.size()) { +// UnwrappedLineParser's recognition of free-standing macro like +// Q_OBJECT may also recognize some uppercased type names

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

Izaron updated this revision to Diff 401363. Izaron added a comment. Fixed commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117613/new/ https://reviews.llvm.org/D117613 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

aaron.ballman added a comment. Thanks for this, I think it's shaping up well! Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:723 +def err_attribute_argument_parm_pack_not_supported : Error< + "attribute %0 does not support pack expansion in arguments">; +def

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2535 ArgAttrs[FirstIRArg + i] = llvm::AttributeSet::get(getLLVMContext(), Attrs); } nlopes wrote: > ab wrote: > > Hmm, if I'm reading this right, this overwrites the

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:120 const auto MayPrecedeDefinition = [&](const int Direction = -1) { + assert(Direction >= -1 && Direction <= 1); const size_t OperateIndex = OpeningLineIndex +

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre added a comment. CI test finished successfully before windows setup did . My workplace's Windows VMs are a bit hosed at the moment... In D114732#3253416 , @Quuxplusone wrote: > In D114732#3253142

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

MyDeveloperDay added a comment. Works nicely now... LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117520/new/ https://reviews.llvm.org/D117520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

devin.jeanpierre updated this revision to Diff 401358. devin.jeanpierre added a comment. Clarify Windows comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114732/new/ https://reviews.llvm.org/D114732 Files:

[PATCH] D117634: [OpenMP] Expand short verisions of OpenMP offloading triples

jhuber6 updated this revision to Diff 401357. jhuber6 edited the summary of this revision. jhuber6 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Changing approach to simply expand the triple where we parse it for OpenMP. Repository: rG LLVM Github

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:186 + "with maximal 32 EEW and F extension)", + [FeatureStdExtZve32x, FeatureStdExtF]>; +def HasStdExtZve32f : Predicate<"SubTarget->hasStdExtZve32f()">;

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

This revision was automatically updated to reflect the committed changes. LegalizeAdulthood marked an inline comment as done. Closed by commit rGd83ecd77cc0f: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants (authored by LegalizeAdulthood). Changed prior to commit:

[clang-tools-extra] d83ecd7 - [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

Author: Richard Date: 2022-01-19T12:28:22-07:00 New Revision: d83ecd77cc0f16cb5fbabe03d37829893ac8b56d URL: https://github.com/llvm/llvm-project/commit/d83ecd77cc0f16cb5fbabe03d37829893ac8b56d DIFF: https://github.com/llvm/llvm-project/commit/d83ecd77cc0f16cb5fbabe03d37829893ac8b56d.diff LOG:

[PATCH] D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool

jhuber6 added a comment. In D117049#3255748 , @saiislam wrote: > It seems that this patch along with D117156 > and D117246 > is giving `patch application failed` error >

[PATCH] D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool

saiislam added a comment. It seems that this patch along with D117156 and D117246 is giving `patch application failed` error [https://buildkite.com/llvm-project/diff-checks/builds/82688]. `arc patch` is also giving the same

[PATCH] D117706: [openmp] Unconditionally set march commandline argument

JonChesterfield added a comment. Landed with you as author and me as reviewer as that seems a more accurate statement than the default. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117706/new/ https://reviews.llvm.org/D117706

[PATCH] D117706: [openmp] Unconditionally set march commandline argument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa9935b5db706: [openmp] Unconditionally set march commandline argument (authored by jhuber6, committed by JonChesterfield). Repository: rG LLVM

[clang] a9935b5 - [openmp] Unconditionally set march commandline argument

Author: Joseph Huber Date: 2022-01-19T19:14:47Z New Revision: a9935b5db706c89182fa3a3e10f30237fb6c4ec5 URL: https://github.com/llvm/llvm-project/commit/a9935b5db706c89182fa3a3e10f30237fb6c4ec5 DIFF: https://github.com/llvm/llvm-project/commit/a9935b5db706c89182fa3a3e10f30237fb6c4ec5.diff LOG:

[PATCH] D117706: [openmp] Unconditionally set march commandline argument

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM, with this you should be able to replace calls for the AMDGPU arch with querying the ToolChain args, e.g. `TCArgs.getLastArgValue(options::OPT_march_EQ)` Repository: rG LLVM Github

  1   2   3   >