[PATCH] D119722: [clang][lex] Use `SearchDirIterator` types in for loops

jansvoboda11 updated this revision to Diff 408724. jansvoboda11 added a comment. Remove `Optional<...>` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119722/new/ https://reviews.llvm.org/D119722 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D119722: [clang][lex] Use `SearchDirIterator` types in for loops

jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1450 Optional HeaderSearch::searchDirIdx(const DirectoryLookup ) const { - for (unsigned I = 0; I < SearchDirs.size(); ++I) -if ([I] == ) - return I; - return None; + return -

[PATCH] D116924: [clang-extdef-mapping] Allow clang-extdef-mapping tool to output customized filename for each index entry

OikawaKirie added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116924/new/ https://reviews.llvm.org/D116924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102614: [index] Add support for type of pointers to class members

OikawaKirie added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102614/new/ https://reviews.llvm.org/D102614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D119806: [clangd][NFC] includes missing headers

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119806/new/ https://reviews.llvm.org/D119806

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie added a comment. I think I have found out the reason for the problem, and it proved my guesses. When executing the test case of the static analyzer, we usually use `%clang_analyze_cc1` as the entry, which is `%clang_cc1 -analyze`. And we usually do not set a target triple, as it

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

vsapsai added a comment. In my testing I was able to find a case where we go around `requires` like // module.modulemap module Main { header "main.h" export * extern module A "extra.modulemap" requires nonsense { extern module B "extra.modulemap" } } //

[PATCH] D119806: [clangd][NFC] includes missing headers

cjdb created this revision. cjdb added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. cjdb requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. `Shutdown.h` was transitively

[PATCH] D119745: [libTooling] Change Tranformer's consumer to take multiple changes

li.zhe.hua updated this revision to Diff 408699. li.zhe.hua added a comment. Attempt fix for Windows compilation issue Work around ambiguous function call by foregoing the delgating constructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119655: [Driver][NetBSD] -r: imply -nostdlib like GCC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd241ce0f97e4: [Driver][NetBSD] -r: imply -nostdlib like GCC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d241ce0 - [Driver][NetBSD] -r: imply -nostdlib like GCC

Author: Brad Smith Date: 2022-02-14T23:29:13-05:00 New Revision: d241ce0f97e47afa4f01a643ebbb4eafd729b403 URL: https://github.com/llvm/llvm-project/commit/d241ce0f97e47afa4f01a643ebbb4eafd729b403 DIFF: https://github.com/llvm/llvm-project/commit/d241ce0f97e47afa4f01a643ebbb4eafd729b403.diff

[PATCH] D119655: [Driver][NetBSD] -r: imply -nostdlib like GCC

MaskRay added a comment. In D119655#3318586 , @joerg wrote: > Well, it doesn't work with GCC either, that's why I don't care much about > this change. It just attempts to legalize a user bug (using a linker option > directly as a compiler flag). But I

[PATCH] D119656: [Driver][DragonFly] -r: imply -nostdlib like GCC

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbd9d136ef81: [Driver][DragonFly] -r: imply -nostdlib like GCC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119656/new/

[clang] cbd9d13 - [Driver][DragonFly] -r: imply -nostdlib like GCC

Author: Brad Smith Date: 2022-02-14T23:24:26-05:00 New Revision: cbd9d136ef8164970957317737cf51182acd236c URL: https://github.com/llvm/llvm-project/commit/cbd9d136ef8164970957317737cf51182acd236c DIFF: https://github.com/llvm/llvm-project/commit/cbd9d136ef8164970957317737cf51182acd236c.diff

[PATCH] D119714: [clang][lex] Remove `Preprocessor::GetCurDirLookup()`

dexonsmith accepted this revision. dexonsmith added a comment. LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119714/new/ https://reviews.llvm.org/D119714 ___ cfe-commits mailing list

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

ChuanqiXu added inline comments. Comment at: clang/test/CXX/modules-ts/basic/basic.def.odr/p4/module.cpp:5 // CHECK-DAG: @extern_var_exported = external {{(dso_local )?}}global -// CHECK-DAG: @inline_var_exported = linkonce_odr {{(dso_local )?}}global +// CHECK-DAG:

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

ChuanqiXu updated this revision to Diff 408694. ChuanqiXu added a comment. Update tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119409/new/ https://reviews.llvm.org/D119409 Files: clang/lib/Serialization/ASTWriterDecl.cpp

[PATCH] D119778: [clang] Add a note "deducing return type for 'foo'"

ChuanqiXu added a comment. I am curious about the behavior if we removed the guard `if (OrigResultType.getBeginLoc().isValid())`. Comment at: clang/lib/Sema/SemaStmt.cpp:3804-3807 +if (DAR != DAR_Succeeded) { + if (OrigResultType.getBeginLoc().isValid()) +

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

MaskRay added a comment. The Clang driver change should be in a separate patch with clang/test/Driver tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91605/new/ https://reviews.llvm.org/D91605 ___

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

MaskRay added a comment. `GetTls` is about the static TLS block size. It consists of the main executable's TLS, and initially loaded shared objects' TLS, `struct pthread`, and padding. Solaris should be able to just use the code path like Linux musl: #elif SANITIZER_FREEBSD ||

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

junaire added a comment. In D119528#3319955 , @aaron.ballman wrote: > LGTM, thank you for the additional test coverage! Do you need me to commit on > your behalf? If so, what name and email address would you like me to use for > patch attribution?

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

This revision was automatically updated to reflect the committed changes. Closed by commit rGeffd6dd63a65: [Clang][Sema] Add a missing regression test about Wliteral-range (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] effd6dd - [Clang][Sema] Add a missing regression test about Wliteral-range

Author: Jun Zhang Date: 2022-02-15T09:46:42+08:00 New Revision: effd6dd63a65f201b4f8f1be6a025b0608604449 URL: https://github.com/llvm/llvm-project/commit/effd6dd63a65f201b4f8f1be6a025b0608604449 DIFF: https://github.com/llvm/llvm-project/commit/effd6dd63a65f201b4f8f1be6a025b0608604449.diff

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. Thank you for your clarification. I'll change it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105169/new/ https://reviews.llvm.org/D105169 ___ cfe-commits mailing list

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw updated this revision to Diff 408673. zixuw added a comment. Convert file path to forward slashes for the URI scheme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119479/new/ https://reviews.llvm.org/D119479 Files:

[PATCH] D119761: [OpenMP]Fix parsing of OpenMP directive nested in a metadirective

This revision was automatically updated to reflect the committed changes. Closed by commit rG83a407d176f8: [OpenMP]Fix parsing of OpenMP directive nested in a metadirective (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] 83a407d - [OpenMP]Fix parsing of OpenMP directive nested in a metadirective

Author: Mike Rice Date: 2022-02-14T16:15:20-08:00 New Revision: 83a407d176f84c53633a2ef259642ff184e0613f URL: https://github.com/llvm/llvm-project/commit/83a407d176f84c53633a2ef259642ff184e0613f DIFF: https://github.com/llvm/llvm-project/commit/83a407d176f84c53633a2ef259642ff184e0613f.diff

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

pcc added a comment. In D115844#3321235 , @ychen wrote: > In D115844#3321190 , @pcc wrote: > >> On the bug you have: >> >> define internal fastcc void >> @_Z4callIiE4taskv.resume(%_Z4callIiE4taskv.Frame*

[PATCH] D118862: [clang][driver] add clang driver support for emitting macho files with two build version load commands

arphaman added a comment. In D118862#3321343 , @gulfem wrote: > The following two tests started failing in our bots: > > Clang :: Driver/darwin-ld-platform-version-target-version.c > Clang :: Driver/darwin-zippered-target-version.c > >

[PATCH] D118855: [modules] Add a flag for TagDecl if it was a definition demoted to a declaration.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa4a0f1d31e2: [modules] Add a flag for TagDecl if it was a definition demoted to a… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fa4a0f1 - [modules] Add a flag for TagDecl if it was a definition demoted to a declaration.

Author: Volodymyr Sapsai Date: 2022-02-14T16:04:40-08:00 New Revision: fa4a0f1d31e2f797c3e27eb7cad15755e46a4726 URL: https://github.com/llvm/llvm-project/commit/fa4a0f1d31e2f797c3e27eb7cad15755e46a4726 DIFF:

[PATCH] D118862: [clang][driver] add clang driver support for emitting macho files with two build version load commands

gulfem added a comment. The following two tests started failing in our bots: Clang :: Driver/darwin-ld-platform-version-target-version.c Clang :: Driver/darwin-zippered-target-version.c

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

MaskRay added a comment. In D105169#3321237 , @hyeongyukim wrote: > In D105169#3319773 , @dblaikie > wrote: > >> In D105169#3315009 , @MaskRay >> wrote: >> >>> It may

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

Izaron added a comment. Cases that show the difference (they're covered in tests, though do we need an AST test as well?): X test(bool B) { if (B) { X y; // before: nrvo, after: nrvo (same) return y; } X x; // before: no nrvo, after: nrvo (better) return x; }

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

Izaron added a comment. There is a nice proposal (P2025) Guaranteed copy elision for return variables by **Anton Zhilin**. The poll on the proposal showed that its ideas are very welcome: link to cplusplus/papers github

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

Izaron created this revision. Izaron added reviewers: lebedev.ri, rsmith. Izaron requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before the patch we calculated the NRVO candidate looking at the variable's whole enclosing scope. The

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. In D105169#3319773 , @dblaikie wrote: > In D105169#3315009 , @MaskRay wrote: > >> It may not be worth changing now, but I want to mention: it's more >> conventional to have a

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added a comment. In D115844#3321190 , @pcc wrote: > On the bug you have: > > define internal fastcc void > @_Z4callIiE4taskv.resume(%_Z4callIiE4taskv.Frame* noalias nonnull > align 8 dereferenceable(24 > ) %FramePtr) #1 prologue <{ i32,

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D119613: [OpenMP] Add support for CPU offloading in new driver

jdoerfert added a comment. We should be able to test this with unit tests, no? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119613/new/ https://reviews.llvm.org/D119613 ___ cfe-commits mailing list

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

pcc added a comment. On the bug you have: define internal fastcc void @_Z4callIiE4taskv.resume(%_Z4callIiE4taskv.Frame* noalias nonnull align 8 dereferenceable(24 ) %FramePtr) #1 prologue <{ i32, i32 }> <{ i32 846595819, i32 trunc (i64 sub (i64 ptrtoint (i8** @1 to i64), i64 ptrtoint

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith added reviewers: beanz, efriedma. keith added a comment. Adding folks from https://reviews.llvm.org/D69597 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith created this revision. Herald added subscribers: dexonsmith, pengfei, hiraditya, kristof.beyls. keith requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This improves the getHostCPUName check for Apple M1

[PATCH] D119745: [libTooling] Change Tranformer's consumer to take multiple changes

li.zhe.hua added a comment. In D119745#3320154 , @ymandel wrote: > Looks good. But, please add tests. Thanks! Done; added a test for a multi-AtomicChange edit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119745: [libTooling] Change Tranformer's consumer to take multiple changes

li.zhe.hua updated this revision to Diff 408636. li.zhe.hua marked 2 inline comments as done. li.zhe.hua added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119745/new/ https://reviews.llvm.org/D119745 Files:

[PATCH] D119785: [clang-format] Fix formatting of struct-like records followed by variable declaration.

curdeius updated this revision to Diff 408629. curdeius added a comment. Remove unused. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119785/new/ https://reviews.llvm.org/D119785 Files: clang/lib/Format/FormatToken.h

[PATCH] D119785: [clang-format] Fix formatting of struct-like records followed by variable declaration.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/24781. Fixes

[PATCH] D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support

arphaman updated this revision to Diff 408621. arphaman added a comment. Add checking for -darwin-target-variant support CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118875/new/ https://reviews.llvm.org/D118875 Files: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake

[PATCH] D119778: [clang] Add a note "deducing return type for 'foo'"

Quuxplusone created this revision. Quuxplusone added reviewers: sammccall, rsmith, dblaikie, majnemer, mizvekov, ChuanqiXu. Quuxplusone added a project: clang. Quuxplusone requested review of this revision. Herald added a subscriber: cfe-commits. Emit the note when we fail to deduce a return

[PATCH] D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support

arphaman added a comment. In D118875#3296030 , @bc-lee wrote: > Hi, I built and tested clang using this patch and > https://reviews.llvm.org/D118862. It works great. > The current patch adds the -darwin-target-variant flag to all object files > for

[PATCH] D119184: [clang] [concepts] Check constrained-auto return types for void-returning functions

Quuxplusone updated this revision to Diff 408594. Quuxplusone marked an inline comment as done and an inline comment as not done. Quuxplusone added a comment. Address review comments; add exhaustive tests as a parent revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119184/new/

[PATCH] D119726: [asan] Add support for disable_sanitizer_instrumentation attribute

eugenis accepted this revision. eugenis added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119726/new/ https://reviews.llvm.org/D119726 ___ cfe-commits mailing list

[clang] 688622f - [clang][test] Add -fuse-ld= to test cases added in d238acd1131ec2670acf5cf47b89069ca6c2e86c to resolve test failure with CLANG_DEFAULT_LINKER=lld

Author: Alex Lorenz Date: 2022-02-14T13:21:39-08:00 New Revision: 688622ff607ca1b15e76f9b4f6216f78dd22fab2 URL: https://github.com/llvm/llvm-project/commit/688622ff607ca1b15e76f9b4f6216f78dd22fab2 DIFF: https://github.com/llvm/llvm-project/commit/688622ff607ca1b15e76f9b4f6216f78dd22fab2.diff

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1764 +def NoInline : DeclOrStmtAttr { + let Spellings = [Clang<"noinline">, Declspec<"noinline">]; + let Documentation = [NoInlineDocs]; What I need to mention here. With

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added inline comments. Comment at: clang/test/CodeGen/attr-noinline.cpp:11 + +void foo(int i) { + [[clang::noinline]] bar(); kuhar wrote: > Could you also add a test function that is already marked as noinline at the > declaration? Yes, added

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 updated this revision to Diff 408588. xbolva00 added a comment. More tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[PATCH] D119745: [libTooling] Change Tranformer's consumer to take multiple changes

li.zhe.hua updated this revision to Diff 408587. li.zhe.hua added a comment. Update based on comments. Update test to switch off depreated constructor. Fix assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119745/new/

[PATCH] D119772: [clang] [NFC] More exhaustive tests for deducing void return types

Quuxplusone created this revision. Quuxplusone added reviewers: sammccall, rsmith, dblaikie, mizvekov. Quuxplusone added a project: clang. Quuxplusone requested review of this revision. Herald added a subscriber: cfe-commits. This is a preliminary ahead of D119184

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 updated this revision to Diff 408580. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 updated this revision to Diff 408578. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:522 + let Content = [{ +This function attribute suppresses the inlining of a function at the call sites +of the function. Feel free to suggest better wording :)

[PATCH] D119061: [Clang] noinline call site attribute

kuhar added inline comments. Comment at: clang/test/CodeGen/attr-noinline.cpp:11 + +void foo(int i) { + [[clang::noinline]] bar(); Could you also add a test function that is already marked as noinline at the declaration? CHANGES SINCE LAST ACTION

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 updated this revision to Diff 408573. xbolva00 added a comment. Added check to warn for conflicting attributes. More docs, tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 Files: clang/include/clang/Basic/Attr.td

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added a comment. Fixes for inliners landed, working on this now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D118862: [clang][driver] add clang driver support for emitting macho files with two build version load commands

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd238acd1131e: [clang][driver] add clang driver support for emitting macho files with two… (authored by arphaman). Changed prior to commit:

[clang] d238acd - [clang][driver] add clang driver support for emitting macho files with two build version load commands

Author: Alex Lorenz Date: 2022-02-14T12:27:14-08:00 New Revision: d238acd1131ec2670acf5cf47b89069ca6c2e86c URL: https://github.com/llvm/llvm-project/commit/d238acd1131ec2670acf5cf47b89069ca6c2e86c DIFF: https://github.com/llvm/llvm-project/commit/d238acd1131ec2670acf5cf47b89069ca6c2e86c.diff

[PATCH] D119711: Add asan support for MSVC debug runtimes

cbezault added a comment. Imo I agree that this shouldn’t be merged until the debug variants of the asan runtime are getting built publicly. @stevewishnousky Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119711/new/

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

xbolva00 added a subscriber: aaron.ballman. xbolva00 added inline comments. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:186 void VisitCallExpr(const CallExpr *E) { FoundCallExpr = true; } + void VisitAsmStmt(const AsmStmt *S) { FoundCallExpr = true; }

[PATCH] D118855: [modules] Add a flag for TagDecl if it was a definition demoted to a declaration.

vsapsai added a comment. In D118855#3320064 , @Bigcheese wrote: > lgtm. Thanks for the review, Michael! I'll give some time to the pre-merge checks to run, then will land the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118855: [modules] Add a flag for TagDecl if it was a definition demoted to a declaration.

vsapsai updated this revision to Diff 408536. vsapsai added a comment. Update assertion message wording to be more actionable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118855/new/ https://reviews.llvm.org/D118855 Files:

[PATCH] D118855: [modules] Add a flag for TagDecl if it was a definition demoted to a declaration.

vsapsai added a comment. Thanks for the review, Dan! Comment at: clang/include/clang/AST/Decl.h:1383-1398 /// If this definition should pretend to be a declaration. bool isThisDeclarationADemotedDefinition() const { return isa(this) ? false :

[PATCH] D119745: [libTooling] Change Tranformer's consumer to take multiple changes

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Looks good. But, please add tests. Thanks! Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:27 + using ChangesConsumer = std::function> Changes)>;

[PATCH] D119612: [clang] Pass more flags to ld64.lld

MaskRay added inline comments. Comment at: clang/test/Driver/darwin-ld-dedup.c:4 +// -no_deduplicate is only present from ld64 version 262 and later, or lld. +// RUN: %clang -target x86_64-apple-darwin10 -### -fuse-ld= %s \ // RUN: -mlinker-version=261 -O0 2>&1 | FileCheck

[PATCH] D119707: [C2x] Implement WG14 N2764 the [[noreturn]] attribute

aaron.ballman added a comment. I've made the requested changes from @jyknight in a766545402d8569532294d097d026cf2e837b5c2 -- please let me know if there are more issues you'd like me to address. Thank you for the

[PATCH] D118855: [modules] Add a flag for TagDecl if it was a definition demoted to a declaration.

delcypher added a comment. Change seems reasonable but I don't have expertise on this code. I've left a few minor nits. Comment at: clang/include/clang/AST/Decl.h:3494 + /// symbol and not interested in the final AST with deduplicated definitions. + bool

[PATCH] D119612: [clang] Pass more flags to ld64.lld

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:272 - // ld64 version 262 and above run the deduplicate pass by default. - if (Version >= VersionTuple(262) && shouldLinkerNotDedup(C.getJobs().empty(), Args)) + // ld64 version 262 and above

[clang] a766545 - Update the diagnostic behavior of [[noreturn]] in C2x

Author: Aaron Ballman Date: 2022-02-14T14:04:32-05:00 New Revision: a766545402d8569532294d097d026cf2e837b5c2 URL: https://github.com/llvm/llvm-project/commit/a766545402d8569532294d097d026cf2e837b5c2 DIFF: https://github.com/llvm/llvm-project/commit/a766545402d8569532294d097d026cf2e837b5c2.diff

[PATCH] D118855: [modules] Add a flag for TagDecl if it was a definition demoted to a declaration.

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118855/new/ https://reviews.llvm.org/D118855

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

aaron.ballman added a comment. In D119525#3317623 , @tbaeder wrote: > In D119525#3314383 , @aaron.ballman > wrote: > >> Can you also add a release note for the change? > > Would this go in the "libclang" section

[PATCH] D119745: [libTooling] Change Tranformer's consumer to take multiple changes

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. li.zhe.hua requested review of this revision. Herald added a project: clang. Previously, Transformer would invoke the consumer once per file modified per match, in addition to any errors encountered. The consumer is not aware

[PATCH] D119528: [Clang][Sema] Add a missing regression test about Wliteral-range

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the additional test coverage! Do you need me to commit on your behalf? If so, what name and email address would you like me to use for patch attribution?

[PATCH] D119095: [clang] Fix redundant functional cast in ConstantExpr

aaron.ballman added a comment. I haven't had the chance to review this yet (in C standards meetings again this week), but I did notice that https://reviews.llvm.org/D119477 seems to be touching on a related (or possibly the same) issue. Can you coordinate with the other patch author to make

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

aaron.ballman added a comment. I haven't had the chance to review this yet (in C standards meetings again this week), but I did notice that https://reviews.llvm.org/D119095 seems to be touching on a related (or possibly the same) issue. Can you coordinate with the other patch author to make

[PATCH] D78762: build: use `find_package(Python3)` if available

hans added a comment. Herald added a project: clang-tools-extra. What's the new cmake flag to set the python executable, and should we update llvm/docs/GettingStarted.rst to not refer to PYTHON_EXECUTABLE anymore? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash updated this revision to Diff 408498. vtjnash added a comment. fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119591/new/ https://reviews.llvm.org/D119591 Files: clang/CMakeLists.txt

[PATCH] D119707: [C2x] Implement WG14 N2764 the [[noreturn]] attribute

aaron.ballman added inline comments. Comment at: clang/lib/Headers/stdnoreturn.h:19 +/* The noreturn macro is deprecated in C2x. */ +#pragma clang deprecated(noreturn) + aaron.ballman wrote: > jyknight wrote: > > Is this actually useful? Isn't it sufficient to

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash added a comment. We are not going to start exporting plugin support if the user explicitly disabled it with CLANG_PLUGIN_SUPPORT=OFF, but why is it trying to read that directory at all, when it should be disallowed by this PR unless CLANG_PLUGIN_SUPPORT=ON Repository: rG LLVM

[PATCH] D119591: clang-analyzer plugins require LLVM_ENABLE_PLUGINS also

vtjnash updated this revision to Diff 408491. vtjnash added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119591/new/ https://reviews.llvm.org/D119591 Files: clang/CMakeLists.txt

[PATCH] D119711: Add asan support for MSVC debug runtimes

rnk added subscribers: cbezault, vitalybuka. rnk added a comment. I'm hesitant to do this. The main reason we disabled the use of the debug runtimes was that the debug runtimes interfered with malloc interception, which leads to crashes and a generally poor user experience. I'd like some

[PATCH] D117989: [RISCV] Add the passthru operand for RVV nomask binary intrinsics.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:181 + // The nomask intrinsic IR have the passthru operand. + bit HasNoMaskPolicy = false; + Should this be `HasNoMaskPassThru` rather than `Policy`?

[PATCH] D119095: [clang] Fix redundant functional cast in ConstantExpr

erichkeane added a comment. I think this makes sense to me, I'd like to see it captured in an AST test though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119095/new/ https://reviews.llvm.org/D119095

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane added a comment. In D110641#3319787 , @cor3ntin wrote: > In D110641#3064200 , @erichkeane > wrote: > >> Ping! Does anyone have any feedback on this? I'd really like to start >> getting us caught up

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

cor3ntin added a comment. In D110641#3064200 , @erichkeane wrote: > Ping! Does anyone have any feedback on this? I'd really like to start > getting us caught up on standards implementation, and this seems like it > might be an easy win (unless

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

dblaikie added a comment. In D105169#3315009 , @MaskRay wrote: > It may not be worth changing now, but I want to mention: it's more > conventional to have a `BoolOption` which adds `-[no-]noundef-analysis`. > Since both positive and negative forms

[PATCH] D119651: [clang] Fix evaluation context type for consteval function calls in instantiations

cor3ntin added a comment. > I like the idea of the assert, can we do it as a part of this? That way when > we run into it it becomes more obvious/linked to this discussion. I think that's a good idea too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119707: [C2x] Implement WG14 N2764 the [[noreturn]] attribute

jyknight added inline comments. Comment at: clang/lib/Headers/stdnoreturn.h:22 +/* Including the header file in C2x is also deprecated. */ +#warning "the '' header is deprecated in C2x" +#endif aaron.ballman wrote: > jyknight wrote: > > Would be nice to mention

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. D72404 has some comments why the -Os/-Oz levels are discouraged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118987: [analyzer] Add failing test case demonstrating buggy taint propagation

steakhal reopened this revision. steakhal added a subscriber: simoll. steakhal added a comment. This revision is now accepted and ready to land. It seems like the `clang-ve-ninja` doesn't really want to accept any patches from me :D I hope it's not personal. Let's be friends bot, please. I'm

[clang] b8ae323 - Revert "[analyzer] Add failing test case demonstrating buggy taint propagation"

Author: Balazs Benics Date: 2022-02-14T18:45:46+01:00 New Revision: b8ae323cca61dc1edcd36e9ae18c7e4c3d76d52e URL: https://github.com/llvm/llvm-project/commit/b8ae323cca61dc1edcd36e9ae18c7e4c3d76d52e DIFF: https://github.com/llvm/llvm-project/commit/b8ae323cca61dc1edcd36e9ae18c7e4c3d76d52e.diff

[clang] d16c5f4 - Revert "[analyzer] Fix taint propagation by remembering to the location context"

Author: Balazs Benics Date: 2022-02-14T18:45:46+01:00 New Revision: d16c5f4192c30d53468a472c6820163a81192825 URL: https://github.com/llvm/llvm-project/commit/d16c5f4192c30d53468a472c6820163a81192825 DIFF: https://github.com/llvm/llvm-project/commit/d16c5f4192c30d53468a472c6820163a81192825.diff

  1   2   3   >