[PATCH] D119998: [Clang] Rename `disable-noundef-analysis` flag to `-[no-]enable-noundef-analysis`

MaskRay added a comment. > enable_noundef_analysis `-enable-noundef-analysis` If there is a need for an alias `-disable-noundef-analysis`, we can add it later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119998/new/

[PATCH] D119998: [Clang] Rename `disable-noundef-analysis` flag to `-[no-]enable-noundef-analysis`

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119998/new/ https://reviews.llvm.org/D119998

[PATCH] D118598: [C++20][Modules][7/8] Find the primary interface name for a module.

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/Module.h:527 +} +return StringRef(Name); + } Here we could return `Name` simply. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118586: [C++20][Modules][3/8] Initial handling for module partitions.

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:177 + if (IsPartition) { +ModuleName += ":"; +ModuleName += stringFromPath(Partition); iains wrote: > urnathan wrote: > > iains wrote: > > > ChuanqiXu wrote: > > > > I chose '-'

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

ChuanqiXu added a comment. Thanks for explanation. Now it looks good to me. Let's accept it formally after the series of partition landed and so that we could add test about partitions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352

[PATCH] D120084: [clang][DOC] Document module mangler changes

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120084/new/ https://reviews.llvm.org/D120084 ___ cfe-commits mailing list

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

ye-luo added a comment. Change title threat state to thread state Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120106/new/ https://reviews.llvm.org/D120106 ___ cfe-commits mailing list

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

davidstone added a comment. In D99134#3331259 , @rsmith wrote: > Looks good. Do you need someone to land this for you? Yes, I do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99134/new/

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

jrtc27 added inline comments. Comment at: llvm/lib/Support/Host.cpp:1320 + int Error = sysctlbyname("hw.cpufamily", , , NULL, 0); + assert(!Error && "Fetching hw.cpufamily failed"); Not sure this should be an assert? I think other implementations will fall

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jhuber6 updated this revision to Diff 409850. jhuber6 added a comment. Changing assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120106/new/ https://reviews.llvm.org/D120106 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Last nit, otherwise LG Comment at: openmp/libomptarget/DeviceRTL/src/State.cpp:385 + if (!config::mayUseThreadStates()) +ASSERT(false && "Thread state modified

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith added a comment. Thanks for the tips! I left the default as generic here, but I totally take your point on defaulting to the newest and I'm happy to update if you feel strongly, lmk what you think Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith updated this revision to Diff 409849. keith added a comment. Update to read CPU from sysctl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jhuber6 updated this revision to Diff 409847. jhuber6 added a comment. Change name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120106/new/ https://reviews.llvm.org/D120106 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jhuber6 updated this revision to Diff 409845. jhuber6 added a comment. Making suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120106/new/ https://reviews.llvm.org/D120106 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jdoerfert added a comment. I'd go with `config::mayRequireThreadSpecificState` or sth. Also some documentation there. you should be able to use assertions, like `ASSERT(false && "")`. Which gives us messages in assert mode if violated. Clang documentation should be something like `no

[PATCH] D120106: [OpenMP] Add flag for disabling threat state in runtime

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992. Herald added subscribers: dexonsmith, dang, guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, OpenMP. The

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

rsmith accepted this revision. rsmith added a comment. Looks good. Do you need someone to land this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99134/new/ https://reviews.llvm.org/D99134 ___

[PATCH] D112916: Confusable identifiers detection

rsmith added a comment. In D112916#3290365 , @serge-sans-paille wrote: > @rsmith : once the licensing issue has been fixed, can we merge that patch or > do you have any other thought? I have no concerns once the licensing question is resolved and the

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

junaire added a comment. gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119609/new/ https://reviews.llvm.org/D119609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118525/new/ https://reviews.llvm.org/D118525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

kuzkry added a comment. First of all, thanks @MyDeveloperDay for the approval. In D119682#3321965 , @MyDeveloperDay wrote: > @HazardyKnusperkeks could you validate the `IndentRequiresClause` I know I > added `IndentRequires` in 13 but is this the same

[clang] 0b5fe2c - [clang] Remove Address::deprecated() in emitVoidPtrDirectVAArg()

Author: Arthur Eubanks Date: 2022-02-17T15:05:50-08:00 New Revision: 0b5fe2c9f2e5bdfb111068fab1f6689c066422aa URL: https://github.com/llvm/llvm-project/commit/0b5fe2c9f2e5bdfb111068fab1f6689c066422aa DIFF:

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

ormris added a comment. Hi Shangwu, I've reverted this change to unblock the buildbots and our internal CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119207/new/ https://reviews.llvm.org/D119207

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

pirama added subscribers: pirama, srhines, kongyi. pirama added a comment. Unrelated to missing resolver definition, this change doesn't accommodate resolvers that take parameters. (Curiously, this verification only fails with ThinLTO). // with -flto=full or without -flto=thin, below

[clang] 9ce0909 - Revert "[CUDA][SPIRV] Assign global address space to CUDA kernel arguments"

Author: Matthew Voss Date: 2022-02-17T14:32:10-08:00 New Revision: 9ce09099bba4be68d2a269b0bfd2b1dcc67f02d4 URL: https://github.com/llvm/llvm-project/commit/9ce09099bba4be68d2a269b0bfd2b1dcc67f02d4 DIFF: https://github.com/llvm/llvm-project/commit/9ce09099bba4be68d2a269b0bfd2b1dcc67f02d4.diff

[PATCH] D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo

tyb0807 updated this revision to Diff 409796. tyb0807 added a comment. Remove reference to unused ACLE macro `__ARM_FEATURE_CRYPTO` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118757/new/ https://reviews.llvm.org/D118757 Files:

[clang] ba9944e - [clang] Remove Address::deprecated() in CGCXXABI.h

Author: Arthur Eubanks Date: 2022-02-17T14:23:02-08:00 New Revision: ba9944ea1dff507839df8e4cf9897a5d4916ec68 URL: https://github.com/llvm/llvm-project/commit/ba9944ea1dff507839df8e4cf9897a5d4916ec68 DIFF:

[PATCH] D120086: Explicitly document that `__is_trivially_relocatable(T)` implies that `T` is implicit-lifetime.

devin.jeanpierre updated this revision to Diff 409794. devin.jeanpierre added a comment. Rebase off of D119385 . Sorry, I'm bad at git. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120086/new/

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 409791. tianshilei1992 added a comment. add a small test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D119392: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

tianshilei1992 updated this revision to Diff 409784. tianshilei1992 added a comment. add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119392/new/ https://reviews.llvm.org/D119392 Files: clang/lib/Sema/SemaOpenMP.cpp

[clang] 0e219af - [clang] Remove Address::deprecated() call in CGExprCXX.cpp

Author: Arthur Eubanks Date: 2022-02-17T13:58:26-08:00 New Revision: 0e219af475430ab338c9d76a101a78304a64f78a URL: https://github.com/llvm/llvm-project/commit/0e219af475430ab338c9d76a101a78304a64f78a DIFF:

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw updated this revision to Diff 409783. zixuw added a comment. Use `%/t` for path substitution to normalize path separators for file URI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119479/new/ https://reviews.llvm.org/D119479 Files:

[PATCH] D119612: [clang] Pass more flags to ld64.lld

thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119612/new/ https://reviews.llvm.org/D119612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120086: Explicitly document that `__is_trivially_relocatable(T)` implies that `T` is implicit-lifetime.

Quuxplusone added a comment. FWIW, I think this is a good idea. I even think that the parentheses and "Note:" are too self-deprecating, and this deserves to be a bigger deal. Perhaps `__is_implicit_lifetime(T)` should be an intrinsic in its own right! Then you could say very concretely that

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis closed this revision. thakis added a comment. If you put "Differential Revision: https://reviews.llvm.org/D109239; instead of just "https://reviews.llvm.org/D109239; in the commit message, phabricator will auto-close the review when the commit lands. Repository: rG LLVM Github

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. I saw that test failing again. I could repro the problem locally and fixed it in 1689b1092ebb2c630f8ef1d3880a9fb4808d16fa . I guess this did make it into the pch somehow after all. But all good now.

[PATCH] D119612: [clang] Pass more flags to ld64.lld

This revision was automatically updated to reflect the committed changes. Closed by commit rG383ed82dd1f8: [clang] Pass more flags to ld64.lld (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 383ed82 - [clang] Pass more flags to ld64.lld

Author: Nico Weber Date: 2022-02-17T16:45:52-05:00 New Revision: 383ed82dd1f8c4ea7e88a4cf92dd918dda794854 URL: https://github.com/llvm/llvm-project/commit/383ed82dd1f8c4ea7e88a4cf92dd918dda794854 DIFF: https://github.com/llvm/llvm-project/commit/383ed82dd1f8c4ea7e88a4cf92dd918dda794854.diff

[PATCH] D120086: Explicitly document that `__is_trivially_relocatable(T)` implies that `T` is implicit-lifetime.

devin.jeanpierre created this revision. devin.jeanpierre added reviewers: rsmith, rjmccall. devin.jeanpierre requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previous change: D114732 The wording here

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added a comment. In D116261#3330732 , @tianshilei1992 wrote: > We don't have Sema yet, so there is no erroneous test. But you have the checks for the clauses, repeated several times in a construct. Repository: rG LLVM Github Monorepo

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:6 + +// RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -target-cpu core2 -fopenmp-simd -fopenmp-version=51 -x c -emit-llvm %s

[clang] 1689b10 - unbreak Modules/cxx20-export-import.cpp with LLVM_APPEND_VC_REV after 32b73bc6ab82

Author: Nico Weber Date: 2022-02-17T16:33:39-05:00 New Revision: 1689b1092ebb2c630f8ef1d3880a9fb4808d16fa URL: https://github.com/llvm/llvm-project/commit/1689b1092ebb2c630f8ef1d3880a9fb4808d16fa DIFF: https://github.com/llvm/llvm-project/commit/1689b1092ebb2c630f8ef1d3880a9fb4808d16fa.diff

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 added a comment. We don't have Sema yet, so there is no erroneous test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 ___ cfe-commits mailing

[PATCH] D120084: [clang][DOC] Document module mangler changes

urnathan created this revision. urnathan added reviewers: ChuanqiXu, iains, rsmith. urnathan requested review of this revision. Note that the mangling has changed and the demangler's learnt a new trick. Obviously dependent upon the mangler and demangler patches.

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added a comment. Erroneous tests? Comment at: clang/lib/Sema/SemaOpenMP.cpp:11320 + bool MutexClauseEncountered = false; + llvm::SmallSet EncounteredAtomicKinds; for (const OMPClause *C : Clauses) { tianshilei1992 wrote: > ABataev wrote: > >

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

ABataev added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:6 + +// RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -target-cpu core2 -fopenmp-simd -fopenmp-version=51 -x c -emit-llvm %s -o - | FileCheck --check-prefix SIMD-ONLY0 %s +//

[PATCH] D119392: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

ABataev added a comment. Tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119392/new/ https://reviews.llvm.org/D119392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120028: [clang-format] Do not add space after return-like keywords in macros.

This revision was automatically updated to reflect the committed changes. Closed by commit rG331e8e4e27be: [clang-format] Do not add space after return-like keywords in macros. (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 331e8e4 - [clang-format] Do not add space after return-like keywords in macros.

Author: Marek Kurdej Date: 2022-02-17T22:12:39+01:00 New Revision: 331e8e4e27be5dd673898a89a7cf00e76903216a URL: https://github.com/llvm/llvm-project/commit/331e8e4e27be5dd673898a89a7cf00e76903216a DIFF: https://github.com/llvm/llvm-project/commit/331e8e4e27be5dd673898a89a7cf00e76903216a.diff

[PATCH] D120034: [clang-format] PROPOSAL - WIP: Added ability to parse template arguments

owenpan added a comment. +1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120034/new/ https://reviews.llvm.org/D120034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120081: [clang][ASTReader] Fix memory leak while reading FriendTemplateDecls

kadircet created this revision. kadircet added a reviewer: sammccall. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allocate on ASTContext, rather than just on heap, so that template parameter lists are freed up. Repository:

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

urnathan updated this revision to Diff 409761. urnathan added a subscriber: cfe-commits. urnathan added a comment. rebase on top of D116773 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352 Files:

[PATCH] D112081: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

rnk added a comment. In D112081#3330585 , @emmenlau wrote: > Current OpenSSL 1.1.1m requires `__STDC_NO_ATOMICS__` to build with clang-cl > against MSVC. Is this on-topic here? I think stdatomic.h is supposed to work with clang-cl, see this comment

[PATCH] D112081: Define __STDC_NO_THREADS__ when targeting windows-msvc (PR48704)

emmenlau added a comment. Current OpenSSL 1.1.1m requires `__STDC_NO_ATOMICS__` to build with clang-cl against MSVC. Is this on-topic here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112081/new/ https://reviews.llvm.org/D112081

[PATCH] D120065: [clang][SemaTemplate] Fix a stack use after scope

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc79c13cae615: [clang][SemaTemplate] Fix a stack use after scope (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] c79c13c - [clang][SemaTemplate] Fix a stack use after scope

Author: Kadir Cetinkaya Date: 2022-02-17T21:47:50+01:00 New Revision: c79c13cae61564d3a03831013ea24ff483ee3e82 URL: https://github.com/llvm/llvm-project/commit/c79c13cae61564d3a03831013ea24ff483ee3e82 DIFF:

[PATCH] D120065: [clang][SemaTemplate] Fix a stack use after scope

kadircet added inline comments. Comment at: clang/include/clang/AST/DeclTemplate.h:2464 FriendTemplateDecl(DeclContext *DC, SourceLocation Loc, - MutableArrayRef Params, + TemplateParameterList **Params, unsigned NumParams,

[PATCH] D120065: [clang][SemaTemplate] Fix a stack use after scope

kadircet updated this revision to Diff 409752. kadircet marked 2 inline comments as done. kadircet added a comment. - Inline `Params.size()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120065/new/ https://reviews.llvm.org/D120065 Files:

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth

vabridgers marked 5 inline comments as done. vabridgers added a comment. I believe I've addressed all of Artem's comments thus far. This is a NFC patch, so will include no test cases. We detected these inconsistencies in getting NULL pointers in our downstream target, that supports 2 different

[clang] f5b85f1 - Use functions with prototypes when appropriate; NFC

Author: Aaron Ballman Date: 2022-02-17T15:33:50-05:00 New Revision: f5b85f15510db409277d8492524b2fc040e776d8 URL: https://github.com/llvm/llvm-project/commit/f5b85f15510db409277d8492524b2fc040e776d8 DIFF: https://github.com/llvm/llvm-project/commit/f5b85f15510db409277d8492524b2fc040e776d8.diff

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth

vabridgers updated this revision to Diff 409750. vabridgers added a comment. Address NoQ comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119601/new/ https://reviews.llvm.org/D119601 Files:

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added a comment. Ping. Waiting for review feedback for about a week now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

dyung added a comment. In D119207#3330494 , @shangwuyao wrote: > In D119207#3330385 , @dyung wrote: > >> Hi, the test you added is failing on the PS4 Linux bot, can you take a look? >> >>

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao added a comment. In D119207#3330385 , @dyung wrote: > Hi, the test you added is failing on the PS4 Linux bot, can you take a look? > > https://lab.llvm.org/buildbot/#/builders/139/builds/17199 Looks like the compiled SPIR-V is slightly

[PATCH] D119184: [clang] [concepts] Check constrained-auto return types for void-returning functions

Quuxplusone updated this revision to Diff 409740. Quuxplusone added a comment. Rebase and update — this is becoming more and more of a trivial patch, which I guess is good! Add a test case for https://github.com/llvm/llvm-project/issues/53911 (which I finally thought to test, and was surprised

[PATCH] D119562: Provide fine control of color in run-clang-tidy

kesyog marked an inline comment as done. kesyog added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119562/new/ https://reviews.llvm.org/D119562 ___ cfe-commits mailing list

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

pcc added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116774/new/ https://reviews.llvm.org/D116774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120078: Insert MIRProfile into LLD

Roger created this revision. Herald added subscribers: ormris, steven_wu, hiraditya. Roger requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120078 Files:

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82e5f951fd6e: AST: Move __va_list tag back to std conditionally on AArch64. (authored by pcc). Changed prior to commit:

[clang] 18ead23 - AST: Make getEffectiveDeclContext() a member function of ItaniumMangleContextImpl. NFCI.

Author: Peter Collingbourne Date: 2022-02-17T11:31:40-08:00 New Revision: 18ead23385a4e0e6421d658591b1ee6a1c592b53 URL: https://github.com/llvm/llvm-project/commit/18ead23385a4e0e6421d658591b1ee6a1c592b53 DIFF:

[clang] 82e5f95 - AST: Move __va_list tag back to std conditionally on AArch64.

Author: Peter Collingbourne Date: 2022-02-17T11:31:40-08:00 New Revision: 82e5f951fd6e6ad6323067d8afcf025fc72d9c33 URL: https://github.com/llvm/llvm-project/commit/82e5f951fd6e6ad6323067d8afcf025fc72d9c33 DIFF:

[PATCH] D116773: AST: Make getEffectiveDeclContext() a member function of ItaniumMangleContextImpl. NFCI.

This revision was automatically updated to reflect the committed changes. Closed by commit rG18ead23385a4: AST: Make getEffectiveDeclContext() a member function of… (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D116773?vs=398007=409733#toc Repository: rG LLVM Github

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/solaris-ld-sanitizer.c:1 +// General tests that the ld -z relax=transtls workaround is only applied +// on Solaris/amd64. Note that we

[PATCH] D119309: [Driver][test] Clean up some AIX tests

MaskRay added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119309/new/ https://reviews.llvm.org/D119309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8555-8556 +// namespace std { struct __va_list { +NamespaceDecl *NS; +NS = NamespaceDecl::Create(const_cast(*Context), + Context->getTranslationUnitDecl(),

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

dyung added a comment. Hi, the test you added is failing on the PS4 Linux bot, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/17199 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119207/new/

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

jrtc27 added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8555-8556 +// namespace std { struct __va_list { +NamespaceDecl *NS; +NS = NamespaceDecl::Create(const_cast(*Context), + Context->getTranslationUnitDecl(),

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

aaron.ballman added a comment. Only a small nit from me. Comment at: clang/lib/AST/ASTContext.cpp:8555-8556 +// namespace std { struct __va_list { +NamespaceDecl *NS; +NS = NamespaceDecl::Create(const_cast(*Context), +

[PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf56cb520d855: [DEBUGINFO] [LLDB] Add support for generating debug-info for structured… (authored by shafik). Herald added projects: clang, LLDB.

[clang] f56cb52 - [DEBUGINFO] [LLDB] Add support for generating debug-info for structured bindings of structs and arrays

Author: Shafik Yaghmour Date: 2022-02-17T11:14:14-08:00 New Revision: f56cb520d8554ca42a215e82ecfa58d0b6c178e4 URL: https://github.com/llvm/llvm-project/commit/f56cb520d8554ca42a215e82ecfa58d0b6c178e4 DIFF:

[PATCH] D119979: [OpenMP] Diagnose bad 'omp declare variant' that references itself

jdoerfert added a comment. In D119979#3330343 , @mikerice wrote: > What's the use case? I wasn't aware of any. We saw it from someone who did > it accidently and caused the compiler to crash in codegen. If you have N overloads/variants and you want to

[PATCH] D119886: [AMDGPU] Promote recursive loads from kernel argument to constant

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0aa1946dfe1: [AMDGPU] Promote recursive loads from kernel argument to constant (authored by rampitec). Herald added a project: clang. Herald added

[clang] b0aa194 - [AMDGPU] Promote recursive loads from kernel argument to constant

Author: Stanislav Mekhanoshin Date: 2022-02-17T11:07:03-08:00 New Revision: b0aa1946dfe1d204e49b8238c4960f64a68f31d5 URL: https://github.com/llvm/llvm-project/commit/b0aa1946dfe1d204e49b8238c4960f64a68f31d5 DIFF:

[clang] 4dfa68e - [NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue.

Author: Zahira Ammarguellat Date: 2022-02-17T10:59:54-08:00 New Revision: 4dfa68e483137cc13eb9027c0dd834ede19f2fd4 URL: https://github.com/llvm/llvm-project/commit/4dfa68e483137cc13eb9027c0dd834ede19f2fd4 DIFF:

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2c91754a13f3: [Clang] Add attributes alloc_size and alloc_align to mm_malloc (authored by xbolva00). Repository: rG

[clang] 2c91754 - [Clang] Add attributes alloc_size and alloc_align to mm_malloc

Author: Dávid Bolvanský Date: 2022-02-17T19:59:18+01:00 New Revision: 2c91754a13f333d7fe9f9d3d40fb618e40c48cab URL: https://github.com/llvm/llvm-project/commit/2c91754a13f333d7fe9f9d3d40fb618e40c48cab DIFF:

[PATCH] D119979: [OpenMP] Diagnose bad 'omp declare variant' that references itself

mikerice added a comment. What's the use case? I wasn't aware of any. We saw it from someone who did it accidently and caused the compiler to crash in codegen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119979/new/

[clang] 5824d2b - Fix the declaration printer to properly handle prototypes in C

Author: Aaron Ballman Date: 2022-02-17T13:54:09-05:00 New Revision: 5824d2bb0f036e631419ae0993fd03d633398266 URL: https://github.com/llvm/llvm-project/commit/5824d2bb0f036e631419ae0993fd03d633398266 DIFF: https://github.com/llvm/llvm-project/commit/5824d2bb0f036e631419ae0993fd03d633398266.diff

[PATCH] D116773: AST: Make getEffectiveDeclContext() a member function of ItaniumMangleContextImpl. NFCI.

jrtc27 accepted this revision. jrtc27 added a comment. This revision is now accepted and ready to land. This makes sense to me but I don't know if you want someone with more authority in these parts to review it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

jrtc27 accepted this revision. jrtc27 added a comment. This revision is now accepted and ready to land. Thanks, looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116774/new/ https://reviews.llvm.org/D116774

[PATCH] D119979: [OpenMP] Diagnose bad 'omp declare variant' that references itself

jdoerfert reopened this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Why is this supposed to be a user error? I don't remember the standard disallowing this and I can see use cases for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D119612: [clang] Pass more flags to ld64.lld

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:272 - // ld64 version 262 and above run the deduplicate pass by default. - if (Version >= VersionTuple(262) && shouldLinkerNotDedup(C.getJobs().empty(), Args)) + // ld64 version 262 and above

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

pcc marked 2 inline comments as done. pcc added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116774/new/ https://reviews.llvm.org/D116774 ___ cfe-commits mailing list

[clang] 5364b36 - Revert "[Driver][Fuchsia][NFC] Use GetLinkerPath to see if linker is lld"

Author: Alex Brachet Date: 2022-02-17T18:41:49Z New Revision: 5364b36868210364b2ccf8e9f9169ed1fd545ae0 URL: https://github.com/llvm/llvm-project/commit/5364b36868210364b2ccf8e9f9169ed1fd545ae0 DIFF: https://github.com/llvm/llvm-project/commit/5364b36868210364b2ccf8e9f9169ed1fd545ae0.diff LOG:

[PATCH] D119612: [clang] Pass more flags to ld64.lld

int3 accepted this revision. int3 added a comment. This revision is now accepted and ready to land. lgtm! Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:272 - // ld64 version 262 and above run the deduplicate pass by default. - if (Version >= VersionTuple(262) &&

[PATCH] D116774: AST: Move __va_list tag back to std conditionally on AArch64.

pcc updated this revision to Diff 409716. pcc added a comment. Use isARM() etc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116774/new/ https://reviews.llvm.org/D116774 Files: clang/lib/AST/ASTContext.cpp clang/lib/AST/ItaniumMangle.cpp

[PATCH] D119979: [OpenMP] Diagnose bad 'omp declare variant' that references itself

This revision was automatically updated to reflect the committed changes. Closed by commit rG383f3a467c92: [OpenMP] Diagnose bad omp declare variant that references itself. (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] 383f3a4 - [OpenMP] Diagnose bad 'omp declare variant' that references itself.

Author: Mike Rice Date: 2022-02-17T10:36:28-08:00 New Revision: 383f3a467c92499956ed804eb2bd69ad8576615b URL: https://github.com/llvm/llvm-project/commit/383f3a467c92499956ed804eb2bd69ad8576615b DIFF: https://github.com/llvm/llvm-project/commit/383f3a467c92499956ed804eb2bd69ad8576615b.diff

[PATCH] D120070: [HIP] Support linking archive of bundled bitcode

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-link-bundle-archive.hip:3 + +// RUN: touch %T/libhipBundled.a + tra wrote: > Is this file necessary? `clang -###` should not need the file to be present >

  1   2   3   >