[clang] 3cfa32a - Undeprecate ATOMIC_FLAG_INIT in C++

2022-07-12 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2022-07-12T06:48:31-04:00 New Revision: 3cfa32a71ecfbc1bf993358e32b916cf3483299f URL: https://github.com/llvm/llvm-project/commit/3cfa32a71ecfbc1bf993358e32b916cf3483299f DIFF: https://github.com/llvm/llvm-project/commit/3cfa32a71ecfbc1bf993358e32b916cf3483299f.diff

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

2022-07-12 Thread weiyi via Phabricator via cfe-commits
wyt updated this revision to Diff 443905. wyt added a comment. Extract recursion into boolean subvalues into separate statements to enforce order of evaluation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129547/new/

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

2022-07-12 Thread H. Vetinari via Phabricator via cfe-commits
h-vetinari added a comment. Just comments, looks OK otherwise. Comment at: clang/test/CMakeLists.txt:6 CLANG_BUILD_EXAMPLES + CLANG_BUILT_STANDALONE CLANG_DEFAULT_PIE_ON_LINUX OT for this PR, but it would be nice to eventually rename this to

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

2022-07-12 Thread Danil Sidoruk via Phabricator via cfe-commits
eoanermine added a comment. In D129443#3644795 , @eoanermine wrote: > Add tests for AlignRequiresClauseBody option Are these tests fine? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

2022-07-12 Thread Danil Sidoruk via Phabricator via cfe-commits
eoanermine updated this revision to Diff 443895. eoanermine added a comment. Add tests for AlignRequiresClauseBody option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/ https://reviews.llvm.org/D129443 Files:

[PATCH] D129499: [clang] Do not crash on "requires" after a fatal error occurred.

2022-07-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. Thanks! The fix LG, just a small nitpick for the test from my side Comment at: clang/test/SemaCXX/concept-fatal-error.cpp:8 + // We test that we do not crash in such cases (#55401) + int i = requires { { i } f } // expected-error {{expected ';'

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

2022-07-12 Thread Danil Sidoruk via Phabricator via cfe-commits
eoanermine added a comment. In D129443#3641571 , @curdeius wrote: > Haven't you forgotten to add formatting tests? :) Yes, I have. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values.

2022-07-12 Thread weiyi via Phabricator via cfe-commits
wyt updated this revision to Diff 443868. wyt added a comment. Update CMakeList for DebugSupportTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129547/new/ https://reviews.llvm.org/D129547 Files:

[PATCH] D129548: [clang][dataflow] Generate readable form of input and output of satisfiability checking.

2022-07-12 Thread weiyi via Phabricator via cfe-commits
wyt created this revision. Herald added subscribers: martong, tschuett, mgrang, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends On D129547

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values.

2022-07-12 Thread weiyi via Phabricator via cfe-commits
wyt created this revision. Herald added subscribers: martong, tschuett, xazax.hun, mgorny. Herald added a reviewer: NoQ. Herald added a project: All. wyt requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Depends On D129546

[PATCH] D129546: [clang][dataflow] Refactor boolean creation as a test utility.

2022-07-12 Thread weiyi via Phabricator via cfe-commits
wyt created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129546

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

2022-07-12 Thread Pavel Samolysov via Phabricator via cfe-commits
psamolysov updated this revision to Diff 443860. psamolysov added a comment. Return the `PostOrderFunctionAttrsPass` pass back on its original place in the pipeline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128830/new/

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

2022-07-12 Thread Pavel Samolysov via Phabricator via cfe-commits
psamolysov added a comment. @aeubanks Hmm, if I correctly get your comment, I should revert this patch to the state before the proposed solution with moving the `PostOrderFunctionAttrsPass` at the end of the `buildInlinerPipeline` function regardless of the `readonly` instead of `readnone`

[clang] f44d28f - Fix build errors.

2022-07-12 Thread Manuel Klimek via cfe-commits
Author: Manuel Klimek Date: 2022-07-12T07:43:26Z New Revision: f44d28f840c0b0877b09d5547fd09e191bbdc90e URL: https://github.com/llvm/llvm-project/commit/f44d28f840c0b0877b09d5547fd09e191bbdc90e DIFF: https://github.com/llvm/llvm-project/commit/f44d28f840c0b0877b09d5547fd09e191bbdc90e.diff

[PATCH] D88299: [clang-format] Add MacroUnexpander.

2022-07-12 Thread Manuel Klimek via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6d0dc1f4537: [clang-format] Add MacroUnexpander. (authored by klimek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d6d0dc1 - [clang-format] Add MacroUnexpander.

2022-07-12 Thread Manuel Klimek via cfe-commits
Author: Manuel Klimek Date: 2022-07-12T07:11:46Z New Revision: d6d0dc1f45377ddaf5c10a48d64b09308b71501a URL: https://github.com/llvm/llvm-project/commit/d6d0dc1f45377ddaf5c10a48d64b09308b71501a DIFF: https://github.com/llvm/llvm-project/commit/d6d0dc1f45377ddaf5c10a48d64b09308b71501a.diff

[PATCH] D129534: [OpenMP] Do not link static library with `-nogpulib`

2022-07-12 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129534/new/ https://reviews.llvm.org/D129534

[PATCH] D124751: [HLSL] Support -E option for HLSL.

2022-07-12 Thread Greg Roth via Phabricator via cfe-commits
pow2clk added a comment. Looks to me that all the comments were responded to. I see nothing else worth commenting on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124751/new/ https://reviews.llvm.org/D124751

[PATCH] D125655: [HLSL] add -P option for dxc mode.

2022-07-12 Thread Greg Roth via Phabricator via cfe-commits
pow2clk added a comment. Mostly just some comments on user output Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:684 +def warn_drv_dxc_ignore_output_for_preprocess : Warning< + "output compiler options like -Fo ignored with Preprocess">, + InGroup;

[PATCH] D128462: [HLSL] add -I option for dxc mode.

2022-07-12 Thread Greg Roth via Phabricator via cfe-commits
pow2clk added a comment. I'm confused by the ways this option is allowed to be specified Comment at: clang/include/clang/Driver/Options.td:6824 +class DXCJoinedOrSeparateConflict : Option<["--", "/", "-"], name, + KIND_JOINED_OR_SEPARATE>, Group, Flags<[DXCOption,

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

2022-07-12 Thread Greg Roth via Phabricator via cfe-commits
pow2clk added a comment. Looks good apart from my uncertainty as to what -fcgl should or shouldn't imply Comment at: clang/test/Driver/dxc_O.hlsl:9 +// CHECK: "-O0" +// CHECK-SAME: "-dxc-opt-disable" + It looks to me that these are added when -Od is specified,

<    1   2   3