[PATCH] D133436: Ground work for cuda-related checks in clang-tidy

njames93 added a comment. What's with the .keep files. Will lit or sphinx fail if the cuda directory doesn't exist, if not I'd be happier removing them(they'd get removed once the first cuda check lands anyway). Comment at:

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

njames93 requested changes to this revision. njames93 added a comment. This revision now requires changes to proceed. Just address that test issue then it'll be good Comment at: clang-tools-extra/test/clang-tidy/checkers/misc/redundant-expression.cpp:1 -// RUN:

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. I reverted this commit while I fix the failing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 ___ cfe-commits mailing list

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 added a comment. @tianshilei1992 that is a fair point. I would be open to calling them something else. I just don't want to call them `LLVM_*` because that would be confusing since there is (a) LLVM in particular (b) the monorepo / project as a whole, and this variable are about

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

python3kgae updated this revision to Diff 460288. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131799/new/ https://reviews.llvm.org/D131799 Files: clang/lib/CodeGen/CGHLSLRuntime.cpp

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. In D102107#3791292 , @vitalybuka wrote: > check-llvm fails bunch of test for me > > > > Failed Tests (12): > > LLVM :: Transforms/OpenMP/custom_state_machines.ll > LLVM ::

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

vitalybuka added a comment. check-llvm fails bunch of test for me Failed Tests (12): LLVM :: Transforms/OpenMP/custom_state_machines.ll LLVM :: Transforms/OpenMP/custom_state_machines_remarks.ll LLVM :: Transforms/OpenMP/get_hardware_num_threads_in_block_fold.ll

[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

ychen added a comment. Looks great. Just a few more nits. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11280 +def warn_non_aligned_allocation_function : Warning < + "found non aligned allocation function for coroutine %0">, + InGroup; "under

[PATCH] D133887: [Clang] Support label at end of compound statement

shafik added a comment. The proposal says: > A label at the end of a compound statement is treated as if it were followed > by a null statement Does it make sense to write an AST test to verify this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc added inline comments. Comment at: clang/test/Sema/offsetof.c:79 +int a; +struct B // no-error, struct B is not defined within __builtin_offsetof directly +{ inclyc wrote: > aaron.ballman wrote: > > inclyc wrote: > > > aaron.ballman wrote: >

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc added inline comments. Comment at: clang/test/Sema/offsetof.c:79 +int a; +struct B // no-error, struct B is not defined within __builtin_offsetof directly +{ aaron.ballman wrote: > inclyc wrote: > > aaron.ballman wrote: > > > I think this is

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7539e9cf811e: [OpenMP] Codegen aggregate for outlined function captures (authored by ggeorgakoudis, committed by dhruvachak). Repository: rG LLVM

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak updated this revision to Diff 460274. dhruvachak added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang updated this revision to Diff 460271. akhuang marked 3 inline comments as done. akhuang added a comment. more comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133457/new/ https://reviews.llvm.org/D133457 Files:

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

reames added a comment. In D133443#3790420 , @asb wrote: > The change in set of instructions without changing the version number is > concerning - do you know anyone involved in that group? It would be good to > feedback the difficulties this can cause

[PATCH] D133659: [Clang] P1169R4: static operator()

lichray added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

VincentWu updated this revision to Diff 460266. VincentWu added a comment. fix test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133863/new/ https://reviews.llvm.org/D133863 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

kcc accepted this revision. kcc added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D133843: [clangd] Prefer definitions for gototype and implementation

sammccall added a comment. There's no test here, can you describe the cases you expect this to affect and why the new behavior is better? For types this seems doubly-dubious at first glance: - when we've decided to "prefer" a non-definition declaration, why make an exception here? - I'd

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

tianshilei1992 added a comment. Is it a good idea to define variables starting with `CMAKE`? That might be confusing for later maintenance by other developers because chances are that they will think those variables are CMake provided variables, try to look up into CMake document to see what

[PATCH] D133804: Cuda Check for ignored return errors from api calls to cuda

barcisz updated this revision to Diff 460261. barcisz added a comment. Removed unneeded headers from the check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133804/new/ https://reviews.llvm.org/D133804 Files: clang-tools-extra/-

[PATCH] D133804: Cuda Check for ignored return errors from api calls to cuda

barcisz updated this revision to Diff 460258. barcisz added a comment. Removed unneeded headers from the check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133804/new/ https://reviews.llvm.org/D133804 Files: clang-tools-extra/-

[PATCH] D133804: Cuda Check for ignored return errors from api calls to cuda

barcisz updated this revision to Diff 460256. barcisz added a comment. Brought back different message prefix for when AcceptedHandlers is set Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133804/new/ https://reviews.llvm.org/D133804 Files:

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem marked 3 inline comments as done. Navidem added inline comments. Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_control_flow.cpp:15 +extern "C" void __sanitizer_cov_cfs_init(const uintptr_t *cfs_beg, +

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem updated this revision to Diff 460251. Navidem added a comment. Use CHECK-DAG and separate function for checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 Files:

[PATCH] D133444: [RISCV] Update error message to not call 'RV32' and 'RV64' an extension.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6106a6d7fe48: [RISCV] Update error message to not call RV32 and RV64 an extension. (authored by craig.topper). Repository: rG LLVM Github

[clang] 6106a6d - [RISCV] Update error message to not call 'RV32' and 'RV64' an extension.

Author: Craig Topper Date: 2022-09-14T14:51:37-07:00 New Revision: 6106a6d7fe48ac26bc39621898b90766e2a10bd0 URL: https://github.com/llvm/llvm-project/commit/6106a6d7fe48ac26bc39621898b90766e2a10bd0 DIFF: https://github.com/llvm/llvm-project/commit/6106a6d7fe48ac26bc39621898b90766e2a10bd0.diff

[PATCH] D133711: [Sema] Reject array element types whose sizes aren't a multiple of their alignments

rnk added a comment. This seems like a new error that will be pretty easy to run into, especially in the funky MSVC virtual base case. @aaron.ballman proposed some kind of new breaking change announcement mechanism. Can you add a release note and send an announcement following that process? I

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

kcc added inline comments. Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_control_flow.cpp:24 +int main() { + int (*main_ptr)() = + void (*foo_ptr)(int) = syntax nit: auto main_ptr = Comment at:

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

vitalybuka added inline comments. Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_control_flow.cpp:15 +extern "C" void __sanitizer_cov_cfs_init(const uintptr_t *cfs_beg, + const uintptr_t *cfs_end) { + CFS_BEG

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem marked an inline comment as done. Navidem added inline comments. Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_control_flow.cpp:15 +extern "C" void __sanitizer_cov_cfs_init(const uintptr_t *cfs_beg, +

[PATCH] D133622: [clang][test] Disallow using the default module cache path in lit tests

benlangmuir added a comment. In D133622#3788218 , @bruno wrote: >> I'm not sure how to deal with missing `env -u`. >> >> - We could do `env CLANG_MODULE_CACHE_PATH=` and change the compiler's >> interpretation of empty string for this variable. I'm not

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem updated this revision to Diff 460232. Navidem added a comment. Enhance rt test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 Files: clang/docs/SanitizerCoverage.rst

[PATCH] D133875: [clang] fix generation of .debug_aranges with LTO (resubmit)

MaskRay added inline comments. Comment at: clang/test/Driver/debug-options-aranges.c:1 +// Check that lld will emit dwarf aranges. + The message is outdated now. This just checks how -gdwarf-aranges ias passed to the compiler and linker.

[PATCH] D132990: [Clang] Fix compat diagnostic to detect a nontype template parameter has a placeholder type using getContainedAutoType()

shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1534-1538 + if (const auto *T = TInfo->getType()->getContainedDeducedType()) +if (isa(T)) + Diag(D.getIdentifierLoc(), + diag::warn_cxx14_compat_template_nontype_parm_auto_type) +

[PATCH] D132990: [Clang] Fix compat diagnostic to detect a nontype template parameter has a placeholder type using getContainedAutoType()

shafik updated this revision to Diff 460229. shafik marked 6 inline comments as done. shafik added a comment. - Updating testing to reflect comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132990/new/ https://reviews.llvm.org/D132990 Files: clang/lib/Sema/SemaTemplate.cpp

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 added inline comments. Comment at: libcxx/CMakeLists.txt:421 +if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) + set(default_install_path "${CMAKE_INSTALL_INCLUDEDIR}/${LLVM_DEFAULT_TARGET_TRIPLE}/c++/v1") +else() ldionne wrote: > ldionne

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM as-is Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_control_flow.cpp:15 +extern "C" void __sanitizer_cov_cfs_init(const uintptr_t

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 460222. Ericson2314 added a comment. Rebase, fix some issues (by the looks of it) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586 Files: clang/CMakeLists.txt

[PATCH] D133711: [Sema] Reject array element types whose sizes aren't a multiple of their alignments

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133711/new/ https://reviews.llvm.org/D133711

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 460220. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp

[PATCH] D133261: NFC: [clang] add template AST test for make_integer_seq and type_pack_element

mizvekov updated this revision to Diff 460219. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133261/new/ https://reviews.llvm.org/D133261 Files: clang/test/SemaTemplate/make_integer_seq.cpp clang/test/SemaTemplate/type_pack_element.cpp Index:

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

vitalybuka added inline comments. Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_control_flow.cpp:15 +extern "C" void __sanitizer_cov_cfs_init(const uintptr_t *cfs_beg, + const uintptr_t *cfs_end) { + CFS_BEG

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

ldionne added inline comments. Comment at: libcxx/CMakeLists.txt:421 +if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) + set(default_install_path "${CMAKE_INSTALL_INCLUDEDIR}/${LLVM_DEFAULT_TARGET_TRIPLE}/c++/v1") +else() ldionne wrote: > Instead, I'd do

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

jcranmer-intel accepted this revision. jcranmer-intel added a comment. This revision is now accepted and ready to land. I'm happy with these changes. I'll let Aaron have one last crack at the wording of the documentation, in case there's any minor editorial stuff he'd like to see cleaned up.

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

Navidem updated this revision to Diff 460215. Navidem added a comment. Update the rt test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 Files: clang/docs/SanitizerCoverage.rst

[PATCH] D133886: [clang][RecoveryExpr] Don't perform alignment check if parameter type contains errors

hokein added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5779 QualType ParamTy = Proto->getParamType(ArgIdx); +if (ParamTy->containsErrors()) + continue; It looks like for the failure case the `ParamTy` for the

[PATCH] D133875: [clang] fix generation of .debug_aranges with LTO (resubmit)

azat updated this revision to Diff 460212. azat added a comment. Use --plugin-opt=-generate-arange-section instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133875/new/ https://reviews.llvm.org/D133875 Files:

[PATCH] D133711: [Sema] Reject array element types whose sizes aren't a multiple of their alignments

ahatanak updated this revision to Diff 460207. ahatanak retitled this revision from "[Sema] Reject array element types whose alignments are larger than their sizes" to "[Sema] Reject array element types whose sizes aren't a multiple of their alignments". ahatanak added a comment. Check whether

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

aaronpuchert added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12367 + case Type::Class: \ +llvm_unreachable("Unexpected " Kind ": " #Class); + mizvekov wrote: > aaronpuchert wrote: >

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

Izaron updated this revision to Diff 460209. Izaron added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122078/new/ https://reviews.llvm.org/D122078 Files:

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov retitled this revision from "WIP: Clang: fix AST representation of expanded template arguments." to "Clang: fix AST representation of expanded template arguments.". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 460206. mizvekov requested review of

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat added a comment. > I wasn't expecting that Oh, I see, it wasn't the linker, but the plugin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092 ___

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat added a comment. > This is not correct. GNU ld and gold don't accept -mllvm. You need to use > -plugin-opt=-generate... @MaskRay actually those options will be added only if the name matches `lld`/`lld.exe` (but I guess I need to provide more context so that it will be easier to

[PATCH] D133875: [clang] fix generation of .debug_aranges with LTO (resubmit)

azat added a comment. > I think @MaskRay was saying this doesn't actually work & different flags are > needed to pass to lld I thought that @MaskRay was talking about more generic approach that will not require if for the linker name, and indeed `--plugin-opt=-generate-arange-section` is

[clang] c69b269 - [pipelines] Require GlobalsAA after sanitizers

Author: Vitaly Buka Date: 2022-09-14T13:33:53-07:00 New Revision: c69b26911168cdcf49c7c7162d7b44ce4ed40c37 URL: https://github.com/llvm/llvm-project/commit/c69b26911168cdcf49c7c7162d7b44ce4ed40c37 DIFF: https://github.com/llvm/llvm-project/commit/c69b26911168cdcf49c7c7162d7b44ce4ed40c37.diff

[PATCH] D133537: [pipelines] Require GlobalsAA after sanitizers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. vitalybuka marked an inline comment as done. Closed by commit rGc69b26911168: [pipelines] Require GlobalsAA after sanitizers (authored by vitalybuka). Repository:

[PATCH] D133537: [pipelines] Require GlobalsAA after sanitizers

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:443 Options.EmulatedTLS = CodeGenOpts.EmulatedTLS; - Options.ExplicitEmulatedTLS = true; + Options.ExplicitEmulatedTLS =

[clang] 270c843 - [NFC][CodeGen] Remove empty line

Author: Vitaly Buka Date: 2022-09-14T13:29:15-07:00 New Revision: 270c843005f927c878f391c9d444b48c3ce2965e URL: https://github.com/llvm/llvm-project/commit/270c843005f927c878f391c9d444b48c3ce2965e DIFF: https://github.com/llvm/llvm-project/commit/270c843005f927c878f391c9d444b48c3ce2965e.diff

[PATCH] D133537: [pipelines] RecomputeGlobalsAAPass after OptimizerEarlyEPCallbacks

vitalybuka updated this revision to Diff 460199. vitalybuka added a comment. fix capture Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133537/new/ https://reviews.llvm.org/D133537 Files: clang/lib/CodeGen/BackendUtil.cpp Index:

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

mstorsjo added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6546 + if (Triple.isOSWindows() && !D.IsCLMode()) +ProcessVSRuntimeLibrary(Args, CmdArgs); Should this be `Triple.isWindowsMSVCEnvironment()`? We don't want to do this at

[PATCH] D133537: [pipelines] RecomputeGlobalsAAPass after OptimizerEarlyEPCallbacks

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. lg with comments addressed title needs update Comment at: clang/lib/CodeGen/BackendUtil.cpp:443 Options.EmulatedTLS = CodeGenOpts.EmulatedTLS; -

[PATCH] D133537: [pipelines] RecomputeGlobalsAAPass after OptimizerEarlyEPCallbacks

vitalybuka updated this revision to Diff 460197. vitalybuka edited the summary of this revision. vitalybuka added a comment. remove typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133537/new/ https://reviews.llvm.org/D133537 Files:

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, nice! Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4452 + + if (Arg *A = Args.getLastArg(options::OPT_fms_runtime_lib_EQ)) { +StringRef Val = A->getValue();

[PATCH] D133537: [pipelines] RecomputeGlobalsAAPass after OptimizerEarlyEPCallbacks

vitalybuka updated this revision to Diff 460194. vitalybuka added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133537/new/ https://reviews.llvm.org/D133537

[PATCH] D133847: [test][clang] fix pattern for LDGARANGE-NOT in debug-options-lld test

azat abandoned this revision. azat added a comment. Closed in favor of https://reviews.llvm.org/D133875 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133847/new/ https://reviews.llvm.org/D133847 ___

[PATCH] D133890: [CMake] Do these replacements to make use of D132608

Ericson2314 created this revision. Ericson2314 added reviewers: phosek, ldionne, sebastian-ne, beanz. Herald added subscribers: libc-commits, bzcheeseman, ayermolo, sdasgup3, abrachet, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo,

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 updated this revision to Diff 460191. Ericson2314 added a comment. Fix misspelled variable `CLANG_CURRENT_SOURCE_DIR` -> `CLANG_SOURCE_DIR` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132608/new/ https://reviews.llvm.org/D132608

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a1c81e32739: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better… (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3a1c81e - [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2

Author: John Ericson Date: 2022-09-14T15:48:58-04:00 New Revision: 3a1c81e327391466f827cafef7156b164cb4c3e6 URL: https://github.com/llvm/llvm-project/commit/3a1c81e327391466f827cafef7156b164cb4c3e6 DIFF: https://github.com/llvm/llvm-project/commit/3a1c81e327391466f827cafef7156b164cb4c3e6.diff

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

luken-google added a comment. @ilya-biryukov can you please take a look? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133052/new/ https://reviews.llvm.org/D133052 ___ cfe-commits mailing list

[PATCH] D119651: [clang] Fix evaluation context type for consteval function calls in instantiations

Izaron added a comment. @usaxena95, thanks! It was a really tough issue =) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119651/new/ https://reviews.llvm.org/D119651 ___ cfe-commits mailing list

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

asb added a comment. The change in set of instructions without changing the version number is concerning - do you know anyone involved in that group? It would be good to feedback the difficulties this can cause for us. It's also not clear if there might be changes again during ratification

[PATCH] D133887: [Clang] Support label at end of compound statement

cor3ntin added a comment. Thanks for doing that work. Given that this paper was touted as a C compatibility feature, I think we should implement the C feature at the same time https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2508.pdf If my understanding is correct the change implemented here

[PATCH] D133804: Cuda Check for ignored return errors from api calls to cuda

barcisz updated this revision to Diff 460184. barcisz added a comment. Documentation and small check-message-related bugfixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133804/new/ https://reviews.llvm.org/D133804 Files: clang-tools-extra/-

[PATCH] D133887: [Clang] Support label at end of compound statement

Izaron added a comment. I thought it was a good idea to slightly rename `err_label_end_of_compound_statement` to `err_SWITCH_label_end_of_compound_statement` because we aren't going to support empty labels in switch statements. (GCC also doesn't compile it - https://godbolt.org/z/xabKaon8v)

[PATCH] D133887: [Clang] Support label at end of compound statement

Izaron created this revision. Izaron added reviewers: clang-language-wg, aaron.ballman. Herald added a project: All. Izaron requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implements paper P2324R2 https://wg21.link/p2324r2

[PATCH] D133886: [clang][RecoveryExpr] Don't perform alignment check if parameter type contains errors

ArcsinX added a comment. This looks similar to the problem fixed in D103825 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133886/new/ https://reviews.llvm.org/D133886

[PATCH] D133886: [clang][RecoveryExpr] Don't perform alignment check if parameter type contains errors

ArcsinX created this revision. ArcsinX added reviewers: hokein, kadircet. Herald added a project: All. ArcsinX requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes a crash which appears because of CheckArgAlignment() call with

[PATCH] D133444: [RISCV] Update error message to not call 'RV32' and 'RV64' an extension.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133444/new/ https://reviews.llvm.org/D133444

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam updated this revision to Diff 460178. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/ffp-contract-option.c

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:55 + } else +PrevDecl = dyn_cast(Found); + assert(PrevDecl && "Unexpected lookup result type."); aaron.ballman wrote: > Is it possible that this finds a

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae updated this revision to Diff 460175. python3kgae marked 4 inline comments as done. python3kgae added a comment. Code cleanup per comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132421/new/ https://reviews.llvm.org/D132421

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2311 case DeclSpecContext::DSC_association: +case DeclSpecContext::DSC_offsetof: return true; inclyc wrote: > aaron.ballman wrote: > > Is this correct? I don't

[PATCH] D133664: [clangd] Fix hover on symbol introduced by using declaration

nridge added a comment. In D133664#3790144 , @tom-anders wrote: > Yeah I do have commit access now, so I'll land this by myself. > > I don't think I have the permissions to close the corresponding issue on > Github though, so someone else would need to

[PATCH] D133875: [clang] fix generation of .debug_aranges with LTO (resubmit)

dblaikie added a comment. I think @maskray was saying this doesn't actually work & different flags are needed to pass to lld - have you tested this end-to-end/with a real compilation, does that work? (are there other cases that already use `-mllvm` to pass flags down to lld?) Repository:

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

ningvin added a comment. In D133354#3790064 , @hans wrote: > Ah, thanks for letting me know. I've committed on your behalf as > https://github.com/llvm/llvm-project/commit/49e7ef2c09facd722a29a5ad96a7f8f16e362b28 Sweet, thanks a lot :-) Repository:

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

beanz added inline comments. Comment at: clang/lib/Basic/Targets/DirectX.h:66 + bool hasBitIntType() const override { return true; } bool hasFeature(StringRef Feature) const override { aaron.ballman wrote: > This change requires more testing/thought, IMO

[PATCH] D133664: [clangd] Fix hover on symbol introduced by using declaration

tom-anders added a comment. Yeah I do have commit access now, so I'll land this by myself. I don't think I have the permissions to close the corresponding issue on Github though, so someone else would need to do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson updated this revision to Diff 460155. royjacobson added a comment. Add tests required by reviewerd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 Files: clang/docs/ReleaseNotes.rst

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

MaskRay added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:48 + +constexpr int NoCompression = -5; +constexpr int BestSpeedCompression = 1; MaskRay wrote: > I missed the values here. Why is -5 picked for NoCompression? What does it >

[PATCH] D133773: [clang] fix linker executable path in test

alvinhochun added a comment. The literal dots have not been escaped as `\.`, but the current change works anyway and the chance of false positives here should be very low. I guess this is acceptable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang updated this revision to Diff 460154. akhuang marked an inline comment as done. akhuang added a comment. Address comments, more cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133457/new/ https://reviews.llvm.org/D133457 Files:

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

akhuang marked 3 inline comments as done. akhuang added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4442 +bool IsClangCL) { + unsigned RTOptionID = 0; // MT=0, MTd=1, MD=2, MDd=3 + bool HasLDdFlag = IsClangCL &&

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

MaskRay added a comment. This is not correct. GNU ld and gold don't accept `-mllvm`. You need to use `-plugin-opt=-generate...` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

hans added a comment. In D133354#3789212 , @ningvin wrote: > @hans just to clarify as I do not have commit access: do I still need to > perform some action? Ah, thanks for letting me know. I've committed on your behalf as

[clang] 49e7ef2 - [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

Author: Julius Date: 2022-09-14T19:48:08+02:00 New Revision: 49e7ef2c09facd722a29a5ad96a7f8f16e362b28 URL: https://github.com/llvm/llvm-project/commit/49e7ef2c09facd722a29a5ad96a7f8f16e362b28 DIFF: https://github.com/llvm/llvm-project/commit/49e7ef2c09facd722a29a5ad96a7f8f16e362b28.diff LOG:

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG49e7ef2c09fa: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode (authored by ningvin, committed by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133817: MSVC ABI: Looks like even non-aarch64 uses the MSVC/14 definition for pod/aggregate passing

rnk added a comment. Thanks! > But I had > trouble figuring out how to exercise this functionality properly to add > test coverage and then compare that to MSVC itself... - I got very > confused/turned around trying to test this, so I've given up enough to > send what I have out for review, but

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

aaron.ballman added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:50 +if (S.LookupQualifiedName(Result, HLSLNamespace)) { + NamedDecl *Found = Result.getFoundDecl(); + if (auto *TD = dyn_cast(Found)) { 99.9% sure this is

  1   2   3   >