[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

shafik added a comment. I found a way to get `ImplictValueInitExpr` for a record: https://godbolt.org/z/Eqf9Gz1G4 I am not sure if we can achieve the same in C++ b/c value init of a class break down to default init or zero init. CHANGES SINCE LAST ACTION

[PATCH] D127695: [clang] Implement Template Specialization Resugaring

rjmccall added a comment. I see, thank you. I know you've marked this a WIP, but it's always good to describe these things in the patch description; that's what it's for. This is quite exciting! Thank you for looking into this. I think you could usefully be much more incremental here.

[PATCH] D127695: [clang] Implement Template Specialization Resugaring

mizvekov added a comment. In D127695#3860237 , @rjmccall wrote: > What is this work about? I have written more about it in this discourse thread: https://discourse.llvm.org/t/rfc-improving-diagnostics-with-template-specialization-resugaring/64294

[PATCH] D135926: [clang] Fix crash with -funique-internal-linkage-names

tmsriram accepted this revision. tmsriram added a comment. This revision is now accepted and ready to land. LGTM, thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135926/new/ https://reviews.llvm.org/D135926

[PATCH] D135871: [clang-format][NFC] Handle language specific stuff at the top...

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3121 + return 1; +if (Right.is(tok::period)) + return 500; Otherwise, it wouldn't be NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

owenpan added a comment. In D135707#3858097 , @MyDeveloperDay wrote: > Thanks @rymiel its great to have another active contributor, especially one > who seems so focused on github issues. Really appreciate your recent > contributions. Can we start

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

dblaikie added a comment. In D85802#3859540 , @leonardchan wrote: >> Naive question, but what does it mean to target Fuschia but be >> gnu-compatible? (how would that be different than using whatever gnu OS >> (linux, etc) the other code was built for)

[PATCH] D127695: [clang] Implement Template Specialization Resugaring

rjmccall added a comment. What is this work about? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127695/new/ https://reviews.llvm.org/D127695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136007: [clang][modules][deps] System module maps might not be affecting

jansvoboda11 created this revision. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The dependency scanner relies on the module map filtering logic in

[PATCH] D130324: [ODRHash] Hash `ObjCProtocolDecl` and diagnose discovered mismatches.

bruno accepted this revision. bruno added a comment. Great to see both this and D130325 landing, LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130324/new/ https://reviews.llvm.org/D130324

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

rjmccall added a comment. Please add a comment something like this: The semantics of dynamic initialization of thread-local variables depends subtly on whether they are block-scope. The initialization of block-scope thread locals can be aborted with an exception and later retried (), and

[PATCH] D135832: Do not append terminating NUL to the string with embedded GPU binary.

tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:95 llvm::ConstantInt::get(SizeTy, 0)}; -auto ConstStr = CGM.GetAddrOfConstantCString(Str, Name.c_str()); +auto ConstStr = CGM.GetAddrOfConstantCString(Str, Name.c_str(),

[PATCH] D135832: Do not append terminating NUL to the string with embedded GPU binary.

tra updated this revision to Diff 467957. tra added a comment. Reworked string/array generation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135832/new/ https://reviews.llvm.org/D135832 Files: clang/lib/CodeGen/CGCUDANV.cpp

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

rjmccall added a comment. In D135919#3859520 , @hubert.reinterpretcast wrote: > In D135919#3859491 , @tahonermann > wrote: > >>> the case from https://github.com/llvm/llvm-project/issues/57828 is not for >>> a

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

jrtc27 added a comment. It also will fail if the configured default target triple is one where the default program address space is non-zero, and maybe other things (do any targets do pre-IR name mangling for C?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

saugustine added a comment. The newly added test func-attr.c fails when run in opt mode. If it is expected to run only at a certain optimization level, it should probably include that level in the test itself. I don't think it seriously blocks anything, but would be good to fix.

[clang] 82035ec - Revert "[PGO] Make emitted symbols hidden"

Author: Zequan Wu Date: 2022-10-14T15:23:26-07:00 New Revision: 82035ecf683067c7c7b9f344bb7ca28b4717 URL: https://github.com/llvm/llvm-project/commit/82035ecf683067c7c7b9f344bb7ca28b4717 DIFF: https://github.com/llvm/llvm-project/commit/82035ecf683067c7c7b9f344bb7ca28b4717.diff

[PATCH] D135340: [PGO] Make emitted symbols hidden

zequanwu added a comment. This causing instrprof-darwin-dead-strip.c failed on mac. FAIL: Profile-x86_64 :: instrprof-darwin-dead-strip.c (1 of 238) TEST 'Profile-x86_64 :: instrprof-darwin-dead-strip.c' FAILED Script: -- : 'RUN: at line 4';

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void updated this revision to Diff 467941. void added a comment. Update test to use a smaller index. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135920/new/ https://reviews.llvm.org/D135920 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

mstorsjo added a comment. I don't quite know why, but it seems like this new library breaks tests of llvm-config; if I start out with an empty build directory and run `ninja check-llvm` (or `ninja llvm-test-depends`), then this library doesn't get built, and llvm-config prints `llvm-config:

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 467940. ayzhao added a comment. implement StmtProfiler and Sema::canThrow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/include/clang-c/Index.h

[clang-tools-extra] 21fb70c - [clang-doc] Add typedef/using information.

Author: Brett Wilson Date: 2022-10-14T14:59:29-07:00 New Revision: 21fb70c6ab3b25fe8f5f8384714a9a359b4b5a54 URL: https://github.com/llvm/llvm-project/commit/21fb70c6ab3b25fe8f5f8384714a9a359b4b5a54 DIFF: https://github.com/llvm/llvm-project/commit/21fb70c6ab3b25fe8f5f8384714a9a359b4b5a54.diff

[PATCH] D134371: [clang-doc] Add typedef/using information.

This revision was automatically updated to reflect the committed changes. Closed by commit rG21fb70c6ab3b: [clang-doc] Add typedef/using information. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added a comment. I pushed some late changes: - Implement this new scheme uniformly across all template parameter kinds. Before we were doing only type parameters, now we are doing non-type and template template parameters. While the diff is not very small, it's more of the same

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 467932. ayzhao added a comment. implement serialization stuff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/include/clang-c/Index.h

[PATCH] D135989: [clang][Sema] Use size of char for void types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91b3823bd000: [clang][Sema] Use size of char in bits for void types (authored by void). Changed prior to commit:

[PATCH] D135989: [clang][Sema] Use size of char for void types

void added a comment. In D135989#3859763 , @nickdesaulniers wrote: > LGTM; please consider appending to the commit message something along the > lines of "operations on the result of getTypeSize() are in bits, not bytes. > Using 1 as the value for

[clang] 91b3823 - [clang][Sema] Use size of char in bits for void types

Author: Bill Wendling Date: 2022-10-14T14:46:19-07:00 New Revision: 91b3823bd000b1a6ffde96a6363098f59307317a URL: https://github.com/llvm/llvm-project/commit/91b3823bd000b1a6ffde96a6363098f59307317a DIFF: https://github.com/llvm/llvm-project/commit/91b3823bd000b1a6ffde96a6363098f59307317a.diff

[PATCH] D135729: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd11b9fa3bfb9: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as (authored by drodriguez). Changed prior to commit:

[clang] d11b9fa - [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as

Author: Daniel Rodríguez Troitiño Date: 2022-10-14T14:33:10-07:00 New Revision: d11b9fa3bfb9e2bedec142816e88b9171c8ec6b6 URL: https://github.com/llvm/llvm-project/commit/d11b9fa3bfb9e2bedec142816e88b9171c8ec6b6 DIFF:

[PATCH] D134143: [clang] Misc type sugar preservation improvements

mizvekov updated this revision to Diff 467923. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134143/new/ https://reviews.llvm.org/D134143 Files: clang/lib/Sema/SemaCXXScopeSpec.cpp clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaType.cpp

[PATCH] D134115: [clang] Store in exprs the deduced arguments for function calls.

mizvekov updated this revision to Diff 467922. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134115/new/ https://reviews.llvm.org/D134115 Files: clang/include/clang/AST/ASTImporter.h clang/include/clang/AST/Expr.h

[PATCH] D134604: [clang] Instiantiate early substituted entities with sugared template arguments

mizvekov updated this revision to Diff 467920. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files:

[PATCH] D133874: [clang] Implement sugar retention for converted template arguments

mizvekov updated this revision to Diff 467919. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/TemplateDeduction.h

[PATCH] D135721: [HLSL] Added HLSL this as a reference

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue);

[PATCH] D135989: [clang][Sema] Use size of char for void types

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. LGTM; please consider appending to the commit message something along the lines of "operations on the result of getTypeSize() are in bits, not bytes. Using 1 as the value

[PATCH] D135989: [clang][Sema] Use size of char for void types

void updated this revision to Diff 467912. void added a comment. Fix up testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135989/new/ https://reviews.llvm.org/D135989 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D135989: [clang][Sema] Use size of char for void types

void added inline comments. Comment at: clang/test/Sema/array-bounds-ptr-arith.c:14 +void* broken (struct ext2_super_block *es,int a) { + return (void *)es->s_uuid + 9; // expected-warning {{the pointer incremented by 9 refers past the end of the array (that contains 8

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae updated this revision to Diff 467909. python3kgae marked 3 inline comments as done. python3kgae added a comment. Rebase to use FrontendResource. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130951/new/ https://reviews.llvm.org/D130951

[PATCH] D135989: [clang][Sema] Use size of char for void types

nickdesaulniers added inline comments. Comment at: clang/test/Sema/array-bounds-ptr-arith.c:14 +void* broken (struct ext2_super_block *es,int a) { + return (void *)es->s_uuid + 9; // expected-warning {{the pointer incremented by 9 refers past the end of the array (that

[PATCH] D135989: [clang][Sema] Use size of char for void types

void added inline comments. Comment at: clang/test/Sema/array-bounds-ptr-arith.c:14 +void* broken (struct ext2_super_block *es,int a) { + return (void *)es->s_uuid + 9; // expected-warning {{the pointer incremented by 9 refers past the end of the array (that contains 8

[PATCH] D135989: [clang][Sema] Use size of char for void types

serge-sans-paille added inline comments. Comment at: clang/test/Sema/array-bounds-ptr-arith.c:14 +void* broken (struct ext2_super_block *es,int a) { + return (void *)es->s_uuid + 9; // expected-warning {{the pointer incremented by 9 refers past the end of the array (that

[PATCH] D135989: [clang][Sema] Use size of char for void types

void created this revision. void added reviewers: serge-sans-paille, kees, nickdesaulniers. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The extension that allows for pointer arithmetic on 'void' types

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 467900. ayzhao added a comment. run clang-format again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/include/clang-c/Index.h

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw updated this revision to Diff 467895. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/BitcodeWriter.h

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw updated this revision to Diff 467894. brettw added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. > Naive question, but what does it mean to target Fuschia but be > gnu-compatible? (how would that be different than using whatever gnu OS > (linux, etc) the other code was built for) (Probably poor wording on my part.) When I mention gnu-compatible here, I don't

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5511-5539 + template ::value, bool> = true> + bool operator()(T1 *PS1, T2 *PS2) { +return hasEqualTemplateArgumentList( +PS1->getTemplateArgsAsWritten()->arguments(), +

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

hubert.reinterpretcast added a comment. In D135919#3859491 , @tahonermann wrote: >> the case from https://github.com/llvm/llvm-project/issues/57828 is not for a >> block-scope variable, but the case in the patch description is... > > Thanks, Hubert.

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

rjmccall added a comment. If it comes down to it, we can make this a Fuchsia-specific flag, so that Fuchsia + alternative C++ ABI is essentially a sort of subtarget. That way we don't have to support the arbitrary Cartesian product of OS + ABI. With that said, while I don't know the details

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

sammccall added a comment. In D54943#3854279 , @sammccall wrote: > FYI I've sent D135829 to block this check > from running in clangd, after tracking it down as the cause of a >10x > regression in reparse times in a

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

dblaikie added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration anderslanglands wrote: > dblaikie wrote:

[clang] 7da0879 - [clang][dataflow][NFC] Fix reachability warning.

Author: Yitzhak Mandelbaum Date: 2022-10-14T19:35:11Z New Revision: 7da087974f9491855eea0087c657851a84c67b75 URL: https://github.com/llvm/llvm-project/commit/7da087974f9491855eea0087c657851a84c67b75 DIFF: https://github.com/llvm/llvm-project/commit/7da087974f9491855eea0087c657851a84c67b75.diff

[PATCH] D135978: [clang][dataflow][NFC] Fix reachability warning.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7da087974f94: [clang][dataflow][NFC] Fix reachability warning. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135978/new/

[PATCH] D135916: Itanium ABI: Pack non-pod members of packed types

This revision was automatically updated to reflect the committed changes. Closed by commit rG037f85668126: Itanium ABI: Pack non-pod members of packed types (authored by dblaikie). Changed prior to commit: https://reviews.llvm.org/D135916?vs=467599=467890#toc Repository: rG LLVM Github

[PATCH] D135919: [Clang] Set thread_local Itanium ABI guard variables before calling constructors.

tahonermann added a comment. > the case from https://github.com/llvm/llvm-project/issues/57828 is not for a > block-scope variable, but the case in the patch description is... Thanks, Hubert. Yes, I found that the reported issue occurred for any case where thread safe guard variables are not

[clang] 037f856 - Itanium ABI: Pack non-pod members of packed types

Author: David Blaikie Date: 2022-10-14T19:32:57Z New Revision: 037f856681268c793c660389b4d6407367e68190 URL: https://github.com/llvm/llvm-project/commit/037f856681268c793c660389b4d6407367e68190 DIFF: https://github.com/llvm/llvm-project/commit/037f856681268c793c660389b4d6407367e68190.diff

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

HazardyKnusperkeks added a comment. In D135707#3859357 , @rymiel wrote: > Thanks for the kind words ❤️ (I've noticed Björn already includes me in his > reviewers list); and while I am humbled, and I do look at every patch, I > don't *yet* trust myself

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue);

[PATCH] D135978: [clang][dataflow][NFC] Fix reachability warning.

ymandel added a comment. In D135978#3859272 , @xazax.hun wrote: > I'd argue the warning is correct as you could store "non-enum" integer values > into an enum typed variable (and people do that fairly often with bitwise > enums). Good point. Feels

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

anderslanglands added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration dblaikie wrote: > aaron.ballman

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

beanz added inline comments. Comment at: clang/include/clang/Basic/HLSLRuntime.h:31 +// NOTE: keep sync with ResourceBase::Kinds in DirectX backend. +enum class ResourceKind : uint32_t { + Invalid = 0, If this is only used in the clangCodeGen library, we can

[PATCH] D135916: Itanium ABI: Pack non-pod members of packed types

abrachet accepted this revision. abrachet added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135916/new/ https://reviews.llvm.org/D135916

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

dblaikie added a comment. In D85802#3859235 , @leonardchan wrote: > In D85802#3858760 , @rjmccall wrote: > >> Does Fuchsia still need this? If those experiments have stabilized, maybe >> we can just remove it.

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

rymiel added a comment. Thanks for the kind words ❤️ (I've noticed Björn already includes me in his reviewers list); and while I am humbled, and I do look at every patch, I don't *yet* trust myself to actually perform good code review, as it's not something I've really ever done before.

[PATCH] D135966: [X86] Use unsigned int for return type of __get_cpuid_max.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71a9b8833231: [X86] Use unsigned int for return type of __get_cpuid_max. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES

[clang] 71a9b88 - [X86] Use unsigned int for return type of __get_cpuid_max.

Author: Craig Topper Date: 2022-10-14T11:45:20-07:00 New Revision: 71a9b8833231a285b4d8d5587c699ed45881624b URL: https://github.com/llvm/llvm-project/commit/71a9b8833231a285b4d8d5587c699ed45881624b DIFF: https://github.com/llvm/llvm-project/commit/71a9b8833231a285b4d8d5587c699ed45881624b.diff

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG911d2dc23035: [NFC] [HLSL] Move common metadata to LLVMFrontend (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 911d2dc - [NFC] [HLSL] Move common metadata to LLVMFrontend

Author: Chris Bieneman Date: 2022-10-14T13:40:04-05:00 New Revision: 911d2dc23035454cb85422922c19259855e33bba URL: https://github.com/llvm/llvm-project/commit/911d2dc23035454cb85422922c19259855e33bba DIFF:

[PATCH] D135978: [clang][dataflow][NFC] Fix reachability warning.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. I'd argue the warning is correct as you could store "non-enum" integer values into an enum typed variable (and people do that fairly often with

[PATCH] D135978: [clang][dataflow][NFC] Fix reachability warning.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Some compilers can't determine that all cases of

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. In D85802#3858760 , @rjmccall wrote: > Does Fuchsia still need this? If those experiments have stabilized, maybe we > can just remove it. Also, it should probably have been a -cc1 flag in the > first place. We still use

[PATCH] D135834: [PowerPC] Fix parameters for __builtin_crypto_vsbox

This revision was automatically updated to reflect the committed changes. Closed by commit rG6897dbc46329: [PowerPC] Fix parameters for __builtin_crypto_vsbox (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135834/new/

[clang] 6897dbc - [PowerPC] Fix parameters for __builtin_crypto_vsbox

Author: Stefan Pintilie Date: 2022-10-14T13:30:59-05:00 New Revision: 6897dbc46329cc8cc3f58b9e4809dd400218b8ae URL: https://github.com/llvm/llvm-project/commit/6897dbc46329cc8cc3f58b9e4809dd400218b8ae DIFF:

[PATCH] D135964: [clang][dataflow] Add equivalence relation for `Value` type.

ymandel marked an inline comment as done. ymandel added a comment. In D135964#3858783 , @xazax.hun wrote: > In D135964#3858706 , @ymandel wrote: > >> Reviewers: I'm inclined towards a method vs overloaded

[PATCH] D135964: [clang][dataflow] Add equivalence relation for `Value` type.

ymandel updated this revision to Diff 467856. ymandel added a comment. switched to function, instead of operator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135964/new/ https://reviews.llvm.org/D135964 Files:

[PATCH] D135931: [Attributes] Improve writing `ExprArgument` value.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135931/new/ https://reviews.llvm.org/D135931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135931: [Attributes] Improve writing `ExprArgument` value.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1783253c41f1: [Attributes] Improve writing `ExprArgument` value. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135931/new/

[clang] 1783253 - [Attributes] Improve writing `ExprArgument` value.

Author: Volodymyr Sapsai Date: 2022-10-14T11:20:57-07:00 New Revision: 1783253c41f1b0ac378ab7fa4b6fe5547369c6b0 URL: https://github.com/llvm/llvm-project/commit/1783253c41f1b0ac378ab7fa4b6fe5547369c6b0 DIFF:

[PATCH] D135966: [X86] Use unsigned int for return type of __get_cpuid_max.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135966/new/ https://reviews.llvm.org/D135966

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 467845. ychen added a comment. - skip non-dependent NTTP comparison because they're equivalent (match GCC) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files:

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

dblaikie added inline comments. Comment at: clang/bindings/python/clang/cindex.py:1530 + +def record_needs_implicit_default_constructor(self): +"""Returns True if the cursor refers to a C++ record declaration aaron.ballman wrote: > royjacobson wrote:

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

MaskRay updated this revision to Diff 467840. MaskRay marked an inline comment as done. MaskRay edited the summary of this revision. MaskRay added a comment. remove lit feature default_std_cxx I think some other CLANG_DEFAULT_* probably should go away as well, but we can start with STD_C STD_CXX

[PATCH] D135923: [clang][dataflow][NFC] Mark test analysis classes as `final`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG13cd184ef7fa: [clang-dataflow][NFC] Mark test analysis classes as `final`. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES

[clang] 13cd184 - [clang-dataflow][NFC] Mark test analysis classes as `final`.

Author: Yitzhak Mandelbaum Date: 2022-10-14T17:51:57Z New Revision: 13cd184ef7fa9d76deaffb1924521fa914edba5e URL: https://github.com/llvm/llvm-project/commit/13cd184ef7fa9d76deaffb1924521fa914edba5e DIFF: https://github.com/llvm/llvm-project/commit/13cd184ef7fa9d76deaffb1924521fa914edba5e.diff

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1007 // Then load configuration files specified explicitly. - llvm::SmallString<128> CfgFilePath; + std::string CfgFilePath; if (CLOptions) { mgorny wrote: > I don't really understand

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1007 // Then load configuration files specified explicitly. - llvm::SmallString<128> CfgFilePath; + std::string CfgFilePath; if (CLOptions) { I don't really understand the purpose of

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39b9d4f188ca: [clang][dataflow] Add support for a Top value in boolean formulas. (authored by ymandel). Repository: rG LLVM Github Monorepo

[clang] 39b9d4f - [clang][dataflow] Add support for a Top value in boolean formulas.

Author: Yitzhak Mandelbaum Date: 2022-10-14T17:41:53Z New Revision: 39b9d4f188ca1f99515658334d57c2961db33289 URL: https://github.com/llvm/llvm-project/commit/39b9d4f188ca1f99515658334d57c2961db33289 DIFF: https://github.com/llvm/llvm-project/commit/39b9d4f188ca1f99515658334d57c2961db33289.diff

[PATCH] D131701: [CodeGen][ObjC] Call synthesized copy constructor/assignment operator functions in getter/setter functions of non-trivial C struct properties

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28f7087c9163: [CodeGen][ObjC] Call synthesized copy constructor/assignment operator (authored by ahatanak). Repository: rG LLVM Github Monorepo

[clang] 28f7087 - [CodeGen][ObjC] Call synthesized copy constructor/assignment operator

Author: Akira Hatanaka Date: 2022-10-14T10:40:24-07:00 New Revision: 28f7087c9163f66b07e17bd47a1bfb5d9448467d URL: https://github.com/llvm/llvm-project/commit/28f7087c9163f66b07e17bd47a1bfb5d9448467d DIFF:

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

mgorny added inline comments. Comment at: clang/test/Preprocessor/lang-std.cpp:1 -// UNSUPPORTED: default-std-cxx, ps4, ps5 -/// Test default standards when CLANG_DEFAULT_STD_CXX is unspecified. I suppose you want to remove the `lit.cfg.py` counterpart of this

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw updated this revision to Diff 467833. sstwcw added a comment. - correct spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/ https://reviews.llvm.org/D135740 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

sstwcw updated this revision to Diff 467832. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135972/new/ https://reviews.llvm.org/D135972 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. Daisy's bug ended up being more complicated than I expected... there is a lot to unpack here. In the meantime, I've captured the bug here: https://github.com/llvm/llvm-project/issues/58368 and will continue looking at it. Repository: rG LLVM Github Monorepo

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw added a comment. In D135740#3858782 , @MyDeveloperDay wrote: > Did you test this with nested #if #endif? No. I added the tests now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw updated this revision to Diff 467829. sstwcw added a comment. - add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/ https://reviews.llvm.org/D135740 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D135973: Move HLSL builtins into hlsl namespace

beanz created this revision. beanz added reviewers: python3kgae, pow2clk, bob80905. Herald added a subscriber: Anastasia. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. Should have done this from the start. Since all the injected AST types are

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel updated this revision to Diff 467822. ymandel marked an inline comment as done. ymandel added a comment. rebase onto a recent HEAD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135397/new/ https://reviews.llvm.org/D135397 Files:

  1   2   3   >