[PATCH] D142328: [clang][Interp] Fix compound assign operator types

tbaeder added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142328/new/ https://reviews.llvm.org/D142328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D142500: Fix one of the regressions found in revert of concept sugaring

Mordante added a comment. FYI I tested this patch with libc++ and as expected it does not fix the libc++ modular build ICE. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142500/new/ https://reviews.llvm.org/D142500 ___ cfe-commits mailing

[clang-tools-extra] 603c286 - Bump the trunk major version to 17

Author: Tom Stellard Date: 2023-01-24T22:57:27-08:00 New Revision: 603c286334b07f568d39f6706c848f576914f323 URL: https://github.com/llvm/llvm-project/commit/603c286334b07f568d39f6706c848f576914f323 DIFF: https://github.com/llvm/llvm-project/commit/603c286334b07f568d39f6706c848f576914f323.diff

[libunwind] 603c286 - Bump the trunk major version to 17

Author: Tom Stellard Date: 2023-01-24T22:57:27-08:00 New Revision: 603c286334b07f568d39f6706c848f576914f323 URL: https://github.com/llvm/llvm-project/commit/603c286334b07f568d39f6706c848f576914f323 DIFF: https://github.com/llvm/llvm-project/commit/603c286334b07f568d39f6706c848f576914f323.diff

[clang] b0daacf - [CodeGen] Use llvm::bit_ceil (NFC)

Author: Kazu Hirata Date: 2023-01-24T22:54:53-08:00 New Revision: b0daacf58f417634f7c7c9496589d723592a8f5a URL: https://github.com/llvm/llvm-project/commit/b0daacf58f417634f7c7c9496589d723592a8f5a DIFF: https://github.com/llvm/llvm-project/commit/b0daacf58f417634f7c7c9496589d723592a8f5a.diff

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:1 +// RUN: %check_clang_tidy -std=c++14-or-later %s

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 491992. ccotter added a comment. - Use multiple runs on the same test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files:

[clang-tools-extra] c7575fc - Revert "[clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options"

Author: Carlos Galvez Date: 2023-01-25T05:17:00Z New Revision: c7575fcb685a15f5384c137c76913e0bb11d1320 URL: https://github.com/llvm/llvm-project/commit/c7575fcb685a15f5384c137c76913e0bb11d1320 DIFF: https://github.com/llvm/llvm-project/commit/c7575fcb685a15f5384c137c76913e0bb11d1320.diff

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:1 +// RUN: %check_clang_tidy -std=c++14-or-later %s cppcoreguidelines-rvalue-reference-param-not-moved %t -- --

[PATCH] D141959: [clang-format] Fix inconsistent identification of operator

dkt01 added a comment. Sounds good. I don't believe I have permissions to add commits to three repo anyway, so someone can add on my behalf after the 16 branch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141959/new/ https://reviews.llvm.org/D141959

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:1 +// RUN: %check_clang_tidy -std=c++14-or-later %s cppcoreguidelines-rvalue-reference-param-not-moved %t -- --

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:1 +// RUN: %check_clang_tidy -std=c++14-or-later %s cppcoreguidelines-rvalue-reference-param-not-moved %t -- --

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter marked an inline comment as done. ccotter added a comment. In D141569#4048359 , @njames93 wrote: > What happens with code like this > > void foo(bar&& B) { > std::move(B); > }

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/RvalueReferenceParamNotMovedCheck.cpp:13 + +#include + carlosgalvezp wrote: > Not sure if this is allowed in the repo or if we

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 491989. ccotter added a comment. - Use match instead of bespoke traversal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files:

[PATCH] D142297: [Clang][OpenMP] Find the type `omp_allocator_handle_t` from identifier table

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ba8ecb6cc7b: [Clang][OpenMP] Find the type `omp_allocator_handle_t` from identifier table (authored by tianshilei1992). Repository: rG LLVM

[clang] 5ba8ecb - [Clang][OpenMP] Find the type `omp_allocator_handle_t` from identifier table

Author: Shilei Tian Date: 2023-01-24T22:49:05-05:00 New Revision: 5ba8ecb6cc7b76e7124566e53a3bce9393763a20 URL: https://github.com/llvm/llvm-project/commit/5ba8ecb6cc7b76e7124566e53a3bce9393763a20 DIFF: https://github.com/llvm/llvm-project/commit/5ba8ecb6cc7b76e7124566e53a3bce9393763a20.diff

[clang] 0f07ff8 - [Clang] Fix test that sometimes fails depending on the temp name

Author: Joseph Huber Date: 2023-01-24T21:12:00-06:00 New Revision: 0f07ff8b71e6c5f899b99b445eccd4323395b33f URL: https://github.com/llvm/llvm-project/commit/0f07ff8b71e6c5f899b99b445eccd4323395b33f DIFF: https://github.com/llvm/llvm-project/commit/0f07ff8b71e6c5f899b99b445eccd4323395b33f.diff

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

rymiel added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3592-3601 case tok::kw_bool: // bool is only allowed if it is directly followed by a paren for a cast: // concept C = bool(...); // and bool is the only type, all other

[PATCH] D129008: [Clang][OpenMP] Fix the issue that globalization doesn't work with byval struct function argument

tianshilei1992 added a subscriber: aaron.ballman. tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:2501 + LValue Src = MakeAddrLValue(Arg.getIndirectAddress(), Ty); + callCStructCopyConstructor(Dst, Src); +

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3592-3601 case tok::kw_bool: // bool is only allowed if it is directly followed by a paren for a cast: // concept C = bool(...); // and bool is the only type, all other

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56313f65cce7: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use (authored by owenpan). Repository: rG LLVM Github Monorepo

[clang] 56313f6 - [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

Author: Owen Pan Date: 2023-01-24T18:40:14-08:00 New Revision: 56313f65cce71366fdc659d1d08e0eeaa5d40b63 URL: https://github.com/llvm/llvm-project/commit/56313f65cce71366fdc659d1d08e0eeaa5d40b63 DIFF: https://github.com/llvm/llvm-project/commit/56313f65cce71366fdc659d1d08e0eeaa5d40b63.diff

[PATCH] D142437: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 491981. lime added a comment. Updated as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142437/new/ https://reviews.llvm.org/D142437 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclCXX.h clang/lib/AST/CXXInheritance.cpp

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3592-3601 case tok::kw_bool: // bool is only allowed if it is directly followed by a paren for a cast: // concept C = bool(...); // and bool is the only type, all other

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 491978. ccotter added a comment. - Fix universal reference check; move diagnostic location to parameter name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files:

[PATCH] D142297: [Clang][OpenMP] Find the type `omp_allocator_handle_t` from identifier table

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142297/new/ https://reviews.llvm.org/D142297

[PATCH] D142477: [X86] Ensure the _mm_test_all_ones macro does not reuse argument (PR60006)

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142477/new/ https://reviews.llvm.org/D142477

[PATCH] D142297: [Clang][OpenMP] Find the type `omp_allocator_handle_t` from identifier table

tianshilei1992 updated this revision to Diff 491976. tianshilei1992 added a comment. use compiler builtin for types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142297/new/ https://reviews.llvm.org/D142297 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D142297: [Clang][OpenMP] Find the type `omp_allocator_handle_t` from identifier table

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/target_uses_allocators.c:108 // CHECK-NEXT: store i32 %[[#R1]], ptr %.x..void.addr, align 4 -// CHECK-NEXT: call void @__kmpc_free(i32 %[[#R0]], ptr

[PATCH] D142297: [Clang][OpenMP] Find the type `omp_allocator_handle_t` from identifier table

ABataev added inline comments. Comment at: clang/test/OpenMP/target_uses_allocators.c:108 // CHECK-NEXT: store i32 %[[#R1]], ptr %.x..void.addr, align 4 -// CHECK-NEXT: call void @__kmpc_free(i32 %[[#R0]], ptr %.x..void.addr, ptr inttoptr (i64 8 to ptr)) \ No newline at end of

[PATCH] D142297: [Clang][OpenMP] Find the type `omp_allocator_handle_t` from identifier table

tianshilei1992 updated this revision to Diff 491972. tianshilei1992 added a comment. rebase and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142297/new/ https://reviews.llvm.org/D142297 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

nickdesaulniers added a comment. Is https://reviews.llvm.org/D142163 a blocker for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138337/new/ https://reviews.llvm.org/D138337 ___ cfe-commits

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/rvalue-reference-param-not-moved.cpp:1 +// RUN: %check_clang_tidy -std=c++14-or-later %s cppcoreguidelines-rvalue-reference-param-not-moved %t -- --

[PATCH] D140179: [-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas

ziqingluo-90 updated this revision to Diff 491960. ziqingluo-90 retitled this revision from "[WIP][-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas" to "[-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas". ziqingluo-90 added reviewers: aaron.ballman, xazax.hun,

[clang] 92b4946 - [CodeGen] bugfix: add REQUIRES target triple in test

Author: usama hameed Date: 2023-01-24T16:28:01-08:00 New Revision: 92b4946aa2f6e061bf0ab9803fc6a0657d9ce969 URL: https://github.com/llvm/llvm-project/commit/92b4946aa2f6e061bf0ab9803fc6a0657d9ce969 DIFF: https://github.com/llvm/llvm-project/commit/92b4946aa2f6e061bf0ab9803fc6a0657d9ce969.diff

[PATCH] D142065: [SVE] Fix incorrect lowering of predicate permute builtins.

paulwalker-arm added inline comments. Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:6361 + def : SVE_2_Op_Pat(NAME # _S)>; + def : SVE_2_Op_Pat(NAME # _D)>; } peterwaller-arm wrote: > Out of interest, is there a good reason to handle the nxv16

[PATCH] D142048: [Phabricator] Fix __ptr32 arguments passed to builtins

arichardson added a comment. It sounds to me that the logic from b919c7d should have been restricted to actual LLVM intrinsics that are overloaded on the pointer args ( e.g. llvm.memcpy which was the test in that commit). Builtins that are just library calls with known semantics probably need

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

NoQ added a comment. Awesome, we're getting closer to producing our first fix! I think the most important thing right now is to add a lot of `SourceLocation::isMacroID()` checks everywhere, so that to *never* try to fix code that's fully or partially expanded from macros. I suspect that we can

[clang] 0245dcc - [clang][test] Remove check that fails if SOURCE_DATE_EPOCH is set globally

Author: Ben Langmuir Date: 2023-01-24T16:00:56-08:00 New Revision: 0245dcc000faf4f6dea9552a44106c8921df841e URL: https://github.com/llvm/llvm-project/commit/0245dcc000faf4f6dea9552a44106c8921df841e DIFF: https://github.com/llvm/llvm-project/commit/0245dcc000faf4f6dea9552a44106c8921df841e.diff

[PATCH] D142511: [clang][test] Remove check that fails if SOURCE_DATE_EPOCH is set globally

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0245dcc000fa: [clang][test] Remove check that fails if SOURCE_DATE_EPOCH is set globally (authored by benlangmuir). Repository: rG LLVM Github

[PATCH] D142511: [clang][test] Remove check that fails if SOURCE_DATE_EPOCH is set globally

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142511/new/ https://reviews.llvm.org/D142511

[PATCH] D136717: [clang] Move getenv call for SOURCE_DATE_EPOCH out of frontend NFC

benlangmuir added inline comments. Comment at: clang/test/Driver/SOURCE_DATE_EPOCH.c:2 +// RUN: %clang -E %s -### 2>&1 | FileCheck %s -check-prefix=NO_EPOCH +// NO_EPOCH-NOT: "-source-date-epoch" + tstellar wrote: > Hi @benlangmuir, this test fails in our build

[PATCH] D142511: [clang][test] Remove check that fails if SOURCE_DATE_EPOCH is set globally

benlangmuir created this revision. benlangmuir added a reviewer: tstellar. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The check for "no SOURCE_DATE_EPOCH" wasn't especially interesting, and I

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer added a comment. Thanks, Nathan. Makes sense; sounds good. @kadircet, I think this one is ready for you, whenever you want it. Lmk how you'd like to proceed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138546/new/ https://reviews.llvm.org/D138546

[PATCH] D142243: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b6dbdecba0b: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended (authored by usama54321). Repository: rG LLVM Github

[clang] 5b6dbde - [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

Author: usama hameed Date: 2023-01-24T15:31:07-08:00 New Revision: 5b6dbdecba0b033e6a64593062cf87cd6c8a66ee URL: https://github.com/llvm/llvm-project/commit/5b6dbdecba0b033e6a64593062cf87cd6c8a66ee DIFF: https://github.com/llvm/llvm-project/commit/5b6dbdecba0b033e6a64593062cf87cd6c8a66ee.diff

[PATCH] D142144: [RISCV][Driver] Add -mrvv-vector-bits= option similar to -msve-vector-bits=

craig.topper updated this revision to Diff 491935. craig.topper added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142144/new/ https://reviews.llvm.org/D142144 Files: clang/docs/ReleaseNotes.rst

[clang] 7532e88 - [Clang] Add missing requires directives for new test

Author: Joseph Huber Date: 2023-01-24T17:09:18-06:00 New Revision: 7532e88f38a417d3713cb179dc974948c30f0336 URL: https://github.com/llvm/llvm-project/commit/7532e88f38a417d3713cb179dc974948c30f0336 DIFF: https://github.com/llvm/llvm-project/commit/7532e88f38a417d3713cb179dc974948c30f0336.diff

[clang] 5d1dc9f - [OpenMP] Do not link the bitcode OpenMP runtime when targeting AMDGPU.

Author: Joseph Huber Date: 2023-01-24T17:01:37-06:00 New Revision: 5d1dc9fa043f8ee239cbc16347025a4f0831e132 URL: https://github.com/llvm/llvm-project/commit/5d1dc9fa043f8ee239cbc16347025a4f0831e132 DIFF: https://github.com/llvm/llvm-project/commit/5d1dc9fa043f8ee239cbc16347025a4f0831e132.diff

[PATCH] D142491: [OpenMP] Do not link the bitcode OpenMP runtime when targeting AMDGPU.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d1dc9fa043f: [OpenMP] Do not link the bitcode OpenMP runtime when targeting AMDGPU. (authored by jhuber6). Repository: rG LLVM Github Monorepo

[PATCH] D142506: [AMDGCN] Fix device lib test to work with lib64

scchan added a comment. In D142506#4078402 , @arsenm wrote: > The resource directory should be strictly controlled. why would lib64 ever be > used here? The intention is to eventually move the device libs into the library directory inside clang's

[PATCH] D142486: [OpenMP] Unconditionally link the OpenMP device RTL static library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc60f7aa0435: [OpenMP] Unconditionally link the OpenMP device RTL static library (authored by jhuber6). Repository: rG LLVM Github Monorepo

[clang] dc60f7a - [OpenMP] Unconditionally link the OpenMP device RTL static library

Author: Joseph Huber Date: 2023-01-24T17:01:35-06:00 New Revision: dc60f7aa0435a4e4778cfbf22f4fcb52c97427c0 URL: https://github.com/llvm/llvm-project/commit/dc60f7aa0435a4e4778cfbf22f4fcb52c97427c0 DIFF: https://github.com/llvm/llvm-project/commit/dc60f7aa0435a4e4778cfbf22f4fcb52c97427c0.diff

[clang] 1964c33 - [LinkerWrapper] Only import static libraries with needed symbols

Author: Joseph Huber Date: 2023-01-24T17:01:33-06:00 New Revision: 1964c334782e7c5961772fbdcdcc0029cba3a7fa URL: https://github.com/llvm/llvm-project/commit/1964c334782e7c5961772fbdcdcc0029cba3a7fa DIFF: https://github.com/llvm/llvm-project/commit/1964c334782e7c5961772fbdcdcc0029cba3a7fa.diff

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jhuber6 marked an inline comment as done. Closed by commit rG1964c334782e: [LinkerWrapper] Only import static libraries with needed symbols (authored by jhuber6).

[PATCH] D118493: Set rpath on openmp executables

MaskRay added a comment. In D118493#4075970 , @JonChesterfield wrote: > That works if you have one toolchain installed globally or you are happy to > cobble together a working system using environment variables. If you have > multiple toolchains, they

[PATCH] D141414: [clang] add warning on shifting boolean type

angelomatnigoogle updated this revision to Diff 491923. angelomatnigoogle added a comment. Consolidated shift-bool warning; fixed relevant unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141414/new/ https://reviews.llvm.org/D141414

[PATCH] D141959: [clang-format] Fix inconsistent identification of operator

MyDeveloperDay added a comment. There is part of me that feels we should not rush this in to get it into 16 (which was due to branch today), I feel it might be a good idea to commit this after branching, and let it live in 'main' so we can take for a real test drive CHANGES SINCE LAST ACTION

[PATCH] D140250: Define NULL in its own header

iana added inline comments. Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/sroa/unspecified-var-size.ll:37 !7 = !DIFile(filename: "clang/12.0.0/include/__stddef_max_align_t.h", directory: "/") -!8 = !DICompositeType(tag: DW_TAG_structure_type, file: !7, line: 19,

[PATCH] D142486: [OpenMP] Unconditionally link the OpenMP device RTL static library

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142486/new/ https://reviews.llvm.org/D142486

[PATCH] D142354: [analyzer] Create a stub for an std::variant checker

NoQ added a comment. Interesting, what specific goals do you have here? Are you planning to find specific bugs (eg. force-unwrap to a wrong type) or just to model the semantics? In the latter case, have you explored the possibility of force-inlining the class instead, like I suggested in the

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

tra added a comment. > I'm somewhat hoping to get this in before the fork that happens in a few > hours. OK. We can fix it later if it turns out that we've missed something. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142484/new/

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 491917. ziqingluo-90 added a comment. Addressed the minor comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139737/new/ https://reviews.llvm.org/D139737 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

jhuber6 marked an inline comment as done. jhuber6 added a comment. In D142484#4078377 , @tra wrote: > LGTM. Please wait a bit before landing it, in case @MaskRay has something to > say. I'm somewhat hoping to get this in before the fork that happens in

[PATCH] D142491: [OpenMP] Do not link the bitcode OpenMP runtime when targeting AMDGPU.

jhuber6 added a comment. In D142491#4078400 , @arsenm wrote: > Well the library still doesn't 100% work unless using -mlink-builtin-bitcode. > It's taking forever to make progress on fixing that This is the OpenMP DeviceRTL, the AMD one is still shoved

[PATCH] D142506: [AMDGCN] Fix device lib test to work with lib64

arsenm added a comment. The resource directory should be strictly controlled. why would lib64 ever be used here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142506/new/ https://reviews.llvm.org/D142506

[PATCH] D142491: [OpenMP] Do not link the bitcode OpenMP runtime when targeting AMDGPU.

arsenm added a comment. Well the library still doesn't 100% work unless using -mlink-builtin-bitcode. It's taking forever to make progress on fixing that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142491/new/ https://reviews.llvm.org/D142491

[PATCH] D142506: [AMDGCN] Fix device lib test to work with lib64

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142506/new/ https://reviews.llvm.org/D142506

[PATCH] D142506: [AMDGCN] Fix device lib test to work with lib64

scchan created this revision. scchan added reviewers: yaxunl, mgorny. Herald added subscribers: kosarev, jvesely. Herald added a project: All. scchan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change fixes an issue introduced by

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Please wait a bit before landing it, in case @MaskRay has something to say. Comment at: clang/test/Driver/linker-wrapper-libs.c:38-39 + +// LIBRARY-RESOLVES: clang{{.*}} -o

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs added a comment. > E.g., instead of asserting true/false, checking if the assignment would > compile. This is actually biased. If the result of the compilation is different from the result we get from this function, it can also mean a bug in the compiler. Take a look at this example

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 491910. isuckatcs marked 9 inline comments as done. isuckatcs added a comment. Addressed comments Updated tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files:

[PATCH] D142396: [AArch64] Add the Ampere1A core

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb0af89193a9: [AArch64] Add the Ampere1A core (authored by philipp.tomsich). Changed prior to commit:

[clang] fb0af89 - [AArch64] Add the Ampere1A core

Author: Philipp Tomsich Date: 2023-01-24T22:36:39+01:00 New Revision: fb0af89193a9ea0f92eaffb454341987f897f0c7 URL: https://github.com/llvm/llvm-project/commit/fb0af89193a9ea0f92eaffb454341987f897f0c7 DIFF:

[PATCH] D139454: [CMake] Replace clang binary if using clang-bolt target

Amir added a comment. Ping @phosek @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139454/new/ https://reviews.llvm.org/D139454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

scott.linder added a comment. In D142499#4078177 , @arsenm wrote: > Making this target specific doesn’t make sense I don't know how else to resolve others wanting the default to be the `CGOptLevel = clamp(ltoOptLevel, 2, 3)` behavior and AMDGPU wanting

[clang] 25b03ae - Fix C++11 warnings in RangeSetTest.cpp

Author: Philipp Tomsich Date: 2023-01-24T22:13:44+01:00 New Revision: 25b03ae78ff368f77d548fddea327f3b802799f3 URL: https://github.com/llvm/llvm-project/commit/25b03ae78ff368f77d548fddea327f3b802799f3 DIFF:

[PATCH] D142439: Fix C++11 warnings in RangeSetTest.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25b03ae78ff3: Fix C++11 warnings in RangeSetTest.cpp (authored by philipp.tomsich). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142501: [clang][deps] Fix modulemap file path for implementation of module

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/ClangScanDeps/modules-implementation-vfs.m:67-68 +#import +struct A { float x; }; // expected-error {{incompatible definitions}}

[PATCH] D140250: Define NULL in its own header

dblaikie added inline comments. Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/sroa/unspecified-var-size.ll:37 !7 = !DIFile(filename: "clang/12.0.0/include/__stddef_max_align_t.h", directory: "/") -!8 = !DICompositeType(tag: DW_TAG_structure_type, file: !7, line:

[PATCH] D141717: [Clang] Only emit textual LLVM-IR in device only mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd50dacd7c3c2: [Clang] Only emit textual LLVM-IR in device only mode (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] d50dacd - [Clang] Only emit textual LLVM-IR in device only mode

Author: Joseph Huber Date: 2023-01-24T15:11:30-06:00 New Revision: d50dacd7c3c2ce489df6ed1ccde71bba390fe5e2 URL: https://github.com/llvm/llvm-project/commit/d50dacd7c3c2ce489df6ed1ccde71bba390fe5e2 DIFF: https://github.com/llvm/llvm-project/commit/d50dacd7c3c2ce489df6ed1ccde71bba390fe5e2.diff

[PATCH] D142501: [clang][deps] Fix modulemap file path for implementation of module

benlangmuir marked an inline comment as done. benlangmuir added inline comments. Comment at: clang/test/ClangScanDeps/modules-implementation-vfs.m:67-68 +#import +struct A { float x; }; // expected-error {{incompatible definitions}} expected-note {{type 'float' here}} +//

[PATCH] D142454: [analyzer] Update satest dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa037b85f3097: [analyzer] Update satest dependencies (authored by manas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a037b85 - [analyzer] Update satest dependencies

Author: Manas Date: 2023-01-25T02:37:16+05:30 New Revision: a037b85f30970cb2dc51e8ab66f2e157bfb28c19 URL: https://github.com/llvm/llvm-project/commit/a037b85f30970cb2dc51e8ab66f2e157bfb28c19 DIFF: https://github.com/llvm/llvm-project/commit/a037b85f30970cb2dc51e8ab66f2e157bfb28c19.diff LOG:

[PATCH] D142501: [clang][deps] Fix modulemap file path for implementation of module

benlangmuir updated this revision to Diff 491886. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142501/new/ https://reviews.llvm.org/D142501 Files: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp clang/test/ClangScanDeps/modules-implementation-vfs.m Index:

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

arsenm added a comment. Making this target specific doesn’t make sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142499/new/ https://reviews.llvm.org/D142499 ___ cfe-commits mailing list

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f02ad880e42: [analyzer][solver] Improve reasoning for not equal to operator (authored by manas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140086/new/

[clang] 5f02ad8 - [analyzer][solver] Improve reasoning for not equal to operator

Author: Manas Date: 2023-01-25T02:32:55+05:30 New Revision: 5f02ad880e423a33f903299f0123e9d8a59bbe8d URL: https://github.com/llvm/llvm-project/commit/5f02ad880e423a33f903299f0123e9d8a59bbe8d DIFF: https://github.com/llvm/llvm-project/commit/5f02ad880e423a33f903299f0123e9d8a59bbe8d.diff LOG:

[PATCH] D142484: [LinkerWrapper] Only import static libraries with needed symbols

jhuber6 updated this revision to Diff 491883. jhuber6 added a comment. Adding test and making the logic a bit more readable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142484/new/ https://reviews.llvm.org/D142484 Files:

[clang] 8700bee - Revert "[15/15][Clang][RISCV][NFC] Set data member under Policy as constants"

Author: Douglas Yung Date: 2023-01-24T12:59:15-08:00 New Revision: 8700beee9367fdf95d146c810855125a51006063 URL: https://github.com/llvm/llvm-project/commit/8700beee9367fdf95d146c810855125a51006063 DIFF: https://github.com/llvm/llvm-project/commit/8700beee9367fdf95d146c810855125a51006063.diff

[PATCH] D142501: [clang][deps] Fix modulemap file path for implementation of module

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/modules-implementation-vfs.m:67-68 +#import +struct A { float x; }; // expected-error {{incompatible definitions}} expected-note {{type 'float' here}} +//

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

scott.linder added reviewers: arsenm, yaxunl, scchan, pcc, MaskRay, mehdi_amini, respindola, ruiu, aheejin, sbc100. scott.linder added a comment. (Just adding everyone from the parent review, feel free to remove yourself as reviewer if you aren't interested!) It isn't ideal, but as only AMDGCN

[PATCH] D141959: [clang-format] Fix inconsistent identification of operator

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a reviewer: rymiel. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Looks good to me, but please wait until another one has given their blessing, or at least no veto for a few days. CHANGES

[PATCH] D142501: [clang][deps] Fix modulemap file path for implementation of module

benlangmuir created this revision. benlangmuir added a reviewer: jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use the name "as requested" for the path of the implemented module's

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3592-3601 case tok::kw_bool: // bool is only allowed if it is directly followed by a paren for a cast: // concept C =

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

scott.linder created this revision. Herald added subscribers: kosarev, inglorion, tpr, dstuttard, yaxunl, kzhuravl. Herald added a project: All. scott.linder requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, wdng. Herald added a project: clang. For AMDGCN default

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

aaron.ballman added inline comments. Comment at: clang/test/Frontend/sarif-diagnostics.cpp:8 +// Omit filepath to llvm project directory +// CHECK:

[clang] 0647f4a - Drop a path component from the sarif diagnostics test; NFC

Author: Aaron Ballman Date: 2023-01-24T15:37:53-05:00 New Revision: 0647f4a77a2f9aab84c961982193bea1a9eb1585 URL: https://github.com/llvm/llvm-project/commit/0647f4a77a2f9aab84c961982193bea1a9eb1585 DIFF: https://github.com/llvm/llvm-project/commit/0647f4a77a2f9aab84c961982193bea1a9eb1585.diff

  1   2   3   4   >