[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

Backl1ght added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3891 + * ``PCIS_OnlyNextLine`` (in configuration: ``OnlyNextLine``) +Put all constructor initializers on the next line if they fit. @HazardyKnusperkeks Maybe I

[PATCH] D143025: [Fuchsia] Add llvm-mt and llvm-rc to clang bootstrap dependency

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM but can you update the change title and description since the original one no longer matches the content of the patch. Comment at: clang/CMakeLists.txt:599-600 + if

[clang] 16749d2 - [Driver] Remove deprecated -fsanitize-system-blacklist=

Author: Fangrui Song Date: 2023-02-03T22:06:34-08:00 New Revision: 16749d28cc56b441dc252f7017fbf532ea41f8c4 URL: https://github.com/llvm/llvm-project/commit/16749d28cc56b441dc252f7017fbf532ea41f8c4 DIFF: https://github.com/llvm/llvm-project/commit/16749d28cc56b441dc252f7017fbf532ea41f8c4.diff

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

tahonermann added a comment. > Incidentally, it looks like that LSI copy > (https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/TreeTransform.h#L13469-L13478) > has not been needed since commit bf5fe2dbba0899bee4323f5eaa075acc43a18e2e > (see >

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

MaskRay added a comment. No test probably makes this easy to back port. Eventually there needs to be a test but the original author can do it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143306/new/ https://reviews.llvm.org/D143306

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

MaskRay created this revision. MaskRay added reviewers: jdoerfert, jhuber6, JonChesterfield, tstellar. Herald added subscribers: guansong, yaxunl. Herald added a project: All. MaskRay requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[PATCH] D143305: [clang] Fix -Xarch_ for -mllvm and alike

yaxunl created this revision. yaxunl added reviewers: tra, MaskRay. Herald added a subscriber: hiraditya. Herald added a project: All. yaxunl requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, sstefan1. Herald added a project: LLVM.

[PATCH] D143304: [Coverage] Map regions from system headers

gulfem created this revision. Herald added a project: All. gulfem requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Originally, the following commit removed mapping coverage regions for system headers:

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

void updated this revision to Diff 494772. void added a comment. Move test and improve checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143300/new/ https://reviews.llvm.org/D143300 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

MaskRay added inline comments. Comment at: clang/test/Sema/init-randomized-struct-fwd-decl.c:23 + +// CHECK-LABEL: t1 +// CHECK: getelementptr inbounds %struct.foo, ptr %0, i32 0, i32 2 `// CHECK-LABEL: define {{.*}} @t1(` is less likely to cause a conflict with

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

MaskRay added a comment. The test appears to belong to test/CodeGen instead of test/Sema ? Mixed 8-column and 2-column indentation probably should be unified. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143300/new/

[PATCH] D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b8daee028a8: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced (authored by bruno). Repository: rG LLVM Github Monorepo

[clang] 0b8daee - [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced

Author: Bruno Cardoso Lopes Date: 2023-02-03T15:37:29-08:00 New Revision: 0b8daee028a87ab8a6f8fe54d2eb2d5b5c2babd4 URL: https://github.com/llvm/llvm-project/commit/0b8daee028a87ab8a6f8fe54d2eb2d5b5c2babd4 DIFF:

[PATCH] D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced

bruno added a comment. Only test failing is `ClangScanDeps/modules-full.cpp` on Windoes, which is unrelated to this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142077/new/ https://reviews.llvm.org/D142077 ___ cfe-commits mailing

[PATCH] D143025: [Fuchsia] Add llvm-mt and llvm-rc to clang bootstrap dependency

haowei marked 2 inline comments as done. haowei added inline comments. Comment at: clang/cmake/caches/Fuchsia.cmake:170-171 runtimes + llvm-rc + llvm-mt CACHE STRING "") phosek wrote: > Could we do this in >

[PATCH] D143300: [randstruct] Don't allow implicit forward decl to stop struct randomization

void created this revision. void added reviewers: aaron.ballman, MaskRay, nickdesaulniers. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a struct/enum type used in a record doesn't have a forward decl

[PATCH] D143025: [Fuchsia] Add llvm-mt and llvm-rc to clang bootstrap dependency

haowei updated this revision to Diff 494755. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143025/new/ https://reviews.llvm.org/D143025 Files: clang/CMakeLists.txt Index: clang/CMakeLists.txt

[PATCH] D138337: Add support for kcfi-seal optimization with LTO

samitolvanen updated this revision to Diff 494756. samitolvanen added a comment. This revision is now accepted and ready to land. Herald added subscribers: ormris, steven_wu. Don't drop type hashes from VisibleToRegularObj symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D143027: [clang][deps] Fix module context hash for constant strings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG223e99fb698d: [clang][deps] Fix module context hash for constant strings (authored by benlangmuir). Changed prior to commit:

[clang] 223e99f - [clang][deps] Fix module context hash for constant strings

Author: Ben Langmuir Date: 2023-02-03T15:10:19-08:00 New Revision: 223e99fb698dd63b5bb9266e11c2582261e05ad9 URL: https://github.com/llvm/llvm-project/commit/223e99fb698dd63b5bb9266e11c2582261e05ad9 DIFF: https://github.com/llvm/llvm-project/commit/223e99fb698dd63b5bb9266e11c2582261e05ad9.diff

[clang] d46d44e - [Tooling/Inclusion] qualifed_name() => qualifiedName(), NFC

Author: Haojian Wu Date: 2023-02-04T00:08:45+01:00 New Revision: d46d44e3c4a6f1f980f595386fc7ddd03c1f3fcd URL: https://github.com/llvm/llvm-project/commit/d46d44e3c4a6f1f980f595386fc7ddd03c1f3fcd DIFF: https://github.com/llvm/llvm-project/commit/d46d44e3c4a6f1f980f595386fc7ddd03c1f3fcd.diff

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

craig.topper added a comment. We have a couple bugs that show (freeze (poison)) doesn't work past SelectionDAG. Is that a concern here? The most recent https://github.com/llvm/llvm-project/issues/60429 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced

bruno updated this revision to Diff 494740. bruno added a comment. Update checks that rely on `coroutine_traits` in `std-coroutine.h` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142077/new/ https://reviews.llvm.org/D142077 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

jkorous added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:703 + case Strategy::Kind::Span: +return FixItList{}; + case Strategy::Kind::Wontfix: jkorous wrote: > jkorous wrote: > > I am afraid I might have found one

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

jkorous added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:703 + case Strategy::Kind::Span: +return FixItList{}; + case Strategy::Kind::Wontfix: jkorous wrote: > I am afraid I might have found one more problem :( > I

[PATCH] D141338: [-Wunsafe-buffer-usage] Filter out conflicting fix-its

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great! Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:961 +// a fix-it overlaps with macros; or +// a fix-it conflicts with another one +if

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. As far as I'm concerned, I think this is great for the initial implementation! Let's commit as soon as Jan confirms that his problem is addressed. Comment at:

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

void added inline comments. Comment at: clang/include/clang/AST/Designator.h:88 + /// An array designator, e.g., "[42] = 0" and "[42 ... 50] = 1". + template struct ArrayDesignatorInfo { +/// Location of the first and last index expression within the designated

[PATCH] D142991: [clang-tidy] Add --fix-mode and --nolint-prefix options

KyleFromKitware added a comment. Though I did find that it inserted more than one `NOLINT` comment for a templated function, probably due to multiple warnings being issued for the same violation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142991/new/

[PATCH] D142991: [clang-tidy] Add --fix-mode and --nolint-prefix options

KyleFromKitware added a comment. I just tried this out on a somewhat larger scale - I built all of CMake with this flag enabled, and it found a number of clang-tidy violations and added `NOLINT` comments to silence them. Worked like a charm. CHANGES SINCE LAST ACTION

[PATCH] D143288: [Fuchsia] Simplified the stage2 build setup

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143288/new/ https://reviews.llvm.org/D143288

[PATCH] D142948: [OpenCL] Disable vector to scalar types coercion for OpenCL

rjmccall added a comment. Does the x86 backend lower these small vectors to the same ABI? If so, I think we could just teach Clang unconditionally that it doesn't need this coercion on x86 targets. If not, this is an ABI break; are you sure that's okay? Repository: rG LLVM Github Monorepo

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

rjmccall added a comment. In D79378#4101935 , @shiva0217 wrote: > In D79378#4101829 , @rjmccall wrote: > >> In D79378#4101613 , @shiva0217 >> wrote: >> >>> Hi, >>> >>> I

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

rsmith accepted this revision. rsmith added a comment. I think this is fine as a short-term stepping stone to a different representation. Comment at: clang/include/clang/AST/Designator.h:88 + /// An array designator, e.g., "[42] = 0" and "[42 ... 50] = 1". + template

[PATCH] D143128: [-Wunsafe-buffer-usage][WIP] Fix-Its transforming `[any]` to `DRE.data() + any`

ziqingluo-90 updated this revision to Diff 494711. ziqingluo-90 retitled this revision from "[-Wunsafe-buffer-usage][WIP] Fix-Its transforming `[*]` to `DRE.data() + *`" to "[-Wunsafe-buffer-usage][WIP] Fix-Its transforming `[any]` to `DRE.data() + any`". ziqingluo-90 edited the summary of this

[PATCH] D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced

bruno added a comment. Thanks for the review, will push once all tests pass! Comment at: clang/lib/Sema/SemaChecking.cpp:15186 + if (ChildExpr == CSE->getOperand()) +// Do not recurse over a CoroutineSuspendExpr's operand. +// The operand is also a

[PATCH] D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced

bruno updated this revision to Diff 494707. bruno added a comment. Update patch to reuse `std-coroutine.h` and add a few more other bits there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142077/new/ https://reviews.llvm.org/D142077 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D142948: [OpenCL] Disable vector to scalar types coercion for OpenCL

Anastasia added a comment. It doesn't seem to make sense to have a `LangOpt` for this, if anything a new `CodeGenOpt` feels like a better fit. Then you should probably extend existing classify functions to prevent coercion instead of adding yet another function otherwise you will need to

[PATCH] D142384: [C++20] Fix a crash with modules.

rsmith added a comment. In D142384#4102937 , @hans wrote: > I don't know if that's expected or not, but maybe that behavior change could > be used as an inspiration for a test case. At least this suggests a way to test this with a C++ unit test: get a

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142499/new/ https://reviews.llvm.org/D142499 ___ cfe-commits mailing list

[PATCH] D142499: [Clang][AMDGPU] Set LTO CG opt level based on Clang option

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Fine with me, but you may need an AMDGPU reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142499/new/ https://reviews.llvm.org/D142499

[PATCH] D142891: [clang-format] Recognize Verilog non-blocking assignment

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Looks ok to me. Please wait for some other opinion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142891/new/

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

HazardyKnusperkeks added a comment. In D143091#4099585 , @Backl1ght wrote: > In D143091#4097534 , > @HazardyKnusperkeks wrote: > >> An entry in the changelog would be nice. > > It is already added I think. I

[PATCH] D143288: [Fuchsia] Simplified the stage2 build setup

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch simplified the BOOTSTRAP_ flags, allowing

[PATCH] D140179: [-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas

ziqingluo-90 updated this revision to Diff 494693. ziqingluo-90 added a comment. Change the fix-it test style CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140179/new/ https://reviews.llvm.org/D140179 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h

[PATCH] D142867: [Clang] Add machinery to catch overflow in unary minus outside of a constant expression context

hans added a comment. Amusingly this fired on some code that used negation with the intention of getting fewer warnings: https://github.com/KhronosGroup/glslang/commit/866f67140ed98865350b53312bba1b654b59f937 :-) Fixed in

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 494689. ziqingluo-90 added a comment. address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139737/new/ https://reviews.llvm.org/D139737 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito created this revision. ManuelJBrito added reviewers: craig.topper, RKSimon. Herald added subscribers: pengfei, mgrang. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The following

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

phosek accepted this revision. phosek added a comment. LGTM Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:95 +# and remove these libpath flags. +-libpath:"${LLVM_WINSYSROOT}/VC/Tools/MSVC/14.34.31933/lib/x64" +

[PATCH] D143025: [Fuchsia] Add llvm-mt and llvm-rc to clang bootstrap dependency

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia.cmake:20-46 +# Passthrough stage1 flags to stage1. +set(_FUCHSIA_BOOTSTRAP_PASSTHROUGH + LLVM_ENABLE_ZLIB + ZLIB_INCLUDE_DIR + ZLIB_LIBRARY + LLVM_ENABLE_ZSTD + zstd_DIR Could we move this

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xbolva00 requested changes to this revision. xbolva00 added a comment. This revision now requires changes to proceed. Huge code duplication. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609

[clang] 3de55e6 - Fix tests commited in 450a461

Author: ManuelJBrito Date: 2023-02-03T17:52:23Z New Revision: 3de55e6b0e7faf374510aa469aafbf3fba7c848e URL: https://github.com/llvm/llvm-project/commit/3de55e6b0e7faf374510aa469aafbf3fba7c848e DIFF: https://github.com/llvm/llvm-project/commit/3de55e6b0e7faf374510aa469aafbf3fba7c848e.diff LOG:

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

KyleFromKitware updated this revision to Diff 494675. KyleFromKitware added a comment. Added virtual destructor to `HeaderGuardStyle`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142673/new/ https://reviews.llvm.org/D142673 Files: clang-tools-extra/clang-tidy/ClangTidyModule.h

[PATCH] D138802: [clang][Interp] Implement DecompositionDecls

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:34-35 + virtual ~DeclScope() override { this->emitDestruction(); } + void addExtended(const Scope::Local ) override {

[PATCH] D140999: [NFC][TargetParser] Remove llvm/Support/AArch64TargetParser.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c712296fb75: [NFC][TargetParser] Remove llvm/Support/AArch64TargetParser.h (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140999/new/

[clang] 8c71229 - [NFC][TargetParser] Remove llvm/Support/AArch64TargetParser.h

Author: Archibald Elliott Date: 2023-02-03T17:34:01Z New Revision: 8c712296fb75ff73db08f92444b35c438c01a405 URL: https://github.com/llvm/llvm-project/commit/8c712296fb75ff73db08f92444b35c438c01a405 DIFF: https://github.com/llvm/llvm-project/commit/8c712296fb75ff73db08f92444b35c438c01a405.diff

[PATCH] D142384: [C++20] Fix a crash with modules.

hans added a comment. It looks like this is making one of Chromium's clang plugins traverse (and flag) more code: https://bugs.chromium.org/p/chromium/issues/detail?id=1412769 No modules involved :) I don't know if that's expected or not, but maybe that behavior change could be used as an

[PATCH] D142123: [clang-tidy] Add header guard style to suggest use of #pragma once

KyleFromKitware added a comment. CI on all seven commits in this stack looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142123/new/ https://reviews.llvm.org/D142123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143280: [include-mapping] Better #includes support for std input/output symbols

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D143280 Files:

[PATCH] D142123: [clang-tidy] Add header guard style to suggest use of #pragma once

aaron.ballman added a comment. LGTM assuming precommit CI doesn't discover any surprises, but hopefully @njames93 or @carlosgalvezp can weigh in as well since they've been in this code more recently than I have. Comment at:

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

aaron.ballman added a comment. In D127762#4102578 , @erichkeane wrote: > By standard imp-limits, apparently we only need to handle 8 bits worth for > the Exception Spec types. I'd be tempted, based on exception specs being > deprecated and rarely

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added a comment. In D124351#4102818 , @rupprecht wrote: > In D124351#4102679 , @aaron.ballman > wrote: > >> In D124351#4102634 , @eaeltsin >> wrote: >>

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

rupprecht added a comment. In D124351#4102679 , @aaron.ballman wrote: > In D124351#4102634 , @eaeltsin > wrote: > >>> Looks like we fail to enter the appropriate context somewhere (my guess is >>> that it

[clang] 74ce297 - Revert "[Clang] Implement Change scope of lambda trailing-return-type"

Author: Jordan Rupprecht Date: 2023-02-03T08:49:34-08:00 New Revision: 74ce297045bac4bc475b8e762d2a1ea19bb16d3c URL: https://github.com/llvm/llvm-project/commit/74ce297045bac4bc475b8e762d2a1ea19bb16d3c DIFF:

[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6654 +def warn_comp_op_in_comp_op : Warning< + "'%0' within '%1'">, InGroup, DefaultIgnore; +def warn_rel_op_in_rel_op : Warning< Spit-balling wording ideas:

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

balazske added a comment. I looked at some of the failing tests but can not decide how to fix the problems. The problem seems to be with the extra `namespace std` that was not there before. I do not know what the tests are exactly testing. A part of the tests can be fixed by adding new expect

[PATCH] D137070: [clang][Interp] Support destructors

tbaeder updated this revision to Diff 494660. tbaeder marked an inline comment as done. tbaeder added a comment. No surprises I think. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137070/new/ https://reviews.llvm.org/D137070 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp

[PATCH] D143274: [clangd] Remove the direct use of StdSymbolMapping.inc usage.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: arphaman, mgrang. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Replace them with the

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

This revision was automatically updated to reflect the committed changes. Closed by commit rG1285172c21ef: [include-mapping] Implement language separation in stdlib recognizer library (authored by VitaNuo, committed by hokein). Changed prior to commit:

[PATCH] D137070: [clang][Interp] Support destructors

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM assuming no surprises with the new test request. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1915-1916 + +if (const CXXDestructorDecl *Dtor =

[clang] 1285172 - [include-mapping] Implement language separation in stdlib recognizer library

Author: Viktoriia Bakalova Date: 2023-02-03T17:05:25+01:00 New Revision: 1285172c21ef4867d9f895c0b2ab0f338c46e36f URL: https://github.com/llvm/llvm-project/commit/1285172c21ef4867d9f895c0b2ab0f338c46e36f DIFF:

[PATCH] D142123: [clang-tidy] Add header guard style to suggest use of #pragma once

KyleFromKitware updated this revision to Diff 494653. KyleFromKitware added a comment. Removed comma from documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142123/new/ https://reviews.llvm.org/D142123 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D142123: [clang-tidy] Add header guard style to suggest use of #pragma once

KyleFromKitware updated this revision to Diff 494652. KyleFromKitware added a comment. Updated documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142123/new/ https://reviews.llvm.org/D142123 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D142123: [clang-tidy] Add header guard style to suggest use of #pragma once

KyleFromKitware added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/ReadabilityModuleTest.cpp:569-571 +runPragmaOnceCheck("#ifndef BOTH_H\n" + "#define BOTH_H\n" + "#pragma once\n"

[PATCH] D142123: [clang-tidy] Add header guard style to suggest use of #pragma once

KyleFromKitware updated this revision to Diff 494650. KyleFromKitware added a comment. Updated with review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142123/new/ https://reviews.llvm.org/D142123 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

KyleFromKitware updated this revision to Diff 494649. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142673/new/ https://reviews.llvm.org/D142673 Files: clang-tools-extra/clang-tidy/ClangTidyModule.h clang-tools-extra/clang-tidy/llvm/CMakeLists.txt

[PATCH] D142471: [pp-trace] Add PragmaOnce callback

KyleFromKitware updated this revision to Diff 494648. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142471/new/ https://reviews.llvm.org/D142471 Files: clang-tools-extra/pp-trace/PPCallbacksTracker.cpp clang-tools-extra/pp-trace/PPCallbacksTracker.h

[PATCH] D142470: [clang][lex] Add PragmaOnce callback to PPCallbacks

KyleFromKitware updated this revision to Diff 494647. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142470/new/ https://reviews.llvm.org/D142470 Files: clang/include/clang/Lex/PPCallbacks.h clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/Pragma.cpp Index:

[PATCH] D142030: [pp-trace] Print HashLoc/Introducer parameter

KyleFromKitware updated this revision to Diff 494646. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142030/new/ https://reviews.llvm.org/D142030 Files: clang-tools-extra/docs/pp-trace.rst clang-tools-extra/pp-trace/PPCallbacksTracker.cpp

[PATCH] D142465: [clang][lex] Consolidate PPCallbacks::PragmaDirective parameters

KyleFromKitware updated this revision to Diff 494644. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142465/new/ https://reviews.llvm.org/D142465 Files: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.h

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added a comment. In D124351#4102634 , @eaeltsin wrote: >> Looks like we fail to enter the appropriate context somewhere (my guess is >> that it might be specific to the attribute but it's hard to say without >> picking around), definitely

[PATCH] D140874: [clang][Interp] Support pointer types in compound assignment operations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a2c4acb9869: [clang][Interp] Support pointers in compound assignment operators (authored by tbaeder). Changed prior to commit:

[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

erichkeane added a comment. I'm reasonably happy here. I think the chained-comparisons getting the && suggestion is nice. However in each case, the diagnostic is REALLY poor. It isn't really clear to most folks (barely clear to me!) that `'<' within '>'` really means anything. I'd love if

[clang] 4a2c4ac - [clang][Interp] Support pointers in compound assignment operators

Author: Timm Bäder Date: 2023-02-03T16:42:46+01:00 New Revision: 4a2c4acb98694bb90c04e05052898708a03a7ebc URL: https://github.com/llvm/llvm-project/commit/4a2c4acb98694bb90c04e05052898708a03a7ebc DIFF: https://github.com/llvm/llvm-project/commit/4a2c4acb98694bb90c04e05052898708a03a7ebc.diff

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:13611-13653 if (RHS.get()->EvaluateAsInt(EVResult, Context)) { llvm::APSInt Result = EVResult.Val.getInt(); if ((getLangOpts().Bool && !RHS.get()->getType()->isBooleanType() &&

[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

hazohelet updated this revision to Diff 494635. hazohelet added a comment. Address comments from erichkeane: - Fix comment wording - Avoid using macro in test file Implement my proposal for fix-it hint: - In the case of chained relational operators (`<`, `>`, `<=`, `>=`), suggest adding `&&`.

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

eaeltsin added a comment. > Looks like we fail to enter the appropriate context somewhere (my guess is > that it might be specific to the attribute but it's hard to say without > picking around), definitely a bug > > I'll be away the next 2 weeks, I'll look at it when I get back. Maybe we >

[clang] 5059193 - Revert "[clang][Interp] Only generate disassembly in debug builds"

Author: Timm Bäder Date: 2023-02-03T16:24:04+01:00 New Revision: 50591936a1befc44f2853f1a6493ee1ef2afaa6e URL: https://github.com/llvm/llvm-project/commit/50591936a1befc44f2853f1a6493ee1ef2afaa6e DIFF: https://github.com/llvm/llvm-project/commit/50591936a1befc44f2853f1a6493ee1ef2afaa6e.diff

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta updated this revision to Diff 494631. xgupta added a comment. remov blank Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/lib/Sema/SemaExpr.cpp clang/test/C/drs/dr4xx.c

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta updated this revision to Diff 494629. xgupta added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/lib/Sema/SemaExpr.cpp Index: clang/lib/Sema/SemaExpr.cpp

[clang] 0bf5845 - [Tooling/Inclusions] ensure the Mapping is inititalized in

Author: Haojian Wu Date: 2023-02-03T16:10:05+01:00 New Revision: 0bf58458d31e238b4ae850e2a0d934190c6682cc URL: https://github.com/llvm/llvm-project/commit/0bf58458d31e238b4ae850e2a0d934190c6682cc DIFF: https://github.com/llvm/llvm-project/commit/0bf58458d31e238b4ae850e2a0d934190c6682cc.diff

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

erichkeane added a comment. In D127762#4102526 , @aaron.ballman wrote: > In D127762#4102436 , @erichkeane > wrote: > >> Finally, and this is something @aaron.ballman probably wants to answer: Is >> this

[clang] a7f3bca - [clang][Interp][NFCI] Handle DiscardResult for ExprWithCleanups

Author: Timm Bäder Date: 2023-02-03T16:07:14+01:00 New Revision: a7f3bcaa8409f67e604bcbe22a960f54ebc657ef URL: https://github.com/llvm/llvm-project/commit/a7f3bcaa8409f67e604bcbe22a960f54ebc657ef DIFF: https://github.com/llvm/llvm-project/commit/a7f3bcaa8409f67e604bcbe22a960f54ebc657ef.diff

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

aaron.ballman added a comment. In D127762#4102436 , @erichkeane wrote: > Finally, and this is something @aaron.ballman probably wants to answer: Is > this sufficiently important that we're willing to take the additional > overhead of 8 bits for each

[PATCH] D142123: [clang-tidy] Add header guard style to suggest use of #pragma once

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/header-guard.rst:31 + Use ``#pragma once`` instead of macro guards. Note that ``#pragma once`` + is not part of the C++ standard, and may not work correctly in all

[PATCH] D142694: [clang][Interp] Only generate disassembly in debug builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60dcc70e48fa: [clang][Interp] Only generate disassembly in debug builds (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 60dcc70 - [clang][Interp] Only generate disassembly in debug builds

Author: Timm Bäder Date: 2023-02-03T15:40:25+01:00 New Revision: 60dcc70e48fa9814a4e0d5e12856bc88b7f927eb URL: https://github.com/llvm/llvm-project/commit/60dcc70e48fa9814a4e0d5e12856bc88b7f927eb DIFF: https://github.com/llvm/llvm-project/commit/60dcc70e48fa9814a4e0d5e12856bc88b7f927eb.diff

[PATCH] D142694: [clang][Interp] Only generate disassembly in debug builds

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142694/new/ https://reviews.llvm.org/D142694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 0505c0b - [clang][Interp][NFC] Make VariableScope::getParent() const

Author: Timm Bäder Date: 2023-02-03T15:35:42+01:00 New Revision: 0505c0b8cc998399979fcb970634dc8ee974dc7d URL: https://github.com/llvm/llvm-project/commit/0505c0b8cc998399979fcb970634dc8ee974dc7d DIFF: https://github.com/llvm/llvm-project/commit/0505c0b8cc998399979fcb970634dc8ee974dc7d.diff

[PATCH] D142992: [include-mapping] Implement language separation in stdlib recognizer library

hokein updated this revision to Diff 494611. hokein added a comment. rebase to main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142992/new/ https://reviews.llvm.org/D142992 Files: clang/include/clang/Tooling/Inclusions/StandardLibrary.h

  1   2   >